GitLab

Other visual changes coming in later CLs

Bug: 820648
Change-Id: I1ac47a4f45af906cf1ba53f3304dd2d55bc1c684
Reviewed-on: https://chromium-review.googlesource.com/959145
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544159}

This reverts commit 23aafba1.

Reason for revert: Started failing CTS tests across all WebView platforms:
android.webkit.cts.WebViewTest#testRequestImageRef
android.webkit.cts.WebViewTest#testLoadDataWithBaseUrl

Original change's description:
> [url] Properly treat '#' as marking the start of the fragment in data URIs
> 
> This CL aligns Chromium with the URL spec, such that we consider '#' to
> mark the end of the content and the start of the fragment section only.
> GURL::GetContent was updated to reflect this, with a special case for
> javascript URLs specifically (as their spec mentions including '#' in the
> URL content).
> 
> Bug: 123004
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: I49c6f4d739a2dd42eecc9947f8e75071b84e9be7
> 
> TBR: boliu@chromium.org, pfeldman@chromium.org, thakis@chromium.org
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: I49c6f4d739a2dd42eecc9947f8e75071b84e9be7
> Reviewed-on: https://chromium-review.googlesource.com/738395
> Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Reviewed-by: David Benjamin <davidben@chromium.org>
> Reviewed-by: Brett Wilson <brettw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#544065}

TBR=davidben@chromium.org,thakis@chromium.org,brettw@chromium.org,boliu@chromium.org,msarda@chromium.org,pfeldman@chromium.org,eugenebut@chromium.org,mkwst@chromium.org,smcgruer@chromium.org

Change-Id: Ib4cd66e4eae27a4868654e305796b98a7734ce20
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 123004
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/969189Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544158}

Remove dependency to blink in ash/
Define ash own orientation lock type so that
exo can set the orientation w/o depending on blink.

Bug: 735078
Test: None
Change-Id: Ie11e1716cf6e657dd6899d05a2f1921cace17980
Reviewed-on: https://chromium-review.googlesource.com/967721
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544157}

This is towards being able to host RWHVCocoa in another process (though
it is worth doing on its on merits, as the source files are getting far
too heavy).

Bug: 821651
Change-Id: Id379e21defdf0b5e68eab96d1463a7972f2e9b20
Reviewed-on: https://chromium-review.googlesource.com/969404Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544156}

This is a builder on the "chromium.linux" master which builds twice
and then ensures the two builds are the same.

Bug: 790123
Change-Id: I6599363cb89a516710a2b3cd3e5d0f1e3388675c
Reviewed-on: https://chromium-review.googlesource.com/969144Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544155}

Bug: 818520
Change-Id: Id9a9c289a29ab9b1ccef5eff4f0019bb47363866
Reviewed-on: https://chromium-review.googlesource.com/969452Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544154}

Some types of Target.detachedFromTarget events do not have a
targetId. This causes an error in ChromeDriver while processing
such events, and also leaves the internal data in an inconsistent
state, causing a crash later on.

This is fixed by ignoring Target.detachedFromTarget events without
a targetId. Also added code to prevent inconsistent data structure
when event processing fails, to avoid crashes.

Bug: chromedriver:2340
Change-Id: I8b6292584939cd921784eea0483c86c1a2765cec
Reviewed-on: https://chromium-review.googlesource.com/969325Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544153}

This change removes the unused NetLog and NetLogSource from
BluetoothDeviceWin and adds a few missing #includes.

Bug: 821766
Change-Id: I74e0f888398ced801072f25e8d90a8e338dc8e79
Reviewed-on: https://chromium-review.googlesource.com/968513
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544152}

Change-Id: I925ed0cbfc574e09d45b834258026963fade6794
Reviewed-on: https://chromium-review.googlesource.com/965617Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544151}

This CL fixes a crasher introduced by nano to lite transition.

Bug: 822845
Change-Id: Id130f29a85cddf1e77b7fd34f1254503f7865f5c
Reviewed-on: https://chromium-review.googlesource.com/968868Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544150}

Skipping CQ due to timeout failures. See the bug for more info.

No-Try: true
Bug: 821544
Change-Id: I16e9363afa44fdde5fd67391e118bca94440af5b
Reviewed-on: https://chromium-review.googlesource.com/967426
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544149}

This reverts commit 0465b7fe.

Reason for revert: Breaks compile on IOS bots.

Original change's description:
> ui: Add FrameMetrics histogram helpers.
> 
> Adds a Histogram interface with two implementations. One for
> ratios with most of it's precision just above 1 and another
> for latency with higher precision near vsync intervals.
> 
> The Histogram can be queried for approximate percentiles,
> which will be useful for UKM based frame metrics.
> 
> Bug: 807463
> Change-Id: Ic50ce19eeb1804063628c09cbd1e0c30afbfd930
> Reviewed-on: https://chromium-review.googlesource.com/952534
> Commit-Queue: Brian Anderson <brianderson@chromium.org>
> Reviewed-by: Timothy Dresser <tdresser@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#544119}

TBR=sadrul@chromium.org,brianderson@chromium.org,tdresser@chromium.org

Change-Id: I9a706e7b936abb90e6856d983d550a9272f74e24
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 807463, 823437
Reviewed-on: https://chromium-review.googlesource.com/969226Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544148}

viz_content_browsertests has stabilized. Due to this we no longer need a
separate filter for the FYI bots to first try out new tests for flakes. So I am
removing the FYI filter file. (We are already not using FYI filters for the
other viz tests)

This change updates the viz.content_browsertests.filter file with the
remaining differences from the FYI filter. Then removes the fyi one. Updating
the test configs to use the full one

TEST=viz_content_browsertests

Bug: 760181
Change-Id: I949f0e74974f9f9cd847323e97c99d9a0b403b81
Reviewed-on: https://chromium-review.googlesource.com/968703Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544147}

Some bots build this apparently.

No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: Ib1efbbc14a982d5848ad6cfaa029be1f7f5bcfcf
Reviewed-on: https://chromium-review.googlesource.com/969149Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544146}

https://skia.googlesource.com/skia.git/+log/c9a642edf2d1..cb88470d82d6

$ git log c9a642edf..cb88470d8 --date=short --no-merges --format='%ad %ae %s'
2018-03-19 bsalomon Remove SkSurface::MakeFromBackendTextureAsRenderTarget variant that doesn't take SkColorType
2018-03-19 bsalomon Revert "New read pixels implementation that is simpler but does all conversions on CPU."

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jvanverth@chromium.org

Change-Id: Ie5d73a29c6be4c8b4d4a240e2a2c700401375f78
Reviewed-on: https://chromium-review.googlesource.com/969073
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544145}

This changes updates all uses of
kReferrerPolicyNoReferrerWhenDowngradeOriginWhenCrossOrigin
to kReferrerPolicyStrictOriginWhenCrossOrigin, to more closely
match the spec.

R=jochen@chromium.org, tkent@chromium.org

Change-Id: I04412fc56e0739e91783f1cc6d3c7d981d54b289
Reviewed-on: https://chromium-review.googlesource.com/952528Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544144}

Report and cancel scroll bubbling when the
RenderWidgetHostInputEventRouter tries to bubble a gesture scroll
event back to the same view instead of CHECKing or hanging.

Bug: 818214
Change-Id: I5b8ce7815ba24855bc18a1c200541034fae21df5
Reviewed-on: https://chromium-review.googlesource.com/969335Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544143}

R=amineer@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib51e30fcb54f380b2167115492359ba829c37669
Reviewed-on: https://chromium-review.googlesource.com/969143Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544142}

https://chromium.googlesource.com/media_router.git/+log/270eb6c464d5..50d927e72030

$ git log 270eb6c46..50d927e72 --date=short --no-merges --format='%ad %ae %s'
2018-03-15 mfoltz Remove last references to chrome.dial from externs and manifests. Code calling chrome.dial has already been removed. The entire API it will be removed from Chrome in M67.
2018-03-06 mfoltz Added unit tests for Slarti support.
2018-02-28 mfoltz [Cast Provider] Disable sink query if it is enabled on the browser side.
2018-02-27 mfoltz [Media Router] Include media sink service status in feedback report

Created with:
  roll-dep src/chrome/browser/resources/media_router/extension/src

TBR=amp@chromium.org

Change-Id: I13f0ba07080d21f4e0e8bf331abac08ba06baabe
Reviewed-on: https://chromium-review.googlesource.com/966992Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Adam Parker <amp@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544141}

Bug: 800972
Change-Id: Ibf4e602c0d3a71ea105bcfd9285f1b410b91eb86
Reviewed-on: https://chromium-review.googlesource.com/966987
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544140}

This avoids doing memory allocations for every single node added to
the map.

Change-Id: Id7dd638e292c09180db3435285ce6d0a24ddc838
Reviewed-on: https://chromium-review.googlesource.com/962347
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544139}

Rename MediaPipelineBackendFactory to CmaBackendFactory because
it now creates a CmaBackend, not a MediaPipelineBackend.

Bug: 62147653
Test: cast_media_unittests
Change-Id: Ibd0e40d4165cf872f42d5386e1c9601c1dba2fcd
Reviewed-on: https://chromium-review.googlesource.com/967074Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: James West <jameswest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544138}

On GCC, due to a bug with initializer lists passed to classes
with explicit constructors, the test will fail.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84849

So disable the test on GCC.

Change-Id: Ida16d242177e6cd5af449b3e8dadc43e2da16ba6
Reviewed-on: https://chromium-review.googlesource.com/966288Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#544137}

AppShell doesn't support context menus, but still needs to provide a
WebViewGuestDelegate to handle the context menu. Otherwise, we reach a
NOTREACHED() in WebContentsViewChildFrame::ShowContextMenu().

Also removes a WebViewGuestDelegate function that is unused (see
https://codereview.chromium.org/2836973002).

Bug: 820604
Change-Id: I0760d397384908a490704f23388e11c4eef113a5
Reviewed-on: https://chromium-review.googlesource.com/957596
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544136}

Using wpt-import in Chromium f9cd9e06.
With Chromium commits locally applied on WPT:
23aafba1 "[url] Properly treat '#' as marking the start of the fragment in data URIs"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14190

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
ksakamoto@chromium.org:
  external/wpt/resource-timing

TBR=kereliuk

No-Export: true
Change-Id: I321cf41a7d45e52957c4fa04523808c630aaed55
Reviewed-on: https://chromium-review.googlesource.com/969184
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544135}

This is for the LUCI migration of this builder; the expected
effect of this as far as I understand is that it will cause
1% of CQ runs to include this builder (as an experimental
builder so failure won't block).

No-Try: True
Bug: 731426
Change-Id: I5922b8673481cdd34102e239b3255d5f24423327
Reviewed-on: https://chromium-review.googlesource.com/966700Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544134}

Add a separate Shutdown pass for this object so it can clean up its
observers. This avoids shutdown problems where animations can be
canceled, which causes display configuration changes, which causes
WindowTreeHostManager observer notifications, which runs code in
ShelfController when Shell is in a partially-destroyed state.

Bug: 817522
Test: added to ash_unittests
Change-Id: Iedabeb06e8a16653e0fb274b647e80748a0b6d26
Reviewed-on: https://chromium-review.googlesource.com/966862
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544133}

LowPriorityIframes2 is the name used in the server field trial
configs. This CL updates the name in the fieldtrial_testing_config
to be consistent with the server configs.

Bug: 800035
Change-Id: I85a681e181be4b0a0bd8718f2671ff9ba062073b
Reviewed-on: https://chromium-review.googlesource.com/969115Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544132}

This CL improves the code quality in VideoResourceUpdater.
1. Use C++11/14 conventions if possible.
2. Use OnceCallback and use member functions.
2. Delete dead code.
3. Add comments.

Bug: 730660
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I6d34839b7b781fa61b3b7c6655f7bba599892755
Reviewed-on: https://chromium-review.googlesource.com/959046
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544131}

* Remove FAR to package conversion logic.
* Migrate to "pm install" for installing packages on the deployment
  target.
* Plumb the unadorned application name through the various scripting
  layers, so that it can be run like "run foo_unittests".
* Roll SDK to 6e46feb3b26db267c65ea0923426a16f4da835bb.

Bug: 707030,798851

Change-Id: I4c8cc439a8be7a8d158df87200d0db6d67e6c9df
Reviewed-on: https://chromium-review.googlesource.com/963763
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544130}

Yahoo sites smoothness benchmarks are failing on Android Webview

BUG=822925

TBR=eyaich@chromium.org
NOTRY=true

Change-Id: I707551a1a43f716c2669bb3c4ddf7f94704cb62e
Reviewed-on: https://chromium-review.googlesource.com/969336Reviewed-by: Ashley Enstad <ashleymarie@chromium.org>
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544129}

Bug: 809637
Change-Id: I1eebc6708f52539848d2a38025c087051ced9985
Reviewed-on: https://chromium-review.googlesource.com/935675
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544128}

Shouldn't just assume something else has already done it.

Bug: 59847

Change-Id: I038ed2cf195578515da4aa5f376a0b897281756c
Reviewed-on: https://chromium-review.googlesource.com/965028Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544127}

https://chromium.googlesource.com/catapult.git/+log/d0c8b3b7d24c..2a467ca516e1

$ git log d0c8b3b7d..2a467ca51 --date=short --no-merges --format='%ad %ae %s'
2018-03-19 simonhatch Dashboard - More name validation in /add_point.
2018-03-19 nednguyen Remove more profilers in Telemetry
2018-03-19 simonhatch Dashboard - Validate master/bot/suite names.
2018-03-19 simonhatch Dashboard - Allow ints/longs for commit position in /add_histograms

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I749d80f31c5010e259b713090bfa55462ceb733d
Reviewed-on: https://chromium-review.googlesource.com/969321Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544126}

Added extended error codes to WebURLError, URLLoaderCompletionStatus and
ResourceError as well as adding a new ExtendedErrorToString method in
net_errors.h to take the extended error code and include the quic error
if applicable.

Bug: 801669
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I503c0197a8e5835be6bbbc2a7209c4373e7a08fd
Reviewed-on: https://chromium-review.googlesource.com/897706Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Brad Lassey <lassey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544125}

Fallthrough in a switch statement now omits a warning in modern
compilers. Unfortunately, the NaCl compilers are too old to support
the required annotation. We could enable this conditionally with a
macro, but it's simpler to just remove the fallthrough and replace
it with a goto.

Change-Id: I0c112883d170155424c8c40879d3024e2d144c8e
Reviewed-on: https://chromium-review.googlesource.com/965563Reviewed-by: Sam Clegg <sbc@chromium.org>
Commit-Queue: Ben Smith <binji@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544124}

BUG=822614
TBR=mmenke@chromium.org

Change-Id: I360c120ea72fd7ec215ec3d2e16214a1b77835e0
Reviewed-on: https://chromium-review.googlesource.com/969331Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544123}

This CL removes the flag to disable this feature, since it
has been in Beta 66.0.3359.30 without any major problems
so far.

Bug: 771345
Change-Id: I7283cc05ded90ca3ec24ba227fc80654ad5f3325
Reviewed-on: https://chromium-review.googlesource.com/912016Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544122}

The usb-style vendor-id/product-id for input devices are no longer
used. So remove them.

Bug: None
Change-Id: I72b8c136799f944281849b461140beb636ef75c9
Reviewed-on: https://chromium-review.googlesource.com/967732Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544121}

This excludes TranslateBubbleViewTest.AlwaysTranslateLanguageMenuItem which needs to be rewritten.


Change-Id: I81609db0da69f6529f043340f542d179622d0a0d
Reviewed-on: https://chromium-review.googlesource.com/963609Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544120}