GitLab

This could lead to us inline-autocompleting "foo.com" for a previous typed visit
to "ftp://ftp.foo.com", which feels misleading.

We still have the "ftp://" and even "ftp://www." prefixes, so not all FTP URLs
will be affected by this, just ones where the full hostname differs from the
typed text by something other than a missing "www.".

BUG=325997
TEST=Do a typed navigation to a valid "ftp://ftp.<something>" site.  Start typing "<something>", verify the browser won't inline-autocomplete it; verify inline autocomplete works if you start typing "ftp.<something>".

Review URL: https://codereview.chromium.org/387313007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283498 0039d316-1c4b-4281-b951-d872f2087c98

This appears to cause a compile faliure on buildbots.

> Add GN build targets for the rest of mojo/public
> 
> BUG=369643
> TEST='gn gen out/Debug && ninja -C out/Debug mojo
> 
> Review URL: https://codereview.chromium.org/388333003

TBR=cmasone@chromium.org

Review URL: https://codereview.chromium.org/399623005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283497 0039d316-1c4b-4281-b951-d872f2087c98

This is necessary because extension_app_shim_handler_mac.cc includes
public/web/WebNotificationPresenter.h indirectly.

BUG=350097

Review URL: https://codereview.chromium.org/391283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283496 0039d316-1c4b-4281-b951-d872f2087c98

This CL cleans up ContentsSwitcherView by removing its custom layout code
which is superceded by BoxLayout's main axis alignment.

Review URL: https://codereview.chromium.org/392133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283495 0039d316-1c4b-4281-b951-d872f2087c98

change to generate GetAttribLocation/GetUniformLocation functions by build_gles2_cmd_buffer.py 
and remove HandWritten code.

Bug=None
TEST=gpu_tests --gtest_filter="GLES2FormatTest.*"

Review URL: https://codereview.chromium.org/333303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283494 0039d316-1c4b-4281-b951-d872f2087c98

GetAllBookmarkIDsOrderedByCreationDate had a place where it incorrectly
terminated itself (return) while reading the bookmarks.

BUG=386785

Review URL: https://codereview.chromium.org/396843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283493 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening@chromium.org
BUG=DR-i#1476

Review URL: https://codereview.chromium.org/394283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283492 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347425
TEST=./unit_tests --gtest_filter="MetadataDatabase*"

Review URL: https://codereview.chromium.org/388913005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283491 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369643
TEST='gn gen out/Debug && ninja -C out/Debug mojo

Review URL: https://codereview.chromium.org/388333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283490 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394193

Review URL: https://codereview.chromium.org/396123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283488 0039d316-1c4b-4281-b951-d872f2087c98

This adds U suffixes to literals for unsigned int types in C++. For
Java, because integer literals >= 2 ** 63 are not allowed, such values
are transformed to the equivalent 64 bit signed value.

BUG=375522

Review URL: https://codereview.chromium.org/397453004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283487 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jamesr

Review URL: https://codereview.chromium.org/394033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283486 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393932

Review URL: https://codereview.chromium.org/397863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283485 0039d316-1c4b-4281-b951-d872f2087c98

This changes the syntax from:
 @(filepath:key0:key1)
to:
 @FileArg(filepath:key0:key1)

This should make it much easier for someone who encounters this syntax
to figure out what it is (currently a `git grep FileArg` returns only
results about/using this feature).

Also changes it to use a simple regex search instead of adhoc stuff.

BUG=359249

Review URL: https://codereview.chromium.org/377803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283484 0039d316-1c4b-4281-b951-d872f2087c98

Reset now will allow plugin to call RecyclePicture. The plugin must recycle any
texture it receives now. This makes plugin code simpler, since it can treat all
textures it receives in the same way (no special Reset handling).

Also fix a bug where Reset didn't return textures to the hardware decoder, which
already has this behavior.

BUG=281689

Review URL: https://codereview.chromium.org/390213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283483 0039d316-1c4b-4281-b951-d872f2087c98

gfe_quic::QuicSocketUtils::SetGetAddressInfo() calls. Update
gfe_quic::QuicSocketUtils::SetGetAddressInfo() to the best-known
implementation.

Merge internal CL: 70966702

R=rtenneti@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/397793004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283482 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350782

Review URL: https://codereview.chromium.org/385173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283481 0039d316-1c4b-4281-b951-d872f2087c98

BUG=329109

Review URL: https://codereview.chromium.org/395003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283480 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283479 0039d316-1c4b-4281-b951-d872f2087c98

If the tun interface is present, disable the data reduction proxy.

BUG=357129

Review URL: https://codereview.chromium.org/373153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283478 0039d316-1c4b-4281-b951-d872f2087c98

Previous submission was missing enough of the android portion to prevent
passing of compilation.  This patch combines ajwong@'s previous work with
enough fixes to the Android build to get it working.

BUG=none
TEST=passes GN, compiles.
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/390893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283477 0039d316-1c4b-4281-b951-d872f2087c98

This will allow us to roll the change out gradually using
Finch.

BUG=385213

Review URL: https://codereview.chromium.org/362553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283476 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Sync: Refactoring of DEVICE_INFO syncable type - Part 1 (https://codereview.chromium.org/367153005/)

Reason for revert:
this broke unit_tests" on "Linux ASan LSan Tests (2):
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/4967.

Original issue's description:
> Sync: Refactoring of DEVICE_INFO syncable type - Part 1
> 
> This change introduces a new class LocalDeviceInfoProvider that is responsible
> for providing the local device specific DeviceInfo/cache_guid. It initializes
> the data asynchronously and allows consumers to get notified when the data 
> becomes available. 
> 
> LocalDeviceInfoProvider will allow to remove these responsibilities from 
> SyncedDeviceTracker / ProfileSyncService and loose coupling between
> ProfileSyncService and a number of SyncableService and DataTypeController 
> derived classes.
> 
> LocalDeviceInfoProvider is hosted on the frontend thread. Since it needs
> cache_guid to initialize DeviceInfo, which is currently available only on the
> backend, I updated SyncBackendHostCore and SyncBackendHostImpl to pass
> cache_guid to the frontend via OnBackendInitialized.
> 
> For the time being SyncedDeviceTracker remains unchanged
> and continues to initialize the local device info too. The entire class will be
> removed in the Part 2 of the change which will move SyncedDeviceTracker
> functionality to a new SyncableService.
> 
> LocalDeviceInfoProvider also replaces SessionsSyncManager::SyncInternalApiDelegate
> which was previously used to decouple SessionsSyncManager from the specifics of
> of the local device info implementation. 
> SessionsSyncManager is changed to consume LocalDeviceInfoProvider instead of 
> SessionsSyncManager::SyncInternalApiDelegate.
> SessionDataTypeController now also consumes LocalDeviceInfoProvider to make sure
> that SESSIONS type model doesn't start before local device info becomes available.
> A very similar approach will be used in the upcoming second part of the change
> for DEVICE_INFO DataTypeController and SyncableType.
> 
> The change includes new unit tests for LocalDeviceInfoProvider and
> SessionDataTypeController.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283461

TBR=zea@chromium.org,rlarocque@chromium.org,sky@chromium.org,maniscalco@chromium.org,stanisc@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/401433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283475 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283472 0039d316-1c4b-4281-b951-d872f2087c98

> NaCl: Update revision in DEPS, r13456 -> r13484
> 
> This pulls in the following Native Client changes:
> 
> r13457: (dyen) LLVM Regression tests check for build files instead of empty dirs.
> r13458: (noelallen) Update and add GN files to build sel_ldr.
> r13459: (jvoung) Remove env cleanser references to obsolete env vars.
> r13460: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
> r13461: (hamaji) Non-SFI Mode: Add prctl syscall wrapper
> r13462: (hamaji) Non-SFI Mode: Implement IRT fstat
> r13463: (hamaji) Correct the return type of TestSuite in timefuncs_test
> r13464: (hamaji) syscall_test: Do not test st_atime in the test for fstat
> r13465: (earthdok) Implement initial MSan support. Also, adjust ASan build flags.
> r13466: (dschuff) pnacl-ld: Do not attempt to parse ELF or bitcode files as linker scripts
> r13467: (jvoung) Remove NaClSrpcIsStandalone() function.
> r13468: (dschuff) Make testing architecture explicit PNaCl toolchain buildbot script
> r13469: (dschuff) Stub out pnacl-opt and pnacl-finalize tools for scons built_elsewhere=1
> r13470: (dschuff) Update revision for PNaCl r13392->r13466
> r13471: (noelallen) Build nacl_bootstrap_helper and test with GN scons
> r13472: (dschuff) Build PNaCl with mingw again
> r13473: (earthdok) Zap the NaClSignalContext struct in SignalCatch.
> r13474: (dschuff) Update revision for PNaCl r13466->r13472
> r13475: (sehr) Munge nacl_helper_bootstrap using python rather than libelf
> r13476: (sky) Changes scan_sources not to output on bogus directory
> r13477: (dschuff) Reduce debugging metadata for pexe builds in Chrome
> r13480: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
> r13481: (hidehiko) Align at 16 bytes for stack for created thread.
> r13484: (jfb) Revert "Munge nacl_helper_bootstrap using python rather than libelf"
> 
> BUG=none
> TEST=browser_tests and nacl_integration
> R=jvoung@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283271
> 
> Review URL: https://codereview.chromium.org/390553002

TBR=dschuff@chromium.org

Review URL: https://codereview.chromium.org/396343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283471 0039d316-1c4b-4281-b951-d872f2087c98

Similar to ChromeOS, non-X11 Linux builds (such as Ozone) do not provide the
filename to URL conversion.

BUG=none

Review URL: https://codereview.chromium.org/394983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283468 0039d316-1c4b-4281-b951-d872f2087c98

Follow-up to https://codereview.chromium.org/370813003/ as per request.

BUG=391338
TEST=kInstallDate is still set on startup when it wasn't previously set (and no backup is present in registry)

Review URL: https://codereview.chromium.org/396753005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283467 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes a bug introduced with my earlier patch where in we were converting the insets to
a rect incorrectly for converting it to pixels.

This caused border artifacts for some app windows.

BUG=393930
R=sky

Review URL: https://codereview.chromium.org/394013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283466 0039d316-1c4b-4281-b951-d872f2087c98

use_glib=0 can work on some embedded setup that doesn't use glib.

Review URL: https://codereview.chromium.org/387623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283465 0039d316-1c4b-4281-b951-d872f2087c98

for testing.

Merge internal CL: 71210916

R=rtenneti@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/393143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283464 0039d316-1c4b-4281-b951-d872f2087c98

The sample isn't part of mojo implementation, so it
should be outside of mojo:: namespace.

TEST=none
BUG=330467
R=darin@chromium.org, ben@chromium.org, viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/393093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283463 0039d316-1c4b-4281-b951-d872f2087c98

* Update to use a single regex with named groups
* Add flags attr to the TIR __init__ function
* Remove references to 'logical name' (use 'label' instead)
* Use @property for attributes
BUG=

Review URL: https://codereview.chromium.org/390143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283462 0039d316-1c4b-4281-b951-d872f2087c98

This change introduces a new class LocalDeviceInfoProvider that is responsible
for providing the local device specific DeviceInfo/cache_guid. It initializes
the data asynchronously and allows consumers to get notified when the data 
becomes available. 

LocalDeviceInfoProvider will allow to remove these responsibilities from 
SyncedDeviceTracker / ProfileSyncService and loose coupling between
ProfileSyncService and a number of SyncableService and DataTypeController 
derived classes.

LocalDeviceInfoProvider is hosted on the frontend thread. Since it needs
cache_guid to initialize DeviceInfo, which is currently available only on the
backend, I updated SyncBackendHostCore and SyncBackendHostImpl to pass
cache_guid to the frontend via OnBackendInitialized.

For the time being SyncedDeviceTracker remains unchanged
and continues to initialize the local device info too. The entire class will be
removed in the Part 2 of the change which will move SyncedDeviceTracker
functionality to a new SyncableService.

LocalDeviceInfoProvider also replaces SessionsSyncManager::SyncInternalApiDelegate
which was previously used to decouple SessionsSyncManager from the specifics of
of the local device info implementation. 
SessionsSyncManager is changed to consume LocalDeviceInfoProvider instead of 
SessionsSyncManager::SyncInternalApiDelegate.
SessionDataTypeController now also consumes LocalDeviceInfoProvider to make sure
that SESSIONS type model doesn't start before local device info becomes available.
A very similar approach will be used in the upcoming second part of the change
for DEVICE_INFO DataTypeController and SyncableType.

The change includes new unit tests for LocalDeviceInfoProvider and
SessionDataTypeController.

Review URL: https://codereview.chromium.org/367153005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283461 0039d316-1c4b-4281-b951-d872f2087c98

chrome.input API allows modifying text as an IME, but the warning only says "Read anything you type". It should say "Read and change anything you type".

BUG=388535
R=jww

Review URL: https://codereview.chromium.org/396653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283460 0039d316-1c4b-4281-b951-d872f2087c98

Mojo: get .so from PRODUCT_DIR for packaged apps. This changed when we made them be LOADABLE_MODULEs

BUG=None

Review URL: https://codereview.chromium.org/395993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283458 0039d316-1c4b-4281-b951-d872f2087c98

ART does check covariance of types passed via JNI anyway, causing the VM to
crash if they doesn't. We'd better check this in Java Bridge and throw a
JavaScript exception, as LiveConnect spec suggests.

BUG=392489

Review URL: https://codereview.chromium.org/393733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283457 0039d316-1c4b-4281-b951-d872f2087c98

-----------------Reland Description------------------
Core animation was turned on in M35. The fullscreen window was not layer
backed, but should have been. This original CL exposed this bug.

-----------------Original Description------------------
In OSX 10.10+, all views must be added to the NSWindow's contentView. Some
views (like the tab strip and the profile icon) are placed on top of the title
bar and require special treatment. All other views are added as subviews of
'chromeContentView' in TabWindowController. This allows tab dragging and
fullscreen logic to easily move the views that don't need special treatment.

This CL also removes the instances where a VersionIndependentWindow's
contentView gets replaced by setContentView:. Instead, the 'chromeContentView'
gets passed around as a subview. This allows VersionIndependentWindow to remove
another of its internal hacks.

Original CL link: https://codereview.chromium.org/379293003/
BUG=392239

Review URL: https://codereview.chromium.org/393933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283456 0039d316-1c4b-4281-b951-d872f2087c98

Write would return synchronously but continue to retain the buffer.

BUG=380340,381147

Review URL: https://codereview.chromium.org/396003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283454 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/396743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283453 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/394683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283452 0039d316-1c4b-4281-b951-d872f2087c98