- 24 Feb, 2020 40 commits
-
-
Nazerke authored
This CL modernizes the OmniboxPopupCoordinator - to use |browser| in the initializer, - to remove the public property for dispatcher, webstatelist and browserstate, - to use self.browser to get browserstate, webstatelist and dispatcher values. This CL includes migration to ChromeCoordinator as a superclass. Bug: 1029346, 1048423 Change-Id: Id99b8197d23cbb9d0b16e9a35b096a9b91213562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068598Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#743899}
-
Nazerke authored
This CL modernizes the UnifiedConsentCoordinator to use |browser| in the initializer. This CL includes migration to ChromeCoordinator as a superclass. Bug: 1029346, 1048685 Change-Id: Ie2ce333091fcfcc9ed37fef74b2d71b254105f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068597Reviewed-by:
-
Colin Blundell authored
With this CL, WebLayer now shares the logic of when to allow users to proceed past security interstitials with Chrome rather than using its previous custom implementation. I verified manually that proceeding past an SSL interstitial still works as expected in WebLayer on Android and Linux. There are potential behavioral differences, as the logic of the previous custom implementation was simpler than that of ChromeSSLHostStateDelegate. However, any such behavioral differences should simply be bringing WebLayer's behavior in line with Chrome's behavior here, and hence should be a Good Thing from a security UX POV. This CL also opens the possibility of tracking metrics for recurrent errors in WebLayer, as ChromeSSLHostStateDelegate exposes the necessary functionality. However, this CL does not make any changes there. Making those changes would be a matter of porting the //chrome-level callsites of ChromeSSLHostStateDelegate::HasSeenRecurrentErrors() to //weblayer (or figuring out how to share them). Bug: 1030692 Change-Id: I21fcc417bbbaf7574fabbf27d64ebf07dbceae9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064393 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#743897}
-
Rushan Suleymanov authored
This reverts commit 232ad148. Reason for revert: this patch was reverted in crrev.com/c/2043451 due to suspect of sync protocol violation. It was fixed in crrev.com/c/2061751. Original change's description: > Revert "Unify clearing of sync prefs" > > This reverts commit 44d3aa82. > > Reason for revert: suspect of running into sync protocol violations and the corresponding DCHECK failures. > > Original change's description: > > Unify clearing of sync prefs > > > > SyncPrefs is a thin layer on top of preferences and hosts two groups > > of preferences: > > 1) Actual user-facing settings, such as type-selection, exposed via > > SyncUserSettings. > > 2) Local "bookkeeping" sync metadata, such the last synced time or the > > client ID (cache GUID). > > > > In addition, there are two cases that fall somewhere in the middle, > > whose behavior is changed in this patch: > > a) FirstSetupComplete: which roughly represents the user having > > consented to sync-the-feature (as opposed to transport-only upon > > sign-in without explicit user consent). > > b) The encryption-bootstrap-token: which represent an explicit > > passphrase (usually custom passphrase) entered by the user, that > > allows decrypting the incoming sync changes and encrypt outgoing > > ones. > > > > The last two preferences above fit group 1 better, so this patch stops > > clearing them in SyncPrefs::ClearPreferences(), now renamed to > > SyncPrefs::ClearLocalSyncTransportData(). > > > > With such cleanup, what used to be > > ClearDirectoryConsistencyPreferences() is now merged into a single > > clearing function, ClearLocalSyncTransportData(), and all calling sites > > are unified by directly clearing prefs in ShutdownImpl(DISABLE_SYNC), as > > opposed to individual calling sites. > > > > This introduces -arguably desirable- behavioral changes because > > codepaths like RESET_LOCAL_SYNC_DATA or STOP_SYNC_FOR_DISABLED_ACCOUNT > > now actually clear all local metadata, which most notably includes > > keystore keys. > > > > Change-Id: I2c42f98c4e068c7e340580d0b78a5cd5b5c46171 > > Bug: 1046237 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023649 > > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > > Reviewed-by: Marc Treib <treib@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#735841} > > TBR=treib@chromium.org,mastiz@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1046237, 1048771 > Change-Id: I4ce9e941f12aa58b7b6b286e990e74a1e01dad69 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043451 > Commit-Queue: Rushan Suleymanov <rushans@google.com> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739374} TBR=treib@chromium.org,mastiz@chromium.org,rushans@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1046237, 1048771 Change-Id: Idfad70ab9b1c00f56dc8e78257fc1a75fc71466f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066726Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#743896}
-
Javier Ernesto Flores Robles authored
Organize common UI utils to be consistent with ios/c/b/ui. Bug: 1052505 Change-Id: I628c814e74c58c7a1e5e913ec8c934f02a0b97d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066737 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#743895}
-
Jose Lopes authored
The callback is called once to indicate the initialization is complete: * https://cs.chromium.org/chromium/src/media/base/decryptor.h?rcl=bf6cbdd206196a39ecce5575a8a828eaa844dcb5&l=92 The initialization operations are defined in: * https://cs.chromium.org/chromium/src/media/base/decryptor.h?rcl=bf6cbdd206196a39ecce5575a8a828eaa844dcb5&l=98 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I7a2f3245f6d03eeed83c79a6155f1678aae136d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050588 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#743894}
-
Kim-Anh Tran authored
Bug: 1043030 Change-Id: Ifc97e8f42c67e21ca6418313469a933d08c3945f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066779Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/master@{#743893}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d358d055a505..5d5361f3bf54 Created with: gclient setdep -r src-internal@5d5361f3bf54 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic1123363c98659c7d36173d26dcbbd1871995bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069914Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743892}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b5576b67bcf5..8b73596fe704 git log b5576b67bcf5..8b73596fe704 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader f50cc82b3bed..214ec337a0b2 (3 commits) Created with: gclient setdep -r src/third_party/angle@8b73596fe704 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: If47094967a9e2f769d404a3af21ffa05e77ebf44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069913Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743891}
-
alanlxl authored
This CL adds unittest for ml_agent.h/cc and ml_agent_util.h/cc. It's very like model_unittest.cc, as ml_agent.h/cc is supposed to replace current model_impl.h/cc and ml_service_client.h/cc in the future. Bug: 1018065 Test: run this unittest and pass Change-Id: I9fda48f1235ca24220e8422a9de84e94537d0899 Cq-Depend: chromium:1903168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905044 Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#743890}
-
Javier Ernesto Flores Robles authored
Bug: N/A Change-Id: I3d3e3e997ef328f696a31a7056cf1ef942c47941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062370 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#743889}
-
Colin Blundell authored
This factory will be needed for using this class in WebLayer in order to share the logic for bypassing SSL interstitials between WebLayer and Chrome. The factory follows that of //chrome. Bug: 1030692 Change-Id: I84ac6ef02331b7d038b3a13e4e31951b4932d124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063007 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I1db6d9e2ed57c994e8a036a5c65428d376cfa5ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069911Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/6e49dff0052a..fa147af4a525 git log 6e49dff0052a..fa147af4a525 --date=short --first-parent --format='%ad %ae %s' 2020-02-22 wl@gnu.org [woff2] Fix font table access. Created with: gclient setdep -r src/third_party/freetype/src@fa147af4a525 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Bug: None Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Iadf0eb4f2c60703086827fa9f1efe7d1d413078c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069395Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#743886}
-
Keishi Hattori authored
This reverts commit af46fc0f. Reason for revert: Caused 10% speedometer2 regression crbug.com/1054840 Original change's description: > Change HeapObserverList to HeapObserverSet to support removal while iterating > > Some observers call their regular shutdown methods from ContextDisposed(), and they end up calling RemoveObserver while HeapObserverList is being iterated over. > To support this natively this CL adds removal while iteration support by sacrificing stable iteration order. > > Bug: 1052319 > Change-Id: I83ece3b5596550b9016c911e433f6f9e1a5fdc34 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060348 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742554} TBR=haraken@chromium.org,keishi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1052319 Change-Id: I4c49ca4d04c75be5f933308366334f3de93f4938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066435Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#743885}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f084b8b6b6a1..57bc977e124c git log f084b8b6b6a1..57bc977e124c --date=short --first-parent --format='%ad %ae %s' 2020-02-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 94ec1e5f8df5..b5576b67bcf5 (18 commits) 2020-02-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src f5ddd865..f0bb4f52 (1392 commits) Created with: gclient setdep -r src/third_party/skia@57bc977e124c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I1b40c93bdc520f4d17c0171afeb4d24ba3324cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069905Reviewed-by:
-
Lan Wei authored
This reverts commit f88810b8. Reason for revert: <INSERT REASONING HERE> virtual/storage-access-api/external/wpt/storage-access-api/requestStorageAccess.sub.window.html external/wpt/storage-access-api/requestStorageAccess.sub.window.html are flaky on Mac 10.10 and 10.11, https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests I think the expectation files are different when running on wpt serve. Original change's description: > Enable requestStorageAccess.sub.window.html test on Mac > > Enable requestStorageAccess.sub.window.html test on Mac because two > tests virtual/storage-access-api/external/wpt/storage-access-api/requestStorageAccess.sub.window.html > external/wpt/storage-access-api/requestStorageAccess.sub.window.html > failed on > https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests, but I > reverted the expectation file change. > > TBR=brandm@microsoft.com > > Bug: 1053903 > Change-Id: I348c8a387346ee2a4e8980a2fe6d84e4e5272232 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068253 > Commit-Queue: Lan Wei <lanwei@chromium.org> > Reviewed-by: Lan Wei <lanwei@chromium.org> > Auto-Submit: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743697} TBR=lanwei@chromium.org,brandm@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1054577 Change-Id: I95ae362c6dd2700a1e7fa4c1611ddf28ac1adab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069848Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#743883}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/934699adfbac..d358d055a505 Created with: gclient setdep -r src-internal@d358d055a505 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I26a57eff1541ea1191485250a0e0d4bb0c930a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069904Reviewed-by:
-
Julie Jeongeun Kim authored
This CL fixes AXPosition::IsIgnored to properly handle "after children" tree positions. It adjusts the position with the last index if |child_index_| has AnchorChildCount(). With this CL, if the position is an "after children" position, we should consider the position to be ignored if the last child is ignored. The original author of this CL is Nektarios Paisios<nektar@chromium.org> Bug: 1043769 Change-Id: I5d59d201634e1bf3366010adef6eba0d81334f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025007 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#743881}
-
Julie Jeongeun Kim authored
This CL is a precursor to converting FrameMsg_EnforceInsecureRequestPolicy to blink RemoteFrame mojom. It moves WebInsecureRequestPolicy values to mojom to use the values in content and blink and removes WebInsecureRequestPolicy. Bug: 1047284 Change-Id: If030952dbd0c9e98bb0c4a11479ea175ade91fc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045293 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#743880}
-
Yuzu Saijo authored
Bug: 1052733 Change-Id: Idaf0090bd0d1fe242c0c618559a6bdee13f03ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059828Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#743879}
-
Thanh Nguyen authored
If the edit distance is big enough, the ratio could be less than 0. This CL fixes the bug. Bug: 990684 Change-Id: I61e536aff49cef3cd5e844b816f8d3e6662f0e88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068228Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#743878}
-
alanlxl authored
SmartDimMlAgent is introduced to support loading model and preprocessor from either rootfs or component update service. SmartDim logic can just request decisions from SmartDimMlAgent without needing to know about it. SmartDimMlAgent is a replacement for model_impl.* and ml_serfvice_client.*, but they will coexist for a while, until the flag kSmartDimNewMlAgent rolls out to 100% of the devices. Bug: 1018065 Test: tast test power.SmartDim passes Change-Id: I6bb16c642476775d14836de27ca3a56fa98a8e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903168Reviewed-by:
-
Julian Watson authored
Bug: 1048962 Change-Id: I759b75b58402d8754a47dfa361c5a7918453bd45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068401 Commit-Queue: Julian Watson <juwa@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#743876}
-
Eric Willigers authored
SettingsWindowManagerTest.OpenSettingsWindowOpenSettingsWindow no longer relies on the extensions function OpenApplication() to launch a web application. Instead, it uses the launch service. Bug: 1052722 Change-Id: Ib4a3bf1a8c37d17b3fcd337c98ee7b1129fbdd5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066504 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#743875}
-
Lan Wei authored
This reverts commit 9ecbfdde. Reason for revert: <INSERT REASONING HERE> fast/peerconnection/RTCPeerConnection-applyConstraints-remoteVideoTrack.html is flaky on Builder Mac10.10 Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests Original change's description: > media: Makes fake video support 30 fps > > Bug: b/150004607 > Test: capture_unittests > > Change-Id: I2fd99575cb8a9b780946679ded96c10d94334370 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063617 > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Auto-Submit: Wei Lee <wtlee@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743661} TBR=guidou@chromium.org,wtlee@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/150004607 Change-Id: I1221bc67ba695faa6313a939b8e8f1f7a6ea527c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069846Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#743874}
-
Julian Watson authored
Bug: 1049453 Change-Id: I55c53beb5a8fd2eb1a61badfd98ac89cf770c4df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063560 Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
-
Noel Gordon authored
- move related CSS file-ng and not files-ng rules together - file-ng cr-button: no shadow, and account for 2px border Bug: 992824 Change-Id: I7d56a0e98df0384763007558e8ea15c85f5913f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069977 Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#743872}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/998066127e0d..f084b8b6b6a1 git log 998066127e0d..f084b8b6b6a1 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader f50cc82b3bed..214ec337a0b2 (3 commits) Created with: gclient setdep -r src/third_party/skia@f084b8b6b6a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: Ifc6042a4cb5288e302fd78100159adb2c9537e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069903Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/878e5f26c327..e1d7a0fe6ffb git log 878e5f26c327..e1d7a0fe6ffb --date=short --first-parent --format='%ad %ae %s' 2020-02-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@e1d7a0fe6ffb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I135ec876e90c2f44baca89d85c6b43a3286b3a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069902Reviewed-by:
-
Eric Willigers authored
The tests BookmarkAppUninstallDialogViewBrowserTest and BookmarkAppUninstallDialogViewInteractiveBrowserTest previously relies on extensions methods to install "bookmark apps". We now refer to these as web apps, and now use web_app:: functions to install them. Bug: 1052722 Change-Id: Ie4f81682ffa4282a88f06ca89578b3f093507ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067774 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#743869}
-
nancy authored
Update related unit tests, and not call CreateBlockDialog for unit tests, because below unit tests are broken if create CreateBlockDialog due to BubbleDialogDelegateView related error. All/ArcAppModelBuilderTest.IconLoaderForSuspendedApps/* AppServiceWrapperTest.ArcAppDisabled So workaround it by not showing CreateBlockDialog. BUG=1035136 Change-Id: Id5e4af8cc575f25c1edcdce576b59d46ff1e667b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061576Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#743868}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d26dd46a92a9..934699adfbac Created with: gclient setdep -r src-internal@934699adfbac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ib85c9d5660099b9786190af43db886917ec256a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069899Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I7fc721982a2142a6c79d29ecc38beeeb42d553f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068730Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743866}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 02382bd2. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 76ee218c "Split html/.../query-encoding/ tests" 1ce9585a "Clear-Site-Data must uncontrol affected service worker clients" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iec109052362a6cda92975e3779a5f2427f1069d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069861Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743865}
-
Leon Han authored
The spec changes: https://github.com/w3c/web-nfc/pull/361 https://github.com/w3c/web-nfc/pull/495 https://github.com/w3c/web-nfc/pull/536 BUG=520391 Change-Id: I00a363aba07d1f9f2f8e40212dca7650e26047a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038492 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#743864}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/672b17ee91d5..d5a5c4801756 git log 672b17ee91d5..d5a5c4801756 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 abennetts@google.com Fix TypeError in commit_cache.Get when id_string is None. Created with: gclient setdep -r src/third_party/catapult@d5a5c4801756 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1050173 Tbr: crouleau@chromium.org Change-Id: Ie110cf2f4c9cfe1ab01ba01dd615155cd6241022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069900Reviewed-by:
-
Abigail Klein authored
Allow line-by-line navigation of the accessibility tree and accessibility events by splitting the output element into lines and wrapping each line as a div. Bug: 877714,785493 Change-Id: I1fe60beb8e98ea49eab6fc372c74ab131beb9772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978822 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#743862}
-
Tommy Nyquist authored
It is necessary to continue the inline update flow experiment a little bit longer, so this sets the expiry date to M83 for now. R=dtrainor@chromium.org Bug: None Change-Id: Iacfb313619defdbdfa3b5042d93dfdc3da50494c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007316Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#743861}
-
Victor Costan authored
//content/browser/appcache_response{h,cc} include classes that wrap //net/disk_cache, which are used by AppCache and Service Worker, as well as a class that is only used by AppCache. This CL breaks down the code into the following: * appcache_disk_cache_ops.{cc,h} - the classes used by AppCache and Service Worker, which are HttpResponseIOBuffer, AppCacheResponseIO, AppCacheResponseReader, AppCacheResponseWriter, and AppCacheResponseMetadataWriter * appcache_response_info.{cc,h} - the AppCache-only AppCacheResponseInfo The CL also adjusts relevant include directives in //content_browser/{appcache,service_worker}. Some includes are replaced with forward declarations, and some IWYU fixes are applied as well. The CL introduces no functional changes. Bug: 1055133 Change-Id: I06408ca0aa7347d81dd73d4644d431abc2935cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069509 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#743860}
-
