- 12 Dec, 2018 40 commits
-
-
Henrique Nakashima authored
This metric measures completion rate of background downloads when started through DownloadBroadcastManager. The events are: - Started - Completed - Cancelled - Failed A trend of process killed rate can be inferred from the formula: 1 - ((Completed + Cancel + Failed) / Started) Bug: 864625 Change-Id: If9fc28f25a72a9010055b995f8ab53b11c1b2563 Reviewed-on: https://chromium-review.googlesource.com/c/1363679Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#616051}
-
Andres Calderon Jaramillo authored
This CL creates a story which consists of a JS animation in which a group of red squares rotates in the background while three semi-transparent foregrounds move on top (with some rotation, translation, and resizing going on). The foregrounds apply a blur filter. The motivation is that in Chrome OS, we were having problems with the launcher animation having a low frame rate. As the launcher is swiped upwards, it applies a blur on the background. dcastagna@ landed a fix to improve this significantly (see https://crbug.com/900046). The code used by the launcher to do the blurring is not unique to Chrome OS, so the new story should be able to measure regressions in that animation. For due credit: the story is based on tbuckley@'s example which reproduced the issue on the web (see https://codepen.io/anon/pen/MPXYMQ). Chromebook after reverting bf7c3813 (dcastagna@'s fix) from 96c5b055. Test: percentage_smooth goes from 90.805% to 36.158% on an eve Bug: 682082 Change-Id: Ifc4a725a2ba430e7698fccde703d2de4a12db687 Reviewed-on: https://chromium-review.googlesource.com/c/1324240 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#616050}
-
Marcin Wiacek authored
@IntDef annotations are preferred way for declaring set of int values: 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing InternalState enum in common @IntDef form: 1. with @IntDef first, @Retention second and related @interface third 2. with values inside @interface 3. with @Retention(RetentionPolicy.SOURCE) 4. without "static final" in the @interface Change-Id: I8ca8f808060f31e60c07cfc9bcdc6f3b2a8dc8a4 Reviewed-on: https://chromium-review.googlesource.com/c/1135539Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#616049}
-
Michael Ludwig authored
The rebaseline diffs are a little trickier to follow because many specific expectations have been moved into a more generic family, either from Mac and Windows versions to just Mac/Windows generic, or all the way to a platform independent expectation image. Bug: 913948 Change-Id: Ifa1cfa5191587a0ece36c2ce06dc111db5f699fa Reviewed-on: https://chromium-review.googlesource.com/c/1372221 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#616048}
-
chrome://flashJulian Pastarmov authored
All information on this page is duplicate of information from other sources. The Flash plugin version and path can be found on chrome://version. GPU information is present of chrome://gpu and crashes on chrome://crashes. BUG=615739 Change-Id: Ic0dce75db63099715145a63cac82316494a87b12 Reviewed-on: https://chromium-review.googlesource.com/c/1373841Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#616047}
-
Greg Kerr authored
The V2 sandbox is now default for all but the network and GPU processes on macOS. This CL deletes the feature flag. A new experiment will be introduced for the GPU process. The default case for the sandbox profile switch is removed, because previous CHECK() failures were confusing to diagnose. All profiles must now be handled explicitly, so Chrome won't build if a new profile type isn't handled. Bug: 749839 Tbr: asvitkine@chromium.org Change-Id: I3924a27efcc34091258e9c6076d062c35abef186 Reviewed-on: https://chromium-review.googlesource.com/c/1371024 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#616046}
-
Mounir Lamouri authored
HTMLMediaElementRemotePlayback (whith is HTMLMediaElement.remote) is currently the supplement. Making RemotePlayback the supplement will allow core/ to get the object and use it via an interface. Bug: 913668 Change-Id: I8f2c1fb0039098d829d11b166191f6d4745eb96b Reviewed-on: https://chromium-review.googlesource.com/c/1371215Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#616045}
-
Regan Hsu authored
Histograms which records if the user attempted to unlock and signin their device via SL (tapped their user photo) or other auth method (e.g., password, PIN, or fingerprint tba). Bug: 905438 Change-Id: I1cd840c67ad717102b4008be7e92aafcad5f95c6 Reviewed-on: https://chromium-review.googlesource.com/c/1355846 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#616044}
-
Sami Kyostila authored
This patch makes ThreadControllerWithMessagePumpImpl continue processing tasks even after the enclosing RunLoop has been quit. This is needed for MessageLoop compatibility in the following scenario: 1. A RunLoop is entered. 2. A native OS-level runloop is started, e.g., by opening a popup menu on Mac. Chrome tasks are allowed to executing in this nested loop. 3. A task is posted terminate the nested loop. 4. Before the above task has a chance to execute, a native callback calls RunLoop::Quit(). Because from Chrome's point of view there is no runloop nesting happening in the above scenario, RunLoop decides that it is the innermost one and tells ThreadControllerWithMessagePumpImpl to quit. However this doesn't terminate the OS-level loop and we get a live-lock. As Quit() is only supposed to affect RunLoop behavior instead of preventing tasks from getting executed, this patch changes ThreadControllerWithMessagePumpImpl to match the behavior of MessageLoop, i.e., allowing tasks to run after Quit(). Bug: 891670 Change-Id: I64fd335c122a0a6709f0c7222cfa1d3140a702e6 Reviewed-on: https://chromium-review.googlesource.com/c/1367660Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#616043}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f6b10fbe4ad7..f7f13e0742a9 git log f6b10fbe4ad7..f7f13e0742a9 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 kron@webrtc.org Add end-to-end test for ColorSpace information 2018-12-12 phensman@webrtc.org Switch to literals in playout delay tests 2018-12-12 kron@webrtc.org Add chroma siting to color space RTP extension 2018-12-12 henrikg@webrtc.org Revert "Reland "Default to dlopening the PipeWire."" 2018-12-12 nisse@webrtc.org Delete VideoCodec::targetBitrate 2018-12-12 mbonadei@webrtc.org Using fully qualified names for using declarations. 2018-12-12 phensman@webrtc.org Reintroduce division by two for audio playout delay 2018-12-12 mbonadei@webrtc.org Stop using 'using namespace'. 2018-12-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7f93585b..23962c38 (615733:615838) 2018-12-12 srte@webrtc.org Signals start rate when registering to TargetTransferRateObserver. 2018-12-12 nisse@webrtc.org Convert NetEq Cng-related test to not use RegisterExternalDecoder 2018-12-12 tomas.popela@gmail.com Reland "Default to dlopening the PipeWire." Created with: gclient setdep -r src/third_party/webrtc@f7f13e0742a9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:682122,chromium:None,chromium:None,chromium:682122 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icf6f6fc19cf09dfc783ca117f3ae0206218f5731 Reviewed-on: https://chromium-review.googlesource.com/c/1374136Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#616042}
-
Mohsen Izadi authored
Viz process that can be run using service manager is only used when mash is run in multi-process mode with out-of-process viz (i.e. when both Mash and MashOopViz features or on). Currently, service manager uses aura::Env mode (MUS vs LOCAL) to allow this which is wrong. Also, a recent change (r611340) causes service manager to run before aura::Env is created which breaks things further. This CL checks Mash and MashOopViz features to allow out-of-process viz. BUG=912218 Change-Id: Ib828acefd07abcb9ab134c9ed866fc3d4792de40 Reviewed-on: https://chromium-review.googlesource.com/c/1373883Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#616041}
-
Marcin Wiacek authored
Patch is aligning PromiseState to other @IntDef: 1. with @IntDef element first, @Retention second and related @interface third 2. with values inside @interface 3. with @Retention(RetentionPolicy.SOURCE) 4. without "static final" in the @interface Change-Id: Ia94bbd12a0e4cac0e4a0d504dbd3c24a2a8b10f7 Reviewed-on: https://chromium-review.googlesource.com/c/1370950Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#616040}
-
Nicolas Ouellet-payeur authored
This policy behaves a lot like BrowserSwitcherUseIeSitelist, except it can point to a different URL than the one IE uses. Bug: 846316 Change-Id: I52f91019aabcdd9b20163198195770fb52183e98 Reviewed-on: https://chromium-review.googlesource.com/c/1361327 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#616039}
-
Sky Malice authored
+66,360 bytes main lib size +483,380 bytes main dex size +780,271 bytes normalized apk size +299,669 bytes APK size +865,224 bytes Estimated installed size (Android Go) +2,252,524 bytes Estimated installed size InstallBreakdown (+2,251,998 bytes): +2,778 bytes unwind_cfi (dev and canary only) size +2,673 bytes Non-compiled Android resources size +66,360 bytes Native code size +589 bytes Package metadata size +2,163,890 bytes Java code size +15,708 bytes Compiled Android resources size +2,466 entries fields +3,489 entries methods +794 entries types +1,732 entries strings Specifics: InstallSize: Dex: Change-Id: I75d601109fcd2ed725ed70bbd907da9a1da3bd6f Reviewed-on: https://chromium-review.googlesource.com/c/1374165Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#616038}
-
Nasko Oskov authored
Since PlzNavigate is the only way navigation works currently, this comment is no longer valid. Change-Id: I0a922d096a9bfd574e904ef6ee0fa5b79793e6ec Reviewed-on: https://chromium-review.googlesource.com/c/1373018Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#616037}
-
Min Chen authored
Tap inside the status area of auto-hide shelf with app list opened will dismiss the app list and hide the shelf at the same time. This will let the status area can't receive the gesture event to open the corresponding tray bubble. This cl adds a lock for the auto-hide shelf and uses it to lock the auto-hide shelf state if dismiss the app list through tapping the status area of auto-hide shelf. Bug: 902680 Change-Id: Ib946d57a25a664f3f0b80230d35a38a5c2cc1256 Reviewed-on: https://chromium-review.googlesource.com/c/1373012 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#616036}
-
Martin Kreichgauer authored
When initializing pExcludeCredentialList parameter of a WEBAUTHN_MAKE_CREDENTIAL_OPTIONS struct, the code calls std::transform with a wrong value for the output iterator argument. As a result, the code crashes if an exclude_list was set in the request. This fixes the issue by passing the correct output iterator. (The initialization of the equivalent pAllowCredentialList parameter during GetAssertion was already correct.) Bug: 898718 Change-Id: Id0611348f6b4e208d9176d714b10da95b474bd2e Reviewed-on: https://chromium-review.googlesource.com/c/1374401Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Cr-Commit-Position: refs/heads/master@{#616035}
-
Tiansong Cui authored
Bug: internal 110279510 Test: manual Change-Id: I52cc1ab552f6d405cf0eb15c79fa6ea88f51398d Reviewed-on: https://chromium-review.googlesource.com/c/1372628 Commit-Queue: Tiansong Cui <tiansong@google.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#616034}
-
Peter Mayo authored
Improve the readability. "an string" -> "a string", mostly. Bug: None Change-Id: I71ef9fa7545e23c977a7b90192161776d69cf527 Reviewed-on: https://chromium-review.googlesource.com/c/1180275Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#616033}
-
Tom Bergan authored
R=robertogden@chromium.org Bug: 908491 Change-Id: Id65e7b73fda8f873d9d818683b12df449d65c96d Reviewed-on: https://chromium-review.googlesource.com/c/1352821Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tom Bergan <tombergan@chromium.org> Cr-Commit-Position: refs/heads/master@{#616032}
-
Cary Clark authored
In preparation for review.skia.org/173427 add a switch so Chrome can use the old version. Once Chrome is rebaselined, it will be switched to the newer version. R=fmalita@chromium.org BUG=899689 Change-Id: I0ccf1e682337b238afa024ad26b09dde875afefd Reviewed-on: https://chromium-review.googlesource.com/c/1374162Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#616031}
-
Xiyuan Xia authored
The test creates windows on ash side, which uses the Shell's env in local mode. Hence, occlusion state change happens synchronously and does not depend on grouping occlusion state change. Bug: 910303 Change-Id: I99765acb3818295cbb96cef212cea91e06929704 Reviewed-on: https://chromium-review.googlesource.com/c/1372662Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#616030}
-
Xianzhu Wang authored
We need to persist main frame overlay across page navigations [1]. LocalFrameView doesn't persist across same origin page navigations, while LocalFrame does, so FrameOverlay should be managed by LocalFrame. The test happened to pass with FrameOverlay in LocalFrameView because the GraphicsLayer created by the FrameOverlay for the previous LocalFrameView was left in the graphics layer tree. Actually this is an unwanted memory leak. The new LocalFrameView may create its own FrameOverlay resulting two overlay GraphicsLayers in the graphics layer tree. This CL fixes the leak bug. It's also needed by ComposteAfterPaint which doesn't use GraphicsLayer. Also set correct property tree state when painting frame overlays. This is important for subframes to paint the overlay at the correct place in the overlay layer. [1] compositing/visibility/overlays-persist-on-navigation.html Bug: 912570 Change-Id: Ib458b6fa374aa25478ce52da1226a0c43df7d1ef Reviewed-on: https://chromium-review.googlesource.com/c/1372723 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#616029}
-
dpapad authored
The latest version no longer depends on neon-animation which has been deprecated. Bug: 907333 Change-Id: I68ada294a8f159db7fd5f393733be47afd347d2e Reviewed-on: https://chromium-review.googlesource.com/c/1373880Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#616028}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/38b36666a125..ca5569f2c920 git log 38b36666a125..ca5569f2c920 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 fmayer@google.com fuzzing: Consume everything in buffered_frame_deserialzier. Created with: gclient setdep -r src/third_party/perfetto@ca5569f2c920 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I9c85583421867cd7f69cb4ccb442ab1946f0eb69 Reviewed-on: https://chromium-review.googlesource.com/c/1374139Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#616027}
-
Nicolas Pena authored
This CL allows reporting events without event handlers. In particular, this implies that slow clicks cause slow mousedown events, so the tests are modified accordingly. Bug: 823744 Change-Id: I9578519ae538496404bb220001d3ca97565b7bd7 Reviewed-on: https://chromium-review.googlesource.com/c/1368458Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#616026}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/277cdb9bcc3e..ebff6e2b3d0a git log 277cdb9bcc3e..ebff6e2b3d0a --date=short --no-merges --format='%ad %ae %s' 2018-12-12 uwyiming@google.com Potential Perf Regression Expected: Add nonce to injected scripts for responses with restrictive CSP script-src directive. Created with: gclient setdep -r src/third_party/catapult@ebff6e2b3d0a The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:904534 TBR=sullivan@chromium.org Change-Id: Ie3c930e05e732e25f060e22b5cf99c56d8de2aa9 Reviewed-on: https://chromium-review.googlesource.com/c/1374047Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#616025}
-
Richard Knoll authored
If we show a notification with a long title, a context message and an image, the line limit of the message body is set to 0 so that the image can be flush against the icon. This CL removes this limitation and therefore the "feature" of having the image flush against the icon when the notification contains a lot of text. The notification message can now contain: 0 title lines: 5 max lines message 1 title lines: 5 max lines message 2 title lines: 3 max lines message This does not depend on whether there is an image or a context message. We still make sure that there is at least 16px of space between the icon and the image, if the text part is higher than the icon. Bug: 697573 Change-Id: Ic8f2441de58e4503d93da025275b57ba5a2a92b9 Reviewed-on: https://chromium-review.googlesource.com/c/1350749Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#616024}
-
Jonathan Backer authored
Change-Id: I96ef67192107f46e5524a406535c1c1fa51fbc80 Reviewed-on: https://chromium-review.googlesource.com/c/1374392Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#616023}
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/407b393..2823bdd7 The following change includes: 2823bdd7 Fix crash of new Intl.DateTimeFormat("ja-u-tz-uslax") Test: v8: intl/regress-8469 Bug: v8:8469 Change-Id: I3ac43f0a54761c3de0b5764b3075e587bef74275 Reviewed-on: https://chromium-review.googlesource.com/c/1373009 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#616022}
-
Yao Xiao authored
Bug: 911674 Change-Id: Ia010b625ed72ca575fc1aeafdf64990bcd2171d8 Reviewed-on: https://chromium-review.googlesource.com/c/1366766 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#616021}
-
Sonny Sasaka authored
Currently there is no way to override a method handler that is already registered to an ExportedObject. A support to do so is required to correctly implement Chrome OS Bluetooth dispatcher which needs to add/remove an interface to an exported object dynamically. Therefore this CL adds methods to allow method handlers to be unexported so another handler can be exported afterwards. Bug: 883039 Change-Id: Id26dbdb8b2ee3425c21ec0797e1c08183f3e04ab Reviewed-on: https://chromium-review.googlesource.com/c/1370573 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#616020}
-
Ryan Sturm authored
This CL introduces a feature to prevent showing all preview types on all reloads. Historically, only Offline previews have been prevented on reload, but this notion should be cautiously extended to all Previews types. Bug: 914029 Change-Id: I8f3859a7f3ffd62b159cd064f117ed462faa1920 Reviewed-on: https://chromium-review.googlesource.com/c/1372541Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#616019}
-
manuk authored
Reduced table body row heights from 44px to 42px. 42px is just sufficient to display 3 lines. Any less, and cells with 3 lines of contents would grow in height on hover. 3 lines seems sufficient for most matches without consuming too much vertical space. Reduced table header row padding from 20 (top) and 10px (bottom) to 12 and 6px respectively. This looks more visually pleasing and consumes less vertical space without appearing cramped compared with the adjacent table rows. Bug: 891303 Change-Id: I75efba70799163bd7f33e1340cfecdd2d1bb45a3 Reviewed-on: https://chromium-review.googlesource.com/c/1374400Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#616018}
-
Aleks Totic authored
Bug: 740993 Change-Id: I8253d80703333beb4d252b585df910c71af43ab6 Reviewed-on: https://chromium-review.googlesource.com/c/1371019 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#616017}
-
Zinovy Nis authored
Bug: None Change-Id: I01bf6013df07ba47d3f1b567a8ce7e7235971bdb Reviewed-on: https://chromium-review.googlesource.com/c/1356558Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#616016}
-
rbpotter authored
Spacing between buttons on the downloads page was not specified in the styling, and was instead the result of whitespace that is removed when using the legacyOptimizations: true flag in Polymer 2. Specify 8px margin between buttons to match spacing used in other Web UI paper-buttons. Bug: 912488 Change-Id: Icca140d02fe85fbb8b847b67f6925da87e13b26f Reviewed-on: https://chromium-review.googlesource.com/c/1373137Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#616015}
-
Stephen Chenney authored
For some reason the snapped_dest_rect for background image geometry calculations was not actually snapped. Snapping it fixes cases where we were not filling to the border without regressing any tests (in fact improving some). Probably fixes most of the background bugs resulting from the previous big refactoring. R=fmalita@chromium.org BUG=912423,889426 Change-Id: Ieba65130e7f8c0e95db7375ab3a8188bfc78d8d5 Reviewed-on: https://chromium-review.googlesource.com/c/1372556 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#616014}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dfed8e9b27e3..d80da25f9a45 Created with: gclient setdep -r src-internal@d80da25f9a45 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2e6d5d9381c4e6497cc806420ee27c717aaca41a Reviewed-on: https://chromium-review.googlesource.com/c/1374044Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#616013}
-
edchin authored
This was previously the transition animation for the tab strip during the tab switcher transition. It is no longer used. Change-Id: Iead91a20ea25f5810e2556a0de99f4f0ec310592 Reviewed-on: https://chromium-review.googlesource.com/c/1370826 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#616012}
-