- 15 Jul, 2020 40 commits
-
-
Vikas Soni authored
Set GrContextOptions::fPreferExternalImagesOverES3 to true which causes Skia to use ES2 instead of ES3 if GL_OES_EGL_image_external_essl3 is not available and GL_OES_EGL_image_external is available. Bug: 1031383,1104891 Change-Id: I87c2e35e4f1ae95a4882a275d3aceb416c47bd0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296875Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#788507}
-
Dale Curtis authored
This is blocking our ability to handle HDR images since the function always forced HDR color spaces to P3. This change removes this method and updates a few call sites to expect that. Most callers are unchanged since they properly handle the HDR color space. R=ccameron Bug: 960620, 1076568 Change-Id: If507cae148a1e510b3569907773f6d84c5ed2d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298580 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#788506}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/35dec5f127c3..9d9199a509bf 2020-07-15 chanli@chromium.org [led] Roll to latest If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1099018 Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: Ic1747423c2e82c118349278d065ac5e1beeeb4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298812Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788505}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fb20ab83..a721ddba Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4ae80d5f8ae8a07aae99894f1c77d2953ba18057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298740Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788504}
-
Matt Falkenhagen authored
Bug: 1092329 Change-Id: I7e5697631a0eedd12202533f59c48b15aba674be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298843Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#788503}
-
Brett Kilty authored
Update the IS_ANDROID_THINGS check to use the superset IS_ANDROID_APPLIANCE, covering cases using other Android platform builds. Bug: b/156263192(internal) Test: local build (device) Change-Id: Ia750c8d31a98881e7efaa6e69b10f2f7a6ba0ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298342Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Brett Kilty <brettk@google.com> Cr-Commit-Position: refs/heads/master@{#788502}
-
David Vallet authored
BUG=1068382 Change-Id: I1e717499d26e0d8984d731bdd74b59700285b861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291134 Commit-Queue: David Vallet <dvallet@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#788501}
-
Jit Yao Yap authored
Sync server-side changes from cl/320034367. Change-Id: I16909359e462681ec2a3b1b7a7be8ef2730c60b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294659Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#788500}
-
Hajime Hoshi authored
TBR=agl@chromium.org Bug: 997732 Bug: 1105733 Change-Id: Iab83322d35a5e24f3ea1ee5bbdb25daae33ecc60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298961Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788499}
-
Zhongyi Shi authored
connectivity related errors. Early data indicating that most connections has been closed by the time a network change happens, which is the main motivation for me to track the count for closed connections caused by connectivity related errors. Some connection may get closed early due to connectivity related issues: 1. public reset by the peer post handshake is typically caused by NAT rebinding. 2. QUIC_PACKET_WRITE_ERROR by self is typically early signal indicating network no longer being usable. 3. QUIC_TOO_MANY_RTOS by self is typically caused by silent blackholing. This change also moves metrics logging to QuicConnectivityMonitor. Bug: 1090532 Change-Id: Ic0d05fc788aeb35b49ae853b0b8b652673c16ea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293261Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788498}
-
Mei Liang authored
TabSuggestionMessageCardTest#groupTabSuggestionReviewedAndDismissed is flaky when running on an emulator. This CL is to disable this test on the emulator testers. TBR=wychen@chromium.org Bug: 1102423 Change-Id: I8196a21a028d40cce846d47ee7cd4d8bf6fda0a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296292Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#788497}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7cdf3fb532c2..24010e318dc4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hajimehoshi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085419 Tbr: hajimehoshi@google.com Change-Id: Ie0d76a0beca7f5f1a77f4b9ab1aa90d330c660d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298804Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788496}
-
Takashi Sakamoto authored
Bug: 1092288 Change-Id: I194809d2690e969ace4ed2fa9db34f5bb20f40cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270287 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#788495}
-
Keishi Hattori authored
Convert reference members to LayoutObjects to pointers in anticipation of oilpanization of LayoutObjects. Because reference members cannot be used to reference on-heap objects. Bug: 1030176 Change-Id: I78f404a38bca26b2f24c4a1abf5faabafe55fcb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277906Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/100707a33723..1de497cc50ab 2020-07-14 natsu@google.com Support Gralloc3 in SwiftShader If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I8d51994ce5874c55f8ddd0389cf8c8ae198e6cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298801Reviewed-by:
-
Mohsen Izadi authored
Every time this file is modified, there is a cpplint complaint about the C-style cast. Fixing the cast to avoid cpplint complaint. Bug: none Change-Id: I8b93c028a2208c71332e8ff1de49f8af9ae32a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299020 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#788492}
-
Lan Wei authored
overflow-scroll-in-overflow-scroll-scrolled.html" Avoid testRunner.eventSender in paint/invalidation/scroll/overflow-scroll-in-overflow-scroll-scrolled.html TBR=wangxianzhu@chromium.org Bug: 1047176 Change-Id: If4522d945a8e5d2d269bd7e8eedf8b070a81cc6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298277Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#788491}
-
Sven Zheng authored
Bug: 1104291 Change-Id: Ib783a1d26f96c16042178c232a41477a9f0fc6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293479Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#788490}
-
Yue Zhang authored
http://crrev.com/c/2123991 makes TAB_CLOSED_LISTENER a common property for all types of tab lists. However, TAB_CLOSED_LISTENER should not be set for UiType.SELECTABLE. This CL fixes this issue by not setting up TAB_CLOSED_LISTENER for UiType.SELECTABLE. Bug: 1105439 Change-Id: I3999463f1cb574fd16904fef83fe4ef1a5418c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298521Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#788489}
-
Yuki Shiino authored
Creates the returned V8 wrapper in the appropriate context when [CheckSecurity=ReturnValue] is specified for the new bindings generator. Bug: 839389 Change-Id: Iccc59a2dca63d146b4f06413672778627bb7a1e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297000Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#788488}
-
Jeremy Roman authored
We know exactly what the final size and type is, so we can write directly into the final buffer instead of using a builder first. Change-Id: Ia8fcbc2ae6ae7adc0eedc9d3cac7938a6ccb3291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297684 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#788487}
-
Kent Tamura authored
SELECT: The last selected OPTION should be selected when multiple selected OPTIONs are added by jQuery append(). HTMLOptionElement::SetWasOptionInsertedCalled() had a silly bug. Bug: 1105672 Change-Id: Ic70572f297969d44bbe8f3d55fe05af796397f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298882 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#788486}
-
Hirokazu Honda authored
This enables VaapiVEA to produce temporal layer bitstream. The temporal layer bitstream structure is defined in VP9TemporalLayer class. It now supports two and three temporal layer structures. VA-API encoder driver works in CQP mode only if temporal layer encoding because VA-API driver on gen 9 devices doesn't support bitrate control of each bitrate layer in CBR mode. Design doc: go/vaapi-vp9-TL Bug: 1030199 Test: vp9_encoder_unittest Test: appr.tc/?debug=loopback&vsc=vp9&vrc=vp9 with --force-fieldtrials=WebRTC-SupportVP9SVC/EnabledByFlag_1SL3TL/ --enable-features=VaapiVP9Encoder Change-Id: Ie46b4b52730c59684ea00c27bdf1afaaf07bf991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150525 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#788485}
-
Lingqi Chi authored
|WebLocalFrameImpl::FromFrame()| will return nullptr if the given frame does not have a valid |WebLocalFrameClient|, using the returned null pointer leads to a null dereference crash. This CL adds a check on the returned WebLocalFrameImpl. Bug: 1069289 Change-Id: Ifa009f974a1bb25add08bb6f155b02a4c797c423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275818 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Nate Chapin authored
* Add an execution_context_ pointer to SecurityContext (which will be null for RemoteSecurityContext). Use execution_context_ state in lieu of context_type_for_asserts_, and add a way for ExecutionContext to report if it has an insecure ancestor. This gives SecurityContext all the state it needs to update the SecureContextMode when the SecurityOrigin changes. * Now that SecureContextMode is set automatically, ensure all tests that depend on the SecureContextMode set a suitable SecurityOrigin, and remove SetSecureContextModeForTesting(). Change-Id: I881593fc3e3dbeef589c87f4e40b1037200037b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295792 Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Glen Robertson authored
Web App Manifest spec term was updated recently: https://github.com/w3c/manifest/pull/833 Bug: 1096388 Fixes: 1096388 Change-Id: I6fe6da6abb8d4e06391c46d4054a746bc49e6e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291512Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#788482}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f4f8011aef19..9421094d01b1 2020-07-15 herb@google.com Revert "rename MakePath to Make" 2020-07-15 herb@google.com rename MakePath to Make 2020-07-15 reed@google.com Revert "remove support for serialized pictures before aug 2019" 2020-07-14 adlai@google.com Add a direct context arg to makeColorTypeAndColorSpace 2020-07-14 johnstiles@google.com Update SkTQSort to use half-open ranges. 2020-07-14 brianosman@google.com Runtime effects: Allow null children 2020-07-14 jcgregorio@google.com Add one R preview bot. 2020-07-14 herb@google.com subclass GrPathSubRun from GrSubRun 2020-07-14 bsalomon@google.com Remove under used IsACopyNeededForMips helper. 2020-07-14 bsalomon@google.com Make GrTextureProducer take optional subset and domain rects 2020-07-14 herb@google.com make GrAtlasSubRun a subclass of GrSubRun 2020-07-14 egdaniel@google.com Update GrDawnBuffer to handle mappable xfer buffers. 2020-07-14 robertphillips@google.com Set up to use new GrDirectContext factories in Chrome 2020-07-14 herb@google.com extract and rename SubRun to GrSubRun 2020-07-14 johnstiles@google.com Replace various one-liner sorting functor adapters with lambdas. 2020-07-14 bungeman@google.com Move makeFontData to SkTypeface_FreeType. 2020-07-14 senorblanco@chromium.org Roll Dawn, and update to new TextureDataLayout API. 2020-07-14 jvanverth@google.com Add Direct3D compressed texture support. 2020-07-14 bsalomon@google.com Remove GrTextureProducer::DetermineDomainMode. 2020-07-14 reed@google.com Create mipmaps when creating images 2020-07-14 brianosman@google.com In FPs, store pointers for all child slots, even nullptr 2020-07-14 egdaniel@google.com Revert "Add GrContext api to update compressed backend textures." 2020-07-14 johnstiles@google.com Include the SkTSort header only where it is used. 2020-07-14 egdaniel@google.com Add GrContextOption to limit the number of cached secondary command buffers. 2020-07-14 reed@google.com remove support for serialized pictures before aug 2019 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1099255 Tbr: nifong@google.com Change-Id: I26f0c3bea8ed278c552c66c48328ecb22c2e7289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298470Reviewed-by:
-
Mohsen Izadi authored
There are a few cases that the commit is aborted: 1) LayerTreeHost is not visible; 2) Main frame update is deferred; 3) Commit is deferred; 4) There is no update/damage. In case (4), gathered events metrics are thrown away as handling of the events had no effect. In cases (1) to (3), commit is deferred to a later time and might happen in the future, so we should keep gathered events metrics around to report in case the commit happened in the future. This CL adds comments to explain this in code and adds tests to verify these behaviors. Bug: 1100491 Change-Id: I89c2bae0a78c0274a78cf9ff6c4979bbb53ec952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285476 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#788480}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=lgcheng@google.com Change-Id: I4587fdbb89b569a094b86951020204423f923736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297365 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Commit-Queue: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#788479}
-
Joel Hockey authored
Waiting for terminal is not necessary. The fact that we can find the browser is sufficient to prove that things are working. Bug: 1105721 Change-Id: I97fd9a7b80919353bb1c7d3b81e039f1e5b11309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298959Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#788478}
-
Tarun Bansal authored
Change-Id: I6cfecc37b262308f0ca557ec51dd876b53aa12cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298162Reviewed-by:
-
Ben Joyce authored
This will turn "coverage on the fly" on if someone uses the "use_jacoco_coverage" gn arg, which is probably what most people would expect, however, there wouldn't be a way to turn --coverage-on-the-fly off with that option. Bug: 1097815 Change-Id: I07567931854f0d1f6a1399c613bc6f856e1faff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298038Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#788476}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=dgozman@chromium.org Change-Id: Ia76930746905f4360705812c3eae6f2379b6b426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298820 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#788475}
-
Adam Rice authored
Update the IDL for ByteLengthQueuingStrategy and CountQueuingStrategy to match the standard. The most noticeable semantic difference is that incorrect calls like `new CountQueuingStrategy(10)`, which previously silently gave you the default highWaterMark, will now throw an exception. Also cache the "size" function on the global object. Add a test that iframes have a different "size" function, since they have a different global object. Change-Id: I9b6763944c0abc278451c28a4fcf615f624e1fdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104815Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#788474}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/581586d36efb..7cdf3fb532c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hajimehoshi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: hajimehoshi@google.com Change-Id: I9e9f9de9b6b7d52801fbc6b88b2c0111e033701a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298467Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ieca4eb8b7c2b8ea5e26b404335209b8f290ff979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298709Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788472}
-
Fergus Dall authored
According to the linter, all of these expectations are redundant with other lines in these files. TBR=hajimehoshi@google.com Bug: None Change-Id: If88dee6746e044217b670345d725d0ebc7af1f70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298865Reviewed-by:
-
dpapad authored
Since it tests focus() and blur() functionality it should be an interactive ui test, which is known to work better for such WebUI tests on Mac. Note that the test currently manually fires 'blur' events (via MockInteractions.blur), and bypasses the problem. This is in preparation of relanding a CL that adds type-checking for this file which was previously reverted at r775025. Fixed: 1091201 Change-Id: I4d458eb6bef08cfdcb7741e1771747f6d39a5e94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296483 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#788470}
-
Donn Denman authored
Check for matching source/target parameters and don't send the translation information if they match. BUG=1076197 Change-Id: Ie4ba9b9061d62512b348b0e47dd48bc2b2054c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298178 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#788469}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7e3ef3c4..fb20ab83 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic4ecfb3a93aae0c5e6807cfd0b08ac5e621d2256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298620Reviewed-by:
-
