- 12 Oct, 2020 40 commits
-
-
Mark Mentovai authored
The bucket index is needed internally, but it can be computed from the threshold size rather than being hard-coded. This was partially fixed by 94069728 (https://chromium-review.googlesource.com/c/2428896) which added a constant for the threshold size which can be checked by PA_CHECK. Unfortunately, that new CHECK was violated on mac-arm64, where the environment reports that the system allocator guarantees a minimum 8-byte alignment, thus the bucket corresponding to allocation size 512 occurs at a higher index than other 64-bit platforms, where the environment reports a minimum 16-byte alignment. It’s possible that the alignment reported on mac-arm64 is a bug, because the system allocator does in fact impose a 16-byte minimum alignment, but perhaps it believes that while this is true, it’s only guaranteeing 8-byte alignment. Regardless, the new PA_CHECK did catch that the thread cache threshold was not tuned as expected on mac-arm64. It seems to be intended to have used 512 everywhere, but 256 was being used on mac-arm64 instead. Bug: 1135726 Change-Id: Ic820842d2a6eb669a0a65afb68c34638adf598d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463445 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#816239}
-
Allen Bauer authored
Bug: 772945 Change-Id: Ib68c761d567456094a33ba075a639e932106a103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464346 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#816238}
-
Saho Kobayashi authored
The information of checked property and state description is duplicated, and this causes doubled output of ChromeVox on ARC++ Checkbox. State description is added in R, so this was not a problem until P. Instead of description property, add new field property to send state description. Use this new property to recognize whether this description is came from state description or not, and avoid doubled output. only once) out/Release/browser_tests --test-launcher-jobs=20 --gtest_filter=ChromeVox Test: manual (manually check that ChromeVox says checked and not checked Bug: b:154433831 AX-Relnotes: n/a Change-Id: I6055bb317db6525a8eafd2cff2213e7eb6434274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444875 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:Dominick Ng <dominickn@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#816237}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/936ef0a5f21e..a7b0fdc90fea 2020-10-12 cwallez@chromium.org Make SetScissorRect match upstream WebGPU specification. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I75cd38d854ab98b1ee2b8ba3644a789a1e802cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466359Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816236}
-
Austin Eng authored
This CL fixes SharedImage interop between Dawn and Skia on Linux so that WebGPU can be enabled when SkiaRenderer Vulkan is used. To get the correct layout for import, we query the GrBackendTexture for the layout information on BeginAccess, and on EndAccess, we save the exported layout information on the GrBackendTexture. This makes it so that future users of the shared image import it with the correct layout. Bug: dawn:200, 976495 Change-Id: I6303812bf088f21f01bc3ca0d1cfee12b662815f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462634 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#816235}
-
Eugene Zemtsov authored
1. Attach a new sync token to the frame, so it's not destroyed before the resulting image is fully created. 2. Introduce WaitAndReplaceSyncTokenClient to avoid duplicating code from paint_canvs_video_renderer.cc Bug: 1136410 Test: https://webcodecs-blogpost-demo.glitch.me/ doesn't crash Change-Id: I62d091776424f2ee3d550c8c5ef98f99f6720e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465504 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#816234}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ceb6214a556a..9213e610ed92 2020-10-12 csmartdalton@google.com Disable the tessellation atlas on non-direct contexts 2020-10-12 bsalomon@google.com Revert "Use ManagedBackendTexture in place of TestUtils backend texture helpers." 2020-10-12 fmalita@chromium.org Reland [svg] Add svg_tool 2020-10-12 johnstiles@google.com Undo call-count fix for intrinsic functions. 2020-10-12 ethannicholas@google.com moved SkSL FunctionReference/TypeReference data into IRNode 2020-10-12 bsalomon@google.com Use ManagedBackendTexture in place of TestUtils backend texture helpers. 2020-10-12 fmalita@chromium.org [svg] Add public.bzl defs for SVG source sets 2020-10-12 bungeman@google.com Update site favicon to new theme. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: Ie53046779b84c9d70ba0d13b7a246bbfbc7a1e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466318Reviewed-by:
-
Patrick Brosset authored
Script chromium\src\third_party\blink\tools\blinkpy\web_tests\run_web_tests.py defines an argument called --layout-tests-directory However BUILD.gn uses it as --layout-test-directory (singular). This, apparently, is leading to issues when trying to run devtools web tests like here https://ci.chromium.org/p/devtools-frontend/builders/try/devtools_frontend_linux_blink_light_rel/7863? Bug: 1137356 Change-Id: I01f247d786caf59ab0baef6fb881739e99b805f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466197Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#816232}
-
Joshua Pawlicki authored
Bug: 1069814 Change-Id: I3715bd092ba30947541a7aaff766fe29cd3b73f1 Fixed: 1069814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453906 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#816231}
-
Klaus Weidner authored
Passing device-specific options was getting messy in xr_system/ xr_session. Use a containing structure to simplify this, and to avoid merge conflicts as in https://crrev.com/c/2438207 going forward. Bug: 1135789 Change-Id: Ie26affa410a1fad8a8ff9cd6686de452d2393ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440222Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#816230}
-
Aaron Tagliaboschi authored
Change-Id: If0e649e39efd9a6d7786021f64fdd3a3c8ec8662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461935Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#816229}
-
Fredrik Söderqvist authored
Seems unnecessary to bind some state - that's already bound to the owning object - into a subobject. Just keep a bool and call a function on SVGMaskPainter like we do for ClipPathClipper. Change-Id: I6f8a0a56a523b843014be3c7d6cfc7d2db8f0712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465908Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#816228}
-
Allen Bauer authored
Bug: 772945 Change-Id: Id3e59075546185b145f7389a2bcf30388ac59060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464322 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Stephen Chenney authored
These test fail due to anti-aliasing when the border image is scaled. They should be modified to use fuzzy matching when we finally support it. TBR: fs@opera.com Bug: 1133834 Change-Id: I91ea36ce62dafbc9d931d93172d7f75fa86fc874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464909Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#816226}
-
Kent Tamura authored
- Don't apply PixelSnappedWidth() and PixelSnappedHeight() as the sources - Adjust LayoutUnit with zoom level, then round it. - Apply testharness.js to images/zoomed-img-size.html This CL doesn't fix cases of 1% and 2%. It's expected. Bug: 1113987 Change-Id: Ib9cbd7c6beea2b5e7219eb87cfd32d6cc120595c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465350 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#816225}
-
Marc Treib authored
This better describes what it does, and is symmetric with DeactivateDataType. Similarly, DataTypeManagerImpl::RegisterTypesWithBackend is renamed to ActivateDataTypes. Bug: 647505 Change-Id: I780d4a3e31b93ca067f647c4465ec0e33e23230e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462271 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#816224}
-
Eric Willigers authored
Remove #include from source files that do not use ScopedFeatureList. Bug: 1137231 Change-Id: I6c094e63af68af44b0a23c4dc69d46d16cedd830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462972 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#816223}
-
Abigail Klein authored
When the Live Caption bubble appears, announce to assistive tech that the user should go to the Live Caption window. When the Live Caption bubble moves, announce to assistive tech that it has moved. AX-Relnotes: N/A (feature has not launched) Bug: 1055150, 1105676 Change-Id: I96310007c15fb929dbed0d17613731bf03b05047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453927Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#816222}
-
Willie Koomson authored
This change adds a check in ArcVmClientAdapter::StopArcInstance() to see if a VM is running (current_cid_ is set). If not, skip calling ConciergeClient::StopVm() and notify observers that ARCVM is stopped right away. BUG=b:169893632 TEST=arc.AuthPerf.unmanaged_vm Change-Id: Ic927f122cacea0e89cacffbbcd67a217772dba43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462573 Commit-Queue: Willie Koomson <wvk@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#816221}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ia1fb6ddabd8c6b0a8fea720662d2f4b4b703374c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462046Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#816220}
-
David Tseng authored
Change-Id: I86274af81a2d60223813cdfb91253abca97a766b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465383Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#816219}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2067d1a93e6e..69d0c1acc28a 2020-10-12 rverschelde@gmail.com Remove executable bits from code/data files (#2420) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com Change-Id: I956c21d527d9508e49c0e021f00f62762dd87bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466317Reviewed-by:
-
rbpotter authored
Last portion of a rebase of: https://chromium-review.googlesource.com/c/chromium/src/+/2443211 by dpapad@ onto the addition of a new resource_path grit property. This CL updates Print Preview to use the new manifest generation option in optimize_webui, combined with the resource_path grit property and generate_grd changes, to autogenerate the grd file in optimized builds. Bug: 1132403 Change-Id: I8f03064bbacd0ce993f59cf008ee27112d1934cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458878 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#816217}
-
Finnur Thorarinsson authored
Bug: 1135551 Change-Id: If6eb558fd23c74b16479a4f23b4327b522a828e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442691Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
-
Zach Trudo authored
Bug: chromium:1078512 Change-Id: I959ed70590b80770eef0edd44fd88ea940e1020e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459706Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#816215}
-
Idries Hamadi authored
Adds RectUtil class for computing coverage of multiple rects Add an OnPreDraw Listener to AwContents Provides a means for the Java side of AwContents to determine whether the WebView is displaying Open Web Content. Tracking is behind an experiment flag Bug: 1122091 Bug: 1122060 Bug: 1122203 Bug: 1122087 Change-Id: Ie8587525310c4b856bf08d9c2edd2af74ec376e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327050 Commit-Queue: Idries Hamadi <idries@google.com> Auto-Submit: Idries Hamadi <idries@google.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#816214}
-
Zach Trudo authored
CloudPolicyClient will be expanded to make use of a new server endpoint. This change prepares DeviceManagementService for that eventuality. Bug: chromium:1135951 Change-Id: I8b23d8dc112a8f583ddc249f01572cae9522d99b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454278Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/46d4522b161b..0f55e3e5d266 2020-10-12 lexa.knyazev@gmail.com Reland "Remove redundant BlendStateArray tracking" 2020-10-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 51b03d58fb17 to e72c6099f946 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1085996,chromium:1086582,chromium:1086585,chromium:1086586 Tbr: ynovikov@chromium.org Change-Id: Ibe5cf5d42a910067ee3f3282bf57815ddd07b120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465208Reviewed-by:
-
Hidehiko Abe authored
This reverts commit 2133e7d7. Reason for revert: The original revert was speculative. Relanding. Original change's description: > Revert "Fix ifdef guard for OS_CHROMEOS." > > This reverts commit fcffa1cc. > > Reason for revert: Reverting due to failure on Linux ASAN LSAN bot > See link below for failure details: > https://ci.chromium.org/p/chromium/builders/ci/Linux%20ASan%20LSan%20Tests%20%281%29/82545 > > Original change's description: > > Fix ifdef guard for OS_CHROMEOS. > > > > There's on going work to unset OS_LINUX on Chrome OS build, > > however, it is not yet completed, so it is still defined. > > > > This CL adds the explicit !defined(OS_CHROMEOS) to fix > > the behavior. > > > > Bug: 1110266 > > Test: Built locally. > > Change-Id: I60731672aabb6bb6025e29a0b641988e68ecade5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460826 > > Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> > > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#815116} > > TBR=hidehiko@chromium.org,guidou@chromium.org > > Change-Id: I59d4a9dfe96d45199c87fcf42a65d9e05e7b76d1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1110266 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462015 > Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815138} TBR=hidehiko@chromium.org,guidou@chromium.org,tluk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1110266 Change-Id: I086c838a52603f647d5dbc948e577e930d80ecd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466008Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#816211}
-
Egor Pasko authored
Disable CrossPlatformAccessibilityBrowserTestWithImplicitRootScrolling.ImplicitRootScroller on Android It fails since 2020-10-01 on test-o-phone. Tbr: dmazzoni@chromium.org Bug: 1137425 Change-Id: I6457626f3da9e021b888d0b92506262206105730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466239Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#816210}
-
Claude van der Merwe authored
Wifi Sync is enabled from a Chrome OS device if the multidevice setup is complete and the Wifi Sync flag is enabled on the Chrome OS device. This CL adds a pending state kEnableOnVerify that gets set when the Multidevice setup is complete on a Chrome OS device with the Wifi Sync flag enabled. The kEnableOnVerify state listens for the host to become verified and enables Wifi Sync if it is not already enabled. The kEnableOnVerify state gets cleared if the host device is removed. Bug: 1117619 Change-Id: I34070149b963629aa0ff0dc2da8c3022c2fcef5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457047 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#816209}
-
Moe Ahmadi authored
This reverts commit 174d9faa. Reason for revert: Breaking https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-cfi-thin-lto-rel See: https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-cfi-thin-lto-rel/24710 Original change's description: > build: In LTO links, run just one link at once, but give it all cores > > Normally, we allow running several links in parallel if there's enough > memory, since links tend to be memory- and io-bound, not compute bound. > However, in LTO builds the linker does codegen for every linked > translation unit, which needs a lot of CPU. > > Previously, we used to hardcode 8 threads per link for thinlto builds, > which makes builds needlessly slow on machines with many cores. > > Instead, automatically use all cores for a thinlto link, but only run > one link in parallel at once. > > chromeos-chrome-9999.ebuild in the Chrome OS build and link_jobs_32 in > mb_config.pyl currently manually set the number of threads per lto link > to the number of cores. Once this change here is in, we should stop > explicitly setting the arg there and then we can turn this from a gn arg > to a regular variable that's not settable in args.gn > > Bug: 1132930 > Change-Id: If2fda3e38b2b1827beb2da844f024f52211210db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464782 > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816129} TBR=thakis@chromium.org,hans@chromium.org Change-Id: Ic1d381681e00dbebd576ec44119d426518f4b778 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1132930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466261Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#816208}
-
Xianzhu Wang authored
Bug: 1136764 Change-Id: Id909f6ef11c914ca8ff4c468c669a60d0f04dd31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464015Reviewed-by:
-
Xiaohui Chen authored
Bug: b:170509871 Test: unittests and manually on nocturne Change-Id: Ib59a1c9e00056a5fdd13e5ee94cac51c365cf9b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462025Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#816206}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/109c355900d1..7c7b98f06001 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0adf5ba77c2c555b89df7d4232747c824ad5addf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466316Reviewed-by:
-
Mohamed Amir Yosef authored
Before this CL, each part of the badged icon was a views, however, this wasn't necessary since they were never placed using layout manager and users were never supposed to interact with them. This CL should introduce only minor visual difference. It however uses ImageSkiaOperations which: 1- Eliminates the need for 2 custom views. 2- Allows to use a more standard way for creating badged images by using gfx::ImageSkiaOperations::CreateIconWithBadge(). Bug: 1100814 Change-Id: Iaf84b61c4bae1d7130ae58513c9b287ba8eb55d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466276 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#816204}
-
Eric Willigers authored
Remove #include from source files that do not use ScopedFeatureList. Bug: 1137231 Change-Id: I2513187d4585930e0ac2a82a45cd15f0ffe2645a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463021 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Moe Ahmadi authored
Fixed: 1136654 Change-Id: I55f7cb4ca34332a33d81421a9a21475279e6fa08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463335Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#816202}
-
Victor Hugo Vianna Silva authored
Following crrev.com/c/2465744, the last usage of this class (in DataTypeController::GetStatusCounters() and similar methods) is unused in production code, so this CL removes the class. As for the methods, some are removed, while others are converted into *ForTest methods that don't make use of the class, in case they are still used in test expectations and there's no other good way of verifying those. The CL also removes the unimplemented method DataTypeDebugInfoEmitter::EmitStatusCountersUpdate(), so that there's no reference to the concept of StatusCounters in the sync codebase anymore. Bug: 1102849 Change-Id: I47dc92b6ce6f1631cc3762834770c54e3d47ea12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463611 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#816201}
-
Antonio Gomes authored
This is step 1.2 on the design document [1]. [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/edit BUG=1113900 R=jamescook@chromium.org, sky@chromium.org Change-Id: Ic625b887b00538d758260a3f35426c346bcdbabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458768 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#816200}
-
