- 13 Jun, 2018 40 commits
-
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7deacf4833dc..7c525e62d405 git log 7deacf4833dc..7c525e62d405 --date=short --no-merges --format='%ad %ae %s' 2018-06-12 robertphillips@google.com Plumb GrContext everywhere Created with: gclient setdep -r src/third_party/skia@7c525e62d405 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: Ibfa4ea0068bdda2d94fc48feffea5544344ae0a5 Reviewed-on: https://chromium-review.googlesource.com/1098835Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566796}
-
Ramin Halavati authored
Network traffic annotation tests on Windows FYI bot are failing. The scope of tests is reduced to minimum to check for error. TBR=georgesak@chromium.org Bug: 844014 Change-Id: Ib6ea2b50cc4bf5ca2c869daf7e133f0feac790f3 Reviewed-on: https://chromium-review.googlesource.com/1098655Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#566795}
-
Maxim Kolosovskiy authored
- introduces the metric of whether manual or automatic generation was triggered - fixes a bug in reporting NO_SIGN_UP_DETECTED and SIGN_UP_DETECTED - disables reporting of PasswordGenerationEvent if generation is disabled Bug: 851401 Change-Id: I4ccd4bfb5847d108a671571601e85fbf876de637 Reviewed-on: https://chromium-review.googlesource.com/1095177Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#566794}
-
Greg Kraynov authored
Change-Id: I674f1c9a1bb77dad743e0b879b3d45bd96df61ff Reviewed-on: https://chromium-review.googlesource.com/1097401 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#566793}
-
Tetsui Ohkubo authored
FeaturePodsContainerView should trigger PreferredSizeChanged() when child visibility is changed, and UnifiedSystemTrayView should propagate it. TEST=ash_unittests BUG=852248 Change-Id: I26e5050f44df0b4271d1bb8b774f5cda30a534f3 Reviewed-on: https://chromium-review.googlesource.com/1096928Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#566792}
-
Joel Hockey authored
* Add quickview test to FileManagerUITest * Fix error in create_test_main script which was creating invalid markup. Bug: 845830 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I23b9e587df0ac8e4cdd3a45db4a9faba3f13e7cd Reviewed-on: https://chromium-review.googlesource.com/1098754Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#566791}
-
Yoichi Osato authored
This patch cancels selection painting if the NGPaintFragment has no selection rect. This happens when we select the last line break but it is not painted whether it is selected or not anyway. The test was virtually passed image expectation but PaintUnderInvalidationChecking has made crash for above reason. Bug: 708452 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia1939c02aa6327f3dd7620920ec6b60a6b74b790 Reviewed-on: https://chromium-review.googlesource.com/1096592 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#566790}
-
Bernhard Bauer authored
Bug: 805070 Change-Id: I60095497d0dcf5029737ae511be13bb8d9af55d8 Reviewed-on: https://chromium-review.googlesource.com/1097412 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#566789}
-
Colin Blundell authored
https://chromium-review.googlesource.com/c/chromium/src/+/1090277 fixed //chrome's IdentityManagerFactory to properly handle incognito Profiles. The factories in //ios need to be fixed as well. After discussion with sdefresne@, I now realize that it's a safer pattern to have the //chrome-level class tying IdentityManager to KeyedService *wrap* IdentityManager rather than *hold* IdentityManager. The concrete reason is that that way all of the KeyedServiceFactory methods will Just Work as expected rather than needing custom code in the factory subclass to deal with the holder (as I had previously directed should be added to //chrome for dealing with incognito Profiles). This CL thus changes all the IdentityManager factories to have a private *subclass* of IdentityManager rather than a private *holder* of IdentityManager. By doing this, we also ensure that incognito mode will now be handled properly in the iOS IdentityManager factories without requiring any custom code (i.e., it will simply use the default KeyedServiceFactory infrastructure, which returns nullptr from GetServiceForBrowserState() when the browser state is incognito). Bug: 796544 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2a11fafd28f9c1003a40bcfd2cea50403276ea90 Reviewed-on: https://chromium-review.googlesource.com/1092497Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#566788}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/459c4d0417df..0db1e01e3f4c git log 459c4d0417df..0db1e01e3f4c --date=short --no-merges --format='%ad %ae %s' 2018-06-13 chiniforooshan@chromium.org Telemetry: Scroll up at the end of test PageTests Created with: gclient setdep -r src/third_party/catapult@0db1e01e3f4c The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:851523 TBR=sullivan@chromium.org Change-Id: I9c73ab9c69c2ce98c120ed1a97cf298cdafdf84d Reviewed-on: https://chromium-review.googlesource.com/1098715Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566787}
-
Hajime Hoshi authored
EventQueue no longer belongs to ExecutionContext but event target. This is a preparation of merging MediaElementEventQueue and EventQueueImpl. Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit# Bug: 846618 Change-Id: Ib09cc7ca837e9900885824b3786209bafba59a30 Reviewed-on: https://chromium-review.googlesource.com/1090697Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
load_flags is set from fetch_credentials_mode in renderer/loader but for preflight requests we need to set it manually. Bug: 736308 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I7ff8b945c091bf1195dd83318d74945c5020aece Reviewed-on: https://chromium-review.googlesource.com/1095124 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#566785}
-
Peter E Conn authored
Notify the user via Toast that an opened Trusted Web Activity is part of Chrome and therefore will have access to their cookies, autofill data, etc. This is shown at most once per week for a single app. Bug: 813100 Change-Id: I7f921637ffa042ff4d0f076ad4ca007708f06879 Reviewed-on: https://chromium-review.googlesource.com/1097399 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#566784}
-
Tatiana Gornak authored
TBR=avi@chromium.org Bug: 852232 Change-Id: I45351c0c7f919a28d75a481bd1130d6682435a6b Reviewed-on: https://chromium-review.googlesource.com/1098667Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#566783}
-
Tatiana Gornak authored
Disables SingleClientDirectorySyncTest.DeleteDirectoryWhenCorrupted due to repeated flakes on Win TBR=treib Bug: 850980 Change-Id: I68b330145218982dd6be976a3c62f7713128be11 Reviewed-on: https://chromium-review.googlesource.com/1098665Reviewed-by:
-
Blake O'Hare authored
The names DismissKeyboard, MaybeHideKeyboard, and HideKeyboard don't fully explain what it is they do differently from each other. We've been having trouble with changes to the HideKeyboard behavior being somewhat brittle and confusing since the calling sites don't always fully express what it is it's trying to accomplish by hiding the keyboard. This will hopefully prevent future regressions. Change-Id: I0c15934a871ead71e1e5656c2cb97c9ff5f548ce Reviewed-on: https://chromium-review.googlesource.com/1092220 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#566781}
-
Dominic Battre authored
This is just a tiny cleanup that has been suggested on a previous CL. Bug: 846694 Change-Id: I0462c6b6a88d434ccbd4f41fa11513628b0e7ea7 Reviewed-on: https://chromium-review.googlesource.com/1098662Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#566780}
-
Alex Clarke authored
Seems there where some hard to understand crashes associated with it. I aim to re-land if possible. Change-Id: Iaf6a179ef186c1b0d027c17fa9276fafef23f55e Bug: 851381 Reviewed-on: https://chromium-review.googlesource.com/1097489Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/241d0c16c0d3..1f4d7a28484f git log 241d0c16c0d3..1f4d7a28484f --date=short --no-merges --format='%ad %ae %s' 2018-06-13 qingsi@google.com Revert "Refactor the regathering of candidates in P2PTransportChannel." Created with: gclient setdep -r src/third_party/webrtc@1f4d7a28484f The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iba7b2cc3a4ba1257db5be752d29327fe72c577f3 Reviewed-on: https://chromium-review.googlesource.com/1098795Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566778}
-
Max Morin authored
The case where the connection is broken by the renderer is logged incorrectly. Bug: 851865 Change-Id: I72a69c5b9fa84a6f8c569b29fbcb0528c16c0524 Reviewed-on: https://chromium-review.googlesource.com/1096770 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#566777}
-
Alexandr Ilin authored
This reverts commit 2f220c33. Reason for revert: TBD Original change's description: > Revert "predictor: Switch to WebContentsObserver to observe resource loads." > > This reverts commit e9fcce49. > > Reason for revert: > Findit identified the culprit r565609 with confidence 70.0%. > See https://bugs.chromium.org/p/chromium/issues/detail?id=851232 > > > Original change's description: > > predictor: Switch to WebContentsObserver to observe resource loads. > > > > This CL is needed to make the preconnect predictor work with the Network > > Service. The CL removes the LoadingPredictorObserver class that has been > > notified by the ChromeResourceDispatcherHostDelegate and introduces instead the > > LoadingPredictorTabHelper which implements the WebContentsObserver to notify > > the predictor about resource loads. > > > > All uses of the net::URLRequest and predictors::URLRequestSummary was replaced > > by using the predictors::NavigationID or the content::mojom::ResourceLoadInfo. > > > > The WebContentsObserver::ResourceLoadComplete() should work with and > > without the Network Service, so we don't have to keep the old path. > > > > Bug: 809583 > > Change-Id: I05c0aa97cfab1d773285633e6c5c3ef6a91367ca > > Reviewed-on: https://chromium-review.googlesource.com/1039526 > > Commit-Queue: Alexandr Ilin <alexilin@chromium.org> > > Reviewed-by: Matt Menke <mmenke@chromium.org> > > Reviewed-by: Lei Zhang <thestig@chromium.org> > > Reviewed-by: Michael Wasserman <msw@chromium.org> > > Reviewed-by: Benoit L <lizeb@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#565609} > > TBR=msw@chromium.org,thestig@chromium.org,mmenke@chromium.org,lizeb@chromium.org,alexilin@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 809583 > Change-Id: If1bf3e4b6e98fbd716b9b994b0ee0c69cafc7036 > Reviewed-on: https://chromium-review.googlesource.com/1094955 > Reviewed-by: Hayato Ito <hayato@chromium.org> > Commit-Queue: Hayato Ito <hayato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565945} TBR=msw@chromium.org,thestig@chromium.org,hayato@chromium.org,mmenke@chromium.org,lizeb@chromium.org,alexilin@chromium.org Change-Id: I10444584eb2a216db16066cd5909e51ed4e27fda No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 809583 Reviewed-on: https://chromium-review.googlesource.com/1095874Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#566776}
-
Ulan Degenbaev authored
This adds the following histograms: - V8.GCFinalizeMC.Clear - V8.GCFinalizeMC.Epilogue - V8.GCFinalizeMC.Evacuate - V8.GCFinalizeMC.Finish - V8.GCFinalizeMC.Mark - V8.GCFinalizeMC.Prologue - V8.GCFinalizeMC.Sweep The CL also cleans up the description of other V8.GCFinalizeMC* histograms. Bug: chromium:850508 Change-Id: I069105809393d16ee09aa7c75ddaf5dec6c9d8e6 Reviewed-on: https://chromium-review.googlesource.com/1095156Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#566775}
-
stkhapugin@chromium.org authored
Enables the UI Refresh location bar flag by default. Fixes a test that was attempting to tap the location view twice. Bug: 821821 Tbr: noyau@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I02ad0dfbc98d86183b1a3628e2195b28e8993cd6 Reviewed-on: https://chromium-review.googlesource.com/1090929 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#566774}
-
Alexandr Ilin authored
This CL fixes a race condition in the HostedAppTest.ShouldShowLocationBarDangerous test. This test sets an app, makes all further certificate validations to fail and then navigates inside the app to the app url. The test expects that an interstitial page will be shown after the navigation. Hovewer, there is a small probability that the nullptr will be returned from WebContents::GetInterstitialPage(). The reason is that another navigation is triggered when the app is created and the test doesn't wait for this navigation to complete before setting cert_verifier to return an error. Two navigations trying to display an interstitial page at the same time may make this test fail. The fix is simple, we just have to wait for the first navigation to complete before doing anything else. Bug: 851232 Change-Id: Ic3d55321efb23df726c8e178912704e15f3a54c8 Reviewed-on: https://chromium-review.googlesource.com/1097477Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#566773}
-
Ganesh Borle authored
Bug: 561800 Change-Id: I9da77edbdb6777a3fc25bed30275c72e9790d88f Reviewed-on: https://chromium-review.googlesource.com/952882Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com> Cr-Commit-Position: refs/heads/master@{#566772}
-
Hajime Hoshi authored
This CL is just a pure refactoring. RelatedEvent was removed at https://codereview.chromium.org/2905763003. Change-Id: Ib0c4a31944075a9361618ec556544a97bbb95cc0 Reviewed-on: https://chromium-review.googlesource.com/1096732Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#566771}
-
Yoshifumi Inoue authored
This patch makes file local funciton |NonInlineBlockFlow()| in "ax_node_object.cc" to use |IsAtomicInlineLevel()| to make this funciton to work both legacy layout and LayoutNG. Note: |IsAtomicInlineLevel()| is a bitfiled in |LayoutObject|. It is set by |LayoutBlock::StyleWillChange()| when compute style has "display:inline-block". Therefore, in legacy layout, when |IsAtomicInlineLevel()| is true for |LayoutBlockFlow|, |!InlineBoxWrapper() == !IsAtomicInlineLevel()|. In LayoutNG, |IsAtomicInlineLevel()| is used for computing physical fragment box type in |BoxTypeFromLayoutObject()|. |BoxTypeFromLayoutObject()| returns |NGBoxyType::kAtomicInline| for |IsAtomicInlineLevel()|. Bug: 591099 Change-Id: Ieafd8a414662df7e0d4f48f1b15657a602265559 Reviewed-on: https://chromium-review.googlesource.com/1092224Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#566770}
-
Yoichi Osato authored
This patch imports the paint logic from InlineTextBoxPainter, converts DOM offset to inline offset and paint markers with NGPhysicalTextFragment. Here is copied functions from InlinTextBoxPainter to NGTextFragmentPainter: PaintSingleMarkerBackgroundRun PaintStyleableMarkerUnderline PaintDocumentMarkers This patch fixes: paint/markers/active-suggestion-marker-basic.html paint/markers/composition-marker-basic.html Bug: 850448 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6126bcc3880fe8ba9bd0ebd6262bae4cd7b762be Reviewed-on: https://chromium-review.googlesource.com/1090601 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
Jun Mukai authored
This CL looks up the policy blob data for the offline demo mode from the filesystem and goes through the enrollment flow. Bug: 827290 Change-Id: Id23959bb710a08db2ad64cf838b15a3b21457cef Reviewed-on: https://chromium-review.googlesource.com/1048166 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#566768}
-
Yutaka Hirano authored
Bug: 851858 Change-Id: I332467c9ac043408e8a44c41047ef511131e96eb Reviewed-on: https://chromium-review.googlesource.com/1098635 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#566767}
-
Richard authored
We do not have 'handle' concept now, this CL just renames class ServiceWorkerHandle to ServiceWorkerObjectHost as it implements mojom:: ServiceWorkerObjectHost. Change-Id: I004c45bdf739cc32e0a89c9c4221d352457d9d2f Reviewed-on: https://chromium-review.googlesource.com/1090574 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#566766}
-
Colin Blundell authored
This CL follows the motivations of https://chromium-review.googlesource.com/c/chromium/src/+/1095108 to make the same change for the SetInvalidRefreshTokenForAccount() and RemoveRefreshTokenForAccount() APIs as that CL made for the SetRefreshTokenForAccount() API. Bug: 798699 Change-Id: If3701f0d42fd0129ed324dc8b9f7ac7402c1cb3d Reviewed-on: https://chromium-review.googlesource.com/1097087Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#566765}
-
Daniel Cheng authored
Bug: none Change-Id: Id43c913c699283df72696c8f97b7b869befeebd1 Reviewed-on: https://chromium-review.googlesource.com/1093265Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#566764}
-
Christopher Lam authored
This CL fixes an issue where the overlay didn't hide the toolbar properly so it could still be tabbed to, and a corresponding problem where overlay buttons could be tabbed to when not visible. Bug: 851835, 851864 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1562211745c2373ee64a85936953137f2541ae48 Reviewed-on: https://chromium-review.googlesource.com/1098420 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#566763}
-
Yutaka Hirano authored
Bug: 736308 Change-Id: I3e0f76acc7269d54ed86999d7938384f9c2171e1 Reviewed-on: https://chromium-review.googlesource.com/1095118 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Noel Gordon authored
With more speed, add more coverage: run open Quick View case in Tablet mode, and in Guest mode (so easy). Add a Quick View open test case for an ephemeral volume (USB here). Tablet (aka fully immersive) mode is not supported in Mash: add a Mash bot exclusion for the Tablet mode case. Bug: 851888 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I893f35838731b3264268b027a00a86c339bf5b3f Reviewed-on: https://chromium-review.googlesource.com/1098432 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
This is a cleanup CL and doesn't change behavior except LAPIs support (see below). Before this CL, ModuleScriptFetcher is an implementation of module script fetch for <script type='module'> on Documents, and WorkletModuleScriptFetcher is a subclass of ModuleScriptFetcher that implements the custom fetch hook for Worklets. This override reduces code duplication, but also makes it difficult to read code. After this CL, ModuleScriptFetcher becomes just an interface. DocumentModuleScriptFetcher implements it for Documents, and WorkletModuleScriptFetcher implements it for Worklets. This separation makes it easier to read code and to add a new variant of ModuleScriptFetcher for Workers, there're some duplicate code among DocumentModuleScriptFetcher and WorkletModuleScriptFetcher though. Note that this CL tentatively drops LAPIs support for worklets. This is safe because it has been flagged feature and not ready for worklets so far. We'll re-add the support after refactoring around ModuleScriptFetcher. Change-Id: I60fa46ebd86e046da811f018219cdd02411529a8 Bug: 842553 Reviewed-on: https://chromium-review.googlesource.com/1096919 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#566760}
-
Rohit Rao authored
When switching between incognito and non-incognito BVCs, it is possible for all of the toolbar's buttons to be temporarily hidden. We believe that this results in the stack view having zero width, which seems to permanently break autolayout on iOS 10. Adding an optional width constraint seems to work around this issue. BUG=851954 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6995f2b3f5fa3b0f2eafb09e3970001fd16720f6 Reviewed-on: https://chromium-review.googlesource.com/1097207Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#566759}
-
Nicholas Verne authored
Also adds a browsertest for CrostiniUninstallerView. Bug: 849438 Change-Id: I13ff94ec9324be0c01757f3094d76403c1d3b30f Reviewed-on: https://chromium-review.googlesource.com/1092397 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#566758}
-
Nicholas Verne authored
This relands commit 9ec0dfc9. In viz_browser_tests and mash_browser_tests it is possible for RunLoop::RunUntilIdle to return in a test while there are still pending tasks (on another task runner). We delay the test's continuation until the appropriate condition on FakeConciergeClient is satisfied. Bug: 851253 Change-Id: Iab1ade58607efae9ca7666666e0f77210d5973c1 Reviewed-on: https://chromium-review.googlesource.com/1096587Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
-
