GitLab

This serves as a base class for us to send UI updates for both download and
offline items

Bug: 881499
Change-Id: I54e50191764f9796250be02c7461cb96b9fa85a6
Reviewed-on: https://chromium-review.googlesource.com/1226456
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591505}

Bug: None
TBR: rsesek,kinuko,kouhei
Change-Id: I2dda1e9ed0bcdf822a3d310a1654fded31eb8038
Reviewed-on: https://chromium-review.googlesource.com/1227355Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591504}

Implement error handling in content storage, and change callback in java
to lambda.

Bug: 884230

Change-Id: I0dd9999dc221e7fb4d030d2b8f56d16482b04985
Reviewed-on: https://chromium-review.googlesource.com/1226079Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591503}

It was getting a bit cluttered in ExploreSitesBridge, so this
creates an ExploreSitesBridgeExperimental that contains all
the code required for the "experiment" version (that is still
in use behind a flag.)

Bug: None
Change-Id: Ie5575d1960ef7016a08f7b4eff56327fa15ce1d7
Reviewed-on: https://chromium-review.googlesource.com/1227216
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591502}

During thread exits TLS clears its storage vector. If after that
a memory is allocated/deallocated profiler hooks gets triggered and
access the TLS which makes it reallocate the storage vector that
is then never deallocated.

The patch makes profiler do not rely on base::ThreadLocalStorage
and use the OS primitives directly.

BUG=881352,803276

Change-Id: I8493768e57e4121c9ce38d09c77f8d38b04941b3
Reviewed-on: https://chromium-review.googlesource.com/1225280Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591501}

Because views login hasn't implemented the code path to transition
between web-ui OOBE to views-login directly, the web-ui public session
pod is shown one-time only right after the enrollment completes. So for
this bug, we should implement the web-ui and views versions separately.

Bug: 882692
Change-Id: Ia3945b2dbfdb3a2e38db4d59c74248a29004bf37
Reviewed-on: https://chromium-review.googlesource.com/1226256Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591500}

In a prior CL, GraphicsPipeline Metrics were added to AsyncLayerTreeFrameSink
but the browser process does not use that when OOP-D is off. This CL adds
those metrics to DirectLayerTreeFrameSink in order to allow us to do comparisons
in Finch trial.

Bug: 881262
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I8d3a7c41603d1b84e8d72ef530189b7864361c40
Reviewed-on: https://chromium-review.googlesource.com/1227141Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591499}

Up to version 7.14.1.1210, per customer report of poor behavior.

Bug: 879098
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I29f5b3b501d2ff17572bcab1d490d4c308f398f3
Reviewed-on: https://chromium-review.googlesource.com/1218445
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591498}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/41562c7c..7a02a8fc

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ic79b20ecf2943d3f2f64aa99630f0bb98b9bcdb4
Reviewed-on: https://chromium-review.googlesource.com/1227308Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#591497}

Update parsing of proxy settings in session capabilities, for W3C
compliance. Changes include:
* Handle noProxy containing a list of strings.
* Handle socksProxy and socksVersion.
* Return kInvalidArgument for errors.

Bug: chromedriver:2537
Change-Id: I545291b8249e147f75babee5dfe72137bfc4cdca
Reviewed-on: https://chromium-review.googlesource.com/1226096Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591496}

This is implemented by adding a GetCatalogTask that has a few jobs:
* Return the current catalog
* Update the current catalog if there is one in the DB and it's the
  first time the catalog was requested since Chrome started.

Also removes the "usable_on_ntp" boolean column from the sql store
as it doesn't have a clear use in the design doc.

Bug: 867488
Change-Id: I17ff725633f13e57a542e7e48fcf974a1ae1a3d1
Reviewed-on: https://chromium-review.googlesource.com/1226193
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591495}

Some strings are only used by //chrome and can be moved to //chrome/app
string targets. Some are used by //chrome and //ash and are moved to
//chromeos/chromeos_strings.grd

Bug: 756095
Change-Id: If7b3b89486035d36505f6d133b35593d10570f20
Reviewed-on: https://chromium-review.googlesource.com/1213585Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591494}

It is currently set to 10 minutes, which means that test suites
will time out first so we don't get a chance to provide a useful error
message. It also makes reproing issues difficult because you need
to wait for 10 minutes for them.

Note that because of various retries, this could amount to 60 seconds
of total time because of 2 ChromeDriver retries * 3 higher level retries.

Bug: b/115528744
Change-Id: I15753fd5ac27e5d5ec36aa4f81a1a80133f4d6ff
Reviewed-on: https://chromium-review.googlesource.com/1227307Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591493}

TBR=dtrainor@chromium.org
BUG=884280

Change-Id: Idb8b32c3f7418017bd0f6f7bae1e89f14cd2a060
Reviewed-on: https://chromium-review.googlesource.com/1225898Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591492}

Bug: 877519
Change-Id: I738d6f7f871413e2df493bc7918538be441464e0
Reviewed-on: https://chromium-review.googlesource.com/1219990
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591491}

In the case where the image cache is used with a color type other than
N32, the software cache performs the original decode in the target
color type followed by a scale operation. While the GPU cache always
decodes to N32, scales it and then performs the color type conversion.

Switch the GPU cache to have the same behaviour as software cache.

R=ericrk@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0199eefbc19b6038e2439d53946af0608afd498c
Reviewed-on: https://chromium-review.googlesource.com/1223337Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591490}

The test has been disabled for 5 years.

Bug: 316334
Change-Id: I34e4e0ebb407220cec9294a513b164f18e2af135
Reviewed-on: https://chromium-review.googlesource.com/1226160Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591489}

Bug: 866126
Change-Id: Ib6af1a8ae3e21354bef52257447dc9c2268aea8a
Reviewed-on: https://chromium-review.googlesource.com/1222875
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591488}

R=khorimoto@chromium.org

Bug: 884323
Change-Id: I86ee823ac4d22f72792baf2494b504b53aa680c2
Reviewed-on: https://chromium-review.googlesource.com/1227225
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591487}

As noted in the comments in that file, it is essentially the same as
https://github.com/WebKit/webkit/blob/master/LayoutTests/webaudio/gain.html
which was moved from there to WPT as gain.html.  This test is now
basically redundant and adds no additional coverage.

Bug: 883167
Change-Id: Ie50111e263790025c615b64ad8f5e06428ae3177
Reviewed-on: https://chromium-review.googlesource.com/1221477Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591486}

Re-enabling this test just long enough to collect logs from a couple
of flakey runs of the test.

TBR=kenrb@chromium.org

Bug: 882458
Change-Id: Icb727a91a0b4178cf4cf18a162d218c78f47371f
Reviewed-on: https://chromium-review.googlesource.com/1227306Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591485}

This reverts commit 9fc367df.

Reason for revert: Broke bot

Original change's description:
> Linux ARM: Use swarming mixins
> 
> This change is deliberately small (only changing one builder) to make
> sure the feature is working correctly.
> 
> Bug: 880973
> Change-Id: If9ffea3eadc461a994cd7dcc409b9b8206871024
> Reviewed-on: https://chromium-review.googlesource.com/1222165
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#591241}

TBR=dpranke@chromium.org,kbr@chromium.org,martiniss@chromium.org,bpastene@chromium.org,jbudorick@chromium.org

Change-Id: I0aca3b5b53c5f74f0af8f5fc287051cc4457cdd2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 880973
Reviewed-on: https://chromium-review.googlesource.com/1227394Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591484}

Previously, IOv2 layout tests would enable IOv2 in script via:

if (window.internals && internals.runtimeFlags) {
  internals.runtimeFlags.intersectionObserverV2Enabled true;
}

There are two problems with this approach:

1. By the time the above code runs, it may be too late: the prototype
for the IntersectionObserverEntry javascript type may already have been
created *without* the isVisible attribute. This was causing flaky test
failures, because the exact timing of when the prototype is created may
vary between runs.

2. Because the layout test runner re-uses content_shell processes for
multiple tests, the side effects from turning on the feature flag
affect tests that later use the same renderer process (see bug).

This CL also adds DisableIntersectionObserverV2ThrottleForTesting,
which eliminates the need to add a bunch of 100ms timers to the tests.
Slow tests are bad.

Finally, this CL reorders the handshake for cross-origin tests that
rely on postMessage, to ensure that both the embedding frame and the
child frame are properly initialized before starting the test
procedure.

BUG=882280,883676
R=chrishtr@chromium.org,foolip@chromium.org

Change-Id: I18e62c2cf099bf74ef4afc43f46a794c7a322582
Reviewed-on: https://chromium-review.googlesource.com/1220044
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591483}

So that builder pools can be merged in bots.cfg

Bug: 868213
Change-Id: Iea69b964ad411c15ee5c79fb67af7dff61792449
Reviewed-on: https://chromium-review.googlesource.com/1227146Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591482}

Fork the arm builds so we can enable vp9 profile 2 (high bit depth) on
chromeos devices without affecting other arm devices.

BUG=chromium:875773

Change-Id: I23a9c2875a8585e2fd4e45ecc2a0e8b3ab317585
Reviewed-on: https://chromium-review.googlesource.com/1227217Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#591481}

Bug: 866125
Change-Id: I8f4da0990340d71342076f2d3ee5565267ad37f2
Reviewed-on: https://chromium-review.googlesource.com/1222683
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591480}

|window.opener| in main frame can point at a subframe (if the subframe
called before |window.open('', '<name of the main frame>')|.  If both
frames are at about:blank, this can lead to an infinite loop in
ScriptContext::GetEffectiveDocumentURL.

Bug: 883526
Change-Id: I49b93b0bd068b1d0f2ea0241d0ede32ec6d6c689
Reviewed-on: https://chromium-review.googlesource.com/1222877
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591479}

Touch selection editing handles use window targeting insets.
(to let users more easily tap text above the visible handle)

Adjust targeting of the handle's client root window in Mus.
(otherwise events target the server's invisible root window)

Bug: 872891
Test: KSV (Ctrl-Alt-/) touch edit handles don't block tapping text.
Change-Id: I6d8614257dc4927a1562bc02c2eefef1f8ff2faa
Reviewed-on: https://chromium-review.googlesource.com/1226877Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591478}

This reverts commit d91dacc0.

Reason for revert: Failed base_unittests Run on OS: 'Ubuntu-14.04'
SequenceBoundTest.MultiplyDerivedDestructionWorksLeftSuper
SequenceBoundTest.MoveAssignmentFromDerivedClass
SequenceBoundTest.MoveConstructionFromSameClass
SequenceBoundTest.MoveAssignmentFromSameClass
SequenceBoundTest.PostBeforeConstruction
SequenceBoundTest.MoveConstructionFromDerivedClass
SequenceBoundTest.MultiplyDerivedPostToLeftBaseClass
SequenceBoundTest.ConstructThenPostThenReset
SequenceBoundTest.MoveAssignmentFromDerivedClassDestroysOldObject
SequenceBoundTest.MultiplyDerivedDestructionWorksRightSuper
SequenceBoundTest.MultiplyDerivedPostToRightBaseClass

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/10148

Original change's description:
> SequenceBound<T> for classes with affinity to a sequence.
> 
> SequenceBound<T> allows for easy creation, posting, and destruction
> objects of type T on a designated Sequence.  It does not expose the
> underlying pointer to T, so it's hard to accidentally pass them around
> in callbacks that are then run on the wrong thread.
> 
> A SequenceBound<> may be created anywhere, passed (moved) between
> threads, etc., safely.  Destruction of the SequenceBound schedules
> destruction of the underlying instance of T on the appropriate thread.
> 
> Not implemented here (but prototyped elsewhere) are weak pointers
> to these objects that may be passed and used between threads safely;
> utility functions to generate thread-hopping callbacks; support for
> strong shared ownership semantics.
> 
> Tests: sequence_bound_unittest.cc
> 
> Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I3bbf7e975884fce8e18f3bb15a0d211ead58a619
> Reviewed-on: https://chromium-review.googlesource.com/875241
> Commit-Queue: Frank Liberato <liberato@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#591429}

TBR=dcheng@chromium.org,dalecurtis@chromium.org,liberato@chromium.org,tzik@chromium.org

Change-Id: I122ffbe8eb1670e7a252392fb7c28652672d1bc7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1227356Reviewed-by: Jian Li <jianli@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591477}

Use =default in some places where we can, to avoid hand-writing
move constructors and move assignment operators.

Also adds a move constructor to NG{Unp,P}ositionedFloat and adds a
missed std::move call.

R=eae@chromium.org,ikilpatrick@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I8c3c850d495b455a9a6dddff0b62f3dcf1927c64
Reviewed-on: https://chromium-review.googlesource.com/1226008Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591476}

https://skia.googlesource.com/skia.git/+log/776a411b5267..a7914d3a8e3b


git log 776a411b5267..a7914d3a8e3b --date=short --no-merges --format='%ad %ae %s'
2018-09-14 michaelludwig@google.com Implement textured gradients
2018-09-14 csmartdalton@google.com ccpr: Remove the dangling pointer from GrCCDrawPathsOp
2018-09-14 robertphillips@google.com Harden SerializedImageFilter fuzzer against filter creation failure
2018-09-14 robertphillips@google.com Preserve fLastMoveToIndex in SkPath::transform
2018-09-14 caryclark@skia.org fix error reporting for doc examples
2018-09-14 michaelludwig@google.com Implement dual interval gradients


Created with:
  gclient setdep -r src/third_party/skia@a7914d3a8e3b

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=caryclark@chromium.org

Change-Id: I7d0ec294f34b7e529cc1623651a44312662caf88
Reviewed-on: https://chromium-review.googlesource.com/1226387Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#591475}

In WebKit there were multiple WebPopupType values, such as None, Select,
Suggestion, Page, HelperPlugin. In Blink however there are only two:
None - it's not a popup, it's a frame.
Page - it is a popup.

As such, when creating a popup widget, there is no need to specify the
PopupType, as it would always be Page.
And when creating a frame widget, there is also no need as it will be
None always.

To this end, we make a few changes:
1. WebPopupType is not needed in blink, so move to content/public/
and rename it to WidgetType (as it is indeed the type stored on
RenderWidget and RenderWidgetHostViewBase.

2. Do not plumb WebPopupType through the RenderWidget's
CreateForPopup() path, nor through the mojo calls to the browser
when creating the widget and setting up the routing id.
RenderMessageFilter::CreateNewWidget() is only called for popups
so does not need the enum.

3. Thus plumbing continues being removed up through to
WebContentsImpl where we do end up calling CreateNewWidget() with
the enum for fullscreen widgets (which are frames) and for popup
widgets, so we keep the enum there.

4. The mac RenderWidgetHostNSViewBridgeLocal class was receiving
the popup type from the RenderWidgetHostViewMac when it is called
(via mojo) to InitAsPopup(). This path is only used when making a
popup widget, not a frame widget, so we:

4a. DCHECK and stop plumbing the WebPopupType over to the
RenderWidgetHostNSViewBridgeLocal class. It had a TODO mentioning
that the PopupType == Page should be equal to there being a
popup_window_, which it is as they are set together. So change
IsPopup() there to check the popup_window_ instead.

4b. Also stop plumbing the PopupType to PopupWindowMac, which
was setting RenderWidgetHostViewCocoa::setCanBeKeyView to NO
if the PopupType was Page, which it always would be. So just
set it to NO always.

5. The RenderMessageFilter::CreateNewWidget() call returns a
routing id which is never 0, however the RenderWidget was
checking for 0 and returning nullptr in that case. Instead
DCHECK and stop returning nullptr so callers also won't have
to check.

There are a bunch of function/variables named for WebPopupType
instead of WidgetType that could change but will be done in a
follow-up instead.

R=awong@chromium.org, ccameron@chromium.org, dcheng@chromium.org

Bug: 419087
Change-Id: I88d6eba93cf737b47b823dbead55664cb514fa4a
Reviewed-on: https://chromium-review.googlesource.com/1225608Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591474}

A disassembly of CGSSetDenyWindowServerConnections indicates that it only
actually does anything when there are no currently open WindowServer
connections. There should be no open connections, so we call it and verify
that we succeeded.

Bug: 880886
Change-Id: I59bce619d1e684da1fc9356a89c129f990c8e91c
Reviewed-on: https://chromium-review.googlesource.com/1150668
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591473}

a521447214be Use x30 register instead of LR, which GCC doesn't seem to
             understand
78bf924fa63d linux: Read /proc/<pid> files via PtraceConnection
9dcf4ab23efc arm/linux: Fix build after a5214472
b918119ca20a linux: Read thread IDs via a PtraceConnection
076d760d636a linux: Check for SO_PASSCRED on client sockets before
             setting
8595f4b4231d linux: allow collecting scheduler priorities to fail

Change-Id: I548d90da4e2c6a85a3508b3fb7d84a8319977df6
Reviewed-on: https://chromium-review.googlesource.com/1226358Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591472}

R=benmason@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I4bb7b84d18dd9b625a795aaa873ff821756ea442
Reviewed-on: https://chromium-review.googlesource.com/1227227Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591471}

Reenable some of the flaky NoScript browser tests.
This CL includes two fixes:
1. Ensure that some of thread unsafe variables are not
referenced cross-thread.
2. Disables loading of blacklist database which is racy with the
first page load. At least one of the test flakes that I
reproduced locally was because of this.

Change-Id: If3c7190532f5feebf686f02dd9a3003e7396f9f4
Bug: 869781
Reviewed-on: https://chromium-review.googlesource.com/1226851Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591470}

When only running the service manager, a simple PrefService containing user
PrefStore and commandline PrefStore can be created before BrowserProcessImpl.
And it will be passed to the BrowserProcessImpl to create the local_state.
The implementation has already landed here:
https://chromium-review.googlesource.com/c/chromium/src/+/1148959
This CL makes it possible to migrate the simple PrefService to local state
by adding new pref stores, rather than creating the latter from scratch.
The benefit of doing this is that existing listeners to the simple PrefService
won't need to handle the case of swapping PrefServices,
re-registering PrefChangeRegistrar and default values, and verifying no
pref value changes during the swap.


Bug: 866028
Change-Id: I35b643d27ffabd9621f21f68a3261aa3482ca173
Reviewed-on: https://chromium-review.googlesource.com/1199944
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591469}

This is a CL with temporary diagnostic code for
https://crbug.com/882458.

This CL will be landed and left in ToT long enough to collect data, and
then reverted quickly, and certainly prior to the next stable branch
cut.

Bug: 882458
Change-Id: I5c5d1f2e26a032f743a86af6f335e6942f97e423
Reviewed-on: https://chromium-review.googlesource.com/1227130Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591468}

Change-Id: Ic76d28bc5f3e4b0165fc2f6f1433f08c9b3701a6
Reviewed-on: https://chromium-review.googlesource.com/1225282
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591467}

Make AuraTestHelper take a given aura::Env and do the test setup
for that Env. TestWs uses it to setup an aura::Env for WindowService
when running in single process mode.

Bug: 874089
Change-Id: I65914ed9942c6ce779cdde4a31ef04d727c8fb29
Reviewed-on: https://chromium-review.googlesource.com/1226365Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591466}