Commits · ddb1d689331aef84c2b94c6ec2dcc7b831579655 · eriksson monteiro / tangled

31 Aug, 2020 40 commits

Fix use-after-move in //content/browser/service_worker/ · ddb1d689

Maksim Ivanov authored Aug 31, 2020

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I987800bb2b59f29899c308125594d45b4d409a38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382759Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803087}

ddb1d689

[mathml] Introduce LayoutNGMathMLBlockFlow · f3eef02a

Rob Buis authored Aug 31, 2020

Introduce LayoutNGMathMLBlockFlow to mark the block flow as a MathML
layout class, currently only used for operators (mo).

A follow-up CL will introduce an UpdateFromElement method on it to
deal with operator attribute changes.

This CL does not yet introduce an operator layout algorithm (which will
allow things like stretching) and falls back to the block layout
algorithm for operators.

Bug: 6606
Change-Id: I5ed10f7e27bdd08be2eb576d297067ac790241bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382601
Commit-Queue: Rob Buis <rbuis@igalia.com>
Reviewed-by: Frédéric Wang <fwang@igalia.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803086}

f3eef02a

Roll src-internal from 45c7cc03636d to be19a45481cf (1 revision) · 41ecc1ca

chromium-internal-autoroll authored Aug 31, 2020

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/45c7cc03636d..be19a45481cf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC kolos@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: kolos@google.com
Change-Id: Ie8193db2cbc16ec72b9327c8fc1ae346b6d5ab88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384853Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803085}

41ecc1ca

Roll WebRTC from e3e2618b1b05 to c2cc4d305a7c (3 revisions) · 226fbd1b

chromium-autoroll authored Aug 31, 2020

https://webrtc.googlesource.com/src.git/+log/e3e2618b1b05..c2cc4d305a7c

2020-08-31 ilnik@webrtc.org [adaptation] Expose target pixels and max framerate in VideoAdapter
2020-08-31 mbonadei@webrtc.org Move ABSL_MUST_USE_RESULT at the beginning of the method decl.
2020-08-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4bf6d398..a50ca66b (802598:802712)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1116430,chromium:1122891
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ib9b42743db058e452398d48bb87b59ce8eb603ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384856Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803084}

226fbd1b

Reland "OOR-CORS: Remove BlinkCORS related tests" · 67aa394e

Maxim Kolosovskiy authored Aug 31, 2020

This reverts commit cd8566c8.

Reason for revert: this CL didn't cause the problem. The root cause was a tricky infra problem. sorry for wrong revert.

Original change's description:
> Revert "OOR-CORS: Remove BlinkCORS related tests"
> 
> This reverts commit 7d2bed26.
> 
> Reason for revert: No good reason, but this build causes a compilation error. No clear culprit. https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190
> 
> Original change's description:
> > OOR-CORS: Remove BlinkCORS related tests
> > 
> > This patch removes network::features::kOutOfBlinkCors and
> > network::features::ShouldEnableOutOfBlinkCorsForTesting() references
> > from existing tests as now BlinkCors was deprecated, and we already
> > turned down CORS fyi bots.
> > 
> > This is part of the work to remove the kOutOfBlinkCors feature.
> > 
> > Bug: 1053866
> > Change-Id: I4ba14005fd3fb310cbd246e6c0bd6cc18bd005d8
> > TBR: mkwst@chromium.org
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377633
> > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
> > Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
> > Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#803029}
> 
> TBR=falken@chromium.org,toyoshim@chromium.org,lukasza@chromium.org,karandeepb@chromium.org,mkwst@chromium.org
> 
> Change-Id: I96044df30b8694433c6bad6e9eb719b949f6413e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1053866
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385075
> Reviewed-by: Maxim Kolosovskiy  <kolos@chromium.org>
> Commit-Queue: Maxim Kolosovskiy  <kolos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803044}

TBR=falken@chromium.org,toyoshim@chromium.org,lukasza@chromium.org,kolos@chromium.org,karandeepb@chromium.org,mkwst@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1053866
Change-Id: Ic35fa6950fc52873ad3650ce836a015b2a274cee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382761Reviewed-by: Maxim Kolosovskiy  <kolos@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Maxim Kolosovskiy  <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803083}

67aa394e

Reland "[WebAuthn] Add UseCounter for WebAuthn in cross-origin iframes" · 13da2646

Maxim Kolosovskiy authored Aug 31, 2020

This reverts commit 1c8be55e.

Reason for revert: this CL didn't cause the problem. The root cause was a tricky infra problem. sorry for wrong revert.

Original change's description:
> Revert "[WebAuthn] Add UseCounter for WebAuthn in cross-origin iframes"
> 
> This reverts commit 0426308f.
> 
> Reason for revert: I suspect it caused compilation failures https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190?
> 
> Original change's description:
> > [WebAuthn] Add UseCounter for WebAuthn in cross-origin iframes
> > 
> > The feature policy to enable WebAuthn get requests in cross-origin
> > iframes shipped in M84 but did not include a use counter. This CL adds
> > one.
> > 
> > Change-Id: Ie404ab62de3cfe665a1927883a31d7f17c329c1b
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384651
> > Commit-Queue: Martin Kreichgauer <martinkr@google.com>
> > Reviewed-by: Martin Kreichgauer <martinkr@google.com>
> > Cr-Commit-Position: refs/heads/master@{#803026}
> 
> TBR=kenrb@chromium.org,martinkr@google.com
> 
> Change-Id: I07e8edb0aeed3c53118f69bb4c7304cb6f34342f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383026
> Reviewed-by: Maxim Kolosovskiy  <kolos@chromium.org>
> Commit-Queue: Maxim Kolosovskiy  <kolos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803037}

TBR=kenrb@chromium.org,kolos@chromium.org,martinkr@google.com

# Not skipping CQ checks because this is a reland.

Change-Id: I7ba02d1cf109b2a6026ccd8c90c19ba5d00bd8c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382607Reviewed-by: Maxim Kolosovskiy  <kolos@chromium.org>
Commit-Queue: Maxim Kolosovskiy  <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803082}

13da2646

Clean up move() in //components/policy/core/common/cloud/ · 94cd4e50

Maksim Ivanov authored Aug 31, 2020

Refactor the code to make it clearer that there's no
use-after-move bug, both for the reader and for the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I9e1983c60ca76992c87d825223e0c24c5b818002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382114Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803081}

94cd4e50

Reland "Reland "cros: Implement ClipboardImageModelFactory"" · 7387e33c

Maxim Kolosovskiy authored Aug 31, 2020

This reverts commit 1d850b0b.

Reason for revert: this CL didn't cause the problem. The root cause was a tricky infra problem. sorry for wrong revert.

Original change's description:
> Revert "Reland "cros: Implement ClipboardImageModelFactory""
> 
> This reverts commit 57af2c42.
> 
> Reason for revert: No good reason, but this build causes a compilation error. No clear culprit. https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190
> 
> Original change's description:
> > Reland "cros: Implement ClipboardImageModelFactory"
> > 
> > This reverts commit 5822a03a.
> > 
> > Reason for revert:
> > It turned out that the test is flaky regardless of this change.
> > Probably this just made it easier to reproduce the flakiness.
> > 
> > Original change's description:
> > > Revert "cros: Implement ClipboardImageModelFactory"
> > > 
> > > This reverts commit 056d2885.
> > > 
> > > Reason for revert:
> > > This is a speculative revert for failures on 
> > > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38382
> > > 
> > > This could fail the following test:
> > > ClipboardHistoryWithMultiProfileBrowserTest.ShouldPasteHistoryAsPlainText
> > > 
> > > Original change's description:
> > > > cros: Implement ClipboardImageModelFactory
> > > > 
> > > > Implements ClipboardImageModelFactoryImpl.
> > > > Previous CL landed ClipboardImageModelFactory, and all
> > > > ash-side usages of the factory.
> > > > 
> > > > This CL implements rendering of HTML via
> > > > ClipboardImageModelRequest.
> > > > 
> > > > Bug: 1117230
> > > > Change-Id: I2f7ac67eadac5ef1a3c7cfca9918de438f02ff8e
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367395
> > > > Commit-Queue: Alex Newcomer <newcomer@chromium.org>
> > > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> > > > Auto-Submit: Alex Newcomer <newcomer@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#802779}
> > > 
> > > TBR=xiyuan@chromium.org,newcomer@chromium.org
> > > 
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > 
> > > Bug: 1117230
> > > Change-Id: Ibc178e2d0b50bb423bc5a128aead30a5f471bd18
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383532
> > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> > > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#803003}
> > 
> > TBR=xiyuan@chromium.org,nhiroki@chromium.org,newcomer@chromium.org
> > 
> > # Not skipping CQ checks because this is a reland.
> > 
> > Bug: 1117230
> > Change-Id: I49fe530783a23a65e06456ca3c4ab3703dde35e2
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384712
> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#803027}
> 
> TBR=xiyuan@chromium.org,nhiroki@chromium.org,newcomer@chromium.org
> 
> Change-Id: Iad7614b249091bfcce8a27f10ae4e67de86a2a29
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1117230
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382603
> Reviewed-by: Maxim Kolosovskiy  <kolos@chromium.org>
> Commit-Queue: Maxim Kolosovskiy  <kolos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803043}

TBR=xiyuan@chromium.org,nhiroki@chromium.org,kolos@chromium.org,newcomer@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1117230
Change-Id: I410473bc38efce068f1c3d2a2158489ff4eb4f17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382122Reviewed-by: Maxim Kolosovskiy  <kolos@chromium.org>
Commit-Queue: Maxim Kolosovskiy  <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803080}

7387e33c

[iOS][Password Check] Password check interactions · 3a57dd72

Viktor Semeniuk authored Aug 31, 2020

This change adds metrics recording for password check interactions.

Bug: 1121906
Change-Id: Ib044e6174d4ef70a55500a21401fe2c69d1b833e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377725Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Cr-Commit-Position: refs/heads/master@{#803079}

3a57dd72

Roll Chrome Win32 PGO Profile · f37e14dd

chromium-autoroll authored Aug 31, 2020

Roll Chrome Win32 PGO profile from chrome-win32-master-1598834860-65570273a8a9241ebf147440a3fd9be058e3b8e7.profdata to chrome-win32-master-1598857126-da6d6f9c34b393846886ccd27545501972c5d864.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: Ie47829d64d373873ec38092cac9a8f8bfa996794
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384852Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803078}

f37e14dd

[Passwords] CompromisedCredentialsReader::GetAllCompromisedCredentials() · 4a262c39

Mohamed Amir Yosef authored Aug 31, 2020

This CL introduce a new API to fetch all compromised from both
the profile and the account stores.

Bug: 1108422

Change-Id: I41998de212ad5d83f2c489aad98b43e343296828
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378030
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803077}

4a262c39

Reland "[Telemetry SWX] Add battery capacity routine" · ef476b5c

Maxim Kolosovskiy authored Aug 31, 2020

This reverts commit cebb96ff.

Reason for revert: this CL didn't cause the problem. The root cause was a tricky infra problem. sorry for wrong revert.

Original change's description:
> Revert "[Telemetry SWX] Add battery capacity routine"
> 
> This reverts commit 437b61ae.
> 
> Reason for revert: No good reason, but this build causes a compilation error. No clear culprit. https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190
> 
> Original change's description:
> > [Telemetry SWX] Add battery capacity routine
> > 
> > Add implementation to chrome://.
> > 
> > Add implementation to chrome-untrusted://.
> > 
> > Add tests.
> > 
> > Bug: b:162051831
> > Change-Id: Ib2d618c4eacce43e6cd588c766e8d40af9ae318b
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362933
> > Commit-Queue: Laurențiu Olteanu <lolteanu@google.com>
> > Reviewed-by: Tom Sepez <tsepez@chromium.org>
> > Reviewed-by: Oleh Lamzin <lamzin@google.com>
> > Cr-Commit-Position: refs/heads/master@{#803030}
> 
> TBR=tsepez@chromium.org,lamzin@google.com,mgawad@google.com,lolteanu@google.com
> 
> Change-Id: I675879ec1c65f834362901ba862923acadfa9551
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: b:162051831
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383028
> Reviewed-by: Maxim Kolosovskiy  <kolos@chromium.org>
> Commit-Queue: Maxim Kolosovskiy  <kolos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803041}

TBR=tsepez@chromium.org,kolos@chromium.org,lamzin@google.com,mgawad@google.com,lolteanu@google.com

# Not skipping CQ checks because this is a reland.

Bug: b:162051831
Change-Id: I1e09e1a56feba44f2079c2b459337a88e622d30c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382838Reviewed-by: Maxim Kolosovskiy  <kolos@chromium.org>
Commit-Queue: Maxim Kolosovskiy  <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803076}

ef476b5c

Roll Perfetto from 79257bae3c9a to 19157ee4a2fd (1 revision) · bd9402b6

chromium-autoroll authored Aug 31, 2020

https://android.googlesource.com/platform/external/perfetto.git/+log/79257bae3c9a..19157ee4a2fd

2020-08-31 treehugger-gerrit@google.com Merge "Creation of permalinks for config"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I411f4c2f5d07f15d01f5e70ffc436fb8f2691a69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384854Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803075}

bd9402b6

[PartitionAlloc] Clarify "64 bit pointers" guards. · 6a1f1050

Benoit Lize authored Aug 31, 2020

All 64 bit ABIs have 64 bit pointers, except for NaCl (using something
similar to x32 on Linux). Instead of repeating this exception
everywhere, replace it with a single define in a single place,
PA_HAS_64_BITS_POINTERS.

Change-Id: Ie64a47c77a68de2bc22703d0e10db7347481b922
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377708
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Takashi Sakamoto <tasak@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803074}

6a1f1050

Fix use-after-move in //components/mirroring/service/ · 614b825a

Maksim Ivanov authored Aug 31, 2020

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I7f67d4dde85e191cba0337a1bffe270c4a407658
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383016Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803073}

614b825a

[Perfect Negotiation] Pass Perfect Negotiation WPTs with proper ONN. · 87b0f61a

Henrik Boström authored Aug 31, 2020

This CL migrates to the spec-compliant OnNegotiationNeededEvent[1], only
firing it it the Operations Chain is empty. It also makes the
"negotiationneeded" and "icecandidate" events fire without additional
delay. This is important, because Perfect Negotiation is very
timing-sensitive, and the way we've been firing these events is wrong.

A bug in the Perfect Negotiation WPT is discovered: if an incoming
follow-up offer is sent to the impolite peer while the SRD(answer) of
the previous O/A exchange is still pending, the impolite peer would
incorrectly ignore the offer. This is fixed with the introduction of a
boolean variable to keep track of if SRD is pending, allowing the
impolite peer to predict that it is about to become "stable" and can
thus chain the incoming offer onto its Operations Chain.

With these changes, we pass the Perfect Negotiation WPTs! Hurray!

[1] https://webrtc-review.googlesource.com/c/src/+/180620

Bug: chromium:1060083
Change-Id: I8e8c684ef6cfc1faac0256d33b8fc89be3fc614f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330014
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803072}

87b0f61a

Stop using BlockThirdPartyCookies preference in Desktop UI · cb76432b

Christian Dullweber authored Aug 31, 2020

The boolean BlockThirdPartyCookies preference was replaced by
CookieControlsMode enum. Existing settings were migrated since M83.

Bug: 1104836
Change-Id: I1afabd42053515a0b436f7f92bac5eed0a14c2fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366935Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Theodore Olsauskas-Warren <sauski@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803071}

cb76432b

Reland "Add Media Capture and Generic Sensors mojom.js files to mojojs.zip" · c14b408c

Maxim Kolosovskiy authored Aug 31, 2020

This reverts commit 6d7617fa.

Reason for revert: this CL didn't cause the problem. The root cause was a tricky infra problem. sorry for wrong revert.

Original change's description:
> Revert "Add Media Capture and Generic Sensors mojom.js files to mojojs.zip"
> 
> This reverts commit 1edcb047.
> 
> Reason for revert: No good reason, but this build causes a compilation error. No clear culprit. https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190
> 
> Original change's description:
> > Add Media Capture and Generic Sensors mojom.js files to mojojs.zip
> > 
> > This is the first step before removing those files from WPT.
> > 
> > Bug: 1119858
> > Change-Id: I461ba09d1aaf9573c8f79b0fd6ee59a724be0fd0
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378325
> > Reviewed-by: Robert Ma <robertma@chromium.org>
> > Reviewed-by: Michael Moss <mmoss@chromium.org>
> > Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com>
> > Cr-Commit-Position: refs/heads/master@{#803031}
> 
> TBR=mmoss@chromium.org,raphael.kubo.da.costa@intel.com,robertma@chromium.org,arnaud.mandy@intel.com
> 
> Change-Id: I94a722412f3cd37ef6ad9ab15274f6951855e9c7
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1119858
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383027
> Reviewed-by: Maxim Kolosovskiy  <kolos@chromium.org>
> Commit-Queue: Maxim Kolosovskiy  <kolos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803040}

TBR=mmoss@chromium.org,raphael.kubo.da.costa@intel.com,kolos@chromium.org,robertma@chromium.org,arnaud.mandy@intel.com

# Not skipping CQ checks because this is a reland.

Bug: 1119858
Change-Id: I96db7fc48ab349c86a23c972071dea8e534a4cf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384034Reviewed-by: Maxim Kolosovskiy  <kolos@chromium.org>
Commit-Queue: Maxim Kolosovskiy  <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803070}

c14b408c

[PwdCheckAndroid] Add favicons to credential rows · 8f6af298

Friedrich Horschig authored Aug 31, 2020

This CL adds favicons to each credential row or a fallback if no icon is
available for a site.

Screenshots in the bug.

Bug: 1106724, 1092444
Change-Id: I246f128fc76838142f599b75666912a1187bf9bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362895Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803069}

8f6af298

Fix example code of PrimaryAccountAccessTokenFetcher · e722fcb8

Jeroen Dhollander authored Aug 31, 2020

This example code is really useful, but it contained a few minor
C++ mistakes.

Bug: N/A
Test: compiled
Change-Id: If0b110c89657a4f018e2b406b0e4b2213a4fe420
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354594
Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803068}

e722fcb8

[CheckedPtr] Inline EnabledForPtr · 47fa6a6d

Sergei Glazunov authored Aug 31, 2020

This CL allows the CheckedPtr constructor to quickly skip unsupported
pointers.

Change-Id: Ibabb8802f4feb3734e1e7740fd86bd8df9a4e657
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379831Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Sergei Glazunov <glazunov@google.com>
Cr-Commit-Position: refs/heads/master@{#803067}

47fa6a6d

oobe: Update eula screen name in debug overlay · c2a5c043

Danila Kuzmin authored Aug 31, 2020

After migrating eula screen to LoginScreenBehaior the screen is
temporarily named as "oobe-eula-md". This CL is a follow up name update.

Bug: 1121655
Change-Id: Ifcfbc0d8a3528d33deda01d9227c5ec449b0c1bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378029Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Danila Kuzmin <dkuzmin@google.com>
Cr-Commit-Position: refs/heads/master@{#803066}

c2a5c043

[Android] Add SyncErrorCardPreference to ManageSyncSettings · d6278602

Tanmoy Mollik authored Aug 31, 2020

This cl is the second part that implements the onClickListeners for
SyncErrorCard buttons. It also adds the preference to ManageSyncSettings
page. The preference is not visible unless MOBILE_IDENTITY_CONSISTENCY
feature is enabled.

Bug: 1107420
Change-Id: I55a1fcf73747e9e75d950daad0794220226ed0d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346439
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803065}

d6278602

Add WellKnownChangePassword flag to chrome://flags on iOS · 7df8c60b

Jan Wilken Dörrie authored Aug 31, 2020

Bug: 927473
Change-Id: I86ea71e72d2d3db4473c7a0b9687c700212d5975
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379765Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803064}

7df8c60b

Always let an in-flow legend be part of any flow thread parent. · 9b628826

Morten Stenshorne authored Aug 31, 2020

The containing block of a rendered legend of a fieldset that also
establishes a multicol container is the fieldset itself, not the flow
thread (and also not the anonymous fieldset contents wrapper).

However, since dynamic changes may change which legend is the rendered
legend, we'll keep it simple, and always let them be treated as part of
the flow thread - so that they trigger creation of a
LayoutMultiColumnSet - so that we are guaranteed to actually have a
LayoutMultiColumnSet if the rendered legend ceases to be the rendered
one.

Bug: 1122722
Change-Id: I5a287e367f8824dc0c5a27620c74d2ec6eedfd34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379723Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803063}

9b628826

Roll FreeType from 6730854c3971 to 16ee2a22abb6 (2 revisions) · 705a0d5e

chromium-autoroll authored Aug 31, 2020

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/6730854c3971..16ee2a22abb6

2020-08-29 apodtele@gmail.com [smooth] Don't set target in direct mode.
2020-08-29 apodtele@gmail.com Improve FT_Outline_Render docs.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel
Tbr: bungeman@google.com,drott@google.com,thestig@google.com
Change-Id: I89510122adea0c26d939ddcc19b74ad69c6644da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383039Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803062}

705a0d5e

[SC] Change the computer name to be the FQDN instead of hostname · 7adb1062

Julian Pastarmov authored Aug 31, 2020

Aligning the various reporting paths to return the same type of identifiers.

BUG=b/165296736
TEST=unit_tests:EnterpriseReportingPrivateGetDeviceInfoTest.GetDeviceInfo

Change-Id: Id4789d368d99097cbdbe1f65be098902cb773183
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380285Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803061}

7adb1062

Remove SMILAnimationEffectParameters::is_to_animation · 826db82c

Fredrik Söderqvist authored Aug 31, 2020

The effect of this parameter can be described using the other
parameters (is_additive = is_cumulative = false).

For list types it was previously used to avoid copying a list into
itself (clobbering it in the process), but that can achieved by
just comparing objects.
Similar techniques were applied in SVGPath and SVGTransformList, but
those classes could deal with the issue differently.

Rewrite SVGPath::CalculateAnimatedValue() to eliminate the extra
copy which should (no longer) be needed.

Change SVGTransformList::CalculateAnimatedValue() to compute the
transform first and then handle addition.

Also re-order the computations to try to get a somewhat canonical
order: interpolation, accumulation, addition.

In SVGAnimateMotionElement, always set |to_point_at_end_of_duration_|
instead of setting and checking a separate bool.
AnimateAdditiveNumber() handles the accumulation if required.

Bug: 1017723
Change-Id: I8adb2a7ad415a2d00aa057bfb93f55953450dd07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382111
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803060}

826db82c

Triage new failing list-item test. · 955a1c4f

Rune Lillesveen authored Aug 31, 2020

Bug: 1123140, 1123457
Change-Id: I316e49bca0153737c89e3ac418d407655f03ebbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383025Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803059}

955a1c4f

Exit early if the layer has been deleted in OnLayerBoundsChanged · 9fba1345

Mitsuru Oshima authored Aug 31, 2020

This can happen when a layer is recreated for animation for example.
(observed in crrev.com/c/2375686)

Bug: None
Test: Covered by unittest
Change-Id: Ia8e4bae050ef5c281ad498a461171900ceae13a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384070Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803058}

9fba1345

Roll src-internal from d9d64f51f078 to 45c7cc03636d (1 revision) · 72699d4a

chromium-internal-autoroll authored Aug 31, 2020

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d9d64f51f078..45c7cc03636d

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:897717
Tbr: kolos@google.com
Change-Id: I3c7032cbb8ed1dac11b1f030a566e8a9f9394305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384850Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803057}

72699d4a

blink_gc_plugin: Update stack_allocated test expectations · fd076537

Hans Wennborg authored Aug 31, 2020

The test broke after crrev.com/802490

TBR=thakis

Bug: 1100257, 1123469
Change-Id: Ie8ae2f26b1ffd92fa422d719a80aecc161f18738
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382836Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803056}

fd076537

CCA: Add new function replacing type assertion + querySelector · ec486222

Kuo Jen Wei authored Aug 31, 2020

Add new dom.* utility functions replacing
assertInstanceof+querySelector/querySelectorAll.

Bug: 1122444
Test: tast run <DUT> "camera.CCAUI*"
Change-Id: I7932bc65ad21e45c1c982bc0e9b77eb88084c5f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382992Reviewed-by: Shik Chen <shik@chromium.org>
Commit-Queue: Inker Kuo <inker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803055}

ec486222

Flag for fast API calls in Blink bindings · 4785fd22

Maya Lekova authored Aug 31, 2020

This is a follow-up of the recently added Blink support for fast calls:
https://chromium-review.googlesource.com/c/chromium/src/+/2361939

The new flag is called --enable-unsafe-fast-js-calls.

Bug: chromium:1052746

Binary-Size: Size increase is unavoidable (see above).
Change-Id: Iad5e398bb1398868d631345d1197a4596f4be423
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315680
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803054}

4785fd22

Roll ANGLE from 2f291c0bd181 to b4c90eee2f9f (1 revision) · 5ed6f467

chromium-autoroll authored Aug 31, 2020

https://chromium.googlesource.com/angle/angle.git/+log/2f291c0bd181..b4c90eee2f9f

2020-08-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ec3650f56ca2 to a2e6c1a149f4 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: cwallez@google.com
Change-Id: I4be057a7b32d91fff2af14f9df7abe9e259023aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384849Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803053}

5ed6f467

Remove references to ServiceWorkerRequestHandler/ServiceWorkerNavigationLoader · 48952cc7

Frédéric Wang authored Aug 31, 2020

ServiceWorkerRequestHandler has been removed in [1] while
ServiceWorkerNavigationLoader has been renamed in [2]. This CL removes
remaining references to these classes.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2150289
[2] https://chromium-review.googlesource.com/c/chromium/src/+/2210292

Bug: 1083047
Change-Id: I00b61033db140b1dd005f6111431e94b3ad44038
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379511Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#803052}

48952cc7

[Android] Change sign-out string in the account management screen · a8d404d0

Tanmoy Mollik authored Aug 31, 2020

If sync hasn't been turned on, the string should be "Sign out".
Otherwise, the existing "Sign out and turn off sync" string should be
used.


Bug: 1107421
Change-Id: I2dc84c34aba4deea8707d5b49fd838b153da9040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368360
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Reviewed-by: Alice Wang <aliceywang@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803051}

a8d404d0

[Perfect Negotiation] Fire events and resolve SRD promise synchronously. · 42d1061d

Henrik Boström authored Aug 31, 2020

Due to a bug about scheduling to dispatch various events instead of
dispatching them immediately, the setRemoteDescription was also
scheduled to be resolved rather than be resolved immediately, as to
ensure that all events had fired prior to the promise resolving. This
causes timing issues that become a problem for Perfect Negotiation.

This CL makes the events fire and the promise resolve synchronously in
the following order:
- Fire track.onmute.
- Fire stream.onremovetrack and stream.oninactive.
- Fire stream.onaddtrack and stream.onactive.
- Fire legacy pc.onaddstream.
- Fire legacy pc.onremovestream.
- Fire pc.ontrack.
- Fire track.onunmute.
- Resolve setRemoteDescription's promise. (Same order for SLD.)

Supporting this in Unified Plan was mostly a matter of changing
ScheduleDispatchEvents to DispatchEvents. We already processed addition
and removal in the same place, and could process all state changes
before firing events.

To support this in Plan B however, we had to merge DidAddReceiverPlanB
and DidRemoveReceiverPlanB into a single method DidModifyReceiversPlanB.
This is because we have to process all state changes before firing
events, otherwise an event listener in JS would not see all receivers or
remote streams when inspecting the peer connection.

In both Plan B and Unified Plan, now that stream.onaddtrack and
stream.onremovetrack fire synchronously, when listening to "onaddtrack"
you can observe each track being added separately (rather than
stream.getTracks() containing all the tracks that was added in the first
event).

Note: We still fire pc.onsignalingstatechange at the end; this should be
fired at the start, but this can be fixed in a separate CL.

Bug: chromium:788558
Change-Id: I9be34d7919a73799e944089f9afe0e90ba1de90f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332158Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803050}

42d1061d

[Android][WebSignin] Add view fields to bottom sheet view · 73ce161f

Alice Wang authored Aug 31, 2020

This CL adds two view fields in AccountPickerBottomSheetView for the
logo and horizontal divider. They will be used later for logo setup.
There is no behavior change in this CL.

Bug: 1120308
Change-Id: I1e1368bac873c37e0633fa34270a013f66aa0d34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379760Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803049}

73ce161f

Roll SPIRV-Tools from 08291a3a9e22 to f428aa39ca2b (1 revision) · 6e832559

chromium-autoroll authored Aug 31, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/08291a3a9e22..f428aa39ca2b

2020-08-28 afdx@google.com spirv-fuzz: Remove opaque pointer design pattern (#3755)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com
Change-Id: Iea2ab880632015213a44e8b63a935beff91b1546
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384528Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803048}

6e832559