GitLab

The data members were earlier marked protected when they were part of
a test fixture class defined in a .cc file. Now that they have been
moved to a .h file, it is preferred to mark them as private.

Bug: 1086430
Change-Id: I405115dd30330e7b4be90ce43c31eb06ee965b6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421500
Commit-Queue: Saurabh Nijhara <snijhara@google.com>
Reviewed-by: Oleg Davydov <burunduk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809736}

If MOBILE_IDENTITY_CONSISTENCY feature flag is enabled, this screen
will use the same icon as the one AccountPickerDialog is using.

Screenshot: https://crbug.com/1107423#c9
Bug: 1107423
Change-Id: I796f8df61e2eba707e83b43c00a45e84b02d5d91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390906
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809735}

The global variable 'ShouldUseGaiaAuthFetcherIOS' is no longer used
following the launch of NSURLSessionBridge.

Bug: 1101748
Change-Id: I8c20303ec98811afd6f8b83dc19f8caa6ec27805
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425823Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809734}

This CL splits timers with nesting level >5 and <= 5 into two different
TaskTypes. This CL should not affect behavior because the two TaskTypes
funnel into the same TaskQueue. In a separate CL, the TaskTypes will
be associated with different TaskQueues, which will make it possible to
disable intensive throttling for timer tasks with a low nesting level.

Discussion: https://groups.google.com/a/chromium.org/g/scheduler-dev/c/EWKYCZlWjpc

Bug: 1075553
Change-Id: I0f45c413b24e01e9687f109d0643bd1e46412075
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416854Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809733}

For files that are known to be text: convert them to a UTF-8 blob, and
use it to source the <webview src="params.contentUrl"> to convince the
<webview> to render UTF-8 (issue 1064855). A follow-up change will add
test coverage.

Files that are not known to be text (issue 772600): continue to render
as before (no UTF-8 support), using the default "browsable" code. This
code is already covered by our test system. Store task verb in a local
variable to aid debugging. Remove local |browsable| variable.

Bug: 1064855
No-try: true
Change-Id: Ic2cb580a97d25d2c90d95a72a954b6aa33b4c6a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425551
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Jeremie Boulic <jboulic@chromium.org>
Reviewed-by: François Degros <fdegros@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809732}

This CL updates PasswordManagerProxy and adds basic properties to the
PasswordCheckBehavior to provide the ability to use passwords check for
weakness in the frontend. It also updates password_check a bit to
verify that basic logic works.

Bug: 1119752
Change-Id: I95133f63094fafa7ac105ebba3c1df357cb7bf1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421372Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Irina Fedorova <irfedorova@google.com>
Cr-Commit-Position: refs/heads/master@{#809731}

Hiding a crash sets a boolean field in the JSON log file. When this
file is not found, the method used to do nothing. Now it creates
the JSON log file and writes to it.

run_webview_instrumentation_test_apk -f *CrashReceiverServiceTest*

Bug: 1122058
Test: run_webview_instrumentation_test_apk -f *WebViewCrashInfoCollectorTest*
Change-Id: I3175f09839254b98c0b051873320253103675d15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405584Reviewed-by: Hazem Ashmawy <hazems@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Laís Minchillo <laisminchillo@chromium.org>
Commit-Queue: Azhara Assanova <azharaa@google.com>
Auto-Submit: Azhara Assanova <azharaa@google.com>
Cr-Commit-Position: refs/heads/master@{#809730}

This reverts
https://chromium-review.googlesource.com/c/chromium/src/+/1685372, which
has been obsoleted by
https://chromium-review.googlesource.com/c/chromium/src/+/2332703.  The
profile directory is now guaranteed to outlive both TestingProfile and
TaskEnvironment.

The revert introduced a failure in
TabManagerTest.IsTabRestoredInForeground: PathDeleterOnTestEnd was not
able to delete the profile directory on Windows.  This is fixed here
by getting rid of TestMockTimeTaskRunner in favor of using the MOCK_TIME
trait for TaskEnvironment.  This is the preferred way of mocking time
and it makes the test simpler.

Bug: 978442
Change-Id: I3810d2ae57911f5b2d3337f954be5f5f360d7d4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416354Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com>
Cr-Commit-Position: refs/heads/master@{#809729}

The purpose of this test is to ensure |NeedsCollectInlines|
is not set by `text-decoration-line`, because it is one of the
most expensive operations, and the property is often changed
dynamically (e.g., hover on links.)

r807433 crrev.com/c/2411300 changed it to test
`text-decoration-color` instead, because it changed
`text-decoration-line` to invalidate visual overflow, and
because crbug.com/1043927 added a workaround to
|SetNeedsLayoutAndIntrinsicWidthsRecalc| when
|NeedsRecomputeVisualOverflow| for NG inline objects.

This patch changes the test to:
* Change to test `text-decoration-line` property.
* Change to expect |NeedsLayout| is set, with TODO comment.
* Add `outline` property, another property commonly changed
  dynamically (e.g., focus ring.)

Bug: 1128199, 1043927
Change-Id: I879582916d45a9374fada4e8d42f5baca95adabb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423766Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809728}

This reverts commit 1e32efc6.

Reason for revert:
Some tests used to fail in WebRTC Chromium Mac Tester bot.
Since macOS now supports detecting PTZ-capable cameras with this patch,
it is no longer correct to assume that pan_tilt_zoom_supported() will be
false for every enumerated camera, so let's remove the test named
VideoCaptureDeviceFactoryMacTest.ListDevicesWithNoPanTiltZoomSupport


Original change's description:
> Revert "[PTZ] Add macOS support"
>
> This reverts commit 6fc7c32c.
>
> Reason for revert: crbug.com/1128470
>
> Original change's description:
> > [PTZ] Add macOS support
> >
> > This CL makes sure a USB Webcam device on macOS properly advertises its
> > PTZ support. When supported, the pan, tilt, and zoom controls (ranges
> > and values) are available to websites that user has granted access to.
> >
> > Bug: 934063
> > Change-Id: I9d92d41fba0a6e9d518efb2501355d66cf77998f
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368596
> > Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
> > Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> > Reviewed-by: Reilly Grant <reillyg@chromium.org>
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
> > Cr-Commit-Position: refs/heads/master@{#807387}
>
> TBR=avi@chromium.org,beaufort.francois@gmail.com,reillyg@chromium.org,guidou@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 934063
> Change-Id: I88b1a41d28f5ad34f149f489b22eae6753e051dd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418577
> Reviewed-by: Markus Handell <handellm@google.com>
> Commit-Queue: Markus Handell <handellm@google.com>
> Cr-Commit-Position: refs/heads/master@{#808384}

TBR=avi@chromium.org,beaufort.francois@gmail.com,reillyg@chromium.org,guidou@chromium.org,handellm@google.com

# Not skipping CQ checks because this is a reland.

Bug: 934063
Change-Id: I82b757e1b5d3e6e62f520982ac5e4ef216849550
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420031Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Markus Handell <handellm@google.com>
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#809727}

Change-Id: If3ec764097f8a52b4b144fa69bd1009711db95fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424159
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809726}

Add a AVFoundationCaptureV2ZeroCopy feature flag to control exporting
IOSurfaces directly out of VideoCaptureDeviceAVFoundation. This flag
will do nothing unless AVFoundationCaptureV2 is also specified.

Bug: 1125879
Change-Id: If18c797ad2cdb6abab73679df7ef9b150fc39f61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425084Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Markus Handell <handellm@google.com>
Commit-Queue: Markus Handell <handellm@google.com>
Cr-Commit-Position: refs/heads/master@{#809725}

Roll Chrome Linux PGO profile from chrome-linux-master-1600819087-f018447afe1bff252e1e84ad0f3e21a12934b752.profdata to chrome-linux-master-1600840405-46e4cd70bd3de973a171c7f611770f78487d203a.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com
Change-Id: If52beaa97510384bb399211a094b8618d71e27e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425359Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#809724}

This reverts commit 0d88901a.

Reason for revert: Introduced a heap user after free in TabSearchButtonBrowserTest.TestBubbleVisible.

[my hunch is, it's just missing a call to tab_search_button()->bubble_for_testing()->Close()]

Original change's description:
> Tab Search: Update TabSearchButton tests
> 
> This CL creates a new file for TabSearchButton browser tests. These
> tests run for both the fixed and regular entrypoints.
> 
> Existing tests for the TabSearchButton have been moved from the tab
> strip into the TabSearchButton browser tests.
> 
> Bug: 1099917
> Change-Id: I0b1d57826768705316b9bed814dac7af96ce52e8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422730
> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#809376}

TBR=sky@chromium.org,tluk@chromium.org

Change-Id: I7b90eff0efbd7a807c0f085496f75139b1961909
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1099917,1131399
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424288Reviewed-by: Tim Schumann <tschumann@chromium.org>
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809723}

Roll Chrome Mac PGO profile from chrome-mac-master-1600819087-f4efc7f723c6812144192ebd4eb5f53f5a4e9534.profdata to chrome-mac-master-1600840405-f4d8e4031cebaee3fd15a03b0f21d18ea0743d9a.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: I6aaf4f46f5e1c185984503aaeb3986a694a10f81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425360Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#809722}

This reverts commit 5aa92900.

Reason for revert: Suspicious of introducing a heap use after free.

Original change's description:
> Rough in support for multiple selection in holding space.
> 
> Holding space needs to support selection of multiple holding space items
> to perform bulk context menu and drag/drop operations on them at a time.
> 
> This CL refactors HoldingSpaceItemContextMenu into a shared
> HoldingSpaceItemViewDelegate to facilitate these requirements.
> 
> Note that this CL does not change any existing behavior, just lays the
> groundwork for supporting multiple selection.
> 
> Bug: 1129981
> Change-Id: If4da6c19ba01bd7104a1b1487350c362d7be1dd4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419136
> Commit-Queue: David Black <dmblack@google.com>
> Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#809625}

TBR=dmblack@google.com,amehfooz@chromium.org

Change-Id: I6c0ea6374b87d7d2f673f80e97781b1036604a14
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1129981,1131382
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425048Reviewed-by: Tim Schumann <tschumann@chromium.org>
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809721}

This reverts commit a5d3ad0f.

Reason for revert: Suspected to break NearbyOnboardingPageTest.All on linux-chromeos-dbg

Original change's description:
> [Nearby] Trigger onboarding when first enabling Nearby
> 
> This CL adds a pref to track if onboarding was run by this user before.
> If it has not, when enabling for the first time, onboarding is run first
> by navigating to the subpage and showing in a dialog. Once onboarding
> has been done once, the user can freely toggle on/off without
> triggering onboarding. However, onboarding will still run if the user
> triggers the pod button and the feature is disabled. This matches the
> Android behavior.
> 
> Additionally, this CL fixes a bug with the premature closing of the
> shared receiveManager which needs to stay alive and connected after the
> dialog closes otherwise getReceiveManager returns a remote with a closed
> pipe.
> 
> Bug: b/154866951
> Change-Id: I1e3cbd15f4995f019b3476c2f7a69f67d6eb1888
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424763
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Commit-Queue: James Vecore <vecore@google.com>
> Cr-Commit-Position: refs/heads/master@{#809623}

TBR=khorimoto@chromium.org,vecore@google.com

Change-Id: I4bd779c4a17b7ef0560078cefd00287810dab796
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/154866951, 1131390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424160Reviewed-by: Tim Schumann <tschumann@chromium.org>
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809720}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: If1a1ecb542c2e8a72f24d967d52b211c8faf9a7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425349Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#809719}

This CL makes sure that the correct trait collection is used when
checking if the NTP is displaying one or two toolbars.
With multiwindow, it is not possible to directly check the key window.

Fixed: 1128527
Change-Id: I79a441b1a186c755b7cc979f527e807f10aa3a29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422955
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809718}

This reverts commit 821323c7.

Reason for revert: Breaks RenderProcessHostUnitTest.ReuseCommittedSite on linux-bfcache-rel builders.

Original change's description:
> Add Render Process for Site Instance Assignment to content API
> 
> This CL adds an enum, SiteInstanceProcessAssignment, which
> describes all the ways a SiteInstance may be assigned a render
> process. This is exposed in the content API to allow embedders to
> record this usage.
> 
> See design doc in bug and/or chained CL for more info.
> 
> Bug: 1129505
> Change-Id: I0654d52b4c0fef3830a877fb1c1476dea4ad9361
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417100
> Commit-Queue: Robert Ogden <robertogden@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#809620}

TBR=alexmos@chromium.org,robertogden@chromium.org

Change-Id: I89a7d068b8897c520a3d02645222c9cd91220c19
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1129505,1131378
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424314Reviewed-by: Tim Schumann <tschumann@chromium.org>
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809717}

DOMWrapperWorld is implemented with a few thread static variables
and its behaviors depend on other threads.  Makes the test
expectations independent from other threads.

Bug: 874484
Change-Id: I3c93ab89c2fd4db67d3380251b9da06cd96991c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420171Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809716}

We used to assume 16bits is sufficient, but somehow it's not always the
case. In this cl, let handshake message and pcm audio message no longer
share the same packet header. I.e., let them have their own header
struct and read/make methods.

Besides, add more unittest to cover packet header poluate/parse.

Merge-With: eureka-internal/453374
Bug: internal: 168457620
Test: Unittest.
Change-Id: I6e10fe9d58974646029ba222229e2f6d4df8acd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413110
Commit-Queue: Kehuang Li <kehuangli@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809715}

That is:
- Increase the number of spinning iterations
- Do a relaxed atomic check before the CAS in the spin loop.

Bug: 1125999, 1061437
Change-Id: I4f33376b55206dff9557a9ee59109aeaa06b5a56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424310Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809714}

Bug: 1099982
Change-Id: I0b8e35b04c9b995bac6c49e8c831520ab350c040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416928
Commit-Queue: Ben Goldberger <benwgold@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#809713}

There are some cases missing in the switch, the IDE added them.

Bug: none
Change-Id: I77f16010fbb0ee2ee3be11402d26dd6ab35cf56e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424154
Auto-Submit: Sandro Maggi <sandromaggi@google.com>
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#809712}

This CL adds a few elements to the new menus in incognito and guest
modes:
 - Add a new background subclass that allows to draw themed images
   on a view's background.
 - Add incognito and guest mode art assets.

Design Deck: go/alignmenus

Screenshots:
https://screenshot.googleplex.com/9nCgPZMahh8eALD.png

Bug: 1105763
Change-Id: I2367514aa7285959409e68e3cfd618690beedff1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388442Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Mariam Ali <alimariam@google.com>
Cr-Commit-Position: refs/heads/master@{#809711}

Renderer-side autofill sometimes sends the browser a notification that
a form was *likely* submitted. WebView/WebLayer autofill currently
handles this case as follows:
- It records the fact that the event was received.
- If a new form is seen by the renderer while the current form is still
  active in the browser, it considers the current form as having been
  submitted and informs the Android Autofill framework.

This CL modifies this flow in order to support followup work that will
reset the current form on navigation. The logic is now as follows:
- When a navigation occurs, WV/WL Autofill's browser-side code checks
  whether (a) it has previously received a "form likely submitted" event
  from the renderer and (b) the current form has not subsequently been
  reset. If so, it considers the current form as having been submitted
  and informs the Android Autofill framework.

Without this change, the followup work that resets the current form on
navigation would break this flow entirely, as (naturally) a new form is
seen by the renderer only *after* a navigation occurs.

The practical impact of this change is that commit of a successful
autofill session will occur sooner: on the navigation resulting from
the successful submission rather than the next time that a form is seen
(which can be arbitrarily later). This seems like a good thing.

Bug: 1117563
Change-Id: I33dfa27b4bbf7e246e62273d3598eb0f30f1f722
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424144
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Michael Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809710}

Post-CQ bots are failing in ways not reproducible locally or on the CQ.
To rule out if tests are interfering with each other (e.g. opening
camera in parallel or leaving the camera in a bad state) we disable all
tests exercising the new code path.

This should result in only old capturer code running, with only pixel
formats not natively supported by the camera (2vuy).

TBR=handellm@google.com, ccameron@chromium.org
NOTRY=True

Bug: chromium:1128470, chromium:1129807
Change-Id: I68d425807cee869bcc76dddcb0aa36ff4476e6ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424128
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809709}

Bug: 1125784
Change-Id: Id7dc06dc9b5b463aa62784f9927ce684f5b9c64e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423510Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/master@{#809708}

Follow-up of
https://chromium-review.googlesource.com/c/chromium/src/+/2220359. This
CL removes related XXXToString() methods.

Bug: None
Change-Id: I99fb653e0f5ed179bb21fa8e48b5c79aa98b6557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425386Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Linkun Chen <lkchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809707}

Includes 🙂 face character, samples from different languages, Dingbats
and Math characters, Greek letters, Runes, etc:

  Hello नोपहिनस्ति أن 害
  色は匂へど 散りぬるを
  κόσμε ᚹᛦᛗ コンニチハ
  волн ապակի Կրնամ
  їсти मुझे |∊☀✌✂♁ 🙂

Note the file is pure text with no UTF-8 BOM (Byte Order Marks) at the
start of the file.

Not used in anywhere in the code as yet.

Bug: 1064855
No-try: true
Change-Id: I34409215ec22aacea6a872cbc87241f27ab35e03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425545
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: François Degros <fdegros@chromium.org>
Reviewed-by: Jeremie Boulic <jboulic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809706}

Duplicate the openQuickViewTabIndexText test but here use an HTML file
as the preview file. This to document a difference between the preview
HTML and TEXT content renderers. The HTML renderer content is not part
of the tabindex order, while the TEXT renderer content *is*. Add a new
test to document the HTML renderer tabindex behavior.

Test: browser_tests --gtest_filter="*openQuickViewTabIndexHtml"
No-try: true
Bug: 1064855
Change-Id: Ieae14b0468c1142feeb23a240fb8f73c119bef4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425605
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809705}

- Add query set with the types of occlusion query, pipeline statistic
  query and timestamp query.
- Add extension of timestamp query.
- Add query APIs:
  createQuerySet on device.
  writeTimestamp on command encoder, render encoder and compute encoder.
  resolveQuerySet on command encoder.
- Now timestamp query is available on D3D12 backend, other backends are
WIP.


Bug: dawn:434
Change-Id: Icfdb17da7f406bfd1d6e903503b103391d9c7d8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415572
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809704}

Makes .gni files of file lists a little cleaner.

Change-Id: I10045a56809949cdd158de067439a27dfde0125d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424366Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809703}

This patch shows two related photos together when device is in landscape
orientation.

Major changes:
1. Only show paired photos in landscape mode.
2. Use flex layout to dynamically add and show the secondary image.
3. If the primary image is fetched, it will be shown in the UI.
4. If the primary image is not fetched, then will ignore the secondary
   image, i.e. read from cache.
5. If the second image is fetched, it will be added to the UI if the
   screen orientation is landscape.
6. There is a 8px wide separator between two photos.
7. Only update the cache with primary image.
8. Paired photos share the same attributes.

Screenshot: https://screenshot.googleplex.com/9UirWBGxheYVqV4

Bug: b/157080996
Test: added new tests.
Change-Id: I25fb18104f317ffad629bbf7d1fcc5302806cf20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407176
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809702}

Purely mechanical change to follow a PRESUBMIT recommendation.

Bug: 1111134
Change-Id: Ic1674e98d977326f3666469fe53145912e6d5ac5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419052Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809701}

Also fixes a few cpp lint errors. No functional changes.

Bug: 1010217
Change-Id: Ibdbac42980740d26392812b39f86859b238b7a64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422964
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809700}

R=khorimoto@chromium.org

Bug: 1045266
Test: none
Change-Id: I82ca433269e300a2e7745b661be3f7a85f8117a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425325
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809699}

It seems c_icu symlink is also created along with /c symlink for
ChromeOS build (/c is for chromeos-chrome package, /c_icu is for
chrome-icu package).  It's better to ignore it for the same reason.

Bug: none
Test: build_packages with chromeos chroot environment
Change-Id: Iad0a4addac492580601a16faa26ec34ed2fe77e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425123Reviewed-by: Honglin Yu <honglinyu@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809698}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df9a5f7482ce..aad83522fd17

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC horo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: horo@google.com
Change-Id: I798644c8da266945de1b361fbf17c4418f231062
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425515Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#809697}