- 28 Jul, 2020 40 commits
-
-
Mike Dougherty authored
On iOS 14, when set as default browser, Chrome can receive http and https URLs directly from system and third party apps. Extend the metrics to capture this case separately from the default case where the source application is unknown. Bug: 1101058 Change-Id: Ieb269be5d93d00c07e23e25d366037667d986cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315199Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#792126}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I4c25f81b7892b2975677df81eb56639f7269271e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321535 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792125}
-
Andrey Kosyakov authored
TBR=kvitek, wez ... with the exception of Fuchsia where they don't behave. Flakes/timeouts need further investigation, but they seem fine on most OSes most of the time and this is a piece of coverage that we can't sacrifice. Bug: 1107396, 1110091 Change-Id: Idb9da904566ad0a4d9bc77a9e9e159df2f03aaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321551Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#792124}
-
Jinsuk Kim authored
PreviewTab is enabled only on non-low-end devices. This CL stops its tests from running on build bots for low-end devices. Bug: 1096808 Change-Id: Ie314b05163a7d567074b2d284f7c3c1331b1c4ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321806Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#792123}
-
nancylingwang authored
When there is only 1 icon file(icon_xxx.png) for the app, there could be 2 cases: 1. The icon is not the adaptive icon 2. The system just migrated from the adaptive icon feature disabled to enabled. To distinguish these 2 scenarios, modify the arc_app_list_prefs. If the adaptive icon feature is enabled, for non-adaptive icons, save the image to both icon_xxx.png and foreground_icon_xxx.png. Then ArcAppIcon can check the files to know whether the current icon is non-adaptive icon or the system migration case. If there is no foreground icon, that means the system migration case, then we should request the icon. Otherwise, that means the icon is a non-adaptive icon. This is also preparing for the next step, removing the icon_xxx.png, so that we can have 2 png files only: foreground_icon_xxx.png: Present the foreground image for the adaptive icon or the image for the non-adaptive icon. background_icon_xxx.png: Present the background image for the adaptive icon. TODO: Add the metric to verify whether we have non-adaptive icon scenario. If all icons return from ARC side are 2 layer, for the next step, we can add some DCHECK and remove the icon_xxx.png, and force checking both the foreground and background images. BUG=1083331 Change-Id: I516c4a317040da03902f80ddbaa9876325bfbd35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318885Reviewed-by:
Long Cheng <lgcheng@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#792122}
-
Adrienne Walker authored
Since sometimes the WebIDBGetDBNamesCallbacksImpl can be destroyed when the promise is resolved, make sure that no code that could reference it is still around. Store the async task as an optional member so it can be cleared during the destructor. Followup to: https://chromium-review.googlesource.com/c/chromium/src/+/2311620 Bug: 1109467 Change-Id: Id6a0ff0a3703fab94e9684e41f16d5a1bac20468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321332Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#792121}
-
Reilly Grant authored
Renames these targets from "service" to "services" to match the other test target names defined for this directory. Change-Id: Idf0473638223747327c4c500b768ea43495e2e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317859 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#792120}
-
Brian Sheedy authored
Fixes GPU Telemetry tests on CrOS devices not capturing JavaScript console messages (and a large chunk of the actual browser logging) in the browser log artifacts. The cause was a combination of: 1. The --enable-logging=stderr flag we pass by default messes with browser logging on CrOS, apparently because stderr doesn't go anywhere on CrOS. 2. Not passing a --log-level flag, as apparently JavaScript logging is log enough verbosity (even when done via console.error) to show up with the default verbosity. Bug: 1102664 Change-Id: Ia06e59cb9bafcda32266960e4310e99bc2a831a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316846 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#792119}
-
tby authored
There's a flaky DCHECK crash in launcher search, due to the query getting out of sync in the ranker vs the returned search results. This is caused by deeper problems, but this CL is a quick patch that should fix the immediate issue. Currently we don't update the most recent query if two searches happen in quick succession, even if the second search contains a genuinely new query. Let's fix that. Bug: 1109017 Change-Id: Iac78aef0dae6d4001fc0726ac0deb5ced9bd11aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319949Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#792118}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I81472cf59fbd23754ffb30f3545d0f159b7bad00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321791Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iee8222c6d1a8faaef24267cff726abbf963a2d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321343Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595872800-d57a770d7bc200213efd65ae14b0000c1824f2dd.profdata to chrome-mac-master-1595894324-d422a20c76a9a0bf9c80e2917291820d179a400b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6b5a3fc99978ece7b870b8bc8bb10ac73d935586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321845Reviewed-by:
-
Shengfa Lin authored
strip is incompatible on Mac with Linux, which could cause large binary size. Make sure it's linux env before running release script Bug: chromedriver:3556 Change-Id: I7f7d9b9a12bb78a558016a28a7c5ecc3dc7098de Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321715Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#792114}
-
Scott Violet authored
SecurityInterstitialPage::ShouldCreateNewNavigation() is not used. BUG=none TEST=none Change-Id: I73bd846489577e786c28126b190d6c6256c3b4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318317Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#792113}
-
Chris Lu authored
See bug for Finch Config Screenshot: https://drive.google.com/file/d/1MTSsMCjvCoTW4yBKGaH1wCBzOroVeWnT/view?usp=sharing Bug: 1107489 Change-Id: Ia01af991e4019ac10011b340b39dde358fbfdab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309129 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#792112}
-
Ben Pastene authored
All Simple Chrome builders should have migrated to using args.gni files fetched during gclient-runhooks. And so there's no bot that should be calling out to `cros chrome-sdk` during GN-gen or compile any longer. Bug: 937821 Change-Id: If24f4b30e29232bef7bb969ea03afdae22e9143b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321231Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#792111}
-
Mario Bianucci authored
Prediction and prediction related features were all used for scrolling and input events, so they lived in blink and had scrolling specific names. This CL moved them from being blink and having feature specific names to being in ui/base with feature-agnostic names. The motivation for this move is to enable the prediction classes to be used elsewhere. Specifically, I will be using prediction from viz in order to predict future points on an ink stroke as part of the delegated ink trail feature in order to improve user perceived latency. Bug: 1052145 Change-Id: I3399ecabf962544dc1a4ecefe42583f1d717b6de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270635Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#792110}
-
Ken Rockot authored
This converts the remaining default variant .typemap files within //third_party/blink to direct GN target configurations. Bug: 1059389 Change-Id: I7c9f7e097667a8fdc79aff51a4c0b30d35bcbb67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315766 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#792109}
-
Xiaoqian Dai authored
Currently when swiping up from bottom to drag a window, the window can be ended in 4 different places: restore to its old position, go to home screen, drop in overview, or snap in splitview. These operations are handled in different places, with the first 2 handled in FinalizedDraggedWindow() function and the latter 2 handled in EndDrag() function. The reason for it to avoid window state change to interfere with shelf state change, see https://crrev.com/c/2004052. This CL moves the logic of window finalization operations together while keeping the existing logic unchanged. This CL doesn't have any functional change. Bug: None Change-Id: Ib2c4e866893c51ee952725a3b80c701f8b02120a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320770Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#792108}
-
Eric Willigers authored
The method Browser::GetDisplayMode previously returned kStandalone for non-full-screen app windows, even if they contained minimal-ui controls. Bug: 1109522 Change-Id: I151e68bdbcacb0aa73c15152eb462bc5d5901644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318848 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#792107}
-
Olga Gerchikov authored
This change implements initializing ScrollTimeline with scrollOffsets and reading back scrollOffsets. Bug: 1094014 Change-Id: I9d39bcc2644cee1288d59a29119d9ac1d91b5080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264926Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/master@{#792106}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/25a8165f50bc..469c2061cd49 2020-07-27 rharrison@google.com Rolling 2 dependencies and updating expectations (#1121) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I55f337edb90c45cc80e021bb415237dd8b54e71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321262Reviewed-by:
-
Fergus Dall authored
In CL:1993062 this was changed in an attempt to make the smallest non-zero scroll value aura would give us line up with the minimum scroll value legacy linux apps could handle. After further discussion off-line we've decided this is incorrect. Instead, we will keep the old scale and just adjust the size of small scroll events sent to linux apps. This CL does the first half of this, the crostini specific parts will be done in sommelier. Bug: 1039157, b/162264906 Change-Id: I5a3b26a520ee085a063a71b22c89c877d9734c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315667 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#792104}
-
Omid Tourzan authored
Adding 6px padding to the tooltip if it's on the edge of the window. Adjusting current calculation to consider 6px padding according to the ux spec. Tested on rtl successfully as well. Bug: 1108152 Change-Id: Icdc3d59983e75a397dd6a0971ea22d95dc82d8e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318954 Commit-Queue: Omid Tourzan <oto@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#792103}
-
Ben Pastene authored
This reverts commit f3ff8620. Reason for revert: builder is broken & closing the tree: https://ci.chromium.org/p/chromium/builders/ci/linux-ash-chrome-builder-rel Original change's description: > Adds linux-ash-chrome-builder-rel > > This linux-ash-chrome-builder-rel is created to upload ash-chrome > continuously to gs and the binary will be used to test lacros-chrome. > The upload logic will be in the next cl when the bot can launch and run. > > Bug: 1109287 > Change-Id: I12ab8b0cc8e24b8f217df1f710e5b918397dd987 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316807 > Commit-Queue: Sven Zheng <svenzheng@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792091} TBR=erikchen@chromium.org,liaoyuke@chromium.org,svenzheng@chromium.org Change-Id: Ifcce11fb201ccf1b17cd9aa973aad6a0cd5f3bca No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1109287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321881Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#792102}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a681d12639f4..12c9d4ac61f2 2020-07-27 sugoi@google.com Manual changes required for SPIR-V update 2020-07-27 sugoi@google.com Merge changes Icf7b69da,I2c88ee38 2020-07-27 sugoi@google.com Merge changes Id54668de,I200b4417 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Id8a4515c73cee45835b5005bb8830a6556ba19e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321259Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f2780c629ddc..b1d870649dd5 2020-07-27 primiano@google.com Merge "UI: improve string_utils, deal with UTF8/16 and Base64" 2020-07-27 primiano@google.com Merge "fixing b64encode to be compatible also with python3" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia8bbf35f5a591c1fa65b5c6be5e01fc3ddefbdb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321008Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/66d19211aa8f..0307e9114c30 2020-07-27 johnstiles@google.com Remove unreferenced function SkStrDup. 2020-07-27 johnstiles@google.com Add missing #includes for referenced types, and missing headers in GN. 2020-07-27 johnstiles@google.com Update types in TextStyle to use member initialization syntax. 2020-07-27 herb@google.com add final to all the leaf SubRuns 2020-07-27 herb@google.com consolidate common vertex filling code 2020-07-27 adlai@google.com Use std::move when constructing GrSurfaceProxyViews 2020-07-27 scroggo@google.com Remove references to Golden/Diamond Master 2020-07-27 brianosman@google.com Handle more types as parameter/return in runtime effect helper functions 2020-07-27 fmalita@chromium.org Bump SkottieKit version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101491 Tbr: borenet@google.com Change-Id: Iac6c764c792f96c66da1d1d2e12dbed8588e3676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321261Reviewed-by:
-
Thiabaud Engelbrecht authored
Bug: 1106364 Change-Id: If62ae6d1efdd76fd12f7550c5828c61798a61914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310899Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Cr-Commit-Position: refs/heads/master@{#792098}
-
Tarun Bansal authored
Record count of hints received from external Android app using histograsms. Change-Id: I1ed043c2bfa6ef8447e50fda0b05b15507978dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319539 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#792097}
-
Regan Hsu authored
Screenshot: https://screenshot.googleplex.com/XvkUmxNGiM7 Mock: https://screenshot.googleplex.com/33XZNfWX4ms Spec: https://carbon.googleplex.com/cros-ux/pages/lte-setup/settings-approach?q= * Caller formatted graphics and text are added into the slotted-content by the caller. * Formatting the position and alignment of cr-card-radio-button relative to the cr-radio-group is also up to discretion of caller (e.g. caller may want to have cards aligned horizontally or vertically). Bug: 1093185 Change-Id: I4a0fab53f7bb34e0140b851e896175aa89340254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310878Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#792096}
-
Yuwei Huang authored
We never use FTL's PeerToPeerService, so this CL simply removes it from FtlServicesPlayground, so that we have one less thing to migrate. Bug: 1103416 Change-Id: I48bbea1399c447e681ab5624c7d9db3221bb527d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321533 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#792095}
-
dpapad authored
Bug: 965770 Change-Id: I71b26312a18f9da09a29ccb2b341935e2f62bc60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321140 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#792094}
-
Carlos IL authored
As part of the mixed form changes, we will no longer degrade the lock icon to (i) if a mixed form is present on an otherwise secure site (since there will be other stronger warnings present). Bug: 1106536 Change-Id: I959b731b00d8b19ba264ab38078d66e5bdfc9eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315297Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#792093}
-
Joey Arhar authored
Original Patch: https://chromium-review.googlesource.com/c/chromium/src/+/1986972 Revert: https://chromium-review.googlesource.com/c/chromium/src/+/2148472 The original patch was reverted for three reasons: 1. android-pie-x86-rel had slightly different pixel output. I am addressing this with a fuzzy pixel comparator, and the bot passes in "Choose Tryjobs". 2. android-arm64-proguard-rel started failing, and surprisingly it showed that it was using the linux baseline as the expected output. This must have happened because I left in the logic for separate marshmallow baselines but didn't provide a separate marshmallow baseline. This shouldn't happen again now that I removed the check for a separate marshmallow baseline. Unfortunately this bot does not appear in "Choose Tryjobs," but I am confident that at the very least the bot will not fail again for the same reason. 3. Focus rings on different macos versions have different colors. I fixed this in http://crrev.com/786769 and verified that it works by running tests on the various macos bots available in "Choose Tryjobs" This patch also implements the suggestion crbug.com/1091661 and re-enables the tests disabled in that bug. In the original patch, I made a new file called screenshot_test_utils, but I found another function in browser_test_utils which does the same thing, so this patch doesn't have screenshot_test_utils anymore. Bug: 1038425, 1022122, 1039866, 1091661 Change-Id: Ic1642179bd3ca659f3b4b1f3a25c86a719518ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150765 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#792092}
-
Sven Zheng authored
This linux-ash-chrome-builder-rel is created to upload ash-chrome continuously to gs and the binary will be used to test lacros-chrome. The upload logic will be in the next cl when the bot can launch and run. Bug: 1109287 Change-Id: I12ab8b0cc8e24b8f217df1f710e5b918397dd987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316807 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#792091}
-
Matthew Denton authored
Change-Id: Ia2c39a86fb3516040a74de963115e73b7b1a1e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318316Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#792090}
-
Yuwei Huang authored
This CL makes FtlRegistrationManager use ProtobufHttpClient. Bug: 1103416 Change-Id: If09d41a8cb6b4db6aa7bade7f01a65b6562e03a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293230 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
-
Curt Clemens authored
Use leveldb-proto and prefs to implement certificate storage. Bug: b/154865267 Change-Id: I55b548d4e25c1afb6809f45200623d3b55077f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269957 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#792088}
-
Carlos IL authored
Disables both the on-form warning (kAutofillPreventMixedFormsFilling) and the on submit interstitial (kInsecureFormSubmissionInterstitial). Bug: 1106545 Change-Id: I85ece8018b06de600a03d28821102bfabb4ff0a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305239 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#792087}
-
