- 12 Oct, 2018 40 commits
-
-
David Black authored
Per request from UI/UX folks, enlarging DialogPlate icons sizes to 24dip and adjusting left inset for voice input modality layout container. Note that the vector icon files themselves were also updated per request in the bug to ensure consistency of internal padding. Also per request, the greeting label is shifted up by 4dip. See bug for discussion/screenshots. Bug: b:112313532 Change-Id: I5b72c6867452470abbc8bd562c83ba37492279ea Reviewed-on: https://chromium-review.googlesource.com/c/1276947 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#599074}
-
David Black authored
This CL moves processing logic out of UiElementContainerView and into AssistantResponseProcessor which is owned by AssistantInteractionController. The controller will now initiate processing of the Assistant response before it is finalized. This cleans up the view logic considerably as well as provides better synchronization of animations since processing will have already occurred prior to the stage initiating a change. Bug: b:117344968, b:116751668 Change-Id: I3ac1300978a3448fd7e244b6a7312ec9bf3c39bd Reviewed-on: https://chromium-review.googlesource.com/c/1265820 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Pavel Feldman authored
Bug: 893705 Change-Id: I6df37f886de9c080fa20c972df7457b0a726ce3e Reviewed-on: https://chromium-review.googlesource.com/c/1278206Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#599072}
-
Zhizhou Yang authored
This patch will remove a linker flag for ThinLTO. The flag was first introduced to work around a nacl crash bug. After the compiler upgrade, there is no need to keep this work around. I tested the nacl_helper code size changes on several different boards: on samus: 30MB -> 11MB on elm: 19MB -> 7MB on veyton-minnie: 19MB -> 7MB Tested correctness by trying to reproduce https://crbug.com/799642 and no error shows up. BUG=chromium:799642 TEST=USE="afdo_use" emerge-samus chromeos-chrome Change-Id: I6fff65700e6d5a5d0e02ad810def5317ea912263 Reviewed-on: https://chromium-review.googlesource.com/c/1277596Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Commit-Queue: Zhizhou Yang <zhizhouy@google.com> Cr-Commit-Position: refs/heads/master@{#599071}
-
Scott Chen authored
The original CL 1252906 was reverted due to breaking unit tests for branded window builds. This CL fixes that by removing obsolete unit tests. It was testing the mechanism that conditionally directs users to the chrome://welcome/email and chrome://welcome/apps experiment URLs, which will no longer be used. Bug: 874153 Change-Id: I3b92b53e191606a6f5889cf17b15a570ce566994 Reviewed-on: https://chromium-review.googlesource.com/c/1275294Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#599070}
-
Patti authored
This reverts commit c3acb7ba. Reason for revert: This change may be causing ash_unittests to fail on multiple builders - see crbug.com/894683 Original change's description: > splitscreen: Adjust bubble dialog bounds if splitscreen is active. > > When a dialog is added to a window that's currently showig in > splitscreen, we should adjust the dialog bounds to show the dialog > aligned within its own side of the split, rather than across the divider > bar. > > Note the divider is still placed on top of the snapped windows and its > transient children if they are placed in default container. > > Bug: 878268 > Change-Id: Ibdd71f1d42aac419ef73ae9f7a2f78af6bf36880 > Reviewed-on: https://chromium-review.googlesource.com/c/1274197 > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#598827} TBR=xiyuan@chromium.org,xdai@chromium.org Change-Id: I74d78ce0184d2028811872ac633da33ede16f296 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878268, 894683 Reviewed-on: https://chromium-review.googlesource.com/c/1277907Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#599069}
-
Kent Tamura authored
This CL makes LayoutTests/PRESUBMIT.py and some tests in LayoutTests/ workable in blink/web_tests/ too. Moving LayoutTests directory gets easier by this CL. * PRESUBMIT.py - Use PresubmitLocalPath() instead of 'LayoutTests' - Remove unnecessary check for existence of 'LayoutTests' in AffectedFiles(), which returns files under the PRESUBMIT directory. _FindNewViolationsOfRule() also handles only files under the PRESUBMIT directory. * Tests - Update code searching for 'LayoutTests' so that it searches for 'web_tests' too. - Drop 'LayoutTests' from test expectations if we can - Introduce relativeTestPath() Change-Id: I741ab3cb29d8e6c2a35e3b7669f92744f76c2839 Bug: 843412 Reviewed-on: https://chromium-review.googlesource.com/c/1276047Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#599068}
-
Henrique Nakashima authored
Previously, after HandleMessage matched the message type, if the argument types were wrong it would keep trying to match with the other message types. Change-Id: Ia270ddc0ac4614b3ef998bcd30d3686f987dd809 Reviewed-on: https://chromium-review.googlesource.com/c/1277445Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#599067}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 08d41ac5. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25970 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ic18cb6ace02a8e07c8b1c4fcca71bd9ce8704ebd Reviewed-on: https://chromium-review.googlesource.com/c/1278142 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#599066}
-
John Rummell authored
BUG=894422 TEST=test passes on Windows Change-Id: I3907fecda3642f542db153e68ce12cb33c074402 Reviewed-on: https://chromium-review.googlesource.com/c/1278467 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#599065}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/55ac0aa2f68f..616feb1a7c2c Created with: gclient setdep -r src-internal@616feb1a7c2c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia68c999e8e301f47fc1e0dadeb8cd369a1377495 Reviewed-on: https://chromium-review.googlesource.com/c/1277840Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599064}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c7f66edd2244..94f3ca931552 git log c7f66edd2244..94f3ca931552 --date=short --no-merges --format='%ad %ae %s' 2018-10-11 thestig@chromium.org Fix some nits in CJS_Document helpers. 2018-10-11 thestig@chromium.org Use pdfium::Vector2D in CCodec_FaxEncoder ctor. Created with: gclient setdep -r src/third_party/pdfium@94f3ca931552 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I062fef526b85eec3b0d299893951ad74a10d4b2c Reviewed-on: https://chromium-review.googlesource.com/c/1278485Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599063}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7078e2599b7b..d23bbdb87b57 git log 7078e2599b7b..d23bbdb87b57 --date=short --no-merges --format='%ad %ae %s' 2018-10-12 gmx@chromium.org kip: enable new tcmalloc Created with: gclient setdep -r src/third_party/chromite@d23bbdb87b57 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7c19b61739142e56b9c1053adbbf8b5884e2738c Reviewed-on: https://chromium-review.googlesource.com/c/1277836Reviewed-by:
-
Edward Lemur authored
Bug: 881860 Change-Id: I32d8c17e2501010a24b9550c433407dfd55a3807 Reviewed-on: https://chromium-review.googlesource.com/c/1278525Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#599061}
-
Eric Roman authored
Bug: 891526 Change-Id: I3ecda33cc7c1dbc2df96a613c5723a77ead9806c Reviewed-on: https://chromium-review.googlesource.com/c/1258505Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#599060}
-
Jeremy Klein authored
Adding a temporary exception for one link-in-text-block error. This error comes from the fact that we (intentionally) removed the underline from the learn more links in our settings. I've filed crbug.com/894602 to work with UX on a new strategy and remove this exception. Bug: 894602 Change-Id: I0da37adfee02699415a011939dbfc6d4e1d93f34 Reviewed-on: https://chromium-review.googlesource.com/c/1278131 Commit-Queue: Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#599059}
-
Jeremy Klein authored
The phone side flags and enrollment will be slower than the ChromeOS rollout. In order to avoid breaking Instant Tethering in the meantime, look for cases where: 1) There are no host devices reporting BETTER_TOGETHER_HOST support. 2) There is at least one host device reporting INSTANT_TETHER_HOST support. In this scenario, the only possiblity is that this host device has not reenrolled yet after receiving the new flags. Bug: 893769 Change-Id: Ib7fd0acdbe80903a499dd0dd42fd60365304371d Reviewed-on: https://chromium-review.googlesource.com/c/1277272 Commit-Queue: Jeremy Klein <jlklein@chromium.org> Reviewed-by:
-
Lei Zhang authored
Also remove some unused/redundant headers, and remove a check that will always evaluate to true. Change-Id: I816ab3154c50b1f0f1f8c4fc738760b97e607d7e Reviewed-on: https://chromium-review.googlesource.com/c/1277677Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#599057}
-
Nico Weber authored
This reverts commit 4e9c4b37. Reason for revert: This might no longer be needed; revert to check. (I thought the bot built in two different build dirs, and for that to work we need to land https://chromium-review.googlesource.com/c/chromium/src/+/1273479 first, but it builds in one dir, moves that elsewhere, and builds in that dir again. We should probably make it build in two different dirs once that other CL is in, to make sure that that keeps working.) Original change's description: > Set symbol_level=0 on Windows Deterministic. > > If /debug is passed to lld, the pdb aging in PDB70DebugInfo currently > means that repeat builds get different PDB70DebugInfo headers, so for now > don't pass /debug to the linker. > > Bug: 330260 > Change-Id: I86e6b470ad95f3f6556c8f8f69d6d394a32661ff > Reviewed-on: https://chromium-review.googlesource.com/1162948 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580765} TBR=thakis@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 330260 Change-Id: I8637e6c089464eddc7d9cfc35f6fa28b0cd54987 Reviewed-on: https://chromium-review.googlesource.com/c/1277486Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#599056}
-
khmel@chromium.org authored
TEST=Manually BUG=b:117366533 Change-Id: I1038cbd9adf7e92df1953a428cd9b1a9bceb9b45 Reviewed-on: https://chromium-review.googlesource.com/c/1278291 Commit-Queue: Yury Khmel <khmel@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#599055}
-
HyeockJinKim authored
Remove sub-namespace and rename symbols to start with WebSpeechSynthesisConstants. Bug: 889726 Change-Id: I48be833ca3b71f6a482f23d168a2aeaf212323f4 Reviewed-on: https://chromium-review.googlesource.com/c/1257722Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#599054}
-
rbpotter authored
Fixing CrSettingsPeoplePageSetupPinDialogTest.All with 2 changes: (1) Reading updated pin dialog from the pin-change event, rather than from |pinKeyboardValue_|. In Polymer 2, this value is not updated at the time the pin-change event arrives. (1) In the test for the backspace button, set the value in cr-input instead of on the pinKeyboard directly, so that |selectionStart_|, used to determine if the backspace key should be enabled, will be > 0. Bug: 875454 Change-Id: Iec83f3a85a4d04fe710cb6b5e23b99d59be54f49 Reviewed-on: https://chromium-review.googlesource.com/c/1274462 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: -
Xiaocheng Hu authored
This patch changes tests in the following directories to use Element.innerText for text dump: accessibility/ animations/ battery-status/ bindings/ clipboard/ compositing/ crypto/ Most of this patch is mechanical rebaseline, except: - Some LayoutNG-specific baselines become redundant and are removed - One test is turned into failure with LayoutNG flag due to LayoutNG innerText bug with ellipsis (crbug.com/873957). Bug: 887148 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Idf28a2696b4824f3fd845c7392b588544e8de1d3 Reviewed-on: https://chromium-review.googlesource.com/c/1239165Reviewed-by:
-
Kunihiko Sakamoto authored
This removes internal testing API that overrides SignedExchange signature verification time, which is no longer needed since --ignore-certificate-errors-spki-list now ignores signature timestamp errors. This is mostly a revert of https://crrev.com/c/991833. Bug: 803774 Change-Id: I5b2f77062d897f6c025566ea98fe740735ae8172 Reviewed-on: https://chromium-review.googlesource.com/c/1270457Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#599051}
-
Thomas Anderson authored
This reverts commit 6d83f4b9. Reason for revert: Suspected cause of browser_test failures on "Mac10.13 Tests (dbg)": https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/5697 Original change's description: > macOS V2 Sandbox: Report correct sandbox profile for nacl-loader. > > The nacl loader process, used only on macOS, currently tries to load an > invalid profile type under the V2 sandbox. This loads the correct type. > > Bug: 892554 > Change-Id: I7b2733db426e3c91181b1f375d791d2918ac6763 > Reviewed-on: https://chromium-review.googlesource.com/c/1268671 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Derek Schuff <dschuff@chromium.org> > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#598380} TBR=dschuff@chromium.org,tsepez@chromium.org,kerrnel@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 892554 Change-Id: Ib5a7767695fce263830cf9329da0cda99aaab9b7 Reviewed-on: https://chromium-review.googlesource.com/c/1278162Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#599050}
-
Sunny Sachanandani authored
EGL_ANGLE_flexible_surface_compatibility allows contexts to be able to bind to surfaces with different formats e.g. with or without alpha. With DirectComposition, we have a real surface inside a Begin/EndDraw pair, and use a default 1x1 pbuffer surface outside of that. That surface must be created with flexible surface compatibility so that we can MakeCurrent outside of Begin/EndDraw. Noticed this while working on a related change. There were some crashes in MakeCurrent in SetSwapInterval which was fixed in a different way by removing SetSwapInterval, but it's possible the root cause was this. Bug: 800950 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I05aa1a61bfa0d1445778bbd9599d3f630dddbe8c Reviewed-on: https://chromium-review.googlesource.com/c/1237535Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#599049}
-
Albert J. Wong authored
The |input_router_| field is initialized early in the constructor and only ever replaced with a new instance so null-ness is not possible. Bug: 545684 Change-Id: Ib6ecbffd20cebfd5f6c5f23557494681b11435f2 Reviewed-on: https://chromium-review.googlesource.com/c/1277585 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#599048}
-
Avi Drissman authored
BUG=none Change-Id: I118976f80f3c605f7b2c5cb05e8b60278fded19d Reviewed-on: https://chromium-review.googlesource.com/c/1272495Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Albert J. Wong authored
As part of the effort to stop RenderWidgetHost from forwarding it's messages in OnMessageReceived() on to other classes (which lead to spooky message-action at a distance), this introduces a new shim class InputEventShim that allows BrowserPlugin to override various input event related messages in RenderWidgetHost. This also simplifies some of the message routing in InputRouter allowing it to NOT be a IPC::Listner, which again, makes inter-class relations more explicit. There should be no functionality change. Bug: 419087 Change-Id: I75f2f4cc1d1b6d36373c75dc7b4ae7bd7af1afe4 Reviewed-on: https://chromium-review.googlesource.com/c/1274606Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/47faa068e8ff..066e11079d98 git log 47faa068e8ff..066e11079d98 --date=short --no-merges --format='%ad %ae %s' 2018-10-11 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@066e11079d98 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ib36b95d43c0bf2ffa7161c1ce49349c6f59b3873 Reviewed-on: https://chromium-review.googlesource.com/c/1277763Reviewed-by:
-
James Cook authored
It passes for me locally. I don't see anything in the test or the underlying code that depends on the mash mode. I'm not sure why it was being skipped. Bug: none Change-Id: I300bd010ffa68c3cb5c6efec2df316752971084c Reviewed-on: https://chromium-review.googlesource.com/c/1277954Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#599044}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fb226af64dad..1cd39fa9ea0c git log fb226af64dad..1cd39fa9ea0c --date=short --no-merges --format='%ad %ae %s' 2018-10-11 jonaso@webrtc.org make CreateOffer/CreateAnswer use ice credentials of pooled sessions. 2018-10-11 yvesg@webrtc.org Headers shouldn't include themselves. 2018-10-11 benwright@webrtc.org Move CryptoOptions to api/crypto from rtc_base/sslstreamadapter.h 2018-10-11 srte@webrtc.org Adds handling of untracked data to congestion controller. 2018-10-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f34485ff..9d052f4b (598711:598839) 2018-10-11 srte@webrtc.org Removes socket addresses from PacketInfo struct. 2018-10-11 srte@webrtc.org Adds tracking of allocated but unacknowledged bitrate. 2018-10-11 nisse@webrtc.org Delete unused utf8 conversion utilities 2018-10-11 srte@webrtc.org Adds IP overhead info to PacketInfo. 2018-10-11 devicentepena@webrtc.org AEC3: Enabling by default the use of the stationarity properties at render at init 2018-10-11 terelius@webrtc.org RtcEventLogSource no longer uses deprecated parsing functions. 2018-10-11 yvesg@webrtc.org Fix race conditions for ReofferDoesNotCallOnTrack test. 2018-10-11 gustaf@webrtc.org AEC3: Kill kill-switches 2018-10-11 srte@webrtc.org Adds default values for feedback/allocation indicators. Created with: gclient setdep -r src/third_party/webrtc@1cd39fa9ea0c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:894439 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Idd9b3d88e5b4ce791774fabce00dfddd33a9ad21 Reviewed-on: https://chromium-review.googlesource.com/c/1277758Reviewed-by:
-
Jun Cai authored
Reland: Network Service: Migrate chromeos::assistant::NetworkProviderImpl to NetworkConnectionTracker The original CL is: https://chromium-review.googlesource.com/c/chromium/src/+/1270950 and the Initial upload is the same as the original CL. The reland CL fixes compile error on chromeos. TBR=jam@chromium.org, stevenjb@chromium.org, xiaohuic@chromium.org, rmcelrath@chromium.org Bug: 887040 Change-Id: Ic0cf9d07f7c7d6c5c59694c1414bc38b83a36456 Reviewed-on: https://chromium-review.googlesource.com/c/1277647Reviewed-by:
Jun Cai <juncai@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#599042}
-
Chris Lu authored
- Deletes favicon logic in bookmarks and just calls FaviconForUrl to retrieve favicon. - Adds TouchIconFromGoogleServer() for all Google Server requests made by FaviconLoader to ensure they stay in the database longer. - Removing LargeIconService request cancel logic, since it was deemed an unnecessary complexity (https://docs.google.com/document/d/1-c4YEmRta2qcg2HC9VzQZoeI9CBG3yccfN3GBITU910/edit) Change-Id: Ib44d53e4d50ac27c2871bb7916370fc9ccfe6380 Reviewed-on: https://chromium-review.googlesource.com/c/1262414 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#599041}
-
Jordy Greenblatt authored
In principle a user should never be in the subpage without a host set so we didn't bother to put in a default for the case of no set host when we made the page in the first place. However, this seems to be causing a11y test failures, so we are using the label text for the settings main page which is exactly what we want (i.e. the host name) when the host is set. In other words, this should look the same to the user. Change-Id: I03ddf0cd298d9ca8eb832e14cff354c419d5acb6 Reviewed-on: https://chromium-review.googlesource.com/c/1277680Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
-
Kurt Horimoto authored
The WKWebView frame relative to the image frame has been changed; so update the touch location. Bug: 894597 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ifdf34f7596352a9414c562fee09e4b2b561702b9 Reviewed-on: https://chromium-review.googlesource.com/c/1277831Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#599039}
-
Timothy Loh authored
Transient Crostini windows are supposed to be filtered from the shelf, but we are checking for a transient parent on window Init, which is before it actually gets set. This was causing a UAF on profile switching as MultiUserWindowManagerChromeOS::SetWindowOwner() is not supposed to be called with transient windows. Bug: 845843 Change-Id: Iec7b48cb03fff22775c31ce08c398ba750836463 Reviewed-on: https://chromium-review.googlesource.com/c/1266475 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#599038}
-
Bret Sepulveda authored
When a touch event is not handled, WindowEventDispatcher will generate gesture events from it. However, when those gesture events are marked as handled that handling doesn't propagate back to the original touch event. For bug 852241, the hamburger menu only handles gesture events. On Windows, selecting an option with a touch would cause the hamburger menu to close, but because the touch event wasn't marked as handled Windows would pass it along to the underlying window, causing it to gain focus. Most of the time it would be gaining focus anyway (since the hamburger menu just closed) so this isn't noticeable, but the Cast dialog is a newly-added surface that closes if it loses focus. In this case, it seems to not appear at all. Similarly for bug 866421, when the guest window becomes restored it reveals the window underneath and then Windows passes the event along, giving it focus. This patch marks all touch released as handled by default, which prevents Windows from ever propagating them. These events generate the tap gestures that cause the state change in the hamburger menu and window size in the above bugs. Bug: 852241, 866421 Change-Id: I10a67d56fdc46d5b91282e0f395c895339f71951 Reviewed-on: https://chromium-review.googlesource.com/c/1260507 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/865321239f56..55ac0aa2f68f Created with: gclient setdep -r src-internal@55ac0aa2f68f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8570cdea9745766fdfb3c8f741685c81d8850ad4 Reviewed-on: https://chromium-review.googlesource.com/c/1277761Reviewed-by:
-
Daniel Erat authored
Make the chrome.autotestPrivate API's getHistograms function call content::FetchHistogramsAsynchronously() and base::StatisticsRecorder::ImportProvidedHistograms() to fetch and incorporate histogram data from other processes, similar to what chrome://histograms does. Without this, the function (which is called over the Chrome DevTools Protocol by Chrome OS integration tests) serves stale data. For example, Media.GpuVideoDecoderInitializeStatus samples are missing since that histogram is recorded from renderer processes. Bug: 893937 Change-Id: Id6415f1a32b41ad7ddeb251216f09b2314eb5980 Reviewed-on: https://chromium-review.googlesource.com/c/1274892 Commit-Queue: Dan Erat <derat@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#599035}
-
