- 29 Nov, 2018 40 commits
-
-
Devlin Cronin authored
Update APIPermission and ManifestPermission (and their subsequent subclasses) to return a std::unique_ptr from the Clone(), Diff(), Union(), and Intersection() methods. This makes the ownership of the return result significantly more clear. Update all usages of these methods as well. Bug: 907661 Change-Id: I5110014cca0af9b5364fd8fa8bdcdfc4fee58195 Reviewed-on: https://chromium-review.googlesource.com/c/1347777 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#612005}
-
Xianzhu Wang authored
Stat on top 25 sites showed that the objects that have PaintProperties but not LocalBorderBoxProperties were only 1% of all objects having PaintProperties. Most of them were objects with link highlight and some SVG objects with paint properties. This fixes a bug in svg/text/text-selection-text-08-b.svg that the opacity was not applied on the selection tint. This will simplify handling in situations e.g. when we need to know the transform state of an object with link highlight. Change-Id: Iaa48469e69a96c3decb739d6b49526519556b869 Reviewed-on: https://chromium-review.googlesource.com/c/1354221 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612004}
-
Nigel Tao authored
Just names and icons for now. More features will come in future commits. Tested manually, with "chrome --enable-features=AppService". BUG=826982 Change-Id: I465daa7597e5172792d185e8b33228b127879057 Reviewed-on: https://chromium-review.googlesource.com/c/1349155 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#612003}
-
Michael Spang authored
This fixes a crash if you don't pass --enable-features=OzoneDrmMojo. Oops. Bug: 861853 Test: run_content_shell with no arguments Change-Id: I5408ca9323b8481ed6c5f092172b75f2181c94fe Reviewed-on: https://chromium-review.googlesource.com/c/1354502Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612002}
-
John Budorick authored
Note that this does not affect mac_chromium_rel_ng. Bug: 908929 Change-Id: I4834ae78bb0e037a2def2fd73762b5a90c0ef949 Reviewed-on: https://chromium-review.googlesource.com/c/1354131Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#612001}
-
Troy Hildebrandt authored
Adds a SharedProtoDatabase that owns a LevelDB instance. The shared database provides a way to get SharedProtoDatabaseClients to access the shared DB with a unique namespace/prefix. The SharedProtoDatabase instance is provided through the KeyedService ProtoDatabaseProvider so the shared database is tied to the appropriate profile directory. Bug: 870813 Change-Id: I433518c3fee4d37abcaa0c7efa94e7912da521ec Reviewed-on: https://chromium-review.googlesource.com/c/1332009Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612000}
-
David Black authored
This is preferred over unchecked observers. Bug: b:120097552 Change-Id: Id44822dce375e3400baa336fee3154ad99d18d7f Reviewed-on: https://chromium-review.googlesource.com/c/1354569 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#611999}
-
Mustafa Emre Acer authored
Bug: 909944 Change-Id: Ic3304d8a0244a9cea5b5a3b151f8245b8c8269eb Reviewed-on: https://chromium-review.googlesource.com/c/1354642 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Cr-Commit-Position: refs/heads/master@{#611998}
-
David Black authored
The chain of ownership between AssistantResponseProcessor and UI elements that were being processed was overly complicated. Previously, it was possible for callbacks to fire when the underlying UI element had already been destroyed. Now, we refactor processing logic so that processors are bound to the response/element that they are processing. As such, lifecycle complications are drastically simplified. Bug: b:119674543 Change-Id: I04a08f29ffaf0178d409c7bc0e5d84292993d1ae Reviewed-on: https://chromium-review.googlesource.com/c/1350961 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Xianzhu Wang authored
It was the same as GraphicsLayer::CcLayer() and was easily to be mixed up with Graphics::ContentsLayer() which returns the real contents layer. Change-Id: I260791979cdd82c42dd23eb20bd5fdb522898b37 Reviewed-on: https://chromium-review.googlesource.com/c/1354440Reviewed-by:
-
Eliot Courtney authored
applied both times. Bug: 908337 Test: Open and close a Chrome PIP window twice. Slide out animation is Change-Id: I617e008070f733184d635486ea3c14b260838c8b Reviewed-on: https://chromium-review.googlesource.com/c/1350026 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#611995}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1a2476d29456..22619c2e1a6d git log 1a2476d29456..22619c2e1a6d --date=short --no-merges --format='%ad %ae %s' 2018-11-28 csmartdalton@google.com Remove instanced flush WAR for Skylake 2018-11-28 csmartdalton@google.com Reland "Prefer GrAAConvexPathRenderer over ccpr" 2018-11-28 herb@google.com Move the empty glyph checks into the common code 2018-11-28 kjlubick@google.com [canvaskit] Fix arc() call 2018-11-28 kjlubick@google.com gn format gn/opts.gni 2018-11-28 michaelludwig@google.com Reland "Initial definition of fill rect op" 2018-11-28 herb@google.com Fix up GrGlyphCache ctor 2018-11-28 reed@google.com remove legacy hinting-enum guards Created with: gclient setdep -r src/third_party/skia@22619c2e1a6d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:860021 TBR=borenet@chromium.org Change-Id: Id2658c8e866288fad7c8b9ab819b62c31e2571b4 Reviewed-on: https://chromium-review.googlesource.com/c/1354337Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611994}
-
Eric Roman authored
This preserves its previous behavior (localhost now bypasses the proxy). Bug: 901896 Change-Id: I2d651b6ff8828d3f344fed0aecf4fb4ae4c31eb8 Reviewed-on: https://chromium-review.googlesource.com/c/1354646Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611993}
-
Ryan Tseng authored
Bug: 889542 Change-Id: I59055c2ce9b6af9026ee8284dd3f943cc0d7d179 Reviewed-on: https://chromium-review.googlesource.com/c/1252625 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#611992}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c959e1230546..70282bd00ee9 git log c959e1230546..70282bd00ee9 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 treehugger-gerrit@google.com Merge "Fix MSAN and debug build." 2018-11-28 primiano@google.com Merge "perfetto: fix MSAN bugs in ftrace muxer" Created with: gclient setdep -r src/third_party/perfetto@70282bd00ee9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I94a144d1601fcb0032ee3d940c701480892cf979 Reviewed-on: https://chromium-review.googlesource.com/c/1354618Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I2e2b85af56153b60836ae799e45623dcf25c48e4 Reviewed-on: https://chromium-review.googlesource.com/c/1351147Reviewed-by:
-
Matt Falkenhagen authored
This is the same fix as r583483 did for issue 872078. As that commit description says: "Before this CL, this test tried to get performance entries right after Response#text() is resolved, but Chrome doesn't guarantee that there will be a performance entry for the response at that point. This CL changes the test to use PerformanceObserver so that we can make sure that there will be a performance entry for the response." Bug: 846631 Change-Id: Ia8aaf82939f4457b7e2427bbefacce79150fbb20 Reviewed-on: https://chromium-review.googlesource.com/c/1353032 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#611989}
-
Dean Liao authored
LOG_ASSERT() platform and factory pointers in case they are null. BUG=None TEST=None Change-Id: If40e3cfffcd64a15de0010f7cd57e987b1955023 Reviewed-on: https://chromium-review.googlesource.com/c/1352122Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Cr-Commit-Position: refs/heads/master@{#611988}
-
jonross authored
viz::LocalSurfaceIdAllocation bundles a viz::LocalSurfaceId and an allocation time for that viz::LocalSurfaceId. The purpose of this allocation time is to determine how long it takes for a surface to get embedded once an ID has been allocated for it. There was some concern raised about drift between LocalSurfaceIds and allocation times and so a previous CL bundled the two together in a class. This CL plumbs LocalSurfaceIdAllocation to more places to ensure the two quantities remain in sync with one another. This CL plumbs removes various accessors on ParentLocalSurfaceIdAllocator that return a LocalSurfaceId. This is to encourage future plumbing of LocalSurfaceIdAllocation instead. Bug: 655231 TBR: boliu@chromium.org Change-Id: I304cff6343dc73a26c12852fa33ed5926223b320 Reviewed-on: https://chromium-review.googlesource.com/c/1330217 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#611987}
-
Carlos IL authored
Change-Id: I7f39643ed0a932adf0d4677ff4e676fe0b9cec00 Reviewed-on: https://chromium-review.googlesource.com/c/1352574 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#611986}
-
Mohsen Izadi authored
Multi-Process Mash by default runs Viz in Ash process. There is a --enable-viz flag used to run it as a separate process. This CL changes that flag to a feature named MashOopViz and adds it to chrome://flags page. When Viz runs properly as a standalone process, we can get rid of this flag and make it the default behavior for Mash. Then, --in-process-gpu flag can be used to run Viz in Ash process. BUG=862384 Change-Id: I3015a0936a7287e7a7106c86bbed55863eabdbbe Reviewed-on: https://chromium-review.googlesource.com/c/1349478Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#611985}
-
Christian Biesinger authored
The CSSWG would like to apply align-content to single-line flexboxes as well: https://lists.w3.org/Archives/Public/www-style/2018Nov/0007.html https://github.com/w3c/csswg-drafts/issues/3052 Add a use counter for that to see if it is web-compatible. TESTED=Manually using chrome://histograms R=eae@chromium.org, tabatkins@google.com Change-Id: I3af67474937c8c589e8235c451b358b839556d1f Reviewed-on: https://chromium-review.googlesource.com/c/1354539 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#611984}
-
Miguel Casas authored
This CL changes the call to vaCreateContext() to use a set of dummy VASurfaceIDs and removes the then unnecessary parameter from CreateContext(). Bug: None Change-Id: Ibe64deb21ff2f9fabf351740389a60eb44ff1636 Reviewed-on: https://chromium-review.googlesource.com/c/1351747 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Jered Gray authored
The previous logic in OptimizationGuideService created an optimization_guide::proto::Configuration object on a background thread and then used task posting to send it on to PreviewsHints::CreateFromConfig(), where it was used to create a PreviewsHints object on another background thread. In all, there were two tasks posted that included the config object as a parameter, one on the background thread and one on the UI thread. Including it as a parameter in a task requires a full copy of the protobuffer. This means that a full copy of the config protobuf, which can be as large as 1.8MB (the size of the current Brazil one on Canary), was occurring on the UI thread. In local performance measurements, making a single copy of a 600KB version of the protobuf took several milliseconds (it amounted to roughly 60% of the time taken by the initial component string parsing and 60% of the time taken by PreviewHints::CreateFromConfig()). Given that we were incurring the cost of two copies, one of which was on an extremely high priority thread, it makes sense to change the logic to eliminate the need for the copies. The logic has been altered so that OptimizationGuideService no longer immediately processes the component, but instead notifies the observers that it is available and allows them to trigger the processing. This eliminates both copies of the configuration protobuf, as it is now created where it is used. Additionally, OptimizationGuideServiceObservers are now immediately notified of the hints component when they register if one is already available. This will enable the PreviewsOptimizationGuide to wait until the HintCacheLevelDBStore is fully initialized before registering for the component, and in the future will potentially allow it to avoid processing the configuration altogether when the store already has the latest version cached. New unittests have been added and older ones have been updated to accommodate the new logic. The related browser tests have also been modified to be more robust, where they now wait for a signal from a local histogram indicating that hint processing is complete. Bug: 908985 Change-Id: I330fcc35f14388b8a704d3180bd758e7327e9892 Reviewed-on: https://chromium-review.googlesource.com/c/1351719 Commit-Queue: Jered Gray <jegray@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#611982}
-
Robert Ogden authored
A pingback is sent whenever there is a server_lite_page_info struct on the associated PreviewsUserData. This CL does not add any new metrics to the pingback, that comes in the last CL (next) for this bug. Bug: 864665 Change-Id: I25059066b8d460d87613bd1969ceb7cb0a4ed3e1 Reviewed-on: https://chromium-review.googlesource.com/c/1354126Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#611981}
-
Devlin Cronin authored
There were two issues with the BaseSetOperators copy constructor and assignment operator: 1) The methods were declared to take a const T&, rather than a const BaseSetOperators<T>&. This meant that, since BaseSetOperators didn't delete the default copy/assignment methods, the result was that code would use the compiler-generated versions, bypassing our safer copy methods. 2) Once fixing that so that the custom copy/assignment methods are called, the assignment operator did not clear the map. This meant that any previous values in the map would remain present. Fix both of these issues, and add regression unittests. Bug: 908619 Change-Id: Id633467f165801f2be09f453f5c46102f023b687 Reviewed-on: https://chromium-review.googlesource.com/c/1351886 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Khushal authored
CCPR tends to be slower for chrome's tiled rendering due to its interaction with CCPR caching strategy. R=vmiura@chromium.org Change-Id: I3ddc221675e9c844261de6f7e8006091812462ee Reviewed-on: https://chromium-review.googlesource.com/c/1354331Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#611979}
-
Moe Ahmadi authored
- Integrates ARQuickLookTabHelper in BrowserDownloadService in order to handle downloading USDZ format files. Bug: 908696 Change-Id: I977e1609d02e6f14e7f84d9d2fba5b4cce96e76e Reviewed-on: https://chromium-review.googlesource.com/c/1352120 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#611978}
-
Sammie Quon authored
Refactor overview and cycle list code. The should end up showing the same windows, so they should share the same codes if possible. Test: manual Bug: 844829 Change-Id: Ib5f2800f7b0876afcff10cea3bf37f0156e83467 Reviewed-on: https://chromium-review.googlesource.com/c/1344814 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
-
Chad Duffin authored
Implemented the ability to allow the Presenter API to be used to display fullscreen when running on Fuchsia. Change-Id: I2b5b32b4a2ea3c1623951f0c7af361fc68592185 Depends-On: https://chromium-review.googlesource.com/c/chromium/src/+/1313873 Reviewed-on: https://chromium-review.googlesource.com/c/1320975 Commit-Queue: Chad Duffin <chadduffin@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#611976}
-
lanwei authored
If we have more than one touch monitor and we are expanding chrome window to all the touch screens, we can only touch on one screen not the others. We found out the when we searched for targets of the touch events, we could not find the right target, which should be "RenderWidgetHostViewAura", because we are checking if the screen locations of the touch events are in the display's bound, which only matches to one monitor. We should change to screen's bound, which can represent the bound of all the screens that are connected. Bug: 901399 Change-Id: I9c85d6e81d0d1bbaf023f566b1512a5c7b839625 Reviewed-on: https://chromium-review.googlesource.com/c/1354125 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
-
Derek Schuff authored
Change-Id: I536145529ece588c4b7b5311fd86979045949a3b Reviewed-on: https://chromium-review.googlesource.com/c/1354323Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Derek Schuff <dschuff@chromium.org> Cr-Commit-Position: refs/heads/master@{#611974}
-
Nigel Tao authored
These ImageLoaderFooBarCallback typedef's were previously base::Callback, neither explicitly a base::OnceCallback or a base::RepeatingCallback. Presumably these typedef's were first defined before there was a base::OnceCB vs base::RepeatingCB distinction. The general motivation for this commit is that base/callback.h says that it intends to flip the type alias of base::CB to be base::OnceCB instead of base::RepeatingCB. The specific motivation for this commit is to be able to call ImageLoader::LoadImagesAsync as part of a Mojo IPC call chain. The mechanism for Mojo method calls to return something is a base::OnceCB. You can easily use a base::OnceCB to call another base::RepeatingCB (once), but doing vice versa is trickier, especially if the base::OnceCB expects to be std::move'd around but base::BindRepeating expects to copy its arguments. A very specific motivation is to make the app_icon_factory.h API more consistent, with its functions all taking the same type of callback, a base::OnceCB. Change-Id: Iec560709d97be22e92ccd17a27bad39eab597c6f Reviewed-on: https://chromium-review.googlesource.com/c/1348875Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This CHECK is currently occasionally failing in the wild, but the failure of the CHECK doesn't mean any serious correctness issues. Make it a DCHECK for now to prevent crashes, and investigate separately. Bug: 865098 Bug: 899217 Bug: 909858 Change-Id: Ie99a1e79bd239ac01021e1d942724cf3bdfdd510 Reviewed-on: https://chromium-review.googlesource.com/c/1353955 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#611972}
-
Matt Falkenhagen authored
This test was originally created to test "cross-site transfers" that happened during navigations pre-PlzNavigate. These no longer happen, so the test is no longer needed. More background: the test was always flaky because it didn't wait for service worker activation after trying to register the service worker. So it was disabled on Linux/Android/CrOS for most of its life. Later, r521904 adjusted the test because it removed the ShouldSwapProcessesForRedirect() method that the test relied on for forcing cross-site transfer. To try to keep test coverage, it added the IsolateAllSitesForTesting flag as site isolation apparently has similar behavior to the swap processes method. This flag is already run in the linux_chromium_rel_ng config in the site_per_process_content_browsertests step, but since this test was disabled on Linux, it was needed to add this flag explicitly for Windows. But it's all moot because cross-site transfers don't happen, so the test isn't testing anything interesting. We have enough coverage for site isolation with with site_per_process_content_browsertests running the normal tests. Bug: 474976 Change-Id: Icec7c4d5408f8dfb1bb2437036482c184bd2d0a2 Reviewed-on: https://chromium-review.googlesource.com/c/1353053Reviewed-by:
-
Dan Harrington authored
Setting the offline clock pointer is error-prone, as a test must ensure it resets the pointer back to null, or a later test will fail. TestScopedOfflineClock overrides the clock in a more safe way. Bug: 906903 Change-Id: Idd88c35da90bddcb3b7006c7b33547c5b36b02d2 Reviewed-on: https://chromium-review.googlesource.com/c/1351748 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#611970}
-
Darren Shen authored
Follow up to r1278462. TBR=stevenjb@chromium.org Bug: 849995 Change-Id: I35d0e1e64149e5b71b3da409a7ade18995039854 Reviewed-on: https://chromium-review.googlesource.com/c/1353060Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#611969}
-
Eric Roman authored
Bug: 721403 Change-Id: I6f23e6ba1099666be58014efa840829a072b097c Reviewed-on: https://chromium-review.googlesource.com/c/1347432Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611968}
-
Moe Ahmadi authored
AutofillController for the most part forwards calls from AutofillClient and AutofillDriver to AutofillAgent. This complicates understanding and debugging the logic. It also has some logic (e.g., adding clear form and gpay logo to the list of suggestions) that has been a source of confusion in past. This CL gets rid of AutofillController by: -Removing the middle man for the AutofillClient and AutofillDriver calls. -Moving the logic to setup AutofillDriver to AutofillTabHelper. -Merging its tests into AutofillAgent and JSAutofillManager tests. Change-Id: I207ec8137a8d4b0cfc1c42de8cd06b8f4de33e67 Reviewed-on: https://chromium-review.googlesource.com/c/1310353 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#611967}
-
Matt Falkenhagen authored
Add a browser test that serves a service worker from chrome://dummyurl/sw.js, and attempts to register it as a service worker. It of course fails, but for several reasons it's hard to change Chrome to get the registration to succeed to prove the test would catch a regression should one occur. Also add a simple unit test that that ChromeContentClient doesn't include chrome:// in the whitelisted schemes for service workers. The browser test crashes locally with a DCHECK in the destructor for DBus, apparently because it finishes too quickly. Not sure if that also happens on the bots. Bug: 823475 Change-Id: I41db993405de219cadaf63cfe43ed0844ba6f1fe Reviewed-on: https://chromium-review.googlesource.com/c/1351205 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#611966}
-
