- 09 Sep, 2019 27 commits
-
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/favicon. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=mastiz@chromium.org Bug: 891670 Change-Id: I9a8ef1f34217a8d8110454a28138963c99b66ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787060 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#694652}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6c3bd09ead0f..7588f07cd928 git log 6c3bd09ead0f..7588f07cd928 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 5d0faf9be9d7..44e6523d7ff3 (12 commits) Created with: gclient setdep -r src/third_party/skia@7588f07cd928 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: chromium:None Change-Id: I0fd6e2ec1f623a5cea68d9946a565daa55bc1285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791435Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694651}
-
David Munro authored
BUG=chromium:996945 Change-Id: I9c53f26e6a9364e88b641a6af677b0340d79012a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787489 Commit-Queue: David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Auto-Submit: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#694650}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 67aeeb51. With Chromium commits locally applied on WPT: 1f146124 "[WPT/common/security-features] Remove {mixed-content,referrer-policy}-test-case.sub.js" bfd6ddf8 "[WPT/common/security-features] Update subresource and redirection type names" 9d7721df "Strip the fragment directive and update scroll-to-text WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I74009311a82387db712800215761b478fe525ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792084Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694649}
-
David Staessens authored
This CL fixes the IVF header of the resolution_change_500frames-vp8.ivf and resolution_change_500frames-vp9.ivf videos. These test files were created manually and have an incorrect IVF header. The first 4 bytes are set to 'DKIF' to identify the file as an IVF file. The frame header size and codec FOURCC are also added to the IVF header. Other entries such as resolution have not been added. TEST=./video_decode_accelerator_tests resolution_change_500frames-vp8.ivf BUG=b:140538436 Change-Id: Ic9738140895861a5b8e9c219082e16f190ca7c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788962Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#694648}
-
Hirokazu Honda authored
This CL changes GetTestName() to return test_suite_name+test_name, which originally returns test_name. This change mainly affects the directory where frames and images are saved. For example, the saved directory in video_decode_accelerator_tests is changed to $(CUR_DIR)/VideoDecoderTest/FlushAtEndOfStream from $(CUR_DIR)/FlushAtEndOfStream. The saved directory in image_processor_test is changed to $(CUR_DIR)/PixelFormatConversionToNV12/ConvertOneTime_MemToMem/0 from $(CUR_DIR)/ConvertOneTime_MemToMem/0. This is useful for a parameterised test like image_processor_test. For instance, before this change, image_processor_test saves the processed images in PixelFormatConversionToNV12 and NV12Scaleing to $(CUR_DIR)/ConvertOneTime_MemToMem/0. Bug: 917951 Test: video_decode_accelerator_tests --output_frames Test: video_decode_accelerator_perf_tests Test: image_processor_test --save_images Test: tast run video.DecodeAccelVDH264 Test: tast run video.DecodeAccelVDPerfH2641080P30FPS Change-Id: Ife8412603dc95ca24e87960523d249abc6bcacfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778104Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#694647}
-
Luciano Pacheco authored
The native types that are mocked in mock_entry.js (FileSystem, Entry, FileEntry, DirectoryEntry and DirectoryReader) can't be instantiated or extended in JS, making the closure type of these mocks trickier, to allow to provide the Mock type where implementation expects the native type. This issue has been solved in 2 different ways: MockFileSystem and MockDirectoryReader are marked as @extends {_native type_}, however they don't actually extend/inherit from its native type, this is only to allow Closure type check to accept these mocks as their native types. MockEntry, MockFileEntry and MockDirectoryEntry, couldn't use the same false @extends, because they use inheritance from MockEntry and closure checks the @extends with the actual "extends" in the ES6. To make Closure accept these are their natives a static factory casting to the native type is used instead of the normal constructor which is declared @private so can't be called directly. All caller sites were updated to use the factory instead of constructor. Note that to be able to promote to native type Closure requires to cast to Object first, otherwise it fails saying that the cast has to be from a derived class. Note #2: For both of these style of fixes, Closure doesn't check that the Mock actually adheres to the native type API, but it's expected that the tests would fail if the mocks don't perform the expected action/behaviour. Bug: 778674 Change-Id: I0d5e69ace7f59295dcda4a867b2746043ac9a3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788425 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#694646}
-
Kouhei Ueno authored
This CL allows pages which have requested Geolocation permission from entering BFCache, and verifies that the inflight geolocation requests from renderer are canceled when the page enters bfcache. This CL doesn't implement the request cancel logic. * The Blink code [1] already has this implemented. * This CL is just adding browser_test to verify the cancel logic. We are replacing the "real" implementations of the device service counterpart to a "fake" one so we can: - decouple the browser_test from relying on a real GPS device - "keep the request inflight": renderer requestPosition, but the "fake" service can be Pause()-d to not respond to the request, so we can test that renderer would forcibly cancel the request when put into BFCache on that case. - count the active number of mojo-channels renderer<->device_svc, to confirm that the request has been cancelled. [1] src/third_party/blink/renderer/modules/geolocation/geolocation.cc Bug: 989847 Change-Id: I9b5b5af2ee50418ff92738560039967fcb20b8a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730153 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#694645}
-
David Staessens authored
This CL changes the video_decode_accelerator_(perf_)tests to not crash when decoding a video frame failed, as this causes all further tests to be aborted. The error is now ignored, but tests will still properly fail as the number of decoded frames and their contents are verified. TEST=./video_decode_accelerator_tests \ vda_sanity-vp90_2_17_show_existing_frame_20190109.vp9 BUG=None Change-Id: I5828111fb354b765ef331a9bbb7fc1183b1cb10e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775651Reviewed-by:
-
Takashi Toyoshima authored
This patch adds webRequest API tests that inject headers in a way to trigger CORS preflight, then confirm if it actually triggers the CORS preflight only when the required extra option to avoid the CORS preflight is not specified. Bug: 1000554 Change-Id: I31bfc9b9b2495efd51d88a078f7273f8edf34118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782229 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#694643}
-
Sanket Joshi authored
This is a reland of 27e98258. The original change was reverted due to a MSAN failure with the color-picker-appearance-hue-slider-keyboard-navigation test. The test failed due to a timeout, and the likely explanation is that the test is just too slow on MSAN builds. This is being fixed by shortening the test, and it now passes on the MSAN trybot. Original change's description: > Add keyboard based navigation for visual color picker > > This change adds functionality to move the color selection ring > through the color well and hue slider via keyboard input. The user > can press the up/down/right/left arrows to move the ring in the > corresponding direction. The user can also press ctrl+[arrow key] > to perform an accelerated movement. The accelerated movement is > particularly useful for the color well as it takes time to navigate > from one end of the color well to the other with just the standard > keyboard movement. > > Bug: 994437 > Change-Id: Idfef70adf443f8576f83dc9e6c9347a0d320b768 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757159 > Commit-Queue: Sanket Joshi <sajos@microsoft.com> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#690076} Bug: 994437 Change-Id: I9e3e60568ee6e651979613af08102792728c52f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772126Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Sanket Joshi <sajos@microsoft.com> Cr-Commit-Position: refs/heads/master@{#694642}
-
Shik Chen authored
Bug: b:134636934 Test: Manually on Nocturne Change-Id: I10bf9a8af174b4686ae645e534f2500b77a218ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788424Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#694641}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dd57eac06cab..d0fb30ed6419 Created with: gclient setdep -r src-internal@d0fb30ed6419 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I4f3d418130b5adf04f4f0405c43dabbc80d7f101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792002Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694640}
-
Peter Kotwicz authored
This CL: - Fixes a regression in WebappInfo#themeColor()/ WebappInfo#backgroundColor() as a result of https://crrev.com/c/1770001 - Fixes incorrect WebappInfoTests BUG=1001755 Test=WebappInfoTest.* Change-Id: I0aaa3cdb6ae121ec2f4d2bfa9aada0117ee2ddd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790737 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#694639}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/91c6d76345fe..879cafdd9c15 git log 91c6d76345fe..879cafdd9c15 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 primiano@google.com Move wire_protocol.proto under protos/perfetto/ipc Created with: gclient setdep -r src/third_party/perfetto@879cafdd9c15 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:140126865 Change-Id: I519e40dc5cae1015e2180f5c3fcb2fed274baf8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791988Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Icf2f0bea8f4a5cd0a2999fb54c497592a68904fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790301Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694637}
-
Glen Robertson authored
Also remove repeated registrar getter. Following up on points raised offline discussing crrev.com/c/1746116 (relanded as crrev.com/c/1787021) Bug: 989792 Change-Id: I211208d5b1a3aacc66fb28e2082f0051a5254cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763277 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
-
Leon Han authored
This CL switches the IDL type definition from "enum NDEFRecordType { "empty", "text", "url", "json", "opaque" };" to "typedef DOMString NDEFRecordType" according to web-nfc spec. This is in preparation for supporting 'smart-poster' and external type records in the future, which was added in https://github.com/w3c/web-nfc/pull/278. BUG=520391 Change-Id: I45ec31afb3841cc5b12c954ffc2821da357fef04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781510 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#694635}
-
Matt Falkenhagen authored
Change-Id: Icfc0645d1a4b22a7849639febc3d076cee2d8491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787664Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#694634}
-
Matt Falkenhagen authored
Change-Id: Ie5a0001816e2833ef7382e807da9dffde45bb4ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787661Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f0efec46. With Chromium commits locally applied on WPT: 1f146124 "[WPT/common/security-features] Remove {mixed-content,referrer-policy}-test-case.sub.js" bfd6ddf8 "[WPT/common/security-features] Update subresource and redirection type names" 9d7721df "Strip the fragment directive and update scroll-to-text WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: futhark@chromium.org, andruud@chromium.org, ericwilligers@chromium.org, shend@chromium.org: external/wpt/css/css-conditional NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I66ecf8ff25114a9c457cda5fa983a7600d6766bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790710Reviewed-by:
-
Glen Robertson authored
This reverts revert d124891d. Cleanup after crrev.com/c/1746116 (relanded as crrev.com/c/1787021) Bug: 989792 Change-Id: Ied2e1561f1b60734e31780d0affe2bdc2e9d5c45 Hashtag: desktop-pwas Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786896 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#694631}
-
Hirokazu Honda authored
This CL introduces a new buffer usage enum to allocate a buffer that is capable of being rendered, read/written by CPU, input to video encoder driver. This CL doesn't contain a real case to allocate the buffer with the new buffer usage enum. Bug: 999445 Test: ozone_gl_unittests with enabling GLImageNativePixmap test case Change-Id: I9d62a04c0acc5423b9295bd78f0e8ae6c6899905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729331 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#694630}
-
Glen Robertson authored
This reverts revert e805923b. Bug: 989792 Change-Id: Ib2d26364ae836c2fd4af405957fd049a0fe55a51 Hashtag: desktop-pwas Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786370 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
-
Nicholas Hollingum authored
We would like to intercept these messages so that clients can monitor attempts to close shell surfaces. The intention is to bring up UI for forcibly closing windows that do not close themselves quickly enough. In discussion with sky@ it is undesirable to have this kind of functionality put into views::Widget, so it was added as a callback to ShellSurfaceBase. Bug: 914322 Change-Id: Ieed675c937176283356bbccdf99055138b5166ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776140 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#694628}
-
Luciano Pacheco authored
Bug: 778674 Change-Id: I02a7526e86fe85e8288a475a1cd499e76e402575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784419 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#694627}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/611648d84551..dd57eac06cab Created with: gclient setdep -r src-internal@dd57eac06cab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id75bb0a66a847304ea139271ecb34a5ce00e2e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791446Reviewed-by:
-
- 08 Sep, 2019 13 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/73694fd3..a4b8f8f4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0958519c54cff6bcc9ddced84038fb049185f915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790706Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694625}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4bfee95fc03c..611648d84551 Created with: gclient setdep -r src-internal@611648d84551 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I2f1a10d50af8c83dd44064237331d9472546fc49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791412Reviewed-by:
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/cast_channel. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=mfoltz@chromium.org Bug: 891670 Change-Id: I965bace9523d6e4bea29d46cb516d0ac3cd89ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786850 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#694623}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e686b3e1255c..4bfee95fc03c Created with: gclient setdep -r src-internal@4bfee95fc03c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I56a4984f304f2a4fd2f2756ac685caa586288305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791069Reviewed-by:
-
Rune Lillesveen authored
We used StyleForElement which does not make sure the ancestor chain for ComputedStyle is constructed for inheritance. Use EnsureComputedStyle instead. Bug: 1001703, 972752 Change-Id: I5b61f4644746c9c530bb4ac1a9335bcbac2da6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789241Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#694621}
-
Justin Cohen authored
Tentatively enabling this by default for M79. Bug: 789582 Change-Id: I030902ddbb1a19f5b49a847b727c439cfd10fcf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787885Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#694620}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/256c44257e10..e686b3e1255c Created with: gclient setdep -r src-internal@e686b3e1255c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id6143eeea9afa6630d46d3c3adb9378b933969ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791049Reviewed-by:
-
Francois Doray authored
It will be easier for Web developers to understand the purpose of this origin trial. We are renaming it before adding it to the console that will let Web developers register for this origin trial. Bug: 999594 Change-Id: Id51c361629c8bf996d0ad9ab0209caa046083f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789426Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/359ff0f85e5f..256c44257e10 Created with: gclient setdep -r src-internal@256c44257e10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I1f43302c01a23816beece08348b3240d4ce9b2bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791443Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
This is a reland of a90f0d96 Original change's description: > Enable flag TabToGTSAnimation by default > > Also update the default parameter of zooming-min-sdk-version to M. > > TBR=twellington@chromium.org > > Bug: 964406 > Change-Id: I3a23e20511f9ecb48ed70fd6952f36b06191817c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743106 > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Mei Liang <meiliang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689627} TBR=mdjones@chromium.org Bug: 964406, 997065 Change-Id: Iff003fda8274e0715b3e9ab492286218b649cdbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767611Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#694616}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/883d5f41a5cb..359ff0f85e5f Created with: gclient setdep -r src-internal@359ff0f85e5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iddd1c4b7229ae97d674ae2a79d1e3b7c36f2123f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791622Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f433336585ed..6c3bd09ead0f git log f433336585ed..6c3bd09ead0f --date=short --no-merges --format='%ad %ae %s' 2019-09-08 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@6c3bd09ead0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I18a59142988b9c07685caf932240234103920249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791513Reviewed-by:
-
Ted Meyer authored
Change-Id: I1e48eb0a2a0a42052fc078682a4766a43422ce45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790585Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#694613}
-
