- 15 Nov, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/588d23a98223..fe24d1e38c44 git log 588d23a98223..fe24d1e38c44 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 vapier@chromium.org run_tests: increase Ctrl-C timeouts 2019-11-15 vapier@chromium.org upload_prebuilts_unittest: get tests passing under Python 3 Created with: gclient setdep -r src/third_party/chromite@fe24d1e38c44 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I8bcf29d94cacc8d605243df9a8db56155a5602ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917952Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715607}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/21d0e38fc847..716db02ba1e8 git log 21d0e38fc847..716db02ba1e8 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 rmhasan@google.com [typ] Add Slow action specifier to typ's expectations parser Created with: gclient setdep -r src/third_party/catapult@716db02ba1e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:986447 Change-Id: I83e9c62f5c720624e484aaf72ecc48fd76adb65f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918812Reviewed-by:
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /chrome/browser/profile_resetter This CL was uploaded by git cl split. R=battre@chromium.org Bug: 1018667 Change-Id: Ib05a1b4e6df9e41126a2810d800be92907ee8639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917228 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#715605}
-
chrome://media-appchrome://flagTrent Apted authored
ChromeOS resource.pak increases: 26864016 -> 27594788 bytes (+713kiB) until we can remove the apps that this will replace. See go/media-app-size. Bug: 996088 Change-Id: I00c3435d428f18cf0e4e461738dcf8dc0d627fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916538 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#715604}
-
Chris Hall authored
R=aboxhall Change-Id: Ie73667890a0f30ecb7eaa16a7f2797287e1d841b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918792 Auto-Submit: Chris Hall <chrishall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#715603}
-
Noel Gordon authored
The list check icon should be filled with Blue 600 #1A73E8. Add it to the files-ng 20px icon set. Minor fix: close the <g> tag on external- link item in the icon set. Bug: 1002393, 992821 Change-Id: Ic5bee0a90c1fdcfb8eb9b6c424c00001c8bb8f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918791Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#715602}
-
Chih-Yu Huang authored
This CL uses SequencedTaskRunner, SequenceChecker, and WeakPtr to handle tasks on different sequences of V4L2ImageProcessor, without changing any logic. Also, we use function thunk to ensure a task is called on a certain sequence, instead of using media::BindToCurrentLoop. Bug: 1004727 Test: Run video_decode_accelerator_tests and video_encode_accelerator_unittests on Kukui Change-Id: I15bf1b2fa17bad75706bf0ecf543c31d813e8787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905043Reviewed-by:Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715601}
-
Dan Beam authored
This reverts commit 544412a4. Reason for revert: Performance and functional regressions https://bugs.chromium.org/p/chromium/issues/detail?id=1024034#c5 Original change's description: > Friendly Privacy Setting Initial Redesign > > This CL does 3 things: > 1) The order of rows in the privacy page is affected, regardless of the value of the "privacySettingsRedesignEnabled" flag. > 2) The privacy-page is moved to the "basic", only when the "privacySettingsRedesignEnabled" flag is on. > 3) A "more" expansion button is introduced in the privacy-page only when the "privacySettingsRedesignEnabled" flag. > > Bug: 1014143 > Change-Id: I678e81aa3b67acd2ae41eeda355cd3b32a5b4088 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872094 > Commit-Queue: Sean Harrison <harrisonsean@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714287} TBR=dpapad@chromium.org,msramek@chromium.org,harrisonsean@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1014143, 1024034 Change-Id: Ic95f592ad4913804ba738553091d907c61289e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917949Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#715600}
-
nancy authored
Add an InstanceRegistry pointer to ExtensionApps, to add the instance to the InstanceRegistry when launching apps. BUG=1011235 Change-Id: I85aea523ecd5e1ea68810bcc8e7e364d1798b5a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913286 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#715599}
-
Luciano Pacheco authored
While working in the new file list I've faced this assert error and couldn't figure out what metadata property name was wrong. This CL makes easier to identify the invalid metadata property by adding the name in the assert message. Bug: 992821 Change-Id: I258867b9b33385667a9c45a5d59cc2cf4c76c246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918796 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/11c487a891eb..5f4db6a76640 git log 11c487a891eb..5f4db6a76640 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 mihu@microsoft.com Fix performance issue with EXT_multisampled_render_to_texture Created with: gclient setdep -r src/third_party/angle@5f4db6a76640 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: chromium:1019199 Change-Id: I59b52eff3004a1fa90a0a3ffe91b111fac7fa4e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918799Reviewed-by:
-
Wei Lee authored
photo This CL is used to refine the timing of shutter sound and the shutter button animation so that it could be synced to the timing when the shutter is actually done. Bug: 1021430 Test: Open CCA and take a picture Change-Id: I6e5be0c9bc8aa6200917ab71165c0735a515527f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899243Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#715596}
-
Noel Gordon authored
arrow_{up,down}_small.svg file list sort up and down arrows 16px x 16px filled with Grey 700 #5F6368 dragger.svg: used for splitter bar, and file list column drag 32px x 32px filled with Grey 300 #DADCE0 drag_drop_{allow,deny}.svg drag drop chip allow and deny icon 20px x 20px filled with white #fff Optimized these SVG icon with SVGOMG. Bug: 1002393, 1002790, 992821 Change-Id: Ie01d8836b7f59f832f9aefcfecba8591b791207e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916537Reviewed-by:Noel Gordon <noel@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cd162a62..eae1d5ed Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3c9fa3088cced7f6aa29dd463865383a02b26987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917092Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715594}
-
Jeevan Shikaram authored
This CL replaces a non-existent function call with the function that should be called. Bug: 963326 Change-Id: I6d014b7a9eee69a73fafedf5359aa1b06270b4be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918779 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#715593}
-
Trent Apted authored
This CL reduces the size of ChromeOS resources.pak by 996kiB. One resource wasn't compressed at all, which accounts for 165kiB of the savings. Bug: 1015978 Change-Id: Iab7084e57446549187fc22a428e435e39856d267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918786Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I077255774e5546948b71d8575e5f06630eaec675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918684Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715591}
-
Jia authored
Bug: 881215 Test: unit_tests --gtest_filter=AboutFlagsTest*, AboutFlagsHistogramTest* Change-Id: I268e9495dfd6f6f0fc9817e156ca4cd2624677b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918780Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#715590}
-
Hajime Hoshi authored
TBR=kinuko@chromium.org Bug: 1025123 Change-Id: I467a196df9286b088516b43b6deb8e7d3acf433a No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918790Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#715589}
-
Christopher Cameron authored
The data gathered from Browser.Metal.TestShaderCompileTime indicates that, while shader compilation will often take a long time, it does eventually succeed. This will add the same test in the GPU process, on a thread not affected by the watchdog. If this indicates the same result (that shaders always do compile, though sometimes they hang for a long time), then this will indicate that - we should elongate the watchdog timer for shader compilation - the new limit should come from the histogram produces (if the browser is any indication, 20 seconds should be enough, with perhaps some extra time for initialization) - we should double-down on investments in taking shader compilation out of the critical path Bug: 974219 Change-Id: I9534a66821492c01fbd128417a93c46f47547d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913029Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#715588}
-
Piotr Pawliczek authored
This patch add methods to CupsPrinterHandler that allow to query a list of printers from a print server with given URL. Returned list of printers is compared with the cuurent list of saved printers. This patch adds also enum PrintServerQueryResult with error codes for ServerPrintersFetcher. BUG=chromium:1014760 TEST=on my workstation Change-Id: I14f5d2a68c5ec0621b3e1190622a2bca291d4603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912918 Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#715587}
-
Lily Chen authored
This CL contains drafts of the UI strings to be used for Legacy Cookie Access content settings in chrome://settings/content. The rest of the UI will be built later; this is just to get the strings in before string freeze for M80. Bug: 1025007 Change-Id: I9d03c2863dafab2f26796865321d83208f290ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918340Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#715586}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9413ab06f394..21d0e38fc847 git log 9413ab06f394..21d0e38fc847 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 abennetts@google.com Remove hard-coded owner from ‘File a bug’ link. 2019-11-15 ericlaw@microsoft.com [NetLogViewer] Filter should search ID 2019-11-15 fancl@chromium.org Fix autocomplete-box to respect free-form user input. Created with: gclient setdep -r src/third_party/catapult@21d0e38fc847 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:1024891,chromium:1016542 Change-Id: I0e7b2027664509277e342996e1feb7c31c28e9b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918713Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id97aa727aa833cc83a3b9fcd370d453f756a55b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917582Reviewed-by:
-
Dan Beam authored
Bug: 973674 Change-Id: I93b58a68f85b5dbbd9e62b75673b46e76f424df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912992 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
Demetrios Papadopoulos authored
This is in preparation of migrating to Polymer3. JS unit tests (V8UnitTest) have no way currently of loading JS modules within a test context, since they rely on a chrome://test data source that only exists in a browser_tests context (WebUIBrowserTest). Bug: 1022215 Change-Id: Ieb8caa155d3b83567160eb0927f43adbf548b153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918650 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#715582}
-
Junbo Ke authored
Http cache was disabled before the network service migration because there was no significant benefit. Disable now in the network service path. Bug: b/144224349 Test: TBD Change-Id: If6ce53548d13e9ba16ad92e075217f4673089e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918720Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#715581}
-
Shik Chen authored
Design doc: go/cca-devtool Bug: 1019581 Test: Manually Tricium: disable Change-Id: Ibe427a666692ae5efd4e9bc1aaddc43def2e0f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892972Reviewed-by:
Wei Lee <wtlee@chromium.org> Reviewed-by:
-
kylechar authored
Update code where NULL or 0 is assigned to a scoped_refptr to reset it. Just call reset() instead. If operator=(std::nullptr_t) is added these assignments become ambiguous. This CL was uploaded by git cl split. R=skuhne@chromium.org Bug: 1024981 Change-Id: I584886409b60f2cae2c868cf52ff72186a2af041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918324 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Stefan Kuhne <skuhne@chromium.org> Cr-Commit-Position: refs/heads/master@{#715579}
-
kylechar authored
Update code where NULL or 0 is assigned to a scoped_refptr to reset it. Just call reset() instead. If operator=(std::nullptr_t) is added these assignments become ambiguous. This CL was uploaded by git cl split. R=sky@chromium.org Bug: 1024981 Change-Id: I03070a48e4e14a588eab55165fb895599e57159d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918149 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#715578}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1a47081b61b7..588d23a98223 git log 1a47081b61b7..588d23a98223 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@588d23a98223 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Id42599793e2078935bf7293535ff7f30401ba08a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918700Reviewed-by:
-
Xiaohan Wang authored
is_decrypting_demuxer_stream -> has_decrypting_demuxer_stream since the pipeline "has" a DecryptingDemuxerStream instead of "is". Tbr: dcheng@chromium.org Change-Id: I95e812cb4e0cb408d57c849730e8fe8ffe1dfaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917620 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#715576}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/5043101ccdf5..942aa55afa1d git log 5043101ccdf5..942aa55afa1d --date=short --no-merges --format='%ad %ae %s' 2019-11-14 9856269+sarahM0@users.noreply.github.com Add spvc parser support for all OpConstant.* and OpSpecConstant.* (#886) Created with: gclient setdep -r src/third_party/shaderc/src@942aa55afa1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I7038a6c1cc1b488d9dc54528e96c86bff47da1ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918699Reviewed-by:
-
Torne (Richard Coles) authored
Add a GN argument "webview_includes_weblayer" (which defaults to true) which determines whether or not the WebLayer code will be compiled into WebView implementations (such as system_webview_apk, monochrome_public_apk, and trichrome_webview_apk). The standalone WebLayer support APK in //weblayer is not affected and can be used regardless of the value of this option. Change-Id: Iae082c24e386771e520a68e09748f0d6be1d9fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917960Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#715574}
-
Henrique Nakashima authored
The annotation doc already mentions they are supported. Verified locally that the check is triggered when an annotated field is optimized out. Change-Id: Ida56c91238afc2141c5562a49544a27afe9af452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918332 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Michael Matena authored
BUG=b:139752841 TEST=Ran on betty VM and eve-arcvm device, stopped ARC by opting out of Play store, and checked histograms on chrome. Change-Id: Ia400c6c38614e3b9bd19b1382ed26ba2bd76030e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792788 Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Shao-Chuan Lee <shaochuan@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#715572}
-
Xiaohan Wang authored
Currently we compare the whole PipelineDecoderInfo to decide where there's a change to report. But we only store the |decoder_name| for the next comparison, so info like |is_decrypting_demuxer_stream| is not updated. Then we'll keep reporting PipelineDecoderInfo even if there's no new change. This CL fixes this issue by storeing the whole PipelineDecoderInfo instead of just the |decoder_name|. Additional logging is also added for the convenience in debugging. Bug: 1018372 Test: Adds new unit test to cover this Change-Id: I6d309075b694f6a7cde6a4662c2200e2606652f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917600Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Alan Screen authored
During print preview when the PDF compositor is used, individual PDFs for each page are made for the preview. Prior art has the full document PDF used for printing being generated by sending a separate metafile blob for all the pages, which is overly large for long documents. This alters that to have the full document PDF get composited using the same individual page metafile objects as they are sent to the utility process for the composition. This effectively halves the amount of IPC traffic for Skia metafile data and eliminates potential huge metafile messages that can overwhelm IPC limits. This is only applicable for print preview scenarios that pass Skia metafile into PDF compositor. Non-modifiable content and basic printing are unaffected in behavior. This is a reland of https://crrev.com/c/1616461, which was reverted due to a problem with death tests not detected with debug version of components_unittests. TBR=dcheng@chromium.org Bug: 872935, 1024748 Change-Id: Ie22121c4bebae37882b3b2f6be808b8956c499ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917685 Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#715570}
-
Richard Li authored
Chromium has the command-line option "disable-gpu-vsync" to control presentation with vblank but it doesn't take effect when presenting video with overlays. This CL enables this feature to reduce video presenting latency. Change-Id: I1e74937d15ff8a9f0355fea57a62f3431c27b9ff Bug: 807406 Change-Id: I1e74937d15ff8a9f0355fea57a62f3431c27b9ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905266 Commit-Queue: Richard Li <richard.li@intel.com> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#715569}
-
rbpotter authored
Always add the <base href="chrome://extensions> tag, even in optimized builds, since it no longer needs to be added by the optimize_webui script. This is because Polymer 3 pages use rollup rather than Polymer bundler. Rollup does not process HTML files and therefore does not have the same issue with eating <base> tags that Polymer bundler did. The base tag is needed for URLs like chrome://extensions/a/b/ to work correctly and not cause a console error. Bug: 1004967 Change-Id: I9b8b6c20ebe8de1a6a5c92361079321b124fa6c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918644Reviewed-by:
-
