- 17 Apr, 2020 38 commits
-
-
Xianzhu Wang authored
This is just a safety measure for some theoretical corner cases that the bug may occur when the LayoutView and the document element are not in the same composited layer. However, I haven't succeeded to create such a test case yet. TBR to catch up with the next canary build, so that this CL can be merged together with crrev.com/759821. TBR=pdr@chromium.org Bug: 1070952 Change-Id: I1f8448da81aea18fc08515ec3f7b0b7d03bca197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153904Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#759909}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/800a89ae20a4..6144906469fe Created with: gclient setdep -r src-internal@6144906469fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com,nektar@google.com,guidou@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1053795,chromium:1054179 Tbr: ricea@google.com,nektar@google.com,guidou@google.com Change-Id: I6d1ec815372d159b957987b936e7944445c729e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153993Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759908}
-
Bettina authored
Bug: 1071510 Change-Id: I3eb8f81c96815469a0f50473eb12a1702e873097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153313 Auto-Submit: Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#759907}
-
Gyuyoung Kim authored
This CL migrates flex-sizing-rows-min-max-height.html from fast/css-grid-layout to external/wpt/css/css-grid/layout-algorithm with WPT styles, adding links to the relevant specs, and test description. This test is renamed to flex-sizing-rows-min-max-height-001.html to be align with existing tests. Bug: 1063749 Change-Id: Ie02efebdbbe50c3a7a6307dac3a2097a25d9ad86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152567 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#759906}
-
Karandeep Bhatia authored
IndexedRuleset.median_match_time_avg/MatchAll perftest shows a regression after r759462 due to computation of rule count in the UrlPatternIndexMatcher constructor. This CL changes UrlPatternIndexMatcher rule count to be lazily computed which should ensure that the cost of computation is only paid by clients which use the rule count. When the perf test is run locally on my machine: Without this CL: *RESULT IndexedRuleset.median_match_time: MatchAll= 231364 us With this CL: *RESULT IndexedRuleset.median_match_time: MatchAll= 80248 us Note that the test regression is exaggerated since the test creates a UrlPatternIndexMatcher for each request. BUG=1071599 Change-Id: I6364e4b9043494d18389a41c517b90756ba4c8f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153693 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#759905}
-
Khushal authored
R=vikassoni@chromium.org Bug: 1019751 Change-Id: Icdb44b7233bd0aa3bea432b68bfb50f0e033afcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149640 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#759904}
-
Brandon Jones authored
Will shortly be replaced by a more up-to-date variant of the API, but due to some conflicting interface names it's going to be cleaner to remove the current blink code (minus a couple of stubs that I know the upcoming code will need). XRCubeMap specifically will be sticking around as an internal utility, but won't be web exposed with the new API shape. Bug: 1070819 Change-Id: I40f752c8caebf6de49d1abc1d8385857389a5eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152954Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#759903}
-
Tomasz Wiszkowski authored
This change cleans up ICS specific overrides from OmniboxSuggestionsList component. Change-Id: I3a486a002290a84779fc0ef92d3761d899550bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154065Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#759902}
-
Haiyang Pan authored
This fixes sdcard mounting and avd fastboot. Emulator reads config.ini for the configuration, not hardware-qemu.ini. (The latter one is auto-generated and gets updated when applicable.) Also, change made to hardware-qemu.ini could invalidate the snapshot and leads to a cold boot, which is not desired. It is because emulator will not use the quickboot snapshot unless hardware-qemu.ini and hardware.ini from quickboot snapshot are equal Bug: 922145, 1057811 Change-Id: Ie913e907148e64fcc7ba4188529578b739fa1f3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153762Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#759901}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4b06b0b9c9b1..16abfa5e42d1 git log 4b06b0b9c9b1..16abfa5e42d1 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 bsalomon@google.com Revert "Revert "GrDisplacementEffect uses GrTextureEffect."" Created with: gclient setdep -r src/third_party/skia@16abfa5e42d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: Id8c2b6f72b382c45b01c7cea2b6ae7a90f1f1ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153987Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759900}
-
Alexander Timin authored
Use RenderFrameHost::GetMainFrame instead to always get the correct main frame — as frame might have navigated away, WebContents::GetMainFrame can return a completely different frame. BUG=1061899 Change-Id: I319602ee64482cfe0dfc002c797c6dc0e80ec003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153110Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759899}
-
Meredith Lane authored
This reverts commit bd1cac0c. Reason for revert: Flakily failing on linux-chromeos-rel. First failure: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/36764 Original change's description: > arcvm: Launch arcvm-boot-notification-server during vm start > > This change modifies ArcVmClientAdapter so that > arcvm-boot-notification-server upstart job is started during > StartMiniArc(). In UpgradeArc(), ArcVmClientAdapter sends > upgrade props to the server over the Unix socket. > > make sure AVCA is able to successfully start and connect to the > server. > > Bug: b:144542975 > Test: Build and deploy_chrome. "restart ui", then look at logs to > Change-Id: I914770d4639eefd6cf3baa444d0288f0ae8a6dbf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067613 > Commit-Queue: Willie Koomson <wvk@google.com> > Reviewed-by: Yury Khmel <khmel@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759415} TBR=yusukes@chromium.org,khmel@chromium.org,wvk@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:144542975 Change-Id: I29ac160b6aafb54d27be2e3dce34468421e41dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153174Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#759898}
-
Darwin Huang authored
Change-Id: I57fc90c6261903f3ad5afe8833c226b8bbfde3e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153945 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#759897}
-
John Z Wu authored
Token fetches by the client may fail for any number of reasons. The errors should be categorized and returned to //ios/web_view for internal handling. Bug: 780937 Change-Id: I84e15d8f43ad8ca1fca8f9be41d82fad0cae6421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153337 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#759896}
-
My Nguyen authored
AssistiveWindowControllerImpl is not called directly but called through ImeAssistiveWindowHandlerInterface so its overridden methods do not need to be public. Also remove extra comment and variable. No-Bug: Clean Up Change-Id: I51e9df427d937c12e26d0b2fed63f16619bdbfa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153176Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#759895}
-
Darwin Huang authored
https://chromium.googlesource.com/chromium/deps/sqlite.git/+log/3d3ac5e6f58a..c906d361bd62 $ git log 3d3ac5e6f..c906d361b --date=short --no-merges --format='%ad %ae %s' 2020-04-15 huangdarwin Fix a case when a pointer might be used after being freed in the ALTER TABLE code. Fix for [4722bdab08cb1]. 2020-04-14 huangdarwin In the event of a semantic error in an aggregate query, early-out the resetAccumulator() function to prevent problems due to incomplete or incorrect initialization of the AggInfo object. Fix for ticket [af4556bb5c285c08]. Created with: roll-dep src/third_party/sqlite/src Bug: 1070012 Change-Id: Ib6b8271a20064a846d6be69ba022cff57b4b5730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153576 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
-
Devlin Cronin authored
Remove the permission warning for externally connectable sites. This warning previously indicated that an extension could "Communicate with cooperating websites", and was shown when an extension specified "externally_connectable" in the manifest with any "matches" (i.e., websites). This allowed websites to message extensions via runtime.sendMessage() and runtime.connect(). This wasn't very useful. Any extension can communicate with cooperating websites without this capability, e.g. by being specified in the cooperating sites' ACAO, and just making an ordinary CORS request. This requires no permissions, because it is a normal web capability. (There are also other ways extensions can communicate, e.g. through web_accessible_resources). Remove the warning. Bug: 469602 Change-Id: I8663125f268b4e031a0a83c4dd0fd886cc2a6457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148249Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759893}
-
David Black authored
Opening of Assistant search results is delegated to the Assistant Controller as it knows how to handle Assistant deep links. Known issue: - Launcher eagerly closes when opening search results. We will need to do a follow up CL to make this behavior conditional since more often than not Assistant search results will need to open in-Launcher embedded Assistant UI. Bug: b:146673437 Change-Id: Ifc0e3bd5bde0ecb574ef9469d3e55968ad51fa7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153343 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#759892}
-
dpapad authored
Migrating everything in that folder, except search_engines_browser_proxy.html/js which is still used by CrOS Settings and therefore still has to be generated at build time. Bug: 1069258 Change-Id: Ifd48616cdc4a8d2075b115c9e47511e69945cdfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151891 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#759891}
-
Ayu Ishii authored
Bug: 1070609 Change-Id: I5953f73eae729a314fa41927df22020a3ba60236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135018Reviewed-by:
Sam Goto <goto@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#759890}
-
Sophie Chang authored
Bug: 1054519 Change-Id: If6d80ceee4d01b95a8bfca7dc7f894afee14c097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153577 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#759889}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8116c488ae96..f93cc8bda48d git log 8116c488ae96..f93cc8bda48d --date=short --first-parent --format='%ad %ae %s' 2020-04-16 timvp@google.com Vulkan: Skip failing BlendIntegerTest tests 2020-04-16 jmadill@chromium.org Vulkan: Make staged clears store aspect mask. 2020-04-16 jmadill@chromium.org Vulkan: Forward RenderBuffer/Surface dirty messages. 2020-04-16 jmadill@chromium.org Pass binding enum to Framebuffer::syncState. Created with: gclient setdep -r src/third_party/angle@f93cc8bda48d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Iaa5400fed809de24535aa1d3a5c46e599aca2ed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153877Reviewed-by:
-
Mike Wasserman authored
Bug: 994889 Change-Id: I9aa8225c2508b7390914ec220a840de329520ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152776 Auto-Submit: Michael Wasserman <msw@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#759887}
-
Reilly Grant authored
These tests use BluetoothTest to create a platform-specific fake adapter. Since FidoBleDiscovery uses BluetoothAdapterFactory to get the BluetoothAdapter SetAdapterForTesting() must be called to register this fake adapter with the factory so that the tests use the right one. Bug: 1071677 Change-Id: I3cc53f39bbd492a0901e334cea0308c65fde4b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153938Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#759886}
-
Devlin Cronin authored
Bug: 1060749 Change-Id: I3abf19298f0ec871b8e26e442569e0cfdeff4386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153928Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759885}
-
David Roger authored
In some rare cases (such as a network request hanging), the user is able to start a new signin flow while one is already in progress. This causes the policy manager to crash, as it doesn't support multiple flows. Beside this crash, this would also result in bad user experience, since both signin flow would trigger (possibly conflicting) dialogs. This CL keeps track of the current signin flow and cancels any existing flow when a new one starts. Fixed: 1061459 Change-Id: I5cda95fab6b7b5a6f75372685a0d5c9ae02a59a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115617 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759884}
-
dpapad authored
Bug: 1069258 Change-Id: If45a412efd3194aef806e2e3084cd0bc31667bb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152995 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#759883}
-
Johann authored
Change-Id: I6ac521afd6daa88556801e23ca3d7668e628f6a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152133Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#759882}
-
Joao Victor Almeida authored
There are some definitions of ClampToRange functions within Blink avoiding the usage of base::ClampToRange. But there are already dependencies from Blink to base/numerics and to other clamping functions in base so it doesn't appear to be any particular reason to exclude this from the allowed dependencies. Bug: 1071230 Change-Id: I2c99eddafe79020490d3dcf722aab5c1dce56140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153757Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: João Victor Almeida de Aguiar <joalmei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759881}
-
Johann authored
Artifacts can be removed after the clang prebuilt is updated. Change-Id: I473c22843445745a39d1fc648a7bbcc336631b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152329Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#759880}
-
Natalie Chouinard authored
This is a first step towards modularizing SettingsLauncher. See go/clank-modularize-settings-launcher for full details. Bug: 1054193 Change-Id: Ib073e60aacce51ff7948621fc35c3bf2d6d68988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149885Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#759879}
-
Bugs Nash authored
Bug: 1071320 Change-Id: Idb3a0fb5e1f6bba1a37ae22c785c1a1a56625b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151771Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#759878}
-
Meredith Lane authored
This reverts commit 0fbb4553. Reason for revert: Broke the chromeos-amd64-generic-rel build: https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-rel/41896? Original change's description: > [cros search service] Remove mojom and async API > > This cl removes all mojo and async APIs without moving files or > changing file names (which will be done in later cls). > > Bug: 1064424,1018613 > Change-Id: Ie92967aa37723e31557487aeb96bc9eed3458b39 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151376 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Commit-Queue: Jia Meng <jiameng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759848} TBR=dcheng@chromium.org,blundell@chromium.org,jiameng@chromium.org Change-Id: Ica10760e53a1a95a0e25cd4b8c6370043e0adec1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1064424, 1018613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153172Reviewed-by:
-
Sammie Quon authored
This will allow us to skip restoring external display bounds when heading to ACTIVE session, and instead restore on Display added during a lock state. Test: added test, manual Bug: 1033263 Change-Id: I4bb91fc7db6f7423ce8280465e783cfc4f468dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134570 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#759876}
-
Liquan (Max) Gu authored
Before: * The security icon on the toolbar did not have content description, i.e, when the accessibility assistant did not speak when users focused the security icon. * The mediator uses static methods from these classes that make it hard to test: - SecurityStatusIcon - SecurityStateModel - PageInfoController After: * The security icon has a content description. The description is the same as the one used on custom tab toolbar. * The static methods are invoked from the coordinator Change: * Add content description to security icon. * Move the classes with static methods out of the mediator to make it testable. Bug: 1067659 Change-Id: Icd21f0578492e9b9b595cd06909049839c6eed85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140956 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#759875}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a0145e0512c2..800a89ae20a4 Created with: gclient setdep -r src-internal@800a89ae20a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com,nektar@google.com,guidou@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ricea@google.com,nektar@google.com,guidou@google.com Change-Id: Ibb330577d38e25778f15fea64e6425045a8bdee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153865Reviewed-by:
-
Adenilson Cavalcanti authored
Document the optional compression strategies supported by zlib_bench. Bug: 798943 Change-Id: Ic4e1a89163bef087d424467710a016edf5bad242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152780Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#759873}
-
Scott Violet authored
At the time OnNavigationStarted() is called it's not safe to call Navigate(). This patch delays the navigate until it is safe (when NavigationThrottleImpl::WillStartRequest() is called). BUG=1070569 TEST=NavigationBrowserTest.NavigateFromRendererInitiatedNavigation Change-Id: Ia110bb94e64d6551c9db302ae41b735ad5a8a5e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153758Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#759872}
-
- 16 Apr, 2020 2 commits
-
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a8817db1767d..6af2de8b2aa5 git log a8817db1767d..6af2de8b2aa5 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 thestig@chromium.org Use FT_LOAD_PEDANTIC in CFX_GlyphCache::RenderGlyph(). 2020-04-16 dhoss@chromium.org Change implementation of CPDF_FormField::IsItemSelected() 2020-04-16 dhoss@chromium.org Add unit tests for CPDF_FormField::IsItemSelected() 2020-04-16 bravi@microsoft.com Added URI Action handling public API and its test cases 2020-04-16 nigi@chromium.org Fix embedder test FPDFFormFillEmbedderTest.BUG_1281 for Skia. 2020-04-16 dhoss@chromium.org Capture existing multi-select list box behavior with more tests Created with: gclient setdep -r src/third_party/pdfium@6af2de8b2aa5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1063609,chromium:994500 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I468d30ad3ca5077a15c9835f3bc5ba22487264e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153876Reviewed-by:
-
Sujie Zhu authored
Add sub-histogram Autofill.FormEvents.CreditCard.WithServerNickname to log form events when any server nickname is available and calculate the CTR and suggestion selection rate to see whether having a server nickname available make it easier for users to select the card they want and submit the form. Note that we will compare selection rate only for the same group of users who have server nicknames, which means for the Control group we will also log to CreditCard.WithServerNickname if the user has any masked server cards with a nickname, but we won’t display the nickname in the UI. For Enabled group, we will log and show nickname when nickname is available. We will compare the Experimental and Control group’s selection rate from this CreditCard.WithServerNickname. Add a boolean to credit_card_form_event_logger to represent whether user has any server nicknames, and put nickname logging in the OnLog() by which all related form events can be additionally logged to specialized sub-histograms. Metrics design (googlers only): https://docs.google.com/document/d/1SfrBduc3gJrouT4zLmQHWtUPtcE-9JbkBGLHYgFLTFc/edit?ts=5e50549a#heading=h.olagc6jelr42 Bug: 1059087 Change-Id: Ia82172c6d7673cbb5744b0d6fc43ab8968d8c036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150028 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#759870}
-
