- 08 Jan, 2021 40 commits
-
-
Arthur Sonzogni authored
This reverts commit e05911e4. Reason for revert: https://crbug.com1164259 WebViewLayoutTest#testWebViewIncludedStableInterfaces is failing because the new API doesn't set up whether it should be exposed in WebView. Interfaces which are intentionally not exposed in WebView need to be added to not-webview-exposed.txt Original change's description: > webhid: Mark the API stable > > Updates runtime_enabled_features.json5 and the stable webexposed tests > to mark the WebHID API stable on desktop platforms. > > Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/rL1csFYD1Ms > > Bug: 890096 > Change-Id: I36a6b62475dd9de01a4dbf013b2be00e8901359e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610995 > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Auto-Submit: Matt Reynolds <mattreynolds@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841185} TBR=chrishtr@chromium.org,mattreynolds@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I16463f8d4b8e9e4893217f5349d2a8a9f7aa76f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 890096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616200Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#841413}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f7ce1cd243f2..cb3bcf88e382 2021-01-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from ebb8289a to f936dc21 (446 revisions) 2021-01-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from fac169113df7 to 00fcab636a05 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I7a0f1725759bcac61e44c9d9ad291282ca9e0794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617309Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841412}
-
Nazerke authored
The crash report shows that the crash of |addConstraintsToTabStrip| is on the iphones only. This CL removes the adding the constraints to the tabstrip from the viewDidLoad, as currently it's crashing on it while it's trying to add the constraints to the tabstripview which is nil on the iphones. Now it is moved to the point when the tabstripview is added, which does not let it run on the iphones as it's not needed and causes crashes. Bug: 1152059, 1128249 Change-Id: Ic161b0d687b828ec57889c455d171c4f6a5fcf42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611977Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#841411}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/48240126b9fe..589e3dd96b0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC qjw@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: qjw@google.com Change-Id: Id21e75bdc6dd85b316c84554c85e272b37776c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617311Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841410}
-
Kuo Jen Wei authored
Bug: b/176266123 Test: Manually toggle different grid line type from toggle button and grid settings. Change-Id: I59dfb3b46415ad0b1a6206ecf4a31344479f0ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611152 Commit-Queue: Inker Kuo <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#841409}
-
Mirko Bonadei authored
This reverts commit 5903b6b1. Reason for revert: This should land after M89 is branched. Original change's description: > Roll src/third_party/usrsctp/usrsctplib/ 995c0b844..4191ca178 (72 commits) > > https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/995c0b844144..4191ca1784d8 > > $ git log 995c0b844..4191ca178 --date=short --no-merges --format='%ad %ae %s' > 2021-01-04 vitaly Fixed installation on other than Ubuntu GNU/Linux distributions. (#541) > 2021-01-01 tuexen Improve handling of aborted associations > 2020-12-31 yuquanw2 Add SACK into fuzzer_fragment (#516) > 2020-12-31 61293369+ihsinme Update client_upcall.c (#559) > 2020-12-30 deadbeef Add optional SCTP_USE_OPENSSL_RAND define to use openssll's RNG. (#558) > 2020-12-30 deadbeef Lowercase reference to iphlpapi.lib (#560) > 2020-12-23 tuexen Improve input validation for parameters in ASCONF and ASCONF-ACK chunks > 2020-12-20 deadbeef Fall back to using urandom on Linux if getrandom isn't available. (#557) > 2020-12-14 tuexen Harden the handling of outgoing streams in case of an restart or INIT collision. This avouds an out-of-bounce access in case the peer can break the cookie signature. Thanks to Felix Wilhelm from Google for reporting the issue. > 2020-12-12 tuexen Clean up more resouces of an existing SCTP association in case of a restart. > 2020-11-19 weinrank Sync master with fuzzing branch (#551) > 2020-11-18 CoolmanCZ MinGW release build - initialize variables (#548) > 2020-11-18 deadbeef Call __msan_unpoison after syscall(__NR_getrandom, ...). (#550) > 2020-11-18 deadbeef Support building with emscripten. (#549) > 2020-11-18 sironhide0null Fix a typo in user_mbuf.c (#552) > 2020-11-09 tuexen Fix a potential use-after-free bug introduced in https://github.com/sctplab/usrsctp/commit/b10a5d3b26e94320232dbdf269873497f8f7cff1. > 2020-11-04 weinrank Fix #545 - remove .lib extension (#546) > 2020-11-02 weinrank Use CMAKE's BUILD_SHARED_LIBS flag to build shared library (#543) > 2020-10-22 tuexen Use the SCTP_REUSE_PORT socket option. > 2020-10-17 tuexen Improve the handling of cookie life times. The staleness reported in an error cause is in us, not ms. Enforce limits on the life time via sysct; and socket options consistently. Update the description of the sysctl variable to use the right unit. Also do some minor cleanups. This also fixes an interger overflow issue if the peer can modify the cookie. This was reported by Felix Weinrank by fuzz testing the userland stack and in https://oss-fuzz.com/testcase-detail/4800394024452096 > 2020-10-13 tuexen Improve compilation on Windows. > 2020-10-07 tuexen Whitespace changes > 2020-10-06 tuexen Reset delayed SACK state when restarting an SCTP association > 2020-10-06 tuexen Cleanup. > 2020-10-06 tuexen Accept any cookie if FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION is defined. > 2020-10-06 tuexen Provide RNG for __native_client__ as suggested by Taylor Brandstetter. Fail compilation on all platforms we don't have a specific RNG for. > 2020-10-06 tuexen terminate_non_graceful() never returns... > 2020-10-06 tuexen Initialize variables before using > 2020-10-06 tuexen Remove dead stores reported by clang > 2020-10-06 tuexen Cleanup > 2020-10-06 tuexen Whitespace changes > 2020-10-04 tuexen Use __func__ instead of __FUNCTION__ > 2020-10-04 tuexen Cleanup. No functional change intended > 2020-10-02 tuexen Minor cleanup. > 2020-10-01 deadbeef Call getrandom via syscall directly on Linux. (#533) > 2020-10-01 tuexen I guess Bitrig support arc4random(). > 2020-10-01 tuexen Whitespace change. > 2020-10-01 tuexen Don't start SCTP/UDP receive threads (and don't open corresponding UDP sockets) when the UDP port specified in scpt_init() is 0. > 2020-09-30 deadbeef Add missing return type to init_random. (#531) > 2020-09-30 tuexen Try to fix the Windows build. > 2020-09-30 tuexen Add Android specific code for the random number generator. > 2020-09-30 tuexen Add platform specifc includes to the corresponding code. > 2020-09-30 tuexen Add a cleanup routine for the random number generator. > 2020-09-29 tuexen Improve the input validation and processing of cookies. > 2020-09-28 tuexen Whitespace cleanup > 2020-09-28 tuexen Improve random number generation on __Fuchsia__. > 2020-09-27 tuexen Improve the handling of fragmented, unordered, and unreliable user data using DATA chunks in the receive path. > 2020-09-26 tuexen Fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=25984 > 2020-09-24 tuexen Whitespace changes > 2020-09-22 deadbeef Avoid duplicate definition of _CRT_RAND_S. (#529) > 2020-09-22 deadbeef Fix gcc/clang type mismatch warnings on Windows (#527) > 2020-09-22 deadbeef Fix -Wunreachable-code in programs/ (#528) > 2020-09-19 tuexen Improve consistency. > 2020-09-19 tuexen Cleanup. > 2020-09-19 tuexen Improve Windows build. > 2020-09-19 tuexen Fix syntax error on windows. > 2020-09-19 tuexen Add include for getrandom() on Linux. > 2020-09-19 tuexen Fix type of init_random() on Linux and Windows. > 2020-09-19 tuexen Improve Windows build. > 2020-09-19 tuexen Improve consistency. > 2020-09-19 tuexen Improve random number generation on Linux and Windows. > 2020-09-19 tuexen Cleanup read_random(). No functional change. > 2020-09-19 tuexen Fix NetBSD related #ifdef. > 2020-09-19 tuexen Whitespace changes > 2020-09-18 tuexen Add license. > 2020-09-18 tuexen Add license statement. > 2020-09-18 tuexen Fox more typos. > 2020-09-18 tuexen Fix typo. > 2020-09-18 tuexen Remove trailing whitspaces. > 2020-09-18 tuexen Improve consistency, no functional change intended. > 2020-09-18 tuexen Check for too short packets when using the receive threads. > 2020-09-18 tuexen Fix mask for ECN bits. > > Created with: > roll-dep src/third_party/usrsctp/usrsctplib > > Bug: chromium:1163228 > Change-Id: I9b0b5f8c98bf3f7c9f51ae6fae24dd0e9b6e3117 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612384 > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841036} TBR=hta@chromium.org,deadbeef@chromium.org,mbonadei@chromium.org,orphis@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ifd8bf7e7fb5a50cdc4fb4b128895bc34425f127a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1163228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617778Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#841408}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/87d362bb2c4d..80399af7a213 2021-01-08 bmeurer@chromium.org [e2e] Rebaseline sources tests after Chromium roll. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1159309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I48c1b497ee8365c5d1b8c2e6ea58180b3d58f251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616755Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841407}
-
Victor Vasiliev authored
https://quiche.googlesource.com/quiche.git/+log/63bdfe586f8c..425c25a8ad2d $ git log 63bdfe586..425c25a8a --date=short --no-merges --format='%ad %ae %s' 2021-01-07 bnc Add SETTINGS_DEPRECATE_HTTP2_PRIORITIES. 2021-01-07 haoyuewang Add supports to write NewConnectionId/RetireConnectionId via QuicControlFrameManager. 2021-01-07 wub Refactor TlsServerHandshaker to use ProofSourceHandle for cert selection and signature. 2021-01-06 wub In QUIC BBRv2, reset max_bytes_delivered_in_round when a new round starts. 2021-01-06 haoyuewang Add new & retire ConnectionId interface to QuicSession::visitor and implement them in (Gfe)QuicDispatcher. 2021-01-05 haoyuewang Add multiple CID per connection support to time_wait_list. 2021-01-05 quiche-dev Rename gfe2_restart_flag_always_promote_chunk_if_coalesced_2 and remove "enabling_blocked_by". 2020-12-30 vasilvv Fix include paths for quiche/common/platform/impl. 2020-12-30 fayang Fix QUIC_BUG in FlushAckFrame to check whether frames is empty. 2020-12-30 danzh Make QuicConnection count bytes sent/received in probing packets on alternative paths. Created with: roll-dep src/net/third_party/quiche/src Change-Id: I492a96c7f055561f465fe0e7ea5b9907906548d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617418Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#841406}
-
Matt Falkenhagen authored
In the multi-WebContents implementation, history must be copied from the old WebContents's NavigationController. Also adjust a unittest to more fully simulate navigation, as it's necessary to commit the navigation in order to copy the history. Bug: 1132746 Change-Id: I0e2061451779d1fa9e4db2957aa06d0a05bef436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612291Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#841405}
-
Matt Giuca authored
This change removes the status bar in installed WebApp windows (the small text box that appears in the lower left hand corner of the window). Bug: 1151487 Change-Id: Ic1088730b7d6cdd622aedcefd1902e21741d7821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617479 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Auto-Submit: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#841404}
-
Yoshisato Yanagisawa authored
Now Goma client is not guaranteed to run on Windows 7. It has no meaning to keep the builders. Bug: b/139556893 Change-Id: I8cda7f1b00a0e356f0ad9ba3c002280ab514d727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617215 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#841403}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4d379d2f..ff24c712 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iab1cb0cb4fe365e6a0d0f7062369bee5f06ec0a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617211Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841402}
-
Archie Pusaka authored
This adds the following histrograms: * BlueZ.AdvertisementMonitor.NumOfMonitors * BlueZ.AdvertisementMonitor.<SW|MSFT>.FilterPatternsPerMinute * BlueZ.AdvertisementMonitor.<SW|MSFT>.<Add|Remove>.Result Corresponding BlueZ metrics implementation can be found at: go/croscl/2565089 Bug: b/169584341 Test: Verify BlueZ.AdvertisementMonitor* on chrome://histograms Change-Id: Ibab7145580b3ddd3369ee83940090ae0f8052dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596585Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Archie Pusaka <apusaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#841401}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cdb3bc3b93da..4681cecb4151 2021-01-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision aff08690..82fccc55 (841210:841356) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I87582f19171db11bd20e19b9b62af9af2c3af3cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617646Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841400}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610063718-47f197c900d6e73c3c9b6aad05d4a947c6371a56.profdata to chrome-win32-master-1610074312-912225aaa44122e4b1a4b8a45da36dc4daa402b9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibf5ae1a87fb8f495943820d329c48a527ef2cb90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617638Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841399}
-
Fergal Daly authored
This was happening in https://crbug.com/1146573 and could happen if a WebContentsObserver triggers synchronous navigation in response to a the RenderFrameDeleted call. This adds a RenderFrameState::kDeleting that is only used during RenderFrameDeleted. Bug: 1146573,1163815 Change-Id: I6f3ff264d5788135a79d90a1dba0e7e6a16adad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599568 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#841398}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610063718-6db51055255b71b3272f9db93116d992601c9633.profdata to chrome-win64-master-1610074312-1e61cca385dcdccbd239aae3d699d6888b006a9e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia255d529decf71b09d9f5351324c12c7abf0f0b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617640Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841397}
-
Jan Krcal authored
This CL changes ProfilePickerView to use it's custom widget class instead of the default one provided by DialogDelegate. This allows to define a theme provider for the widget, based on a profile that (sometimes) gets created throughout profile creation flow. This is a preparatory CL for later CLs (such as CL 2569752) that will add native views into the hierarchy that actually rely on the theme provider. Bug: 1126913 Change-Id: Ifed3f645a4c60035ced4b7562ab21f5d4d5b840a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608206Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#841396}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4367.0-1609757097-benchmark-89.0.4380.0-r1 to 89-4367.0-1609757097-benchmark-89.0.4381.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If7e0d5a8cab2d2a524d5eab76dcd5101818eb300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616753Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841395}
-
Eric Willigers authored
Avoids Step "compile confirm no-op" failing on builder "win32-archive-rel" from https://chromium-review.googlesource.com/c/chromium/src/+/2615664 Bug: 1144920,1164175 Change-Id: Ib8c8d3ac5869547d82cfd89740b1f057affccb09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615729Reviewed-by:
Jiewei Qian <qjw@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#841394}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d39c0ebe595d..48240126b9fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC qjw@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: qjw@google.com Change-Id: Ib03e71c29c46e2af76dde77bbb5cd8fe043eb2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616857Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841393}
-
Aleks Totic authored
Autosizer was being called twice, which made some tests fail. 1st call was inside ComputeTableInlineSize, 2nd call was in Layout. Removed call in Layout, and now all autosizing tests look good. I do not understand autosizing code very well. My guess is that running autosizer twice in the same layout leads to bad things, because it tries to size already sized layout object, and ends up with a wrong multiplier. Without this, fast/text-autosizing/tables/table-cell-inflation.html fails. Change-Id: I5deba326d6f3b1b178f994a7bb03bef67ccc2cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616750Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841392}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4367.0-1609764762-benchmark-89.0.4380.0-r1 to 89-4367.0-1609764762-benchmark-89.0.4381.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie8594068b7d7d13277f094559c76a6a7ebd33f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617645Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841391}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I9a91aed82e95ca5bfdbc6cc93bc8fe70aaf2fe29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616855Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841390}
-
Hayato Ito authored
Enable CORB protection for subresource loading in WebBundle. WebBundle design doc is here. https://docs.google.com/document/d/1_AqUBS4Gr45MPPtXGTUl7Q0DMIEw2zUeWO0zo6Sj0z4/edit#heading=h.pi5jgk8nqwh4 This implementation uses CrossOriginReadBlocking::ResponseAnalyzer to decide whether to block resources or not, as network::URLLoader does. Bug: 1082020,1149258 Change-Id: I6aa53db5fc0839e8a74bf834da2d26a017d2e240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585250Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#841389}
-
Jan Krcal authored
This CL creates a new variant for the chrome://sync-confirmation page that fits to the design of the new profile creation flow. This will eventually become the default design. Screenshot: https://screenshot.googleplex.com/9KbMGdLDnF8N3P8 Bug: 1126913 Change-Id: Idecc93d92985fd5c2275fcbeecb2792eea322e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583902Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#841388}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f4ea30580c91..f7ce1cd243f2 2021-01-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 7b2f93895418 to 937395c1ed5d (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: Icee62362da54a6d6ff044985606fe11e20a7b38d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616854Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841387}
-
Bao-Duy Tran authored
This first batch of metrics are similar to existing metrics for PK Assistive Autocorrect but adapted to scope to CrOS 1P experimental multilingual input methods. Other metrics to be added in follow-ups. Bug: 1159297 Change-Id: I4684d7b8bdbae570e428e08b79de4eb642a3945e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596484Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
John Palmer <jopalmer@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#841386}
-
Joel Hockey authored
Python3 does automatic utf-8 decode/encode when reading/writing files and it throws an exception when reading binary files in normal 'r' mode. When we detect such an error, we will read and write the file as binary 'rb' / 'wb' without doing any text substitutions. The script is tested locally and works for python2 and python3 Bug: 1163386 Change-Id: I46f53dcafbdb43a367e5418bab84cf7a0ebd84a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617408 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#841385}
-
Daniel Cheng authored
The intent appears to be to execute script in an isolated world in the child frame's context. However, the iframe completion callback's global scope is the main frame's global, not the child frame's global. The test worked anyway, because window.parent simply points to window in the main frame. Change-Id: I24915e06ef1dd67cbf4a2de33018da979f39fb57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617135Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#841384}
-
Alan Cutter authored
This is a reland of 7aca7756 The original was reverted due to test flakiness. We weren't waiting for the Extensions toolbar to appear after test Extension installation before testing its visibility. Diff of additions to the original: https://chromium-review.googlesource.com/c/chromium/src/+/2602305/1..2 Original change's description: > desktop-pwas: Add "Extensions" menu item to web app windows > > This CL: > - Hides the Extensions icon in web app windows unless the Extensions > menu is opened. > - Adds an "Extensions" menu item to the web app three dot menu to > open the Extensions menu. > > This change is behind the DesktopPWAsElideExtensionsMenu flag. > > Minor change in behaviour to browser window extension menu > (regardless of flag state): When the last extension is removed the > container will wait for its layout animation to complete before hiding > itself. > > Before: > https://bugs.chromium.org/p/chromium/issues/attachment?aid=480233&signed_aid=3saz6ZsTFVwVy1W5EoAbXQ==&inline=1 > > After: > https://bugs.chromium.org/p/chromium/issues/attachment?aid=481189&signed_aid=tZhlRb6XLB8XimALjMCn6g==&inline=1 > > Bug: 1155421 > Change-Id: I80d5b382610895021c2cdf861d253edbdabe8630 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573897 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Dana Fried <dfried@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838031} Bug: 1155421 Change-Id: I4c0c3f90c78c0dd4e1f582a4f36a462bbb6f05fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602305 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#841383}
-
Angela Gyi authored
This CL adds a single file title preview for share sheet feature on Chrome OS devices. Note: This feature is not in its final form and is still open to extension Bug: 1157628 Change-Id: I44acc5a0c3fc231e66f1a77b77542d39931bb772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584632 Commit-Queue: Angela Gyi <angelagyi@google.com> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#841382}
-
Sergei Glazunov authored
If the MiraclePtr PA extras are enabled, Alloc() returns a pointer past the end of a slot for zero-sized allocations, which leads to problems when a function needs to determine the slot from a given pointer. Adjust the requested allocation size to avoid that. Bug: 1162769 Change-Id: I7c398a99a257f443ef704b87ac188acef0bcc5a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613974 Auto-Submit: Sergei Glazunov <glazunov@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#841381}
-
Daniel Cheng authored
This is a reland of d24a515a, which triggered false positives in the Blink leak detector. Now that isolated worlds are correctly reinitialized after a navigation, they remains live as long as the associated browsing context is live, persisting across navigations. At the end of the test, the leak detector navigates to an empty page and performs a comparison of live objects against the captured baseline, causing leak detection to incorrectly report the isolated world contexts as leaked. To address this, the web test harness now also disposes any isolated worlds created for a test when resetting the state at the end. Original change's description: > Reinitialize isolated world window proxies on navigation if needed. > > When a window proxy is initialized for a child frame, it must be > reinitialized on every subsequent navigation to correctly hook up the > window proxy (which may have cached JS references). > > Previously, this was only happening for the main world window proxy. One > visible side effect is that if an extension cached a window proxy > reference to a frame that was then navigated, the cached reference would > not work until something else forced the window proxy to be > reinitialized. > > Fixing this has an unintended side effect in an inspector protocol test > which logs context creation: since isolated world window proxies are > reinitialized in an arbitrary order (specifically, HashMap iteration > order), the expected results become arbitrary as well. Instead of hoping > that iteration order remains consistent, update the test to only log the > context creation events it actually cares about. > > Change-Id: I11d7e13f7c2810d1c662ccf40f37c880e5026db5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607680 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840983} Change-Id: I77c62a790566815a6e5287bdb465b374c0210bee Bug: 1163893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616238Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#841380}
-
Hirokazu Honda authored
This CL enables AV1Decoder feature during VaapiUnittest so that it can confirm av1 decode capability. Bug: b:175895251 Test: vaapi_unittest on volteer Change-Id: Id2aa79a1e02c19c337e946306c984f6018d159e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612549 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#841379}
-
Leonid Baraz authored
Signature is now mandatory in client when encryption is enabled. Bug: b:170054326 Change-Id: I1b884b5b39d326446c24794c10cab1ced443312d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615662 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#841378}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b43fbe8a06ea..87d362bb2c4d 2021-01-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia6ebbaeb1a2b6897fecff15d2994e689ad6a4a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616851Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841377}
-
Chris Cunningham authored
API and motivations described here: https://github.com/WICG/web-codecs/issues/98 Spec PR here: https://github.com/WICG/web-codecs/pull/120 Bug: 1141707 Test: new layout tests Change-Id: I3e53da5961119b4b36ec76666ad1a67cca19b963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612684 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#841376}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610052964-a33bb7f09ef1aa4be028cda8573fe902d004ec4a.profdata to chrome-win64-master-1610063718-6db51055255b71b3272f9db93116d992601c9633.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7524bcb489a28cfe1ccaa73831cba89c21f75af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616967Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841375}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8e33046d8bd5..d39c0ebe595d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC qjw@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: qjw@google.com Change-Id: Iea0f21cf0c2a83655158fc2d9c4bb1a92ca7b542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617300Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841374}
-