GitLab

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5f95dbe..d79096c

TBR=caseq@chromium.org,pdr@chromium.org,wjmaclean@chromium.org

Review URL: https://codereview.chromium.org/583493003

Cr-Commit-Position: refs/heads/master@{#295863}

Previously LibjingleTransportFactory was creating and returning
transport before the transport is connected. This means that that the
PseudoTCP was trying to start handshake on a broken transport. That was
delaying PseudoTCP/SSL when the transport takes some time to setup
(e.g. over STUN/Relay). Now LibjingleTransportFactory returns the
transport only after it becomes writable. Empirical testing shows that
this change makes connection initiation much faster in cases when NAT
traversal is required (4 vs 10 seconds).

Review URL: https://codereview.chromium.org/587943002

Cr-Commit-Position: refs/heads/master@{#295862}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d49226c..13645ea

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/585173003

Cr-Commit-Position: refs/heads/master@{#295861}

prevent PictureLayerImpl from creating tiles if the entire
layer is solid.

If the entire layer is solid, PictureLayerImpl will now draw
solid quads using a method provided in SolidColorLayerImpl.

The is_solid_color_ and solid_color members have been moved
from PicturePile To BasePicturePile so that the properties
are copied between PicturePile and PicturePileImpl.

BUG=396908

Review URL: https://codereview.chromium.org/519583003

Cr-Commit-Position: refs/heads/master@{#295860}

This is for http://src.chromium.org/viewvc/blink?view=revision&revision=182213

BUG=123896

Review URL: https://codereview.chromium.org/580383002

Cr-Commit-Position: refs/heads/master@{#295859}

CursorShapeStub is being called in perf tests and the test was
returning NULL for the cursor stub which causes it to crash.

Review URL: https://codereview.chromium.org/586943002

Cr-Commit-Position: refs/heads/master@{#295858}

FrameSender now decides whether to drop frames based on the media
duration in-flight (instead of the number of frames in-flight).  The
maximum allowed in-flight duration is the target playout delay plus the
one-way network trip time, the latter of which accounts for the time it
takes for an ACK to travel back from the receiver.

ShouldDropNextFrame() still limits by the number of frames in-flight,
but only so that a client cannot flood the FrameSender with frames at a
rate greater than the configured maximum frame rate.  Some burstiness is
allowed to mitigate false-positive detections.  In a typical session,
frames should never be dropped based upon the in-flight count.

This change also alters the design of PacketStorage where, instead of
being a fixed "large enough for anything" size, it only holds the frames
that are in-flight.  This is needed because we no longer limit by the
number of frames in-flight, and there's no way to determine what the
"large enough for anything" size has to be.  It's now the duty of
FrameSender to "cancel out" acknowledged frames, and of RtpSender to
release them from storage.

BUG=404813

Review URL: https://codereview.chromium.org/560223002

Cr-Commit-Position: refs/heads/master@{#295857}

Cr-Commit-Position: refs/heads/master@{#295856}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Mac build.

BUG=110610

Review URL: https://codereview.chromium.org/584883003

Cr-Commit-Position: refs/heads/master@{#295855}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Mac build.

BUG=110610

Review URL: https://codereview.chromium.org/591493002

Cr-Commit-Position: refs/heads/master@{#295854}

BUG=None
TEST=ninja -C out/Debug gn_unittests
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/583453003

Cr-Commit-Position: refs/heads/master@{#295853}

BUG=397754
R=mattm@chromium.org

Review URL: https://codereview.chromium.org/578103002

Cr-Commit-Position: refs/heads/master@{#295852}

This CL lays the ground work for implementing in process native messaging.

It extracts a common interface |NativeMessagingChannel| outs of
native_messaging_channel.h and renames the existing implementation
to pipe_messaging_channel.

This CL is best reviewed by diffing against patch set 1.

Review URL: https://codereview.chromium.org/558403002

Cr-Commit-Position: refs/heads/master@{#295851}

BUG=388885

Review URL: https://codereview.chromium.org/590593002

Cr-Commit-Position: refs/heads/master@{#295850}

When the InfoBarContainer is first attached to the window,
View.initialAwakenScrollBars() is called on it. Even though the scrollbars
aren't visible, this schedules a delayed runnable to fade out the scrollbars
1.2 seconds later. This delayed runnable (View$ScrollabilityCache) then calls
View.invalidate() repeatedly as it fades out the (already invisible) scrollbar,
which pauses scroll updates and touch event handling for 10 to 15 frames.

This CL disables the scrollbars on the InfoBarContainer, except in the rare
case that the container is actually scrollable (i.e. when infobars take up the
entire screen). In that case, page jank doesn't matter since the user can't
even see the webpage!

BUG=407149
NOTRY=true

Review URL: https://codereview.chromium.org/588843002

Cr-Commit-Position: refs/heads/master@{#295849}

All DataReductionProxy.BypassedBytes.* UMA that don't have an explicit triggering
request UMA need to count the triggering request bytes.

BUG=413771

Review URL: https://codereview.chromium.org/566943004

Cr-Commit-Position: refs/heads/master@{#295848}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Mac build.

BUG=110610

Review URL: https://codereview.chromium.org/590493002

Cr-Commit-Position: refs/heads/master@{#295847}

SubstitutionPatterm -> SubstitutionPattern
SubstutitionWriter -> SubstitutionWriter

BUG=None
TEST=ninja -C out/Debug gn_unittests - compare the output before and
after this change.
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/590683002

Cr-Commit-Position: refs/heads/master@{#295846}

BUG=415792
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/586133002

Cr-Commit-Position: refs/heads/master@{#295845}

This used to return RWX, but regressed as of
314a240e.

BUG=none
R=sbc@chromium.org
R=bradnelson@chromium.org

Review URL: https://codereview.chromium.org/587933003

Cr-Commit-Position: refs/heads/master@{#295844}

BUG=386033,365418

Review URL: https://codereview.chromium.org/589523003

Cr-Commit-Position: refs/heads/master@{#295843}

It was being done as a one-off in app_shell and replicated in Chrome.
Moved it to RegisterCommonManifestHandlers() where it belongs.

BUG=none
TEST=extensions_unittests, unit_tests

Review URL: https://codereview.chromium.org/586873003

Cr-Commit-Position: refs/heads/master@{#295842}

This mostly just adds the missing dependency identified by the checker.

In some cases I looked at the target and added public_deps that I thought were appropriate given the nature of the target.

This renames the generated mojo action names to be foo__generator instead of foo_generator since it is not clear from the current name that it is an internally-generated target and I kept trying to use it. The double-underscore matches the Android generated targets.

In a few cases I changed ordering (sources come before deps in GN style) but I didn't want to make the changes difficult to diff so didn't do it for most cases.

Reland of https://codereview.chromium.org/581273003/
TBR=darin

Review URL: https://codereview.chromium.org/591763002

Cr-Commit-Position: refs/heads/master@{#295841}

BUG=415697

Review URL: https://codereview.chromium.org/589693002

Cr-Commit-Position: refs/heads/master@{#295840}

If an extension is detected to be corrupt, introduce an
option to repair it, if it is from the webstore.

Also reposition the "Reload" link (for reload terminated
extensions) to be next to the trash can, rather than above
it.

Screenshots: http://imgur.com/35tL9Xz,CslEoW5

BUG=410896

Review URL: https://codereview.chromium.org/557953005

Cr-Commit-Position: refs/heads/master@{#295839}

Writable operations are completed and pretty stable, so it's time to let
developers know about them and start using them!

TEST=Confirmed on a testing doc server.
BUG=248427

Review URL: https://codereview.chromium.org/583893002

Cr-Commit-Position: refs/heads/master@{#295838}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Mac build.

BUG=110610

Review URL: https://codereview.chromium.org/584103002

Cr-Commit-Position: refs/heads/master@{#295837}

For these functions the default no-op behavior is fine, so remove the calls
to NOTIMPLEMENTED to reduce log spam.

BUG=none
TEST=none
TBR=yoz@chromium.org for changing a comment in extensions/

Review URL: https://codereview.chromium.org/587913002

Cr-Commit-Position: refs/heads/master@{#295836}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/45725db..d49226c

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/583413002

Cr-Commit-Position: refs/heads/master@{#295835}

R=michaelpg@chromium.org
BUG=416133

Review URL: https://codereview.chromium.org/583193007

Cr-Commit-Position: refs/heads/master@{#295834}

BUG=415683

Review URL: https://codereview.chromium.org/582833003

Cr-Commit-Position: refs/heads/master@{#295833}

BUG=415852

Review URL: https://codereview.chromium.org/586063003

Cr-Commit-Position: refs/heads/master@{#295832}

BUG=388885

Review URL: https://codereview.chromium.org/586903003

Cr-Commit-Position: refs/heads/master@{#295831}

Two lists ftw!

R=maruel@chromium.org
BUG=416120

Review URL: https://codereview.chromium.org/589703002

Cr-Commit-Position: refs/heads/master@{#295830}

BUG=352293

Review URL: https://codereview.chromium.org/583233003

Cr-Commit-Position: refs/heads/master@{#295829}

Review URL: https://codereview.chromium.org/572603005

Cr-Commit-Position: refs/heads/master@{#295828}

BUG=

Review URL: https://codereview.chromium.org/584543003

Cr-Commit-Position: refs/heads/master@{#295827}

When --allow-sandbox-debugging is used, we set-up a new signal
handler in the Zygote (inherited by all renderers) that performs a
chroot().

This allows testing of sandbox violation crash report with official
binaries shipping to users.

BUG=415842
R=mdempsky@chromium.org

Review URL: https://codereview.chromium.org/585123003

Cr-Commit-Position: refs/heads/master@{#295826}

For clients that are part of the finch trial, change the proxy bypass
logic to not trigger a proxy bypass when a response with a non-4xx
response code is expected to have the data reduction proxy header, but
the data reduction proxy via header is missing.

BUG=413035

Review URL: https://codereview.chromium.org/583363002

Cr-Commit-Position: refs/heads/master@{#295825}

is not handled. Added a histogram to track how often this happens.

R=rch@chromium.org,rjshade@chromium.org,  asvitkine@chromium.org

Review URL: https://codereview.chromium.org/583063002

Cr-Commit-Position: refs/heads/master@{#295824}