- 09 Jan, 2013 40 commits
-
-
wxjg68@motorola.com authored
DEPS rules to make visitedlink independent of chrome/browser except chrome/browser/[api, common] BUG=none Review URL: https://chromiumcodereview.appspot.com/11746027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175883 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
Touch-events targetted to the root-window can be handled. This can happen when, for example, an event handler is installed on the Env, or the RootWindow, which takes some action based on the touch event. BUG=chrome-os-partner:17053 Review URL: https://codereview.chromium.org/11833007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175882 0039d316-1c4b-4281-b951-d872f2087c98
-
pshenoy@chromium.org authored
NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11824012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175881 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175880 0039d316-1c4b-4281-b951-d872f2087c98
-
chrisgao@chromium.org authored
The python unittest failed to run setUpClass/tearDownClass because of python version is 2.6 in pyauto bots. This CL makes a workaround to fix this issue. NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11830030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175879 0039d316-1c4b-4281-b951-d872f2087c98
-
dglazkov@chromium.org authored
TBR=noel TEST= BUG= Review URL: https://chromiumcodereview.appspot.com/11820028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175878 0039d316-1c4b-4281-b951-d872f2087c98
-
reveman@chromium.org authored
This moves thread pool related code out of the tile manager and into a new RasterWorkerPool class. This doesn't change the behavior of the tile manager in any way it just separates tile management logic from the thread handling logic, which results in a significant cleanup of the tile manager. BUG=155209 TEST=manual Review URL: https://chromiumcodereview.appspot.com/11593030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175877 0039d316-1c4b-4281-b951-d872f2087c98
-
dewittj@chromium.org authored
In order to facilitate the move to MessageCenterNotificationManager, we need to be able to determine when message_center.gyp is being included in the build. This change defines ENABLE_MESSAGE_CENTER which can be used for conditional compilation. r=stevenjb@chromium.org TBR=ben@chromium.org BUG=168605 Review URL: https://chromiumcodereview.appspot.com/11791004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175876 0039d316-1c4b-4281-b951-d872f2087c98
-
pilgrim@chromium.org authored
Fix the last of the #includes and OVERRIDEs in preparation for removing WebKitPlatformSupport upstream. Review URL: https://chromiumcodereview.appspot.com/11821025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175875 0039d316-1c4b-4281-b951-d872f2087c98
-
albertb@chromium.org authored
BUG=168648 Review URL: https://chromiumcodereview.appspot.com/11734009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175874 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
callbacks for methods without any parameters, and it wasn't showing properties for objects within arrays. Review URL: https://codereview.chromium.org/11823033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175873 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
The existing code: choose the newer items, the new code: choose the older items I wrote this existing code, but I was wrong. BUG=165768 TEST=message_center_unittests passed Review URL: https://chromiumcodereview.appspot.com/11827010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175872 0039d316-1c4b-4281-b951-d872f2087c98
-
acolwell@chromium.org authored
This change appears to be breaking the ChromeOS(x86) and ChromeOS(amd64) bots. http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/11010 > Clean up: remove unnecessary if-branches on initialization of the a11y prefs. > > According to the comment at preferences.cc:96, some accessibility prefs may be already registered in WizardController::RegisterPrefs. But the magnifier prefs are never registered there, hence we can remove if statements. > > BUG=none > TEST=launch ChromeOS, and login. > > Review URL: https://chromiumcodereview.appspot.com/11820018 TBR=yoshiki@chromium.org Review URL: https://codereview.chromium.org/11817029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175871 0039d316-1c4b-4281-b951-d872f2087c98
-
ncbray@chromium.org authored
There is no known issues with UMA poisoning, but a command line flag has been added to make sure. BUG= none Review URL: https://chromiumcodereview.appspot.com/11828009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175870 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175869 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
TBR=dimich@chromium.org,jsbell@chromium.org BUG=108628,162829 TEST=none NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11828025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175868 0039d316-1c4b-4281-b951-d872f2087c98
-
scr@chromium.org authored
BUG=169021 R=nirnimesh@chromium.org,marja@chromium.org CC=dennisjeffrey@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11826027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175867 0039d316-1c4b-4281-b951-d872f2087c98
-
aboxhall@chromium.org authored
This change adds an accessibility audit which runs just before tearDown() on any WebUI browser test that uses the chrome/test/data/webui/test_api.js framework. As of this change, the test will run by default for each test case, but not cause any errors in the case of accessibility issues. As we fix accessibility issues, we can set the a11yIssuesAreErrors flag on a per-test and per-fixture basis, to catch regressions. Once the majority of WebUI pages are passing the accessibility audit, and we have a mechanism in place for ignoring false positives, we will transition to treating accessibility issues as errors by default. http://www.chromium.org/developers/accessibility/webui-accessibility-audit has more information. BUG=162740 Review URL: https://chromiumcodereview.appspot.com/11363170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175866 0039d316-1c4b-4281-b951-d872f2087c98
-
alexeypa@chromium.org authored
The official build was broken by r175584: > host\desktop_process_main.cc(114): error C2039: 'InitializeCrashReporting' : is not a member of 'remoting' > host\desktop_process_main.cc(114): error C3861: 'InitializeCrashReporting': identifier not found Only the official builders were affected since remoting::InitializeCrashReporting() call is guarded by "#ifdef OFFICIAL_BUILD". BUG=134694 Review URL: https://codereview.chromium.org/11827024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175865 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
This directory is only checked out when target_os=['android']. So we can't assume that adb will always be in the chrome checkout. TBR=nduca@chromium.org BUG=None TEST=./tools/perf/run_multipage_benchmarks --browser=list Review URL: https://codereview.chromium.org/11820035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175864 0039d316-1c4b-4281-b951-d872f2087c98
-
msw@google.com authored
Add ui/resources/default_[1|2]00_percent/close_dialog*.png (copied from chrome/app/theme/default_[1|2]00_percent/web_ui_close*.png) (these are the most up-to-date image that we want to use) Add IDR_CLOSE_DIALOG[_H|_P] to ui_resources.grd TODO(followup): Remove IDR_WEB_UI_CLOSE* and images, use IDR_CLOSE_DIALOG*. (that will depend on WIP CL https://codereview.chromium.org/11830002) BUG=166075 TEST=NONE R=sky@chromium.org Review URL: https://codereview.chromium.org/11785037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175862 0039d316-1c4b-4281-b951-d872f2087c98
-
ilevy@chromium.org authored
It is preferrable to print buildbot step annotations before calling tester runners so that the call is listed in the proper step. This patch removes the step annotation printed by the test runner inself. BUG=161993 R=frankf@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11775013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175861 0039d316-1c4b-4281-b951-d872f2087c98
-
binji@chromium.org authored
BUG=none R=noelallen@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11759011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175860 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
BUG=none NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11817022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175859 0039d316-1c4b-4281-b951-d872f2087c98
-
gman@chromium.org authored
This is a step toward making third_party/khronos/gl2.h and gl2ext.h have as few modifications as possible. BUG=none Review URL: https://chromiumcodereview.appspot.com/11782020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175858 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=168820 TEST=open lots and lots of tabs. The close button stays centered in the selected tab, and the background tabs don't become so small that they look clipped. If too many tabs are opened, they just wander out of the window to the right, like previously -- this time do this on a retina display. Review URL: https://codereview.chromium.org/11821030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175857 0039d316-1c4b-4281-b951-d872f2087c98
-
ilevy@chromium.org authored
chromium.perf bots don't run any tests through bb_tests, so they stopped running device_status_check. Fix this by running device_status_check always if bb_tests is called. R=cmp NOTRY=true Review URL: https://codereview.chromium.org/11827025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175856 0039d316-1c4b-4281-b951-d872f2087c98
-
jamescook@chromium.org authored
This version has a shorter bottom-edge shadow which makes the windows look better when they are at the bottom of the screen near the launcher. It also eliminates some subtle noise in the RGB channels. BUG=168300 TEST=manual, shadows look correct on normal and high resolution displays Review URL: https://codereview.chromium.org/11824033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175855 0039d316-1c4b-4281-b951-d872f2087c98
-
mseaborn@chromium.org authored
Use the Chrome style rather than the NaCl style. Also remove "struct" keywords and use a C++-style cast. BUG=none TEST=build Review URL: https://codereview.chromium.org/11828010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175854 0039d316-1c4b-4281-b951-d872f2087c98
-
jamescook@chromium.org authored
I keep having to look this up from the implementation BUG=none TEST=none TBR=sky@chromium.org - it's just a comment Review URL: https://codereview.chromium.org/11820027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175853 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
TBR=sergiu@chromium.org BUG=169042 TEST=none NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11826029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175852 0039d316-1c4b-4281-b951-d872f2087c98
-
dbeam@chromium.org authored
R=achuith@chromium.org BUG=None TEST=PromoResourceServiceTest.NotificationPromoTest passes on bots and doesn't hurt achuith@'s eyes so much. Review URL: https://chromiumcodereview.appspot.com/11823007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175851 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
By reusing the ui_test_utils::WaitForBookmarkModelToLoad() function we don't need to rely on content::NotificationRegistar/Service nor use chrome::NOTIFICATION_BOOKMARK_MODEL_LOADED. BUG=144783 R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11787025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175850 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
(SystemMenuModelBuilder) and makes BrowserFrame implementation use it. BrowserFrame also provides support for showing the system menu via views::MenuRunner. This is used everywhere but BrowserFrameWin and BrowserDesktolpRootWindowHostWin. Both of these use the system menu. BUG=none TEST=make sure system menu (right click above tab strip) works on windows and chromeos. R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/11819008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175849 0039d316-1c4b-4281-b951-d872f2087c98
-
zmo@chromium.org authored
This failure is caused by crrev.com/175642. So we use file_util::AbsolutePath() to map the path before passing it to ReadFileToString. BUG=168936 TEST=gpu bots Review URL: https://codereview.chromium.org/11820034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175848 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@google.com authored
out/Debug is the current preferred place to put binaries, but keeping sconsbuild/Debug in the search path because that's where the build system currently puts it. More specifically, scripts/slave/extract_build.py extracts builds to src/sconsbuild/Debug rather than src/out/Debug Review URL: https://codereview.chromium.org/11824011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175843 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175840 0039d316-1c4b-4281-b951-d872f2087c98
-
mseaborn@chromium.org authored
This pulls in the following Native Client changes: r10534: (mseaborn) Mac: Fix an off-by-one corner case in handling single-stepping on x86-32 r10535: (mseaborn) Thread suspension: Fix querying registers for another Mac OS X corner case r10536: (mcgrathr) toolchain_build: Update binutils and gcc revisions r10537: (mseaborn) GDB tests: Improve error reporting when GDB's "reason" field is missing r10538: (eliben) Fix pnacl driver tests to look for x64 host dir when x86-32 isn't built r10539: (jfb) ARM: delete stale files and code. r10540: (mcgrathr) Disable performance tests under qemu r10541: (mcgrathr) Segregate trusted/untrusted values of MXCSR r10542: (mcgrathr) Disable run_performance_test via tests_to_disable_qemu not is_broken r10543: (petarj) [MIPS] Update pnacl_llvm_rev and pnacl_gcc_rev r10544: (eliben) Moved pnacl driver tests to a sub-directory separate from driver scripts. r10545: (kschimpf) Fix uses in ARM table: parallel_addition_and_subtraction_unsigned r10546: (kschimpf) Automatically generate actual decoders from information in the ARM decoder table. r10547: (sbc) Remove output chatter from ld_bfd.py run. r10548: (sbc) Add libspeechd-dev to ARM root image. r10549: (kschimpf) Add uses to ARM table packing_unpacking_saturation_and_reversal r10550: (mseaborn) MIPS trusted toolchain: Don't skip QEMU patch if the file is missing r10551: (mseaborn) GDB test: Increase sleep time to reduce the chance of a flaky failure r10552: (mseaborn) Thread suspension: Disallow setting register state during context switch r10553: (jvoung) Allow overriding driver env with test settings. r10554: (mcgrathr) Put code chunks to be copied in rodata, not text r10555: (mseaborn) Enable most of the GDB tests on ARM r10556: (mcgrathr) toolchain_build: Update binutils revision r10557: (kschimpf) Add uses to ARM table branch_branch_with_link_and_block_data_transfer. r10558: (jfb) Update LLVM's known failures. r10559: (mcgrathr) toolchain_build: Update gcc revision r10560: (jvoung) Make LLC use default opt level when pnacl-driver is only used for linking. BUG=none TEST=nacl_integration Review URL: https://codereview.chromium.org/11827011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175838 0039d316-1c4b-4281-b951-d872f2087c98
-
jamesr@chromium.org authored
> Make RenderWidget responsible for the composited view's lifetime > > Chromium side of https://bugs.webkit.org/show_bug.cgi?id=105071. > content::RenderWidget constructs a WebLayerTreeView when WebKit > asks it and then retains ownership. This has to be destroyed > before the WebWidget is closed since the WLTVClient is (currently) > a WebKit object. > > BUG=156175 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175303 > > Review URL: https://codereview.chromium.org/11575049 Broke interactive_ui_tests:ExtensionApiTest.NotificationsHasPermissionManifest on windows TBR=jamesr@chromium.org Review URL: https://codereview.chromium.org/11778068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175834 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
BUG=160902 Review URL: https://codereview.chromium.org/11742012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175833 0039d316-1c4b-4281-b951-d872f2087c98
-