GitLab

Fix Typo in "importance"

Test: None (build passes)
Bug: None (fix typo)
Change-Id: I47997140d94d50c633a02b22f6d7c96741a5e0fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093973Reviewed-by: Sara Kato <sarakato@chromium.org>
Reviewed-by: Hiroki Sato <hirokisato@chromium.org>
Commit-Queue: Sara Kato <sarakato@chromium.org>
Commit-Queue: Hiroki Sato <hirokisato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748507}

BUG=1010303

Change-Id: Iacc4e809cef08aadd061c5c3eab04725382b5108
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082733Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748506}

Following bot results are included.
1656 1658 1659 1660 1661 1662 1663

9 lines were removed and 8 lines were deflaked by consecutive
results since 1532.

TBR=yosin@chromium.org
NOTRY=true

Bug: 982194
Change-Id: I82dfaeb3efa863416d9cd610be7d2a2e6ba24369
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067828Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748505}

https://dawn.googlesource.com/dawn.git/+log/be6cd5188880..52d0627d5607

git log be6cd5188880..52d0627d5607 --date=short --first-parent --format='%ad %ae %s'
2020-03-09 bryan.bernhart@intel.com D3D12: Pool-allocate shader-visible descriptor heaps.
2020-03-09 brandon1.jones@intel.com Residency 2: Create a d3d12::Heap During Direct Allocations

Created with:
  gclient setdep -r src/third_party/dawn@52d0627d5607

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I8b3a86995d954fa859f11f58a1b0040ba67d3291
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095936Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748504}

This CL allows network::mojom::Foo type in PRESUBMIT.
network::mojom is planned to be used as non-blink mojom types.
(discussed here: https://groups.google.com/a/chromium.org/g/platform-architecture-dev/c/ntSzerId4gw)
Showing warnings when developers add network::mojom type is confusing.

This doesn't change the behavior for other ::mojom::Foo types.
FYI: https://chromium-review.googlesource.com/c/chromium/src/+/2010448/3#message-ebc5ce48bcda75d920adc0a3486c233bd802113b

Bug: 1043557
Change-Id: I362b2a0cec53bf39393d203689fbe0a98c34ca11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028879
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748503}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=benmason@chromium.org

Change-Id: I8abf58c5581bec6f81ac4fa40fdadd130ab8a850
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095965Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748502}

- Changed the members in throttle_config struct to be Optional, since
not all configs clients want to specified.
- Wrap up methods to get correct value from either custom_throttle_config
or default config.

Change-Id: Id0338ab2a7c9bbad9ff184655982c5cdb26e6990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090368
Auto-Submit: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748501}

WebAppMigrationManager shouldn't destruct owned database_ object
immediately in callbacks from database_. This would be a violation of
the caller/callee contract.

We should use PostTask instead so |this| stays valid in
WebAppDatabase even after callback call.

This CL fixes
./out/debug/sync_integration_tests --gtest_filter=All/SingleClientBookmarksSyncTest.PersistProgressMarkerOnRestart/0

test if BMO mode is on by default.

TBR=alancutter@chromium.org

Bug: 1054112
Change-Id: I170424768e7c684ed3c14e398836755201dd4f33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089559
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748500}

For users who have enhanced protection enabled, and are not incognito,
attach an OAuth access token to download protection pings to improve
the quality of verdicts.

Bug: 1051679
Change-Id: I8cdfd3392c10cd9d7b81cd5f036e8ccf179b6ade
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092944Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748499}

Change-Id: I4ccc6d5df5ec248d20e35b04d91fe3be762f68e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094420
Commit-Queue: Leo Zhang <googleo@chromium.org>
Reviewed-by: Leo Zhang <googleo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748498}

Disables the swipe when showing accessibility page.

Disables the swipe when screen is not shown fullscreen (i.e. the swipe
is enabled only in OOBE first run).

BUG=1059354,1058896

Change-Id: I400fb1e1321d1123b46cebfcc316cb261ff6e52c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091938
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748497}

Using a FakeCrostiniFeatures with all options on "true" removes flakes.

Bug: 1059771
Change-Id: I5beeea945dd2f38e857c95e808119643e8081b27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094918
Commit-Queue: David Munro <davidmunro@google.com>
Reviewed-by: David Munro <davidmunro@google.com>
Cr-Commit-Position: refs/heads/master@{#748496}

Need this to shorten notification timeouts for an
upcoming experiment on Chrome OS.

Bug: 1059017
Change-Id: I15c70147dcde628851649d71070aeaa9d2b886bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090495Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748495}

Since blink unconditionally requests the TextSuggestionHost interface,
and the browser only binds it on Android, this change adds an empty
binder for other OSes.

Bug: 1059728
Change-Id: Ic9f53b17d9f2abb3d155dd85db098d3b51bfe02d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093913
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748494}

This CL also add a new enumerator |ash::CommandId::SETTINGS|. It does
not reuse the existing |ash::CommandId::Options| because we want to use
a different icon.

Bug: 1056983
Change-Id: I8593fbe6ec0024008e6d75bda3fc41e61aa3d6d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089184
Commit-Queue: Jason Lin <lxj@google.com>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748493}

In this patch, we replace the current implementation of sorting effect
order by comparing effect sequence number with comparing the
HasLowerCompositeOrdering function.

The patch will align the implementation with the spec
(https://www.w3.org/TR/web-animations-1/#the-effect-stack). And as we
are using the same comparison function as the getAnimations, the
rendered result would be the same as getAnimations() result.

Bug: 1050224

Change-Id: I88f151fa78070817d2fa4fd520580ddf6d024e27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076160
Commit-Queue: Hao Sheng <haozhes@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748492}

Using wpt-import in Chromium 0b6c41a8.
With Chromium commits locally applied on WPT:
d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching"
acf33020 "Add testing for the scrolling attribute"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I049e9a6c63597b22b9ebf134d73035f16af8cef4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094662Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748491}

add a feature to disable using TOOL_TYPE_PALM as indicator for
palm-ness. Enable this feature by default, to maintain current
behavior across all devices in chromeos (!!)

Add a comprehensive unit test to test for behavior when this feature
is disabled.

Bug: 1009290
Change-Id: Iea348a37957ba2177c82a31d40029f0b831a578c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094478Reviewed-by: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Rob Schonberger <robsc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748490}

Private CL that logs metric:
https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/2688974

Bug: 1046223
Change-Id: I24823a143aebfd5015d3820348a6ce789f971ab5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090971
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748489}

Bug: 1059507
Change-Id: Icb23df73dd76253ed8432b4893473db3d1952545
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095560Reviewed-by: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748488}

This CL adds the visual elements but omits most of the plumbing necessary to combine all the prefs controlled by this toggle.  That will come in a follow up CL.

Bug: 1032584
Change-Id: I9c4770d88a91774fcd9efa65832ff3b07a3b8d71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092591
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Auto-Submit: Sean Harrison <harrisonsean@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748487}

for on device head suggest in AutocompleteMatchToAssistedQuery.

This caused a failure when I was testing chrome://flag
"Enabled incognito-only-revelance-1000" on iOS, as sometime some
suggestions are with provider type TYPE_ON_DEVICE_HEAD but match type
SEARCH_HISTORY. Not sure why this happens because TYPE_ON_DEVICE_HEAD is
only used in class OnDeviceHeadProvider and this provider always set
its suggestions as match type SEARCH_SUGGEST via function
BaseSearchProvider::CreateOnDeviceSearchSuggestion. I guess there's
some special dedup logic outside the on device head provider when the on
device suggestion happens to be a same suggestion found in search
history. Did not see this issue for non incognito.

I haven't found any failure in any ongoing studies neither, though IIRC
DCHECKIsFatal is enabled for iOS canary: http://screenshot/8TsAdBQ0O6Y.



Bug: 925072
Change-Id: Id9ea168acbddf4c7b6580c7e94cad459cd99f637
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091195Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Ce Chen <cch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748486}

These methods let you compare if two handles represent the same entry, and
get the relative path of an entry inside a directory.

Bug: 1021351, 955184
Change-Id: I00f5be46b13c24973e9ad107f885047483656580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089955Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Olivier Yiptong <oyiptong@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748485}

TBR=benmason@chromium.org

Change-Id: I2f758c3cb899c12385e912aa69dd6debdd427383
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095454
Commit-Queue: Krishna Govind <govind@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748484}

Per the comment in [1], this CL updates the focus ring color
when increased contrast is enabled on Mac to #101010.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=1054813#c22

Bug: 1054813
Change-Id: Iac10ec3a21bf920bd16744f7752d7a24a4aa1906
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094345Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#748483}

BUG=1040648

Change-Id: I911c466951ea2a1691c9ee5539bc5c7573d948fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095781
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748482}

This change introduces Adaptive suggestions count, where the number
of offered suggestions is driven by the available screen space.

The mechanism needs to decide whether a suggestion is eligible ahead
of Layout call, and is therefore unable to reliably identify the
height of a suggestion, therefore we use minimum suggestion height
instead.

Bug: 1050813
Change-Id: I1fc440f6e86fc0ca764b79e8c835be174bf31da6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071139
Commit-Queue: Ender <ender@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748481}

Previously if the extension was in split mode both the incognito and
the non incognito processes would receive the onAlarm event even if
the alarm was created in a different browser context.

Now alarms.onAlarm is restricted to the browser context the alarm
was created.

Bug: 1011374
Change-Id: I1c5ed9273da1ec7d4e8b211b04591c8ae839ad1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067542Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Archana Simha <archanasimha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748480}

It is possible that the preview tab is requested to open, while it
is already the current bottom sheet content just hidden in the
controller. This CL makes sure it will be visible by moving it to
the appropriate peek/open state.

Bug: 1057966
Change-Id: Id3dca309738d22cca5086325272a4aa0dff67724
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087307Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748479}

Some AudioNodes require an access to the execution context (mainly
because of the task runner) and this might not work (null-deref) if
the associated frame/document of a BaseAudioContext is already
detached.

This change adds a check against ExecutionContext in the factory
methods of problematic cases.

Test: Ran submitted reprocases on ASAN and they do not crash anymore.
Bug: 1057735, 1058693, 1058648, 1058687, 1058668
Change-Id: I4c6b994087f8f9561edd4fe8eaa74961fa3bebbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095141
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748478}

Icons for the action bar buttons are controlled using -webkit-mask-image
applied to a child of the buttons. The clear button in the search box
had the mask applied directly to the button which caused any border
applied by focussing to be masked out.

Add a child <div> to the clear button to be consistent with all the
other action bar buttons.

Applies the mask to the child div instead of the containing clear
button.

Tbr: noel
Bug: 1059012
Change-Id: Ie0273eb97b06fb4b588ce523a06673d5606fe056
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094427
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748477}

Currently, we used base::Feature "ChromeosVideoDecoder" to control VD
enabling. For those unsupported boards, we add the cmdline argument
"--disable-feature=ChromeosVideoDecoder" to disable the feature.
However, this argument doesn't affect at guest mode. So when we enable
the feature by default, those boards cannot play video at guest mode.

In this CL, we add a new cmdline flag "kForceDisableNewAcceleratedVideoDecoder".
We pass this flag to GPU process, and this flag forces to disable the
ChromeosVideoDecoder feature.

Bug: b:149797442
Test: Add/Remove "--force-disable-new-accelerated-video-decoder" at /etc/chrome_dev.conf
      then run `tast run $(DUT) video.Play.h264_guest`.
      Check VDA or VD is created as expected
Test: ./gpu_unittests --gtest_filter="GpuPreferencesTest.*"

Change-Id: I1257947fee388e0edbe52e258fbf3f6e5afca795
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063511Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748476}

https://skia.googlesource.com/skia.git/+log/23899c64e3db..ea3ddc9aefde

git log 23899c64e3db..ea3ddc9aefde --date=short --first-parent --format='%ad %ae %s'
2020-03-09 fmalita@chromium.org [skottie] KeyframeAnimator builders
2020-03-09 scroggo@google.com Update SkWebpEncoder.cpp's copyright notice
2020-03-09 kjlubick@google.com [canvaskit] Update dash example link to use new API.
2020-03-09 nifong@google.com Fix deprecated names

Created with:
  gclient setdep -r src/third_party/skia@ea3ddc9aefde

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: brianosman@google.com
Change-Id: Ib5bd141971411b8c436d8977e7c2c2d105387d15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095305Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#748475}

The current implementation checks the URL too early. If the URL is
non-HTTP(S) (e.g. a data URL), url.GetWithEmptyPath() returns an invalid
GURL and causes a DCHECK.

Bug: 1056755
Change-Id: I9923d5f28dae10382ac6701ca5cc25342c24a0fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095778Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748474}

Previously, NewTabPageHandler was a content::WebContentsObserver.
However, we never associated it with a web contents. As a result, all
usages of web contents in the NTP handler were in fact a nullptr. This
CL fixes this by passing the correct web contents when creating the NTP
handler. Additionally, it removes content::WebContentsObserver as one of
the handler's interfaces as we are not observing any changes.

Change-Id: I4d79b726dbc7377f29b6f0630680bb13082a3c15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095785
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748473}

This histogram is expiring soon. Since it was launched to check
usefulness of chrome://connection-help, which has since launched, it is
not required anymore.

Results have been fairly stable at around 20% of "Learn More" clicks
resulting in a redirect to chrome://connection-help (due to the
navigation triggering another SSL interstitial).

Bug: 1059826
Change-Id: I99b87138e0a7776bd89ec9d3785380c725e0f176
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095209Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748472}

In the original implementation, screen reader cannot read out the
content for RadioButtonWithEditText. This change makes the EditText as
the label of the widget, so that the content description for EditText
can be read out as part of the RadioButtonWithEditText.

Before the change, RadioButtonWithEditText read out as
"Checked/Unchecked radio button"; after the change, the widget read out
as "Checked/Unchecked radio button for <read out for EditText>", which
will contains:
1. The Radio button is for a EditText
2. The text & hint for EditText

Bug: 1057269
Change-Id: I23cabe4b7bc8313bbc8c055a95f5a9e26e876b7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090620
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748471}

http://gn.googlesource.com/gn/+log/4166e9fbc1f..fd3d768bcfd4
fd3d768 msvc writer: Don't die on generated_file() and create_bundle() targets.
f871e54 Fix Rust dependency propagation
c2d0ace Fix crash in "gn gen --ide=xcode" when project is malformed
5e43d01 Fix gn format --stdin newlines on Windows
d422999 WIP: Fix (cross)compile with MinGW
c89bc82 Write input files to json project

Bug: 1059666
Change-Id: I2a7de94702f8e5d3611e175aa096c82a8d39a689
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095467Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748470}

Nodes in WebView is already sorted by the order to be traversed.
Sorting based on bounding rectangles makes the navigation order broken.

Bug: 827352
Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*"
Test: Open Gmail app or ChromeBrowser app, and confirm that navigation order is correct.
Change-Id: Icbf1f10ab8762c038e763c80a75e2d17340be7f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089540Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Sara Kato <sarakato@chromium.org>
Commit-Queue: Hiroki Sato <hirokisato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748469}

In order to control real time URL lookup via high-end and low-end
groups, add a memory upper threshold control.

This change will make it easier for finch configuration, see:
go/wmpfd

Bug: 1014202
Change-Id: I639153c9baac73cd8bfcdaff3a82c020237a6c4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092697
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748468}