- 14 Dec, 2020 40 commits
-
-
Song Fangzhen authored
Add TCPReadableStreamWrapper and TCPWritableStreamWrapper which provide stream implementations for TCPSocket. TCPReadableWrapper and TCPWritableWrapper watch the mojo datapipe, create underlying queue strategy, and provide functions like read/write data from/to network. Unittests are also provided. Below documents are from Eric Willigers <ericwilligers@chromium.org>. Explainer: https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md Intent to Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/ARtkaw4e9T4/m/npjeMssPCAAJ Design doc: https://docs.google.com/document/d/1Xa5nFkIWxkL3hZHvDYWPhT8sZvNeFpCUKNuqIwZHxnE/edit?usp=sharing Bug: 905818 Change-Id: I8a0da5d9391c543201e5e9620ca493d192166319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563340Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Ke He <kehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#836841}
-
Mario Sanchez Prada authored
Due to the recent migration from legacy IPC messages to mojo, some crashes have been observed because of MediaSessionController and MediaSessionImpl objects being alive after the WebContents object they are associated to has been destroyed. This seems to have been caused because of a race condition that can happen if a call to a method of the MediaWebContentsObserver mojo interface arrives in the browser process once a WebContents is in the process of being destroyed: such messages will call methods of MediaSessionControllersManager that will create new MediaSessionController and MediaSessionImpl objects again, but with an invalid WebContents object associated to them, causing the crashes when later on such objects assume a valid WebContents available (e.g. in MediaSessionImpl::GetMediaSessionInfoSync()). In order to fix this problem, we need to make sure that we destroy the objects holding the MediaWebContentsObserver mojo receivers in the browser process as soon as we know that the either the WebContents associated to them is about to be destroyed, but before the actual destructor is run. Likewise, and similar to what's already done for the map of PlayerInfo objects, we should also make sure we destroy those objects holding the mojo receivers as soon as the associated RFHI is getting deleted, so this CL does that as well. Last, and even though not directly related to this crash, it's probably a good idea to do a similar cleanup for the map of MediaPlayerHostImpl objects (which is indexed by RFHI) and the map of mojo::Remote<media::mojom::MediaPlayer> remotes (indexed by MediaPlayerId), also owned by MWCO, in the two same cases, so this CL takes care of adding that extra cleanup too. Bug: 1157779, 1039252 Change-Id: I4932f43ce8622dbecaf20dbe417f61ee8167647d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587045Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#836840}
-
Michael Crouse authored
This is a global replace of: /cld_language/model_detected_language /is_cld_reliable/is_model_reliable Bug: 1157983 Change-Id: I9471600db6ae3221dd63fa92ee30d8c093748b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587620 Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Trevor Perrier <perrier@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#836839}
-
Ian Wells authored
Only one is expiring, but since they're closely related, it makes sense to have both expire at the same time next time. Bug: 1140022 Change-Id: I4bfaecaf5e5d07f7576d7840dabb1360d9050f15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577109 Auto-Submit: Ian Wells <iwells@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#836838}
-
Nico Weber authored
We disable ICF for v8_context_snapshot_generator on Linux and Windows. Now we also do it on macOS. (I noticed that we weren't doing it because the mac/lld build complained about ld64.lld not understanding --icf=none.) Bug: 617892,1149587 Change-Id: Idf40a021ec70dea394ed7b74826ceaed99d853b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591007 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#836837}
-
Dave Tapuska authored
GuestViewAttachRequest class is never constructed. This means that GuestViewHostMsg_AttachGuest can be removed as well. BUG=1143268 Change-Id: I5631a5aacb68a426ec1f5d101aea28cd180b86ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587373Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
-
Dave Tapuska authored
The metric has been expired. Remove dead code. BUG=1055384 Change-Id: Ic5df4f8f54adc8057993ab70e66403125e4a5914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587433Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#836835}
-
Michael Crouse authored
Initializes varible in case model is not available. Bug: 1158539 Change-Id: I00587372d9ae185b6840a514da2363c1fe7b971d TBR: megjablon@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590588 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#836834}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/99399caeacf6..9c7f6c25c004 2020-12-14 ehmaldonado@google.com [owners] Refactor OwnersClient. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I9e850abd0a5f456bc524f14a74778cabc6629863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590988Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836833}
-
Jae Hoon Kim authored
The enum values should be 1 to 1 with the error codes sent from update_engine as defined in update_engine's: /aosp/system/update_engine/common/error_code.h BUG=b:175337382 TEST=none Change-Id: I7b6c42d2feef052f5e5ee7b746bf18a971382969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586365 Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Reviewed-by:
Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#836832}
-
Mehran Mahmoudi authored
Bug: 1149972 Change-Id: I9614243851fddcb55402caf5a2d8ea6e1410092f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582405 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#836831}
-
Stefan Zager authored
If an entire frame is display locked because it's an iframe whose owner <iframe> element is locked in the parent document then... - We should not run lifecycle updates, even if the frame requires an IntersectionObserver update. - IntersectionObserver should be allowed to run, even if the document is dirty (because it skipped lifecycle updates). It's OK to do this because when the IntersectionObserver algorithm runs, it will skip all geometry work due to the display lock, and just generate a "not intersecting" notification if one is needed. Change-Id: I591fee0f707189696e2a38bc754b81458d8ae2f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587690Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#836830}
-
Patrick Noland authored
This moves onSuggestionsHidden, onSuggestionsChanged, setOmniboxEditingText, and setUrlBarFocusable to LBCoordinator/ LBMediator. Notably, this removes some redundant logic that was previously siloed in LocationBarTablet. This logic became redundant when we added mUrlBarTextIsSearch. Bug: 1147581 Change-Id: Ia02c651530e6a23540ebcc67abd58c1e846ac738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586186Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#836829}
-
Kenton Lam authored
Uses generate_grd and grit rules to create and bundle the necessary resource files. Functionality is equivalent to existing code. Bug: 1156851,1156859 Change-Id: I0724137a3f6cffbc5d44539e5515b335f702f447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586289Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
John Palmer <jopalmer@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Kenton Lam <kentonlam@google.com> Cr-Commit-Position: refs/heads/master@{#836828}
-
Daniele Castagna authored
|gpu_memory_buffer_factory_| weak pointers are checked on the IOThread. Weak pointers should be invalidated on the same thread that checks them. This CL moves the destruction of |gpu_memory_buffer_factory_| on the IOThread to avoid possible use after free issues. Bug: 1152645 Change-Id: I0d42814f0e435a3746728515da1f32d08a1252cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563077 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#836827}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/12c78cbc820a..43c39a1ba42a 2020-12-14 rharrison@chromium.org Re-enable disabled unit tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I14f5ec40c33cac0d1ffde15e945cce5f3982a76c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591147Reviewed-by:
-
Bruce Dawson authored
Due to an OS bug shell32.dll may get unloaded while still in use. Pinning shell32.dll avoids this and the associated crashes with no downside. This is an expansion of the fix in crrev.com/c/2505835 Bug: 1076771 Change-Id: I89153998a5dabb345db0435877201de771a60b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588012Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#836825}
-
Mark Yacoub authored
This is a reland of 631cb004 Original CL has been reverted due to SkiaRenderer not handling recreating buffers. The fix has been merged (crrev.com/c/2581693), so this should be good to reland again. Original change's description: > Fallback to Linear Modifiers if Preferred Modifiers fail. > > Test-Modeset with preferred modifiers. > If it the test passes, save the preferred modifiers to use for full modeset. > If it fails, try testing with linear modifiers for every controller. > Use empty modifiers list if the platform doesn't support preferred modifiers list. > > This enables us to launch Intel Rendering Buffer Compression. > http://go/cros-intelrbc > > BUG=979736,1082882 > > TEST: RBC enabled on (4K eDP with 4K external) and (4K eDP and 2 external monitors), zork, and nautilus > Change-Id: I7698d2cc9f13e5293eb0f6579dee775314988037 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567263 > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Commit-Queue: Mark Yacoub <markyacoub@google.com> > Cr-Commit-Position: refs/heads/master@{#834389} Bug: 979736 Bug: 1082882 Change-Id: I90a4c93c5318da9ba252d126629c99173895e6f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585813 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Auto-Submit: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#836824}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/778b2c216924..54174aefa84c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id6cc008f4edd71ce2a9e45781f5d648f2ef36dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590491Reviewed-by:
-
Fabrice de Gans-Riberi authored
This adds a //net-based implementation of the Open Screen UdpSocket interface. Its main use is for unit tests that do not have or require the network service. Bug: 1110490 Change-Id: Ic542c3c29d05b5c58d36efb6fd31d0eeac3cefe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580908Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Jordan Bayles <jophba@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#836822}
-
Edward Lesmes authored
Presubmit check added in crrev.com/c/2582566 Bug: 1113033 Change-Id: I09802343bd11d3f5f044cda4cea3aa8e58c8c398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583464 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#836821}
-
Josh Santana authored
If a user decides to check "Always Translate" on the Bubble UI, it will now automatically translate the page upon them doing so, instead of them having to also click on their target language. Bug: 1156275 Change-Id: I2d7aa033d575249d98bb95c90e510fd0dd5e332e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582534Reviewed-by:
Josh Simmons <jds@google.com> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Joshua Santana <joshsantana@google.com> Cr-Commit-Position: refs/heads/master@{#836820}
-
Ian Wells authored
Bug: 1152187 Change-Id: Ic0b044b6c1318d34b0107c1ec37c04aa2b0450ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580780 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#836819}
-
Scott Lee authored
result_adapter is chromium-specific tool that reads the test outputs with gtest/json format and sends them to ResultDB. It was previously deployed to Swarming bots via pool config, but this CL adds it to src.DEPS, so that - swarming pool.cfg no longer have to deploy a chromium specific cipd pkg, and - result_adapter becomes available for local runs in dev's workstation. Change-Id: Ifce0f243162c6aa0f76539fcda1446cfcac2f88d Bug: 1084332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586748Reviewed-by:
Chan Li <chanli@chromium.org> Reviewed-by:
-
Nick Burris authored
* Create ExternalAuthGoogleDelegate, owned by ExternalAuthUtils, which will be used to implement isGoogleSigned downstream, rather than doing so with an overriding subclass. * This is patch 1/5 for providing ExternalAuthUtils as a singleton instead of from AppHooks. Change-Id: I13c8d972f8ca1a4d2dac1bdda4ad8911ae8c275b Bug: 1154371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587429 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Trent Apted authored
This DCHECK is causing tests in components unrelated to notifications to be flaky. Change it to DLOG_IF(ERROR.. so that those components can retain their test coverage. Bug: 859061, 988160 Change-Id: I01a5cfeccc9907c64f7afc9d9235a1ad0cb6179e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584433Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#836816}
-
Yao Xiao authored
What: Rename publicly_routable field in the history APIs to floc_allowed. The database schema is left unchanged to save the migration cost. Updated the comment for VisitRow::floc_allowed. Why: This bit is expected to be used only for floc. We've decided to incorporate another opt-out status, and may introduce more status in the future. Therefore it makes sense to rename to floc_allowed. Bug: 1157761 Change-Id: I9aecb50287e7953754eb05aa2d7993a6092639e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586232Reviewed-by:
-
Jan Grulich authored
Current scenario when PipeWire desktop capturer is used: Chromium picker dialog is created with screen and window capturer. Each capturer makes an xdg-desktop-portal call, showing another picker dialog. Once user confirms both pickers on xdg-desktop-portal side, yet another picker is shown as a new capturer is created for the web page itself. With this change: Chromium picker dialog is created, but only screen capturer will be created as with xdg-desktop-portal the picker will handle both screens and windows. Also in the chromium picker, the "window" tab creating window capturer expects a list of windows and doesn't show previews, but we need actually to behave exactly like the "screen" tab and show preview of selected window. Then again, yet another picker from xdg-desktop-portal is shown as a new capturer is created for the web page itself. Bug: chromium:1157006 Change-Id: I39eafc72eb46da7868d1114b5c106030c22787a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578840 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#836814}
-
Greg Thompson authored
Switch to using a p-link and drop the language query param. BUG=1102713 Change-Id: I782b331d3baae302518b54535e1fcab149e6c549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585087Reviewed-by:
Yann Dago <ydago@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#836813}
-
Abigail Klein authored
Give the toolbar accessible node data so that it becomes a group in the accessibility tree. This improves the experience of navigating the chrome for screen reader users: users can treat the toolbar as a group and interact with it, or skip over it if they prefer. Previously, users had to navigate through every button in the toolbar, slowing them down. Bug: 1097760 Change-Id: Ia7aaed4d74bf081c2b41e4142d732d8b56563afa AX-Relnotes: Make the toolbar an accessible group. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588893 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#836812}
-
Harry Cutts authored
The Yubikey 4 presents as a keyboard to type in OTP codes, but shouldn't prevent the virtual keyboard from showing up. Vendor and Product IDs from https://crbug.com/1011418#c13. Bug: 1011418 Test: none (I don't have the device) Change-Id: I852577679f89ca5613d6120dd0bafdf103554b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590506Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Auto-Submit: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#836811}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c24141ebe089..a4d2246a2f93 2020-12-14 liberato@chromium.org Add freezing / roughness to media telemetry tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: oysteine@google.com Change-Id: Ib3ed207f4aedbed54e7f230ba055542f2f1bda44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590416Reviewed-by:
-
Frank Liberato authored
This lets us record the events in telemetry. Change-Id: I90348045cdca95705be99b5900376fd6e13577d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441018Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#836809}
-
Jarryd authored
Bug: 1102433 Change-Id: I65e8d1504b5ffdcd34706bba746db132692f2d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589008 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#836808}
-
Leonid Baraz authored
Writes the key to the file, parses it from the file during initialization. Encryption is controlled by base::FeatureList; if encryption is enabled, fail Storage initialization. Later on we will instead send Upload with no records and only need_encryption_key flag and reject Enqueue until it is responded. Bug: b:170054326 Change-Id: I343b17f9363e11b62e6ab1f69148a7e9e8e0d4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586086Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#836807}
-
Scott Violet authored
This removes the cct extra header when in incognito mode. BUG=1158518 TEST=doesNotSetHeaderWhenIncognito Change-Id: I43724d127aa6971b686b89293ec8efea146dffdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590705Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#836806}
-
cfredric authored
These functions will eventually be used to compute SameParty-ness by the SameParty cookie implementation. Bug: 1143756 Change-Id: Ib9ac724c4a3d6053c0ed6886e8dc0acdefc050f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586148 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Auto-Submit: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#836805}
-
Aleks Totic authored
Several data structures do not byte align, and cannot be compared with mem functions. Bug: 1158513 Change-Id: I31a0f8b80c17268e1b5661aaef9d07a5854b2e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590907 Auto-Submit: Aleks Totic <atotic@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#836804}
-
Jesse Doherty authored
This histogram value is used as part of a high level guiding metric. We're trying to consolidate these metrics as user actions to improve query speeds and enable new analysis. Bug: b/161525144 Change-Id: I3564e5555f37ecd0c2eb73a9a08adc4d30b8566b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575605Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#836803}
-
Cheick Cisse authored
Create Open javascript action and set up histograms for contextMenu actions Bug: 1140387 Change-Id: I836eff307c6de1a8b233c3018a9856799bd43513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584646 Commit-Queue: Cheick Cisse <cheickcisse@google.com> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#836802}
-
