- 21 Jun, 2018 39 commits
-
-
Fan Yang authored
R=rch@chromium.org Change-Id: Ia7c7977a7e1be03bdc9a91625f2ecaf0be1332d2 Reviewed-on: https://chromium-review.googlesource.com/1108757Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#569134}
-
crystallambert@chromium.org authored
bug: none Change-Id: I331ccff02d4100dfc8c11a3a22de58c80a9356a7 Reviewed-on: https://chromium-review.googlesource.com/1086159Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#569133}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/cc4802edc4fa..d9fb538bc08c git log cc4802edc4fa..d9fb538bc08c --date=short --no-merges --format='%ad %ae %s' 2018-06-20 rharrison@chromium.org Remove duplicate method for generating alerts Created with: gclient setdep -r src/third_party/pdfium@d9fb538bc08c The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I59392e7c5596a0fda09d91152e19c2f8083ce80d Reviewed-on: https://chromium-review.googlesource.com/1108898 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569132}
-
Chris Lu authored
This broke the page because of a DCHECK for what kind of item was being added as a footer. Change-Id: Id6b871b814c32a8579f74b4274167326fcde5178 Reviewed-on: https://chromium-review.googlesource.com/1109415Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#569131}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/99525875794b..2db95136c551 git log 99525875794b..2db95136c551 --date=short --no-merges --format='%ad %ae %s' 2018-06-21 simonhatch@chromium.org Dashboard - Use isinstance() instead of type() Created with: gclient setdep -r src/third_party/catapult@2db95136c551 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I42d7c0b2772818d7e6a0bcaa08850f62b2620858 Reviewed-on: https://chromium-review.googlesource.com/1108778Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569130}
-
Xing Liu authored
Currently we access disks on Android main thread to pull download directories, which can cause Android to skip over 100 frames during rendering, or even totally bust the rendering and show a black screen. When try to build download location UI, it may stuck a few seconds(ANR). This CL moves all disk access operation to background thread, so UI will be fast and smooth. Bug: 844107 Change-Id: Icba6db01a4a638cdc62b2e1d207e73981af15dca Reviewed-on: https://chromium-review.googlesource.com/1107041Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#569129}
-
Jared Saul authored
The ordering of functions in autofill_table.cc is *completely* out of order with what's listed in autofill_table.h, and keeping them consistent seems to be our standard. This CL makes only two changes: 1) Moves functions in autofill_table.cc around (no changes; don't let the diff tell you otherwise!) 2) Removes InitDatesTable() from the .h file, which apparently doesn't exist in the .cc file (or anywhere else in the repo) Change-Id: If091c89fc41bd53bd5c2aaccece0da175ff4937e Reviewed-on: https://chromium-review.googlesource.com/1109402 Commit-Queue: Jared Saul <jsaul@google.com> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#569128}
-
Alexander Alekseev authored
TBR=emaxx@chromium.org Bug: 828996 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iac0401f02a225ff4b75a2b0277a6b90ca2d1116b Reviewed-on: https://chromium-review.googlesource.com/1108748Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#569127}
-
Joshua Peraza authored
Bug: crashpad:30 Change-Id: I3b306c40bdd41bd1536e00a82a712bacf60199a2 Reviewed-on: https://chromium-review.googlesource.com/1107843Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#569126}
-
Hitoshi Yoshida authored
This reverts commit c09fc457. Reason for revert: This CL breaks MSAN build https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/8439 Original change's description: > Roll src/third_party/libaom/source/libaom/ cc92258a0..c5a56b99d (3832 commits) > > https://aomedia.googlesource.com/aom.git/+log/cc92258a08d9..c5a56b99df86 > > $ git log cc92258a0..c5a56b99d --date=short --no-merges --format='%ad %ae %s' > (...) > > Created with: > roll-dep src/third_party/libaom/source/libaom > > As part of the roll we must update the colorspace signaling. > > Originally added to libaom in > commit 9e69463febe0ee8525cb5a99ee5f9f11286581f1 > Author: Andrey Norkin <anorkin@netflix.com> > Date: Thu Dec 21 18:50:57 2017 -0800 > > CICP colorspace signaling > > Monochrome is signaled outside of CICP: > commit f340fece2c18f068dc3c0c9219b2e5a5eee7ba79 > Author: Debargha Mukherjee <debargha@google.com> > Date: Wed Jan 10 18:12:22 2018 -0800 > > No colorspace for mono-video f/ CICP compatibility > > BUG=aomedia:1673 > > And remove references to the deadline parameter. > > BUG=aomedia:13 > > Updates bear-av1.webm and disables bear-av1.mp4 test. > ffmpeg muxing of av1 in mp4 has not been upstreamed yet. > The webm file was generated with the av1 tree in this > update. > vpxdec media/test/data/bear-vp9.webm -o bear.y4m > aomenc -o bear-av1.webm -p 2 --target-bitrate=150 \ > bear.y4m > > The I frame for the AV1 test is generated with: > aomenc -o bear-av1.webm -p 2 --target-bitrate=150 \ > bear.y4m --limit=1 --ivf > > And then a hex editor is used to remove the 32 byte > file header and 12 byte frame header. > > BUG=chromium:783519 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I0b89285155e286f921448b221a491f9ed24cfd6e > > NOPRESUBMIT=true (due to presubmit confusion about relative paths in DEPS) > > Change-Id: I0b89285155e286f921448b221a491f9ed24cfd6e > Reviewed-on: https://chromium-review.googlesource.com/1101705 > Commit-Queue: Johann Koenig <johannkoenig@google.com> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Tom Finegan <tomfinegan@chromium.org> > Reviewed-by: Fredrik Hubinette <hubbe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569100} TBR=dalecurtis@chromium.org,jschuh@chromium.org,tomfinegan@chromium.org,hubbe@chromium.org,johannkoenig@google.com,tdaede@mozilla.com Change-Id: Iea0ad8d1bff6db507eac0be065f3dfe0ba248e5f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: aomedia:1673, aomedia:13, chromium:783519 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1109557Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#569125}
-
Dan Beam authored
R=sky@chromium.org BUG=none Change-Id: Ia0447eae8c7bfbf6646981fd2dda592c25a95f89 Reviewed-on: https://chromium-review.googlesource.com/1098024Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#569124}
-
Yafei Duan authored
'#' will be in the json which will be parsed to get the navigation URL. This should make things better for both server and client side. Bug: NONE Change-Id: I503352ab7970ed55d9e9ab3e786e3c0675d7d471 Reviewed-on: https://chromium-review.googlesource.com/1109379Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#569123}
-
Tetsui Ohkubo authored
Night Light button is no-op when not logged in. There's no harm but it's better to hide the button to avoid confusion. TEST=manual BUG=819957 Change-Id: I28fa1629dea1c19340d6eabcb1bca51b1fea28f0 Reviewed-on: https://chromium-review.googlesource.com/1107533Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#569122}
-
Philip Rogers authored
This is rather surprising: IntSize(1, 33553177) != RoundedIntSize(IntSize(1, 33553177)) This is because we use RoundedIntSize(const DoubleSize&) due to the implicit DoubleSize(const IntSize&) constructor, which rounds the size to 1x33553176 because doubles do not have perfect precision. This removes a RoundedIntSize from CollectDrawableLayersForLayerListRecursively which incorrectly resulted in rounding the layer bounds. This patch also makes the DoubleSize(const IntSize&) constructor explicit to prevent this mistake in the future, because the conversion is lossy. The corresponding FloatSize constructor is already explicit. Bug: 854194 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I71ecc68eeaa39e602ba7e415222eafea2e706047 Reviewed-on: https://chromium-review.googlesource.com/1107203 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569121}
-
Alex Newcomer authored
Properly calculate container MenuItemView widths. Bug: 801015 Change-Id: I467a39ed35a821f231042481e4c85b426dc793e6 Reviewed-on: https://chromium-review.googlesource.com/1106967Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#569120}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7c2b573628be..393d20a8e911 Created with: gclient setdep -r src-internal@393d20a8e911 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=mmoss@chromium.org Change-Id: Ic6cc63bb38bac9824e3404ba63ae63464909e414 Reviewed-on: https://chromium-review.googlesource.com/1108858Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569119}
-
David Trainor authored
This CL adds the following capabilities to the new downloads home: - A separate basic coordinator responsible for showing download deletion undo snackbars. - A DeletionController responsible for determining if deletion is allowed or not. - A file deletion queue that will erase a single file at a time on a background thread. - The proper code to the current downloads home list and glue to put it all together. BUG=850584,850583 Change-Id: I464c9aa49ea297a03b32ed65ce42bca4bb7f0dbc Reviewed-on: https://chromium-review.googlesource.com/1092015 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#569118}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 25737a75. With Chromium commits locally applied on WPT: 03ef65db "Update existing WebUSB WPT to be multi-global" 89102421 "Reland "Multi-global WebUSB WPT for window and worker"" 4d3c444f "Async Cookies: Expose additional cookie attributes." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19940 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jrummell@chromium.org: external/wpt/encrypted-media ortuno@chromium.org: external/wpt/bluetooth TBR=robertma No-Export: true Change-Id: Ifa2c545a91f5e926d423418496e867fe539f0cdf Reviewed-on: https://chromium-review.googlesource.com/1108917 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#569117}
-
Scott Chen authored
cr-input and settings-textarea contains textbox, but they are not the textbox themselves, so they should not have role="textbox". This CL removes such role so that chromevox can navigate to the contained <input> and <textarea> correctly. Bug: 853576 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2aa886e34cd8d36c631ff6b1b5a6b392b8df7199 Reviewed-on: https://chromium-review.googlesource.com/1107301Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#569116}
-
Dominic Mazzoni authored
In r566622 (crrev.com/c/1083854), I rewrote the code to compute the ARIA colindex and rowindex. The "computed" part is that you can set the colindex on the first column in a row and it propagates linearly to the rest of the cells in that row, e.g. 10, 11, 12, 13, ... The implementation was causing O(n^2) loops because each cell was checking each previous cell. Instead, cache the computed colindex and rowindex to avoid that issue. Large tables were hanging Chrome completely. Later on I'd like to move this out of Blink too - but this is a simpler fix for the moment. Bug: 852574 Change-Id: Ib011755ff256733136ba382b83b0a0100607ca49 Reviewed-on: https://chromium-review.googlesource.com/1108919 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#569115}
-
Xiaohui Chen authored
Bug: None Test: Locally build Change-Id: I110dcd953372737156882f8067e7c9188760946e Reviewed-on: https://chromium-review.googlesource.com/1109299Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#569114}
-
Alexey Baskakov authored
ChromeBrowserMainParts::PostMainMessageLoopRun() calls ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() to destroy all Ash objects before BrowserProcessImpl::StartTearDown(). Extensions perform shutdown in BrowserProcessImpl::StartTearDown(). This change allows extensions to remove observers from TabletModeClient. Bug: 812056 Change-Id: I0c96a9cee72c01ab0e4122ee811eb0535e80e7d2 Reviewed-on: https://chromium-review.googlesource.com/1107031 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#569113}
-
Paul Meyer authored
This option allows filtering of the types of reports that will be observed. https://wicg.github.io/reporting/#dom-reportingobserveroptions-types Bug: 731810 Change-Id: I027aab9f753440ba2249da027a2781baa0a1dee5 Reviewed-on: https://chromium-review.googlesource.com/1106292 Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#569112}
-
Wez authored
Bug: 750756 Change-Id: I6fac894ec5aa6ba2cb7aab58b8b1aa03769adadf Reviewed-on: https://chromium-review.googlesource.com/1108502 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#569111}
-
Fredrik Hubinette authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/f7d78b109d17..c3b8d611c12f $ git log f7d78b109..c3b8d611c --date=short --no-merges --format='%ad %ae %s' 2018-06-07 modmaker Fix reading saio/saiz for clear content. 2018-06-19 hubbe step 16 2018-06-18 hubbe ffmpeg build script changes 2018-06-18 liberato Check out toolchains 2018-06-18 hubbe minor fixes 2018-06-18 hubbe Fix include paths for mac 2018-06-15 hubbe make include paths absolute for windows 2018-06-14 hubbe simplify build_ffmpeg.py 2018-05-09 zhong.li lavc/qsv: suppress code scan complain 2018-06-08 derek.buitenhuis pixdesc: Only check against valid entries when iterating over lists of enums 2018-06-08 michael avcodec/h264_slice: Fix overflow in recovery_frame computation 2018-06-10 michael avcodec/h264_ps: Move MAX_LOG2_MAX_FRAME_NUM to header so it can be used in h264_sei 2018-06-08 michael avcodec/h264_mc_template: Only prefetch motion if the list is used. 2018-06-08 michael avcodec/xwddec: Use ff_set_dimensions() 2018-06-08 michael avcodec/wavpack: Fix overflow in adding tail 2018-04-28 cus avcodec/libzvbi-teletextdec: add support for selecting subtitle pages only 2018-06-10 ceffmpeg lsws/rgb2rgb_template: Do not compile unneeded shuffle functions on big-endian. 2018-06-04 mypopydev lavc/aacsbr: fix make checkheaders warning 2018-06-04 mypopydev lavc/dolby_e: fix make checkheaders warning 2018-06-06 ceffmpeg ffmpeg: Fail if the user requested impossible subtitle encoding. (...) Created with: roll-dep src/third_party/ffmpeg Change-Id: I9e9089f54da9c6c222a7466fb3177eb01cec1273 Reviewed-on: https://chromium-review.googlesource.com/1108543Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#569110}
-
Cathy Li authored
Bug: 852075 Change-Id: Ieb6329d57005bdba63cdf7ed1f991b5da61bb362 Reviewed-on: https://chromium-review.googlesource.com/1103138 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#569109}
-
rbpotter authored
The text color in new Print Preview's cr-dialogs should not change to the same greys as for other dialogs. Fix regression introduced by https://crrev.com/c/1102189 by overriding text color variables. See https://cs.chromium.org/chromium/src/ui/webui/resources/css/overlay.css?l=37 for the CSS that set this color in the old UI. Bug: 773928 Change-Id: Ifb4636bbe239a45c4f082a956554c94905fc266e Reviewed-on: https://chromium-review.googlesource.com/1108927Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#569108}
-
Xiaohan Wang authored
- On Linux/Mac/Win, require hardware secure codecs for HW_SECURE_CRYPTO and above. This is different than Android where we require hardware secure codecs for SW_SECURE_DECODE and above. - When there's no hardware secure video codecs supported, hardware secure decrypt-only (for audio) should also not be supported. Hence we should not add any "sucure audio decoder" in this case. - Add command line switch kEnableHardwareSecureCodecsForTesting. - Add EncryptedMediaSupportedTypesWidevineHwSecureTest to cover the fixes and the feature. Bug: 848532 Test: New tests added. Change-Id: I21f94709da5f0352ee8a6abbfa2f9a12f50b97f6 Reviewed-on: https://chromium-review.googlesource.com/1106712 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#569107}
-
Nigel Tao authored
This commit follows up https://chromium-review.googlesource.com/c/chromium/src/+/1090425 "Don't generate @see links for private externs" to, as planned in that prior commit's commit message, update other *_private.js files. This commit merely deletes some comments. It does not re-generate .js files to sync with the source chrome/common/extensions/api/*.{idl,json} files, which would possibly pick up code changes that aren't just comment changes. It appears that the .js generation is triggered manually. These URLs are 404s: https://developer.chrome.com/extensions/bluetoothPrivate https://developer.chrome.com/extensions/inputMethodPrivate https://developer.chrome.com/extensions/languageSettingsPrivate https://developer.chrome.com/extensions/metricsPrivate https://developer.chrome.com/extensions/passwordsPrivate https://developer.chrome.com/extensions/quickUnlockPrivate https://developer.chrome.com/extensions/safeBrowsingPrivate https://developer.chrome.com/extensions/settingsPrivate https://developer.chrome.com/extensions/usersPrivate These URLs are 200s: https://developer.chrome.com/extensions/developerPrivate https://developer.chrome.com/extensions/networkingPrivate However, even if the page exists, some auto-generated links refer to non-existant anchors on that page, such as: https://developer.chrome.com/extensions/developerPrivate#type-DeleteExtensionErrorsProperties https://developer.chrome.com/extensions/developerPrivate#type-ManifestError https://developer.chrome.com/extensions/networkingPrivate#type-L2TPProperties https://developer.chrome.com/extensions/networkingPrivate#type-VerifyX509 As discussed in 1090425, the tool no longer emits @see links for namespaces matching "private", even if its developer.chrome.com page exists. A new TODO was added to address this. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id24b4bcf83fdbc75c225d17c430ffc89cdf3a472 Reviewed-on: https://chromium-review.googlesource.com/1107278Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#569106}
-
Ryan Tseng authored
Bug: 840631 TBR: tandrii Change-Id: I5e2ff971583d52e3c17dfb148bed6f908d7d5b7a Reviewed-on: https://chromium-review.googlesource.com/1109308 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#569105}
-
Charlie Reis authored
Logging the SiteInstance's site URL will help clarify why the (already logged) URL was blocked. This also logs default values for origin lock and site isolation mode in case those strings are empty. BUG=840857 Change-Id: I260bdf5960146a2c8fcab7d3daa56ba9bfa0d05f Reviewed-on: https://chromium-review.googlesource.com/1108968 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#569104}
-
Brandon Jones authored
Adds environmenBlendMode attribute to XRSession. Currently relies on the XR Hit Test flag to determine if the mode is something is other than "opaque" because that's the only signal we have for now. Should ultimately communicate this from the browser side so that devices can report their optical properties on a case-by-case basis. Bug: 854284 Change-Id: I13f3f41d104e017b087a32b32f3d00686513f9f1 Reviewed-on: https://chromium-review.googlesource.com/1109261Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#569103}
-
Muyuan Li authored
Bug: b:77916222 Test: Manual Change-Id: I8d12eb12c6026a862c4546456f38ec943bd2e30d Reviewed-on: https://chromium-review.googlesource.com/1056298 Commit-Queue: Muyuan Li <muyuanli@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#569102}
-
Robert Sesek authored
A detached signature is created by codesign(1) when the signed artifact is not Mach-O, so the resulting signature cannot be placed in the LC_CODE_SIGNATURE command. Instead, the signature is detached into the _CodeSignature/CodeSignature file on-disk. This also updates the testing codesign certificate used for the safe_browsing/mach_o test data, since new test data needed to be generated. The existing test data were not re-signed with it, however. Bug: 826761 Change-Id: Ied0e96b3b0079b86679724b08aa46bf8d2669a94 Reviewed-on: https://chromium-review.googlesource.com/1101842Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#569101}
-
Johann authored
https://aomedia.googlesource.com/aom.git/+log/cc92258a08d9..c5a56b99df86 $ git log cc92258a0..c5a56b99d --date=short --no-merges --format='%ad %ae %s' (...) Created with: roll-dep src/third_party/libaom/source/libaom As part of the roll we must update the colorspace signaling. Originally added to libaom in commit 9e69463febe0ee8525cb5a99ee5f9f11286581f1 Author: Andrey Norkin <anorkin@netflix.com> Date: Thu Dec 21 18:50:57 2017 -0800 CICP colorspace signaling Monochrome is signaled outside of CICP: commit f340fece2c18f068dc3c0c9219b2e5a5eee7ba79 Author: Debargha Mukherjee <debargha@google.com> Date: Wed Jan 10 18:12:22 2018 -0800 No colorspace for mono-video f/ CICP compatibility BUG=aomedia:1673 And remove references to the deadline parameter. BUG=aomedia:13 Updates bear-av1.webm and disables bear-av1.mp4 test. ffmpeg muxing of av1 in mp4 has not been upstreamed yet. The webm file was generated with the av1 tree in this update. vpxdec media/test/data/bear-vp9.webm -o bear.y4m aomenc -o bear-av1.webm -p 2 --target-bitrate=150 \ bear.y4m The I frame for the AV1 test is generated with: aomenc -o bear-av1.webm -p 2 --target-bitrate=150 \ bear.y4m --limit=1 --ivf And then a hex editor is used to remove the 32 byte file header and 12 byte frame header. BUG=chromium:783519 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0b89285155e286f921448b221a491f9ed24cfd6e NOPRESUBMIT=true (due to presubmit confusion about relative paths in DEPS) Change-Id: I0b89285155e286f921448b221a491f9ed24cfd6e Reviewed-on: https://chromium-review.googlesource.com/1101705 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#569100}
-
Tom Anderson authored
This fixes the build with compute_grit_inputs_for_analyze=true which regressed after CL: https://chromium.googlesource.com/chromium/src/+/93e774da116cc1bce515883fc28f012ccd905635 BUG=853961 R=dpranke Change-Id: I48e9297107cc0e543f00f1d6fa7e347bc39e5de3 Reviewed-on: https://chromium-review.googlesource.com/1105485Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#569099}
-
Krishna Govind authored
R=amineer@chromium.org Cq-Include-Trybots: luci.chromium.try:closure_compilation;luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib81c711fa774a279fc7c672e8ca550c3ccb627ca Reviewed-on: https://chromium-review.googlesource.com/1109398Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#569098}
-
dpapad authored
This CL simply updates the string to be displayed. Updating the backend to actually sign-out will happen in a follow up CL. For consistency this also updates the sign-out dialog title for non-Dice to also have a question mark. Bug: 852000 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I0bef12f08d0f89c685b9ce9ee20547b4fe00c76b Reviewed-on: https://chromium-review.googlesource.com/1107300 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#569097}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c4424eb6803d..5831b835bc15 git log c4424eb6803d..5831b835bc15 --date=short --no-merges --format='%ad %ae %s' 2018-06-20 dgarrett@google.com chromeos_config: Create master-incremental. 2018-06-20 vapier@chromium.org pylintrc: enable bad-builtin for apply & input 2018-06-20 vapier@chromium.org pylintrc: stop disabling exec-used 2018-06-20 dgarrett@google.com builder_status: Remove config_lib.UseBuildbucketScheduler. 2018-06-20 dgarrett@google.com cbuildbot/stages: Remove config_lib.UseBuildbucketScheduler. 2018-06-20 dgarrett@google.com simpler_builder: Remove config_lib.UseBuildbucketScheduler. 2018-06-20 dgarrett@google.com repository: Log cleanup methods. Created with: gclient setdep -r src/third_party/chromite@5831b835bc15 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:851183,chromium:None,chromium:None,chromium:853025,chromium:853025,chromium:853025,chromium:853949 TBR=chrome-os-gardeners@chromium.org Change-Id: Ib0d09c8c2eb5246e5e9e7eaa7011ca8f33d7d333 Reviewed-on: https://chromium-review.googlesource.com/1109097Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569096}
-
- 20 Jun, 2018 1 commit
-
-
Robert Liao authored
This moves the code into the toolkit_views source list and gates Aura specific code behind build flags. Additionally, this links up DesktopMediaPicker::Create in a manner similar to ScreenCaptureNotificationUI::Create[Cocoa]. BUG=726005,657883 NOAUTOREVERT=true Need to investigate any failure on the Mac Bot. Not reproducible locally. Change-Id: I9ece0b875268495d70154378c7608c3e1bae2938 Reviewed-on: https://chromium-review.googlesource.com/1102042 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#569095}
-