- 12 Nov, 2019 40 commits
-
-
Mikhail Khokhlov authored
Bug: 981349 Change-Id: I85bd9eea5a612cb5aaa6c519c8750a79505007c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911785 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#714519}
-
Andrey Kosyakov authored
Bug: 1022937 Change-Id: Iacbda3b8a13f41760c74c252fb71bccc0ac66e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906939Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#714518}
-
Jasper Chapman-Black authored
* Add DiffSizeInfo, with logic for matching up symbols from two loaded SizeInfos. This doesn't yet consider the new native and Java canonical name processing code, but the boilerplate is there. * Add scaffolding in caspian_web.cc to support diffing. * Add async waits in .js to avoid attempts to call WebAssembly code before module is loaded. Bug: 1011921 Change-Id: Ia121e78fd5c8c2d7e07c53de345e53e9fa80d88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906109 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#714517}
-
Mikhail Khokhlov authored
Stop checking for aggregated trace from telemetry, and stop uploading diagnostics artifact. Bug: 981349 Change-Id: I045e97ce875751b3621177bac1a38949cb1272c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911745 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#714516}
-
Owen Min authored
BrowserDMToken contains a string and an enum. It should be able to be copied and moved as a normal string. Explicitly declare copy and move constructor and operator. Also move the factory function declaration to the top of the class. Bug: 1020296 Change-Id: I401812b07db1bd2801a4133cb67592f9ef4bc6d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906477Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714515}
-
Cliff Smolinsky authored
This change fixes multiple issues with the process-internals page when viewed in high contrast. Specifically, the header background and tree highlight colors are fixed. See the bug for screenshots. Bug: 1023585 Change-Id: I6405e8b02c5020eb64d3aff93c564ab20a613ef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911482Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#714514}
-
Michael Crouse authored
Bug: 1022625 Change-Id: Idd906b79dda4ee54df7d743ceb52ddfe4f2447ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907313 Auto-Submit: Michael Crouse <mcrouse@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#714513}
-
Jit Yao Yap authored
Change-Id: Id1b567b87d88d3f3c29403ad9ec0c794ab9c9fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911794Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#714512}
-
Oriol Brufau authored
Calculating the used sizing function for a track is not a very expensive operation, but it's not trivial either, and the track sizing algorithm needs to access sizing functions all over the place. This ends up having a performance cost, especially for spanning items. Intrinsic contributions from items that span a single track are handled in a simpler way than when the span is greater than 1. In the former case, SizeTrackToFitNonSpanningItem only calculates the track sizing function of each track once per each item in that track. But in the latter case we not only calculate the track sizing function of multiple tracks per item, we also repeat this 5 times in order to handle the various TrackSizeComputationPhase. Therefore, to increase performance, this patch caches the used track sizing functions in the tracks themselves. This improves the auto-grid-lots-of-spanning-data perf test by 40-50%, nested-grid by 10-15%, and auto-grid-lots-of-data by 5-10%. Bug: 1021929 Change-Id: I4309629bfed28a78421889d157251643efc06b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901292 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#714511}
-
Theresa Wellington authored
Disable flaky #testStartWithUrlRecorded and #testFromExternalAppRecorded on O+. BUG=1023433 TBR=alexilin@chromium.org Change-Id: Ic3111d8cdd1af44003b3ffc6e211d330583b222f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911702Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#714510}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bd27b14638e4..051cae5d11be git log bd27b14638e4..051cae5d11be --date=short --no-merges --format='%ad %ae %s' 2019-11-12 mbonadei@webrtc.org RTC_EXPORT IceServer, StatsReport::{IdBase,Value}. Created with: gclient setdep -r src/third_party/webrtc@051cae5d11be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Id5b23ba12d551f053a7ed5a476775e5cc8dbeda5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910796Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714509}
-
Theresa Wellington authored
BUG=1023833 TBR=wychen@chromium.org Change-Id: If741c0f5a81d87fde4a0262067ece9cb0b6427c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912088 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#714508}
-
Mohamed Heikal authored
This cl adds a presubmit warning on upload if the CL contains images. The warning points the author to //docs/speed/binary_size/optimization_advice.md#optimizing-images so as to ensure they have read the optimization tips and tried applying them to their images. There is no easy way to check if the image is optimized thus the presubmit always fires if there are images but does not block CQ. Bug: 921227 Change-Id: Ib8dd144bd2f728b166ca5b1c9d3882df24e0216b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899645 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#714507}
-
Elly Fong-Jones authored
The symbol is no longer present at all; just hack use of it out for now. Bug: 973128 Change-Id: I39bc4fcfa6a734ac47e2a5237eb35e53a7a6370d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906333Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#714506}
-
Vincent Boisselle authored
Bug: 1023825 Change-Id: I2304c6085c39dfdbbb412b68d7beea017cc8d924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911000Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#714505}
-
Evan Stade authored
Also remove obsolete NotificationService includes from //chrome/browser/ui/webui/settings/ Bug: 268984 Change-Id: I2c5cf6e456965f6d98c844bf8c81c423add00c1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891737 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#714504}
-
Evan Stade authored
Bug: none Change-Id: I5bde1554a5f403ccfa99ab0851be2978dec81846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904750 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#714503}
-
Joe Mason authored
These no longer need to be in the shared components/chrome_cleaner directory because new versions of Chrome do not use them to communicate with the cleaner. The cleaner itself still needs to build against them so that the cleaner can communicate with older versions of chrome that set kChromeMojoPipeTokenSwitch on the command-line. Also split out FilePath, RegistryKey and ExtensionId into a new footprints.mojom interface, to eliminate some bogus dependencies on chrome_prompt.mojom. R=proberge Bug: 969139 Change-Id: Ib6f5b2dbf6f08d389453bcea86d52cdc5b078bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903956Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#714502}
-
Pavel Shmakov authored
Discussion: https://docs.google.com/document/d/1M-ocVxRpj43fGrM4mdBazEgcDa0nbWPxD_NxfsPnrkg/edit?ts=5dc96bc9 This CL implements the short-term solution, i.e. only an onRenderProcessGone callback. Change-Id: I51cf71975db4d72e940e15b5f2acca6cde3ff4a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901083Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#714501}
-
Matthew Jones authored
Bug: Change-Id: If7d4dfd554bb9224f3f12266f1bfdab99040225e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910802 Auto-Submit: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#714500}
-
Manu Cornet authored
Change-Id: I4ab18dcab81d8622a52b9b744bd7aa57ae1693da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911220Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#714499}
-
Denis Kuznetsov authored
Bug: 1023370, 852557 Change-Id: I2d859e6f38f494ad15293939d322a31cc0ac567d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911216Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#714498}
-
Mathias Carlen authored
Before this patch, three different activity types were tested in the same test. That resulted in the activities to interfere with one another. This patch splits the tests up into one test file per activity. R=szermatt@chromium.org Bug: 1018183 Change-Id: Ie09202e9ac69e96ac207ffe3f43b4e00e592d343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910088Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#714497}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e8fc00fb..5bd261c7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic37aee1120a6706c570d556eb1839c825092b5cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911245Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714496}
-
kylechar authored
Ensure the GPU thread task to schedule DC overlays runs after the mailboxes have been mapped to textures. Bug: 1003040 Change-Id: I0a5a8b4ce1c24d8b64fbb600092703e5e8a2d136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907193 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#714495}
-
Kai Ninomiya authored
- New styles from upstream to fix text wrapping. - Add the tests that require glslang. They still won't run - they automatically skip themselves since the glslang dependency is not available. Soon I'll replace this file with a similar auto-generated one. Bug: None Change-Id: I60c64eddce0030a41bf3bb4d97cd8fdaed4905c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906371Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#714494}
-
W. James MacLean authored
This test flakes regularly on Kitkat, less often on marshmallow. TBR=jianli@chromium.org Bug: 1022322 Change-Id: Idca960761c3a4a56fdd2027b79a53943fe07199e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911390Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#714493}
-
Tobias Sargeant authored
In the case that CrashpadHandlerMain is not an exported symbol we should fall back to using the java crashpad launcher. Also check that the trampoline binary exists. Bug: 1022837 Test: manual; install a non-trichrome webview on Q, and check Test: that a minidump is captured. Change-Id: If397fd805a25f73aa4a54e728670d1943cb188e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906350Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#714492}
-
Gauthier Ambard authored
This is needed to be able to use this file from ios/web. Bug: 901082 Change-Id: I893360bab6226212780ebf7d4eb186737936db92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911742 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#714491}
-
Josh Nohle authored
We also add the function ShouldDeprecateV1DeviceSync for future use. We adjust the DeviceSync service unit tests to check the Chrome OS feature flags. Bug: 951969, 1019206 Change-Id: I5cd8de6521131cf1cca672f4dc7b6115f93cd06a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907834Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#714490}
-
nancy authored
Design doc: go/appservice-for-per-app-time-limit-design-doc This CL implements the interface: PauseApps RecoverApps This CL also implements the App Pause Dialog. To make AppServiceProxy more clean, PauseApps's parameter "PauseData" is defined in PauseDialog, as that is used for the App Pause Dialog. The App Pause Dialog should be similar to the Uninstall Dialog. Based on the requirement, the App Pause Dialog should be implemented for the ARC running apps only. The app running checking will be added in a separate CL. BUG=1011235 Change-Id: If2811f9722ce18494418f3a1c7ff0f12c951b599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899629 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#714489}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9da287fd0264..371316798c01 git log 9da287fd0264..371316798c01 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 sugoi@google.com Blend mode fix for 565 format Created with: gclient setdep -r src/third_party/swiftshader@371316798c01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/24332884 Change-Id: I4726090c410a98d65dec6f1c5dc30f7a2a9f4dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910793Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714488}
-
Ian Kilpatrick authored
We had an issue in the existing invalidation code when an object could contain an OOF-positioned node, but wasn't a LayoutBlock. This already happens when we have a LayoutInline being a containing-block, but there are other cases where this is true. Clusterfuzz found that LayoutTableSection falls into this category. E.g. The OOF-positioned node would be inserted into the nearest containing-block (the anonymous LayoutTable in this case). When it stopped being a containing-block, the OOF-positioned node was never removed from the LayoutTable. This caused a crash when the OOF's layout was invalidated. The OOF marked itself, and the LayoutView (its new containing block) for layout. But the LayoutView didn't know it had this as an OOF-positioned child. This patch moves the current logic within LayoutBlock into LayoutBoxModelObject. Bug: 1021491, 1021676, 1022545 Change-Id: I0f0b4c8aa655fc7edca5d79379205a8d445713d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906708Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#714487}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ed16d1d29e2f..a9c64739fb43 Created with: gclient setdep -r src-internal@a9c64739fb43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I9335950b8723dce0baccc2bc9bb224f280e7b265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910792Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714486}
-
Stephen Chenney authored
This patch adds UMA metrics to match the recently added information in UKM, allowing the Rendering Core team to track their contributions to First Contentful Paint. Bug: 1001199 Change-Id: I4a6a4779a4fadf8a71d9e69eaedbe826a3dbb9f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901429 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#714485}
-
Liquan (Max) Gu authored
This patch adds a toolbar to the Bottom-sheet based Payment handler. The features of the toolbar includes: * origin: shows the origin of the payment app url (with the scheme) * title: shows the payment app title * progress bar: shows the load progress of the payment app * security icon: show 3 different icons based on the security level. Because of its resemblance with the ephemeral tab toolbar, we reuse the ephemeral tab toolbar's layout but implement it with different controlling logic. Note that the above features support redirect. Whenever the payment app page redirect, these features would get updated to match the current page. The progress bar updates the load progress whenever receiving web-contents' progress-updating callback. It get hidden once the progress reaches 100%; it shows up again once the progress turns below 100%. Bug: 999196 Change-Id: Ifaf9e971256ff82888176623b3a4b51749246a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901639Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#714484}
-
Andreas Haas authored
We change the type of the size field of a DOMArrayBuffer to size_t to allow bigger DOMArrayBuffers eventually. This CL introduces new getters for the size field, {ByteLengthAsSizeT} and {ByteLengthAsUnsigned}. {ByteLengthAsUnsigned} replaces the current {ByteLength} implementation and still returns an {unsigned}. There is a CHECK for potential overflows. This function is deprecated and should not be used anymore. Instead, {ByteLengthAsSizeT} should be used. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I13dea548c5eae6b46530e49ef51fbb366438e4a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910091 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#714483}
-
Elly Fong-Jones authored
This one is easy: TabHoverCardBubbleView recreates its footnote view whenever the footnote view's state changes anyway, so simply don't create it in the constructor at all. Bug: 1011446 Change-Id: Ia195f28d48dd3a76897c3f466476aaf78a8c13bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910422Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#714482}
-
Joe Mason authored
R=proberge Bug: 1023545 Change-Id: Icc7f7ed30ba4ac51fbf5725e61cfafeb2aebe150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906475Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#714481}
-
Philip Rogers authored
Trivial 3D transforms are not considered direct compositing reasons when the DoNotCompositeTrivial3D experiment is active (see: CompositingReasonFinder::RequiresCompositingFor3DTransform). This has caused a performance regression on top sites (google.com and many others) where we no longer use composited scrolling. This change continues to use trivial 3D transforms as a reason for composited scrolling. Bug: 1012775 Change-Id: Ibef9b9b3de4d57afe30d0fc3dc75da29855b7deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907415Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#714480}
-