- 17 Jul, 2020 18 commits
-
-
Zhongyi Shi authored
A bunch of other components now need explicitly include the dependency. Bug: 1104380 Change-Id: Ia272d1cae50fdc13f4a38c3448e3abf71bb9cceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298724Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#789290}
-
Brian Sheedy authored
Targets Mac 10.15.5 in addition to 10.14.6 for the GPU Mac Intel Stable mixin in preparation for the OS upgrade. Submitting with no-try due to crbug.com/1106559 blocking submission otherwise. TBR=ynovikov@chromium.org No-Try: true Bug: 1078489 Change-Id: I4d0dd92d805a2a2cf6e5355012b6f4b4e83884ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302923 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#789289}
-
Tom Anderson authored
X11 cursor handling is annoyingly all handled client-side, so we need to reimplement libxcursor, including reading and parsing the cursor images from disk. Since new usages of base::ReadFile() are added, cursor reading cannot be done on the UI thread like it was previously. This means every cursor needs to be async, which adds quite a bit of complexity. BUG=1066670 R=nickdiego,sky Change-Id: If63be11bda34c04c56c52085453abbda0ef553bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293616Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#789288}
-
Tom Anderson authored
BUG=1066670 R=sunnyps Change-Id: Icc189028b7d7630d398b1efe7ff55110913d0e48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302735 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#789287}
-
Andrew Xu authored
This CL applies a special rule on Files Manager to ensure that its first context menu item is "New window". A browser test is created to protect this feature. Bug: 1102781 Change-Id: I5de587e6d15f377d2b43fffd8d963437f8f41640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295931Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789286}
-
W. James MacLean authored
The third CL in implementing origin-/site-keying of SiteInstances. https://crbug.com/1085275/#c2 lists the sequence of CLs and what each will accomplish. This CL replaces uses of site URL as map keys with SiteInfo in BrowsingInstance and RenderProcessHostImpl. As a result, maps will be able to distinguish SiteInfos based on additional criteria, such as site vs origin keying. Bug: 1067389, 1085275 Change-Id: Iae821dfb6314968fbe059732ff3c97e84add4212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261216 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#789285}
-
Wei Li authored
Also fix the section title style in theme_aware.md to be consistent. Original Author: tluk@ Bug: none Change-Id: I54b113efb27ec2e98026765c2b11c0bb6e3d2385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297736 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#789284}
-
Alexander Cooper authored
The BrowserList::CloseCallback is potentially called multiple times (for each browser window that is closed), and thus it is explicitly converted to a RepeatingCallback. Note that this change is working towards cleaning up the files at the root of chrome/browser, and as such it does *not* fully convert either BrowserList nor other items that pass in CloseCallbacks, except for unload_browsertest which is at the root of chrome/browser. Bug: 1007635 Change-Id: I81525c00814c59db6b0aceee0e31588062b2775c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302937 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
-
Arthur Wang authored
Bug: 1060399 Change-Id: I05e41fa3b48352ddc37b7ccb39d73ac481cf1c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302917 Commit-Queue: Arthur Wang <wuwang@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#789282}
-
Nate Chapin authored
Change-Id: I7abee88a5214a4e7a0a0680e4e46f80ece3f9182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298174 Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#789281}
-
Scott Violet authored
This test is still mildly flaky. The issue is that while it waits for a non-empty paint, this is not always enough. This makes the test additionally wait for loading to complete and more importantly, waits for a visual update. The latter is a good signal the renderer will actually process events. BUG=1091129 TEST=test only change Change-Id: Iabc6d2dce83985086c56db916c8cc273e3ed65f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303554Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#789280}
-
Nodir Turakulov authored
Update both metadata-exporter and linux_chromium_component_updater builders to NOT be tree closers. Update metadata-exporter builder to be triggered by commits (contiuously), as opposed to periodically. Remove all default notifications from these builders because these are very specific builders and the people notified by default don't have the context. Bug: 1106554 Change-Id: Ib5068ff16b6be2c3f00e354b7c9b2dda6162e8b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303600 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#789279}
-
Mohsen Izadi authored
This enum value is not set anywhere (I believe since r414750) except in some tests. Bug: 1100977 Change-Id: Ib643ca350704ba240057b097379b415b299a0afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274168Reviewed-by:
-
Xing Liu authored
This CL fixed an issue in download location prompt status metrics, also adds a metrics for download later prompt status. Bug: 1106094,1078454 Change-Id: I17af189721e840a5e29ee7fc89e02506b2b9b689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300806 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#789277}
-
wutao authored
Bug: b/160753530 Test: manual Change-Id: I4edae4b329f17919ad25aca3800adf79861e6f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287273Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#789276}
-
Mark Yacoub authored
Put all config requests into a vector and move them together. Change the callbacks to handle all displays configured together rather than one display at a time. BUG=1082882 TEST=no changes enabling and disabling displays, display_unittests. Change-Id: I36859414e1e31e8411f67bac0c3609696cabeece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237653Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Auto-Submit: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#789275}
-
Alexander Cooper authored
The ActiveModalDialogListener outer callback is explicitly called multiple times, thus requiring conversion to RepeatingCallback. the inner closure is also stored as a RepeatingClosure by the only place that creates an ActiveModalDialogListener, so is similarly converted. This change also converts chrome_browser_main's base::Binds, as the only consumer of ActiveModalDialogListener. Bug: 1007635 Change-Id: I49e4a2ba9772919e57c448e08bba57e6c8a32b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299191 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#789274}
-
Jeff Yoon authored
iOS14 tests to execute on chromium.tests.ios14. Bug: 1101531 Change-Id: I8fee379d472ed05c73eeed75b8bf6f50b83a1694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295788Reviewed-by:
-
- 16 Jul, 2020 22 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic84fbe38d12071933410a43d4ca63b64d07e02c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303561Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789272}
-
Jonah Ryan-Davis authored
This was fixed within ANGLE Bug: chromium:1099763 Change-Id: I4398cc7178ceaa05e9000668b04c5501daeea55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302411Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#789271}
-
Sven Zheng authored
Bug: 1104291 Change-Id: If1535212a0a931b0e7477ff91b60d5a3ecbd0efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303456Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#789270}
-
Guillaume Jenkins authored
Refactors the SetAndroidAppInfos method out of ReportGenerator and into a new delegate class, in preparation for moving ReportGenerator to components. Note that the ReportGenerator constructor uses the desktop factory directly, because the base factory can't be used until ReportGenerator is moved to components. #Squeegee Bug: 1092425 Change-Id: Iff4a273f752cc286ac5654c3520c00cd1c31f14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296578Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#789269}
-
Dirk Pranke authored
We no longer have separate test-type-handling logic for CTS tests and instrumentation tests; instead, they emulate and are treated as gtest-based tests by the infrastructure these days. This CL updates the //testing/buildbot/README.md documentation and the generator code accordingly. Bug: 816629 Change-Id: I56d646cab293dcd9e59209d80d6fa016fd1d5ffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303773 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#789268}
-
Christian Biesinger authored
R=ikilpatrick@chromium.org Bug: 1098475 Change-Id: Ibe99426f1737841957b7f6611bcab70228724786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261875 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#789267}
-
Hesen Zhang authored
UnifiedAutoplaySettingBrowserTest.Block Failed on several bots. List of failed builders: Builder: Win10 Tests x64 https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64 First failing build: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/b8874594547915853472 -------------------- Builder: Win10 Tests x64 https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64 First failing build: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/b8874585376703011824 TBR=sergeyu@chromium.org Bug: 1106521 Change-Id: I55eaa23c2bd01d4dc03cdfbef6fe4090866d6f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303457 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
-
Chris Lu authored
Bug: 1100696 Change-Id: I44136dfd61e8ab7d1fc64020d51854adaad68377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283893Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#789265}
-
Sahel Sharify authored
Flake Portal: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUAsSBUZsYWtlIkVjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFNTTFVJVGVzdElnbm9yZUNlcnRFcnJvcnMuU3ViZnJhbWVIYXNDZXJ0RXJyb3IM TBR=estark@chromium.org Bug: 1106370 Change-Id: Ibee02ba23881f78b28c27e3652ccbf60fa7a6f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303055Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#789264}
-
Clark DuVall authored
Follow up to https://crrev.com/c/2289191. This callback is only used in tether code as an error callback. This change moves the callback to TetherDelegate and renames to StringErrorCallback. Even though this is mostly used in chromeos/components/tether, it can't be defined there since chromeos/network can't include code from there. Bug: 1007660 Change-Id: I882d25857afdcc2b86a9cae4f146032603b6d40f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303871Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#789263}
-
Thomas Guilbert authored
This CL relands "Deflake preservesPitch tests", which was reverted by: commit f19f3404. It also attempts to incorporate some of the WPT changes made upstream, but not yet landed, in: https://github.com/web-platform-tests/wpt/pull/24599 Specifically, it fixes typos in the Safari prefixes, and explicitly starts the audio context. However, it is different from the PR, since it reuses the same Audio element, MediaElementAudioSourceNode and AudioContext. This is an attempt to cut down on overhead costs and fix test timeouts. We instead reset the audio.currentTime to 0, and only create a new analyser node for each test. Bug: 1105877, 1096238 Change-Id: Ie528ec0b7c38d9df59fcb04696c810e6d1c232f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300929 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#789262}
-
Torne (Richard Coles) authored
These cases were converted to use PostTask some time ago, but because the PostTask queue is managed in native (once native is initialized) this means that uncaught exceptions cause native crashes instead of being reported as Java exceptions. Use AwThreadUtils to make it clear that posting directly to the Android looper is intentional. Change-Id: If7dcf8b98bb42886d02532a9d27eafcc58bab829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302945 Auto-Submit: Richard Coles <torne@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
-
Chris Sharp authored
Change "a search engine" to "the search engine " to provide better consistency (since "a" was only used once). Change-Id: If001c447bbc9c5d88a841fb8eb1bc69b6053114d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298102Reviewed-by:
-
Ryan Harrison authored
https://dawn.googlesource.com/tint.git/+log/919011af0a2a..5f43fedcddba $ git log 919011af0..5f43fedcd --date=short --no-merges --format='%ad %ae %s' 2020-07-16 dneto [spirv-reader] Handle gl_Position 2020-07-16 rharrison Clean up how deps are defined in BUILD.gn 2020-07-16 dsinclair Remove refs.cfg. 2020-07-16 dsinclair Fixup group list name 2020-07-16 dsinclair [msl-writer] Emitting of program constants. 2020-07-16 dsinclair [msl-writer] Fixup matrix and array constructors. 2020-07-16 dsinclair Differentiate size and stride in array type name. 2020-07-16 dneto [spirv-reader] Support duplicate type definitions 2020-07-15 dsinclair [msl-writer] Add struct offset support. 2020-07-15 dsinclair [msl-writer] Add builtin support 2020-07-15 dsinclair Add helpers for referenced variables. 2020-07-15 dsinclair [msl-writer] Refactor some entry point variable code. 2020-07-15 dsinclair [msl-writer] Generate entry point functions. 2020-07-14 dsinclair [msl-writer] Handle emitting user function calls. 2020-07-14 dsinclair Inherit refererenced globals up the call stack. 2020-07-14 dsinclair [msl-writer] Generate input/output structs 2020-07-14 dsinclair Add determination of entrypoint callees. 2020-07-14 dsinclair Update cube example Created with: roll-dep src/third_party/tint/src Change-Id: I06b16721427a141dee1b101e23bb36e47c09f836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302926 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#789259}
-
Alexander Cooper authored
Converts Callbacks used by the *process_singleton* classes to Repeating Callbacks. Most callbacks are obviously (at least potentially) called multiple times; however, the ShouldKillRemoteProcessCallback appears to only be called once, as a result of PreMainMessageLoopRun. Despite this, this change opts to make it a RepeatingCallback as nothing in its usage would prevent it from being called multiple times and it appears to only be a callback (instead of a direct method call), so that the behavior can be overridden by tests. Additionally, converts base::Binds used by the *process_singleton* classes where the consuming API has been updated to take a particular type. After this change the *process_singleton* files should be clean of any base::Bind(, base::Callback<, and base::Closure calls. Bug: 1007635 Change-Id: Ifbf9fc165e063440f4f6ac3212f0cd403f70dfa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296637Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cab02df7a5c5..c4c3be736312 2020-07-16 dproy@google.com Merge "metrics: Allow chrome metric protos to be compiled in" 2020-07-16 lalitm@google.com amalgamated: use the toolchain script to find clang If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iec1a128013b1766c204c89bb08f156114af3453a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303122Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7fe0359130f9..442d424a7287 2020-07-16 reed@google.com Revert "Serialize mipmaps" 2020-07-16 michaelludwig@google.com Fix GrTAllocator tests 2020-07-16 brianosman@google.com Make invokeChild default to fInputColor, rather than half4(1) 2020-07-16 bsalomon@google.com Consolidate sampler->index/key conversion 2020-07-16 herb@google.com reorganize GrAtlasTextOp creation 2020-07-16 adlai@google.com FIx imagemakewithfilter test in OOPRDDL config 2020-07-16 egdaniel@google.com Use staging buffers in d3d for texture uploads. 2020-07-16 herb@google.com simplify GrAtlasTextOp's onPrepare 2020-07-16 reed@google.com Serialize mipmaps 2020-07-16 brianosman@google.com Remove modulation by input color in GrTextureEffect 2020-07-16 elliotevans@google.com Add Puppeteer perf for release and experimental_simd builds of CanvasKit against SKPs 2020-07-16 rmistry@google.com Add canary roll CL link to canary task driver 2020-07-16 mtklein@google.com support 64-bit gather() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I4e0a5326bc6fe8315b75422645d7694fbc8c1905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303610Reviewed-by:
-
Greg Thompson authored
This CL includes: - Some gentle style updates. - Explicit extraction of only one file. - Use of SetFileInformationByHandle to set the creation time and attributes of the output file before closing it rather than use of SetFileTime and SetFileAttributes after the fact. This avoids potential filesystem races. - Removal of some dead code. BUG=None Change-Id: Iaa27f6951a96fc5cec55fa9b0cd8505f48f2515e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303710 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#789255}
-
Yuke Liao authored
This CL adds functions to download the latest or any given version of ash-chrome. Bug: 1104318 Change-Id: I32da0de5d590586a4c47f55c93fc004e00ce70af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302931 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789254}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I9b7d8ae2b062e8f030c01ab8d6b1024c1cd348aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303105 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Chris Lu authored
Adds a config for the FullscreenControllerBrowserScoped flag. Bug: 790886 Change-Id: Ibbb765e6d7affa49bde4afc8effefdce48da94a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299236Reviewed-by:
-
Sophey Dong authored
Screencast: http://dr/file/d/1eBuaixYJ1kbutQBpT4bCTlyjHY66OeLP/view Screenshots: http://screen/PebTHg6AOTm, http://screen/2SoE6iSFJ3a Finch param command line test flags: -enable-features="SharingQRCodeGenerator<MyStudy" --force-fieldtrials=MyStudy/Group1 --force-fieldtrial-params=MyStudy.Group1:max_url_length/300 Bug: 1105139 Change-Id: I3277f02ac35bcb94d998c8a7c37b1becc26eee79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299462Reviewed-by:
Travis Skare <skare@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#789251}
-
