- 06 Jan, 2020 40 commits
-
-
meacer authored
This CL adds a list of Greek characters that look like Latin characters. A domain consisting only of these characters and not having a .gr ccTLD or other Greek TLDs such as .ελ will be converted to punycode, as is done for other whole-script-confusables such as Cyrillic and Hebrew. Bug: 722167 Change-Id: Id0157503c605a6a73eb49147c26b48d5995d1ff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986209 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#728697}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1ca8124e..fcd83e09 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I67867d71115b2a60146664a01a795273aa85ba3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988680Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728696}
-
kjd564 authored
Recent changes to the scheduler have revealed a race condition with this benchmark. This benchmark is triggered when we do a frame and DidUpdateLayers is called. After the benchmark completes, the impl will schedule a NotifyDone task on the main thread and the results will be recorded when that task is run. The change made in the scheduler will prioritize BeginMainFrame at set intervals. What was happening in the regression was a race condition between NotifyDone and the next frame. If a frame was run before NotifyDone, it would trigger DidUpdateLayers and the benchmark would run a second time, adding its results to the previous runs results, effectively doubling them and causing the benchmark results to oscillate between two ranges of timing. This change fixes this by checking a boolean that tells us whether the benchmark has already been run before running it. Bug: 1030954 Change-Id: Iade1bc20c0cc43e643293f23a631c11c3ff9653e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986970Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#728695}
-
Dave Tapuska authored
Reland 547be407. It was previously reverted because CFI bot started to fail. That was fixed here: crrev.com/2708646c Since the class is no longer memcopied between processes we can use virtuals. - Add virtual destructor - Add pure virtual cloning - Remove memset - Remove size attribute BUG=836826 TBR=nasko@chromium.org,bokan@chromium.org,jbroman@chromium.org Change-Id: I091683184ada8d693c11f8cb7aff9dae3eaf93e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988849Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#728694}
-
Tarun Bansal authored
Add a new field trial param to the config. The param was added to Chromium in M-80. Change-Id: I2532c680e24456cda42a10ee2e0cde3df6dc6a92 Bug: 983721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988207 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#728693}
-
jongdeok.kim authored
This CL makes omnibox clear input text while reloading current page by context menu. Bug: 583241 Change-Id: I8e14a781bf03e239913aac7c3d9b85a71e50fa11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984788Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#728692}
-
Ken Rockot authored
Migrates some directories off of deprecated base::Bind, base::Callback, etc, and onto the newer APIs. Specifically this covers: - components/metrics/ - components/metrics_services_manager/ as well as the minimal set of dependent client code to keep everything compiling. Fixed: 1007701, 1007702 Change-Id: I42231f52b33478d4e874b0ecd96d1a4ccab5313f Tbr: siggi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977854 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#728691}
-
Sophie Chang authored
Code to even log this from Previews land was removed in M79 Change-Id: I649467f73f909f73cba940f32710196ab2807023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988852Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
-
Connie Wan authored
Remove the ShouldPaint logic in TabGroupView because it's already handled in TabStrip::PaintChildren(): https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab_strip.cc?l=2088&rcl=2170efeafe8ee9cafa678d8d1bae67f8182798a8 Also simplify TabStrip::StoppedDraggingView(), which was handling group headers in a hacky way. The group header handling is now more explicit and separate from the deleted-tab logic. Bug: 1034169 Change-Id: I7e87387e6cb89863cb6a0d4b5b706c3ef14d780e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988678 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#728689}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/87d31381588b..96f79f6db56b git log 87d31381588b..96f79f6db56b --date=short --first-parent --format='%ad %ae %s' 2020-01-06 cwallez@chromium.org Validate SetVertexBuffers' slot is less than kMaxVertexBuffers Created with: gclient setdep -r src/third_party/dawn@96f79f6db56b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1034808 Tbr: cwallez@google.com Change-Id: I8ba4473774276100387884943231025378eb17dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988264Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728688}
-
Emily Stark authored
This CL short-circuits OmniboxViewViews::UpdateSchemeStyle() for non-https/https URLs. Before a recent change (https://chromium-review.googlesource.com/c/chromium/src/+/1986189), this would have been a no-op. UpdateSchemeStyle() already short-circuits when the security level is NONE or WARNING, and non-http/https URLs are set to NONE or WARNING by GetSecurityLevel() in the security_state component. As of https://chromium-review.googlesource.com/c/chromium/src/+/1986189, there's a rare case in which a non-http/https scheme can be mapped to DANGEROUS. This case is as follows. When the user allows a page to run active mixed content (by manually allowing the mixed content in content settings), the page gets marked as DANGEROUS, and every other same-origin tab gets marked as DANGEROUS as well. Before https://chromium-review.googlesource.com/c/chromium/src/+/1986189, same-origin tabs with weird URLs (about:blank or blob:, in particular) would not get marked as DANGEROUS, even though they were same-origin. Now they do get marked as DANGEROUS. Styling the scheme in this case ends up looking odd; for example, we don't want the "about" in "about:blank" to get crossed-out. Bug: 609527 Change-Id: Ief3f7d4d679059c8aa540826096ec623293ff0f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987084Reviewed-by:
-
David Grogan authored
Change-Id: I0c3edddaad5ccf8522c40a8e1572ae3d3b448c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987283Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#728686}
-
Austin Eng authored
These tests were disabled because uploads were hanging. The tests have now been switched to histograms and should no longer fail to upload. Bug: chromium:1035590 Change-Id: I16289ffff0ec7e2f1dcca95f9fcac014ef50531e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988909 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#728685}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/19b43a602225..a57e2eca02d1 git log 19b43a602225..a57e2eca02d1 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 capn@google.com Limit Vulkan memory allocation size to 1 GiB Created with: gclient setdep -r src/third_party/swiftshader@a57e2eca02d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I0b9de7e1631af0341a079a7e2a744abc07a55468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988808Reviewed-by:
-
Thomas Guilbert authored
It appears that a merge error in 555ef226... undid the roll in 252792a1ff65deadc4e627e59ce80b... This is a reland. https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/68b4dfdbd607..252792a1ff65 $ git log 68b4dfdbd..252792a1f --date=short --no-merges --format='%ad %ae %s' 2019-12-09 tguilbert Fix null pointer addition error 2019-12-06 tguilbert Fix null pointer arithmetic Created with: roll-dep src/third_party/ffmpeg TBR: tmathmeyer Bug: 1031252 Change-Id: I4b25092bbc7681578cd0bb6f447788f2936d5a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988726 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#728683}
-
Samuel Huang authored
Courgette's algorithm allow removal for underused labels. However, this was only used by ARM, whose support is recently removed. This CL is a follow-up to remove more dead code. * Remove AssemblyProgram::TrimLabels() * Remove LabelManager::RemoveUnderusedLabels() and usage in test. Bug: 1012592 Change-Id: Ia50ee2ec9f90e35ce123463e06edc9bfb5a868af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987863Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#728682}
-
Vlad Tsyrklevich authored
Change-Id: I40ced1a170eeb5164c79f38d304f03b1319bab14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986369 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#728681}
-
Allen Webb authored
Bug: 874630 Change-Id: I248999003b3881dfc9bc941573b78fac84765fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987068 Auto-Submit: Allen Webb <allenwebb@google.com> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Allen Webb <allenwebb@google.com> Cr-Commit-Position: refs/heads/master@{#728680}
-
Rodney Ding authored
- add execution context to cssPropertyID() - Design doc https://docs.google.com/document/d/1Lc3U2WV38GZ3ShTAm3-p6fbZeGJGkxL-KZfWIQ-p8GU/edit?usp=sharing Bug: 775189 Change-Id: Iaf59eba6a12158398bd976fdb74a7800afd0228d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965998 Commit-Queue: Rodney Ding <rodneyding@google.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#728679}
-
Stephen Martinis authored
This CL modifies the sorting and duplicate checks in the *.pyl files in //testing/buildbot. It adds more checks for subsections of the files; for example, each entry inside of test_suite_exceptions.pyl will now be checked, rather than just checking that the top level list of tests is sorted. A few duplicates have been removed; these won't cause any meaningful behavior change, since python ignores duplicates in dictionaries. Change-Id: I314338c904080b463ac6859011a538987a862530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986241 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728678}
-
rbpotter authored
The destinations iron-list in Print Preview has an initial height of 0, since it is sized based on its contents. This results in iron-list setting an optimal physical size of Infinity and rendering a list with length equal to the number of destinations that have been retrieved initially. This causes the dialog to be extremely slow in cases where there are many printers. Instead, set the height of the iron-list in JS before updating the list of printers it displays, and merge this logic with the logic to update the throbber (since it is performing similar compuations). Also removing unused listName property. Bug: 1038434 Change-Id: Id38ccc6252bb2bbbb2f99b67504328f17ccdff64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984717Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#728677}
-
Nina Satragno authored
Add support for the UV tokens to webauthn. When getting an assertion, if UV=true and the authenticator supports UV token, get a token and use it for subsequent operations. This allows silent credential discovery for credProtect=UVRequired credentials. Fixed: 1033225 Change-Id: I4537e76ef4803910d19d9bdc06bb920b4df6f525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975013 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#728676}
-
Peter Kasting authored
* Fixes some (but not all) "Could not delete temp dir" warnings by adding a new ThemeScoper object. This is the bulk of this change. * Fixes some tests that failed on sytems with dark mode on by default. * Cleans up some tests by removing unnecessary bits (e.g. UseDefaultTheme()/RunUntilIdle() calls on test start) and refactoring (e.g. adding a |theme_service_| convenience member alongside the existing |registry_|). Bug: none Change-Id: Ie5c3fcccda294a863c6a598a0513f076788b314d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986284 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#728675}
-
Taylor Bergquist authored
This also adjusts the internal View hierarchy for the tab counter; this will be important when the animation is changed to move the border and the text separately. Bug: 999557 Change-Id: I1f9f7d8544ca87e6ec463b29ce2370f1f88bedfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982722 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#728674}
-
Mei Liang authored
This CL is the final CL that integrates all components in order to serve the CloseTabSuggestion to GTS. component that was previously landed and stripped out by Pro-guard. Binary-Size: Enables the feature by introducing a code path which used a Change-Id: If0fc9e2593fc2422494490b470a0c1b4464af65b Bug: 1004570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959783 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#728673}
-
Jack Lynch authored
This CL adds an axe accessibility test for the Sources panel Scope pane. Bug: 963183 Change-Id: Icb24c0ae8312d38fe26eaa78903472128a01e7cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668238Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Commit-Queue: Jack Lynch <jalyn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#728672}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3311ef65680e..f8ae5dc6d791 git log 3311ef65680e..f8ae5dc6d791 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 syoussefi@chromium.org GL: Enable EXT_gpu_shader5 2020-01-06 flibitijibibo@gmail.com Fix UWP build 2020-01-06 ericbinet@google.com Add missing steps in DevSetup 2020-01-06 flibitijibibo@gmail.com Fix GGP build 2020-01-06 lehoangq@gmail.com Metal: fix vertex attribute's conversion lost after changing buffer binding. Created with: gclient setdep -r src/third_party/angle@f8ae5dc6d791 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I08608142faf6ee51f0fdc49d0d9ce6fe74141bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988518Reviewed-by:
-
Chris Mumford authored
CrossThreadBindRepeating::MakeCrossThreadFunction was calling base::Bind to create callback. Switching to base::BindRepeating. Also modified comment in worker_thread.cc to refer to WTF::Bind so as to not encourage the use of the banned base::Bind* methods in Blink. Bug: 1007835 Change-Id: Ib880897af9f78dc5684a7c7b4cd5be557ed5563d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988507Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#728670}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ed0cc5f6fd8e..a81450253f88 git log ed0cc5f6fd8e..a81450253f88 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 ehmaldonado@google.com depot_tools: Use mock from vpython (or unittest.mock) instead of third_party/mock Created with: gclient setdep -r src/third_party/depot_tools@a81450253f88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I92eb147981445f3e0aa15fe5bc820d1365750e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988260Reviewed-by:
-
Vasiliy Telezhnikov authored
After recent changes OffscreenCanvas now using SharedImage and so can work with Vulkan. This CL re-enables relevant tests. Fixed: 1002538 Change-Id: Icec465655bea0247f0919d95cb39ad62fe6e44e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988504 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#728668}
-
Ian Barkley-Yeung authored
On ChromeOS, pass --always_allow_feedback when running unattended (during integration tests). This avoids the need for most tests to try and set metrics consent. Requires https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1981037 to be rolled into Chromium before checkin. BUG=chromium:1037656 TEST=tast -verbose run --extrauseflags chrome_internal my_crbook ui.ChromeCrashNotLoggedInDirect Change-Id: I7ba481286c87856f2d5e8cebf224b9b1b6212824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981139 Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#728667}
-
Matthew Mourgos authored
Without this change, when multiple external displays are connected and the primary display is turned off, sometimes the bounds of the login ui is incorrect, causing the login ui to be hidden. Bug: 1031571 Change-Id: Iae1447b0ceffe55d41ba79187d2c2fcf2b555b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984763Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#728666}
-
Robert Ogden authored
This flag is no longer used on stable or later versions. TBR=ryansturm@chromium.org Change-Id: I1919d7015bf0caf8f72b31ce8c80f29f7a2048d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986063Reviewed-by:
-
Kurt Horimoto authored
This class was unnecessary, as the same functionality can be implemented much more easily by observing OverlayPresenter from BadgeMediator, which acts as the InfobarBadgeTabHelper's delegate. This implementation will be added in a follow-up CL. This CL replaces the browser agent's instantiation with an infobar- specific BrowserAgent creation helper function that will set up BrowserAgents to handle the model-layer updates from overlay UI interaction events. Bug: 1030357 Change-Id: I4fa3f0c3afa6d0f747f0a7d3b9f5ee14dd43d4e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978623 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#728664}
-
Chris Mumford authored
WebGraphicsContext3DProvider::SetLostContextCallback already exlicitly uses base::RepeatingClosure so converting two overrides to do the same. Bug: 1007835 Change-Id: Id83a1067d9c555700b630deb75fe2b3d13c93d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988487Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#728663}
-
Joey Arhar authored
If a <button> element inside a <form> has a child element which is clicked, and the <button>'s onclick handler removes the child element from the DOM, the <button>'s default event handler which submits the form is never called. If this happens, and the <button>'s onclick handler also manually submits the form via form.submit(), then the form double-submit fix made in crrev.com/c/1850358 will prevent form.submit() from submitting the form because the form.submit() is blocked until the <button> gets the DOMActivate event, which never happens if the child element is removed from the DOM before it can emit the DOMActivate event to the parent <button>. This patch will submit the form in this case by listening to the click event instead of the DOMActivate event. If the click event is additionally preventDefault()ed, this patch will not cover that case. Once we switch back to async form submission in crbug.com/1013385 then all of the cases will be covered and this patch will be reverted. Bug: 1037740 Change-Id: I04cdff451b363b5fafa26d2c58ec0aa76ed95a0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983547Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#728662}
-
Devlin Cronin authored
ExtensionIdSet is typedef'd to a std::set<ExtensionId>. Move the declaration from extension.h to extension_id.h, where the ExtensionId typedef is. Bug: 1038392 Tbr: vakh@chromium.org (micro change in extension_data_collection_unittest.cc) Change-Id: I98c4aa8285c67ac6c48cb372365f8b11700d1d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983192 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#728661}
-
Toby Huang authored
Child/Geller users currently cannot remove extensions with state BLOCKED or REQUIRE_APPROVAL because UserMayModifySettings() returns false. Make UserMayModifySettings() always return true so that child/ Geller users can remove installed extensions regardless of the state. Bug: 1033687,1032352 Change-Id: I4608c22099325578982e48b6da31840c124167d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969068 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#728660}
-
Dan Beam authored
R=dpapad@chromium.org Bug: 1038846 Change-Id: I72d5b46a6132d0e033a1236af57153cf6a7b603b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987134Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#728659}
-
Peng Huang authored
The tearing is because the displayed_image_->EndPresent() is called in wrong place. It should be called when the displayed_image_ is being replaced by a new image. Bug: 1036566 Change-Id: Ic12c41d0191e9ad62638f931bce03c9d44a31c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988687Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#728658}
-
