- 13 Oct, 2020 40 commits
-
-
Mikel Astiz authored
This historic mechanism to inject dependencies into ProfileSyncService doesn't belong in SyncClient (dependencies to core sync logic / engine itself), and it's questionable whether it should remain in this form in BrowserSyncClient, where feature-specific dependencies are injected, and where multiple similar approaches coexist. Arguably, the most elegant and universal way to inject a dependency to a sync controller is to have full access to the KeyedService that owns the local model. Most controllers are simple and don't actually need this: all they need is a SyncableService or ModelTypeControllerDelegate. However, that introduces code inconsistencies that can be confusing. In this patch, the approach is unified for the remaining SyncableService types, after migrating history delete directives and preferences). The corresponding keyed services are directly injected via BrowserSyncClient and hence SyncClient::GetSyncableServiceForType() can be deleted. Change-Id: I8e80482e8657624dc7c1e15b6bcf0409ae4d1336 Bug: 915154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463617Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#816550}
-
Maxim Kolosovskiy authored
This CL fixes two issues. Both issues occurred when |PasswordChangeInSettings| was splitted into two flags |PasswordChangeInSettings| and |PasswordScriptsFetching| (https://chromium-review.googlesource.com/c/chromium/src/+/2436339), but some uses of |PasswordChangeInSettings| were not replaced with |PasswordScriptsFetching|. The change is supposed to be merged to M87 Beta. 1. The param |scripts_list_url| should be read from |PasswordScriptsFetching| Scripts fetching is controlled by |PasswordScriptsFetching| flag, not |PasswordChangeInSettings| flag. The latter might be disabled while scripts need to be fetched. So, it makes sense to read the param from the relevant feature - |PasswordScriptsFetching|. To be on the safe side, the Finch config can provide the param for both features, but the param names must be unique even in separate features. So, this CL renames the param (the param value was not used yet, so we don't need to update any configs). 2. Scripts prewarming should be controlled by |PasswordScriptsFetching|, not |PasswordChangeInSettings|. This issue was not severe and therefore it was hard to notice: even if scripts were not prefetched in advance, scripts were requested when a password check page was shown (|PasswordCheckManager::RefreshScripts|). That method used the correct flag. Bug: 1095627 Change-Id: Ibcfccf5d1348403b5dd46a15515ce4f040cc8047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465913 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#816549}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e2dfd01ded55..b60eeeee9ddb 2020-10-13 jleconte@google.com Partially Revert: Fix 'Unknown git hash' when repository is not chromium. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1133649 Tbr: nuskos@google.com Change-Id: I3e319a236abac20a5461b449ea6a9346f2d71882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465727Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816548}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/599fe36ca9b3..62054633ee57 2020-10-13 kimanh@chromium.org Use skip list on 'stepInto' 2020-10-13 sigurds@chromium.org Refactor factory pattern in ConsoleViewMessage.js 2020-10-13 bmeurer@chromium.org [wasm] Show errors when WasmParser fails. 2020-10-13 jacktfranklin@chromium.org Fix component bridges tests 2020-10-13 sigurds@chromium.org Fix type for SortableDataGrid.create 2020-10-13 sigurds@chromium.org Remove DOM prototype patching of createTextChild(ren) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1135143,chromium:1136484,chromium:1137302,chromium:1137335 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idf8cb03b55feefb8a600ea21ddfb2a1c99418170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466851Reviewed-by:
-
Maxim Kolosovskiy authored
This CL is a follow-up of https://chromium-review.googlesource.com/c/chromium/src/+/2453289 Bug: 1133783 Change-Id: Icff794b1c644d311a7fa9f16248ee9a4f714da08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463823 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#816546}
-
Viktor Semeniuk authored
This change adds flag to enable Password editing feature on iOS. Bug: 1137475 Change-Id: Ia2b00e9be7c3bc2bf0fc3a49f8f21f3472e12dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466763 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#816545}
-
Colin Blundell authored
This CL eliminates the Java ads blocked infobar from depending on the //chrome-level R by adding Java resources to //components/subresource_filter/android and giving these resources the necessary contents / dependencies. This will facilitate componentizing the infobar for sharing with WebLayer. There is no behavioral change. Note: The somewhat-unexpected dep addition in //weblayer is to work around a weblayer packaging test that otherwise fails. cduvall@ is investigating the root cause of this problem. In any case, the dep addition is not problematic as the whole point of the componentization is that //weblayer will shortly be using this code :). Bug: 1116095 Change-Id: I5ceef180908b34a8f784e5b72a5e10886cf0efac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460727Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#816544}
-
Jan Wilken Dörrie authored
This change implements the base::IsContiguousIterator type trait and makes use of it in base::span's constructor to allow construction from arbitrary contiguous iterators, and not just pointers. Given the lack of std::contiguous_iterator_tag in C++14, the type trait is especially instantiated for iterators that are known to be contiguous. These include pointers, and the iterators for std::array, std::string and std::vector<T> (for T != bool). Lastly, this change adds an implementation of std::to_address, which allows obtaining the underlying address from a pointer like type. TBR=dcheng Bug: 828324 Change-Id: I00d44c5edf8d86f811b7b2d32f07fa15e084d987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093215 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#816543}
-
Alexander Bolodurin authored
The cache was introduced in https://crrev.com/c/616409 but was only used to get File::Info for an entry, and the calls to get ExtraFileMetadata made a mojo call each time, even though both functions draw data from the same source (ARC Document objects). It did not impact read-only providers, as the extra metadata returned for them is currently static, but this will change when dynamic metadata is added (DocumentsProvider thumbnail flag). Also, ArcDocumentsProviderRoot::GetMetadata is renamed to GetExtraFileMetadata to disambiguate it from a file system operation with the same name. Bug: 1049966 Change-Id: I94e0dc50e8a646a68b8c7b76e398c7777f4da121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464518 Commit-Queue: Alexander Bolodurin <alexbn@google.com> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#816542}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1479f79a5304..33bd4fbe1e5b 2020-10-13 ilnik@webrtc.org Remove deprecated video_frame_i420 build target If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1132299 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iabb972d7151a2c8c8ea2226be36db5adad1d992c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466850Reviewed-by:
-
Mohamed Amir Yosef authored
This is to protect against avatar with white background. Screenshot: https://screenshot.googleplex.com/BwjbErJCcuxSCw9 Bug: 1100814 Change-Id: I555f05277e540da623402550a5d8b01323838fdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465909 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#816540}
-
Rainhard Findling authored
Bug: 1087263,1136855 Change-Id: Ic2799373e50d7f2f15513d126214f596581f1244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465752Reviewed-by:
-
Nazerke authored
This CL add a new TabStrip view to BVC. Bug: 1132236, 1128249 Change-Id: Ife191e6de13b8bbf700fb5ae4abe3fcb34a948e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436537Reviewed-by:
-
Miyoung Shin authored
This CL passes the annotation class from JavascriptInjectorImpl to RemoteObjectRegistry when the object id of the named object or transient object is generated, and we get it from RemoteObjectRegistry when RemoteObjectImpl is created. The transient object should inherit the annotation class from the parent's one. Bug: 1105940 Change-Id: Ica8625113b5d4caf32c3e51a947179d1fb6b4514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397974 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816537}
-
Jan Wilken Dörrie authored
This change gracefully handles a null PasswordManagerDriver in PasswordGenerationPopupControllerImpl::PasswordAccepted instead of forcing a CHECK failure. Bug: 1133635 Change-Id: Ife83a3c8c78b5dff18c3252c3beb0092750d4420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463834 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
This is a reland of 052bc3e7 Original change's description: > Update V8 to version 8.8.74. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/ba88e59b..7bb48090 > > Please follow these instructions for assigning/CC'ing issues: > https://v8.dev/docs/triage-issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: I95a61574ebdaa9fcab1866231cd4a46092517bd8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462181 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#816339} Change-Id: I019e65713c57c6e78a87dcfc117b79a09a483c29 Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465857 Commit-Queue: Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#816535}
-
Marc Treib authored
This reverts commit d7c5c1d5. Reason for reland: Mac flakiness was hopefully resolved by https://crrev.com/c/2463562 Original change's description: > Revert "Add fieldtrial testing config for ButterForPasswords" > > This reverts commit 8e4ad533. > > Reason for revert: crbug.com/1136758 test failures on macOS > > Original change's description: > > Add fieldtrial testing config for ButterForPasswords > > > > Bug: 991510 > > Change-Id: I447e99f11c322478f007557ab268823ed2616042 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455446 > > Commit-Queue: Jesse Doherty <jwd@chromium.org> > > Auto-Submit: Marc Treib <treib@chromium.org> > > Reviewed-by: Jesse Doherty <jwd@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#815355} > > TBR=jwd@chromium.org,treib@chromium.org > > Change-Id: I41a6d02cb9dce80e5bc41e087c53f8b6b5be0335 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 991510 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462884 > Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815507} TBR=jwd@chromium.org since this is unchanged from the previous version # Not skipping CQ checks because this is a reland. Bug: 991510 Change-Id: Id09347649546b2d7ca102ba839be17fe8cd13166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462081Reviewed-by:
-
Matt Jones authored
This patch adds resets the Y offset of the infobar container on navigation to clear any stale values from the previous page. Bug: 1012695, 1069955 Change-Id: Idccc26471c178850f2ed820e3b567bd6d5970819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461708 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#816533}
-
Thiemo Nagel authored
... due to flakiness on Builder Linux Tests [1]. [1] https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/94497 TBR=dominickn Bug: 1137759 Change-Id: Ib3fe9800b017b311a32cebad46154aca5323bacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466246Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#816532}
-
Rob Buis authored
The codepoint U+266D was used in this test and part of the MathML3 operator dictionary, however it is not part anymore of the MathML Core operator dictionary. Therefore pick a postfix operator that is part of the MathML Core operator dictionary. Bug: 6606 Change-Id: I253909a13a3d1ce34ca597342a706c05d35d3d34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466243Reviewed-by:
Frédéric Wang <fwang@igalia.com> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#816531}
-
Harald Alvestrand authored
It's now in the API directory of third_party/webrtc Bug: webrtc:11967 Change-Id: I752ffa3261fa4080bac565c58d544f900a0bd890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463609Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#816530}
-
Andrey Zaytsev authored
Mocks: https://docs.google.com/presentation/d/1r1wHrb1NnYKEQieWAxeHymsJs__u30yLJ5lJ-BzCm3E/edit?usp=sharing Screenshots: https://screenshot.googleplex.com/AUtj24CvvLBEUzq.png and https://screenshot.googleplex.com/848cwBXgdaXSyGk.png UI deck: go/metrics-settings-clank Bug: 1132805 Change-Id: I220dab3231ed070c26a3a5500c0acf35bba2660f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450190 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#816529}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a4b8d27d96b7..a08dc37d19e5 2020-10-13 treehugger-gerrit@google.com Merge "tracing: Don't reuse trace writers across connections" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I95c3ae8a5d9cdffba9cc90a70274d55a70ca8da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467440Reviewed-by:
-
Luciano Pacheco authored
Change the use of cr.defineProperty() to Object.defineProperty() + type declaration. This is basically what Closure ChromePass was doing [1], but we don't want to depend on ChromePass when using JS modules. NOTE that this changes the property definition for both module and non-module versions, but they should have the same behaviour, because it uses the same getters and setters. [1] - https://github.com/google/closure-compiler/blob/master/test/com/google/javascript/jscomp/ChromePassTest.java#L415-L427 Bug: 1133198, 1134497 Change-Id: I787dc3d7f2fa8dc290f7839c76c347b5695a0038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440331 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#816527}
-
Boris Sazonov authored
Changes the text used for the primary button in sync promo that is shown in the signed out state. The text is changed from "Continue as ..." to "Turn on sync". Applied only if MobileIdentityConsistency flag is enabled. Screenshot: https://crbug.com/1136905#c1. Bug: 1136905 Change-Id: I967768061e26a01a4d34cdedee463fd8276dc969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462267 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#816526}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. In this case, all users (and constants) used "supports," so swap the definition to that, too. Bug: 1136209 Change-Id: I38c98419a0ffdcd5c521b40f065ab9f609194521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458893Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#816525}
-
Maksim Moskvitin authored
There were only few minor expectations relying on verifier profile in preferences tests. This CL removes them together with verifier profile notion in preferences_helper. Bug: 1137746 Change-Id: I7d74ad99feaf1dfa7c4a0eb856fcf94263a681bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467521 Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#816524}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ffd66905c46a..599fe36ca9b3 2020-10-13 sigurds@chromium.org Allow undefined for lineNumber in (maybe)LinkifyScriptLocation 2020-10-13 tonykostowny@gmail.com Devtools: Network panel search clear command resets search results message. 2020-10-13 sigurds@chromium.org Fix typo in variable name 2020-10-13 sigurds@chromium.org [ts] Type-check sdk/SecurityModel.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1102761,chromium:1135143 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibcc7eb55c2a323e67cf5a46d16c02c10694578e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466849Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/df6b7298bb41..06b956fe4525 2020-10-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from efbcef25 to a6b7134c (408 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@chromium.org Change-Id: I7d46bad9602c02e35139c28b5bfc87148be7b2fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466844Reviewed-by:
-
Thiemo Nagel authored
MetricIntegrationTest.LargestContentfulPaint_SubframeInput is flaky on Linux, so disabling there (and for Chrome OS as well). TBR=skobes Bug: 1135527 Change-Id: I876e3e1d174edca0b5bd17f3cc53f3cb61ef4c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467522Reviewed-by:
-
Miyoung Shin authored
This CL implements RemoteObjectInjector#removeInterface which should call the RemoveNamedObject method on a RemoteObjectGateway remote. This CL changes to removing the unnamed object on only the browser side to secure that the object is injected again on the renderer. It is consistent with the old code, and fixes JavaBridgeBasicsTest#testRemovalNotReflectedUntilReload. Bug: 1105925 Change-Id: I7a304dba05f4e09b190658f684c13632497481d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379270Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#816520}
-
Jérôme Lebel authored
Removing ChromeTrustedVaultService::AddKeysChangedObserver() and temporary code introduced in: crrev.com/c/2461007. Related to: crrev.com/i/3323592 Bug: 1081649, 1100278 Change-Id: Iada56e4b25f5d51ab89263d7fa09f5317d26c63c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461124 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
ChromeIdentityService::GetCanonicalizeEmailsForAllIdentities() is unused. And also removing GetCanonicalizedEmailForIdentity(), this function is only used in AuthenticationService. This method can use the user email instead of the canonicalize email. The implementation is removed with: crrev.com/i/3326972. Change-Id: I9f74f5bfffb2fec77bc4ee3fd220a1ae403fe60c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465854Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#816518}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I81007ddb043ef8182e39c282465a1188ba9fad14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466845Reviewed-by:
-
Mitsuru Oshima authored
Use these scale factor when 2.25, 1.77 and 2.66 are given from command line. Bug: None Change-Id: I20f227a80ed38eb3643a63abb50ba6c454036b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448651Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#816516}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1df9e9aac9d3..e2dfd01ded55 2020-10-13 jleconte@google.com Fix 'Unknown git hash' when repository is not chromium. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1133649 Tbr: nuskos@google.com Change-Id: Ifd87cae8526bb14bc204095441e6f2e5e6f8ccb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467541Reviewed-by:
-
Paula Vidas authored
This CL adds a test that checks the following: - When sync is disabled for a data type, it won't show up in interested data types. - When sync gets enabled again for that data type, it will appear in interested data types, and the device will receive invalidations for that type. The test uses only sync invalidations. Bug: 1135167 Change-Id: Ibe118a8281a332ebe64713d9dffdf1e9935e6262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466760 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#816514}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2ce65f04. With Chromium commits locally applied on WPT: cfa13307 "Revert "Enable "Immersive-AR" session for OpenXR runtime"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Ie431e137de412c6946083c712892b507c3e9a802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466440Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816513}
-
Weilun Shi authored
Bug: 758782 Change-Id: I4b7ff5cd8116d9b88ae1e9fe12adb7532a6ecf4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466840 Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#816512}
-
Mikel Astiz authored
The concept of registered datatypes is somewhat advanced and should not be part of SyncService's public API. Instead, this patch moves it to the subclass, ProfileSyncService, and makes it private except for testing. Change-Id: I0934a6a97009bf6589f1075ba37fdc1a52490643 Bug: 915154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463832Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#816511}
-
