- 17 Nov, 2020 40 commits
-
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //components/find_in_page Bug: 1113033 Change-Id: Ia31af39407628ab5c568efcfbe92d9f1297bca50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543544 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#828198}
-
Yifan Luo authored
Bug: 1116418 Change-Id: I9b031a46008557c42121943b0680da5eef8652b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502338Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#828197}
-
Harry Cutts authored
Otherwise one might only find out when OsSettingsManagerTest.Initialization fails during the submit process. Change-Id: I86f2135f3aca46fdad6cab4be7337de211af625d Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542732Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#828196}
-
Sebastien Lalancette authored
Runs only on iOS 13+, and will: - Select a word on a test page, - Tap on "Link to Text", - Tap on the "Copy" activity, - Assert that the expected URL was added to the pasteboard. Test is skipped on iOS 12 due to the activity view not being accessible by EarlGrey. Test is disabled on iPads due to: Bug: 1149603 Change-Id: Ia1011f538e6d2b6aed00a12cccd19df40da13472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530389 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#828195}
-
Roman Aleksandrov authored
Bug: 1144159 Change-Id: I02c5ba9fa2d67755025f364807e4c0e03bba312f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537839 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#828194}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605592392-dc172d915909da26cabde4fc0f34ef46d817ea1e.profdata to chrome-linux-master-1605612997-0b538d267d59602889f3873bf24b3a402bd4dd04.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iba237a12cb4ca4bd2cf26f10b20dc53a40c0a955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544246Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828193}
-
Andrew Shulaev authored
Bug: b/171790119 Change-Id: I00249eab13ecee8163c52f90a91bcaeaa8899a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507651Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Andrew Shulaev <ddrone@google.com> Cr-Commit-Position: refs/heads/master@{#828192}
-
Jan Wilken Dörrie authored
This change unexpires the PasswordImport flag. Bug: None Change-Id: Ie93933f7e12b02f5fc7f9850ae48b433595c3cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542790 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#828191}
-
zhiyuancai authored
This CL records whether users turn on the feature "track prices on tabs" and updates the checkbox on the tab switcher menu. Bug: 1146636 Change-Id: I7dbdddb287a30b47298425eda79778433caa2316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524961Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Cr-Commit-Position: refs/heads/master@{#828190}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=sky@chromium.org Bug: 1145565 Change-Id: I917d2102c2a9d3276355bf395db2a88749effdfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532662 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828189}
-
Karandeep Bhatia authored
Extend expiry of the following histograms: - Extensions.DeclarativeNetRequest.ReadDynamicRulesJSONStatus - Extensions.DeclarativeNetRequest.UpdateDynamicRulesStatus - Extensions.DeclarativeNetRequest.RulesetReindexSuccessful BUG=1149533, 1149532 Change-Id: Id8bb35c0ece810b5c8cadd9f57eb14559cdbebc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541669Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#828188}
-
Liquan (Max) Gu authored
Changes: * De-dups the not-show error handling for disconnectForStrictShow and disconnectIfNoPaymentMethodsSupported by onShowFailed(). Behaviour changes: * When the strict-show conditions fail, adds this behaviour: logs "NotShownReason.OTHER". Bug: 1148902 Change-Id: I30dacb87f9e785466edd76a2de9ceb9b6ed9be9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540574 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#828187}
-
James Vecore authored
Contains only cl/342372120 since the last uprev. This addresses a possible keep alive time-out when doing larger file transfers due to the crypto context mutex being held for longer than necessary. Bug: 1146293 Change-Id: If6e51f936faf10756c122b7d9676ddc606ab7e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543196 Auto-Submit: James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#828186}
-
Nico Weber authored
Ran `./tools/clang/scripts/upload_revision.py 6ef07111a402a87fda096b6b8d7327e4aa89d4d6`. Bug: 1149189,1148761 Change-Id: I6bde4a1d5f055296d4f52619f7bec9ddb191cb79 Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chromium/try:linux-chromeos-dbg Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:mac-arm64-rel,mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:win-asan,win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538318 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#828185}
-
Felipe Andrade authored
Remove duplicate import("//tools/polymer/polymer.gni") from some BUILD.gn files in settings UI. This is a clean up work done while creating a new settings section called Kerberos. See associated bug for additional information. Bug: 983041 Change-Id: Idbf0f78253d4f0410ea9600dff98ae9ac0bc9760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536648 Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Reviewed-by:Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#828184}
-
Karandeep Bhatia authored
This is a reland of 34bf7349 Original change's description: > DNR: Add initial implementation for [get/update]SessionRules. > > The session rules are not indexed and evaluated yet. This will be done > in a follow-up. > > Skipping presubmit since this seems to be hitting crbug.com/956368. > > BUG=1043200 > Doc=https://docs.google.com/document/d/1_I6jHA_jCa0UbR2QVUZsBApt_GqEuMz7qnpQdt1LEv0/edit?usp=sharing (Internal only) > > No-Presubmit: True > Change-Id: Id15783af14ff1f4a88900680d29d71d07794b4e7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495511 > Commit-Queue: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827418} Bug: 1043200 No-Presubmit: True Change-Id: I9174b278594236d5b90cf0d7f434efce538a1cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540208 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#828183}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ic5e99247361e57a90ea048463797bde1b0744101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542756Reviewed-by:
-
Boris Sazonov authored
Adds ToMojoAccountKey/FromMojoAccountKey helpers to components/account_manager_core/account_manager_util.h. These methods will be used by subsequent CLs to implement observers in AccountManagerFacade. Bug: 1117472 Change-Id: I625afacc31dc2d3bd4ceb56dde70a99ed1d15e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542903Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#828181}
-
Omar Morsi authored
This CL inlines the definitions of the constructors of the NSS operation states to make it more readable and shorter. Bug: 1131873 Change-Id: I0ff8b270fe4f1e2b653d3066e9b5dd7ebccad4b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541724Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#828180}
-
Roman Sorokin authored
This CL eliminates NOTIFICATION_KIOSK_AUTOLAUNCH_WARNING_VISIBLE and NOTIFICATION_KIOSK_AUTOLAUNCH_WARNING_COMPLETED notifications. These were used for the tests only. Replaced it with javascript waiter. Bug: none Change-Id: Iea1f187d43fc708c2c23e02e4ebfe37d8a38b329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544138Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#828179}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4f96bf19941b..2f5d646c928e 2020-11-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 089f5a3e to d8a32653 (384 revisions) 2020-11-17 syoussefi@chromium.org Vulkan: Make ImageViewHelper a Resource 2020-11-17 amy.liu@arm.com Fix flip info of colorBlit with pre-rotation. 2020-11-17 cclao@google.com Vulkan: Remove rotation related data from driver uniform If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I91adb3a4dce11175fcef45540021847ea112844c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542856 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Guido Trotter authored
Since we have an observer for the "hidden" attribute, that is going to be called anyway, inline the show() function into it, instead of having it called explicitly. One place in oobe_welcome.js already calls show() only if it exists. Change the other call to follow the same pattern, and remove the show() function altogether from that module. Signed-off-by:
Guido Trotter <ultrotter@chromium.org> Change-Id: I96ff9feb8d339ddf3aca2cf672e69eff78a15c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537688Reviewed-by:
-
Yu-Hsuan Hsu authored
Check whether there is a keyboard mic. If yes, adding keyboard mic effect on lacros-chrome. BUG=b:173113548 Change-Id: I5241c11031cd5f681380f091dac23fbc82b3d75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536661 Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#828176}
-
Tal Pressman authored
This CL introduces separate legacy IPC channels per AgentSchedulingGroup in "MBI mode". This channel is then used to associate channel-associated interfaces with, and to send legacy IPC messages. In addition it does the following: 1. Remove MaybeAssociatedRemote/Receiver, as the ASG's mojo interfaces are now always channel-associated. 2. ASG and ASGH implement IPC::Listener to handle legacy IPC message on the new channel. 3. Rename SetUpMojo/ResetMojo to SetUpIPC/ResetIPC. 4. `should_associate_` flag is replaced with an enum to make its meaning clearer. Bug: 1111231 Change-Id: I1d850aae48b4a900ab0aef24ac8a58b00cbcb218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535954 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#828175}
-
Jit Yao Yap authored
Change-Id: I995dae02a8823ce904f201501063e6a0526dab6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543922 Auto-Submit: Jit Yao Yap <jityao@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#828174}
-
Fredrik Söderqvist authored
ElementStyleResources holds a reference to the Element of the StyleResolverState that also owns the former object, so don't go across the stream for water and use |ElementStyleResources::element_| to get a reference to a proper TreeScope in GetSVGResourceFromValue(). Also make said field a reference to clearly indicate that it will be non-null. Drop StyleResolverState::GetTreeScope() since it now only has a single user. Change-Id: Ic2c994b546069001e6dd716a0d175825ceaeb96d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544183Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#828173}
-
Jan Scheffler authored
CL: https://crrev.com/c/2505657 Bug: chromium:1144127 Change-Id: I438126be535524c073fb9bcba32309ff5c81ac3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539197Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#828172}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1d0105053a41..c4b2f38f2396 2020-11-17 szuend@chromium.org TypeScript-ify DragHandler in UIUtils.js 2020-11-17 yiorsi@gmail.com Fix the problem that there is no color picker in front of the CSS custom property 2020-11-17 jacktfranklin@chromium.org [DataGrid]: allow data-grid-controller to take an initial sort 2020-11-17 alcastano@google.com Introduce CSPViolation as pause reason (Devtools) 2020-11-17 aerotwist@chromium.org TypeScriptify create-shadow-root-with-core-styles 2020-11-17 aerotwist@chromium.org TypeScriptify register-custom-element.js 2020-11-17 aerotwist@chromium.org TypeScriptify inject-core-styles.js 2020-11-17 bmeurer@chromium.org [wasm] Turn DebuggerLanguagePluginManager into a singleton. 2020-11-17 aerotwist@chromium.org TypeScriptify append-style.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1125968,chromium:1142804,chromium:1148763 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If554bdc5eb16a7f5041254c70e4b2ba01efa1a6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544243Reviewed-by:
-
Michael Lippautz authored
Explicit template instantiations are in place to allow moving slow paths into the .cc file. Bug: 11297512 Change-Id: Id7f4c9912098ff550fae62fbe024a4cafe5fc56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542787 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#828170}
-
Guido Trotter authored
The dropdown accessible message currently says "Open remove dialog for..." but this is not the case when the account can't be removed (e.g. on the lock screen). This commit calls it an "info dialog" in such case. Signed-off-by:
Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#828169}
-
rajendrant authored
This CL adds a fetcher that fetches robots rules from LitePages. TBR=dullweber@chromium.org Bug: 1147565 Change-Id: If7a00bf83d387d035f890e6aacd1da430672f80c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536755 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#828168}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bde2c3c32a2b..2e8c7015c00a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC melandory@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: melandory@google.com Change-Id: I824b637a81d6502103f580c3ee5a0ae476fcf08a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542811Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828167}
-
Illia Klimov authored
This reverts commit dfd6e35e. Reason for revert: As part of the Flash deprecation, this logic is no longer needed. Original change's description: > Display discarded extension patterns in settings > > Currently we throw away invalid wildcard patterns set using extension apis for Flash. > After this CL instead of throwing them away, we display them in the site settings page. > > Bug: 1102380, 1073883 > Change-Id: Ic9b1d40157cecca3db9673ee92cf208423c71bc2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282742 > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> > Cr-Commit-Position: refs/heads/master@{#785383} TBR=finnur@chromium.org,engedy@chromium.org,ravjit@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1149353 Change-Id: I4761ee6323388ad233817b3fb828028e8aefeb4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537643Reviewed-by:
Illia Klimov <elklm@google.com> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#828166}
-
Saurabh Nijhara authored
The browser tests related to audio sandbox are moved to a separated file. Bug: 1149697 Change-Id: Ie3a8b3b6c3f98e286da78426bd17191c64ec862a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543382Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#828165}
-
Sylvain Defresne authored
BookmarkHomeViewController uses lots of blocks that may causes reference cycles. Convert the code to consistently use weakSelf/strongSelf pattern to avoid cycles. Bug: 1113618 Change-Id: I5cf79c87588944d2fe25f8238dddc25306308c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541082 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#828164}
-
Fabian Sommer authored
The original CL had some relative FilePaths that started with a '/'. This caused browser tests to fail when run in debug mode. This is now fixed by deleting the leading '/' characters. Original change's description: > Add mock policy option to extension install mixin > > Add an option to initialize ExtensionForceInstallMixin with a > MockConfigurationPolicyProvider. > Use this option in ForceInstalledAffiliatedExtensionApiTest. > Add mixin support to ForceInstalledAffiliatedExtensionApiTest. > > Bug: 1090941 > Change-Id: Ieea931c108e091679be607045f405b55f4186a57 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416453 > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: David Bertoni <dbertoni@chromium.org> > Reviewed-by: Omar Morsi <omorsi@google.com> > Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#808281} Bug: 1090941 Change-Id: I4803c1de248b40e22a0194aa9e98182cb5ae1ed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540586Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#828163}
-
Patrick Monette authored
This temporary class wraps a VotingChannel and provides a simpler API for submitting votes. Notably, the wrapper takes care of managing the VoteReceipts. This new API will greatly simplify the implementation of voters that observes a type of node for one property. The usual pattern will look like this: void On*NodeAdded(const Node* node) { auto initial_vote = GetVote(node->property()); voting_channel_wrapper_.SubmitVote(node, initial_vote); } void On*PropertyChanged(const Node* node) { auto new_vote = GetVote(node->property()); voting_channel_wrapper_.ChangeVote(node, new_vote); } void OnBefore*NodeRemoved(const Node* node) { voting_channel_wrapper_.InvalidateVote(node); } The goal in the future is to fold this functionality into the VotingChannel class and remove the wrapper. This will be done after each users of VotingChannel are migrated one at a time. Bug: 971272 Change-Id: I8d5cc58bb13ab4872b49e15bed6868f9a42f5136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533333 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#828162}
-
arthursonzogni authored
Reland information: --- Patchset 1 contains the original (reverted) patch. It has been reverted, because it landed together with: https://chromium-review.googlesource.com/c/chromium/src/+/2533280 [Initial code review]: https://chromium-review.googlesource.com/c/chromium/src/+/2529096 [Revert]: https://chromium-review.googlesource.com/c/chromium/src/+/2542857 --- Turn the IPC struct: FrameHostMsg_DidCommitProvisionalLoad_Params Into a mojo struct mojom::DidCommitProvisionalLoadParams This is mostly straigforward, except: 1. The functions have been updated to correctly specify whether ownership over this struct is passed or not. Use one of "const T&" / "T*", "TPtr*". 2. Mojo checks the required params are populated. This forced me to update several unittests to construct the required params. Like the referrer or the navigation_token. 3. blink::mojom::Referrer is used instead of the old content::Referrer This required adding (temporarily) the conversion between both when needed. TBR=nasko@chromium.org Fixed: 1145888 Bug: 1145888 Change-Id: I5e4a271b362db295947dea51e926114684328e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543347Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#828161}
-
Alfonso Castaño authored
This CL moves the logic for generation the description of Node objects to Blink. Previous CLs: https://chromium-review.googlesource.com/c/v8/v8/+/2502342, https://chromium-review.googlesource.com/c/chromium/src/+/2502589 Fixed: chromium:1127115 Bug: chromium:1048143,chromium:1127115 Change-Id: Ie250cfff9eb45f5b755d7d13871d3039a8ac909b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504259 Commit-Queue: Alfonso Castaño <alcastano@google.com> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#828160}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605560272-3c812cc827eaf1991f3c05cfa46c3374e2d6a16e.profdata to chrome-win32-master-1605571148-cd63329ec540ae538404ceac5db1a609fe603f55.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3fbee6521ad87945c17fadea3372b00e313ab492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544001Reviewed-by:
-
