- 23 Jan, 2019 40 commits
-
-
Kinuko Yasuda authored
This reverts commit ddd4f721. Reason for revert: Looks like some tests become flaky (or even flakier?) https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10417 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10418 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10419 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/31176 Original change's description: > Fix flakiness in previews browsertests > > The previous logic relied upon the hints requested by the store upon a > navigation to a url being loaded prior to the commit. This was not > guaranteed to happen when cores were not available on a machine for > background threads. > > The HintCache has been modified so that it now runs the hint loaded > callback even in the case where no hints are available for the host. > > Additionally, a histogram has been added that tracks the loading of > hints from the hint cache store has in PreviewsOptimizationGuide. The > tests now run a priming navigation that waits for the hints to be > loaded. This ensures that the hints are guaranteed to be available > during the tests. > > Bug: 923161 > Change-Id: I8b09dfc9391164f0a6d424ec0a8ea871334c4c8c > Reviewed-on: https://chromium-review.googlesource.com/c/1423617 > Commit-Queue: Jered Gray <jegray@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Doug Arnett <dougarnett@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625056} TBR=tbansal@chromium.org,dougarnett@chromium.org,jegray@chromium.org Change-Id: I7d7c3393765e2d24d02c49fd5f8be95dd8eebc86 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 923161 Reviewed-on: https://chromium-review.googlesource.com/c/1429879Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#625136}
-
Sylvain Defresne authored
The class base::NoDestructor is a simpler way to define a static global value (aka a singleton) than base::{LazyInstance,Singleton} and is the recommended pattern to use. The changes were automated using a custom one-shot script, then fine tuned by hand (to remove unnecessary classes, ...). This fixes usages in src/ios/chrome/browser/favicon. This CL was uploaded by git cl split. Bug: none Change-Id: Iec12a9f2c05d6415fffb371fa589b65d9f759c19 Reviewed-on: https://chromium-review.googlesource.com/c/1425605 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:edchin <edchin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#625135}
-
Kunihiko Sakamoto authored
This patch drops support for Signed Exchange of "application/signed-exchange;v=b2" format. After this patch, loading Signed Exchanges of version 1b2 will cause fallback redirect. SignedExchangeEnvelopeTest and SignedExchangeSignatureVerifierTest will remain TestWithParam<SignedExchangeVersion>, since that will be useful when adding support for future versions. Bug: 919424 Change-Id: I8f992c2d38e21ad2fc89b9c227295867f588a04a Reviewed-on: https://chromium-review.googlesource.com/c/1428628Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#625134}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ide707dfdcd3571bc335ff6edb4641c79d4fb396f Reviewed-on: https://chromium-review.googlesource.com/c/1429839Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625133}
-
Yuki Shiino authored
This is a follow-up of https://crrev.com/c/1421418 . This patch renames |first_frame| to |entered_window_frame|, and also renames |calling_window| to |incumbent_window|, |entered_window|, or |accessing_window| depending on what it actually is. Change-Id: Ifbfc7c36d6a1b3bfe69387438928c488937d0a35 Reviewed-on: https://chromium-review.googlesource.com/c/1426254Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#625132}
-
Sylvain Defresne authored
The class base::NoDestructor is a simpler way to define a static global value (aka a singleton) than base::{LazyInstance,Singleton} and is the recommended pattern to use. The changes were automated using a custom one-shot script, then fine tuned by hand (to remove unnecessary classes, ...). This fixes usages in src/ios/web_view/internal/sync. This CL was uploaded by git cl split. Bug: none Change-Id: I8c335cf791dbdd57860c7a45bc62fc456a3adbce Reviewed-on: https://chromium-review.googlesource.com/c/1426680 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:Marc Treib <treib@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#625131}
-
siyua authored
Actual code changes will be in the following CL. For mock of its usage please refer to bug comment #43 Bug: 897998 Change-Id: I0f8d616ec24df1ac28ca06485cd21691f2959066 Reviewed-on: https://chromium-review.googlesource.com/c/1427959Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#625130}
-
Sylvain Defresne authored
The class base::NoDestructor is a simpler way to define a static global value (aka a singleton) than base::{LazyInstance,Singleton} and is the recommended pattern to use. The changes were automated using a custom one-shot script, then fine tuned by hand (to remove unnecessary classes, ...). This fixes usages in src/ios/chrome/browser/invalidation. This CL was uploaded by git cl split. Bug: none Change-Id: Iebcc8f75afc76ce261623a3998b1cabd472a5c59 Reviewed-on: https://chromium-review.googlesource.com/c/1426682 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#625129}
-
edchin authored
Remove explicit synthesis where unnecessary. Bug: 923980 Change-Id: Ie5bef471a34625c9f890a49800bd48a496623f68 Reviewed-on: https://chromium-review.googlesource.com/c/1426398 Auto-Submit: edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch fixes a case when a text node ends with a zero width space followed by a new line. Before this fix, the sequence hits a DCHECK failure hits and both the zero width space and the new line were removed. The correct expected behavior is to collapse the new line but leaves the zero width space. Bug: 918812 Change-Id: I90255be8215862a630117950164fba00a7a6e302 Reviewed-on: https://chromium-review.googlesource.com/c/1425855 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#625127}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/24120c2a32c6..d562545e8a23 git log 24120c2a32c6..d562545e8a23 --date=short --no-merges --format='%ad %ae %s' 2019-01-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 05459e06fde5..5313c8a89964 (3 commits) Created with: gclient setdep -r src/third_party/skia@d562545e8a23 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: Ia6a33d756a4f2aa76b91c2de9f5c01d21982cc6a Reviewed-on: https://chromium-review.googlesource.com/c/1429659Reviewed-by:
-
chrome://policyJulian Pastarmov authored
When a setting is defined both as platform policy (GPO, plist, etc.) and also is present in the cloud policy then platform policy takes precedence but it also makes it difficult for an admin to trace the issue. This change exposes such situations on the chrome://policy page. For now only a hard coded English is added but eventually a localized error will be more apropriate. BUG=922957 TEST=components_unittests Change-Id: Ia8a4c7b2a1428005ddf624fb18a39faa4668ef17 Reviewed-on: https://chromium-review.googlesource.com/c/1417615Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#625125}
-
Dan Beam authored
This fixes, for example, chrome://settings/clearBrowserData checkboxes TBR=dpapad@chromium.org BUG=883049 Change-Id: I535c05ec0342a1e9fb735cfae1c48d38d10ae3d0 Reviewed-on: https://chromium-review.googlesource.com/c/1429665 Commit-Queue: Dan Beam (slow until 1/29) <dbeam@chromium.org> Reviewed-by:
Dan Beam (slow until 1/29) <dbeam@chromium.org> Auto-Submit: Dan Beam (slow until 1/29) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#625124}
-
Takashi Toyoshima authored
Current console info messages are not informative because it's shown so often, almost every time when the frame runs in background. With this patch, the message is shown only if the top request in the queue hasn't been sent in the last 1 minute when the frame is brought to the foreground. Bug: 723233 Change-Id: I6fe15b3f6928701e2858cadd0d7eb9e5c64327c6 Reviewed-on: https://chromium-review.googlesource.com/c/1333587 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#625123}
-
Sam McNally authored
i18n-values and i18n-content are deprecated, to be replaced by $i18n{} in Web UI. Allow component apps/extensions to use the same i18n template replacements as Web UI during serving. Update the Files app quickview localization covered by a test to use this method. Bug: 923206,923204 Change-Id: I647bdea906c6bc427a82981fac780cc0e6badf2c Reviewed-on: https://chromium-review.googlesource.com/c/1424619 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:Noel Gordon <noel@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#625122}
-
Tsuyoshi Horo authored
We are using the original request's request_initiator to certificate request. But we can just use an opaque Origin because SignedExchangeCertFetcher fetches the cert with LOAD_DO_NOT_SEND_COOKIES flag, and so URLRequestHttpJob::AddCookieHeaderAndStart() doesn't use the initiator(). https://chromium.googlesource.com/chromium/src/+/accda06/content/browser/web_package/signed_exchange_cert_fetcher.cc#112 https://chromium.googlesource.com/chromium/src/+/f3caee1/net/url_request/url_request_http_job.cc#691 Bug: 920905 Change-Id: If1512420c60bc971e959b66a0e25a39afacc57b9 Reviewed-on: https://chromium-review.googlesource.com/c/1429362 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
-
François Beaufort authored
This CL makes sure we don't only track autoPictureInPicture attribute set in Javascript but also declaratively in HTML for Auto Picture-in-Picture. Bug: 923879 Change-Id: I64725d99c54c302d3d65e48a32524f7b9a485a23 Reviewed-on: https://chromium-review.googlesource.com/c/1425732Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
Wez authored
Fix the //device/gamepad build rules not to add Nintendo files under Fuchsia, where they do not compile cleanly. TBR=mattreynolds@chromium.org Bug: 801717 Change-Id: Iaba2c7f61845f5e1039ad0eae851d004a8a256b9 Reviewed-on: https://chromium-review.googlesource.com/c/1429662 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#625119}
-
Dan Beam authored
TBR=dpapad@chromium.org BUG=883049 Change-Id: Icdef0838145fbc7c207d1c3d57b9cb4d13d1cbb4 Reviewed-on: https://chromium-review.googlesource.com/c/1429759Reviewed-by:
-
Lei Zhang authored
Move most of OutOfProcessInstance::SendNextAccessibilityPage() out into its own function. Then unit test it. Change-Id: I54590ac004f11d918ccb45a3e071d9cf19a927ed Reviewed-on: https://chromium-review.googlesource.com/c/1407265 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#625117}
-
Jamie Madill authored
This mixin will allow a fallback to the older stable driver version after ten minutes of failing to find the new driver version. Bug: 887241 Change-Id: Ieb279babadb6f57441b3c72172f70d4014b2bf8a Reviewed-on: https://chromium-review.googlesource.com/c/1422838 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#625116}
-
jdoerrie authored
This change modifies to base::FilePath::StringType to be base::string16 on Windows. Currently there is no difference between this and the old typedef to std::wstring, but this will change once base::string16 is std::u16string on all platforms. Bug: 911896, 23581 Change-Id: Id7604ca365343de8f05c384d5504e4ed8ab99110 Reviewed-on: https://chromium-review.googlesource.com/c/1425729Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#625115}
-
Donna Wu authored
Bug: 716628 Change-Id: I0eb098a88533effec8b67b499fe98f8b39b20fc3 Reviewed-on: https://chromium-review.googlesource.com/c/1420274 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#625114}
-
Alex Danilo authored
Attempting to open a '.exe' or '.msi' file shows a dialog explaining that those are Windows specific files that aren't compatible with ChromeOS. That dialog included text directing users to the Chrome Web Store which doesn't provide a fix for issue of being able to run a '.exe' file. Bug: 787472 Tests: Ran all browser and unit tests, have existing coverage for this. Change-Id: I625467161499527a0e74fa8c2b4cd6e07a3819fd Reviewed-on: https://chromium-review.googlesource.com/c/1426337Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#625113}
-
Kent Tamura authored
This CL has no behavior changes. Change-Id: I3318702f9e20937b180149c3cfe8b4a465317c20 Reviewed-on: https://chromium-review.googlesource.com/c/1405113Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#625112}
-
Dan Beam authored
Screenshots: https://imgur.com/a/9VhTdfx R=dpapad@chromium.org BUG=883049 Change-Id: I75fab44827d25f89fc39e474419701dca4d306a4 Reviewed-on: https://chromium-review.googlesource.com/c/1428680 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#625111}
-
Christopher Thompson authored
The new functions in chrome/browser/ssl/origin_util.* wrap the function content::IsOriginSecure() and apply per-profile enterprise policy overrides. This will allow all call-sites in chrome/browser/ to correctly handle the OverrideSecurityRestrictionsOnInsecureOrigin policy. As a first step, this also changes PermissionContextBase to use the new wrapper function, fixing a bug where enterprise policy failed to allow notifications on policy-allowed origins. Bug: 920819 Change-Id: Iaaaefbd0888e90f51dac73435e8c152e649001a9 Reviewed-on: https://chromium-review.googlesource.com/c/1417840 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#625110}
-
Weiyong Yao authored
The new web-contents capturers don't request wake lock as the old version does, given the thought it's the applications responsibility to do so. But the fact is there are many consumers of the video stream from tab capturing and none of them is doing wake-lock. So it seems it's most convenient to re-do the wake lock requesting in the new web-contents capturers for now. This cl is to fix the regressions. We may revisit this if all the remoting impls have wake lock applied. Bug: 917529 Change-Id: I6ce726dcd3e45666079e9e856b5eff2914237e96 Reviewed-on: https://chromium-review.googlesource.com/c/1401844 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#625109}
-
Paul Dyson authored
Bug: 899123 Change-Id: I087426528e995bbd7cb4c168ca5aec38b6d8b722 Reviewed-on: https://chromium-review.googlesource.com/c/1426339Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#625108}
-
Takashi Sakamoto authored
This reverts commit 7a172974. Reason for revert: Suspect compile failure on Win32-rel https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win32-rel/10047 Original change's description: > libwebp: update to 1.0.2 > > minor encoder speedups and roll up to pick up local fuzzer cherry-pick > > Bug: 922319 > Change-Id: I2c8be4423aab86c406c3d4d2848950178337da3c > Reviewed-on: https://chromium-review.googlesource.com/c/1412021 > Reviewed-by: Urvang Joshi <urvang@chromium.org> > Commit-Queue: James Zern <jzern@google.com> > Cr-Commit-Position: refs/heads/master@{#625099} TBR=jzern@google.com,urvang@chromium.org Change-Id: I8bb8f22990696269d18f35a95aa611ab4a3efeba No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 922319 Reviewed-on: https://chromium-review.googlesource.com/c/1428629Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#625107}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/828acb39df5f..5313c8a89964 git log 828acb39df5f..5313c8a89964 --date=short --no-merges --format='%ad %ae %s' 2019-01-23 syoussefi@chromium.org Implement EGL_KHR_fence_sync and EGL_KHR_wait_sync Created with: gclient setdep -r src/third_party/angle@5313c8a89964 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I546e9f622b185ca263aaf0d4b1d3b3c85aa0cffa Reviewed-on: https://chromium-review.googlesource.com/c/1429500Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0550ef03..2307cc4b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3b6e9cd8b623e5189a256b34242bcb29029b93ec Reviewed-on: https://chromium-review.googlesource.com/c/1429384Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625105}
-
Jon Napper authored
Added a predictor class for the new NN classifier in AssistRanker. This makes it possible to use downloadable unquantized NN classifiers for inferencing. Bug: 907727 Change-Id: Ib1e5647e3792f10757c17968a6b0b9b198a8d620 Reviewed-on: https://chromium-review.googlesource.com/c/1399768 Commit-Queue: Jon Napper <napper@chromium.org> Reviewed-by:
-
Danan S authored
Bug: 923575 Change-Id: I9e11fb01e3f6914c58a3f2204b2c617f6d20adda Reviewed-on: https://chromium-review.googlesource.com/c/1423353Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Danan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#625103}
-
Matt Falkenhagen authored
This enables the variations header to be added to the request, and other modifications by the embedder. Basically it looks like any network request should go through throttles. Bug: 923247 Change-Id: I7cb2d3a7edfff866487814884e0b44f4000dbca5 Reviewed-on: https://chromium-review.googlesource.com/c/1424098 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#625102}
-
Hirokazu Honda authored
VEA unittest verifies VEA's encoding content by 1. decode content by FFmepgVideoDecoder 2. compare it with the original VideoFrame and computes SSIM 3. check the SSIM less than or equal to the predetermined threshold, 10.0. VEA unittest turns on this verifitcation by --verify_all_output and one of test case parameters. This verification was always disabled on Chrome OS by setting --verify_all_output false because of https://crbug.com/694131. I think the bug is already fixed. We can re-enable the verification on Chrome OS now by default. TBR=kcwu@chromium.org Bug: 923762 Test: VEA unittest on eve Change-Id: I597346a9ecd114ccc37ebde1ab284b97103a6e4f Reviewed-on: https://chromium-review.googlesource.com/c/1429307Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#625101}
-
Alexandre Courbot authored
posix_memalign() returns an error value when it fails, but that value is not forwarded to the user despite being valuable to understand what the underlying problem of a failed allocation is. Make sure to display the error code. Chrome OS. Bug: 918509 Test: Checked that software video decoding was still working on Change-Id: I508d6cc6332a1a5c29e8f3cece56272969e99dcc Reviewed-on: https://chromium-review.googlesource.com/c/1424108 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#625100}
-
James Zern authored
minor encoder speedups and roll up to pick up local fuzzer cherry-pick Bug: 922319 Change-Id: I2c8be4423aab86c406c3d4d2848950178337da3c Reviewed-on: https://chromium-review.googlesource.com/c/1412021Reviewed-by:
Urvang Joshi <urvang@chromium.org> Commit-Queue: James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#625099}
-
Dominic Farolino authored
This CL gates Priority Hints behind an origin trial. Note, the preload scanner must know about the status of the Priority Hints origin trial in its ExecutionContext, and since it has no access to an EC itself, this CL adds a priority_hints_origin_trial_enabled flag in a few higher-level classes that create the preload scanner, so that the necessary information can be passed in. I2E: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/jpeSdM897Xw R=kinuko@chromium.org, kouhei@chromium.org, yhirano@chromium.org, yoavweiss@chromium.org Bug: 821464 Change-Id: I767cee02cb1797c35d792c1682d5414fa56a0a20 Reviewed-on: https://chromium-review.googlesource.com/c/1426439 Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
This changes the DataSaverForWorkerBrowserTest //chrome test to use the //chrome test data directory. Before it was using both //content and //chrome and therefore failing when a file of the same name existed in both directories. Bug: 901082, 922291 Change-Id: Ibf3982750ba65f1fd9f8b31fc6f5583e08fc4ff2 Reviewed-on: https://chromium-review.googlesource.com/c/1424520 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
