- 29 Aug, 2019 40 commits
-
-
Luum Habtemariam authored
Recent refactor enforces explicitly tagging a default TaskRunner as coming from the 'base::ThreadPool()'. Bug: none Test: unittests now build Change-Id: I93956800cceb92c9e302c1047d45eb713d3aae39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776399Reviewed-by:
Nikita Podguzov <nikitapodguzov@google.com> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#691688}
-
Yuke Liao authored
These print statements were used for debugging puporse, but forgot to remove when land the CL, so this CL cleans them up. TBR=robertma@chromium.org Change-Id: Ib327231c5f2dcf7e288013a315a45c5604f2da2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776381Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#691687}
-
Elly Fong-Jones authored
This change adds support for CSV reporting to //tools/flags/list_flags.py. When --verbose is supplied, list_flags.py will: 1) Compute the actual set of owners for each flag (i.e., resolve //path/to/OWNERS references into a set of users), and 2) Emit its output as a CSV whose columns are: flag name, expiration milestone, originally listed owners, and resolved owners. The two latter columns are space-separated lists themselves. This allows TPMs to produce email notifications for flag expiration more easily. This change also adds a --testonly flag to list_flags.py, which causes it to silently exit after running its self-tests. Bug: 953690 Change-Id: Ia71868aa48d6044e5b64ca0ab9c3625967469245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760275 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#691686}
-
Koji Ishii authored
This patch sets to create a box fragment (not to cull) empty inline boxes. |NGInlineBoxState| already computes positions/sizes of empty inline boxes if it were set not to be culled (e.g., by setting background), but the emptiness was not included in the condition to set |ShouldCreateBoxFragment()|. According to crbug.com/997705, legacy works in some cases, but not in any of simplified test cases nor in other issues. Some changes needed in other code and/or tests: * |AbsoluteBoundingBoxRectHandlingEmptyInline| fails when the inline box is not culled. This patch fixes |LayoutInline::AbsoluteBoundingBoxRectHandlingEmptyInline()|. * |NGPaintFragmentTest| has empty inline box by mistake. Fixed. * The |offsetLeft| of <area> element is different when it is not culled. It looks like it is not interoperable, fixed the test not to rely on it. * fast/css/non-empty-span.html looks like it was incorrectly rebaselined for LayoutNG. The new rebaseline in this patch matches to legacy/Gecko/Edge. Bug: 680075, 953479, 997705 Change-Id: I1726d1a573e34d88cc91b1950bfa8e327966833c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774418 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#691685}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fdfb44eeed33..04fc7733eda6 git log fdfb44eeed33..04fc7733eda6 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 zamorzaev@chromium.org cbuildbot: Fix environment for testplan Created with: gclient setdep -r src/third_party/chromite@04fc7733eda6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I97957bc9d591ed3348aed2702a17d4bc56f3041d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775752Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691684}
-
Vladislav Kaznacheev authored
Previously the animation was only initited from the ExpandArrowView constructor which is now being called only once upon the AppView construction. Introduced a MaybeEnableHintingAnimation method to be called every time the launcher state is changing. Replaced PostTask with OneShotTimer to prevent multiple tasks being scheduled in parallel. The timer is canceled whenever AppList is closed. Added a unit test. Bug: 989181 Test: manual Change-Id: I042ed4916497d2d70c900bdddcfce5a3b809342b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775069 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#691683}
-
Tricia Crichton authored
Add check for readable timestamp format in ChromeDriver's log reader. This allows ChromeDriver to successfully replay Dev Tools commands for log replay when logs were recorded with --readable-timestamps. Bug: chromedriver:3095 Change-Id: I3a4a9bf0c43b346daece0aaf595c725a47904d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766431Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#691682}
-
Yuke Liao authored
linux-coverage-rel has been folded into linux-rel, and now that we've verified it sticks, it's safe to clean it up. Bug: 930364 Change-Id: Ic722cabeaf3b9b604ff96c584a838b3a1e1d999a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775360Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#691681}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c5875c2f..d96f3e7d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I48a7355d830f303262fec7e4a8590c74809b9105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775875Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691680}
-
Synthia Islam authored
This is a reland of 2c5431c5 Additionally Modified Logic by prepending comment with contents in order to avoid Deterministic Linux Build Infra fail Original change's description: > Add comment at the top of auto generated files > > Add comment like "// this file is autogenerated, do not edit" > at the top of the files generated from .mojom files > > > Bug: 609794 > Change-Id: I1b39afc0d7c054510f7446af8795e606f07fdfdb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757406 > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689608} Bug: 609794 Change-Id: I579fa81f36385e02e939742cefbf39289ca1ef50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775653Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#691679}
-
Xianzhu Wang authored
This reverts commit 0bc5ba70. Reason for revert: Not the cause of crbug.com/996037. Original change's description: > Revert "Cache animation base computed style only on default StyleForElement()" > > This reverts commit a1fe850a. > > Reason for revert: speculative revert for crbug.com/996037. > > Original change's description: > > Cache animation base computed style only on default StyleForElement() > > > > StyleForElement() can be used to get the default style (i.e. the > > style that will be applied on the element), or style derived from > > custom parent style for e.g. inherited first line style. We should > > cache animation base computed style in the first case only. > > > > Bug: 989490 > > Change-Id: Ia30b3e7bcd65cdb9456eb925e5c24f156353bff9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753030 > > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#686915} > > TBR=wangxianzhu@chromium.org,futhark@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 989490,996037 > Change-Id: Ib12e4e55e70eaeb2c82ca173c145c225c1d79802 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763343 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689165} TBR=wangxianzhu@chromium.org,futhark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 989490, 996037 Change-Id: I32dc5509075cfae90721dadc49144a309b40b901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776380Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#691678}
-
Yuke Liao authored
This CL updates the documentation for per-cl coverage. Bug: 930364 Change-Id: Id22ee2f22bd8e170253af7d82b86fa7b9bd766d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774907Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#691677}
-
Natalie Chouinard authored
The customizations to ChromeBaseListPreference over the base class are not used by any current preference screens, so removing it here in favor of standard Support Library ListPreference. Change-Id: Iace782016af16e4765d5dea0683df168a8d11287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774271Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#691676}
-
Mugdha Lakhani authored
Bug: 998466 Change-Id: Iaba8aa50f37d87597ac46edf9626553936546f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776041 Auto-Submit: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#691675}
-
Natalie Chouinard authored
Match Settings activity status bar to the modern status bar design used in the main activity. Status bar color is set programmatically for M+ devices. The default is set via XML only for O+ devices due to crbug.com/884144. A kill switch is included to disable programmatically setting the status bar color due to crbug.com/880694. Bug: 860848 Change-Id: Icb966bd3655b986d82eddf19efb20e6fd89063ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748123 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
-
Stephen McGruer authored
ValidationMessageOverlayDelegate hosts an internal blink::Page which is not properly integrated into the normal BeginMainFrame flow. As such, it needs to be manually prodded in various places. Integration already existed for layout and paint - this CL adds animations as well. This previously worked because blink::AnimationClock would advance its own time (against the spec), and so the internal Page would see advancing time and the animation would keep ticking. When we fixed blink::AnimationClock to be by the spec, we also broke this. This CL also makes sure that the animation used by ValidationMessageOverlayDelegate is not composited; the internal Page has no compositor so composited animations will not work. Bug: 990680 Change-Id: I16aaddbfa57eaefadfb557fc9cb435d94672e637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763162 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#691673}
-
Samuel Huang authored
This CL adds helper functions to load DevUI DFM native resources. * Add enum chrome::FILE_DEV_UI_RESOURCES_PACK to specify path for "dev_ui_resources.pak" on Android. * Add LoadAndroidDevUiPackFile(). * Adds another {file descriptor, memory mapped file regions} global variable in resource_bundle_android.h. All these will be cleaned up in the future. * Add LoadDevUiResources() (in new file) as the main function to call to load DevUI DFM resources (hidden behind DFMIFY_DEV_UI). * There's no need for a function to return the file descriptor of "dev_ui_resources.pak", because we do not intend to forward it to child processes. Bug: 927131 Change-Id: I0c4e42e33b959d0a022f1287748573ebaf79c685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769218Reviewed-by:Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#691672}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2296e5a4416f..2fe742d3173c Created with: gclient setdep -r src-internal@2fe742d3173c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id40cac32c17469dab624d22191d3b70b396ba5cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775751Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691671}
-
Ryan Sleevi authored
Presently, the handling for an IDL-nullable type "Foo?" is buried within the type mapping documentation for nullable_is_same_type, making it easy to overlook. Update the informational table that serves as a quick reference for IDL to C++ types to include a note about it, as well as a reference to the customizability. Bug: 998985 Change-Id: If4e6609da44d1c2cbb81c32a1712d032e2c3a13a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774330 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
-
Becca Hughes authored
This was never used and therefore we can remove it. If there is old data stored then this will also remove it. BUG=998687 Change-Id: I9ad4a99c3fa2f8786f302bad7334a7882e2d75eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775186Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#691669}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9b593a3406f4..43bcbe51555d git log 9b593a3406f4..43bcbe51555d --date=short --no-merges --format='%ad %ae %s' 2019-08-29 dberris@chromium.org Pinpoint: Post issue update on job creation Created with: gclient setdep -r src/third_party/catapult@43bcbe51555d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:998668 Change-Id: Ie92b9eadaddff7d38f7ee9c88b76daeb10d386e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776213Reviewed-by:
-
Gauthier Ambard authored
When moving out of NativeContent, the reload functionality of the NTP when used with the tools menu was lost. This CL adds plumbing to fix it. Bug: 998537 Change-Id: Ie3c931fa78afd1d38dcf646b419cd405cdf572d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774929Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#691667}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2e290878. With Chromium commits locally applied on WPT: 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." d3b97055 "Update simulateUserActivation to match webxr-test-api spec" 2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest" 90789f54 "Implement fallback to element anchor" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I4a1ea9c7adccb2c40b7e3a91e48c5c364dba83bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775870Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691666}
-
Tommy Steimel authored
This CL changes MediaNotificationBackground to use the native theme for determining the default background color instead of using a constant white color. This fixes an issue where the GMC dialog was white even when dark mode was on. Bug: 981218 Change-Id: I668fe7af83286242e4fb5505b49acf53b185af79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775372Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#691665}
-
Charlene Yan authored
Only handles the single select case. Bug: 905491 Change-Id: I7d4f66b3c611b04258650816d3bebb1a8b5b4fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703021Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#691664}
-
Ulan Degenbaev authored
Bug: 677883 Change-Id: I7d594c9046ca8ae9c94a4be83aee92580f3c4edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710321Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#691663}
-
Marc Treib authored
It creates a second instance of a PasswordStore, which will be used to store Gaia-account-scoped passwords. So far, it is not hooked up to anything at all. TBR=jzw@chromium.org TBRing a purely mechanical change in web_view_password_store_factory.mm Bug: 998455 Change-Id: I775aa7ed66c0ee712e57370fc85d35f7c8e8474a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771911 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#691662}
-
Owen Min authored
Before: https://drive.google.com/file/d/1MZ4wt7LW68CK-KqzLKgLKuZNNUBcrS59/view?usp=sharing After: https://drive.google.com/file/d/1uyUPqdoWE69pp18Q811GsY1JSxSBHMN3/view?usp=sharing Bug: 990406 Change-Id: I674fa16a398f376bafd240bbc54e92786cd2372e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742522Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#691661}
-
Chris Lu authored
Now that FindinPageController's completionBlocks don't get executed, use a TestFindInPageResponseDelegate. Also removes detachFromWebState call because it actually breaks things by nulling out the webstate before it is destroyed. Bug: 919685, 996324 Change-Id: I503c9452d5ee9120aec0c9c1b79fd91379996965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749306Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#691660}
-
Miyoung Shin authored
This CL converts UsbDeviceClientPtr in chrome, extensions and services to the new Mojo types, and uses pending_remote<UsbDeviceClient> in usb_manager.mojom Bug: 955171 Change-Id: Ib71a9f3efe50cb2e8654982d0d47be7b6e5b2ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773007 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Bill Budge authored
- Adds a custom BigIOBuffer subclass of net::IOBufferWithSize, backed by a mojo_base::BigBuffer. - Uses this buffer to avoid a copy for large code data (> 64KB). In order to avoid a copy, the disk entry is read in two parts, response time and code. - Small code data (< 64 KB) uses a single read and copies as before. Bug: chromium:992991 Change-Id: I520c8983b04c323e8ea9c8d817f94a3a64b4f7c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769084Reviewed-by:
-
Lucas Furukawa Gadani authored
This CL also adds a conversion to and from the mojom type to network::ResourceResponseHead. This will allow the conversion of the struct to the mojom type to be split into smaller CLs. Bug: 984550 Change-Id: I7cf6adebddf90bb9cb4df41cf51db3e46cc7fef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758653Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#691657}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/16946e3781ec..44dc241ae8d6 git log 16946e3781ec..44dc241ae8d6 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 alexnarest@google.com Allows configuration of playout audio buffer 2019-08-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9dd4f35a..52323b9f (691474:691589) Created with: gclient setdep -r src/third_party/webrtc@44dc241ae8d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I413a944e1c3b20f9c083860573a45845db5fda78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776211Reviewed-by:
-
Eric Stevenson authored
This is to make proxy natives (crbug.com/929661) work with DFMs. Previously, native methods using proxy natives in DFMs were just excluded from the bundle. See go/chrome-dfm-proxynatives for more context. Bug: 995405 Change-Id: I1dd59fa1b1a1a4629e39f56007066569c4b83345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775268 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
-
Ankit Kumar 🌪️ authored
PdfAccessibilityTreeTest.TestPreviousNextOnLine fails on builders for MSan tests. The actual code uses bounds which were not initialized in the tests. This CL initializes all uninitialized variables of the struct for the test file. Bug: 981448, 999076 Change-Id: Ie26c1fea6f394bfcbd57db5bc47fd121241ef4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775881 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
-
Jérôme Lebel authored
When unified consent is enabled, Privacy settings should not observe metric reporting preferences. The metric reporting settings has been moved Google Services settings. Bug: 998500 Change-Id: I8e3cc2f91a88d373bf9e28ed3eacbe3d1b78d25f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776048Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#691653}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2198b0fe1a2d..a9af883e9787 git log 2198b0fe1a2d..a9af883e9787 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 bclayton@google.com WSI: Very basic XCB surface implementation. Created with: gclient setdep -r src/third_party/swiftshader@a9af883e9787 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/124265819,chromium:b/139412276,chromium:b/139491466 Change-Id: Ic04ce98c0522c2d79693755238a80419b40b50c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776208Reviewed-by:
-
Tomas Popela authored
The main reason for the flag is so called dialog hell, when you try to share the screen on Wayland through PipeWire. To address it we are waiting for work that needs to be done in the upstream[0] and Chromium needs to be adapted to it together with other changes that will remove the UX problems. Once that's done the flag could be removed. [0] - https://github.com/flatpak/xdg-desktop-portal-gtk/issues/204 Bug: 682122 Change-Id: Iff3cad65dcce40de18968f6b7e3dfe4ecb8e55bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768354Reviewed-by:
-
Fernando Serboncini authored
Bug: 988125 Change-Id: I015694f778f7f8ae2a58a667f45b2aff184abf19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776221 Auto-Submit: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#691650}
-
Antonio Gomes authored
... instead of std::circular_deque. This is a follow up of haraken's remark in [1]. It affects the following classes: - RTCVideoEncoder::Impl - RTCVideoDecoderAdapter [1] https://crrev.com/c/1775002/2/third_party/blink/renderer/platform/peerconnection/rtc_video_encoder.cc#246 BUG=952716, 787254 R=guidou@chromium.org Change-Id: I1a90f1e016da250dd76663ed999887e52a71f487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775864 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#691649}
-
