GitLab

BUG=345554
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/216573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260095 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357509
TEST=none
R=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/216173005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260094 0039d316-1c4b-4281-b951-d872f2087c98

BUG=348637
TEST=none
R=nkostylev@chromium.org
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/216553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260093 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds Download folder path migration from /home/chronos/u-hash/Downloads
to /home/chronos/user/Downloads when in the current running environment the
profile path is set as the latter. It can happen when (1) the user enabled and
then disabled the multi-profile flag, or (2) performed restart from about:flags.
In such situations we need back migration not to break configurations.

In addition, inserted path convertion to public functions in open_util so that
paths stored in download history (during flipped path due to about:flags) can
be correctly handled.

BUG=356322,329744
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/216053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260092 0039d316-1c4b-4281-b951-d872f2087c98

These tests draw a light green circle on a background.
The test expect a certain background color, but what color the edge of the circle has is undefined.

BUG=357279
R=mcasas@chromium.org

Review URL: https://codereview.chromium.org/216353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=270356,265945
R=lambroslambrou@chromium.org

Review URL: https://codereview.chromium.org/214193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260089 0039d316-1c4b-4281-b951-d872f2087c98

The new message is currently used only for keys for which Android
generates ACTION_MULTIPLE events.

BUG=265945,270356
R=lambroslambrou@chromium.org

Review URL: https://codereview.chromium.org/214173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260088 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260087 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=170192:170228&mode=html

TBR=enne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/216293004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260086 0039d316-1c4b-4281-b951-d872f2087c98

All callers check for NULL already.

R=piman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/212993008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260085 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357294
R=sky@chromium.org

Review URL: https://codereview.chromium.org/215743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260084 0039d316-1c4b-4281-b951-d872f2087c98

Tests that depend on this flag actually fail since the UI compositor
creates an OutputSurface which makes the GPU process launch before
the test body gets to run.

Since this flag doesn't really make sense with a UI compositor present,
we should move these tests to not be browser tests. Since they just
pass by early-out right now, remove the early outs and disable them.

R=jbauman@chromium.org, piman@chromium.org
BUG=356876

Review URL: https://codereview.chromium.org/212603006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260083 0039d316-1c4b-4281-b951-d872f2087c98

BUG=279653

Review URL: https://codereview.chromium.org/208833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260082 0039d316-1c4b-4281-b951-d872f2087c98

If a mojom interface method specifies response parameters, then we'll generate javascript bindings that provide an additional callback parameter used to pass the response parameters. This mirrors the C++ implementation.

A future improvement will likely be to use promises instead, especially now that they are enabled on trunk.

As part of this CL, connector.js was also made consistent with connector.cc. It starts reading the message pipe immediately, handles write failures in a similar fashion, etc.

The Connection type from connector.js is factored out into a separate file as it now holds a Router object. router.js mirrors router.cc. The Connection type is really the mirror of the C++ RemotePtr<S> type.

Some basic request/response tests were added to connection_unittests.js. We'll probably want more testing.

R=abarth@chromium.org
TBR=mpcomplete@chromium.org

Originally reviewed at https://codereview.chromium.org/207503004/

Review URL: https://codereview.chromium.org/216443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260081 0039d316-1c4b-4281-b951-d872f2087c98

This CL eliminates //chrome dependencies from SigninAccountIdHelper. It
additionally adds an observer-like API to SigninClient and uses this API to
have ChromeSigninClient performs the LocalAuth functionality that SigninManager
was previously performing (LocalAuth will remain a //chrome-level concept).

BUG=354864,354866
TBR=thakis

Review URL: https://codereview.chromium.org/205703005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260080 0039d316-1c4b-4281-b951-d872f2087c98

BUG=293011
R=dmazzoni@chromium.org,oshima@chromium.org

Review URL: https://codereview.chromium.org/213233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260079 0039d316-1c4b-4281-b951-d872f2087c98

Update owners file based on latest project status since many of owners
in text input are now working on different team.

yukishiino@ will be the primary reviewer of IME binding(ui/base/ime) for all
platform(Chrome OS, Linux Aura, and Windows Aura).
shuchen@ will be the primary reviewer of Chrome OS IME engine including
extension binding.
mukai@ will be the primary reviewer of IME specific UI components.

BUG=None
TEST=None
NOTRY=True

Review URL: https://codereview.chromium.org/209393013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260076 0039d316-1c4b-4281-b951-d872f2087c98

Changes in this CL include:
1. Initialize breakpad in it2me native messaging host
2. Create bundles for it2me and me2me native messaging hosts and move them out of the me2me host bundle (and update the manifests accordingly).
3. Dump symbols of the it2me and me2me native messaging hosts
4. Sign the me2me and it2me native messaging hosts
4. Rename the me2me host bundle and the prefPane bundle to get rid of the internal chromium/chromoting names and to conform to Mac convention
5. Refactor GYP, build-installer-archive.py, and do_signing.sh, etc to use name constants from branding_chrome and branding_chromium instead of hard coded names. This ensures that all the name constants are defined in a central location and reduces duplicate name definitions. 

Here are the names of the host bundles:

me2me host:
old name: org.chromium.chromoting.me2me_host
new name: ChromeRemoteDesktop.Host

Pref pane:
old name: org.chromium.chromoting.prefPane
new name: ChromeRemoteDesktop.prefPane

it2me nm host:
name: NativeMessagingHost 
Full Path: /Library/Google/ChromeRemoteDesktop/NativeMessagingHost.app

me2me nm host:
name: RemoteAssistanceHost 
Full path: /Library/Google/ChromeRemoteDesktop/RemoteAssistanceHost.app

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259287

Review URL: https://codereview.chromium.org/186763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260075 0039d316-1c4b-4281-b951-d872f2087c98

BUG=356366
TEST=browser_tests:VolumeControllerSoundsTest.*

Review URL: https://codereview.chromium.org/212793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260073 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=build player_x11
TBR=scherkus

Review URL: https://codereview.chromium.org/215873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260072 0039d316-1c4b-4281-b951-d872f2087c98

This introduces a new class, AudioBufferConverter, which takes AudioBuffers of arbitrary formats and converts them to AudioBuffers of a common format.

To support config changes seamlessly we use the AudioBufferConverter to convert incoming AudioBuffers to the hardware output format as we get them from the AudioBufferStream. This way the rest of the audio pipeline doesn't need to handle config changes.

We only enable this conversion step for DemuxerStreams that support config changes (namely ChunkDemuxerStream).

BUG=347270
TEST=AudioBufferConverterTest
NOTRY=true
R=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/177333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260071 0039d316-1c4b-4281-b951-d872f2087c98

BUG=346626

Review URL: https://codereview.chromium.org/214203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260070 0039d316-1c4b-4281-b951-d872f2087c98

I have a plan to add more audio player tests. Before that, make audio player tests
separated for readability.

BUG=none
TEST=browser_test passes
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/214463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260069 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org

Review URL: https://codereview.chromium.org/213693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260068 0039d316-1c4b-4281-b951-d872f2087c98

That way, the debug URL is chosen only if the app will be debugged.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=3765
R=bradnelson@google.com, tsepez@chromium.org
TBR=bradnelson@chromium.org, teravest@chromium.org

Review URL: https://codereview.chromium.org/212103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260067 0039d316-1c4b-4281-b951-d872f2087c98

TBR=noamsml
NOTRY=true

Review URL: https://codereview.chromium.org/216123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260064 0039d316-1c4b-4281-b951-d872f2087c98

Everybody should be building blink_tests right now. As it is today all_webkit is just an alias to blink_tests.

It was added by r233699 - https://codereview.chromium.org/59233012

Blink side - https://codereview.chromium.org/191973002

Nobody seems to be using it anymore.

BUG=None
TEST=None (no functional changes).
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/214703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260063 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Allows menu host windows to be enumerated in DragTargetWindowFinder (https://codereview.chromium.org/196213004/)

Reason for revert:
Seems to have broken views_unittests on the Linux builder.

Original issue's description:
> Allows menu host windows to be enumerated in DragTargetWindowFinder.
> We create a cache that holds all XIDs of the menu windows that get created in X. The menus are evaluated for being drop targets before enumerating other windows. The menu XIDs cache gets updated in a root X11DesktopHandler when any menu (and Chrome menu in particular) gets created.
> 
> TBR(sky) for OWNERS in ui/base/ui_base.gyp.
> 
> BUG=349154, 349156, 344747
> TBR=sky
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260046

TBR=sadrul@chromium.org,erg@chromium.org,varkha@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=349154, 349156, 344747

Review URL: https://codereview.chromium.org/216133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260062 0039d316-1c4b-4281-b951-d872f2087c98

Have the SimplyMessageBoxViews record the user response in a MessageBoxResult
it doesn't own, so that the user-response is available even after the dialog
has been destroyed. This simplifies the lifetime of the message-box a bit.

BUG=355083
R=sky@chromium.org

Review URL: https://codereview.chromium.org/215353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260061 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260059 0039d316-1c4b-4281-b951-d872f2087c98

These metrics should help us understand whether users are ok with granting
Chrome access to their "Me" card for Autofill or if the system's permissions
dialog scares them away.

BUG=355516
TEST=none
R=asvitkine@chromium.org, pinkerton@chromium.org

Review URL: https://codereview.chromium.org/212233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260057 0039d316-1c4b-4281-b951-d872f2087c98

See snapshot at https://x20web.corp.google.com/~guohui/snapshot.png

BUG=

Review URL: https://codereview.chromium.org/210153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260056 0039d316-1c4b-4281-b951-d872f2087c98

Removed LoggingStats class and replaced them with StatsEventSubscriber.
StatsEventSubscriber differs in that the type of event to listen to
(audio / video / other) is determined at construction. The API to get
the stats map changed as well - caller now passes in an empty map that
will get assigned with the data. These changes are in line with the
EncodingEventSubscriber. The logic to calculate stats remains the same
as LoggingStats, though this will probably change in the future. Stats
can be reset as well via Reset().

In addition since stats gathering now depends on collection of raw
events (which is enabled everywhere), the flag to enable stats
collection in CastLoggingConfig has been removed.

Removed CastLoggingConfig struct - logging is enabled always now.
There are no use cases where it should be disabled.

BUG=353019

Review URL: https://codereview.chromium.org/210303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260055 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664

Review URL: https://codereview.chromium.org/207123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260054 0039d316-1c4b-4281-b951-d872f2087c98

This adds docserver support for interface definitions living in //apps.

A placeholder definition exists to prevent the docserver from choking
on an empty API path.

BUG=357284
NOTRY=true
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/214843006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260053 0039d316-1c4b-4281-b951-d872f2087c98

If a interface has both permanent and temporary address, then based
on the policy setting provide both or temporary address only.

Due to privacy concerns webrtc don't want to expose permanent addresses to remote endpoints.

R=agl@chromium.org

Review URL: https://codereview.chromium.org/213423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260052 0039d316-1c4b-4281-b951-d872f2087c98

TBR=pkasting@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG=356850

Review URL: https://codereview.chromium.org/215943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260051 0039d316-1c4b-4281-b951-d872f2087c98

Also begin rearranging tests. (I'm deferring moving macros_unittest.cc
until after I split macros.h.)

R=darin@chromium.org

Review URL: https://codereview.chromium.org/214753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260048 0039d316-1c4b-4281-b951-d872f2087c98

apkbuilder only uses sourcefolder to package non-java files (see
addSourceFolder() and checkFileForPackaging() in
https://android.googlesource.com/platform/sdk/+/e162064a7b5db1eecec34271bc7e2a4296181ea6/sdkmanager/libs/sdklib/src/com/android/sdklib/build/ApkBuilder.java ),
and our java/src folders only contain .java (and OWNERS) files.

(Determined via `find . -type f -a -path '*/src/*' -a -not -name '*.java'` and
manually ignoring everything not looking like a java folder.)

No intended behavior change; Chrome.apk looks identical with and without
this change (except for timestamps).

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/212173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260047 0039d316-1c4b-4281-b951-d872f2087c98

We create a cache that holds all XIDs of the menu windows that get created in X. The menus are evaluated for being drop targets before enumerating other windows. The menu XIDs cache gets updated in a root X11DesktopHandler when any menu (and Chrome menu in particular) gets created.

TBR(sky) for OWNERS in ui/base/ui_base.gyp.

BUG=349154, 349156, 344747
TBR=sky

Review URL: https://codereview.chromium.org/196213004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260046 0039d316-1c4b-4281-b951-d872f2087c98