- 04 Sep, 2019 34 commits
-
-
Antonio Gomes authored
This is a reland of 19c2d0e4 This CL has no changes compared to the original one. The error was on CL https://crrev.com/c/1778671 (already relanded in https://crrev.com/c/1782514). Original change's description: > Onion soup content/renderer/media/webrtc/rtc_video_encoder_factory.cc|h > > This is phase 2.3 on the design document [1]. > > [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ > > BUG=787254 > R=guidou@chromium.org, haraken@chromium.org > > Change-Id: I32628d84aaba9eba9bde7c9484f8984517b9abf4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778673 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692762} TBR=guidou@chromium.org Bug: 787254 Change-Id: Ia59c58a57dc84322408f64181057819adf4bdad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783208Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#692963}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2a9114f34ad3..0b56e61af91f Created with: gclient setdep -r src-internal@0b56e61af91f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I38d3efcca91593930cf30cd13e00ccee2ea194ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783740Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692962}
-
Yutaka Hirano authored
TBR=alph@chromium.org Bug: 1000512 Change-Id: I0d7a4a777c8dd193284308bab5a35e394c947d40 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782189Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#692961}
-
Andrew Xu authored
Bug: 918024 Change-Id: I81fa612bb3313da87787cc5cd10463da2b352594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782989 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#692960}
-
Hesen Zhang authored
- This CL glues native to Java side for icon data. Bug: 963290 Change-Id: Iba99a50c21b75e8f0a123171cb5362880dc35e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783229 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#692959}
-
Henry Jian authored
Previously, we set is_primary_icon_maskable to true if the primary icon has a "maskable" purposes in it. Turns out it's not necessary and makes server code more complex. This CL makes Chrome directly send the image purpose to server (an image may contain multiple purposes, Chrome may not send all purposes, but just one of them). The purpose field existed in webapk.proto since a long time ago, but was reserved because it wasn't being used. This CL un-reserves it Bug: 977173 Change-Id: I6793d836a2f993862c191b1bc301151bdf64a15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782015 Commit-Queue: Henry Jian <hzjian@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#692958}
-
Lorne Mitchell authored
The localization system was correctly discovering the modules.json file and added the titles to a .grdp file, but ls() was not being called on the property. The fix was to call ls() on the quick open help provider's title descriptor. Screenshot of the quick open available commands menu (i.e. Ctrl+p+?): https://imgur.com/a/7fIWw8f Bug: 941561 Change-Id: I8c4659a76a0e2b9291aa13aa4014016efaf340d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775755Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Jeff Fisher <jeffish@microsoft.com> Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#692957}
-
Paul Dyson authored
These metrics count the number of apps that are successfully ranked by Top Cat and the number not able to be ranked by Top Cat. Bug: 991433 Change-Id: Icf05a35552d4648784f90b05bf2b8deb49fef133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772208Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#692956}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f790aa521cc6..e7c719c3e85f git log f790aa521cc6..e7c719c3e85f --date=short --no-merges --format='%ad %ae %s' 2019-09-03 simonhatch@chromium.org Pinpoint - Display better error on incorrect git hash Created with: gclient setdep -r src/third_party/catapult@e7c719c3e85f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:1000302 Change-Id: I58da7a2f77a65e863d7db403c6c670631a8018d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783742Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692955}
-
Toni Barzic authored
When drawing items in the folder icon, folder image first calculated intended position of the item icons, then resizes them and adds a drop shadow. The drop shadow adds some padding the the resulting image, so FolderImage drawing logic offsets the resulting image so the original image stays in the intended bounds. The offset is calculated by subtracting original image size from the shadowed image size. This works for scale factor 1x, but given that the actual shadow margins are not integers, their calculation introduces rounding error that can disappear at other scale factors. In particular example, the shadow margin is 2.5, which gets rounded up to 3. With scale factor, the shadow margin is 5, i.e. has no rounded error. Given that FolderImage draws the icon with offset 3, at scale factor 2 the offset becomes 6, which is 1 more than the actual shadow margin added to the image, and the actual item icon is drawn 1 pixel off. This cl updates the drawing logic to use actual scaled shadow margins when calculating required offset, and draws the shadowed image rep for the target scale factor with the calculated offset to the unscaled canvas. BUG=999775 Change-Id: I1bf2532f7114e3c5993b84c11d8900a49bb23783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779670 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
Ryan Hamilton authored
Use the ParsedQuicVersion not the TransportVersion when reporting the negotiated QUIC version in net-internals. Change-Id: If43551f700cb795f4ddfae6b3ef3fa70d962575a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779130 Auto-Submit: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#692953}
-
Gyuyoung Kim authored
This CL converts mojo::Binding to mojo::Receiver in TestDocumentInterfaceBroker class. Bug: 955171, 978694 Change-Id: I7f6800d611ed3d015852de939d4c768c690c5290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778443Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#692952}
-
Gyuyoung Kim authored
This CL converts old Mojo types to the new Mojo types more. - Apply mojo::PendingRemote to MediaStreamDispatcherHostPtr. - Replace mojo::Binding with mojo::Receiver. - Apply mojo::Remote to MediaStreamDispatcherHostPtr. Bug: 955171, 978694 Change-Id: Iefacee2172332ba8891fe56f04449e68483373db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780084Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Dale Curtis authored
Our hardware decoders don't have support for alpha decoding at present, so skip tests for support early in the renderer instead of needing to make a gpu round trip. BUG=996960 TEST=none R=chcunningham Change-Id: Ib1701f51beff883bb6b4e062d35a92fc0acc3dcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783520 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#692950}
-
Regan Hsu authored
Wallpaper preview mode breaks when the alphaEnabled flag is removed. This reverts commit 86b21972. Bug: 997115 Change-Id: Iaf34c5da55bb44dfd5e728ccb1a219a4569e4954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783723Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#692949}
-
Sergey Ulanov authored
Now CastRunner enables VULKAN feature for the web context, which will enable Vulkan for rendering. Also CastRunner now passes HARDWARE_VIDEO_DECODER flag. That flag is currently ignored (video decoder is always enabled), but that will change in the future. Bug: 962617 Change-Id: If4160828cf11ec1fa73f0d5465c5ea9c2c0a6209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783665Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#692948}
-
Andrew Grieve authored
This reverts commit f6e84797. Reason for reland: Removed -checkdiscards. TBR=agrieve # Trivial rename Change-Id: I8924fb2ef16ba1a1704e33634c45471c56d84e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780955Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#692947}
-
Maks Orlovich authored
The test removes |cache_dir_|, which seems risky since other instances might touch it; so instead put the cache one more level down. Bug: 999584 Change-Id: I56f100b0308e45f1e6bbc66c7306cbf3af822e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782878Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#692946}
-
Yuke Liao authored
This CL sets up linux-chromeos-coverage-rel, which replicates linux-chromeos-rel with coverage instrumentation, and the intention is to evaluate the stability of coverage instrumentation on ChromeOS platform. Bug: 1000378 Change-Id: I9065c1ef67f81f9a2286632178af12b54c0eb36b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782990Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#692945}
-
Kent Tamura authored
* Change the type of potentially_violated_features_ from std::bitset to Vector<bool>. * Remove feature_policy.mojom-blink.h dependency from security_context.h Also, apply *.mojom-blink-forward.h as much as possible. Bug: 242216 Change-Id: If0c0d1816a5dcad726507c0a22cddbebac34dccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782209Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#692944}
-
Wei Li authored
On Mac, we follow platform convention to use all titlecase for button text. On other platforms, we should prefer full sentence -- non titlecase for button text. So this CL make the button text casing depending on platforms. BUG=979530 Change-Id: I47afe2192e65a42511b36133d0c69cb325c238af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783240 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#692943}
-
Jeevan Shikaram authored
This CL updates the existing ShowAppManagementPage function to open App Management within OS Settings. Bug: 1000104 Change-Id: Iebd02bfc69071d4c6e4dfdd7aee3f5427a575825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781983 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#692942}
-
John Lee authored
https://i.imgur.com/nZEwnkK.png Bug: 989131 Change-Id: I748c3591adeabe43c0e5a3e653185c94b0f3a6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779524Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#692941}
-
Marijn Kruisselbrink authored
We shouldn't be creating or truncating files if the access to the directory is going to be blocked by the restricted folder checks. So swap around the order of the two operations. Bug: 999788 Change-Id: I0b7519e079f79f4cb031f8f5d1d905fee1bbbb60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783725 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#692940}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8df216c09227..1a9881e19baa git log 8df216c09227..1a9881e19baa --date=short --no-merges --format='%ad %ae %s' 2019-09-03 vapier@chromium.org image_lib: remove au-generator.zip support 2019-09-03 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@1a9881e19baa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I8f74037c6b44a8b22b933f7f225ac35b75720232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783737Reviewed-by:
-
Manas Verma authored
Adding opt_in bit which will be set to true when user intends to opt-in for FIDO Authentication for future card unmasking. When set to true, the payments server will respond with creation options for enrollment, or will simply opt-in the user if they are already enrolled. Bug: 949269 Change-Id: I0a6caa61d9c91706db5efc9e0a2866f0228297a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730292 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#692938}
-
Jeevan Shikaram authored
This reverts commit 70aabb04. Reverting this revert and disabling tests as this needs to go to UI review soon. Tests will be fixed in a following CL. TBR=calamity@chromium.org Bug: 1000271 Change-Id: Id681d795194e1d4a7cac8ec5e6167ccdfb2a3434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783677Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#692937}
-
Yutaka Hirano authored
This reverts commit 619a3f3e. Reason for revert: suspected to break ash_unittests on MSAN: https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/14981 Original change's description: > desks: Fix unnecessary highlight on disabled new desk button. > > Test: manual > Bug: 1000191 > Change-Id: Iad3e0918ae6c82e3939e0e9413d93b0f58c2eda5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782671 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692794} TBR=afakhry@chromium.org,sammiequon@chromium.org Change-Id: I4baf70a77f62b2880aaeca4d5b3b7d4aca9aa51f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1000191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782360Reviewed-by:
-
Yannic Bonenberger authored
*** Note: There is no behavior change from this patch. *** This CL replaces calls to base::{Bind,BindRepeating} with calls to base::BindOnce, and removes calls to base::AdaptCallbackForRepeating when the returned base::RepeatingCallback is immediately converted to a base::OnceCallback. This CL was uploaded by git cl split. R=yhirano@chromium.org Bug: 714018 Change-Id: I33444d67bd5d4d2b5d7fed7c50d77b22078c3270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778608Reviewed-by: -
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7ffef1e8cc2e..aeba7fa1fd36 git log 7ffef1e8cc2e..aeba7fa1fd36 --date=short --no-merges --format='%ad %ae %s' 2019-09-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@aeba7fa1fd36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@google.com Bug: None Change-Id: Ic15f9aa720ffc4e944d54e03d1d6608484678395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783617Reviewed-by:
-
James Hawkins authored
The input method list item element is essentially an abuse of the default list item implementation in that selecting the main area of the input item sets the selected input method as the enabled input method. After selection, this part of the list item element should not be focusable or respond to activation. This change provides a few things: * Override the cursor for an actionable input list item element so it does not appear as an activatable button. * Only set the tabindex on the non-enabled input list item elements. * Prevent focusing the input list item element such that a focus ring does not flash then disappear on click. R=jamescook@chromium.org, khorimoto@chromium.org Bug: 987607 Test: none Change-Id: I60c79b50a4e8691ab378d43721116fbbc7202ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783239Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#692933}
-
dalyk authored
If the probe query was cached, the RTT could be significantly less than what a non-cached query would require. Updating the timeout for DoH queries based on the probe RTT is thus potentially problematic. Getting rid of it also reduces code complexity. Bug: 1000043, 985589 Change-Id: Id8db1930c6b8a9a7f409f32a4c04b0ea9ae4c22b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783402Reviewed-by:
-
Matt Mueller authored
The output of 'security find-certificate -a -p -Z' in 10.15 includes both a SHA-256 and SHA-1 hash for each cert. The old parser split on the SHA-1 hash, confusing the rest of the parsing. Now it splits on the "-----END CERTIFICATE-----" PEM marker, which should be a consistent place to split regardless of any future changes. The parsing of the hash value looks for the first hash mentioned in the text regardless of algorithm. (It's only used for SCOPED_TRACE and LOG messages, so the particular algorithm isn't important.) Bug: 998845 Change-Id: Iaea008a253d0dc4d25314010b2803b841206b7ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783661Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#692931}
-
Yun Liu authored
Bug: 970083 Change-Id: I2603767429b481622db8bd85c60687e616c090fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776716 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
-
- 03 Sep, 2019 6 commits
-
-
Toby Huang authored
LoggedInUserMixin provides the same functionality as SupervisedUserTestBase for logging in as child or regular users without the associated multiple inheritance diamond problems. Deprecate SupervisedUserTestBase. Bug: 990909 Change-Id: Ibc01f9d3298fff1cc15812d0aa1373a75e30c394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764935Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#692929}
-
chrome://flagsJared Saul authored
Change-Id: I794519bc2691f7d223d35a8ac7a3090db12f863e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783726 Commit-Queue: Siyu An <siyua@chromium.org> Auto-Submit: Jared Saul <jsaul@google.com> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#692928}
-
Miyoung Shin authored
This CL converts PaymentHandlerHost{Ptr, PtrInfo} in blink and components to the new Mojo types. Bug: 955171, 978694 Change-Id: I903ce85df7ca3d221fcff3c64c366ba1e107d2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782199Reviewed-by:Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
-
David Trainor authored
Due to some work with our cold start tab loading experience, these metrics will be useful for a few more milestones. Bug: 975243 Change-Id: I685b8adc77b589dc79a04c6f454bbc13722292e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783362 Auto-Submit: David Trainor <dtrainor@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#692926}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a877ee62b1fc..f38bc1796282 git log a877ee62b1fc..f38bc1796282 --date=short --no-merges --format='%ad %ae %s' 2019-09-03 ehmaldonado@chromium.org git-cl: Clean up a bit Created with: gclient setdep -r src/third_party/depot_tools@f38bc1796282 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I5511a5b8462f4b99225f4355698d8034b9b5992d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782734Reviewed-by:
-
Nate Fischer authored
No change to logic, this just changes explicit calls to the std::unique_ptr constructor to instead use make_unique() or implicit conversion from nullptr. This is to conform with a chromium presubmit check. Test: ninja -C out/Default android_webview:common Change-Id: If7ebeb1c67e9b5d07b13728cb3971b45491463ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783702 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#692924}
-
