- 12 Sep, 2017 40 commits
-
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3233811b..6bdbb1f1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I2de7655e974727b530607b16f9e33eabff981846 Reviewed-on: https://chromium-review.googlesource.com/662377Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#501165}
-
Austin James Ahlstrom authored
Bug: 745385 Change-Id: Iea2049e1012303d0655d514a6ba4b1406acfbc41 Reviewed-on: https://chromium-review.googlesource.com/644673Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Austin James Ahlstrom <aahlstrom@google.com> Cr-Commit-Position: refs/heads/master@{#501164}
-
Eric Willigers authored
The web platform tests for CSS Namespaces and CSS Conditional are now enabled. OWNERS have been added. Bug: 763636 Change-Id: I7fbead981bc2fd1706d0c8eda800e3c65ddb52cf Reviewed-on: https://chromium-review.googlesource.com/662077 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#501163}
-
chrome-release-bot authored
TBR=govind@chromium.org Change-Id: I56a9670508223711df97dd3775abd46cde604220 Reviewed-on: https://chromium-review.googlesource.com/662219Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#501162}
-
Xianzhu Wang authored
If a subsequence was fully painted the last time, we don't repaint the subsequence on interest rect change because the fully painted result is still useable. However this triggers false-positive of under- invalidation checking which strictly matches new and cached subsequences. Bug: 755478 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I24f8fa9c2e3167ff3c54954bf5e994a74ef70056 Reviewed-on: https://chromium-review.googlesource.com/661379 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#501161}
-
Tarun Bansal authored
Check if the host String is null before computing the hash of the String. Bug: 761282 Change-Id: I76302c544e101bfabba56d77ce0ea40581057176 Reviewed-on: https://chromium-review.googlesource.com/662018 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#501160}
-
Simon Que authored
BUG=755727 R=afakhry@chromium.org Change-Id: Id0acf812bf46aa3dd9b4e5ffb62f34a4b179a782 Reviewed-on: https://chromium-review.googlesource.com/656044 Commit-Queue: Simon Que <sque@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#501159}
-
Matt Falkenhagen authored
This also removes the gmock for ServiceWorkerContext since OnceCallback cannot be copied. Bug: 755477 Change-Id: I59605c4ebc2d9aa691c73b7140d5e1c86e681198 TBR: mpearson Reviewed-on: https://chromium-review.googlesource.com/654502Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#501158}
-
Chris Harrelson authored
Instead of using one of the squashed layers as the starting point, use the transformed ancestor, from which we have already computed an offset to the squashing layer. As a result, remove the squashing-prevention rule about non-translation transforms. Bug: 750433 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4cf1fc5a2e34d7e40023d4c3481bb517c3b6e72f Reviewed-on: https://chromium-review.googlesource.com/658335Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#501157}
-
Emi Morikawa authored
Set ResourceResponseHead::service_worker_start_time and service_worker_ready_time in ServiceWorkerURLLoaderJob. Bug: 763232 Change-Id: I52b8f3495bbae076ef10608b11065e77fa7c3c43 Reviewed-on: https://chromium-review.googlesource.com/659480Reviewed-by:
-
Aleks Totic authored
I was not interpreting offset correctly if static position was kTopRight and we were looking for RightInset. Renamed methods RightInset (instead of RightPosition) trying to make it more explicit, and less error prone. Bug: 740993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I97c12ef1adce31f73b01e4c20850dd18ac01c443 Reviewed-on: https://chromium-review.googlesource.com/658403 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#501155}
-
Chris Harrelson authored
Bug: 763654 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ida1979f9418c95c3b38db423f3bf777186cbb86a Reviewed-on: https://chromium-review.googlesource.com/660407Reviewed-by:
-
Tarun Bansal authored
Keep min payload size to be 32 KB, but make that a field trial param. Also, move |use_small_responses_| to the NQE params class. Bug: 764145 Change-Id: I8bfd37d602705367d294fff037a47ba72c93f2f7 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Reviewed-on: https://chromium-review.googlesource.com/657202 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#501153}
-
Keishi Hattori authored
ThreadState::EstimatedLiveSize always returns 0 for webpages with no JS because WrapperCountAtLastGC is always 0. This caused GCs to (almost) always trigger. By returning estimation_base_size in this case, we can maintain the existing behavior before the first GC, but return the appropriate estimated live size for any calls after the first GC. Bug: 695466 Change-Id: I76972e07d00a27aa14e3204bf77dada51fa00c95 Reviewed-on: https://chromium-review.googlesource.com/659718 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c59db25d8116..505e9ec415f8 $ git log c59db25d8..505e9ec41 --date=short --no-merges --format='%ad %ae %s' 2017-09-11 dtu [pinpoint] Increase significance level. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ibc04e55ae60942bd61b6e728042c3851bf550831 Reviewed-on: https://chromium-review.googlesource.com/661883 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501151}
-
David Reveman authored
This makes a minimal set up changes to get the supervised user creation screen to support the new set of default user images. The changes are: - Limit default images to 23 first images of current set. - Increase size of image grid to 272px to be able to display 23 images. - Always scale default image to 220x220px. - Use 576x576 capture size to match settings UI. - Disable animation for grid images. - Always use 2x resource for preview. Limiting the number of default images to 23 avoids more complicated changes needed to support proper overflow handling for the grid. This can be improved as part of more general UI updates to the supervised user creation flow. Bug: 763780, 763777, 763776 Test: manual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I64346ee6baa8dedb1b3acc8d738716c96f6aa0d7 Reviewed-on: https://chromium-review.googlesource.com/661862Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501150}
-
Ken Buchanan authored
In some situations on Android, RenderWidgetHostViewAndroid receives invalid sequences of touch events, such as consecutive TouchCancels. Currently the RenderWidgetHostInputEventRouter ignores the second Cancel, because there is no longer any target View to send it to. This causes a problem because the gesture provider expects an ACK at some point, and one is never provided because the renderer didn't see the event. This CL causes RenderWidgetHostInputEventRouter::RouteTouchEvent to cause an INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS ACK to be processed whenever a touch event is being dropped. Bug: 753751, 741565 Change-Id: I48d5054fa9b69acd1bc63691aee64cb606f12bf4 Reviewed-on: https://chromium-review.googlesource.com/660639Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#501149}
-
Chong Zhang authored
WebView has different frame model and may handle events differently (e.g. Synchronous zoom). We don't want to enable VsyncAlignedInput on WebView for now, and will leave it as a separate issue as suggested in cl/606990. Note: cl/651557 updated InputHandlerProxy to forward events immediately. Bug: 625689 Change-Id: I88617698c09b12d35cf930b497b14bb84dd568b5 Reviewed-on: https://chromium-review.googlesource.com/655998Reviewed-by:
Alexandre Elias <aelias@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#501148}
-
Toni Barzic authored
* Smooth up animation by using scale transform. * Add fade-out animation even in case the note was not launched from the lock screen. * Wait until the fade out animation ends before showing version info. Bug:762097 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie6cb4b733c1e09820644fd6ff406dcf4a66e5ade Reviewed-on: https://chromium-review.googlesource.com/656607 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#501147}
-
Shakti Sahu authored
This is the first step of the OfflineContentProvider refactor. Currently download home (DownloadHistoryAdapter) supports offline pages and download backends. This CL also adds OfflineContentProvider as the third backend, which will make later it easy to migrate offline pages and download backends to use OfflineContentProvider. Since nobody is using OfflineContentProvider to show up in download home, this CL shouldn't have any impact. Bug: 691805 Change-Id: Ifaa3fe315ebf65456d01a9f94cc718c90b0798dc Reviewed-on: https://chromium-review.googlesource.com/644314 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#501146}
-
Simon Que authored
- power manager logs - update engine log - event log - lspci - ifconfig BUG=762965 R=afakhry@chromium.org Change-Id: I1bde09bffa0727c7cbdbb3c3fff3692451783a3a Reviewed-on: https://chromium-review.googlesource.com/656106 Commit-Queue: Simon Que <sque@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
-
dpapad authored
This is a follow up from r492869 which reduced the responsibilities of ActionService to only contain search related logic. Bug: 752319 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I81452d2ada95ed1ef4478f93961b8467b4724cb8 Reviewed-on: https://chromium-review.googlesource.com/610822Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#501144}
-
Thanh Pham authored
When an element X is pinned in UI DevTools inspect mode, moving the mouse cursor over X and scrolling the mousewheel up should change X to be the parent of X. This will also show the distances between vertical and horizontal distances between X and X's parent. For now, make scrolling the mousewheel down a no-op; if the user wishes to pin a child element of the currently-pinned element, this can be accomplished with a click. Bug: 748138 Change-Id: I61ed0743d96f0021201e329d0c1d765a16004c0a Reviewed-on: https://chromium-review.googlesource.com/594587Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Thanh Pham <thanhph@chromium.org> Cr-Commit-Position: refs/heads/master@{#501143}
-
Dale Curtis authored
The code above this DCHECK already reports media logs for various failures, so there's no point in running the parser just for the purposes of a DCHECK. It also fails out on some things that are not errors within this code. BUG=762545 TEST=none Change-Id: Iedf423ba4f8dcb4074bcc3f143c47b762e210829 Reviewed-on: https://chromium-review.googlesource.com/661887Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#501142}
-
Alice Boxhall authored
Bug: 514674 Change-Id: Iaa3f0a9385d1fe76a2bf45669618976927d3358d Reviewed-on: https://chromium-review.googlesource.com/640392Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#501141}
-
Devlin Cronin authored
MessagingBindings currently handles both the native helpers for the messaging bindings JavaScript code as well as the entry points for dispatching messages and message-related events to extension contexts. Split this into two objects; one to handle the the native helpers (still called MessagingBindings) and the other to handle the message dispatching (JSRendererMessagingService). This is in preparation for creating a native alternative, which will still need to provide much of the same functionality for dispatching, but won't rely on any JS innards. This CL is moving code and updating names only. Bug: 653596 Change-Id: I9b1fa4961434e9cba092c29d3514f147f2dac064 Reviewed-on: https://chromium-review.googlesource.com/658397Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501140}
-
Daniel Cheng authored
Also documents that the python-mock backport needs to be installed and formats the file with format-webkitpy. Bug: 763980 Change-Id: I1f629673ce550adc17eacea098cf71e7d6be9436 Reviewed-on: https://chromium-review.googlesource.com/660978Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#501139}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/3261eb219f2c..a8e5744afadd $ git log 3261eb219..a8e5744af --date=short --no-merges --format='%ad %ae %s' 2017-09-11 brianosman Add general three-stop analytic gradient shader Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Ibf6c782144177af6cde534349ceedabd6c2c3248 Reviewed-on: https://chromium-review.googlesource.com/661949Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501138}
-
Sergey Ulanov authored
Previously Recv() wasn't handling truncated packets consistently on all platforms. It was returning ERR_MSG_TOO_BIG on Windows, while silently truncating message on POSIX. This change updates POSIX version so that it behaves the same as the Windows implementation. Now recvmsg() is used instead of recvfrom(), which allows to get MSG_TRUNC flag back from the OS. Change-Id: Ie97fbec02dba721358f3595b33a265096a1b4289 Reviewed-on: https://chromium-review.googlesource.com/657780Reviewed-by:
Jana Iyengar <jri@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#501137}
-
Patti authored
Before r490727, Site Settings / Content Settings always interpreted URLs to be either an extension (in which the extension name would be retrieved) or a ContentSettingsPattern. r490727 introduced a third option which was to display the URL as the origin it belongs to (including stripping any default port numbers) by checking whether the pattern was a valid origin. However, this introduced a bug where 'https://*' would be intrepreted as a valid origin and be displayed as 'https://%2A' in cases where it should have stayed a ContentSettingsPattern. Fix this by re-separating the codepaths for getting a pattern display name and getting an origin display name. Manual test - Navigate to chrome://settings/content/flash/ and add a new 'Block' exception for 'http://*'. This should show up as typed and not get converted to 'http://%2A'. Bug: 656758, 762754 Change-Id: Ifa6c5f94e4485c7e78f1262a357b219e3cb86c19 Reviewed-on: https://chromium-review.googlesource.com/612025 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#501136}
-
Alice Boxhall authored
[Devtools] Maintain selection when selecting accessibility tree nodes which aren't represented in Elements tree Bug: 560525 Change-Id: I77f911996bbb4cad6ed7967b7e63d2286e39592f Reviewed-on: https://chromium-review.googlesource.com/644646Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#501135}
-
Ben Wells authored
This reverts commit 54a27d88. Reason for revert: Caused compile failure. Original change's description: > Switch RPM packager to use new dependency system > > BUG=758654 > R=thestig@chromium.org > > Change-Id: Ib64eb4ace73d7803b083f4d40795193dedc288f7 > Reviewed-on: https://chromium-review.googlesource.com/655943 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501104} TBR=thestig@chromium.org,thomasanderson@chromium.org Change-Id: I3d625e3098e7b60ca173b51c8616c8d34c58a5a1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 758654 Reviewed-on: https://chromium-review.googlesource.com/662477Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#501134}
-
Ben Wells authored
This reverts commit aa28a986. Reason for revert: Has caused stack-use-after-scope errors on ASAn bot. First build failure: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/23580 Sample output: [ RUN ] GLRendererTest.OverlaySyncTokensAreProcessed ================================================================= ==9679==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7f2ca060c548 at pc 0x000000736f66 bp 0x7ffffdbd9de0 sp 0x7ffffdbd9dd8 READ of size 8 at 0x7f2ca060c548 thread T0 #0 0x736f65 in end buildtools/third_party/libc++/trunk/include/vector:1481:30 #1 0x736f65 in viz::(anonymous namespace)::CollectResources(std::__1::vector<viz::ReturnedResource, std::__1::allocator<viz::ReturnedResource> >*, std::__1::vector<viz::ReturnedResource, std::__1::allocator<viz::ReturnedResource> > const&, cc::BlockingTaskRunner*) components/viz/service/display/gl_renderer_unittest.cc:1925 #2 0x3680f76 in Run base/callback.h:92:12 #3 0x3680f76 in cc::DisplayResourceProvider::DeleteAndReturnUnusedResourcesToChild(std::__1::__hash_map_iterator<std::__1::__hash_iterator<std::__1::__hash_node<std::__1::__hash_value_type<int, cc::DisplayResourceProvider::Child>, void*>*> >, cc::ResourceProvider::DeleteStyle, std::__1::vector<unsigned int, std::__1::allocator<unsigned int> > const&) cc/resources/display_resource_provider.cc:255 #4 0x367dfbf in cc::DisplayResourceProvider::DestroyChildInternal(std::__1::__hash_map_iterator<std::__1::__hash_iterator<std::__1::__hash_node<std::__1::__hash_value_type<int, cc::DisplayResourceProvider::Child>, void*>*> >, cc::ResourceProvider::DeleteStyle) cc/resources/display_resource_provider.cc:145:3 #5 0x367d6d0 in cc::DisplayResourceProvider::~DisplayResourceProvider() cc/resources/display_resource_provider.cc:35:5 #6 0x367e10d in cc::DisplayResourceProvider::~DisplayResourceProvider() cc/resources/display_resource_provider.cc:33:53 #7 0x74ad4e in operator() buildtools/third_party/libc++/trunk/include/memory:2272:5 #8 0x74ad4e in reset buildtools/third_party/libc++/trunk/include/memory:2585 #9 0x74ad4e in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2539 #10 0x74ad4e in viz::(anonymous namespace)::GLRendererTest_OverlaySyncTokensAreProcessed_Test::TestBody() components/viz/service/display/gl_renderer_unittest.cc:2211 .... Original change's description: > viz: Move CreateResourceFromTextureMailbox from Display to LayerTree in GLRendererTest > > As a step of moving SingleReleaseCallbackImpl/CreateResourceFromTextureMailbox > into LayerTreeREsourceProvider, move the call of > DisplayResourceProvider::CreateResourceFromTextureMailbox > into LayerTreeResourceProvider::CreateResourceFromTextureMailbox. > > The usage of CreateResourceFromTextureMailbox is listed here: > https://docs.google.com/spreadsheets/d/1lnyONBganHkiQKw8J-3e3xC7STZkYvSh7dkzxSUFmPw/edit > > BUG=757291 > > Change-Id: I41e5d44c5f2ac03b3a5b3da1951a5ca09b3b4529 > Reviewed-on: https://chromium-review.googlesource.com/654444 > Commit-Queue: Xing Xu <xing.xu@intel.com> > Reviewed-by: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500974} TBR=danakj@chromium.org,sunnyps@chromium.org,xing.xu@intel.com Change-Id: I4429d959bea725598662c5bee5c7f1c70acba22f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 757291 Reviewed-on: https://chromium-review.googlesource.com/662470Reviewed-by:
-
Jeremy Roman authored
It's not clear that much is gained by passing by value here (the inner functions use const references), and in any event, single-argument constructors should be explicit unless it's intended that they be used for implicit conversion. Change-Id: I0e4d0824dadfd8ef4de1ea513bf48059612ac53a Reviewed-on: https://chromium-review.googlesource.com/655858Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501132}
-
Xi Cheng authored
Currently, TopSites maintains a list of 20 top sites excluding the blacklist. Whenever there is a change in these 20 sites, TopSites updates its related database on disk via a task called TopSitesBackend::UpdateTopSitesOnDBThread. The task takes more than 900 ms on average and has a very high jank rate. These evidences show that it's the most expensive operation on the DB thread. In addition to updating DB, TopSites also notifies its observers about the change so that work is triggered in observer classes. However, only the top 8 sites are used by the observers of TopSites. In more details, apart from JumpList which uses the top 5 sites, all its observers use only the top 8 sites. These observers include InstantService, MostVistedSites, SpotlightTopSitesBridge and GlobalMenuBarX11. These facts indicate TopSites is maintaining more sites than needed. This CL changes TopSites to maintain only 10 top sites to trim out that waste. We prefer 10 over 8 because in that way, there is a bit of a buffer if the user blacklists a url and won't end up with an empty thumbnail. Bug: 763103, 763519 Change-Id: Ia0355cff95c8df23335c564a492a62e0011bc6f8 Reviewed-on: https://chromium-review.googlesource.com/656399 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#501131}
-
Ben Wells authored
TBR=brucedawson@chromium.org NOTRY=true Bug: 763197 Change-Id: Ie99b0e5e2839212cdbe6d01986aa99f31911d64e Reviewed-on: https://chromium-review.googlesource.com/662257Reviewed-by:
-
Justin DeWitt authored
This reverts commit e33804da. Reason for revert: crbug.com/763789 Canary crash, due to API requiring version 21. Original change's description: > Check for power saver mode. > > We should turn off prefetching if the user has power saver mode on. > > Bug: 701939 > Change-Id: Idc5ba38650ec0b4e7748b31b50c34955e29cc4b3 > Reviewed-on: https://chromium-review.googlesource.com/642091 > Commit-Queue: Peter Williamson <petewil@chromium.org> > Reviewed-by: Justin DeWitt <dewittj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500780} TBR=petewil@chromium.org,dewittj@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 701939 Change-Id: Ic2ce555d0dbb94a4dc610e0167b1c1b168353c89 Reviewed-on: https://chromium-review.googlesource.com/661817Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#501129}
-
Hiroki Nakagawa authored
Some tests have friendliness ("friend class") with ServiceWorkerStorage just to access a private functions. Generally, it's cumbersome to keep the list of "friend class" up-to-date because an unused "friend class" is just ignored by the compiler. For code cleanup, this CL reduces the number of "friend class" by introducing a test-only public function ("LazyInitializeForTest()"). Bug: n/a Change-Id: I6d8c840089574ca840cd4f279e6c08f2109fd802 Reviewed-on: https://chromium-review.googlesource.com/658161Reviewed-by: -
Xing Liu authored
ParallelDownloadResumption is flaky previously, the cause is an edge case bug in download resumption with a prallel download, that first hole can be filled before creating parallel requests. The impact of this bug is very small. Repro rate in browser test is only 1-2%, and resumption only happens for 4.9% for all downloads. Bug: 762763 Change-Id: I00efbc14ec40f484f3ef111f8237894c4009ba6d Reviewed-on: https://chromium-review.googlesource.com/653314Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#501127}
-
Evan Stade authored
Also remove platform ifdefs from DownloadItemNotification since it's only used on chromeos. Bug: Change-Id: I5aade81c13c96a6da22367c22ad1bad9a6b58286 Reviewed-on: https://chromium-review.googlesource.com/656506Reviewed-by:
-
