GitLab

This is a refactoring CL as a preparation to fix focus handling on
Win-Aura environment. This CL does not change any behavior of
production binaries.

Currently InputMethodBridgeUnitTest internally defines a custom
dummy class of ui::InputMethod. However this is not necessary
because we already have ui::FakeInputMethod.

This CL replaces the custom dummy class with
ui::FakeInputMethod by using DummyInputMethodDelegate.
We can reuse ui::DummyInputMethodDelegate later in other
unit tests.

BUG=287620
TEST=unit test

Review URL: https://chromiumcodereview.appspot.com/23875014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222255 0039d316-1c4b-4281-b951-d872f2087c98

Custom JavaScript loader doesn't work on iOS because an origin check
fails outside v8 isolated world. Chrome should not overwrite these
callbacks on iOS.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/23715006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222254 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes the clear bugs in file_watcher.js.

BUG=288420
TEST=none

Review URL: https://chromiumcodereview.appspot.com/23523042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222253 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bulach@chromium.org
NOTRY=true
BUG=288631

Review URL: https://chromiumcodereview.appspot.com/23903030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222252 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual (open chrome://syncfs-internals, go to File Metadata tab and click
'refresh')

Review URL: https://chromiumcodereview.appspot.com/23753007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222251 0039d316-1c4b-4281-b951-d872f2087c98

Using RGBA implies a colour space conversion in the driver from YUY2 (native capture) to RGBA, which is undone in VideoCaptureController, RGBA to YUV I420. Avoiding this double conversion uses about 5% less CPU in the CMIO thread.

BUG=285967

Review URL: https://chromiumcodereview.appspot.com/23693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222250 0039d316-1c4b-4281-b951-d872f2087c98

This CL revises TSFTextStoreTest as follows.
- Initialize variables
- Declare types in anonymous namespace when possible 
- Use DISALLOW_COPY_AND_ASSIGN when appropriate
- Use scoped_refptr when appropriate

There is no behavioral change.

BUG=none
TEST=ran test

Review URL: https://chromiumcodereview.appspot.com/23548030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222249 0039d316-1c4b-4281-b951-d872f2087c98

> Close the shared audio output device when the tab is closed.
> The audio device is currently shared between multiple media players, but we were missing a step that frees the device when the tab is closed.
> 
> Review URL: https://chromiumcodereview.appspot.com/23449012

TBR=tommi@chromium.org
BUG=288599

Review URL: https://codereview.chromium.org/23442022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222248 0039d316-1c4b-4281-b951-d872f2087c98

> App windows with ids should remember fullscreen state.
>
> BUG=242790
> TEST=PlatformAppBrowserTest.ShellWindowRestoreState
> TEST=1. Install window-state-sample: https://chrome.google.com/webstore/detail/window-state-sample/hcbhfbnaaancmblfhdknlnojpafjohbi; 2. Run the app and create a new window with id. 3. Fullscreen the new window by clicking "Fullscreen" of "chrome.app.window" section; 4. Close the window (You can use "Alt+F4" etc.) and recreate the new window with the same id. 5. A fullscreen window should be shown.
>
> Review URL: https://chromiumcodereview.appspot.com/23672029

Reason for revert: Causes
PlatformAppBrowserTest.ShellWindowRestoreState to fail on Mac OS X
10.6.

TBR=zhchbin@gmail.com

Review URL: https://codereview.chromium.org/23707028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222247 0039d316-1c4b-4281-b951-d872f2087c98

...GetPreferredOutputStreamParameters on Mac.
The GetPreferredOutputStreamParameters implementation now supports non-default output device ids.

BUG=276894
R=henrika@chromium.org

Review URL: https://codereview.chromium.org/23533045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222244 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=green bot
R=tzik@chromium.org

Review URL: https://codereview.chromium.org/23708027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222243 0039d316-1c4b-4281-b951-d872f2087c98

When a user uninstalls an extension, all of the data about that extension is removed from the activity log database. This is a privacy measure.

BUG=244841
R=mpcomplete@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23983014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222242 0039d316-1c4b-4281-b951-d872f2087c98

BUG=284547

Review URL: https://chromiumcodereview.appspot.com/23963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222241 0039d316-1c4b-4281-b951-d872f2087c98

If the StreamChunk RPC fails, the coordinator currently reports an error
and aborts immedately, but this leaves no useful information for the
user or developer. Instead, call the StreamEnd RPC which returns a
string describing the error (but only if the RPC error was
reported by the application on the other end, and not an
error with the RPC itself).
Also disable the PnaclErrorHandling test until the translator change in
https://codereview.chromium.org/23753003/ rolls into Chrome
(since it, combined with this change, will improve the error message
reported by the translator).

R=jvoung@chromium.org
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3519
TEST=NaClBrowserTestPnacl.ErrorHandling

Review URL: https://chromiumcodereview.appspot.com/23946004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222240 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://chromiumcodereview.appspot.com/23922007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222239 0039d316-1c4b-4281-b951-d872f2087c98

Add kill switch for notifications.
Disabled notifications for task manager test.

BUG=286157
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23903024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222238 0039d316-1c4b-4281-b951-d872f2087c98

BUG=286655

Review URL: https://chromiumcodereview.appspot.com/23902020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222237 0039d316-1c4b-4281-b951-d872f2087c98

This switches it away from using the legacy 2D path and gets rid of a couple of copies.

BUG=269214,275200

Review URL: https://chromiumcodereview.appspot.com/23866006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222236 0039d316-1c4b-4281-b951-d872f2087c98

Design proposal: https://docs.google.com/document/d/1r-RoOv2URfZBYrT_B6notQ6MeMqZRd1EP1AITuzJCAc/edit?usp=sharing

* Support for url_handlers in manifest
* New kind of onLaunched event with navigation info in launch data
* Intercept/redirect top-level browser-initiated navigations (bookmarks, omnibox, etc.)
* Intercept/redirect top-frame navigations in tabs and app windows. 

This is a rework of https://codereview.chromium.org/22944002/.

BUG=111422

Review URL: https://chromiumcodereview.appspot.com/23847004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222235 0039d316-1c4b-4281-b951-d872f2087c98

Convert the SyncerCommand GetCommitIdsCommand into a function named
GetCommitIds that serves the same purpose.  There was no benefit in
keeping this functionality in a SyncerCommand, and doing so would have
made the implementation of a per-type GetCommitIds more difficult.

Expose a function to get the IDs to commit for a single data type.  This
function is used in the implementation of GetCommitIdsCommand, but
nowhere else.  It will become more useful when we try to implement the
model type abstraction layer.

BUG=278484

Review URL: https://chromiumcodereview.appspot.com/23809005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222234 0039d316-1c4b-4281-b951-d872f2087c98

This is small refactoring of DriveIntegrationService by introducing State.
This is preparation of mount/enabled state migration of
DriveIntegrationSerivice. By the migration, DriveIntegrationService can be
obtained even before initialization. This CL supports the change.
Also, by this CL, FileSystem can be deleted even before Initialize() is called.

BUG=284972
TEST=Ran unit_tests
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/23548025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222231 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the problem on some platforms where it does not support query the audio params of specific device.

R=tommi@chromium.org

Review URL: https://codereview.chromium.org/23742005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222230 0039d316-1c4b-4281-b951-d872f2087c98

 * This CL moves all drive_backend/ files to drive_backend_v1/ except for:
   - metadata_database*,
   - sync_engine*,
   - *_syncer*,
   - tracker_set*.

R=kinuko,nhiroki
TBR=benwells
BUG=240165
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23787003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222229 0039d316-1c4b-4281-b951-d872f2087c98

The PlatformAppBrowserTest.WindowDotPrintWorks test will only run
automatically for Chrome branded builds because it requires the PDF
plug-in, which isn't provided for Chromium builds. It can be run
manually for Chromium builds, however, and this change expands the
comment explaining how to do this on Linux to add an explanation of
how to do this on OS X.

TBR=asargent@chromium.org
BUG=none

Review URL: https://chromiumcodereview.appspot.com/23708018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222228 0039d316-1c4b-4281-b951-d872f2087c98

RestartEntd() was deprecated years ago, so calls to this method
can certainly be removed. The UnlockScreen() method has done
nothing but emit a signal that no process listens to for several
releases now.

BUG=chromium:286401
TEST=unit tests, desktopui_ScreenLocker autotest

Review URL: https://chromiumcodereview.appspot.com/23694025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222227 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242790
TEST=PlatformAppBrowserTest.ShellWindowRestoreState
TEST=1. Install window-state-sample: https://chrome.google.com/webstore/detail/window-state-sample/hcbhfbnaaancmblfhdknlnojpafjohbi; 2. Run the app and create a new window with id. 3. Fullscreen the new window by clicking "Fullscreen" of "chrome.app.window" section; 4. Close the window (You can use "Alt+F4" etc.) and recreate the new window with the same id. 5. A fullscreen window should be shown.

Review URL: https://chromiumcodereview.appspot.com/23672029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222226 0039d316-1c4b-4281-b951-d872f2087c98

BUG=236290

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222102

Review URL: https://chromiumcodereview.appspot.com/23636015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222225 0039d316-1c4b-4281-b951-d872f2087c98

Previously, closing the app window while a file is being checked for
write access caused a crash. This adds an early exit to prevent that
crash.

BUG=282727

Review URL: https://chromiumcodereview.appspot.com/23629033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222224 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduce PreviewPanel.Thumbnails class and make it manage the thumbnail
images in the preview panel.  PreviewPanel.Thumbnails receives the selection of
entries, and then it loads the images and show the thumbnail properly.

BUG=241693
TEST=manually
R=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/23676006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222223 0039d316-1c4b-4281-b951-d872f2087c98

BUG=157274
R=isherman@chromium.org, sail@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23604046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222222 0039d316-1c4b-4281-b951-d872f2087c98

BUG=260005

Review URL: https://chromiumcodereview.appspot.com/23536020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222221 0039d316-1c4b-4281-b951-d872f2087c98

Attempt to fix testGotQueryParams on 10.6 and 10.7

> keep_test_server_ports to BrowserOptions (this should probably go into AndroidBrowserOptions). android_rndis is a new ctor arg to AndroidBrowserBackend.
> 
> BUG=269131
> TEST=trybot
> 
> Review URL: https://chromiumcodereview.appspot.com/23619022

TBR=achuith@chromium.org

Review URL: https://codereview.chromium.org/23629037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222220 0039d316-1c4b-4281-b951-d872f2087c98

Re-apply 222150. Revert didn't fix testGotQueryParams.

> Revert 222150 "Telemetry: smoothness measurement throws MissingT..."
> 
> Breaks testGotQueryParams on Mac 10.6 and 10.7.
> 
> > Telemetry: smoothness measurement throws MissingTimelineMarker.
> > 
> > Rather than throwing a generic LookupError exception when the timeline marker
> > cannot be found in the trace, throw a MissingTimelineMarker which is a subclass
> > of page_measurement.MeasurementFailure. These exceptios get caught by the page
> > runner.
> > 
> > Stop catching LookupError exeptions in _RunPage.
> > 
> > BUG=238864
> > 
> > Review URL: https://chromiumcodereview.appspot.com/23766009
> 
> TBR=dominikg@chromium.org
> 
> Review URL: https://codereview.chromium.org/23693005

TBR=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/23622023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222219 0039d316-1c4b-4281-b951-d872f2087c98

Currently the test entry data of 'newly added file.ogg' is doubled for creating
and verifiying the entry.  This CL introduces TestEntryInfo class to JavaScript
code and use it for both creating and verifiying the entyr.

BUG=279774
TEST=file_manager_browsertests
R=hashimoto@chromium.org, yoshiki@chromium.org

Review URL: https://codereview.chromium.org/24026003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222218 0039d316-1c4b-4281-b951-d872f2087c98

BUG=276894
R=tommi@chromium.org

Review URL: https://codereview.chromium.org/24072002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222217 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manually
R=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/24053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222216 0039d316-1c4b-4281-b951-d872f2087c98

applist button.

R=harrym@chromium.org
BUG=287593
TEST=Compiles, Visual test

Review URL: https://chromiumcodereview.appspot.com/23526030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222215 0039d316-1c4b-4281-b951-d872f2087c98

A small fix so that modifying the existing code becomes safer.

BUG=none
TEST=SyncTaskManagerTest.ScheduleAndCancelTask

Review URL: https://chromiumcodereview.appspot.com/23513021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222214 0039d316-1c4b-4281-b951-d872f2087c98

This issue was found by a linter.

R=rdevlin.cronin@chromium.org, yoz@chromium.org

BUG=

Review URL: https://chromiumcodereview.appspot.com/23503045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222213 0039d316-1c4b-4281-b951-d872f2087c98

BUG=285941
R=stevenjb@chromium.org, bartfab@chromium.org
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/23464044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222212 0039d316-1c4b-4281-b951-d872f2087c98