GitLab

BUG=

Review URL: https://codereview.chromium.org/335583003

git-svn-id: svn://svn.chromium.org/blink/trunk@176020 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Source/core/dom/Node.h
  Replace TreeSharedWillBeRefCountedGarbageCollected with
  TreeSharedWillBeGarbageCollectedFinalized.
- Source/platform/heap/Handle.h
  Replace TreeSharedWillBeRefCountedGarbageCollected with
  TreeSharedWillBeGarbageCollectedFinalized.
- public/platform/WebPrivatePtr.h
  Introduce PtrStorageImpl<T, GarbageCollectedLifetime>::
  assign(const RawPtr<U>&) because matching RawPtr<U> value with
  assign(const RawPtr<T>&) and assign(T*) are ambiguous.

Leftover RefPtr:
- Source/core/dom/StyleEngine.cpp
- Source/core/dom/StyleEngine.h
- Source/core/fetch/FontResource.h

Remove |using| directives for T::ref and T::deref if ENABLE(OILPAN)
- Source/core/dom/Document.h
- Source/core/html/HTMLFormControlElement.h
- Source/core/html/HTMLObjectElement.h
- Source/core/svg/SVGSVGElement.h
- Source/core/svg/SVGViewElement.h

Simple replacement of adoptRefWillBeRefCountedGarbageCollected:
- Source/core/dom/Attr.cpp
- Source/core/dom/CDATASection.cpp
- Source/core/dom/Comment.cpp
- Source/core/dom/Document.h
- Source/core/dom/DocumentFragment.cpp
- Source/core/dom/DocumentType.h
- Source/core/dom/Element.cpp
- Source/core/dom/Element.h
- Source/core/dom/ProcessingInstruction.cpp
- Source/core/dom/PseudoElement.h
- Source/core/dom/TemplateContentDocumentFragment.h
- Source/core/dom/Text.cpp
- Source/core/dom/XMLDocument.h
- Source/core/dom/shadow/ShadowRoot.h
- Source/core/html/HTMLAnchorElement.cpp
- Source/core/html/HTMLAppletElement.cpp
- Source/core/html/HTMLAudioElement.cpp
- Source/core/html/HTMLButtonElement.cpp
- Source/core/html/HTMLDataListElement.cpp
- Source/core/html/HTMLDetailsElement.cpp
- Source/core/html/HTMLDocument.h
- Source/core/html/HTMLEmbedElement.cpp
- Source/core/html/HTMLFieldSetElement.cpp
- Source/core/html/HTMLFormElement.cpp
- Source/core/html/HTMLImageElement.cpp
- Source/core/html/HTMLInputElement.cpp
- Source/core/html/HTMLKeygenElement.cpp
- Source/core/html/HTMLLinkElement.cpp
- Source/core/html/HTMLMarqueeElement.cpp
- Source/core/html/HTMLMeterElement.cpp
- Source/core/html/HTMLObjectElement.cpp
- Source/core/html/HTMLOptionElement.cpp
- Source/core/html/HTMLOutputElement.cpp
- Source/core/html/HTMLProgressElement.cpp
- Source/core/html/HTMLScriptElement.cpp
- Source/core/html/HTMLSelectElement.cpp
- Source/core/html/HTMLStyleElement.cpp
- Source/core/html/HTMLSummaryElement.cpp
- Source/core/html/HTMLTextAreaElement.cpp
- Source/core/html/HTMLUnknownElement.h
- Source/core/html/HTMLVideoElement.cpp
- Source/core/html/HTMLViewSourceDocument.h
- Source/core/html/ImageDocument.h
- Source/core/html/MediaDocument.h
- Source/core/html/PluginDocument.h
- Source/core/html/TextDocument.h
- Source/core/html/forms/TextFieldInputType.cpp
- Source/core/html/shadow/ClearButtonElement.cpp
- Source/core/html/shadow/DateTimeEditElement.cpp
- Source/core/html/shadow/DateTimeFieldElements.cpp
- Source/core/html/shadow/DetailsMarkerControl.h
- Source/core/html/shadow/MediaControlElements.cpp
- Source/core/html/shadow/MediaControls.cpp
- Source/core/html/shadow/MeterShadowElement.cpp
- Source/core/html/shadow/PickerIndicatorElement.cpp
- Source/core/html/shadow/SliderThumbElement.cpp
- Source/core/html/shadow/SpinButtonElement.cpp
- Source/core/html/shadow/TextControlInnerElements.cpp
- Source/core/html/track/vtt/VTTCue.h
- Source/core/html/track/vtt/VTTElement.cpp
- Source/core/loader/SinkDocument.h
- Source/core/svg/SVGAnimateElement.cpp
- Source/core/svg/SVGScriptElement.cpp
- Source/core/svg/SVGScriptElement.cpp
- Source/core/svg/SVGUseElement.cpp

BUG=357163

Review URL: https://codereview.chromium.org/324073002

git-svn-id: svn://svn.chromium.org/blink/trunk@176019 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The SpeechSynthesis may lose its observed execution context and still
be accessed by the platform. Check if present before accessing the
context.

R=haraken@chromium.org
BUG=345061

Review URL: https://codereview.chromium.org/330603002

git-svn-id: svn://svn.chromium.org/blink/trunk@176018 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Methods are registered in one of three different ways on an interface's
prototype object;

 1) via an entry in a static array,
 2) via custom code in the interface's configure{{class}}Template(), or
 3) via custom code in its installPerContextEnabledMethods();

depending on whether the method is static and its extended attributes.
E.g., [RuntimeEnabled] leads to 2 and [PerContextEnabled] leads to 3.

The old method of setting flags on each method signalling how it ought
to be registered, and filtering the single list of methods in the
templates based on these flags, was becoming seriously unwieldy for
complicated cases such as overloaded methods.

To address this, change the logic to instead filter methods into three
lists in the scripts, one for each type of registration. The templates
simply use a different list of methods when generating the different
code blocks.

For overloaded methods, take the attributes of all overloads into
account, instead of looking at only one of them (the first in IDL file
order, as it were.)

Also introduce a compile-time check that a set of overloaded methods
doesn't contain methods with conflicting extended attributes that affect
how the method ought to be registered.

BUG=339000

Review URL: https://codereview.chromium.org/328663003

git-svn-id: svn://svn.chromium.org/blink/trunk@176017 bbb929c8-8fbe-4397-9dbb-9b2b20218538

RenderDetailMarker needs both left and right margin to get rendered with same margin. Updated with webkit-margin-end to get the same margin result for both ltr and rtl

R=eseidel, leviw, tkent
BUG=335075
TEST=Existing details-writing-mode covers test for showing text in RTL box, with the patch rtl box now shows margin which is currently missing.

Review URL: https://codereview.chromium.org/306923003

git-svn-id: svn://svn.chromium.org/blink/trunk@176016 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It generalize the algorithm to find the surrounding text to be able to
work with a starting position and an ending position. The goal is to be
able to get the surrounding text arround the current selection.

BUG=330238

Review URL: https://codereview.chromium.org/323983006

git-svn-id: svn://svn.chromium.org/blink/trunk@176015 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Spec:
https://svgwg.org/svg2-draft/painting.html#OrientAttribute
http://www.w3.org/TR/2012/WD-css3-values-20120308/#angles

BUG=377514

Review URL: https://codereview.chromium.org/303263008

git-svn-id: svn://svn.chromium.org/blink/trunk@176014 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163
R=haraken@chromium.org

Review URL: https://codereview.chromium.org/294053006

git-svn-id: svn://svn.chromium.org/blink/trunk@176013 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/333623002

git-svn-id: svn://svn.chromium.org/blink/trunk@176012 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now that EventTarget is on-heap, we don't need to use RefCountedGarbageCollected for classes that derive EventTargets.

Another reason why these classes have to be RefCountedGarbageCollected is that they derive ActiveDOMObject, and ActiveDOMObject::setPendingActivity calls ref(). However, they don't need to be RefCountedGarbageCollected unless they actually use setPendingActivity(), so this CL just removes RefCountedGarbageCollected from classes that derive ActiveDOMObject but don't use setPendingActivity().

BUG=340522

Review URL: https://codereview.chromium.org/329853004

git-svn-id: svn://svn.chromium.org/blink/trunk@176011 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Undo command resets the selection to the previous position, but under some
conditions it may set the selection to a position in a document that is not
controlled by FrameSelection.

If this happens, a subsequent call of FindString command provokes an assertion
in TextIterator, as it does not expect the selection endpoints to be in another
document.

This patch fixes the issue and adds a layout test that reproduces the assertion
failure.

BUG=374904

Review URL: https://codereview.chromium.org/326323003

git-svn-id: svn://svn.chromium.org/blink/trunk@176010 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is currently tested with HeapHashSet. Extending it to other hash
collections is postponed to a later change. To have your type removed from
collections when weak pointers in it no longer point to live objects you need
to give it two methods and a special hash trait. See WeakHandlingHashTraits in
Heap.h for details and PairWithWeakHandling in HeapTest.cpp for an example.

R=ager@chromium.org, haraken@chromium.org, wibling@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/319593004

git-svn-id: svn://svn.chromium.org/blink/trunk@176009 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TypeConversions class needs to be GarbageCollectedFinalized because new String
member needs finalization.

BUG=
TBR=oilpan-reviews@chromium.org

Review URL: https://codereview.chromium.org/326423006

git-svn-id: svn://svn.chromium.org/blink/trunk@176008 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For saveImageAs, we want to save the latest frame that has 
been composited to the screen. So in this case, copy from the
frontBuffer in DrawingBuffer::copyToPlatformTexture.
    
BUG=374762

Review URL: https://codereview.chromium.org/309933004

git-svn-id: svn://svn.chromium.org/blink/trunk@176007 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Background: Currently V8GC do not have idea of DOM memory usage retained by wrappers. A small set of unreachable wrappers may retain huge DOM, but v8 gc may not be triggered as it is not aware of DOM memory usage.

This CL introduces |V8GCController::reportDOMMemoryUsageToV8|
- DOM memory usage is tracked at partition{Alloc,Free}
- After each task run, |reportDOMMemoryUsageToV8| is called.
- |reportDOMMemoryUsageToV8| notifies V8 GC the partition memory size currently consumed by DOM.

After this CL, http://jsbin.com/nitobiru/18 will not crash.

BUG=365018, 368406

Review URL: https://codereview.chromium.org/301743006

git-svn-id: svn://svn.chromium.org/blink/trunk@176006 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL deletes a bunch of state and code from GraphicsLayer that's not used.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/335453002

git-svn-id: svn://svn.chromium.org/blink/trunk@176005 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
BUG=383741,383742

Review URL: https://codereview.chromium.org/329263003

git-svn-id: svn://svn.chromium.org/blink/trunk@176003 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=369451

Review URL: https://codereview.chromium.org/315043007

git-svn-id: svn://svn.chromium.org/blink/trunk@176002 bbb929c8-8fbe-4397-9dbb-9b2b20218538

r175772 changed lifetime of SVGViewSpec to be always same as SVGSVGElement,
so this weak-ref can now be made a strong-ref.

BUG=357163

Review URL: https://codereview.chromium.org/331583002

git-svn-id: svn://svn.chromium.org/blink/trunk@176001 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The items that are set to flex-wrap and have a single flex line currently
has their cross size adjusted according to the max of the items cross size.
According to the specification section 9.4 number 8 point, it states that:

If the flex container has only one flex line (_even if it’s a multi-line
flex container_) and has a definite cross size the cross size of the flex line
is the flex container’s inner cross size.

link: http://www.w3.org/TR/2014/WD-css-flexbox-1-20140325/#cross-sizing

This patch fixes this bug by removing the condtion that checks if it's
a multiline container or not and based on that set flex line cross size.

Bug=362848

Review URL: https://codereview.chromium.org/324073003

git-svn-id: svn://svn.chromium.org/blink/trunk@176000 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The scrollingCoordinatorEnabled setting is redundant with acceleratedCompositingEnabled.

Review URL: https://codereview.chromium.org/329863002

git-svn-id: svn://svn.chromium.org/blink/trunk@175999 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SetWrapperReferenceTo IDL attribute is a hack to use V8 wrapper reference
to avoid reference cycles in Blink. The |visitDOMWrapper| callback is
used to create a temporary strong reference between the wrappers in GC
prologue.

Before this patch, |visitDOMWrapper| was allowed to create a new wrapper
if the wrapper for target object didn't exist. However this is dangerous,
as the target object may be already destructed. The target wrapper must
already exist for this reference hack to work correctly.

This patch forbids creating a new wrapper from |visitDOMWrapper| callback,
and adds an ASSERT that checks that the target object wrapper already
exists.

BUG=None

Review URL: https://codereview.chromium.org/332643003

git-svn-id: svn://svn.chromium.org/blink/trunk@175998 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=381876

Review URL: https://codereview.chromium.org/329253005

git-svn-id: svn://svn.chromium.org/blink/trunk@175997 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This function just returns whether we're the main frame.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/329423002

git-svn-id: svn://svn.chromium.org/blink/trunk@175996 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ByteString is like DOMString, but should throw TypeError 
during the V8->C++ hop if script tries to set a string with a 
code unit greater than 0x00FF. No enforcement is done on the 
C++->V8 side.

R=nbarth@chromium.org
BUG=347426

Review URL: https://codereview.chromium.org/309553002

git-svn-id: svn://svn.chromium.org/blink/trunk@175995 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make all CSSSelector data members private. Previously, some of the data members
such as m_relation / m_match / m_pseudoType were public and accessed directly
from outside the class. The new approach is better because:
- Those members are bit fields so by using getters, we can hide the casts inside
  the getters. The setters can now also check that the bitfield is big enough to
  actually store the enum value.
- When using those in switch() statements, the compiler now complains if we fail
  to test some of the enum values as the value is now an enum, and not merely an
  unsigned integer.
- Some of these members already has getters (e.g. relation(), pseudoType()).
- Better encapsulation.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/322803004

git-svn-id: svn://svn.chromium.org/blink/trunk@175994 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Removes <style scoped>.

This was discussed and approved with LGTMs in blink-dev:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/R1x18ZLS5qQ/Bjuh_cENhlQJ

Chrome status dashboard entry:
http://www.chromestatus.com/features/5374137958662144

The previous one failed to land due to stale generated file issues and browser test failures (3 times):
https://codereview.chromium.org/310443002/ (original CL)
http://crrev.com/175550 -> http://crrev.com/175552 (stale generated file issue)
http://crrev.com/175555 -> http://crrev.com/175561 (stale generated file issue)
http://crrev.com/175720 -> http://crrev.com/175754 (browser test failures)

Browser test failure was due to HTMLStyleElement refcounting mismatch
in ShadowRoot.  This CL fixes the issue and adds a layout test
fast/css/shadow-style-removed-out-of-document.html
to catch the condition.

Note:
This is based on esprehn's original cl:
https://codereview.chromium.org/214693002/

BUG=379096
TEST=pass all layout tests and do not break any existing tests

Review URL: https://codereview.chromium.org/325663003

git-svn-id: svn://svn.chromium.org/blink/trunk@175993 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Our support for position: sticky isn't even in the experimental feature set. We
shouldn't be burning time during every frame checking whether any RenderLayers
have sticky position.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/328263002

git-svn-id: svn://svn.chromium.org/blink/trunk@175992 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds WebFont.PackageFormat histogram that tracks the usage of
different format of web fonts. It records container format of font file;
both TrueType fonts and OpenType fonts are recorded as SFNT format.
If a font didn't pass OTS sanitization, it's recoreded as Unknown.

BUG=380988
TEST=manually tested with chrome://histograms

Review URL: https://codereview.chromium.org/324003002

git-svn-id: svn://svn.chromium.org/blink/trunk@175991 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This removes two Persistent<>s, and add one Persistent<>.

BUG=

Review URL: https://codereview.chromium.org/333593002

git-svn-id: svn://svn.chromium.org/blink/trunk@175990 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The deleted code was used to ensure the ASSERT(!isAnimating()) on ~SVGAnimatedProperty.
The assert checks that animation is always stopped when the element is dead. However, the assert is removed now, so we don't need to ensure it.

The deleted code |clearAnimatedType| in ~SVGAnimateElement was triggered when a document was unloaded and its <animate> element was destructed before its target svg element. This stopped animation on the target svg elements before the ASSERT run.

BUG=370834

Review URL: https://codereview.chromium.org/327463002

git-svn-id: svn://svn.chromium.org/blink/trunk@175989 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This provides CacheStorage, the namespace of caches, although without
serialization. The idea is to let us test this API end-to-end early,
and we can replace it with something more sophisticated as we
progress.

R=jsbell@chromium.org,falken@chromium.org,jkarlin@chromium.org,asanka@chromium.org,slightlyoff@chromium.org,jakearchibald@chromium.org
TBR=jochen@chromium.org
BUG=374822

Review URL: https://codereview.chromium.org/329433002

git-svn-id: svn://svn.chromium.org/blink/trunk@175988 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL is a simple s/if !ASSERT_DISABLED/if ASSERT_ENABLED/.
Subsequent CLs will clean up the remaining uses and then delete the macro.

NOTRY=true
R=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/327323002

git-svn-id: svn://svn.chromium.org/blink/trunk@175987 bbb929c8-8fbe-4397-9dbb-9b2b20218538

fastMod has been dead code for over one year (since I removed the only call site):
https://chromiumcodereview.appspot.com/14718009

isDrawingToLayer is trivial, and its only call site is inside GraphicsContext.

Review URL: https://codereview.chromium.org/332443003

git-svn-id: svn://svn.chromium.org/blink/trunk@175986 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix some SVGFonts compilation errors that are seen when turning off the compile time flag SVG_FONTS.

BUG=

Review URL: https://codereview.chromium.org/329143007

git-svn-id: svn://svn.chromium.org/blink/trunk@175985 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since we don't have the SVGInstance tree anymore we can get rid of this
template dispatcher.

Review URL: https://codereview.chromium.org/323253002

git-svn-id: svn://svn.chromium.org/blink/trunk@175984 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is based on an earlier patch from <fs@opera.com>.

The performance regression mostly came from excessive tree walks
on SVG_SvgCubics (with only a tiny part of it came also from
extra invalidations).

This change re-introduces what
SVGRenderSupport::checkForSVGRepaintingDuringLayout was doing to
prevent invalidation by checking if your parent had a transform
change, except that we use it to avoid entire subtree walks.

On my Z620, this changes the results of SVG_SvgCubics as follows:
- RAL without patch: 16 ms (std: 0.5)
- RAL with patch: 8.8 ms (std: 0.4)
- Pre-RAL: 9.2 ms (std: 0.3)

BUG=381138

Review URL: https://codereview.chromium.org/327093003

git-svn-id: svn://svn.chromium.org/blink/trunk@175983 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The Dock button should be the rightmost one, otherwise it gets overlapped
by a button to its right (Settings).

R=eustas, pfeldman@chromium.org, vsevik
BUG=383313

Review URL: https://codereview.chromium.org/329113002

git-svn-id: svn://svn.chromium.org/blink/trunk@175978 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL is a bit of a parlor trick, but it seems worthwhile to remove
DeprecatedDirtyCompositingDuringCompositingUpdate.

Review URL: https://codereview.chromium.org/334443005

git-svn-id: svn://svn.chromium.org/blink/trunk@175977 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/320423004

Review URL: https://codereview.chromium.org/328113005

git-svn-id: svn://svn.chromium.org/blink/trunk@175976 bbb929c8-8fbe-4397-9dbb-9b2b20218538