- 26 May, 2020 40 commits
-
-
Peng Huang authored
For vulkan 1.1.0, VmaAllocator will use dedicated memory allocation for some big vulkan memory request, and free it when the allocation is released. Without this change, the VmaAllocator will allocate memory from self managed memory blocks for all vulkan memory request. And the memory may not be released when the allocation is released. VmaAllocator may keep the memory for later usage. It could be the reason for the memory regression in fuchsia. Bug: fuchsia:52463 Change-Id: I7b905435d31b927b2344724f8a2e1738e0544410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215414 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#771927}
-
Swapnil authored
The browsertests of HSTS policy are moved from policy_browsertests to a separate file. Bug: 1086438 Change-Id: If47a9def6da964428113b6ec7192d84df8f5f577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214954 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771926}
-
Varun Khaneja authored
This feature is now fully enabled via Finch. R=xinghuilu Bug: 963165 Change-Id: Ice9c1bcc95736b3cd8dffd57f8b92ba164c592d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216315 Auto-Submit: Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771925}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2e7c4b66..2b302be3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9de39a57b489d47d51acf5bf654b0d40b563dbc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215911Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771924}
-
Liviu Tinta authored
The tests in pointer_lock_browsertest.cc were flaky for 3 reasons: - requestPointerLock being asynchronous - mouse events being asynchronous - native mouse events interfering with tests during execution All the above were addressed in prior CLs. Bug: 766450 Change-Id: I08ba7c5f34d57a92e24480934cb6d2fc731fd6f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213110Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#771923}
-
Nathan Zabriskie authored
With the new RasterInterface::WritePixels API we can now upload pixels directly to textures through RasterInterface without creating paint ops for mailbox backed shared images. This CL modifies existing code to prepare to use the new API. A follow up CL will actually hook up the new API for CanvasResourceProviderSharedImage. Bug: 1063725 Change-Id: Id5cd411e94d1fd8721d5491673f6120bcd6ed33c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210738 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#771922}
-
Ben Kelly authored
This CL fixes a small interop issue where chromium would always recompute the mime type for a response after reading it from cache_storage. This was incorrect because the mime type should be fixed at original response construction time even if its headers are later mutated. This CL also causes service workers to use the mime type originally computed for the Response instead of re-extracting the value from the content-type header. Bug: 938939 Change-Id: I941c1b1e3863e41da49128ce814ac0f1762dae70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211949 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#771921}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 84-4136.1-1589799722-benchmark-84.0.4147.17-r1 to 85-4136.1-1589799307-benchmark-85.0.4150.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I2ba55b7bb1507d01ac0ab7e6f9492c7bef8da820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216462Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771920}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 84-4136.1-1589794882-benchmark-84.0.4147.17-r1 to 85-4136.1-1589798899-benchmark-85.0.4150.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I7294724f84d1442dd72e2e9d1010c80bb243e35b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216463Reviewed-by:
-
dpapad authored
compress="gzip" is (as of r761031) the default behavior for HTML/CSS/JS/SVG files, and therefore there is no need to explicitly specify it. Bug: 1068407 Change-Id: Id9dfb8ea5102991879b6799b061577aff958b57c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212885Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#771918}
-
Mike Frysinger authored
This makes the externs util code easier to use by other presubmit tests by reducing a lot of boilerplate. This also enforces a rule that was being used in practice: the input & output names have to match (other than file extension). So instead of letting the code map "downloads.idl" to the externs "whatever.js" name, the output must now always be "downloads.js". If we ignore the Chromecast & app_shell forks of the Chromium project, this rule holds. Those forks cause problems by providing extensions to a few APIs and thus use duplicate source names. imo, those forks should be providing their own separate externs tree if they want to provide externs (which they don't currently), although I suspect the users are so few that no one will bother. Bug: 469920 Change-Id: Icb9d2ba4ad78c3c607a09402c82841fb745b4b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215901 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771917}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I018c0b1cdefb7336f67d13433b52a02c879e48ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216043Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#771916}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 84-4136.1-1589797128-benchmark-84.0.4147.17-r1 to 85-4136.1-1589796762-benchmark-85.0.4150.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I9028e19a25dea52163a3c017601e07062546817b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216464Reviewed-by:
-
Tao Bai authored
Bug: 949555 Change-Id: I515e93c8394b00d135d36e4b02487b0cbf8315c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212673Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#771914}
-
Dmitry Gozman authored
This method is not used for a long time. Bug: none Change-Id: Idfdf78a4d2a63ba5470ecd1ff6893a34419225ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215379Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#771913}
-
Ian Kilpatrick authored
Previously we cached at the preferred sizes level, this meant that whenever we called LayoutReplaced::PreferredLogicalWidths the (previous) PreferredLogicalWidthsDirty bit got cleared. However we now cache at the IntrinsicLogicalWidths level. The difference is that LayoutReplaced elements don't clear their IntrinsicLgoicalWidthsDirty bit. This meant that the innocent looking: if (!IntrinsicLogicalWidthsDirty()) SetIntrinsicLogicalWidthsDirty(); Was incorrect, as we were never invalidating the container chain. This caused the observed incorrect rendering in the bug. This patch changes this function to always invalidate the container chain for intrinsic sizes, and layout invalidations. Bug: 1086299 Change-Id: I8145a6276d4ec89c0c7acf91c1bf67714c127440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216373 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#771912}
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. Use cases of this call that ONLY refer to incognito or guest mode can use [Get/Has]PrimaryOTRProfile() instead. OffTheRecord profile API use in web_app_utils_unittest.cc are updated and new test cases for non-primary OTRs are added. Bug: 1060940 Change-Id: I4ae83207a1b971efa7aba5bf5e3bf351f2b107de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212121 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#771911}
-
Joe Mason authored
They can be un-pinned by dropping them outside their designated area. R=siggi Change-Id: I719d6be9509666f4387a4bba91946c3861b771eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214913Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Auto-Submit: Joe Mason <joenotcharles@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#771910}
-
Megan Jablonski authored
Bug: 1054643 Change-Id: Ib985d75905b0b496a1f784b6ff8490c2a5b5f848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204963Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#771909}
-
Vincent Boisselle authored
The bug contains more information on why we need to reduce the timeout. Basically, the IPH can go over UI elements sometimes in which case a user may want the IPH to dimiss quickly which doesn't dismiss on touch. Bug: 1086621 Change-Id: I5771bae257f444d627528f6d7094ffd9427ad52e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216318Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#771908}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fe6a353ce47a..adef79808a7d 2020-05-26 terelius@webrtc.org Enable triage alerts in rtc_event_log_visualizer by default. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I43216620cf28d0270bc776249ee309d305f9c01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216455Reviewed-by:
-
Kevin Babbitt authored
This CL pushes stream-based parsing one level deeper in the stack for at-rules. The most notable difference is that at-rule handler functions are now responsible for tokenizing their own preludes and starting block handling if needed. Actual parsing for at-rule preludes is unchanged as of yet; the handler functions generate token ranges on their own and parse them as before. In future CLs we'll be able to convert each at-rule handler to make full use of stream parsing. Bug: 661854 Change-Id: Ia3345be73ab8cc9fce2537443e8a3ed9df017b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208812Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771906}
-
Elly Fong-Jones authored
This change moves most of the logic from BubbleDialogDelegateView into a new class, BubbleDialogDelegate. BubbleDialogDelegate implements the anchoring logic for bubbles, as well as some ancillary functionality around widget activity, anchor view highlighting, and so on. BubbleDialogDelegateView is now mostly a stub class that subclasses both BubbleDialogDelegate and View, and overrides some behavior of View. BDDV = BubbleDialogDelegateView BDD = BubbleDialogDelegate (doesn't yet exist) DDV = DialogDelegateView DD = DialogDelegate WD = WidgetDelegate V = View This CL is the second step in this process: 1. BDDV inherits from DD & V (landed in r770128) 2. Break BDDV into BDD (which inherits from DD) and BDDV (which inherits from both), like the current DD/DDV split 3. For each client class that subclasses BDDV, move that class to subclassing View and containing a BDD member, which is used when a BDD, DD, or WD is needed. 4. Delete BDDV itself 5. Repeat (3) for DDV instead of BDDV 6. Delete DDV itself 7. Remove any remaining subclasses of BDD or DD Change-Id: Ie300eebdeab59709e2bb437ed8c26ee29d0c2835 Bug: 1075649, 1011446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209374 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Roman Sorokin authored
follow-up of CL:2167271 Bug: 1084940 Change-Id: I00503059c781accacd1b1f6de905ca72f1365854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216216Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771904}
-
Charlie Hu authored
base/containers/flat_set.h included in feature_policy.h also caused flat_set being exposed and used in memory_managed_paint_canvas.h. Replace the usage with WTF::HashSet as base/.. is a illegal path to include in files under third_party. Change-Id: If4bc800ea30b3fda4d6ab2554a21c8c6ebf14a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211908 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#771903}
-
ssid authored
The agent was only created in renderer processes earlier. Change-Id: I7238a73d2c8d9b0ba1c5b52d9acfd4161c5cac91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208081Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#771902}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/61fc1e664eac..1f6c971abea1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC bcwhite@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: bcwhite@google.com Change-Id: I79eedb583cb59790eb3dbfbb6f035d1a0767b7d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216354Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771901}
-
Dan Harrington authored
FeedStreamApi changes - Added CreateEphemeralChangeFromPackedData, which moves responsiblity for deserializaing into the component. This required adding a proto file, since we don't already have a message that contains exactly what we need. - Added ProcessThereAndBackAgain and hooked it up to our uploading logic FeedStreamSurface changes - Implement LoadMore(), CommitEphemeralChange(), DiscardEphemeralChange() - Changed ExecuteEphemeralChange() to take a new serialized proto message Bug: 1044139 Change-Id: I5d3cf0f6dc87ec984593d3641baedd97535bccb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210907Reviewed-by:
Ian Wells <iwells@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#771900}
-
bttk authored
Bug: 865801 Change-Id: I8025699a43df94a67991799983f03f0f242d7d55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212996Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Auto-Submit: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#771899}
-
Yue Zhang authored
Currently, TabGridDialog component uses PopupWindow as a container which has shown some disadvantages as feature evolves (https://docs.google.com/document/d/1z49-ehX2VzoY_KcMUOSDi3FU7NzqLlrQocD_M-bPZ1A/edit?usp=sharing) This CL removes the PopupWindow usage in TabGridDialog. Things happened in this CL: * Instead of using PopupWindow as a container, we insert the inflated view into the root view hierarchy and make all TabGridDialog instances share this same view. * Use the ScrimView in RootUiCoordinator instead of creating a new one. This gives us a bonus that the scrim now covers the status bar. * Tweaks in TabGridDialogMediator to make sure the component behaves the same before/after. * Fix tests to adapt to change that TabGridDialog is not in a separate window. Bug: 1069803, 1064140, 997239 Change-Id: I1da2db2bf7ef5b8f304782c4bcc95e951b23623b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119188 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#771898}
-
Anders Hartvoll Ruud authored
The RuleSet of an ActiveStyleSheet can be nullptr for non-matching media (see StyleEngine::RuleSetForSheet), hence we can't DCHECK that it exists. Bug: 1085994 Change-Id: Iac7f746045f46ad7752b30cccce8b6f403cf19b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214537Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#771897}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ea71aeab0bfb..603989e2c0d6 2020-05-26 andreas@apap04.com add clarification for Python 3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I7eb7d7e97cd2f47c3a48a3309597f00207d2b540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216357Reviewed-by:
-
Matt Menke authored
We want to be able to DCHECK that all requests have a non-empty IsolationInfo, and it's safest to just separate out these fetches, rather than reuse something else's IsolationInfo. Bug: 1082280 Change-Id: Ib734910cc16a555673e4127317d05d80ca119f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212442Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#771895}
-
Wan-Teh Chang authored
ITU-T H.273 (Coding-independent code points for video signal type identification) Section 8.3 (Matrix coefficients) says: - Otherwise, if MatrixCoefficients is equal to 8, the following applies: - If BitDepth_C is equal to BitDepth_Y, Equations 44 to 46 apply: Y = Round(0.5 * G + 0.25 * (R + B)) (44) Cb = Round(0.5 * G - 0.25 * (R + B)) + (1 << (BitDepth_C - 1)) (45) Cr = Round(0.5 * (R - B)) + (1 << BitDepth_C - 1)) (46) NOTE 4 - For purposes of the YCgCo nomenclature used in Table 4, Cb Cb and Cr of Equations 45 and 46 may be referred to as Cg and Co, respectively. ... In Table 4, MatrixCoefficients value 8 is YCgCo. Change-Id: Id597cdfba8b0550dbbf05975e744e2ba31ecb623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211925Reviewed-by:Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#771894}
-
Michael Spang authored
As of skia d8fd0bf574 ("Remove deprecated flush calls.") flush() is flushAndSubmit(). Change-Id: I34a1a72bc8857a994e8a35858950882841a96a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213336Reviewed-by:Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#771893}
-
Alexander Dunaev authored
This CL converts the ui::FilenameToURLPolicy enum into enum class. No change to any logic is done. Bug: 1070138 Change-Id: I595e3050cef597a1eb30bae5433eafc7698458c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212171 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
-
Jeremy Roman authored
Change-Id: Ib6994252e9cf8d620149e4feda128ac98c984c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176931Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#771891}
-
Xianzhu Wang authored
TL;DR, with this CL: - We no longer update custom scrollbar part position during paint; - We avoid unnecessary ScheduleAnimation when painting custom scrollbars; - CustomScrollbar::*Rect() methods no longer have side effects; - Some FIXMEs are fixed. Details: Previously LayoutCustomScrollbarPart::FrameRect() stored different values at different document lifecycle stages: - Before paint, its location was always zero, and the size was not the actual size for some parts, but the minimum size calculated from the style, not based on layout, though updated in UpdateLayout(). UpdateLayout() was called not during layout (as a scrollbar part is not in the layout tree), but anytime we wanted the minimum size from const methods of CustomScrollbar. - During paint, as the FrameRect() calculated during UpdateLayout was not the real frame rect, we updated the frame rect to make sure they would be painted correctly. This caused unnecessary SetShouldCheckForPaintInvalidation when the FrameRect changed and unnecessary ScheduleAnimation(). This CL contains the following changes: - Removes LayoutCustomScrollbarPart::UpdateLayout(). Adds ComputeThickness() and ComputeLength(), and lets Margin*() get style directly, to replace the original UpdateLayout() (which called SetSize()/SetMargin*()) + Size()/Margin*() in the const methods of CustomScrollbar. This removes the dependency of the const methods on the temporary incorrect FrameRect(). - Adds CustomScrollbar::PositionScrollbarParts() to set the correct FrameRect() for scrollbar parts. It's called from several places that position of scrollbar parts can change. This replaces the Set* called from CustomScrollbarTheme::Paint*. Bug: 856802 Change-Id: I5b120294a31a7f91831441cb361adfd27aefa44e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167602Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771890}
-
Daniel Hosseinian authored
This reverts commit 146b9f1b. Reason for revert: These tests were actually failing because death tests weren't working on win-asan. That problem has been fixed as of r771124. Also win-asan is not accurately named as it does not define ADDRESS_SANITIZER. Original change's description: > [Sheriff] Disable SQLDatabaseTest on Windows ASAN because they are flaky > > Bug: 1027481 > Change-Id: I7fc1806eada39c58f3f6035736bf9d5c595fbb0b > TBR: pwnall@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946331 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720463} TBR=guidou@chromium.org,gab@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1027481 Change-Id: I91ab2178d555e7ee852d7a8bf6bb5b0ca90f806d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216358 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#771889}
-
Dominique Fauteux-Chapleau authored
Bug: 1076083 Change-Id: Id2c599da0d3699312d667833238a86d7ef259ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212392Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#771888}
-
