GitLab

This reverts commit 81bbe1e6.

Reason for revert: compile error

https://ci.chromium.org/p/chromium/builders/try/linux-chromeos-rel/654323?

seems to conflict with this recent change: https://chromium-review.googlesource.com/c/chromium/src/+/2355015

Original change's description:
> Browser Clipboard: Implements read and write SVG on the browser side
> 
> Implements the SVG format for the clipboard on all blink platforms. The
> implementation is very similar to HTML and plain text. Initially we will
> put this feature behind a flag before it is exposed to the Web Platform.
> 
> Design Doc: https://docs.google.com/document/d/1jq8QSCQRdNy99rnPusmW8is62c22PVuq-Sk-tMT2tRk/edit#
> 
> Bug: 1110511
> Change-Id: I6d405a9704c431a31995bb50a17dfc309b49b74b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313961
> Reviewed-by: Jarryd Goodman <jarrydg@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#800774}

TBR=sky@chromium.org,dcheng@chromium.org,jarrydg@chromium.org,huangdarwin@chromium.org,dsleeps@google.com

Change-Id: I0e550072698323d9a7e0754548821e2c765e3162
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1110511
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369419Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800797}

This reverts commit 60b63538.

Reason for revert: failing test was marked as failing in issue 1120106 for a different root cause.

Original change's description:
> Revert "Don't trigger main-thread overlay scrollbar animations if composited"
>
> This reverts commit f5cdac12.
>
> Reason for revert: This might be the cause of test failure virtual/threaded/external/wpt/feature-policy/experimental-features/vertical-scroll-disabled-scrollbar-tentative.html for https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/48699 (and some builds after this). Revert to see if this fixed the test.
>
> Original change's description:
> > Don't trigger main-thread overlay scrollbar animations if composited
> >
> > There are already hit tests and animations entirely in the impl thread
> > for such scrollbars.
> >
> > Bug: 1116800
> >
> > Change-Id: I2714258717c89e0ea41232eb86abe12570526d28
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364972
> > Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
> > Reviewed-by: David Bokan <bokan@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#800302}
>
> TBR=bokan@chromium.org,chrishtr@chromium.org
>
> Change-Id: Ided42e8aa3339e93f85d9f73f3737197864b493d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1116800
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369076
> Reviewed-by: Maggie Cai <mxcai@chromium.org>
> Commit-Queue: Maggie Cai <mxcai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#800529}

TBR=bokan@chromium.org,chrishtr@chromium.org,mxcai@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1116800,1120106
Change-Id: I1f88a6c521618dc1d0b4d7e0d97c44acfc224214
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368490
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800796}

A captured tab going into fullscreen is treated differently: instead
of taking up the entire screen, it only fills the browser's contents
container. This is to allow tabs to enter fullscreen while being
streamed without disrupting the user. For example, fullscreening a
video during capture will cause the video to fill the tab contents
rather than the whole screen.

Thumbnail capture uses this same infrastructure but shouldn't affect
any user-visible behavior. This CL prevents thumbnails from being
captured on visible tabs.

Ideally we'd be able to put a capture hold on a WebContents without
affecting fullscreen behavior, but implementing that is a larger
investment. Fixing this bug is a high priority.

Bug: 1112607
Change-Id: I58cc53b2d881bf65cf2a9cb70d1a5d1592d02ad2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354728
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800795}

Unbundled consent will allow GetAuthToken to make API calls to the
server to automatically select an account to request permissions from.
This account can be one specified by the extension or one that
previously granted permissions to the extension. This can be useful for
users so they don't need to choose or remember the "correct" account in
the account chooser. This CL adds this feature of skipping the account
chooser and puts it behind a flag to enable it.

Bug: 1100535
Change-Id: I859784b5d3a533144c48802845b3317ce0e01935
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363879
Commit-Queue: William Lin <williamlin@google.com>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800794}

This reverts commit 297abb5a.

Reason for revert: Potential cause of crbug.com/1120848

Bug: 1120848

Original change's description:
> [ios] noncq to run tests on 14.0 simulators
> 
> ios-simulator-noncq to compile with xc12b5 as well.
> Running iOS 14.0 simulators for our test suites on xc12b5.
> 
> Change-Id: I7ca5f763174c296278401ae3563894a4f5210379
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367792
> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
> Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#800739}

TBR=justincohen@chromium.org,lindsayw@chromium.org,gbeaty@chromium.org,jeffyoon@chromium.org

Change-Id: I3ad22482336124cfff4edc4f521833cf54507dcb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368324Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800793}

This is intended to replace the PrintingAPIExtensionsWhitelist
policy. The old policy will still be used in the absence of the new one
for at least a few releases of Chrome.

BUG=chromium:1119444

Change-Id: Ia4b6d84cd8e716d3a2fb676df288dace50a3f4e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365757
Commit-Queue: Brian Malcolm <bmalcolm@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Nikita Podguzov <nikitapodguzov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800792}

Update PDFiumPage to use gfx::Rect instead of pp::Rect. Update callers
to expect gfx::Rect as return value instead of pp::Rect.

Bug: 1101101
Change-Id: Ibf7b57a007545d2f70ca1a4c72bb428d4b30a139
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367133
Commit-Queue: Ankit Kumar 🌪️ <ankk@microsoft.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: K. Moon <kmoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800791}

https://android.googlesource.com/platform/external/perfetto.git/+log/9869f187b5ea..c86d8fb76ac3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I83fd0e4436d11a51c67a22fc0dca66ac0806b43d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369267Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#800790}

Design doc: go/castinwl

Bug: 1057100
Change-Id: Iabb0cdf3e949737e1cbc5b99f3f8ebeb6297a820
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367696Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800789}

After this CL, the blocklist emitted by the rewriter will include fields
that may cause presence of global destructors (if CheckedPtr has a
non-trivial destructor, such as required by BackupRefPtr
implementation).

Bug: 1069567
Change-Id: I8e547c813198220549875a64baa70af53a96f1fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368934
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800788}

Add logging tab and support to send logs created with PA_LOG macro to
chrome://multidevice-internals page for display. Logs color coded by
severity and displayed with timestamp and log file. Screenshot of
display here:
https://screenshot.googleplex.com/bc0d994b-4f58-4793-84f8-144a150f1496

Change-Id: Ic68aad70c400c5bdc55f7fa37fb20c36c4669233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366654
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800787}

This CL verifies that the browser process will reject attempts that a
comprimised foo.com renderer can make in an attempt to show a bar.com
URL in the Omnibox.

Before this CL, there was already a
SecurityExploitBrowserTest.DidCommitInvalidURL test: committing A)
bar.com URL with B) origin set to foo.com, C) in a process locked to
foo.com.

This CL adds DidCommitInvalidURLWithOpaqueOrigin test which tests
committing A) bar.com URL, B) with opaque origin derived from foo.com,
C) in a process locked to foo.com.

Fixed: 918565
Change-Id: I332349e889b83d1cd298050adbf9dca2f55125ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368288
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800786}

The text on the Tab Switcher is currently misaligned in landscape mode
on notched phones. This affects both the illustrated-empty-states on
and off cases.

Before and After Screenshots (googlers only, sorry):
https://docs.google.com/presentation/d/1cZ151DN3Pywk2Ry-NSrMcM-Vf9v2Qbx35GBZFslSoTk/edit#slide=id.g91d5f68a07_0_6

Bug: 1116296
Change-Id: Icfa15e02abfba5c07b792adb168820755a596206
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369260Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800785}

Using wpt-import in Chromium 17122f17.
With Chromium commits locally applied on WPT:
3b705a74 "WPT: Service Worker: Add unexpected state check to wait_for_state()"
9f52c7e4 "COOP: add reporting to redirects"
f3b221b0 "[COOP] access reporting: Extend report.body.type values."
5da0ed1e "Allow range requests to pass through a service worker"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=foolip@google.com

No-Export: true
Change-Id: I643c2298711d319cb9f6f3c7159269e602fb2eb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368774Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#800784}

Bug: 1120709
Change-Id: I12841b7bfd5d9a987ec6c9e13016e8109aef447f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368876
Commit-Queue: Anna Malova <amalova@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800783}

This patch fixes typo to replace "liasons" with "liaisons" in the comment.

Change-Id: I94edf4ccee8eb75287c1b92f91c4502117ee00b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362054Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800782}

This is a reland of 7d2d8cc1

Original change's description:
> GMC: Redesign audio picker UI
> 
> Implement the new UI for the audio device picker in global media
> controls. As part of this change, the MediaNotificationBackground will
> draw a gradient between the device picker and notification artwork if
> the picker is availabile.
> 
> Screenshots of this updated UI will be posted on the crbug.
> 
> Change-Id: Ic7186c770102663b08e85b56eeddfbfa13833c3c
> Bug: 1117160
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358512
> Commit-Queue: Noah Rose Ledesma <noahrose@google.com>
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#800243}

Bug: 1117160
Change-Id: I3adf5e58dcb8cd77758abd75aa5d497ab0f50c2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368504Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Noah Rose Ledesma <noahrose@google.com>
Cr-Commit-Position: refs/heads/master@{#800781}

When the key type is set to KEY_TYPE_FINGERPRINT, CheckKey will wait
for a fingerprint scan result from biometrics daemon and report the
result. (See http://crrev/c/1941087 for more details.)

This change enables ExtendedAuthenticator to request fingerprint scan
result by calling CheckKey(KEY_TYPE_FINGERPRINT). With this change,
clients of ExtendedAuthenticator can perform fingerprint auth without
having to talk to biometrics daemon directly.

Bug: b:156258540, b:144861739
Change-Id: I923a53afa283dd4794ab8af239da894800a7a3f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364797
Commit-Queue: Yicheng Li <yichengli@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800780}

This CL removes PhoneHubManager::Get(), and instead provides
PhoneHubManager to //ash via new function
SystemTray::SetPhoneHubManager().

This function is left as a TODO for now; a follow-up CL will use the
provided PhoneHubManager pointer to render the UI in //ash.

Bug: 1106937
Change-Id: I4a69d700d4e086d3e59ceaaf5ae1a364824a3633
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368485Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800779}

This reverts commit 40efa001.

Reason for revert: crbug.com/1120811

Original change's description:
> Inhibit hang watching during views::DesktopDragDropClientWin::StartDragAndDrop
> 
> The nested loop process the native events but not the tasks which looks
> like a hang if not inhibited.
> 
> Bug: 806174, 1120381
> Change-Id: Ie298b16a4e0f8cdd6c4ba398d71a7fee02b9d46d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369253
> Reviewed-by: Robert Liao <robliao@chromium.org>
> Commit-Queue: Robert Liao <robliao@chromium.org>
> Commit-Queue: Oliver Li <olivierli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#800626}

TBR=robliao@chromium.org,olivierli@chromium.org

Change-Id: I74f4dcda0ef7dcdd47bcd6e8426c4776575c04d1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 806174
Bug: 1120381
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368336Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800778}

Uses the new gesture type added in https://crrev.com/c/2301084. See
(Google-only) go/cros-wheel-tick-counts for the design doc.

Bug: 1077644
Test: run unit tests

Change-Id: I287740706c77114ac08b84376186096b81138e7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337272
Commit-Queue: Harry Cutts <hcutts@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Sean O'Brien <seobrien@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800777}

Using unretained for decoder/selector callbacks is generally not safe /
fragile. For ex, some decoders (e.g. those that offload) will call the
output callback after destruction. Another example: decoder selector
internally posts the Select() callback, so it may run after destruction.

Additionally, sending incoming callbacks as CrossThreadFunctions for
invoking on the media thread is not safe. We may destruct while some
callbacks are still pending, destroying the callbacks internal state
(including bindings to blink GC types) off the main thread. Now we
ensure that all callbacks are saved on the main thread and we extend
the "client" interfaces of the broker for proxying the callbacks safely.

Bug: 1120431

Change-Id: I2ccfe46982cda9b18e47a56424b25f54f8877883
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366661
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Auto-Submit: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800776}

This is an initial patch to add support for authenticator large blobs.
When a chrome extension creates a resident credential on an
authenticator that supports largeBlobKey, a key is generated and stored
alongside the credential.

At the moment this does nothing in the real world since there are no
hardware implementations for the authenticator extension.

See https://w3c.github.io/webauthn/#sctn-large-blob-extension

Bug: 1114875
Change-Id: Ib0791e143ab78d9f09461ee0a3226fb9c23f75cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353150
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#800775}

Implements the SVG format for the clipboard on all blink platforms. The
implementation is very similar to HTML and plain text. Initially we will
put this feature behind a flag before it is exposed to the Web Platform.

Design Doc: https://docs.google.com/document/d/1jq8QSCQRdNy99rnPusmW8is62c22PVuq-Sk-tMT2tRk/edit#

Bug: 1110511
Change-Id: I6d405a9704c431a31995bb50a17dfc309b49b74b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313961Reviewed-by: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800774}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/662c01bba296..0a98cc54ea0d

2020-08-21 changhaohan@chromium.org Implements grouped Computed styles in the Computed tab

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1084673,chromium:1096230,chromium:1106251
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I69845514cd8b6a6e162d832f4cd10e4f6d3898c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369240Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#800773}

The simple lacros feedback report includes the following:

1. Lacros feedback reports are sent with ChromeOS product id, so
that they will be found under ChromeOS product on Listnr.

2. Prefix the chrome version string with "Lacros ", so that lacros
reports can be filtered by "Version" (for example "Lacros") on Listnr.

3. Attach lacros user log in the system log.

Bug:1109387
TEST:
1. Open Lacros browser, send a feedback report by clicking
"Report an issue" under Help menu.
2. Verify the report can be found at
http://listnr site. The chrome version string should have
a "Lacros " at the beginning, for example, "Lacros 86.0.4238.0".
3. Verify the report contains both system_logs.zip and histograms.zip.
The system log should contain lacros log data from
/home/chronos/user/lacros/lacros.log under "lacros_user_log" section.


Change-Id: I98b381724866d163dc760147448a80e2249c0a1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362977
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Miriam Zimmerman <mutexlox@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800772}

Bug: 1109373
Change-Id: I32b5295f0d6febf565543ec846d6456d622d2998
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369675Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Anjali Doneria <adoneria@google.com>
Cr-Commit-Position: refs/heads/master@{#800771}

Add OPTIONAL_TRACE_EVENT{0,1,2} macros. They are equivalent to regular
TRACE_EVENTs, but they are disabled by default on the platforms where
binary size is a significant factor.

R=eseckler@chromium.org
BUG=1043616

Change-Id: Ifb4265856826423c5079c5d412fc1234db19e820
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359132
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800770}

Used to track how frequently users are still using a shortcut
planned for deprecation.

Bug: 10840227
Change-Id: I59b94aa81d973595282ea9c7aebf79a9ad3c0e36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364083
Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800769}

Purpose: Move payment request UI logic of buildUI to PaymentUIsManager

Change:
* buildPaymentRequestUI() implemented in PaymentUIsManager
* added PaymentUIsObserver interface
* getShippingType() implemented in PaymentOptionsUtils

Bug: 1112974
Change-Id: I7ce7e9193bdd3f368ee44bb7457a92275b340beb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343155
Commit-Queue: Zarah Tesfai <ztesfai@google.com>
Auto-Submit: Zarah Tesfai <ztesfai@google.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800768}

This CL logs a successful cryptid rendering when the asset is
successfully fetched and injected, and invokes writing the timestamp to
the relevant pref. It also adds logging for failed asset fetches, and as
a baseline logs instances where the conditions for rendering were not
satisfied.

I considered using a Histogram for this logging; however, I do intend to
look at the action sequences following a successful render, so I thought
a User Action was more appropriate.

Bug: 1120348
Change-Id: Ib9a536aa928591a2105cdaaca4e054b2c2a01ef8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367642Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800767}

Bug: 1045266
Test: NetworkComponentsNetworkNameserversTest*
Change-Id: I4d5de5f840c80aaf3ad5f57ec77db6ac6c94208a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369614
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Auto-Submit: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800766}

This change moves throwing the exception if Router was not closed to the
executor thread to make it crash instead of just logging.

Bug: 1087098
Change-Id: I65c510bdbadedc3a0589807843c57e925c0351c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321345Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800765}

Lacros uses the chromeOS user-agent string but does not display
ash-specific settings. Historically, webui relied on the user-agent to
determine what platform the browser runs on. The combination of the two
results in webUI settings trying to access ash-only private extension
APIs, causing a crash.

This CL updates the logic to explicitly check platform via gn args via
grit, and plumbs through lacros as a new platform.

This CL has one known problem: grit is not processed for js/cr.js for
some webUI tests. This results on isLacros and isChromeOS returning the
wrong values. This doesn't seem to affect any tests for now, but this is
a problem that should be fixed. This is tracked in
https://crbug.com/1118190.

Bug: 1111985
Change-Id: I038a533ccbc5018cd125a49e70320a36b5aa4d31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360816
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800764}

https://chromium.googlesource.com/catapult.git/+log/a2193f8a8b70..ea8d6a46aad5

2020-08-21 chonggu@google.com [Fuchsia] Add version and board type info to Fuchsia

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC zhanliang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1084367
Tbr: zhanliang@google.com
Change-Id: Ib21f66b7c7214391a44ee4a4c06e2f3bc7253af6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369635Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#800763}

This CL:
- Moves the snapshots storage into the BrowserState folder
with the following path template:
[BrowserState folder]/Sessions/[SceneSession ID]/Snapshots/
- Adds folder migration to the startup task. Migration is only
performed once and the old snapshots folder is deleted.

Change-Id: Ic5bf2fa0cd088e466084d72d408484ff949da17a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354838
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800762}

https://skia.googlesource.com/skia.git/+log/8bd6c9830dd4..13c4dbe2ef24

2020-08-21 fmalita@chromium.org [skottie] Add support for baseline shift

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC stani@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: stani@google.com
Change-Id: I03f6b4d65e90977d343e8af2fa3ce85945ae073f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368115Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#800761}

https://swiftshader.googlesource.com/SwiftShader.git/+log/aba65a8e1ce1..622558b02e1a

2020-08-21 srisser@google.com Revert "Add getPhysicalDeviceFeatures2"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I885fff5c383bcc598f280cee0960089c10b5443d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369416Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#800760}

BUG=1066670

Change-Id: I324c66b3848c4ef6dd40326ae08270c8f14c9eee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354916
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800759}

Cryptohome already supports starting/ending fingerprint auth session
(i.e. preparing biometrics daemon for upcoming fingerprint scan / back
to normal mode).

This change enables ExtendedAuthenticator to start fingerprint auth
session so that ExtendedAuthenticator can be used to do fingerprint
auth.

The reason why fingerprint auth needs starting/ending auth session is
because it is expensive to switch mode of the fingerprint MCU. The
client should only end fingerprint auth session when no more fingerprint
retries are expected.

The reason why we are doing this by calling cryptohome, instead of
calling biometrics daemon, is that we want cryptohome to control all
authentication mechanisms, and there's a generalized "auth session"
project in cryptohome.

Bug: b:156258540, b:144861739
Change-Id: I767b2aff9791c838674d8ace8ab8d4494f69e603
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364894
Commit-Queue: Yicheng Li <yichengli@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800758}