- 17 Mar, 2016 19 commits
-
-
enne authored
As a part of https://codereview.chromium.org/1774323003, it became clear that it needed to be possible to call SetClientReady repeatedly, which some sources didn't support. Instead of just making that part of the contract, instead fold the two places where SetClientReady mattered into AddObserver (the first time where a begin frame could actually be delivered) and remove SetClientReady from the API. R=skyostil@chromium.org,sunnyps@chomium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1778853003 Cr-Commit-Position: refs/heads/master@{#381612}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/2732e186a113..bf680c30a280 $ git log 2732e186a..bf680c30a --date=short --no-merges --format='%ad %ae %s' 2016-03-16 senorblanco Image filters: fix the zero-sigma fast path in SkBlurImageFilter. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=bungeman@google.com Review URL: https://codereview.chromium.org/1808683003 Cr-Commit-Position: refs/heads/master@{#381611}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e27a07b4..eaa2e514 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1806963003 Cr-Commit-Position: refs/heads/master@{#381610}
-
lshang authored
Migrate to use SetContentSettingDefaultScope() which takes GURLs only in plugins. For special test or specific patterns, remain to use SetContentSetting(). BUG=551747 Review URL: https://codereview.chromium.org/1800913002 Cr-Commit-Position: refs/heads/master@{#381609}
-
lshang authored
DesktopNotificationProfileUtil::ClearSetting() is changed to take GURLs directly which internally call HostContentSettingsMap::SetContentSettingDefaultScope(). For case in MessageCenterSettingsController, since the patterns are from user input, SetContentSetting() is used instead of ClearSetting() to take patterns directly. BUG=551747 Review URL: https://codereview.chromium.org/1694923004 Cr-Commit-Position: refs/heads/master@{#381608}
-
mgiuca authored
Previously, ToImageSkia, ToUIImage and ToNSImage would assume the scoped_ptr they pass to AddRepresentation would remain valid after that method returns. This *should* be the case, but it is poor form to assume it. Now AddRepresentation returns a valid pointer and the callers return that, rather than assuming the scoped_ptr stays alive. BUG=590882 Review URL: https://codereview.chromium.org/1769433002 Cr-Commit-Position: refs/heads/master@{#381607}
-
rsleevi authored
This updates from revision 3594dcfbd8cf1cb3ba2c57bd56b761147ea31fca (2016-01-04) to revision fa6e6592cd76eb0cf6d442dbebe24f0a22787c6e (2016-03-01) R=pkasting@chromium.org BUG=37436 Review URL: https://codereview.chromium.org/1750853002 Cr-Commit-Position: refs/heads/master@{#381606}
-
raymes authored
PluginObject creation can fail if there isn't a valid V8 context. In this case we need to take care to free the ppp_class_data. BUG=594926 Review URL: https://codereview.chromium.org/1805303002 Cr-Commit-Position: refs/heads/master@{#381605}
-
tsergeant authored
This means that localization is performed before data is sent to the WebUI client. This CL removes almost all existing i18n-template usage. We still have a small number of more complex strings which are created in JS which are more difficult to convert to the new system. BUG=563884 Review URL: https://codereview.chromium.org/1609683002 Cr-Commit-Position: refs/heads/master@{#381604}
-
rdevlin.cronin authored
Move most of the logic for extension action execution into the ExtensionActionRunner (instead of the ExtensionActionAPI), which eliminates some of the back-and-forth and makes a more common place for execution logic and adds slightly finer-grained control for what to execute. This also becomes more important with upcoming changes for webRequest/document_start handling. BUG=595087 Review URL: https://codereview.chromium.org/1804123003 Cr-Commit-Position: refs/heads/master@{#381603}
-
oshima authored
BUG=595490 TBR=zhaoqin@chromium.org Review URL: https://codereview.chromium.org/1809883002 Cr-Commit-Position: refs/heads/master@{#381602}
-
nasko authored
Since swapped out RenderFrameHosts are no longer used, its swapped out state is no longer necessary. This CL removes it along with a public API that exposed it outside of content/. BUG=357747 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review URL: https://codereview.chromium.org/1799163002 Cr-Commit-Position: refs/heads/master@{#381601}
-
Rebaseline Bot authored
https://chromium.googlesource.com/chromium/src/+/001d37a4b BUG=589525 TBR=pdr@chromium.org Review URL: https://codereview.chromium.org/1813573002 . Cr-Commit-Position: refs/heads/master@{#381600}
-
jbudorick authored
BUG=525873 Review URL: https://codereview.chromium.org/1695913002 Cr-Commit-Position: refs/heads/master@{#381599}
-
danakj authored
We make the ContextProviderCommandBuffer and its WebGraphicsContext3D private in the command buffer version of the tests, and use a GLInProcessContext in the in-process version. The shared code only is exposed to GLES2Interface and ContextSupport. R=kbr@chromium.org BUG=584497 Review URL: https://codereview.chromium.org/1807813002 Cr-Commit-Position: refs/heads/master@{#381598}
-
fgorski authored
Adding a check for a null bookmark ID and tests. BUG=594896 TBR=nyquist@chromium.org Review URL: https://codereview.chromium.org/1804213002 Cr-Commit-Position: refs/heads/master@{#381597}
-
danakj authored
R=kbr@chromium.org BUG=584497 Review URL: https://codereview.chromium.org/1807783002 Cr-Commit-Position: refs/heads/master@{#381596}
-
tedchoc authored
In https://codereview.chromium.org/1638303002, we began potentially removing the overscroll refresh layout at the end of the animations. According to this article: http://stackoverflow.com/questions/15636658/nullpointerexception-when-adding-removing-views-of-a-relativelayout-animations That could potentially be the source of the crashes we are seeing. Changing it to post the detach instead of calling it synchronously in the animation listener. BUG=590359 Review URL: https://codereview.chromium.org/1800293004 Cr-Commit-Position: refs/heads/master@{#381595}
-
paulirish authored
BUG= Review URL: https://codereview.chromium.org/1801293003 Cr-Commit-Position: refs/heads/master@{#381594}
-
- 16 Mar, 2016 21 commits
-
-
erikchen authored
This is required to update the deployment target to OS X 10.7. Eventually, the deprecated Keychain methods should be removed entirely. BUG=595468, 592663 Review URL: https://codereview.chromium.org/1813523002 Cr-Commit-Position: refs/heads/master@{#381593}
-
oshima authored
BUG=595408 TBR=bcwhite@chromium.org Review URL: https://codereview.chromium.org/1813543002 Cr-Commit-Position: refs/heads/master@{#381592}
-
rdevlin.cronin authored
BUG=595168 Review URL: https://codereview.chromium.org/1806723003 Cr-Commit-Position: refs/heads/master@{#381591}
-
ymalik authored
Initial CL in unifying the keyboard behavior between ChromeOS and Android. If the enable-osk-overscroll flag is set, this change will keep the Blink viewport size stable and set the visible_viewport_size to the smaller value. This CL adds a new View (InsetObserverView) to the View hierarchy that will store the value of insets (OSK, status bar). When there is a resize due to OSK show, we keep the view bounds the same and change the visible viewport size. Design doc: http://go/osk-unification BUG=404315 Review URL: https://codereview.chromium.org/1386403003 Cr-Commit-Position: refs/heads/master@{#381590}
-
fgorski authored
The following tests are expected to crash on Android Web Kit Layout bots. editing/caret/caret-color.html fast/invalid/009.html fast/hidpi/clip-text-in-hidpi.html BUG=595483 R=pdr@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1813563002 Cr-Commit-Position: refs/heads/master@{#381589}
-
boliu authored
This is a follow up fix to r361481. After r361481 additional info about a LoadDataWithBaseURL is stored in DocumentState. However, if there is an in-page fragment navigation, this additional info is just thrown away, causing incorrect behavior. Fix this by not updating this additional info for in-page navigations. Note this is NOT a fix for crbug.com/561034, which describes a similar problem, but on the browser side. BUG=594611 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review URL: https://codereview.chromium.org/1802383004 Cr-Commit-Position: refs/heads/master@{#381588}
-
estark authored
The inputs needed for isSecureContext() were, previously: a.) the origins of the current frame and its ancestors b.) for any sandboxed origins in the ancestor chain, the URLs of those frames (a) is easily accessible in --site-per-process, but (b) is not. For sandboxed frames, the URL was used to construct a stand-in origin. The sandboxed frame was considered potentially trustworthy if the stand-in origin was potentially trustworthy. In --site-per-process, instead of using the URL for a sandboxed origin, we save the necessary information (the potential-trustworthiness) at the time that the origin becomes sandboxed. Based on https://codereview.chromium.org/1716303002/ BUG=571079 TEST=secureContexts/* layout tests with --site-per-process CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review URL: https://codereview.chromium.org/1723753002 Cr-Commit-Position: refs/heads/master@{#381587}
-
danakj authored
This is toward deleting the class entirely. These methods were not used at all, or for a couple of them, had one caller which we redirect to the GLES2Interface directly. Adds a DEPS entry for core/testing/ to use GLES2Interface as there's code in there calling things on WebGraphicsContext3D now. R=kbr,esprehn,sievers,chrishtr BUG=584497 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Review URL: https://codereview.chromium.org/1809553002 Cr-Commit-Position: refs/heads/master@{#381586}
-
khushalsagar authored
Revert of Fix typo in Android perf variations for unified media pipeline trial. (patchset #1 id:1 of https://codereview.chromium.org/1808803002/ ) Reason for revert: This is breaking the media tests downstream. Original issue's description: > Fix typo in Android perf variations for unified media pipeline trial. > > BUG=533190 > TEST=none > > Committed: https://crrev.com/31d22b6338ac6ac8b95e9f4c20cdccea11609be2 > Cr-Commit-Position: refs/heads/master@{#381498} TBR=asvitkine@chromium.org,dalecurtis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=533190 Review URL: https://codereview.chromium.org/1813553002 Cr-Commit-Position: refs/heads/master@{#381585}
-
robertocn authored
TBR=sullivan BUG=595404 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Review URL: https://codereview.chromium.org/1812613002 Cr-Commit-Position: refs/heads/master@{#381584}
-
abhishekbh authored
This change implements the SetWifiEnabledState API for the Host. BUG=594723 BUG=b/27107139 Review URL: https://codereview.chromium.org/1798293002 Cr-Commit-Position: refs/heads/master@{#381583}
-
estade authored
The solid line separator is retained for both the top and between infobars. Now both the bottom and the top have pieces that overlap the rest of the browser. On the top, it's the arrow, and on the bottom, it's the shadow. This changes the layout of InfoBarContainerView such that it's always sized with zero overlap. This simplifies layout in the browser view and is now possible because layers allow child views to draw outside their bounds. This also makes event hit testing simpler (no need to override the event targeter for the container). BUG=520266 Review URL: https://codereview.chromium.org/1800373002 Cr-Commit-Position: refs/heads/master@{#381582}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e4173cd91158..468628c224cf $ git log e4173cd91..468628c22 --date=short --no-merges --format='%ad %ae %s' CQ_INCLUDE_TRYBOTS= TBR=catapult-sheriff@chromium.org Review URL: https://codereview.chromium.org/1811693003 Cr-Commit-Position: refs/heads/master@{#381581}
-
cwallez authored
Tryjobs on this bot try to run the angle_deqp_gles3_tests but it isn't found causing gn gen to fail. This fixes this issue by adding the correct gn flag to make ANGLE generate the dEQP targets. BUG=583702 Review URL: https://codereview.chromium.org/1809803003 Cr-Commit-Position: refs/heads/master@{#381580}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/830dfd87a770..2732e186a113 $ git log 830dfd87a..2732e186a --date=short --no-merges --format='%ad %ae %s' 2016-03-16 benjaminwagner Un-deprecate new methods to fix Android. 2016-03-16 mtklein detach -> release CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=bungeman@google.com Review URL: https://codereview.chromium.org/1806013004 Cr-Commit-Position: refs/heads/master@{#381579}
-
fgorski authored
* Adds ability to display an offline bolt icon in CCT, when viewing an offline copy of the page * Appropriately animates 6 state transitions between the following 3 states: no icon, security icon, offline icon. BUG=593833 R=tedchoc@chromium.org Review URL: https://codereview.chromium.org/1804723002 Cr-Commit-Position: refs/heads/master@{#381578}
-
kojii authored
BUG=581974 Review URL: https://codereview.chromium.org/1804963003 Cr-Commit-Position: refs/heads/master@{#381577}
-
mmccoy authored
BUG=594850 Review URL: https://codereview.chromium.org/1801333002 Cr-Commit-Position: refs/heads/master@{#381576}
-
fgorski authored
Revert of Add sk_sp helpers and switch Blink SkShader clients to the new APIs (patchset #7 id:120001 of https://codereview.chromium.org/1789063005/ ) Reason for revert: Suspecting this patch to have caused the compilation failure: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20non-Oilpan/builds/811 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20non-Oilpan/builds/811/steps/compile/logs/stdio Original issue's description: > Add sk_sp helpers and switch Blink SkShader clients to the new APIs > > Introduce a couple of Skia utilities to support PassRefPtr <-> sk_sp > interoperability: > > * adoptRef(sk_sp<T>) - for adopting sk_sps rvals into PassRevPtr > (when transferring ownership from Skia->Blink) > * adoptSkSp(PassRefPtr<T>) - for adopting PassRefPtr rvals into sk_sp > (when transferring ownership from Blink->Skia) > > Update clients to use the new Skia shader factories ("makers" vs. prev > "creators"), and sk_sp-based setters. > > A tangential change: deconstify SkPicture fields/args to align with the new > Skia APIs (SkPicture is inherently const - no non-cost methods - and Skia now > expects non-const SkPicture args). > > BUG=skia:5077 > R=jbroman@chromium.org,reed@google.com,senorblanco@chromium.org > > Committed: https://crrev.com/2df3d4433fc756f1297c4e0ced6524cbfcba9571 > Cr-Commit-Position: refs/heads/master@{#381563} TBR=jbroman@chromium.org,bungeman@chromium.org,reed@google.com,senorblanco@chromium.org,danakj@chromium.org,fmalita@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:5077 Review URL: https://codereview.chromium.org/1814473003 Cr-Commit-Position: refs/heads/master@{#381575}
-
timav authored
This CL adds a stub service that implements interface::AudioDecoder. The interface is modified to pass the AudioDecoderClient which can transfer the results back to the proxy. BUG=542910 Review URL: https://codereview.chromium.org/1808593002 Cr-Commit-Position: refs/heads/master@{#381574}
-
tsepez authored
This reverts commit 13fe4645. See https://codereview.chromium.org/1761673002/ TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1811743002 Cr-Commit-Position: refs/heads/master@{#381573}
-