GitLab

As of https://crrev.com/414077, we would not recognize swipe gestures when the NTP is scrolled, but the touch event would still be dispatched by the toolbar (which would then ignore it). Instead, we now forward the touch events to the NewTabPageView if the toolbar is moved away from its original position.

BUG=631976

Review-Url: https://codereview.chromium.org/2276793003
Cr-Commit-Position: refs/heads/master@{#414380}

This CL includes following changes
- Add a dismiss button on warning banner about Downloads space. If a user dismiss the banner, we won't show unless 36 hours have passed.
- Show the warning banner about Downloads when the available size is less than 1GB. (It used to be 20%)

BUG=634207
TEST=manually tested by modifying DOWNLOADS_SPACE_WARNING_DISMISS_DURATION from 36 hours to 10 seconds.

Review-Url: https://codereview.chromium.org/2271203002
Cr-Commit-Position: refs/heads/master@{#414379}

It has recently completed its 90d compliance monitoring period.

BUG=605415

Review-Url: https://codereview.chromium.org/2202823003
Cr-Commit-Position: refs/heads/master@{#414378}

BUG=640560

Review-Url: https://codereview.chromium.org/2277833002
Cr-Commit-Position: refs/heads/master@{#414377}

BUG=none
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/2272653003 .

Cr-Commit-Position: refs/heads/master@{#414376}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2253943004
Cr-Commit-Position: refs/heads/master@{#414375}

m_client is null after frame gets detached. Hence we don't need to check
frame() in ScreenOrientation::isActiveAndVisible.

This is a follow-up after https://codereview.chromium.org/2272043003/.

BUG=

Review-Url: https://codereview.chromium.org/2273193003
Cr-Commit-Position: refs/heads/master@{#414374}

Until now, System Health stories had to be recorded through a benchmark,
e.g. system_health.memory_*:

  tools/perf/record_wpr mobile_memory_system_health
  tools/perf/record_wpr desktop_memory_system_health

This goes against the idea of SH stories being reusable across multiple
benchmarks. Instead, it is now possible (and recommended) to record
directly through the story set:

  tools/perf/record_wpr mobile_system_health_story_set
  tools/perf/record_wpr desktop_system_health_story_set

This will ensure that all SH stories are recorded under the same
conditions (10s wait at the end of the story without a memory dump).

BUG=589726

Review-Url: https://codereview.chromium.org/2276943002
Cr-Commit-Position: refs/heads/master@{#414373}

We observed that if a screenshot is captured while simultaneously the frame
is resized, it is possible that the screenshot is lost. This is because the latency
info (which identifies a CompositorFrame as the screenshot's frame) is sent
from the renderer within a wrongly sized CompositorFrame, which is then
skipped by DelegatedFrameHost.

For situations with an active resize lock, the latency info attached to dropped
frames is saved by the DFH and re-attached to the first frame that is not
dropped. However, this does not happen if the frame is dropped further down
the line, because it is not of the desired size of the RWHV.

This patch also saves the latency info for such wrongly sized frames in DFH,
until a correctly sized frame is submitted.

BUG=637066

Review-Url: https://codereview.chromium.org/2248183003
Cr-Commit-Position: refs/heads/master@{#414372}

getSizeStat() for Downloads used to return
|actual available space| + |evictable Drive cache| - 512MB.
To be consistent with Storage manager (chrome://settings/storage), getSizeStat()
should simplly return |actual available size|.

BUG=640504
TEST=manually compared the avaiable space in Files app and Storage manager.

Review-Url: https://codereview.chromium.org/2274003004
Cr-Commit-Position: refs/heads/master@{#414371}

Add a caution to LeakExpectations and mention that memory leaks must be fixed asap.

BUG=

Review-Url: https://codereview.chromium.org/2277663004
Cr-Commit-Position: refs/heads/master@{#414370}

This CL implements a loading view (aka progress bar) in download manager
UI on Android. It is slightly trickier to handle state changes on
Tablets, because when the download ui is initialized, a filter is
already set in the URL. Therefore we cache the filter temporarily in the
manager, and will show it after we load everything.

There are three possible types of backend the UI needs to wait:
incognito downloads, downloads and offline apges. The UI will only claim
it is loaded if all of them are loaed.

TODO(ianwen): add a timeout mechanisim to either the
DownloadLoadingDelegate or to the backend so that if it takes forever to
load one of the backend, users are still able to see the other two.

BUG=616324

Review-Url: https://codereview.chromium.org/2269353004
Cr-Commit-Position: refs/heads/master@{#414369}

When official builds switched from gyp to gn some smoothness tests
regressed. Investigation showed that some skia functions were taking
up to 15x longer to execute. This was due to /GL /O2 being changed to
/O1 (LTCG and optimize-for-speed changing to optimize-for-size). This
change resolves most of the compiler option differences in skia and
dramatically reduces the CPU usage in the gn build, from 9.4 s to 5.3,
within spitting distance of the gyp build.

This increases the size of chrome_child.dll from 48,593,408 to
49,213,440 bytes. The gyp version is 49,032,192 bytes and if necessary
some more size optimizations can be applied to the gn build.

The discrepancy between gyp and gn optimization settings in skia occurred
when crrev.com/1410883008 landed for gyp only.

There may be other differences - investigation continues - but this fixes
the main issues noticed.

BUG=632651

Review-Url: https://codereview.chromium.org/2270693006
Cr-Commit-Position: refs/heads/master@{#414368}

Each WebUSB function (on the USB and USBDevice IDL objects) is given a
histogram value that is recorded when the function is called.

BUG=492204

Review-Url: https://codereview.chromium.org/2272563003
Cr-Commit-Position: refs/heads/master@{#414367}

Push updating of the animation value into SVGElement. This resembles the
Web Animations code-path to some degree and maybe we can make them even
more similar eventually. This is the first CL in a series that will
remove knowledge of <use>/shadow trees from the SMIL animation code.

BUG=640676

Review-Url: https://codereview.chromium.org/2272033002
Cr-Commit-Position: refs/heads/master@{#414366}

This is similar to earlier https://codereview.chromium.org/2163223002

BUG=584079
R=emso@chromium.org

Review URL: https://codereview.chromium.org/2278873002 .

Cr-Commit-Position: refs/heads/master@{#414365}

This will ensure we don't run into missing dependencies.

BUG=584079
R=emso@chromium.org

Review URL: https://codereview.chromium.org/2278893002 .

Cr-Commit-Position: refs/heads/master@{#414364}

I had to add them in https://codereview.chromium.org/2052613003

BUG=616502

Review-Url: https://codereview.chromium.org/2276863002
Cr-Commit-Position: refs/heads/master@{#414363}

On Mac all the rendering from the same renderer to the same device runs on the same buffer size which is a minimum of all the requested buffer sizes. FIFO is injected in case that buffer size does not match the one requested by the audio stream. Here we add tracing of the buffer mismatch.
Looks like it's a long enough explanation of 0.5 LOC change :)

TBR=dalecurtis@chromium.org

Review-Url: https://codereview.chromium.org/2278483002
Cr-Commit-Position: refs/heads/master@{#414362}

This patch converts "editing/insert-3778059-fix.html" to use w3c test
harness to simplify test script and renames to "insert_between_block_quote.html"
to provide to provide a hint what this test script verifies, for improving
readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2280533003
Cr-Commit-Position: refs/heads/master@{#414361}

These tests are currently disabled by TestExpectation
for failing, but will be enabled again in the following CLs.

BUG=594918

Review-Url: https://codereview.chromium.org/2279693002
Cr-Commit-Position: refs/heads/master@{#414360}

This patch converts "editing/before-after-input-element.html" to use w3c test
harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2275223002
Cr-Commit-Position: refs/heads/master@{#414359}

After https://codereview.chromium.org/2251073002 we should no longer
need to walk any <use> instances "manually", since setNeedsStyleRecalc
does that already. This should also avoid the potential double-work
because of this.

TEST=svg/W3C-SVG-1.1/animate-elem-30-t.svg
TEST=svg/W3C-SVG-1.1/animate-elem-40-t.svg

BUG=166438,355359,484552,637310

Review-Url: https://codereview.chromium.org/2270363004
Cr-Commit-Position: refs/heads/master@{#414358}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/bb0e6881e53477341891c9e3abe91e0abfbec937 Add comma to prevent unintended string concatenation (tikuta@chromium.org)
  https://crrev.com/eac0c99f5e54e20af75ce3277a42f2c31c614338 Make all the rest of the recipes explicitly specify GIT_MODE (agable@chromium.org)
  https://crrev.com/245c516049e221f79dc8cf8fe395138b782308a0 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/4b21db06e48e90335a0a1ae5d5b911b960ea0e5a Default gclient's GIT_MODE to True (agable@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=640251

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2272333002
Cr-Commit-Position: refs/heads/master@{#414357}

By moving the url_formatter methods out of
org.chromium.chrome.browser.UrlUtilities to it's component, other emdedders than
Chrome can benefit from the Java version.

This CL removes the tests originally written for a Java implementation of the
methods replaced by FormatUrlForSecurityDisplay in
https://codereview.chromium.org/1357563002. It's not trivial to move the tests
over to the component as they depend on native library initialization performed
by //content which is disallowed in components/url_formatter/DEPS. Also, the
tests are redundant as the code is thoroughly tested by other means.

Currently there are no users of formatUrlForDisplay() in Chromium, but Opera
would like it exposed.

BUG=624407

Review-Url: https://codereview.chromium.org/2110543004
Cr-Commit-Position: refs/heads/master@{#414356}

The pickle protocol uses __dict__ if __getstate__ and __setstate__
aren't defined. Using __dict__ is enough for IdlArgument.

BUG=569301

Review-Url: https://codereview.chromium.org/2272283002
Cr-Commit-Position: refs/heads/master@{#414355}

BUG=640628
TBR=pthatcher@chromium.org

Review-Url: https://codereview.chromium.org/2274173002
Cr-Commit-Position: refs/heads/master@{#414354}

https://codereview.chromium.org/2110993003 implemented the filtering for empty usernames.

BUG=400674

Review-Url: https://codereview.chromium.org/2277793002
Cr-Commit-Position: refs/heads/master@{#414353}

BUG=624086,640876
TBR=brucedawson@chromium.org

Review-Url: https://codereview.chromium.org/2278843002
Cr-Commit-Position: refs/heads/master@{#414352}

Revert of Add ARC++ specific fields to launch data for specific apps. (patchset #7 id:120001 of https://codereview.chromium.org/2272813003/ )

Reason for revert:
This broke compilation of ChromeOS:

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/22483

Original issue's description:
> Add ARC++ specific fields to launch data for specific apps.
>
> On devices that have ARC++ available or enabled, certain internal apps need
> to be able to get this information. Currently these are limited to the
> GetHelp and the demo app.
>
> These are fields we'd like to eventually just expose to all apps but currently
> security is not comfortable with that yet, so for now, we'll set these flags
> only for the apps that currently need it.
>
> Reviews requested,
> xiyuan@ - General review.
> asargent@ - //apps and extension parts
> lhchavez@ - ARC++ parts
> sky@ - //chrome/browser/ui
>
> R=asargent@chromium.org, lhchavez@chromium.org, sky@chromium.org, xiyuan@chromium.org
> BUG=640330
>
> Committed: https://crrev.com/3d97de469a486debcb8956de8f7ed679fa862cbf
> Cr-Commit-Position: refs/heads/master@{#414348}

TBR=asargent@chromium.org,lhchavez@chromium.org,sky@chromium.org,xiyuan@chromium.org,rkc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=640330

Review-Url: https://codereview.chromium.org/2276293002
Cr-Commit-Position: refs/heads/master@{#414351}

On https://codereview.chromium.org/2256653002/ it was implemented last fix to UI of change passowrd forms on Android. Since it seems no other significant problems are present from launching change password support on Android, this CL turns on change password support by default, without flag. The flag is not removed yet, just in case, if some problems will be found. It's going to be quite big CL for removing a flag and cleaning all places which depend on it, it will be done in a month, when it will be clear that everything is ok.

BUG=564674

Review-Url: https://codereview.chromium.org/2274913002
Cr-Commit-Position: refs/heads/master@{#414350}

A callsite with NotDispatchSelectEvent is updated so that it calls the
four-argument version of setSelectedRange().

This CL has no behavior changes.

BUG=640861

Review-Url: https://codereview.chromium.org/2274413003
Cr-Commit-Position: refs/heads/master@{#414349}

On devices that have ARC++ available or enabled, certain internal apps need
to be able to get this information. Currently these are limited to the
GetHelp and the demo app.

These are fields we'd like to eventually just expose to all apps but currently
security is not comfortable with that yet, so for now, we'll set these flags
only for the apps that currently need it.

Reviews requested,
xiyuan@ - General review.
asargent@ - //apps and extension parts
lhchavez@ - ARC++ parts
sky@ - //chrome/browser/ui

R=asargent@chromium.org, lhchavez@chromium.org, sky@chromium.org, xiyuan@chromium.org
BUG=640330

Review-Url: https://codereview.chromium.org/2272813003
Cr-Commit-Position: refs/heads/master@{#414348}

BUG=

Review-Url: https://codereview.chromium.org/2140103002
Cr-Commit-Position: refs/heads/master@{#414347}

This patch converts "editing/deleting/delete-all-text-in-text-field-assertion.html"
to use w3c test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2276563005
Cr-Commit-Position: refs/heads/master@{#414346}

This patch converts "editing/deleting/delete-at-paragraph-boundaries-008.html"
to use w3c test harness to simplify test script and consolidates into
"delete_at_paragraph_boundaries.html", since there are similar test cases,
for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2280473004
Cr-Commit-Position: refs/heads/master@{#414345}

A constructor of PassRefPtr makes a reference be convertible to PassRefPtr,
which is not make sense and is not used.

Review-Url: https://codereview.chromium.org/2272133003
Cr-Commit-Position: refs/heads/master@{#414344}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2255123002
Cr-Commit-Position: refs/heads/master@{#414343}

Disables the SGI_video_sync extension and assumes a
vsync interval of 59.9Hz on Linux.

Also adds an --enable-sgi-video-sync command line flag to
re-enable the extension.

Use of the extension on a thread other than the main GPU
thread is encountering issues with Chrome's sandbox for
certain combinations of Linux window managers and NVIDIA
drivers.

Before this patch, we were assuming a frequency of 60Hz
on Linux and re-aligning the phase every 5 seconds.
Since we can no longer align the phase, we assume a
frequency of 59.9 Hz. On a 60Hz monitor, this avoids
driver backpressure on the GPU thread at the cost of
skipping a frame every 10 seconds.

BUG=636644

Review-Url: https://codereview.chromium.org/2277883003
Cr-Commit-Position: refs/heads/master@{#414342}

BUG=551728
TEST=For all tests below, first open DevTools to the Security panel overview.

1) Visit google.com and check that there is a green bullet point with
   the following summary and description:
  - Secure Connection
  - The connection to this site is encrypted and authenticated using a strong protocol (QUIC), a strong key exchange (ECDHE_RSA), and a strong cipher (AES_128_GCM).

2) Visit cbc.badssl.com and check that there is a gray info bullet
   point with the following summary and description:
  - Obsolete Connection Settings
  - The connection to this site uses a strong protocol (TLS 1.2), a strong key exchange (ECDHE_RSA), and an obsolete cipher (AES_256_CBC with HMAC-SHA1).

3) Visit cbc.badssl.com/mixed/script/ and check that there are two gray
   info bullet points: "Obsolete TLS cipher suite" and
   "Blocked mixed content".

4) Visit static-rsa.badssl.com and check that there is a gray info bullet point
   with the following summary and description:
  - Obsolete Connection Settings
  - The connection to this site uses a strong protocol (TLS 1.2), an obsolete key exchange (RSA), and a strong cipher (AES_256_GCM).

5) Visit https://tls-v1-0.badssl.com:1010/ and check that there is a gray info
   bullet point with the following summary and description:
  - Obsolete Connection Settings
  - The connection to this site uses an obsolete protocol (TLS 1.0), a strong key exchange (ECDHE_RSA), and an obsolete cipher (AES_128_CBC with HMAC-SHA1).

Review-Url: https://codereview.chromium.org/1727133002
Cr-Commit-Position: refs/heads/master@{#414341}