GitLab

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/700623003

Cr-Commit-Position: refs/heads/master@{#302594}

By this support, My Maps maps shown in Drive folder have correct icon, file-type description, and file extension.

BUG=397029
TEST=Manually create a form in drive.google.com and see it appears with an icon in Files.app.

Review URL: https://codereview.chromium.org/693843002

Cr-Commit-Position: refs/heads/master@{#302593}

...to match the one in the user manager (https://codereview.chromium.org/698433003/).

NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/688323004

Cr-Commit-Position: refs/heads/master@{#302592}

BUG=267281
TEST=None

Review URL: https://codereview.chromium.org/695883002

Cr-Commit-Position: refs/heads/master@{#302591}

Revert of Add --root-layer-scrolls. (patchset #2 id:20001 of https://codereview.chromium.org/662973003/)

Reason for revert:
This CL causes build failure:
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Builder%20%28dbg%29&number=54070

The error log is:
FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ (snip) -o interactive_ui_tests (snip)
obj/chrome/libbrowser_chromeos.a(obj/chrome/browser/chromeos/login/browser_chromeos.chrome_restart_request.o):../../chrome/browser/chromeos/login/chrome_restart_request.cc:chromeos::(anonymous namespace)::DeriveCommandLine(GURL const&, base::CommandLine const&, base::DictionaryValue const&, base::CommandLine*)::kForwardSwitches:error: undefined reference to 'switches::kRootLayerScrolls'
clang:error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

Original issue's description:
> Add --root-layer-scrolls.
>
> BUG=417782
>
> Committed: https://crrev.com/2eeec6853a1579d09754acfa9961e4dc36aa9264
> Cr-Commit-Position: refs/heads/master@{#302588}

TBR=vollick@chromium.org,jam@chromium.org,skobes@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=417782

Review URL: https://codereview.chromium.org/695613005

Cr-Commit-Position: refs/heads/master@{#302590}

This provides a default WM_ROLE property for "bubble" windows in a similar
manner to how "popup" windows do.

BUG=427430

Review URL: https://codereview.chromium.org/693113002

Cr-Commit-Position: refs/heads/master@{#302589}

BUG=417782

Review URL: https://codereview.chromium.org/662973003

Cr-Commit-Position: refs/heads/master@{#302588}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/7c11aad..2f5cb2f

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/701703003

Cr-Commit-Position: refs/heads/master@{#302587}

Cr-Commit-Position: refs/heads/master@{#302586}

Minimized background (the black layer) is still "visible" in
views point of view even though its layer opacity is 0.0f, and
it intercepts mouse/touch events over the actual visible views.

It needs to SetVisible(false) when it's not used.

BUG=428442
R=yoshiki@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/693103002

Cr-Commit-Position: refs/heads/master@{#302585}

This change allows apps to remember the app state when handling onSuspend event.

Add a new method ProcessManager::ReleaseLazyKeepaliveCountForView to decrement the lazy keepalive count without killing AppWindow.
Rename ProcessManager::IncrementLazyKeepaliveCountForView to AcquireLazyKeepaliveCountForView.
Close remaining views in CloseLazyBackgroundPageNow().

Before this change, things happen in this order:
 1. All AppWindows are destroyed
 2. Keepalive count becomes 0
 3. chrome.runtime.onSuspend is invoked
 4. The background page is unloaded.

After this change:
 1. All AppWindows have released keepalive. (by explicitly releasing it or being destroyed)
 2. Keepalive count becomes 0
 3. chrome.runtime.onSuspend is invoked
 4. Remaining AppWindows are destroyed
 5. The background page is unloaded.

BUG=416999

Review URL: https://codereview.chromium.org/689833005

Cr-Commit-Position: refs/heads/master@{#302584}

BUG=none
TEST=not needed

Review URL: https://codereview.chromium.org/695443007

Cr-Commit-Position: refs/heads/master@{#302583}

The CL seems to break NetInternalsTest.netInternalsSdchViewBlacklistNonSdch in browser_tests.
Its error log is available here:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/15797/
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/15797/steps/browser_tests/logs/netInternalsSdchViewBlacklistNonSdch

This reverts commit fe89e5a5.
https://codereview.chromium.org/423813002/

BUG=
TBR=mmenke, rdsmith, jwd, baranovich,
NOTRY=True

Review URL: https://codereview.chromium.org/704493002

Cr-Commit-Position: refs/heads/master@{#302582}

This patch adds a 'clobber' command to cr which deletes all files
in the current output directory (except for the cr config file).

BUG=

Review URL: https://codereview.chromium.org/703533003

Cr-Commit-Position: refs/heads/master@{#302581}

Revert of Use a stub implementation of GlobalShortcutListener for Athena (patchset #3 id:100001 of https://codereview.chromium.org/697803002/)

Reason for revert:
This CL breaks GN build on ChromeOS:
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20GN&number=187

The error message was:
ERROR at //chrome/browser/extensions/BUILD.gn:189:7: Item not found
      "global_shortcut_listener_x11.cc",
      ^--------------------------------
You were trying to remove "global_shortcut_listener_x11.cc"
from the list but it wasn't there.

Original issue's description:
> Use a stub implementation of GlobalShortcutListener for Athena
>
> BUG=426561
> TEST=None
>
> Committed: https://crrev.com/3064611cafd0464e4899dfdf7f485efe71f3ef57
> Cr-Commit-Position: refs/heads/master@{#302578}

TBR=oshima@chromium.org,asargent@chromium.org,pkotwicz@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=426561

Review URL: https://codereview.chromium.org/697343002

Cr-Commit-Position: refs/heads/master@{#302580}

This CL fixes the animation of folders opening in the app list. This
regressed in r301308 because the ContentsView layer moved, exposing
a latent issue with the calculation of the top icon animation target.

The fix here is to use the view bounds as the target rather than the
layer bounds. The layer bounds are in the coordinate system of the
parent layer which is not what we want.

BUG=429079

Review URL: https://codereview.chromium.org/694743002

Cr-Commit-Position: refs/heads/master@{#302579}

BUG=426561
TEST=None

Review URL: https://codereview.chromium.org/697803002

Cr-Commit-Position: refs/heads/master@{#302578}

When we hit the 30s timeout, we would continue to run the test, then report a success, then attempt to dump the stdio and stacktrace.

Instead re-raise the exception and remove the finally block to stop the test from going through its paces

BUG=424024

Review URL: https://codereview.chromium.org/694893004

Cr-Commit-Position: refs/heads/master@{#302577}

TBR=gcasto@chromium.org
BUG=none
TEST=green closure bots
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/703583002

Cr-Commit-Position: refs/heads/master@{#302576}

Revert of Switch telemetry over to use typ to run the unit tests. (patchset #9 id:170001 of https://codereview.chromium.org/659293003/)

Reason for revert:
This CL causes telemetry_perf_unittests failure:
http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests&number=15802
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tests%20%28dbg%29%281%29&number=54625

Its stack trace was:
Traceback (most recent call last):
  <module> at tools/telemetry/telemetry/unittest/run_tests.py:179
    RunTestsCommand.main()
  main at tools/telemetry/telemetry/unittest/run_tests.py:85
    return obj.Run(options)
  Run at tools/telemetry/telemetry/unittest/run_tests.py:126
    ret, _, _ = runner.run()
  run at third_party/typ/typ/runner.py:187
    upload_ret = self._upload(full_results)
  _upload at third_party/typ/typ/runner.py:599
    full_results)
  make_upload_request at third_party/typ/typ/json_results.py:113
    content_type, data = _encode_multipart_form_data(attrs, full_results)
  _encode_multipart_form_data at third_party/typ/typ/json_results.py:183
    body = CRLF.join(lines)
TypeError: sequence item 3: expected string, NoneType found

Original issue's description:
> Switch telemetry over to use typ to run the unit tests.
>
> Using typ allows us to run the tests in parallel and share
> the logic for parsing the results and uploading them to the
> flakiness dashboard with other python test steps.
>
> R=dtu@chromium.org, tonyg@chromium.org, nduca@chromium.org
> BUG=402172, 388256
>
> Committed: https://crrev.com/3e7c2a6ee80e05fc6b8090bee850c40b8a2a3810
> Cr-Commit-Position: refs/heads/master@{#302570}

TBR=dtu@chromium.org,tonyg@chromium.org,nduca@chromium.org,achuith@chromium.org,dpranke@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=402172, 388256

Review URL: https://codereview.chromium.org/700703003

Cr-Commit-Position: refs/heads/master@{#302575}

Notable implementation details of the change:
. Have ActivityManagerImpl observer each aura::Window of the activities, and
  update order of the activities when their windows are restacked.
. Introduce ActivityManagerObserver::OnActivityOrderChanged().
. Remove the code from ResourceManagerImpl that tracks the activity order, and
  replace it to get the list from ActivityManager instead.
  - Make sure the code traverses the activities in the correct order.

BUG=413928
R=oshima@chromium.org, skuhne@chromium.org

Review URL: https://codereview.chromium.org/694353004

Cr-Commit-Position: refs/heads/master@{#302574}

BUG=
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/687723006

Cr-Commit-Position: refs/heads/master@{#302573}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fca5a7c..dcb6aa9

TBR=vsevik@chromium.org
BUG=

Review URL: https://codereview.chromium.org/696123007

Cr-Commit-Position: refs/heads/master@{#302572}

Tiny refactor of QuicSentPacketManager::NetworkChangeVisitor's
OnCongestionWindowChange() method to take no arguments, and require the
caller to fetch the updated congestion window.

Slightly simplifies the code. In preparation for the larger
GetCongestionWindowInPackets() cleanup.

Merge internal change: 78883300
https://codereview.chromium.org/694383002/

Change the number of emulated connections in QUIC's congestion control
as the number of open streams changes when the NCON connection option is
supplied.

Merge internal change: 78876869
https://codereview.chromium.org/682293004/

Merge changes to keep chromium source tree same as internal source tree.

Merge internal change: 78853598
https://codereview.chromium.org/693253002/

QUIC: Only send a new SCUP if enough packets have been sent since the
last SCUP.

Merge internal change: 78841268
https://codereview.chromium.org/699433002/

Fixes reduction for n-connection emulation in TCP Reno.

Merge internal change: 78812645
https://codereview.chromium.org/680253005/

Delay a QUIC server's use of the FORWARD_SECURE encrypter until the
client has had a chance to start using it.

Protected by FLAGS_enable_quic_delay_forward_security.

When the forward secure encrypter is available, don't use it until one
of two things happens:
1) the peers starts sending forward secure encrypted packets
2) 2 round trips worth of packets have been sent, in case something
   (MitM?) is preventing the peer from using forward secure encryption.

Merge internal change: 78801773

Set FLAGS_enable_quic_delay_forward_security to true in chromium.

https://codereview.chromium.org/698703003/

Change QUIC's Reno congestion controller to use a higher beta. Fixed
tests to be independent of beta.

Merge internal change: 78728349
https://codereview.chromium.org/698713002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/694393002

Cr-Commit-Position: refs/heads/master@{#302571}

Using typ allows us to run the tests in parallel and share
the logic for parsing the results and uploading them to the
flakiness dashboard with other python test steps.

R=dtu@chromium.org, tonyg@chromium.org, nduca@chromium.org
BUG=402172, 388256

Review URL: https://codereview.chromium.org/659293003

Cr-Commit-Position: refs/heads/master@{#302570}

They don't seem to work there now that they use mojo. See referenced bug
for details.

TBR=zhaoqin@chromium.org
BUG=372452
NOTRY=true

Review URL: https://codereview.chromium.org/698913003

Cr-Commit-Position: refs/heads/master@{#302569}

These were disabled on Mac, but are flaking everywhere.

TBR=mmenke
BUG=130404
NOTRY=true

Review URL: https://codereview.chromium.org/698003007

Cr-Commit-Position: refs/heads/master@{#302568}

BUG=406404

Review URL: https://codereview.chromium.org/686013002

Cr-Commit-Position: refs/heads/master@{#302567}

Fixed bug on Ubuntu Linux where the AppInfoDialog was outliving the
ExtensionSettingsHandler, causing Chrome to crash when the browser
window was closed while the dialog was open. This used to only happen
on Mac (where the dialog is disabled), but now happens on Linux Unity
due to Unity's always-accessible close/minimise/maximise toolbar.

TEST=Make Chrome fullscreen on Ubuntu with Unity enabled, then navigate
to chrome://extensions, click Details next to an app, and close Chrome
by clicking the X in Unity's fullscreen toolbar (not in Chrome). Chrome
should close gracefully and not crash.
BUG=427506

Review URL: https://codereview.chromium.org/683763003

Cr-Commit-Position: refs/heads/master@{#302566}

Added startPairing with pairing method parameter.
Changed some naming in gcd_private.idl
Changed PrivetV3Session from delegates to Callback. This makes code smaller and more readable.

Review URL: https://codereview.chromium.org/695253002

Cr-Commit-Position: refs/heads/master@{#302565}

While deflaking some SimpleIndex tests, it became clear we needed a
variation net::TestCompletionCallback that worked work base::Closure
rather than a net::CompletionCallback.

R=jkarlin@chromium.org
BUG=255775

Review URL: https://codereview.chromium.org/699693002

Cr-Commit-Position: refs/heads/master@{#302564}

Revert of Make extensions that desire to act pop out if in overflow (patchset #6 id:200001 of https://codereview.chromium.org/675023002/)

Reason for revert:
Suspect this patch of causing errors on linux valgrind for LocationBarControllerUnitTest.NavigationClearsState.

http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%285%29/builds/31337

Sample valgrind output:
Suppression (error hash=#606630BA25518095#):
For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports
{
<insert_a_suppression_name_here>
Memcheck:Unaddressable
fun:_ZN16ExtensionService21NotifyExtensionLoadedEPKN10extensions9ExtensionE
fun:_ZN16ExtensionService12AddExtensionEPKN10extensions9ExtensionE
fun:_ZN10extensions12_GLOBAL__N_129LocationBarControllerUnitTest12AddExtensionEbRKSs
fun:_ZN10extensions12_GLOBAL__N_156LocationBarControllerUnitTest_NavigationClearsState_Test8TestBodyEv
}

Original issue's description:
> Make extensions that desire to act pop out if in overflow
>
> If an extension desires to act, it should pop itself out of
> the overflow menu.  There should also be a visual queue for
> extensions that are already visible, but what exactly that
> should be is still being discussed.
>
> BUG=417441
>
> Committed: https://crrev.com/d604171517135387ca3b4c33d7f1774c8d2d38b0
> Cr-Commit-Position: refs/heads/master@{#302511}

TBR=finnur@chromium.org,pkasting@chromium.org,rdevlin.cronin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=417441

Review URL: https://codereview.chromium.org/700453003

Cr-Commit-Position: refs/heads/master@{#302563}

Before this change, the data reduction proxies were added to the
list of acceptable proxies for a URL, if the effective proxy
configuration resolved to direct for it. This change further checks
that the effective configuration is not the data reduction proxy's.

BUG=425826

Review URL: https://codereview.chromium.org/653313003

Cr-Commit-Position: refs/heads/master@{#302562}

This code conditionally stashes a sync point for buffer types that require it for the destruction phase.

BUG=416873

Review URL: https://codereview.chromium.org/654223006

Cr-Commit-Position: refs/heads/master@{#302561}

A static code analyzer reports an error in usb_midi_output_stream.cc, which
is a message_size_table buffer overflow. This CL fixes the code.
Note that the reported error never happens and hence the fix doesn't change
the behavior.

BUG=427616

Review URL: https://codereview.chromium.org/694733002

Cr-Commit-Position: refs/heads/master@{#302560}

BatteryStatusServiceTest.AddCallbackAfterUpdate
BatteryStatusServiceTest.RemoveOneCallback
BatteryStatusServiceTest.TwoCallbacksUpdate

These tests fail on DrMemory bots and locally on Windows.

NOTRY=true
TBR=timvolodine
BUG=429942

Review URL: https://codereview.chromium.org/699823002

Cr-Commit-Position: refs/heads/master@{#302559}

The AppCacheUpdateJob::URLFetcher cancels redirects in general.
This change allows redirects that are generated by the data
reduction proxy bypass mechanism. This is a workaround until
crbug.com/429505 is resolved.

BUG=429011

Review URL: https://codereview.chromium.org/695193002

Cr-Commit-Position: refs/heads/master@{#302558}

We are going to use this property from the JS side to know whether a task is generated from generic file handler or not.
Generic file handler is a file handler which can handle any type of file.

e.g.
These are generic handlers.
"types": ["*/*"]
"types": ["*"]
"types": ["*/*", "image/jpeg"]
"extensions": ["*"]
"extensions": ["*", "jpg"]

These are not generic handlers.
"types": ["image/jpeg"]
"types": ["image/*"]
"extensions": ["jpg"]
"extensions": ["jpg", "png"]

BUG=414566
TEST=out/Release/unit_tests --gtest_filter=FileManagerFileTasksTest.IsGenericFileHandler:FileManagerFileTasksComplexTest.FindFileHandlerTask_Generic

Review URL: https://codereview.chromium.org/686393002

Cr-Commit-Position: refs/heads/master@{#302557}

This fixes the call of device.PushChangedFiles; see example of correct usage here: https://code.google.com/p/chromium/codesearch#chromium/src/build/android/provision_devices.py&q=PushChangedFiles

This change should fix the breakage of the chrome-proxy tests that was
introduced in https://codereview.chromium.org/656383002/.

BUG=429313

Review URL: https://codereview.chromium.org/689213002

Cr-Commit-Position: refs/heads/master@{#302556}

Review URL: https://codereview.chromium.org/703433003

Cr-Commit-Position: refs/heads/master@{#302555}