GitLab

Review URL: http://codereview.chromium.org/334027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30055 0039d316-1c4b-4281-b951-d872f2087c98

when they belong to a doomed entry.

BUG=25588
TEST=unittests

Review URL: http://codereview.chromium.org/335015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30054 0039d316-1c4b-4281-b951-d872f2087c98

BUG=9787
TEST=green

Review URL: http://codereview.chromium.org/334015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30053 0039d316-1c4b-4281-b951-d872f2087c98

Also moves the guts of WebFrameImpl::GetWebViewImpl to WebViewImpl's
FromPage method since it involves dipping into ChromeClientImpl.

R=dglazkov
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/339001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30052 0039d316-1c4b-4281-b951-d872f2087c98

The test timed out on one of the bots last time.  This change tries to fix that, and it breaks down the test into multiple tests to isolate the problem in case it isn't fixed.

No changes to code outside the test and the test HTML file.  Previous review at http://codereview.chromium.org/284015.

BUG=24447
TEST=RenderViewHostManagerTest.*SwapProcess*

Review URL: http://codereview.chromium.org/328017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30050 0039d316-1c4b-4281-b951-d872f2087c98

mouse moves over another folder, the menu for that folder is shown.

BUG=355
TEST=thorougly test all possible permutations of bookmark menus you
     can think of, including drag and drop to the menus.

Review URL: http://codereview.chromium.org/328012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30049 0039d316-1c4b-4281-b951-d872f2087c98

When middle-clicking a tab to close it, one should be able to move the mouse off
the tab before releasing to cancel it.

BUG=16019
TEST=Get a 3-button mouse. Make sure middle-clicking tabs to close them still works. Make sure moving the mouse off the tab before releasing the button cancels.

Review URL: http://codereview.chromium.org/333021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30048 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30046 0039d316-1c4b-4281-b951-d872f2087c98

Fixes cmd-c, cmd-v, cmd-x, cmd-a.

The menu blinking is worth the extra IPC hop.

BUG=25254
TEST=Select text, hit cmd-c. "Edit" menu should blink. Hit cmd-v. "Edit" menu should blink again, correct text should be pasted.

Review URL: http://codereview.chromium.org/330014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30045 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25346
Review URL: http://codereview.chromium.org/335026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30044 0039d316-1c4b-4281-b951-d872f2087c98

ThreadSanitizer hang.
Usually, if several tests hang in the same way, that means there's some common code between them that makes TSAN's address space manager unhappy.
Then it's likely that a new test from the same test case exploits the same code and breaks ThreadSanitizer again.
BUG=http://code.google.com/p/data-race-test/issues/detail?id=11
TBR=dank
Review URL: http://codereview.chromium.org/335024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30043 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dank
Review URL: http://codereview.chromium.org/332025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30042 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/v8/issues/detail?id=483
TEST=none
Review URL: http://codereview.chromium.org/329008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30041 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30040 0039d316-1c4b-4281-b951-d872f2087c98

fast/text/basic/006-expected.txt for Linux because r30038 modified
expected results for Windows.

TBR=yutak
BUG=21859
TEST=none
Review URL: http://codereview.chromium.org/334024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30039 0039d316-1c4b-4281-b951-d872f2087c98

* LayoutTests/fast/forms/search-styled.html
  TEXTMETRIC::tmAveCharWidth for `Verdana' font returns different
  results in Windows XP and Vista, and the size of a text form field
  depends on it.

* LayoutTests/fast/text/whitespace/026.html and basic/006.html
  These tests use U+00B7.  The width of U+00B7 in `Times New Roman'
  font is 3 pixels in Windows XP, and 5 pixels in Windows Vista.

BUG=21859
TEST=none
Review URL: http://codereview.chromium.org/327012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30038 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25754
TEST=Check placement of (window modal) sheets (e.g., Open File...) with various combinations of the following: NTP/non-NTP, bookmark bar active/not active, infobar present/not present, and also download bar present/not present.

Review URL: http://codereview.chromium.org/337019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30037 0039d316-1c4b-4281-b951-d872f2087c98

If we reset delegate_ in OnClose, some pending tasks for DoOnReceivedData
would fail to notify received data to the delegate.

Don't reset delegate_ and socket_ in OnClose. Do it in DoOnClose instead.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/326010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30036 0039d316-1c4b-4281-b951-d872f2087c98

This solution is clearly not as elegant, but it gets the job done, and it
eliminates the last remaining base/ reference from webframe_impl.cc!

R=dglazkov
BUG=24608
TEST=none

Review URL: http://codereview.chromium.org/335019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30035 0039d316-1c4b-4281-b951-d872f2087c98

If Read in DoReadWrite succeeded synchronously, it failed to call next Read.
Changed to call Read repeatedly after a Read finished both in synchronous return and asynchronous return.

Also fixes Write case as well.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/326009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30034 0039d316-1c4b-4281-b951-d872f2087c98

We hadn't set up our tracking area (in BaseView) to send mouse enter/exits.

BUG=22199
TEST=Get a page with lots of links which upon resizing can be made to abut the left edge (e.g., <http://www.nytimes.com/>), and resize/scroll to make it so; hover over a link to show status bubble; move mouse off the window, staying on the same link until off the window. The status bubble should then fade away.

Review URL: http://codereview.chromium.org/337016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30033 0039d316-1c4b-4281-b951-d872f2087c98

Walking the whole menu on every keypress seems ridiculous. Linux does this too :-/ (Caching is made hard because the user can change key equivalents in system preferences at every point in time, and we're not notified of that. And people only hit max 5 keys/second, so it's not all that ridiculous).

There's a UI test for this, but the interactive UI tests are not enabled on OS X, so it's not executed.

Menu walking code based on code from CocoatechCore.

BUG=5496,15090,24877
TEST=Go to http://unixpapa.com/js/testkey.html , check "keydown", focus the textbox, and make sure that cmd-t still opens tabs, cmd-shift-[ still switches tabs, cmd-w still closes tabs. however, cmd-L should not focus url bar and cmd-1 should not go to the first tab.

Review URL: http://codereview.chromium.org/273032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30032 0039d316-1c4b-4281-b951-d872f2087c98

This is necessary to limit the web socket handlers scan directories.
Without this, specifying third_party/WebKit/LayoutTest as the handler
root results in wasting several seconds in server startup.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/333024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30031 0039d316-1c4b-4281-b951-d872f2087c98

BUG=Needed for a CL that I'm writing for 15090.
TEST=Unittest included.

Review URL: http://codereview.chromium.org/319001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30030 0039d316-1c4b-4281-b951-d872f2087c98

TBR=pkasting
http://crbug.com/25784
TEST=open any popup window or app frame, should have title bar to drag window.

Review URL: http://codereview.chromium.org/328026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30029 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30028 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25542
TEST=none

Review URL: http://codereview.chromium.org/332016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30027 0039d316-1c4b-4281-b951-d872f2087c98

BUG:25748
Review URL: http://codereview.chromium.org/334021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30026 0039d316-1c4b-4281-b951-d872f2087c98

  LayoutTests/media/controls-drag-timebar.html = FAIL
  LayoutTests/svg/custom/js-update-transform-changes.svg = FAIL

BUG:9798
Review URL: http://codereview.chromium.org/335021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30025 0039d316-1c4b-4281-b951-d872f2087c98

BUG:9798 


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30023 0039d316-1c4b-4281-b951-d872f2087c98

on linux

BUG:9798

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30022 0039d316-1c4b-4281-b951-d872f2087c98

BUG:25746

Review URL: http://codereview.chromium.org/328024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30021 0039d316-1c4b-4281-b951-d872f2087c98

BUG:25747
Review URL: http://codereview.chromium.org/328023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30020 0039d316-1c4b-4281-b951-d872f2087c98

BUG: 25746
Review URL: http://codereview.chromium.org/330012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30019 0039d316-1c4b-4281-b951-d872f2087c98

BUG=21218
TEST=none

Review URL: http://codereview.chromium.org/235030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30018 0039d316-1c4b-4281-b951-d872f2087c98

This is a quick and easy 'mock' implementation of the storage interface
that doesn't put anything to disk.

We simply add an extra reference to objects when they're put in storage,
and remove the extra reference when they are removed from storage.
Responses are never really removed from the in-memory disk cache.
Delegate callbacks are made asyncly to appropiately mimic what will
happen with a real disk-backed storage impl that involves IO on a
background thread.

This is for use in unit tests and to initially bring up the appcache
related layout tests.

TEST=mock_appcache_storage_unittest.cc
BUG=none

Review URL: http://codereview.chromium.org/300043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30017 0039d316-1c4b-4281-b951-d872f2087c98

That is, holding Cmd while pressing back/forward will open in a new background tab and holding Cmd+Shift will open in a new foreground tab. Theoretically, it can support holding Shift to open in a new window, but Browser::GoBack()/GoForward() doesn't support this disposition (due to a technical "limitation" of the implementation?).

This does *not* implement dispositions in the drop-down menus.

BUG=25319
TEST=Navigate to build up some history. Then press back/forward while holding down Cmd or Cmd+Shift.

Review URL: http://codereview.chromium.org/330002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30016 0039d316-1c4b-4281-b951-d872f2087c98

NO CODE CHANGE.

TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30015 0039d316-1c4b-4281-b951-d872f2087c98

This seems to be needed for 64-bit.

BUG=None
TEST=None
TBR=gman

Review URL: http://codereview.chromium.org/328021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30013 0039d316-1c4b-4281-b951-d872f2087c98

BUG=TEST=phajdan

Review URL: http://codereview.chromium.org/333023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30012 0039d316-1c4b-4281-b951-d872f2087c98