- 12 Sep, 2019 26 commits
-
-
rbpotter authored
- Changing controller classes to not depend on PDFViewer - Add closure target for controller.js - Cleanup a TODO in the same file (make postMessage_ private). Bug: 721073,913279 Change-Id: Ib0bc3aaa733e8bcb394fdb15a1cca519d8d61dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796444Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#695862}
-
Kent Tamura authored
This CL reduces the estimated pre-processed size of feature_policy.h from 1.59MB to 0.39MB. This CL has no behavior changes. Change-Id: I73641669dbf53db5df37e0a9d0dcefb370979281 Bug: 1001360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792476Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#695861}
-
Kent Tamura authored
This CL reduces the estimated pre-processed size of resource_request.h from 4.13MB to 1.35MB. This CL has no behavior changes. Bug: 1001360 Change-Id: Iec39166d8763b165012b97c3cd51b0f0450daa93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797945Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#695860}
-
Martin Kreichgauer authored
This adds a set_win_webauthn_api() setter to FidoDiscoveryFactory which injects the WinWebAuthnApi to be used for instantiating the Discovery and Authenticator for the native Windows API integration. This enables cleaner injection of FakeWinWebAuthnApi instances in tests than the previous ScopedFakeWinWebAuthnApi override. By default, only the "real" FidoDiscoveryFactory instances returned by AuthenticatorRequestDelegate::GetDiscoveryFactory() hold a WinWebAuthnApi, whereas the virtual and testing overrides do not. This removes the necessity for explicitly disabling the Windows API integration in all unit tests, which is a nice simplification. ScopedFakeWinWebAuthnApi is made obsolete by this change and deleted. Bug: 984958 Change-Id: Id6319955b715784fc2a5ab59b74a1c6922a29ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789751 Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#695859}
-
Alexey Baskakov authored
1) Update WebAppSpecifics proto to be in sync with WebAppProto, launch_container field and enum added. 2) WebAppProto::app_id was a redundant value in the dictionary. app_id is a hash of launch url and it can be inferred from launch_url field. app_id is the client tag and the storage key. WebAppSyncBridge::GetClientTag and WebAppSyncBridge::GetStorageKey will be implemented to return GenerateAppIdFromURL(launch_url). Bug: 891172 Change-Id: If3abbb96d2bffb368ce37b3d47d0691c3bf11c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792425Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#695858}
-
Amy Huang authored
Disable the clang warning -Wsizeof-array-div with Wno-error to unbreak the build and see how many instances of the warning there are. TBR=thakis@ Bug: 1002945 Change-Id: I4539b6cc84bd3a2f1590a5a0ee09b03175942498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798890 Commit-Queue: Amy Huang <akhuang@google.com> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#695857}
-
Patrick To authored
The XR process initially sends back dummy values (1024) to the renderer for the display's width/height and later sends back the correct values on the first frame. However, in WebVR, most web pages do not look for the updated values after entering the rendering loop. As a result, WebVR pages present with a resolution of 1024 until the user exit presentation and then re-enters presentation without refreshing the page. In WebXR, Blink does not update the XRWebGLLayer's width/height when the XR process sends back the correct values, so presentation also occurs at 1024 until exiting and re-entering presentation. This change updates the display info in the XR process and initially sends back the correct value so that both WebVR and WebXR pages has the correct width/height when starting presentation. Bug: 1000897 Change-Id: I3491d43245bb53100212fd2d0ab38d8f1222e7c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785883Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Patrick To <patrto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#695856}
-
Stephen Martinis authored
Bug: 999206 Change-Id: I60ab32a236575c4d9b65361e487f73f840405fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776605Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#695855}
-
Khushal Sagar authored
R=fserb@chromium.org Bug: 900706 Change-Id: I0a8415d38be139ac894784b464d53b0dd447caf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797367 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#695854}
-
Rahul Singh authored
This CL adds support for text and background opacity on Win10 by computing the color string with an alpha value corresponding to the user's choice in Settings. In addition, it also adds support for window color (with opacity) now that CaptionStyle also contains a string for window_color. With this change, all caption styling properties that show up in Win10 Settings are now supported in Chromium on Win10. New Properties added: 1. Caption Text Opacity 2. Background Opacity 3. Window Color 4. Window Opacity Bug: 1001736 Change-Id: I3e80f88219faa7407bbd015074c486bc4d680e5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794002 Commit-Queue: Rahul Singh <rahsin@microsoft.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#695853}
-
Maggie Cai authored
Looks like there is a typo in the merge code for additional_search_terms, it is still checking for permissions. Non of the DCHECK condition sounds relevant for additional_search_terms, so removed the DCHECK. Bug: None Change-Id: I2d58a018f622b74583d7e11b3bb70e2b83084619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797526Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#695852}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 24ddb486. With Chromium commits locally applied on WPT: cf88186a "[LayoutNG] Fix `vertical-align: top` and `bottom`" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ibc3e34c38ea1b240cfc5f661fe076bcb0d10ec2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799104Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695851}
-
John Lee authored
This CL adds a default fallback of a favicon with an empty URL to display the default globe icon, and also sends the search engine URL as a fallback if the search engine favicon URL is not available. Bug: 1002840 Change-Id: Ie1662e5b3c0e95418abc9bb4bf9a5306f15668d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798982Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#695850}
-
Manu Cornet authored
The original plan was to potentially enable the denser shelf early, as a first step, but it looks like it will now be enabled with the rest of the shelf redesign. There is now no need for the extra complexity of a separate flag for the "densification". Bug: 973483, 973482 Change-Id: I65d491818cecba93962823eb93c7c62f749f779f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799385Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#695849}
-
Sajjad Mirza authored
Also deleted an unnecessary include of unistd.h. Bug: 990480 Change-Id: I5caa9a1dabcbb9e90bab1372bc38b8079c5a640e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797644Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#695848}
-
Aleks Totic authored
We were hitting DCHECK(HasSetAbsoluteColumnIndex()); when recalculating borders. Cells do not have AbsoluteColumnIndex set when section needs cell recalc. Fix is to make section recalc if needed before computing borders. I am not sure if this will have any performance implications... Clusterfuzz is quite elaborate. Several steps are involved in triggering the bug: - set needs_cell_recalc on section - without triggering layout on section, cause child to ask section's cell to compute its borders. Figuring a reduced test case would take about a day. Considering that I am working on eliminating this code completely, and that this bug has been around forever, I think no test case is ok. Bug: 999861 Change-Id: Ia1abcd23646fd534d740ece6d9cae52cf101829e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796570Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#695847}
-
Nicolas Boichat authored
Bug: 993147 Test: At login screen => only power button Test: As guest => power, sign out, feedback(NEW) Test: As user => power, sign out, lock, feedback Test: As user, screen locked => power, sign out Change-Id: I23bb4395d316846112c32e4c5cc398f6eefe5ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787025Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Nicolas Boichat <drinkcat@chromium.org> Cr-Commit-Position: refs/heads/master@{#695846}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f7cf794890d4..7c8c67ec803c git log f7cf794890d4..7c8c67ec803c --date=short --no-merges --format='%ad %ae %s' 2019-09-11 bsalomon@google.com Blacklist InitialTextureClear on TecnoSpark3Pro Created with: gclient setdep -r src/third_party/skia@7c8c67ec803c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: I33497b44a7ea0dc0fdd8098cdbce4a9a25642721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799426Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#695845}
-
rbpotter authored
- Autogenerate Polymer 3 cr-action-menu and test - Autogenerate modulized focus_row.js, since cr-action-menu depends on it - Add cr-action-menu to demo page - Script changes, required to allow cr-action-menu to export its enum Bug: 965770 Change-Id: Ie453b1f5f9ebe385143768cac1609ae1ae2f9de3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789759Reviewed-by:
-
Ryan Hansberry authored
Bring EasyUnlockServiceRegular above the 85% test coverage expectation. This CL also removes unnecessary methods which remained in EasyUnlockServiceRegular, correctly clears stored remote devices in prefs when Smart Lock is no longer enabled, and includes minor refactors necessary to make tests pass. Coverage before this CL: easy_unlock_service.cc: 14.72% (91/618) easy_unlock_service_regular.cc: 22.58% (98/434) Coverage as of this CL: easy_unlock_service.cc: 35.76% (221/618) easy_unlock_service_regular.cc: 91.96% (389/423) Report created with: $ python tools/code_coverage/coverage.py unit_tests \ -b out/coverage \ -o out/report \ -c 'out/coverage/unit_tests --gtest_filter=*EasyUnlockService*' \ -f chrome/browser/chromeos/login/easy_unlock/ Bug: 949209 Change-Id: I037776f197373ff94099d2f5fc38726d60165cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788552 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#695843}
-
Julie Jeongeun Kim authored
This CL converts SandboxSupportMacPtr and SandboxSupportMacRequest to new Mojo types. It uses PendingReceiver, ReceiverSet, and Remote instead of SandboxSupportMacRequest, BindingSet, and SandboxSupportMacPtr. Bug: 955171 Change-Id: I8d216a85939cba01c392bb821e189610d5e5b885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786708Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#695842}
-
Kenichi Ishibashi authored
This is a follow-up CL of crrev.com/c/1792028. The CL seemed to fix a crash but a better and proper fix is to delay adding WorkerThread to WorkerThreads() until the worker context is initialized. This way we can make sure WorkerScheduler is available for all workers in WorkerThreads(). To terminate initializing workers via TerminateAllWorkersForTesting() we need to keep initializing workers somewhere else. This CL adds a HashSet that keeps initializing workers. Bug: 1000077 Change-Id: I8410ebec0a8459a779105f6d65e2bde4f3b81f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792510 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#695841}
-
Scott Violet authored
webkit-box treats a min-size of auto as 0. This adds that logic to FlexLayoutAlgorithm. BUG=993813 TEST=fast/css/deprecated-flexbox-auto-min-size.html Change-Id: I80eb42616575891d4a99450f6d1fd515ba3c39a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799389Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#695840}
-
Xianzhu Wang authored
This reduces size of cc::Layer from 680 to 552 on LP64 systems. - Adjust order of fields to reduce gaps; - Remove snap_container_data. Change-Id: Id2fa92d5feae2cb819b25c400c8ed678a01558ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798987 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#695839}
-
Brandon Wylie authored
Bug: 1002011 Change-Id: Iafd7bfa4f6235575775dee44eeba9779bceda6a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798983Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#695838}
-
Jon Mann authored
This was used by Messages v1 to activate a long living service worker. Now that Messages v2 is completely rolled out, this code path is no longer used. Bug: 869714 Change-Id: I0b0d1dc234a8aec5e3d941cabb196103339a9e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797084Reviewed-by:
-
- 11 Sep, 2019 14 commits
-
-
John Budorick authored
Bug: 922145 Change-Id: I39af4eb6d2290335fdec268d9c9e1e0f7af66f70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795312Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#695836}
-
Danan S authored
This reverts commit 441c06d9. Reason for revert: Reland changes after disabling test for MSan builds. The root issue is a bug that causes a flaky initialization behavior in the <webview> element in MSan builds (https://crbug.com/1002560) Also, added a new unit test from tobyhuang@ that was dependent on the original reverted CL. Original change's description: > Revert "Automated tests for Add Supervision flow ChromeOS code" > > This reverts commit 9f7c76d0. > > Reason for revert: > AddSupervisionBrowserTest.ShowConfirmSignoutDialog > AddSupervisionBrowserTest.URLParameters > failing on Linux ChromiumOS MSan Tests, see > https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/15000 > > Original change's description: > > Automated tests for Add Supervision flow ChromeOS code > > > > This required modifying the classes under test, including > > AddSupervisionHandler, AddSupervisionUI, and ConfirmSignoutDialog > > to allow them to be tested. > > > > Bug:982543 > > > > Change-Id: I3bebada137fe57a63ca090c788fa5a0cb317d22b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771387 > > Commit-Queue: Danan S <danan@chromium.org> > > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#693320} > > TBR=michaelpg@chromium.org,danan@chromium.org > > Change-Id: Ibe6189ed52f32afb62cdfabbf890857e474de6ea > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 982543 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787417 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Auto-Submit: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693571} Change-Id: I4d2c19c229923a5bd1acb246f8e9d4d1b2ccb9af Bug: 982543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787613 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#695835}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /services/device/geolocation. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=mcasas@chromium.org Bug: 891670 Change-Id: Ibfbac7fc26104f23536ba42e07f38232bfd668ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787203 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#695834}
-
Matt Menke authored
This method name is confusing, since HttpServerProperties::SupportsSpdy() is used to store whether a server supports SPDY/H2, but SupportsQuic() actually means a network where QUIC works (i.e., the ISP isn't breaking QUIC, or something similar). This difference in meaning was also not documented anywhere. This CL renames "SupportsQuic" to "LastLocalAddressWhenQuicWorked", adds documentation, and reworks the API slightly - its behavior around empty IPAddresses was a little weird, as was passing in an IPAddress() and a bool when clearing information for all IP addresses. This CL also renames QuicFactory::requires_confirmation_ to is_quic_known_to_work_on_current_network_ (which also requires inverting its value) and adds some documentation for it, as it was similarly confusing. Bug: 969890 Change-Id: Id51b082343ff31ecd36f1bedfab8342307da26ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790325 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#695833}
-
Justin Donnelly authored
Change-Id: I1c9d81ae9f1440710b1409e1e05b89a53852e32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799622Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#695832}
-
rajendrant authored
This reverts commit 2760b9dd. Reason for revert: Causing some regression in perf tests Original change's description: > Bypass proxy for preflight request > > Since the OPTIONS preflight request is generated within the network > service, it will not reach the URL loader throttles in renderer that > handle the proxy specific code. > > Preflight requests apply predominantly to POST requests for which proxy > will not be used. So it makes sense to bypass proxy for preflight > requests too. > > Bug: 985673 > Change-Id: Iafa0db4ac0dcb29d7b38870fb4ea345f60da2212 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764748 > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Commit-Queue: rajendrant <rajendrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694025} TBR=rajendrant@chromium.org,cduvall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 985673, 1001610 TBR: cduvall@chroimum.org Change-Id: I5905b849e14867b467e5fc0af6cbfd24cd10201a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799391 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#695831}
-
Kent Tamura authored
This CL implements new autofocus algorithm in [1]. - Enqueue an autofocus element on InsertedInto(), not AttachLayoutTree() - Handle queued elements after rAF callbacks - Do not handle queued elements if a document has non-empty fragment or already-focused element. * Changes to the existing tests Focus timing becomes slightly later. Some test are updated to use focus(), and some other tests wait for two animation frames. [1] https://html.spec.whatwg.org/C/#the-autofocus-attribute Bug: 382901, 985636 Change-Id: I07b94771a53ddcf600aa3101cc1df1eceaf59356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699391Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#695830}
-
Koji Ishii authored
This patch fixes the |float| variation of |Font::TabWidth| not to return -NaN by adding the same guard as its |LayoutUnit| variation. Bug: 1002999 Change-Id: I4fc1fdb233b4156a425c92d97f7f9444be527d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798070Reviewed-by:
-
Peter Kotwicz authored
This CL adds a new UMA metric WebApk.Navigation.InScope which is recorded on every WebAPK navigation. It records whether WebAPK navigations are within the WebAPK's scope. BUG=999648 Change-Id: I0d8fc678f396e8fd55c48aabd41b8878ee8fdcd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788304 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#695828}
-
Nick Diego Yamane authored
Get rid of native event (i.e: XEvent) usage when translating ui::KeyEvent into GdkEvent in GtkUi GdkKeyBindingsHandler and InputMethod context implementation. Native event usage outside platform code is undesired and blocks changes such as Aura/X11 => Ozone/X11 migration (e.g: PlatformEvent migration crbug.com/965991). It is worth noting that aura IME code has been slightly modified to set root window as Event::target() during the PRE_DISPATCH phase (for some reason InputMethodContext::DispatchKeyEvent() is called at this phase) so that IME context implementation is then able to retrieve the X11 Window id, needed by GdkEvent system. To be able to retrieve XEvent group field in gtkui code, an Event::Property has been added and for now is set only for non-ozone X11. Ozone/X11 will be addressed in a follow-up CL. Rationale: https://docs.google.com/document/d/1Neh2p6f8pew9SPuEAtnJMafozAY7uhAIfhwd43CLETc/edit?usp=sharing Bug: 965991, 987939 Change-Id: I64929d6866c1dfcfddbfe75166a1bad139c2da8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789603 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#695827}
-
Khushal authored
R=kbr@chromium.org Bug: 998038 Change-Id: Ic31d28938ef205b36657fc7bd297fe8a63d08543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798052 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#695826}
-
Brian Sheedy authored
Makes test_env.py compatible with both Python 2 and 3. Also adds a very simple test to ensure that it remains compatible until some other test switches to Python 3. As a side effect of adding the test, also makes testing/scripts/common.py compatible with Python 3 since it's necessary for running isolated scripts. Bug: 898348 Change-Id: Ib58cf4c4f85df60a432764d7f744bc3fee09ae3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796525Reviewed-by:
-
Matt Menke authored
With the non-NetworkService path now removed, only the URLRequest::Delegate auth path is used. This CL leaves a supporting enum and callback in NetworkDelegate, which aren't used by NetworkDelegate, but are still used. I'll figure out where to move them in another CL. Bug: 934009 Change-Id: Icf5f8344ca0326c7ac0bbd72440ad602f65c3363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798886Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#695824}
-
Bo Liu authored
Copies ContentView from components and EventOffsetHandler from chrome. These together will call EventForwarder.setCurrentTouchEventOffsets at the right times to correctly offset user input under browser controls Change-Id: I29a418457c4daf2306e7ce13e8311a489b1ca958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796046Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#695823}
-
