GitLab

R=pkasting@chromium.org

Bug: 1028831
Change-Id: Icba29140de51382053d11766573e602677fb609e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950687
Auto-Submit: Stephen Lin <stephenlin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Stephen Lin <stephenlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721697}

Bug: 1030446
Change-Id: Id022b1d43b7359df768671fbb5562f53a8b21f0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947549
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721696}

- Modified ensureAppLaunchedWithFeaturesEnabled API in AppLaunchManager
  - Added flag |relaunchPolicy| to control manners during relaunching
    app.
- Added backgroundAndForegroundApp method to AppLaunchManager, which
  backgrounds the app and moves it back to foreground.
- Added tests in smoke_egtests.mm to test the newly added methods.
- Changed disabled tests in restore_egtest.mm to using the new API and
  enabled them.
- Changed other affected tests.

Bug: 1018482

Change-Id: Ia20026ca0999b2be3a31ab01f19e47196b4bd07e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935713
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721695}

When dragging a window from shelf, if the window should be taken to home
screen after the drag ends, use scale-in animation to show home screen.
If overview is active, then fade out overview windows.

Bug: 997885, 1026944
Change-Id: I11b92e152679fe32efc2fae0b30b71dcba4ccc74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949276
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721694}

Also reshard the nexus5x perf bot.
Note that this may cause false positive regressions because it
will move some benchmarks to run on different devices.
DO NOT REVERT THIS CL if it appears to cause a perf regression.

Rendering team tells me that nexus5x has a high degree of noise for them,
so they don't mind running fewer benchmarks on it and relying instead on
nexus5 and pixel2 bots.

R=johnchen@chromium.org, sadrul@chromium.org

Bug: 1030788, 1030840
Change-Id: If7a7f2cd847989b4fddd24bc6fa56b5379795d1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951333
Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721693}

This makes finding the inverse operation easier since the Join and
Split operations are defined in two different header files.

BUG=

Change-Id: I86ed3fb360737d3c2fed14edcff59afa0bbac05b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948241
Commit-Queue: Robert Liao <robliao@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Auto-Submit: Robert Liao <robliao@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721692}

If kDragFromShelfToHomeOrOverview feature is enabled, gesture to drag
most recent app window in from top of the home screen is disabled.
Given that on home screen the drag handle presence indicates that an app
window can be dragged in, remove the handle when the feature is enabled.

BUG=1024629,1026964, 1030817

Change-Id: Iefc229bcb447618502b554b8848a800f829c3969
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951643Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721691}

Rename PermissionRequestAutoBlocker to NotificationPermissionUiSelector
to better reflect its current responsibility, and to disambiguate from
PermissionDecisionAutoBlocker.

Factor out all logic from ShouldCurrentRequestUseQuietUI() into an
NotificationPermissionUiSelector implementation, in preparation for the
drop-in replacement ContextualNotifictionPermissionUiSelector from a
follow-up CL.

Also update calls sites on Android to call the PermissionRequestManager
instead of the QuietNotificationPermissionUiState, so that these call
sites will be able to tolerate showing only a fraction of requests
using the quiet UI once Safe Browsing based triggering is enabled.

Bug: 1030633
Change-Id: I355072e0f40cae665536c66b0631d8e609be9b8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951105Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721690}

When aggregator.GetNode() is nullptr, ShouldWalkObject returns false.

Bug: 999264

Change-Id: I4d25322dfdff3741c7a3f02bf6971db233716c85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946450
Auto-Submit: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721689}

Once we have a Q bot these can go on the CQ.

Bug: 1012819
Change-Id: Ia8dd3eff4aaf239db80676e832cb2b936ad6bfc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943096
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721688}

Adding a nullptr check to OnSimpleLoaderCompleteInternal() to avoid crashes
that have been appearing since M69.

Change-Id: Iaa1ddc1cefb741917029bbfb581995c7836d373a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949549Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#721687}

This (somewhat) refactors the AddOutOfFlowChildCandidate into two variants:
 1) For the inline-level OOF case.
 2) For the block-level OOF, added additional "edge" paramaeters.

There should be no behaviour change.

Bug: 845235
Change-Id: If3957078afca7cc0f9175198837a06f0f2badadb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931676
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721686}

ChromeDriver is not correctly detecting when a context id is no longer
valid. This cl updates the error string used to detect this case, and
returns a Selenium standard error instead of a Chrome specific-error.

Bug: chromedriver:3230
Change-Id: Iaa33ae5d64cc634dddc53776e0d03bc385cf6bb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951571Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tricia Crichton <triciac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721685}

Splitting these changes off of
https://chromium-review.googlesource.com/c/chromium/src/+/1949773

Bug: 1022212
Change-Id: Ibf62966995ff4c16eb8cd1edf65110e469ad28e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951156
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721684}

This reverts commit 9d32d07a.

Reason for revert: Causing webkit_layout_tests failures:
https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/7801

Original change's description:
> Make ScriptedAnimationController a ContextLifecycleStateObserver
> 
> This removes the need for special-case pausing/unpausing in Document, as well
> as custom Document::Shutdown() logic.
> 
> Bug: 1029822
> Change-Id: I2c9cda5bb3720626cdc1f3fcadb7876422ca375e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949275
> Commit-Queue: Nate Chapin <japhet@chromium.org>
> Auto-Submit: Nate Chapin <japhet@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#721599}

TBR=haraken@chromium.org,japhet@chromium.org

Change-Id: Ib0dae947c5d4f5dd375b4d14130cf33146648036
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1029822
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951772Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721683}

This adds an optional message below the form in the show action form.
At the message's right there is a tappable icon that prompts a message.
In the prompt it's possible to add a button that opens an URL.


Bug: b/144083252
Change-Id: Iaa02a0660cc1f9cc7246e620f0579346a4d2d494
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940174
Commit-Queue: Luca Hunkeler <hluca@google.com>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#721682}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1e65162c..6d162b51

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I00a230070338ec44e0be84dfdacebd9aca156535
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950887Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721681}

https://chromium.googlesource.com/catapult.git/+log/1d23e728fb93..c4a669a1bfc2

git log 1d23e728fb93..c4a669a1bfc2 --date=short --first-parent --format='%ad %ae %s'
2019-12-04 crouleau@chromium.org [Telemetry] Add weblayer as a tag for disabling.

Created with:
  gclient setdep -r src/third_party/catapult@c4a669a1bfc2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC sadrul@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1030735
Tbr: sadrul@google.com
Change-Id: If733f658298c78b14a15f8bf26bc901e8843a182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951339Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721680}

TBR=rsorokin@chromium.org,xiyuan@chromium.org

Bug: 1030810
Change-Id: Ibca3245a6109f1f6dc56c5389309cfe088a58c7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951545
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721679}

This revert https://chromium-review.googlesource.com/c/chromium/src/+/1951146

Bug: 967716
Change-Id: Iee524f60bc3ee38d0a8118523429d5905ad33914
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951136Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721678}

After the following Linux kernel commit:

commit 2c07a21d6fb0 ("drm: add core support for unplugging a device (v2)")

we now get -ENODEV in response to IOCTLs that are sent to a DRM device
which is in the "unplugged" state.  When unplugging a USB attached
display such as a MIMO, this now causes us to fail the CHECK(status)
sanity check in HardwareDisplayController::SchedulePageFlip().  This is
because we get -ENODEV in response to a page flip IOCTL.

Avoid this browser process crash by ignoring -ENODEV responses to page
flip IOCTLs, just as we already do for -EBUSY and -EACCESS.

I tested this by plugging and unplugging a MIMO using a Guado chromebox
running kernel v4.14.

Bug: b:136471797
Signed-off-by: Ross Zwisler <zwisler@google.com>
Change-Id: I9b25282fda727bcad28da10ef84d357088313e29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951568Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721677}

This CL also adds a flag to BackgroundTaskParameters so that the
permission check for Periodic Background Sync can be skipped from
tests. This allows the instrumentation test to verify Periodic
Background Sync behavior without having to install a PWA.

Bug: 996664
Change-Id: I25885c38ece38e8bcbc15e7e0a6b4efee0d4578b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823077
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721676}

Bug: 991037
Change-Id: Ib05576915206cc2b88a9e3b92d7c5392a480d6e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951004
Commit-Queue: Siyu An <siyua@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#721675}

Using wpt-import in Chromium 979876c1.
With Chromium commits locally applied on WPT:
500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers."
a2a91a99 "Allow another touch start happen when there are active touch points"
85b61e6b "[resource-timing] Ensure workerStart is protected by TAO"
a75430aa "Fix appcache tests."
a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders."
83e4a43b "Refactor VRPose to fit better with WebXr concepts"
a93be69b "Update reversing-an-animation test"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: I3fad8ae994c6c62e95427d2965e8a5d9f56c3f75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950886Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721674}

The included script installs Keystone, and then registers
Chrome with it.

Bug: 1022416
Change-Id: I887b54e0872b0a065cd1ffe17463c06daf460594
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930144Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721673}

TBR=dbeam@chromium.org,tmartino@chromium.org

Bug: 1019296
Change-Id: I3dd7dbf5d1dfdb67b883118b7c4e181cc8bd8795
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947560
Commit-Queue: Archana Simha <archanasimha@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721672}

https://android.googlesource.com/platform/external/perfetto.git/+log/1759c2d96833..77e5e0540b54

git log 1759c2d96833..77e5e0540b54 --date=short --first-parent --format='%ad %ae %s'
2019-12-04 hjd@google.com Merge "Reland: Add statsd logging to perfetto_cmd"

Created with:
  gclient setdep -r src/third_party/perfetto@77e5e0540b54

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I4b65a784878775d9c361f82d7158bb0f02736a6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951338Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721671}

This CL sets the Dawn GN arg to enable compilation of libdawn [1] in
Chrome OS Chromium builds. This CL does *not* modify the
enable-unsafe-webgpu GPU switch [2], so there should be no changes
in functionality for end users yet.

The main reason for this change is to re-enable the Dawn e2e and unit
tests in Chrome OS which were disabled due to a recent change that
requires use_dawn to be set to actually compile the tests [3].
Furthermore, we will need this flag in the near future anyways when
WebGPU support is fully implemented in CrOS.

Adding this flag on the Chrome OS side breaks none of the trybots on
the CQ [4], so the main concern is that adding the new library will
bloat the Chrome binary. I did a quick check, and it seems like
Dawn (and all of its own third-party dependencies) adds less than 1%
to the build size.

~/chromium/src$ du -h out_atlas/Release/chrome
262M	out_atlas/Release/chrome
<Update GN args>
~/chromium/src$ du -h out_atlas/Release/chrome
264M	out_atlas/Release/chrome

[1] https://cs.chromium.org/chromium/src/third_party/dawn/
[2] https://cs.chromium.org/chromium/src/chrome/browser/about_flags.cc?l=4230&rcl=3938e6ad2290409589b5595dd13e0661bb2cf276
[3] https://chromium-review.googlesource.com/c/chromium/src/+/1917380
[4] https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1918345

Bug: 996470
Change-Id: Ia4ccd28817e7665c6725a719b574ad15dad613f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935234Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Brian Ho <hob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721670}

This reverts commit 4f7bdf97.

Reason for revert: Suspected to be the cause of test failures on the "Linux Tests (dbg)(1)" bot:
https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/85058

Original change's description:
> Friendly Privacy Setting Initial Redesign: Reland
> 
> Changes between original submission and reland:
> 
> 1.) Privacy-page subpages are now in lazy_load.html
> 2.) Fixed bug that erroneously showed "privacy" in the settings menu of "Guest" mode settings.
> 3.) Fixed bug where going to chrome://settings/clearBrowsingData didn't work unless the advanced section was expanded when the flag for this change was disabled.
> 4.) Reordered a few settings rows to match the most current mocks.
> 
> > Revert "Friendly Privacy Setting Initial Redesign"
> 
> > This reverts commit 544412a4.
> 
> > Reason for revert: Performance and functional regressions
> > https://bugs.chromium.org/p/chromium/issues/detail?id=1024034#c5
> 
> > Original change's description:
> >> Friendly Privacy Setting Initial Redesign
> >>
> >> This CL does 3 things:
> >> 1) The order of rows in the privacy page is affected, regardless of the value of the "privacySettingsRedesignEnabled" flag.
> >> 2) The privacy-page is moved to the "basic", only when the "privacySettingsRedesignEnabled" flag is on.
> >> 3) A "more" expansion button is introduced in the privacy-page only when the "privacySettingsRedesignEnabled" flag.
> >>
> >> Bug: 1014143
> >> Change-Id: I678e81aa3b67acd2ae41eeda355cd3b32a5b4088
> >> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872094
> >> Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
> >> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> >> Cr-Commit-Position: refs/heads/master@{#714287}
> 
> Change-Id: If3fa33801604491b8648672ff53d37a818f2cd08
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929443
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#721579}

TBR=dbeam@chromium.org,dpapad@chromium.org,msramek@chromium.org,harrisonsean@chromium.org

Change-Id: I50b7bd6b35a1ac769b38c73bdc4b69dd51fa4d6b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951728Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721669}

We would like to enable SkiaRenderer by default on Linux. Due to Skia not
guaranteeing pixel-perfect reprodcution, the blink layout tests require the use
of --fuzzy-diff.

While this was added as a --linux-args to the main test configs, unfortunately
test_suite_exceptions just bases over the args. So this adds it to all linux
exceptions.

This also creates a new exception for linux-trusty-rel as apparently that mixin
does not apply --linux-args

TEST=blink_layout_tests
     webkit_layout_tests

Bug: 967716
Change-Id: I6a97a74effeb5153dce8f21a3da15fc764fada64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951132Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721668}

Currently, the MediaRouter BUILD.gn does not declare any dependencies on
the UI browser.h file, causing build failures on some bots. This patch
adds a dependency on //components/signin/public/base:signin_buildflags
to fix the Open Screen build bots, as ui/browser.h ultimately depends on
this generated header.

Change-Id: Iafed8a6a3717b9ee2b8df6fb41f385a4a0acc4bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951543Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721667}

We should enforce network connection for the first installation of the
app and give the ability to configure the network before running the
app.

Bug: 1015383,1006230
Change-Id: Ic4c10d8032cbd62eada8f85ed343efd92994d594
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904075Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Oleg Davydov <burunduk@chromium.org>
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721666}

This fixes a regression introduced by https://chromium-review.googlesource.com/c/chromium/src/+/1947358
because that CL inadvertently conflated having an empty filter bounds and not cropping the
backdrop at all. This fixes it by dropping the backdrop filter if the backdrop filter bounds
are empty (i.e. all filtered content would have been cropped out anyways).

CalculateRPDQParams() is updated to check the backdrop filter bounds for emptiness. By dropping
early, the rest of the draw code may be able to avoid calling saveLayer() that normally is
required for a backdrop filter. Essentially we have three backdrop filter modes:
1. Backdrop filter with no bounds to crop against
2. Backdrop filter with non-empty bounds to crop against
3. No backdrop filter, or backdrop filter with empty bounds (visually the same, and now effectively
the same in CalculateRPDQParams).

Change-Id: Idcdffb35fa7912fd51ce2cc673a6ce7e2d39371e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948061
Commit-Queue: weiliangc <weiliangc@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Auto-Submit: Michael Ludwig <michaelludwig@google.com>
Cr-Commit-Position: refs/heads/master@{#721665}

https://skia.googlesource.com/skia.git/+log/a06f9d0787ca..6344c2937997

git log a06f9d0787ca..6344c2937997 --date=short --first-parent --format='%ad %ae %s'
2019-12-04 reed@google.com some cleanups for halfplanes
2019-12-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-12-04 egdaniel@google.com Remove unneeded abandon/release check in GrGpuResource message processing.
2019-12-04 bsalomon@google.com Remove SkSize& SkSize::operator=(const SkISize&)

Created with:
  gclient setdep -r src/third_party/skia@6344c2937997

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC bsalomon@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: bsalomon@google.com
Change-Id: Id364b943406450d2210371ef337df9a852a6849c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951330Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721664}

This is a reland of ca140dc0

No changes from the original CL, as it was reverted due to a
FindIt false positive.

Original change's description:
> Replace uses of LogSymbolizedUnsymbolizedMinidumps
>
> Replaces all uses of LogSymbolizedUnsymbolizedMinidumps with
> CollectDebugData, which is functionally identical but the name is more
> descriptive of what it actually does.
>
> TBR=crouleau@chromium.org
>
> Bug: 1025034
> Change-Id: I1cbb2702efec1e608622ca0878399f5406a2775d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937854
> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#720640}

Bug: 1025034
Change-Id: Ia522c0c172b42eb274989d170c578fbe68a6ba4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947387
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721663}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b92f8d81cac4..75a7e95c6f5c


Created with:
  gclient setdep -r src-internal@75a7e95c6f5c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I6bb3eab039a89b3dce1ef0ba2da77dbbc1187c15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951325Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721662}

The page switcher button radius should be 4 dip instead of 5.

BUG=None

Change-Id: Ibfd1a7fd97190b78003a36b1ebca1a56939f7619
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949364Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721661}

- Adds infobarAccepted flag that is YES whenever a user has tapped on
a Translate action.
- Adds displayShowOriginalBanner flag that is YES whenever a translation
has taken place, this will display a Show Original banner once the initial
Banner/Modal has been dismissed.
- alwaysTranslateSourceLanguage now uses performInfobarAction to translate.

Bug: 1014959
Change-Id: I337f6d3172a4f32524940635d9f65944c3daeedf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949853Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721660}

Both Ozone's and Android's OverlayCandidateValidator implementation
goes through a list of strategies. This is different from the Mac and
Windows implementation, which instead answers simple true or false
question. This CL adds a OverlayCandidateValidatorStrategy class as a
base class to be shared by Ozone and Android.

This is moving towards separating out different platforms' validator
implementations so they can be moved into OverlayProcess. The final
goal is for OverlayProcessor to have different subclass implementation
for each platform.

This is CL 3/? of overlay processor refactor.

R=rjkroege
TBR=kylechar@chromium.org

Bug: 963597
Change-Id: I58e17a1bcff7045963ff6026e859310f37972f23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756474
Commit-Queue: weiliangc <weiliangc@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721659}

Bug: None
Change-Id: I51d0b37d763008690f1e4de94c7abd348d8966e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951547
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721658}