GitLab

Use batches of 5 seconds instead of immediate log emission.
(An upcoming CL should make this configurable from JS.)

Bug: 910576
Change-Id: Ib2b804e1e8c7798b744548fb343776fa8a315a65
Reviewed-on: https://chromium-review.googlesource.com/c/1356800Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612663}

From "OK" => "", as per the spec change
https://github.com/whatwg/fetch/pull/836.

R=yhirano@chromium.org, yoav@yoav.ws

Bug: 907441
Change-Id: Id58718ecdba49432078358c20d62df5ff0eda8f8
Reviewed-on: https://chromium-review.googlesource.com/c/1348739
Commit-Queue: Dominic Farolino <domfarolino@gmail.com>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612662}

This CL is in preparation for making SplashActivity more complicated and overriding
SplashActivity#onResume().

This CL:
- Makes SplashActivity no longer inherit from HostBrowserLauncherActivity
- Changes TransparentLauncherActivity to call finish() after the call to
  onHostBrowserSelected()

BUG=901954

Change-Id: I2577031db9f132fc61757126ef9ffbe5c64d46cd
Reviewed-on: https://chromium-review.googlesource.com/c/1319342
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612661}

Bug: 904337
Change-Id: I8fad51cde2b93b83dfa1a14c61a992f659d827be
Reviewed-on: https://chromium-review.googlesource.com/c/1356710Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612660}

Segments are always 4k and indexed by a WTF::Vector

BUG=879657

Change-Id: Ibe922cc6736fed0ba04e99aee0f04eb470f7fecf
Reviewed-on: https://chromium-review.googlesource.com/c/1355884Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612659}

Bug: 846432
Change-Id: Ie618f4e8f978bec4134b1b163e46f087d3101967
Reviewed-on: https://chromium-review.googlesource.com/c/1356238Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612658}

New metric is Net.DNS.RecordParser.DomainNameLength

Bug: 905823
Change-Id: I910ea0bf2629ee2e4663acf998a50debdbed5445
Reviewed-on: https://chromium-review.googlesource.com/c/1340819Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Daniel McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612657}

Bug: 845472
Change-Id: Ibdcc5ead0e06decf0fc27914bea6801120cc77a9
Reviewed-on: https://chromium-review.googlesource.com/c/1356980Reviewed-by: Yi Su <mrsuyi@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612656}

This recently added API has been replaced by the more consistent and
descriptive UpdatePersistentErrorOfRefreshTokenForAccount. Also added
some missing documentation.

This is a follow-up of https://crrev.com/c/1352250

Change-Id: I35bf19d6a209358475e799d3aeed8e772c693d91
Reviewed-on: https://chromium-review.googlesource.com/c/1355185Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#612655}

This CL changes the Blink wrapper for fuzzed_data_provider for callers wanting
a random length string. This uses a much simpler technique for pulling strings
out of random data which should yield better fuzzing discovery.

Note: This will change the behavior of the (two) fuzzers using ConsumeBytesInRange.

Additionally, we add a small max limit to the tokenizer fuzzer to avoid hangs. I
couldn't find anything wrong with the production code to cause these hangs.

Bug: 813761
Change-Id: I30b3be16b6c101165fdd3041596a82412e5c46f1
Reviewed-on: https://chromium-review.googlesource.com/c/1354413Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612654}

Bug: 909867
Change-Id: I8d910acd2b5adf3686678ef186318cc4dc4fe118
Reviewed-on: https://chromium-review.googlesource.com/c/1355772Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612653}

This CL move cache_storage.mojom
third_party/blink/public/platform/modules/cache_storage/
third_party/blink/public/mojom/cache_storage/

from: 
to: 
Change-Id: If3891da5f573f9fc369b8ac89a813d35f1e29fc7
Reviewed-on: https://chromium-review.googlesource.com/c/1351949
Commit-Queue: Richard Li <richard.li@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#612652}

This reverts commit acde6a72.

Reason for revert: Causing crashes, see https://crbug.com/907720.

Original change's description:
> Remove RefCountedThreadSafe from CommandBufferTaskExecutor.
> 
> CommandBufferTaskExecutor needs to be created and destroyed on the GPU
> thread. To ensure it's destroyed on the GPU thread we hold onto a
> scoped_refptr there and destroy it last. Owning the object there and
> passing around a raw pointer accomplishes the same thing with less
> complexity.
> 
> Bug: none
> Change-Id: I7c2d4f22044d28799c04144729c03d273abe7592
> Reviewed-on: https://chromium-review.googlesource.com/c/1340907
> Reviewed-by: Bo <boliu@chromium.org>
> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
> Commit-Queue: kylechar <kylechar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609557}

TBR=boliu@chromium.org,sunnyps@chromium.org,kylechar@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 907720
Change-Id: Ia85f08ce16a674525be9378e44b3535d037fdf24
Reviewed-on: https://chromium-review.googlesource.com/c/1351477Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612651}

|is_valid| is confusing for people in practice: many people want to
check is_valid in cases where they shouldn't. I introduced it to avoid
adding the ability to query the persistent error state to the
IdentityManager API (for Sync's use case of detecting the refresh token
being set to the invalid token). However, avoiding adding that API is no
longer a priority.

This CL gets rid of this parameter altogether; after precedent CLs, it
is not used by any consumer, so this is just stripping out the param.

TBR=sdefresne@chromium.org

Bug: 908412
Change-Id: Idfa954b8d827312c88f2a93dab0e76a87e9ba147
Reviewed-on: https://chromium-review.googlesource.com/c/1350986Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612650}

Before this CL, the AccountConsistency preferences were registered in
ChromeSigninClientFactory, which is not the right place.
This CL moves the registration to the
AccountConsistencyModeManagerFactory.

This requires splitting the AccountConsistencyModeManagerFactory
in its own file, so that it can be registered correctly in
chrome_browser_main_extra_parts_profiles.cc

Change-Id: I0d0dc59796c96d8e48d31a244e59bfe1eb01e334
Reviewed-on: https://chromium-review.googlesource.com/c/1355167Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612649}

https://dawn.googlesource.com/dawn.git/+log/df72914a60d5..58017e91adbf


git log df72914a60d5..58017e91adbf --date=short --no-merges --format='%ad %ae %s'
2018-11-30 cwallez@chromium.org Use Chromium's dcheck_always_on when available.


Created with:
  gclient setdep -r src/third_party/dawn@58017e91adbf

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:901830
TBR=cwallez@chromium.org

Change-Id: I83a90919680d8c321616e25d141857d6e4483c68
Reviewed-on: https://chromium-review.googlesource.com/c/1356622Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612648}

Bug: 910288
Change-Id: I0ab5c1d9f96662d6d5a894a93d8ed031a8655386
Reviewed-on: https://chromium-review.googlesource.com/c/1355320Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612647}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/397651f864da..9bd7b090dcae


Created with:
  gclient setdep -r src-internal@9bd7b090dcae

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Id0383ba2c60133c0302ab3a6741548ad77bc9141
Reviewed-on: https://chromium-review.googlesource.com/c/1356624Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612646}

This relates to http://crrev/c/1340940 , where the ID of the bottombar was changed in the layout, but not in code.

Bug: 806868
Change-Id: I5869625714d9a747f7468bba3e403db5550c1b3c
Reviewed-on: https://chromium-review.googlesource.com/c/1356544Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#612645}

This CL adds simple function call graph clustering. The call graph is
inferred from the function ordering offset list, and the orderfile is
produced by clustering based on this inferred call graph.

In local testing, this change recovers the speedometer performance
lost in the bug. Startup is not affected, and memory shows similar
improvement to the original system_health orderfile.

Bug: 894827
Change-Id: Iedab652d0f25c9c9ea481c2a75214cac41dee368
Reviewed-on: https://chromium-review.googlesource.com/c/1350876
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612644}

If the root layer and the "current" layer are the same, we can't really
guarantee that the "pre"-transform is the same as the "local border
box"-transform - for example in the case where we're performing a hit-
test from/under a foreignObject element which has a 'transform' applied.

Bug: 908570
Change-Id: Icbaf3c15ca7b483f8209d5d0cc8b4613d80d49ce
Reviewed-on: https://chromium-review.googlesource.com/c/1355184
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612643}

Also introduces new required methods on ProducerClient to make the roll succeed.

https://android.googlesource.com/platform/external/perfetto.git/+log/7b49412a6e09..327406e12cba


git log 7b49412a6e09..327406e12cba --date=short --no-merges --format='%ad %ae %s'
2018-11-30 primiano@google.com Merge "ftrace: add PagePool for ftrace reader"
2018-11-29 treehugger-gerrit@google.com Merge "Flush on SIGINT to perfetto cmd."
2018-11-29 lalitm@google.com Merge "trace_processor: initial implementation of the args table"
2018-11-29 fmayer@google.com Merge "profiling: Add missing error return to script."
2018-11-29 eseckler@google.com Merge "perfetto: Add an IPC to associate trace writers with buffers"
2018-11-29 fmayer@google.com Merge "profiling: Better profiling script."

Change-Id: I5708cfcc3067b0e948eb4803c0963088cb3eddcc
Reviewed-on: https://chromium-review.googlesource.com/c/1356779Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612642}

Convert remaining allocations from new to MakeGarbageCollected

R=haraken@chromium.org

Bug: 757708
Change-Id: I6528c69803088728cf4dfd89ed3b6b5ac4969ad8
Reviewed-on: https://chromium-review.googlesource.com/c/1356720Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612641}

Using wpt-import in Chromium 460a5861.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=kyleju

No-Export: true
Change-Id: Ie486d5c1e36524030ba93276536636151d42f4f2
Reviewed-on: https://chromium-review.googlesource.com/c/1356819
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612640}

MessageLoop will go away, eventually.

BUG=891670

Change-Id: I5911ca044c8632a77ed851a148892db34e8ed7c6
Reviewed-on: https://chromium-review.googlesource.com/c/1352416Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#612639}

The previous logic depended on GetUploadToGoogleState, which we changed
to return false in Butter mode.

BUG=906630
R=treib,sebsg

Change-Id: I42c40c20d6d997d571b427b512fe1afc9fd50329
Reviewed-on: https://chromium-review.googlesource.com/c/1354448
Commit-Queue: Florian Uunk <feuunk@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612638}

This CL reorders calls in SyncTestRule so AndroidSyncSettings instance
is overridden before activity is started. This is done to prevent
classes initialized during activity initialization from grabbing
a reference to the default AndroidSyncSettings.

Bug: 903657, 903658, 906188, 906193, 906788
Change-Id: Ib412d7748a8ec6f48b80436051a932d6b7713940
Reviewed-on: https://chromium-review.googlesource.com/c/1356583Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612637}

This CL makes sure the bounds on the serialized node created
in ax_root_obj_wrapper.cc are set. Previously, this was left
as 0,0 and due to recent condition added to ui_event_generator.cc,
this was preventing auto generated LOAD_COMPLETE event from
firing on the desktop tree. (See ShouldFireEvent function).

Also removed all #if !defined(IS_CHROMECAST) as they had no
    effect anyway (the define was never set). No reason to omit
    this code for chromecast anyway.

Change-Id: Ifff95227a8b07349e5401678f9428a85b803ca01

      screen reader.  No issues detected.  Did the same on
      Chromecast smart display. Same.

Bug: 910325
Test: Manual install on Samus ChromeOS device, activated
Change-Id: Ifff95227a8b07349e5401678f9428a85b803ca01
Reviewed-on: https://chromium-review.googlesource.com/c/1355551Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612636}

...and update the tests that depended on overriding it.

Bug: 884159
Change-Id: Iac892550720e19ee5d334f0598413b7e225b8338
Reviewed-on: https://chromium-review.googlesource.com/c/1356704Reviewed-by: Florian Uunk <feuunk@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612635}

When Clear-Site-Data is triggered during a ServiceWorker update request,
there is a deadlock because the update task is waiting for the request,
the request is waiting for Clear-Site-Data, Clear-Site-Data is waiting
for the unregistration of the service worker and the unregistration is
waiting for the update task.
This is fixed by cancelling the update task and removing the service
worker without updating it.
Also requests from Service Workers are not associated with a
WebContents, so we need a better way to get a BrowserContext for these
requests.

Bug: 898465
Change-Id: I543b44e07720cf1849d1d4245ee7d36ec762efb6
Reviewed-on: https://chromium-review.googlesource.com/c/1348058Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612634}

Bug: 896125
Change-Id: I077a839ab900d3e8b966b50ed914b055be4c39eb
Reviewed-on: https://chromium-review.googlesource.com/c/1349221Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612633}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/989acc20a7d1..397651f864da


Created with:
  gclient setdep -r src-internal@397651f864da

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I1d7a0829ca2e2ab4f648622abc315a0337cb8b33
Reviewed-on: https://chromium-review.googlesource.com/c/1356621Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612632}

This is better than onUrlUpdated for two reasons:
1. It's more correct as now we know whether the navigation was committed.
2. The timing is a bit closer to the moment the page content is rendered,
so there is less time when the new top bar shows on the old tab contents.

Bug: 882404
Change-Id: I571aaa2a38168e18b7c0c99feb818055d14add3b
Reviewed-on: https://chromium-review.googlesource.com/c/1355170Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612631}

TBR: bsheedy@chromium.org
Bug: 910549
Change-Id: I92700a06daf98166dd6e0ebb6230748ecc9ee74a
Reviewed-on: https://chromium-review.googlesource.com/c/1356550Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612630}

This CL removes ProcessInitializationHandler.initializePreNative call
from SigninTestUtil (it's no longer necessary to initialize
AccountManagerFacade before overriding it with a test instance).

Bug: 738533
Change-Id: Ieb9f3afe6b7ed59570b899b667e14a14293abebb
Reviewed-on: https://chromium-review.googlesource.com/c/1355197Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612629}

RequestStop(KEEP_DATA) has been replaced by
SyncUserSettings::SetSyncRequested(false). RequestStop(CLEAR_DATA) is
being replaced in this CL by a new StopAndClear().

Bug: 884159
Change-Id: I0d94ee4e834114c062c79bfc10c188276cc294d8
Reviewed-on: https://chromium-review.googlesource.com/c/1353944Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612628}

Also in this CL:
- Refactored onboarding screen to use RelativeLayout (anchor bottom) instead of hard-coded paddings.
- Adjusted paddings according to the mocks.
- The link in the T&C section is currently a stub.
- The image is now centered (previously, it was slightly too far to the right).

Before: https://screenshot.googleplex.com/Od2OhcbKq8y.png
After: https://screenshot.googleplex.com/QdZMisVFK2V.png

Bug: 806868
Change-Id: I1868020aac94c856780069dfd912ffa7fac60758
Reviewed-on: https://chromium-review.googlesource.com/c/1350887
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612627}

This removes checks for !IsLocalSyncEnabled() and IsSignedIn(), which
are implied by IsAuthenticatedAccountPrimary().
With this, IsSyncConfirmationNeeded is implemented fully in terms of
the public SyncService interface, which means we'll be able to move it
out of ProfileSyncService in a followup.

Bug: 884159
Change-Id: I532065b4517e2156c32b8eb91bf613ba23c4a267
Reviewed-on: https://chromium-review.googlesource.com/c/1356543Reviewed-by: Florian Uunk <feuunk@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612626}

The decision of whether the next candidate needs to be downloaded or not
should be independent of possible errors in the last download. Let's
move that logic to a dedicated predicate (ShouldDownloadNextCandidate())
and make sure it's honored in all codepaths (e.g. 404s,
or if image_skia.isNull()).

Bug: 895175
Change-Id: Id4d41ea873b62559c3d191952045f9c714fe729f
Reviewed-on: https://chromium-review.googlesource.com/c/1350631
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612625}

TBR=kojii@chromium.org,xioachengh@chromium.org,yosin@chromium.org

Change-Id: I062fb3026b2dd36aabc50f3f6334da9c9fb580b7
Reviewed-on: https://chromium-review.googlesource.com/c/1356701Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612624}