GitLab

Timing out on windows and linux.

BUG=128412
TEST=

Review URL: https://chromiumcodereview.appspot.com/10417015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138130 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138129 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=steveblock
Review URL: https://chromiumcodereview.appspot.com/10416016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138128 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128429
TEST=make sure cellular section does not show up in settings when only WiMAX is present

Review URL: https://chromiumcodereview.appspot.com/10407069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138126 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10387206

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138124 0039d316-1c4b-4281-b951-d872f2087c98

They should read Yes/No, instead of OK/Close.

BUG=128861
TEST=to reproduce this, have more than 15 bookmarks in a folder in the bookmark
bar, click on "Open All Bookmarks", you should see a confirmation dialog with
[Yes] [No] buttons.
R=pkasting@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10392177

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138121 0039d316-1c4b-4281-b951-d872f2087c98

thread was waiting to get the next frame for renderering which attempts to grab the VideoRendererBase lock
and the gpu video decoder thread would wait on the renderer thread to execute a task while holding the above
lock.

Fix is to post task the demuxer_stream_->Read call to ensure that the lock is released by the gpu video decoder
thread.

BUG=129010
R=fischman
Review URL: https://chromiumcodereview.appspot.com/10408043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138120 0039d316-1c4b-4281-b951-d872f2087c98

no need to do that, and it makes debugging easier to have the value.

Change the logic of IsRunning() to use a dedicated member variable 
instead of overloading the thread id. 

BUG=127931
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10399097

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138119 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138117 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10417014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138116 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=None (yet)
TEST=The vertical separator between recently close and webstore footer link works.

Review URL: https://chromiumcodereview.appspot.com/10332274

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138113 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127463
TEST=Manual.

Review URL: https://chromiumcodereview.appspot.com/10407066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138112 0039d316-1c4b-4281-b951-d872f2087c98

and OnReadCompleted methods.  Use that to pause the request
instead of directly calling ResourceDispatcherHostImpl's
PauseRequest function.

Eliminate direct calls to PauseRequest, with the exception of
resource_dispatcher_host_unittest.cc and some uses internal to
ResourceDispatcherHostImpl.  Those should ultimately be 
changed to use the defer out-param approach too.

This CL also changes the DownloadRequestHandle to talk back to
the DownloadResourceHandler in order to pause / resume / cancel
the URLRequest.  The handle keeps a reference to the handler,
which may extend the lifetime of the handler, but that should be
OK given that the handler already supports having its lifetime
extended beyond the URLRequest.

Now, instead of the DownloadFileManager calling PauseRequest, we
just wait for the SetDownloadID call to resume the URLRequest.
This simplifies some of the logic.  The Pause/ResumeRequest
issued on a DownloadRequestHandle gets its own pause counter,
which has nothing to do with the internal pausing that the
DownloadResourceHandler does when it is waiting for a DownloadId.
See DownloadResourceHandler::MaybeResumeRequest for the logic
that handles the conditions for resuming the URLRequest.
Review URL: https://chromiumcodereview.appspot.com/10332130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138111 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138110 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10407062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138109 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128811
Review URL: https://chromiumcodereview.appspot.com/10409054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138106 0039d316-1c4b-4281-b951-d872f2087c98

The synthetic mouse event is generated at the last mouse DIP-location. But this
event gets transformed for DIP again before it gets dispatched. This ends up
sending the event with incorrect location. So make sure it starts off with the
pixel-location so that the event location gets transformed for DIP only once.

BUG=128095
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10408037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138104 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127697
TEST=

Review URL: https://chromiumcodereview.appspot.com/10399105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138103 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128986

Review URL: https://chromiumcodereview.appspot.com/10383268

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138099 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138098 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138096 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10392180

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138095 0039d316-1c4b-4281-b951-d872f2087c98

These are timing out on the Win (dbg) canary.

BUG=128961

Review URL: https://chromiumcodereview.appspot.com/10407065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138094 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128519

Review URL: https://chromiumcodereview.appspot.com/10399103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138093 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138091 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10417006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138090 0039d316-1c4b-4281-b951-d872f2087c98

This has been flaky on the Win (dbg) canary.

BUG=62311

Review URL: https://chromiumcodereview.appspot.com/10387213

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138089 0039d316-1c4b-4281-b951-d872f2087c98

These are timing out on the Win (dbg) canary.

BUG=128961

Review URL: https://chromiumcodereview.appspot.com/10411050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138088 0039d316-1c4b-4281-b951-d872f2087c98

These are timing out consistently on the Win (dbg) canary.

BUG=128961

Review URL: https://chromiumcodereview.appspot.com/10332270

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138087 0039d316-1c4b-4281-b951-d872f2087c98

This fails after WebKit r117702

BUG=128959

Review URL: https://chromiumcodereview.appspot.com/10399102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138086 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138083 0039d316-1c4b-4281-b951-d872f2087c98

Add a minimum number of bytes when serializing logs so that a large number of very small logs won't be capped the same way as a large number of large logs. This ensures that a reasonable amount of metrics history will be kept even when logs can potentially be cut very frequently, such as Android.

In the short term this may slightly increase the number of logs that are retained, since the number of logs kept by this method is the same or greater than what was kept before.

BUG=None
TEST=None

Review URL: https://chromiumcodereview.appspot.com/9562007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138081 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds a way to simulate IME composition events
inside the renderer process, and tests that IME events are
properly passed between the renderer and plugins.

ppapi/tests/test_ime_input_event.cc:
is the actual test case

ppapi/{api,c,cpp}/dev/*ime_input_event_dev*:
implements an API to create IME events from plugins for testing.

other files:
wire necessary stuff for simulating IME events.
Since Pepper IME events are not delivered through WebKit/DOM layer
but rather directly sent from renderer to plugins,
the simulation part also follows the similar code path.

BUG=126714
TEST=browser_tests PPAPITest.ImeInputEvent

Review URL: https://chromiumcodereview.appspot.com/10391101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138080 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10391185

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138079 0039d316-1c4b-4281-b951-d872f2087c98

BUG=117262
TBR=aa@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10375021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138074 0039d316-1c4b-4281-b951-d872f2087c98

Since r124366 we started checking file permission against
ChildProcessSecurityPolicy on each operation but the current
code prohibits read access on a root directory of IsolatedFileSystem,
since the root directory in IsolatedFileSystem is purely virtual and
has no associated platform path (to check the permission).

BUG=none
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10106017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138073 0039d316-1c4b-4281-b951-d872f2087c98

The files were changed using the following sed script
  1 :top
  2 /SetImage/ {
  3   s|ToSkBitmap|ToImageSkia|g
  4   s|GetBitmapNamed|GetImageSkiaNamed|g
  5   n
  6   N
  7   s|ToSkBitmap|ToImageSkia|g
  8   s|GetBitmapNamed|GetImageSkiaNamed|g
  9   b top
 10 }
 11 /SetBackground/ {
 12   s|ToSkBitmap|ToImageSkia|g
 13   s|GetBitmapNamed|GetImageSkiaNamed|g
 14   n
 15   N
 16   s|ToSkBitmap|ToImageSkia|g
 17   s|GetBitmapNamed|GetImageSkiaNamed|g
 18   b top
 19 }
 20 /SetToggledImage/ {
 21   s|ToSkBitmap|ToImageSkia|g
 22   s|GetBitmapNamed|GetImageSkiaNamed|g
 23   n
 24   N
 25   s|ToSkBitmap|ToImageSkia|g
 26   s|GetBitmapNamed|GetImageSkiaNamed|g
 27   b top
 28 }

The following files were modified by hand afterwards:
  1 ash/launcher/launcher_button.cc
  2 ash/system/audio/tray_volume.cc
  3 ash/system/drive/tray_drive.cc
  4 ash/system/tray/system_tray_delegate.h
  5 ash/system/tray/tray_item_more.cc
  6 ash/system/tray/tray_item_more.h
  7 chrome/browser/chromeos/login/take_photo_view.cc
  8 chrome/browser/chromeos/login/take_photo_view.h
  9 chrome/browser/chromeos/options/network_config_view.cc
 10 chrome/browser/chromeos/options/network_config_view.h
 11 chrome/browser/ui/panels/panel_browser_frame_view.cc
 12 chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc
 13 chrome/browser/ui/views/autocomplete/autocomplete_result_view.h
 14 chrome/browser/ui/views/avatar_menu_bubble_view.cc
 15 chrome/browser/ui/views/chrome_to_mobile_bubble_view.cc
 16 chrome/browser/ui/views/confirm_bubble_view.cc
 17 chrome/browser/ui/views/download/download_shelf_view.cc
 18 chrome/browser/ui/views/download/download_started_animation_views.cc
 19 chrome/browser/ui/views/dropdown_bar_view.cc
 20 chrome/browser/ui/views/dropdown_bar_view.h
 21 chrome/browser/ui/views/find_bar_view.cc
 22 chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
 23 chrome/browser/ui/views/hung_renderer_view.cc
 24 chrome/browser/ui/views/location_bar/page_action_image_view.cc
 25 chrome/browser/ui/views/tabs/tab_strip.cc
 26 chrome/browser/ui/views/tabs/tab_strip.h
 27 ui/views/controls/button/image_button.h
 28 ui/views/controls/button/image_button_unittest.cc
 29 ui/views/controls/scrollbar/bitmap_scroll_bar.cc
 30 ui/views/controls/scrollbar/bitmap_scroll_bar.h

Whitespace changes were made in the following files manually
  1 ash/launcher/launcher_view.cc
  2 chrome/browser/chromeos/login/simple_web_view_dialog.cc
  3 chrome/browser/ui/views/location_bar/chrome_to_mobile_view.cc
  4 chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
  5 chrome/browser/ui/views/toolbar_view.cc 

Bug=124566
Test=Compiles, try bots pass

Review URL: https://chromiumcodereview.appspot.com/10382144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138072 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125513
TEST=git status


Review URL: https://chromiumcodereview.appspot.com/10386222

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138071 0039d316-1c4b-4281-b951-d872f2087c98

A while back we removed all FAILS_ and FLAKY_ tests but a few came back.

BUG=104300,118944,88552,103062,89961

Review URL: https://chromiumcodereview.appspot.com/10381078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138070 0039d316-1c4b-4281-b951-d872f2087c98

linux-release-lowmem/moz: http://build.chromium.org/f/chromium/perf/linux-release-lowmem/moz/report.html?history=250&rev=138066
linux-release-lowmem/intl1: http://build.chromium.org/f/chromium/perf/linux-release-lowmem/intl1/report.html?history=150&rev=138066
linux-release-lowmem/database/*: http://build.chromium.org/f/chromium/perf/linux-release-lowmem/database/report.html?history=150&rev=138066&graph=select-readtransactions-read-results
linux-release-lowmem/v8_benchmark: http://build.chromium.org/f/chromium/perf/linux-release-lowmem/v8_benchmark/report.html?history=150&rev=138066

TBR=cmp
BUG=128645, 121574
Review URL: https://chromiumcodereview.appspot.com/10413021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138069 0039d316-1c4b-4281-b951-d872f2087c98