GitLab

Old: http://chromium-review.googlesource.com/643886
Revert: http://chromium-review.googlesource.com/698004

Bug: 760614
Change-Id: I6d852739c27d84242a1ee90b558ca39b35b273e1
Reviewed-on: https://chromium-review.googlesource.com/698524Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506414}

Bug: 768419
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9f5f2b134213de42e241ba7aa16a8026d77e6684
Reviewed-on: https://chromium-review.googlesource.com/695209
Commit-Queue: Chris Pickel <sfiera@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506413}

This reverts commit df7b7f8e.

Reason for revert: WinAudioInputTest.WASAPIAudioInputStreamMiscCallingSequences started failing on Windows after this patch.

Original change's description:
> Move microphone debug recording to AM.
> 
> Introduces the AudioInputStreamDataInterceptor, which transparently sends audio
> data off for debug recording. AudioManagerBase wraps each created input stream
> in an interceptor to enable debug recording. A side effect of this refactoring
> is that WebContents input streams will not be recorded, but AFAIK noone ever
> used recordings anyways. I also somehow had to fix a bunch of IWYU, not sure
> how I got dragged into that :).
> 
> Since AudioInputRendererHost doesn't have to be accessed by the
> RenderProcessHostImpl anymore, the member variable was removed; the lifetime of
> the AudioInputRendererHost is now managed by the IPC::Channel as it is for other
> message filters.
> 
> Bug: 768610
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I24a89435b283cd5df68373eb37d776a320d6ffd5
> Reviewed-on: https://chromium-review.googlesource.com/680217
> Commit-Queue: Max Morin <maxmorin@chromium.org>
> Reviewed-by: Olga Sharonova <olka@chromium.org>
> Reviewed-by: Tommi <tommi@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Henrik Grunell <grunell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506338}

TBR=avi@chromium.org,tommi@chromium.org,grunell@chromium.org,olka@chromium.org,maxmorin@chromium.org

Change-Id: Id99c595e6ce4cba32e4a43ef93bee2ec329c749e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 768610
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/700079Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506412}

Fragment anchors are often used for "spriting purposes" when using SVG
documents, so scrolling the referenced element into view could seemingly
randomly scroll the top-level document (if it was same-origin with the
sprite sheet.) This is usually not an expected or wanted behavior.
Inhibit scrolling for all the embedding cases. (It's uncertain whether
this ought to affect <iframe>s or not, but let's include those too for
now. For simplicity.)

While here, also remove the dependency on SVGDocumentExtension for the
trivial operation of getting the root element.

Bug: 493802
Change-Id: I9942093331b2c53ba94ad83cfbe0a3b8b4ca6cbe
Reviewed-on: https://chromium-review.googlesource.com/700638Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#506411}

We have not shipped Windows Ash for years. There is a 1:1 mapping
between USE_ASH and OS_CHROMEOS, so consolidate them.

The BUILD.gn files will be cleaned up separately.

Bug: 673826
Test: compiles, gn check on Chrome OS, Linux and Linux Ozone
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5ebf64a133d1032f0d7864ed1a180d0f0b170da1
Reviewed-on: https://chromium-review.googlesource.com/692699
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506410}

LLD is not applicable when using a different compiler (GCC at least)

Bug: chromium:607968
Change-Id: I5f4f53a5c91c52cc5ff9a0b9c5f2c5043c7add46
Reviewed-on: https://chromium-review.googlesource.com/700456Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506409}

This conversion address the search UI unsync issue from crbug/722303.

For more on JUnit4 migration, please check
src/testing/android/docs/junit4.md

Bug: 640116,722303
Change-Id: I3f1aeea09e626ca6bdf16ff06bede2afe6387fd3
Reviewed-on: https://chromium-review.googlesource.com/699596Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Yoland Yan <yolandyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506408}

R=inferno@chromium.org, ochang@chromium.org, oprypin@chromium.org

Bug: 720129
Change-Id: Icbadc3b876c057b3649a0761f1a6775e6c119a2e
Reviewed-on: https://chromium-review.googlesource.com/699798Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506407}

NOTRY=true  # docs update

Change-Id: I4f5840875d6d5256ef14b12de5364643a751f1e4
Reviewed-on: https://chromium-review.googlesource.com/700420Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506406}

WebContents::GetRenderProcessHost is an API that doesn't behave as
expected with out-of-process iframes, as multiple processes can be
associated with a single WebContents.  This CL replaces callers of this
API, so that they go through an equivalent API that explicitly selects
which frame's process is needed.

This CL was started by using an ad-hoc clang-plugin that replaced
existing callsites of WebContents::GetRenderProcessHost() with a call to
something like wc->GetMainFrame()->GetProcess().  This was followed-up
by manually adding an include of render_frame_host.h and git cl format
and git cl lint and then a self-review with small tweaks (e.g. sometimes
using a wc->GetRenderViewHost()->GetProcess() is more appropriate).

This CL was uploaded by git cl split.

R=sky@chromium.org

Bug: 666525
Change-Id: I8167f7c6577f457939f2d2379640523f583c9dff
Reviewed-on: https://chromium-review.googlesource.com/689109
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506405}

Previously it was only disable on system_health.common_desktop

TBR=nednguyen@google.com

Bug: 769809
Change-Id: I02143441e0cee13faab7cf33ba570218a59c480c
Reviewed-on: https://chromium-review.googlesource.com/699053
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506404}

Reference: https://docs.google.com/spreadsheets/d/1HKl-gMSzjI-ygRkYTvqpJRwSW0ZI-xj-0aoiNdTum2g/edit#gid=939250318

Change-Id: Id86469bb8072fbc36df7feea1dc665da275531cf
Reviewed-on: https://chromium-review.googlesource.com/657337
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sanjoy Pal <sanjoy.pal@samsung.com>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506403}

WebContents::GetRenderProcessHost is an API that doesn't behave as
expected with out-of-process iframes, as multiple processes can be
associated with a single WebContents.  This CL replaces callers of this
API, so that they go through an equivalent API that explicitly selects
which frame's process is needed.

This CL was started by using an ad-hoc clang-plugin that replaced
existing callsites of WebContents::GetRenderProcessHost() with a call to
something like wc->GetMainFrame()->GetProcess().  This was followed-up
by manually adding an include of render_frame_host.h and git cl format
and git cl lint and then a self-review with small tweaks (e.g. sometimes
using a wc->GetRenderViewHost()->GetProcess() is more appropriate).

This CL was uploaded by git cl split.

R=samarth@chromium.org

Bug: 666525
Change-Id: I4345acbb935b022be52eadb8789892b33e5b8e96
Reviewed-on: https://chromium-review.googlesource.com/688772Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506402}

In CoalesceScrollAndPinch() function, when the new event cannot be
coalesced with the last event, the DCHECK message is "New event can be
coalesced with the ...", where it should be "can be coalesced ..."

This CL fixes the message. It should introduce no behavior change.

Bug: None
Change-Id: Ia6efb334c005b07a3a98c17655920b6d1109814d
Reviewed-on: https://chromium-review.googlesource.com/700398Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506401}

WebContents::GetRenderProcessHost is an API that doesn't behave as
expected with out-of-process iframes, as multiple processes can be
associated with a single WebContents.  This CL replaces callers of this
API, so that they go through an equivalent API that explicitly selects
which frame's process is needed.

This CL was started by using an ad-hoc clang-plugin that replaced
existing callsites of WebContents::GetRenderProcessHost() with a call to
something like wc->GetMainFrame()->GetProcess().  This was followed-up
by manually adding an include of render_frame_host.h and git cl format
and git cl lint and then a self-review with small tweaks (e.g. sometimes
using a wc->GetRenderViewHost()->GetProcess() is more appropriate).

This CL was uploaded by git cl split.

R=samarth@chromium.org

Bug: 666525
Change-Id: If2a349829b2de02a166403075358e0e7af5f7020
Reviewed-on: https://chromium-review.googlesource.com/689117Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506400}

R=mmoroz@google.com

Bug: 759794
Change-Id: I7f2af4837e83a9ba63ea47735f10701c9d5ffcc1
Reviewed-on: https://chromium-review.googlesource.com/699695
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506399}

There is a crash registered in AutocompleteActionPredictorTable::GetAllRows
probably due to null pointer access. Culprit object is created with raw
new that may be dangerous. This CL removes this and several other usages
of a new statement in c/b/predictors.

Bug: 771616
Change-Id: I30e87b470e623166d03c27694f232a5033b143bf
Reviewed-on: https://chromium-review.googlesource.com/700636
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506398}

Change-Id: I355028a260cef258375192ad71a00711b25dfc70
Reviewed-on: https://chromium-review.googlesource.com/699756Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506397}

* make_qualified_names.py: Generates snake_case file names.

* code_generator.py: Remove exceptions for HTMLNames.h and SVGNames.h.

* MakeQualifedNames.*.tmpl: Renamed to snake_case.
* scripts.gni: Follow the *.tmpl change.

* other files: Use new names of FooNames.h.


Bug: 770603
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I59e0512c5b2d6deffcd84eb9ea33fd47127acd70
Reviewed-on: https://chromium-review.googlesource.com/700236
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506396}

This is what it does behind scenes in Chrome anyway, but always using the scheduler
in tests as well is helpful since it means a single TaskScheduler::FlushForTesting() call
rather than needing both TaskScheduler and SequencedWorkerPool versions of FlushForTesting()
as separate calls, which causes trouble when control jumps back and forth between the two.

Bug: 766221
Change-Id: Iab6a49cad86f1fd5a31c66c50d25e2962c538d53
Reviewed-on: https://chromium-review.googlesource.com/697925Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506395}

There's currently no reason for this class to exist.

Change-Id: Id8a981e37696ceb6c28687f4d894c4278d856997
Reviewed-on: https://chromium-review.googlesource.com/693015Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506394}

This change allows for Android lint suppression configurations
to be defined on a per-target basis (assuming said target is
"Android lint capable") rather than having one global config.
This will allow embedders to keep upstream's lint config for
Chromium targets (w/o patching), while using a separate config
for the embedding application.

Bug: 737897
Change-Id: Ieccb95767e0ce541522d7a53edbe734c5bbfe6dc
Reviewed-on: https://chromium-review.googlesource.com/698297Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506393}

Don't show the search provider when there is no half-height sheet state.
This captures two scenarios:
 - Available screen height is less than 320dp
 - There are no normal tabs currently open

BUG=759134

Change-Id: Ib36154b683679ad2084ac23fafe90e61f9b39fd1
Reviewed-on: https://chromium-review.googlesource.com/698349Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506392}

This guard is required by the upcoming Skia CL https://skia-review.googlesource.com/c/skia/+/55100 (Use SK_DISABLE_DEFERRED_PROXIES to only disable deferred proxies for Chrome)

Change-Id: Ib5972340b8db490af913d5d3bf0889fd364e90cc
Reviewed-on: https://chromium-review.googlesource.com/700475Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#506391}

We may not be seeing as many reboots in the new flow because
there is no browser window open when the cleaner finishes. If
that's the case, we could add logic to reopen the Settings
page when a window pops in the foreground. However, I'd rather
make sure this problem exists before adding more logic to an
already complex piece of code.

Bug: 
Change-Id: I03deaadcda6e2a85001e360811c3fd53554d71a1
Reviewed-on: https://chromium-review.googlesource.com/692695
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506390}

WebContents::GetRenderProcessHost is an API that doesn't behave as
expected with out-of-process iframes, as multiple processes can be
associated with a single WebContents.  This CL replaces callers of this
API, so that they go through an equivalent API that explicitly selects
which frame's process is needed.

This CL was started by using an ad-hoc clang-plugin that replaced
existing callsites of WebContents::GetRenderProcessHost() with a call to
something like wc->GetMainFrame()->GetProcess().  This was followed-up
by manually adding an include of render_frame_host.h and git cl format
and git cl lint and then a self-review with small tweaks (e.g. sometimes
using a wc->GetRenderViewHost()->GetProcess() is more appropriate).

This CL was uploaded by git cl split.

R=samarth@chromium.org

Bug: 666525
Change-Id: Id663ba6297c2513f71343452a1b2f56a1528c17d
Reviewed-on: https://chromium-review.googlesource.com/689140Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506389}

This is a lock order violation that happens when the dll notification
callback is unregistered while under the ModuleWatcher global lock and a
dll notification arrives.

Bug: 757398
Change-Id: I914b03409203394d7546f44d11dfd566f87a6cd4
Reviewed-on: https://chromium-review.googlesource.com/697825Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506388}

This CL is a followup of http://crrev.com/c/695305. It adds relevant
tests to catch any possible regressions.

Bug: 770728
Change-Id: I8e77f1b6d0d8edc78965373da71b37ee764a18ae
Reviewed-on: https://chromium-review.googlesource.com/695331Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506387}

NOTRY=true  # Doc change

Change-Id: Ib1f0379d78b2c668fa8b9541f0427fb13eab177e
Reviewed-on: https://chromium-review.googlesource.com/700478Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506386}

Remove mukai@ from ui/message_center/OWNERS since he no longer works
on Chromium.

Bug: none
Test: none
Change-Id: I20c940861a7b6e120e7f7f235cdb0a33623d8b1a
Reviewed-on: https://chromium-review.googlesource.com/698264Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506385}

Official Android builds scrape the build logs looking for
"unknown pragma" warnings and then remove any resources that don't
have a corresponding warning. This means that the media controls
resources were not getting included in Android builds causing a
crash.

BUG=771507,771513,771512,771397

Change-Id: Icde2be4a881b5e2e06e45a725f6983fe6b280967
Reviewed-on: https://chromium-review.googlesource.com/700495Reviewed-by: Anton Vayvod <avayvod@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506384}

Changes: https://webrtc.googlesource.com/src.git/+log/a9a2771..83ccca1

$ git log a9a2771..83ccca1 --date=short --no-merges --format=%ad %ae %s
2017-10-04 eladalon@webrtc.org Create and use RtcEventLogOutput for output
2017-10-04 alessiob@webrtc.org Allow horizontal scrolling in the APM-QA HTML reports.
2017-10-04 solenberg@webrtc.org Revert "Reland "Remove WEBRTC_TRACE.""
2017-10-04 solenberg@webrtc.org Reland "Remove WEBRTC_TRACE."
2017-10-03 deadbeef@webrtc.org Removing logging in unit test that was committed accidentally.
2017-10-03 deadbeef@webrtc.org Fixing invalid calls to FindMatchingCodec.
2017-10-03 steveanton@webrtc.org Add GetRemoteAudioSSLCertificate() to PeerConnection
2017-10-03 deadbeef@webrtc.org Revert "Run apprtcmobile_tests on real devices."
2017-10-03 deadbeef@webrtc.org Updating comment in Logging.java.
2017-10-03 buildbot@webrtc.org Roll chromium_revision 26bc519a..c5f8071c (506052:506124)
2017-10-03 bpyoung@google.com Enable uploading vertex array with non-zero stride in Android shader.
2017-10-03 buildbot@webrtc.org Roll chromium_revision efe42588..26bc519a (505994:506052)
2017-10-02 flim@webrtc.org Remove memcheck suppression for TestOpusDtx
2017-10-03 alessiob@webrtc.org APM-QA Test data generation: environmental noise looped.
2017-10-03 danilchap@webrtc.org Fix potentional race in AudioSendStream constructor
2017-10-03 nisse@webrtc.org New method RtpReceiver::GetLatestTimestamps.
2017-10-03 ehmaldonado@webrtc.org Disable win_baremetal.
2017-10-03 eladalon@webrtc.org Remove encoding code from RtcEventLogImpl and use RtcEventLogEncoder instead
2017-10-03 ehmaldonado@webrtc.org Revert "Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script."
2017-10-03 eladalon@webrtc.org Create RtcEventLogEncoderLegacy
2017-10-03 solenberg@webrtc.org Revert "Remove WEBRTC_TRACE."
2017-10-03 solenberg@webrtc.org Remove WEBRTC_TRACE.
2017-10-03 ehmaldonado@webrtc.org Reland "Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script."
2017-10-03 ehmaldonado@webrtc.org Revert "Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script."
2017-10-03 ehmaldonado@webrtc.org Run apprtcmobile_tests on real devices.
2017-10-03 buildbot@webrtc.org Roll chromium_revision 624172f8..efe42588 (505968:505994)
2017-10-03 ehmaldonado@webrtc.org Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script.
2017-10-02 eladalon@webrtc.org Add the internals of RtcEvent's subclasses
2017-10-03 nisse@webrtc.org Revert "Make rtc_base/refcount.h self contained, not including refcountedobject.h."
2017-10-03 nisse@webrtc.org Make rtc_base/refcount.h self contained, not including refcountedobject.h.
2017-09-29 magjed@webrtc.org Move list of supported H264 codecs from InternalEncoderFactory to h264.h
2017-09-25 kthelgason@webrtc.org Remove deprecated mac screencapture code.

TBR=hbos@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

Bug: 
Change-Id: I14b7d0cfeaf8522702f163af9cad81b693334fd1
Reviewed-on: https://chromium-review.googlesource.com/700005Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506383}

This matches the behavior on Android and avoids a DCHECK when calculator
matches are produced. It would be better if both platforms used the
calculator-specific icon (looks like an equal sign) but that's only
available as a vector graphic. If we can get a png or start using vector
icons on Android and iOS, we should switch. But for now this is an
improvement.

Bug: 754221
Change-Id: Ie589349e6507b7e0b21896df07b4354e4bc37714
Reviewed-on: https://chromium-review.googlesource.com/699315Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506382}

Considering that PdfMetafileSkia doesn't make any sanity checks here,
creating it from bytes and then pulling those bytes back looks like an
overly complicated no-op

Change-Id: Ie564453318a606d7f71167d0596d44f2a69f589c
Reviewed-on: https://chromium-review.googlesource.com/696202Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506381}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/689bd8a7..b16fa6d2

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I1001ee08e2489938e08d4b3ee39f966dcb39e230
Reviewed-on: https://chromium-review.googlesource.com/700397Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506380}

This allows instantiating OmniboxPopupViewIOS separately, as opposed to
it being a part of OmniboxViewIOS.

Bug: 
Change-Id: I8e26e3d73e4c85b89448c4812eccf3002705a702
Reviewed-on: https://chromium-review.googlesource.com/692015
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506379}

I added ASSERTs to this test in r505630 but none of them tripped and the
test is still flaky. I've replaced the ASSERTS with a new set.

Bug: 769350
Change-Id: Ib4f3819de8e01e346fb1e882fe17b1811e0a30bb
Reviewed-on: https://chromium-review.googlesource.com/698266Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506378}

When a image document is re-parented inside an iframe a race
condition exists between the creation of the
ImageContentResource and the parsing of the document.
ImageDocumentParser::Finish requests the CachedImageSize
which accesses a null image pointer inside the image loader.

Standard behavior for image resources is that they be cleared upon
re-parenting, so enforce that for the ImageContentResource as well.

R=hiroshige@chromium.org
BUG=765917

Change-Id: I93cea9f3eba879abc66d8b8226c3d56a5e02af1b
Reviewed-on: https://chromium-review.googlesource.com/679074Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506377}

This change migrates recording of URLs for
navigation-based source ids from page_load_metrics
to a more general dedicated WebContentsObserver.

The WebContentsObserver can be easily reused in both
unit tests and browser tests.

Bug: 761685
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I3f093dc7e4d2d32c438752371eec5df2e0c58c51
Reviewed-on: https://chromium-review.googlesource.com/648285Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506376}

See https://github.com/w3c/web-platform-tests/pull/7544.

TBR: mkwst@chromium.org

Change-Id: I620980cf9f969045fdcc1eecaffbdec6ec607e07
Reviewed-on: https://chromium-review.googlesource.com/696084Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506375}