- 25 May, 2020 40 commits
-
-
Oleg Davydov authored
This CL combines number of small cosmetic changes: * extensions::InstallationReporter is renamed to extensions::InstallStageTracker as it doesn't report anything by itself, otherwise, different parts of extension installation flow report to it * extensions::InstallationTracker is renamed to extensions::ForceInstalledTracker to reflect what kind of extensions it tracks data of. * extension::InstallationMetrics is renamed to extensions::ForceInstalledMetrics to reflect what kind of extension it reports metrics about. * extensions::ForcedExtensionsInstallationTrackerTest is renamed to extensions::ForceInstalledMetrics test, as it is test for both Tracker and Metrics now, and Metrics class is more specific one. * A couple of unneeded includes are removed. * One stale TODO is removed. * Slightly updated comments to the classes. Bug: 1076159 Change-Id: Ied9252d9277543e8a8d84f67b713cb344d3916d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207462 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771587}
-
Jochen Eisinger authored
Bug: 873178 Change-Id: I6be227d81ccb236eef4e63b2ea242d6221b49298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030950Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#771586}
-
Henry Jian authored
Bug: 1056751 Change-Id: Ifbf0eaed0c6a99725893e798df56298768085474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194071 Commit-Queue: Henry Jian <hzjian@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#771585}
-
Jochen Eisinger authored
Bug: 927509 Change-Id: I56ec8b5cf524a4e1d14b29427931802f80d54a3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132197Reviewed-by:
-
Juanmi Huertas authored
There were some specific web_test expectations that were giving a false error, while the code was behaving as it should have been behaving in all the other cases (not mac). It probably means that at some point a false expectation was uploaded as rebase, and therefore the rebase was broken, not the actual result. Bug: 995142 Change-Id: I5bc2cd80a4c75f5daa10e61f55808c5aba1118ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171596 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#771583}
-
Samuel Huang authored
The following Python functions are directly involved in extracting .info files from .aar: * gn_helpers.py: ToGNString(). * aar.py: _IsManifestEmpty(). * aar.py: _CreateInfo(). We wish to port these files to Google3 to enable .info file extraction (while keeping the Chromium versions around for verification). However, these functions produce many Python lint warnings in Google3. This CL fixes these warnings in Chromium first, and improve comments. Change-Id: I2a826f70ac1d15f2f358195327fd0dd3f12db5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213206Reviewed-by:
-
Julie Jeongeun Kim authored
This CL replaces the PrintHostMsg_CheckForCancel IPC message with a new CheckForCancel Mojo method in the PrintPreviewUI interface. Bug: 1008939 Change-Id: Ic694b892744387bfc0c4c1232ed4b6a9cb1b6388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212181 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#771581}
-
Hans Wennborg authored
To make it harder to forget. Bug: none Change-Id: Iecf97569c56383ade299f264ae0946738e91b60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214884 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#771580}
-
Marina Ciocea authored
PlatformNotificationServiceBrowserTest.TestShouldDisplayFullscreen is flaky on Linux TSan. Bug: 1086169 Change-Id: I919f57ecbcc586f0368553126e54999c582435c8 TBR: peter@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214892Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#771579}
-
Yuki Shiino authored
Calls v8::FunctionTemplate::SetAcceptAnyReceiver(bool) appropriately not only for IDL operations but also IDL attributes (accessor properties). This patch has no behavior change for the current bindings generator, but allows the new bindings generator to control the receiver check. Bug: 839389 Change-Id: Ia7b1817aae46539747d59381cd82c808c5ae5683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212113Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#771578}
-
Takashi Sakamoto authored
Added CanvasMemoryDumpProvider, made CanvasResourceProvider the provider's client, and implemented OnMemoryDump. Since SkSurface has no interface to provide its memory usage, use SkImageInfo::computeBytesSize when allocating memory(not gpu) SkSurface. Change-Id: I51cc40ab472403bb4a1e22fcae3fc6944a5f5a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143178 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#771577}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I54aadee2177b0470a76e909581862c8fe90e5706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212186Reviewed-by:
-
Jan Krcal authored
This CL adds missing error reporting for the wallet_metadata sync type. This brings it on par with how errors are reported for the wallet_data sync type. Bug: 1080844 Change-Id: I05b4482c41221636bd53713aed14d1d4b9fe04db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214888 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#771575}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/da1f4705f664..ec8892b5506b 2020-05-25 pfaffe@chromium.org Fix RTTI Settings in Symbol Server Build If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id69abe033921d4851b0ad45e96dda870f65b03ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214469Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771574}
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. Use cases of this call that ONLY refer to incognito or guest mode can use [Get/Has]PrimaryOTRProfile() instead. Several tests are updated to use the new API. This CL does NOT change any behavior. Bug: 1060940 Change-Id: Ib64d95598959d77cf05f9c2b3beb8fcd8625d779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214388 Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#771573}
-
Dominik Röttsches authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/100d40c827eb..e3af529e511c $ git log 100d40c82..e3af529e5 --date=short --no-merges --format='%ad %ae %s' 2020-05-23 ebrahim [meson] update generated headers only when the result is different 2020-05-23 ebrahim [test] run aat APIs in shape fuzzer 2020-05-23 ebrahim [gdef] minor, use dagger in ligature carets fetch 2020-05-23 ebrahim [tests] some more ligature carets tests 2020-02-26 qxliu [subset] GDEF Variation Store: step 2 do subset based on variation indices collected in step 1 2020-02-26 qxliu [subset] GDEF Variation Store: step 1 closure device variation indexes, create old->new variation idx mapping and store them in subset-plan 2020-05-21 vincent.torri Add shell script and cross-compilation file to compile Harfbuzz with meson 2020-05-21 ebrahim [meson] Fix fix_get_types.py shabang, minor format 2020-05-21 ebrahim [meson] Use find_program for locating python script 2020-05-21 ebrahim [meson] Use a c linker for on Windows also 2020-05-21 ebrahim [meson] Normalize options names 2020-05-21 ebrahim [meson] Add build configuration summary just like autotools 2020-05-21 ebrahim [ci] Install newer meson from pip 2020-05-21 ebrahim [meson] Use / instead join_paths 2020-05-21 ebrahim [meson/ci] Increase cmap fuzzer timeout even more 2020-05-21 ebrahim [meson] Increase timeout in hope to resolve Actions' bot timeout 2020-05-21 ebrahim [ci] Increase timeout as gh bot issue isn't resolved by serial test 2020-05-21 ebrahim [ci] Enable sanitizer bots again 2020-05-21 ebrahim [build] State encoding explicitly for hb-version.h.in 2020-05-21 ebrahim [meson] Use subdir_done to simplify test/api/meson.build 2020-05-21 ebrahim [subset] minor, use a better type in iteration 2020-05-21 ebrahim [meson] Unbreak the build, oops 2020-05-21 ebrahim [meson] Don't run subset tests in parallel 2020-05-21 ebrahim [meson][ci] Don't run subset fuzzer test in parallel 2020-05-21 ebrahim [tests] Enable more gid misc calls on draw fuzzer 2020-05-21 ebrahim Fix _get_ligature_caret's oob read issue 2020-05-21 ebrahim [test] Enable tests fixed by 461cd5a which was regressed by b986fea 2020-04-17 qxliu [subset] GSUB5/GPOS7 Contextual Subst/Pos Subtbale Subsetting support 2020-05-21 ebrahim [tests] Add more tests for _get_ligature_carets 2020-05-20 pipcet minor: fix hb_ot_layout_get_ligature_carets 2020-05-17 tim meson: build documentation with gtk-doc 2020-04-21 ebrahim [meson] Generate harfbuzz.cc, hb-version.h and ragel artifacts 2020-05-16 reiter.christoph meson: error out if introspection is enabled but gobject isn't 2020-04-30 corbett.dav Round-trip OpenType tags through BCP 47 2020-05-15 qxliu [subset] don't use << operator in collect_mapping 2020-05-15 ebrahim [docs] minor update on releasing 2020-05-15 ebrahim [meson] increase subset tests timeout 2020-05-14 behdad [util/hb-view] Add --font-extents 2020-04-01 corbett.dav Update IANA Language Subtag Registry to 2020-05-12 2020-04-22 qxliu [subset] Add support for "--gids" option cmap subsetting now retains entries associated with any glyph ids explicitly requested 2020-05-08 qxliu [subset] fix intersects () for Context/ChainContext tables return true only when all values in array are intersected with input 2020-05-12 ebrahim 2.6.6 2020-05-12 ebrahim [RELEASE] minor update 2020-05-11 khaledhosny [blob] Fix build when HAVE_MMAP is not defined 2020-05-11 ebrahim [cff] remove the not used member 2020-05-11 ebrahim [number] minor 2020-05-10 ebrahim [meson] make -subset target dependent to deps to get libm dependency 2020-05-10 ebrahim [number] Make hb_parse_double simpler now that we don't have to mimic strtod 2020-03-25 ebrahim Remove xlocale use now that isn't available in most distros 2020-05-10 ebrahim [meson] Let name_prefix of exported libraries the default 2020-05-10 ebrahim [meson] specify preferred linker to avoid stdc++ linking 2020-05-10 ebrahim [meson] Reenable make check-symbols compatible with gcov 2020-05-08 khaledhosny [docs] Don’t recommend outdated FDO releases pages 2020-05-07 ebrahim [docs] Simplify logo's SVG source, down scale png version 2020-05-07 ebrahim [ci] disable clang-{everthing,*san} bots 2020-05-07 ebrahim Add a not discardable bool type, hb_success_t 2020-05-06 jfkthame [subset] Check vector resize() call for failure (#2389) 2020-03-15 corbett.dav Update to Unicode 13.0.0 2020-04-29 behdad [vowel-constraints] Simplify generated code 2020-04-01 corbett.dav Recognize Elymaic as a right-to-left script Created with: roll-dep src/third_party/harfbuzz-ng/src R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org Bug: 1071958 Change-Id: I6184f8dc2bbd8ccd1d3a7ac4884f5f86e1766ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214946Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#771572}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/236e0ed83a36..848ea9f0d367 2020-05-25 sprang@webrtc.org Lets PacingController call PacketRouter directly. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie7d4bc39ce8e8bbb314a90d942c173839939011d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214467Reviewed-by:
-
Stephen McGruer authored
This is symptomatic of crbug.com/1047818, but to stop the pain for sheriffs lets mark it timeout=long for now. TBR=lpz@chromium.org Bug: 1085497 Change-Id: Icc9aade41e95f75c2ceda3378b3cbd6b9dfb0deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213407Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#771570}
-
Andrei Salavei authored
Due to code cleanup, |CloudPolicyClient::UploadRealtimeReport| method did not have properly working cancellation logic. Hence after the cancel method call, the corresponding job was keeping running, which could cause to unforceing consequences. Add new cancellable |UploadAppInstallReport| method. Bug: 1061536 Change-Id: Ic6e184d95265b554e788eac27ba6d5e3bbb0ea38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207387 Commit-Queue: Andrei Salavei <solovey@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Victor Hugo Vianna Silva authored
No behavior is changed. This CL introduces a new Polymer behavior responsible for removing a password entry in Settings. In a multi store situation, the behavior would delete all existing versions of the deduplicated entry. The API introduced in crrev.com/c/2199148 for removing batches of passwords is now called, so that undo-ing restores every removed version of the password. <password-list-item> is the only element currently implementing the new RemovePasswordBehavior. Future CLs will extend this behavior to allow choosing which versions to remove, and introduce a new dialog that implements it. Bug: 1049141 Change-Id: Id62eee3dcce3e3a78e4451371a90e324b8095f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209082Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#771568}
-
Leszek Swirski authored
Current work on script streaming (specifically, streaming finalization and off-thread code cache deserialization) has made these histograms interesting again. Bug: chromium:1011762, chromium:1075999 Change-Id: I17d7d967bc588b1a27aae0147a364db07bb0dce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199138 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#771567}
-
Rune Lillesveen authored
There's no need to use a lot of ink for printing dark even if the user has a dark preference for their screen. Bug: 1084465 Change-Id: Ibac200703c4505ed2838c9d40545041ad9609170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214525Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#771566}
-
Andrew Grieve authored
Bug: None Change-Id: I352d059ef8d4103cf0ceb4a742cbeceda1c85c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212475 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#771565}
-
Roman Sorokin authored
Also removed obsolete 'eula-loading' class. Fixed: 1068250 Change-Id: Ib7f1c08da113ba1af7934e12aee7434611f6e957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214528Reviewed-by:
Renato Silva <rrsilva@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771564}
-
Marina Ciocea authored
This reverts commit f0f922f7. Reason for revert: Failing flakily on Linux Chromium OS ASan LSan Tests (1): - https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/37738 - https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/37731 - https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/37729 Original change's description: > Re-enable ChromeVoxBackground*.NavigationSyncSelect > > Mostly speculative; pass with > > testing/xvfb.py out/d/browser_tests --gtest_filter=ChromeVox*.NavigationSyncsSelect > !! & !! & !! & !! & > > TBR=dtseng@chromium.org > > Fixed: 976105 > Change-Id: Ieb646dd0ab22d4b45f2355c89542a59c51af5888 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209684 > Reviewed-by: David Tseng <dtseng@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770789} TBR=dtseng@chromium.org Change-Id: I32c4f0d36e7334cd99e51a25b960d9b56fa32d17 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213524Reviewed-by:
-
Jan Wilken Dörrie authored
The name of the `username_detection_method` variable in form_parser.cc is unnecessarily long for the scope it is defined in and results in unnecessary line breaks (see also go/longnamesarelong). This change fixes this, and also performs a small clean-up on the histogram logging code. Bug: None Change-Id: I72164f113efbdfbd24d42234bd145cc01582d84d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214544 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
(Was reverted because of rebaseline issue) Applying the minimum font-size to the device pixels would not give the expected result, either for using zoom for DSF, or applying page zoom. I added the documentation for the settings based on what I found on stackoverflow: https://stackoverflow.com/questions/52943595/cannot-understand-android-webview-documentation The behavior changes for both the non-"logical" setting in that we will still apply a minimum font-size even if the zoomed font-size would have become larger than the minimum font-size in device-pixels. That is, if we have a minimum font-size of 20px and two elements, one with a 10px font-size and the other with a 20px font-size, they will both be rendered at 40 device pixel size at 200% zoom. This changes the behavior for the logical setting when we have a page zoom factor which is lower than 100%, where we also now just adjust the CSS px font-size before zooming is applied. The logical setting is only exposed via the Android WebView API or via a hand-edited config file. The minimum font-size setting the chrome://settings is the non-"logical" one. If the settings object is null, return the font-size without minimum sizes applied instead of the not-so-useful 1px return we had. TBR=drott@chromium.org,pdr@chromium.org Bug: 1082127 Change-Id: I4fafcbd40331591ade5c0da977150fcbe6d5a3dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214385Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#771561}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c00a59a215e7..728938372b26 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC marinaciocea@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: marinaciocea@google.com Change-Id: I325b9fffb81b732dd2caa08f7bf2920e828dc5e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214993Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771560}
-
Andrei Salavei authored
Focus email input after back button action on EDU and Inline Login sign-in flows. Bug: 1004243 Change-Id: I8021da9d11296040416da2d48a69d0dc136620a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207452Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrei Salavei <solovey@google.com> Cr-Commit-Position: refs/heads/master@{#771559}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590378757-fbe5ba418cc3b4a3b6daa4da92a12bf985342290.profdata to chrome-win32-master-1590407971-070878b52cdd641358380b2e2b381cb8c8d5514d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I378fb7f26dcdab33931f7eeac8ea942e387192ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213815Reviewed-by:
-
Nico Weber authored
It's less code, and the NDK script we used to use prints that we shouldn't use it (see bug). No intended behavior change. Bug: 1085278 Change-Id: I8817ff0234a39f075c5d339e396f216144b875b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212801 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#771557}
-
Alex Ilin authored
In the dark mode, the reauth dialog frame color should match the contents background color, as it does in the light mode. Bug: 1045515 Change-Id: I701e8ece59c9a416f6fd4cf3e1c57e82e418c03e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210502Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771556}
-
Dominique Fauteux-Chapleau authored
This CL makes the FILE_DOWNLOADED Connector replace CheckContentCompliance and SendFilesForMalwareCheck on downloads. This is achieved by replacing CheckClientDownloadRequest::ShouldUploadBinary by CheckClientDownloadRequest::GetAnalysisSettings and passing the returned settings as a parameter to DeepScanningRequest when they are found. This CL does not introduce new tests since this refactor should not affect the behaviour of the previous legacy policies. Once this is submitted, further CLs will reuse download tests with the FILE_DOWNLOADED connector (crbug/1076083). Bug: 1067631 Change-Id: Id66c37b64280f1e482043b8223a72dfd41017147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191205Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#771555}
-
Marina Ciocea authored
This reverts commit a9af8d92. Reason for revert: Test still flakes: https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/34553 Original change's description: > Re-enable AccessibilityFocusHighlightBrowserTest.DrawsHighlight > > It flaked on Mac due to slightly more than 0.01% of pixels in the > page already having the focus highlight color. > > I updated the numbers to be more robust, with more margin for > deviations that will still allow it to pass. By making the > input element taller, that means more pixels get the focus > highlight color. > > Bug: 1083806, 1021939 > Change-Id: I34787ab08eedaaba9dde2cc960b0ab948e711a3d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209683 > Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Chris Hall <chrishall@chromium.org> > Commit-Queue: Chris Hall <chrishall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771512} TBR=dmazzoni@chromium.org,chrishall@chromium.org Change-Id: Ia6a57b4e08cc2341464e2bec788d6a7fe97d4334 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1083806, 1021939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215042Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590392885-f817e2f6c6f861a55dc86221cdd5b022c49b4b4c.profdata to chrome-mac-master-1590407971-3e57b161debb1f13fcdd2d2d0d37a285d980c990.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I7d4df96ccee7732b0a263136d3757efb188c2de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213812Reviewed-by:
-
Anders Hartvoll Ruud authored
This is not marked as a surrogate currently, which means that it won't cascade correctly along with text-orientation in some cases. Change-Id: Ieee83f5176b568c9fbb75b4d6044f266a17357c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210354Reviewed-by:
-
arthursonzogni authored
Compute the sandbox policy of a document in the RenderFrameHost. For now, this is simply used to double check the value computed from the renderer. If this works correctly, the browser process will use it and stop depending on the renderer process. Ideally, this patch must land for M84, in order to get useful reports. This patch is a step in the following direction: ~~ Stop parsing the HTTP CSP sandbox header in blink. Parse it in the network service CSP parser. This allows the browser process to compute the Origin of the new document before loading it. ~~ https://docs.google.com/document/d/1PechV73KKMF8leh7uTlyGkR32kD5qILvu3ZeG8TYGfk/edit?usp=sharing Bug: 1041376 Change-Id: I26d0e3744bc1b5b2d893fd01b6e6ecea35cf47e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190680 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#771551}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b85889d6d5fa..236e0ed83a36 2020-05-25 eshr@google.com Add logging for video restrictions 2020-05-25 danilchap@webrtc.org In media/ and modules/video_coding replace mock macros with unified MOCK_METHOD macro If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0b087ded2cee22fa19d6216869dcac26fa04f688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214992Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3b84585447f1..da1f4705f664 2020-05-25 changhaohan@chromium.org add style tag's media query rule to media query inspector If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1069467 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id84f512f594513503eab6d90a3b9a61766605848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214991Reviewed-by:
-
Kush Sinha authored
- Point *signin_error_notifier*'s per-file OWNERship to OWNERS of Chrome OS Account Manager. - Add anastasiian@ as an OWNER of Chrome OS Account Manager. Change-Id: Ice2e9d8231c6f8cba2f5f6aad408425478b0550f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214944Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#771548}
-
