- 10 Jul, 2017 40 commits
-
-
Eric Roman authored
This replaces use of the deprecated WriteToFileNetLogObserver. It has the advantage of moving file I/O off the calling thread. Bug: 716570 Change-Id: Idac0cec3d1eb59fedc1793e2f60f9244d0324789 Reviewed-on: https://chromium-review.googlesource.com/564074Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485339}
-
parastoog authored
for the admin area drop-down field, show admin areas' complete names rather than codes. - If available, show the names in the device's language, otherwise, show in the default language for that country. Exp: Show Quebec and not QC, and show Québec if the device's language is set to French. - If the name of the admin area for a country is not available, show the admin area code. - Change the unit-tests accordingly. BUG=691643 Review-Url: https://codereview.chromium.org/2966103002 Cr-Commit-Position: refs/heads/master@{#485338}
-
avi authored
BUG=554289 Review-Url: https://codereview.chromium.org/2972773004 Cr-Commit-Position: refs/heads/master@{#485337}
-
Brian Salomon authored
GrBackendTextureDesc is being phased out. Change-Id: Ied5e1edbe2062851ffff2290be52008ee027c3c0 Reviewed-on: https://chromium-review.googlesource.com/563716Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Brian Salomon <bsalomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#485336}
-
Philip Rogers authored
This patch removes the LayerImpl references from DidUpdateScrollOffset. Instead of looking up scroll and transform property nodes with Layers, ElementId is used. The invariant now used in LayerTreeImpl::DidUpdateScrollOffset (and Layer::UpdateScrollOffset) is that a scroll node should exist or the tree should be marked as needing a rebuild which will update the scroll node; there should be no other codepaths that update scroll offset. A TODO has been added to require that a scroll node exists in all cases. Tests have been modified to ensure property trees exist before updating scroll offset. This should be true in all real cases but is not for synthetic testing scenarios. A bug has been fixed in UpdateScrollChildPosition where the scroll layer was not actually scrollable. Bug: Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I75d881a0c05a6fd81ae028bdaead9481641d201f Reviewed-on: https://chromium-review.googlesource.com/560584 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#485335}
-
James Cook authored
For go/mustash we have to use mojo interfaces to communicate between the ash process and chrome browser. Add a mojo method to show the dialog. Migrate code from SystemTrayDelegateChromeOS (deprecated and doesn't exist in mash) and ChromeShellClient (also doesn't exist in mash) into SessionControllerClient. This helps consolidate more session-related code into SessionControllerClient and reduce the size of SystemTrayDelegate. TBR=oshima@chromium.org Bug: 647412 Test: existing ash and chrome tests Change-Id: I1f65f43a4fe668095325ad20c8dc0c201f706321 Reviewed-on: https://chromium-review.googlesource.com/557935Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#485334}
-
Tommy C. Li authored
- Enables on Physical Web - Enables for search suggestions - Disables on all fill_into_edit fields (which shouldn't have these) Bug: 732582 Change-Id: I4828bbf37967f87578a5d48d393b7c0e312a5ecb Reviewed-on: https://chromium-review.googlesource.com/563601 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#485333}
-
Greg Kerr authored
Represents the OS version as a number in sandbox profiles, so it can be compared to with basic equality operations. BUG=689306 Change-Id: I86aca6e1f1919738d2ebcc24b7c9a1d80f9378df Reviewed-on: https://chromium-review.googlesource.com/564057 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#485332}
-
Yuwei Huang authored
Use white status bar color to match the color of other texts. Change-Id: I56ff20106c139b9dbacdbeaad4d1b1f122bfb76c Reviewed-on: https://chromium-review.googlesource.com/564181Reviewed-by:
Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#485331}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2588b89c..edde5168 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I916dc56441f562a6b126e98a5a82c40ca8eabf52 Reviewed-on: https://chromium-review.googlesource.com/565544Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#485330}
-
rnephew authored
Benchmark was acidentally re-enable on android even though it is meant to be a desktop only benchmark. TBR=charliea@chromium.org Bug: 740581, 713222 Change-Id: I59548ffaa2a3a6c5528d2282f23bd16096b41f79 Reviewed-on: https://chromium-review.googlesource.com/565322Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
rnephew <rnephew@chromium.org> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#485329}
-
Yuwei Huang authored
For some reason this gesture makes two-finger pan not quite responsive, while the three-finger pan gesture itself often doesn't respond either. Maybe just disable it for now and see how things work. Change-Id: I015450735e6d0a4f4d671df30b97305798992af8 Reviewed-on: https://chromium-review.googlesource.com/564183Reviewed-by:
-
Benjamin Pastene authored
This includes: sql_unittests ui_touch_selection_unittests vr_common_unittests ui_android_unittests ipc_tests gpu_ipc_service_unittests gl_tests ui_base_unittests capture_unittests media_blink_unittests android_webview_unittests storage_unittests Bug: 670879 Change-Id: Ic6c975e608d440b611bdcb25b65ef038e432ebda Reviewed-on: https://chromium-review.googlesource.com/564139Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#485327}
-
Sadrul Habib Chowdhury authored
BUG=740527 Change-Id: Icd7be15d4b677770d5d4b4910490262d7aba7e9f Reviewed-on: https://chromium-review.googlesource.com/565540 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#485326}
-
dimu authored
- modify chrome/VERSION owner file to stop VERSION updates spamming current owners Bug:739994 R=agable TBR=thakis Change-Id: Ia6474c2ae51c85d53cdc3917c7b4cb8ef8ecee3e Reviewed-on: https://chromium-review.googlesource.com/565739Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Di Mu <dimu@chromium.org> Cr-Commit-Position: refs/heads/master@{#485325}
-
Peter Wen authored
This CL enables webp conversion for SystemWebview. For ChromeModern and Monochrome see: http://crrev.com/c/561578 ChromeModern, Monochrome, and SystemWebview apks all have min sdk version greater than 18. Thus webp is fully supported on those versions and since they are actually all API 21+, optimizations in L, M, and N will be applicable to all devices that receive those apks. This is enabled for all release builds so that if any issues crop up just a simple release build will trigger the conversion. On dev machines it is expected to add about 30 seconds to the overall build time, up to 1 minute if the machine is under load. Bug: 695482 Change-Id: Ifb27fc0d3e015da811a2635358cec336c423a41c Reviewed-on: https://chromium-review.googlesource.com/565542Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#485324}
-
Theresa Wellington authored
BUG=738798 Change-Id: Ic89d30a7ed94e110553712f84b5d02c283522604 Reviewed-on: https://chromium-review.googlesource.com/565341Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#485323}
-
Peter Collingbourne authored
An upcoming version of clang removes the ability to suppress availability warnings by redeclaring functions. This means that any calls to "viewDidLoad" in this code will trigger an availability warning, because that function was added to the API in 10.10. To suppress the warning, rename the function to viewDidLoadImpl and introduce a wrapper function viewDidLoad that calls viewDidLoadImpl. Bug: 735328 Change-Id: Ifcea5787d095601dd621636380770a2c8d7acb59 Reviewed-on: https://chromium-review.googlesource.com/564095 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#485322}
-
Peter Wen authored
This CL enables webp conversion for ChromeModern and Monochrome. SystemWebview will be enabled in: http://crrev.com/c/565542 ChromeModern, Monochrome, and SystemWebview apks all have min sdk version greater than 18. Thus webp is fully supported on those versions and since they are actually all API 21+, optimizations in L, M, and N will be applicable to all devices that receive those apks. This is enabled for all release builds so that if any issues crop up just a simple release build will trigger the conversion. On dev machines it is expected to add about 30 seconds to the overall build time, up to 1 minute if the machine is under load. BUG=695482 Change-Id: Ic4377b9642e09eb1c886626f7750ad00951746e7 Reviewed-on: https://chromium-review.googlesource.com/561578 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#485321}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/72646aa580ee..30c9d9b85571 $ git log 72646aa58..30c9d9b85 --date=short --no-merges --format='%ad %ae %s' 2017-07-10 htwiggsmith Create story tag filter dom module and tests Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I40d4605a7d48e9a749c68b5996f0662299fa3560 Reviewed-on: https://chromium-review.googlesource.com/565326 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485320}
-
Robert Liao authored
On Windows, the background downloader uses the COM Global Interface Table, and Chromium requires these instances to have COM explictly initialized. Using a COM STA TaskRunner works for this case. BUG=739461 Change-Id: I28fdc54af5ec34034498d904bba648fc40c3c2f0 Reviewed-on: https://chromium-review.googlesource.com/562537Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#485319}
-
Steven Bennetts authored
If no ONC values is provided for OpenVPN.RemoteCertKU we need to set the Shill property to an empty string value. Bug: 738119 Change-Id: I3266e0c9f81fea42734e9da7d68df9e268487423 Reviewed-on: https://chromium-review.googlesource.com/558203 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kevin Cernekee <cernekee@chromium.org> Cr-Commit-Position: refs/heads/master@{#485318}
-
Peter Collingbourne authored
An upcoming version of clang removes the ability to suppress availability warnings by redeclaring functions. This means that any calls to "viewDidLoad" in this code will trigger an availability warning, because that function was added to the API in 10.10. To suppress the warning, rename the function to viewDidLoadImpl and introduce a wrapper function viewDidLoad that calls viewDidLoadImpl. Bug: 735328 Change-Id: Ieb806578cc860b483fc75023fb39a7a4af171e14 Reviewed-on: https://chromium-review.googlesource.com/564209Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#485317}
-
Theresa Wellington authored
Changes the location bar translation X when the location bar is RTL, and uses #getLeftPositionOfLocationBarBackground() directly rather than relying on a variable. Previously the variable was set when an #onDraw() called #getLeftPositionOfLocationBarBackground(); this resulted in #updateToolbarButtonVisibility() using a stale value. BUG=740058 Change-Id: I410dd20b7ddb0ff796935e854fd4fbd17b703d37 Reviewed-on: https://chromium-review.googlesource.com/565025Reviewed-by:
-
Peter Collingbourne authored
An upcoming version of clang removes the ability to suppress availability warnings by redeclaring functions. The new way to suppress warnings is to either annotate the caller with an availability attribute or enclose the function reference in an "if (@available)" block. This patch uses @available to protect references to NSWorkspaceAccessibilityDisplayOptionsDidChangeNotification, instead of comparing its address to zero. Bug: 735328 Change-Id: If6f428da62c1486c1d608f0afe5637f9fb2f4e07 Reviewed-on: https://chromium-review.googlesource.com/564151Reviewed-by:
-
Eric Roman authored
This replaces use of the deprecated WriteToFileNetLogObserver. It has the advantage of moving file I/O off the calling thread. Bug: 716570 Change-Id: I89a3c36617c1328f0e64409b341e6483815910f7 Reviewed-on: https://chromium-review.googlesource.com/564341Reviewed-by:
-
Qiang Xu authored
Changes: GestureRecognizerTest has no parameterized tests instantiated. We should remove ::testing::WithParamInterface<bool> inheritence. Bug: none TEST: covered by tests Change-Id: Ibc5701f59d474be1feb336e4ecafcaebf99bf05c Reviewed-on: https://chromium-review.googlesource.com/564094Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#485313}
-
Peter Collingbourne authored
An upcoming version of clang removes the ability to suppress availability warnings by redeclaring functions. The new way to suppress warnings is to either annotate the caller with an availability attribute or enclose the function reference in an "if (@available)" block. Because the type NSVisualEffectView is marked as only available in 10.10 onwards, so must the visualEffectView property in TabWindowController and all other references to NSVisualEffectView. Any code that uses functions on NSVisualEffectView must be protected with @available. Bug: 735328 Change-Id: Ibe1bb965ae93bd0becc24fb90356462b1a26ab86 Reviewed-on: https://chromium-review.googlesource.com/564289Reviewed-by:
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/8fe24272fa6d..5449aade6227 $ git log 8fe24272f..5449aade6 --date=short --no-merges --format='%ad %ae %s' 2017-07-10 fmalita [Reland] More SkColorSpaceXformer caching 2017-07-10 reed don't compose with (forced) opaque colors 2017-07-10 ethannicholas Revert "Make TessellatingPathOp be a non-legacy GrMeshDrawOp" 2017-07-07 iannucci Remove dependency on recipe_engine/shutil. 2017-07-10 ethannicholas Revert "converted GrCircleBlurFragmentProcessor to sksl" 2017-07-07 bsalomon Make TessellatingPathOp be a non-legacy GrMeshDrawOp 2017-07-10 borenet Remove Rietveld stuff from cq.cfg 2017-07-07 csmartdalton Add missing checks for geometry shader stages in GrVkUtil.cpp 2017-07-09 fmalita Revert "More SkColorSpaceXformer caching" 2017-07-07 fmalita More SkColorSpaceXformer caching Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I9b64986d628dee4cb27de0a7e8e58bf4ff411fd6 Reviewed-on: https://chromium-review.googlesource.com/565107Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485311}
-
Anita Woodruff authored
- Previously was using GMock to mock the bridge class that forwards jni calls when creating/deleting/checking site notification channels. - Now there is a very simple fake implementation using an in-memory map from channel origin to NotificationChannel. - This enables more readable tests and will make it easier to write tests in future as the implementation develops. Bug: 700377 Change-Id: I958758c653ca3d83df3e95ad721f66c990fe03ea Reviewed-on: https://chromium-review.googlesource.com/565513 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#485310}
-
Friedrich Horschig authored
This cl complements https://chromium-review.googlesource.com/c/564614/ in that it reenables the baked-in popular sites for iOS. The reason for not reverting the old CL is the includes that were needed to make the presubmit happy. Bug: 737607 Change-Id: I24020f6949aff679bc80a918f61610d32056ceda Reviewed-on: https://chromium-review.googlesource.com/565565Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#485309}
-
kylechar authored
This CL adds a viz_unittests target for testing parts of viz. Remove the tests from components_unittests. Add the viz_unittests to trybots for CrOS, Linux, Windows, Mac and Android. The tests in //components/viz/common:unit_tests are not included on Android because they fail with the test GL implementation. Bug: 722935 Change-Id: Icd1595b745aef1cf87ab6ddbeeb3d16c0c8ec9d0 Reviewed-on: https://chromium-review.googlesource.com/538293 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#485308}
-
mmenke authored
It has two "are"s in a row. BUG=none Review-Url: https://codereview.chromium.org/2976523002 Cr-Commit-Position: refs/heads/master@{#485307}
-
Anthony Berent authored
It is a frequent pattern in tests to start an EmbeddedTestServer before starting a test, and to stop it when the test completes. Simplify this pattern by creating a Junit4 rule for running an EmbeddedTestServer. Change-Id: Ibfdf4c032a0d223c674f09bf847998e62200a6f5 Reviewed-on: https://chromium-review.googlesource.com/548057Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Anthony Berent <aberent@chromium.org> Cr-Commit-Position: refs/heads/master@{#485306}
-
John Abd-El-Malek authored
Change-Id: I9abfb441a9c0de36bc91975b39a5b48568c356a1 Reviewed-on: https://chromium-review.googlesource.com/565543Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#485305}
-
Nicolas Dossou-gbete authored
The repo contains a currently unused preferences screen for the suggestions, that is the only caller of the remote suggestion status methods. This CL marks them as appropriately unreached. The status of the remote suggestions will be used soon to update the UI state, so AreRemoteSuggestionsEnabled is updated in this patch to reflect the accurate status. Bug: 721407,740115 Change-Id: Ia92d85798f96064acc77c9366dafc3daee4ce025 Reviewed-on: https://chromium-review.googlesource.com/563617 Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by:
-
Ingemar Ådahl authored
Merge all resource dependency manifests using the manifest merger from the Android SDK, providing the functionality described in https://developer.android.com/studio/build/manifest-merge.html. Removing the nontrivial manifest guard in the android_aar_prebuilt() template will be done in a follow-up change, as well as removing pre-merged manifest tags, such as "com.google.android.gms.version" meta-data. Bug: 643967 Change-Id: Ifdf9f3f76f5c80f1a2326dcd47045d032556936f Reviewed-on: https://chromium-review.googlesource.com/558296Reviewed-by:
Bo Liu <boliu@chromium.org> Reviewed-by:
-
helenlyang authored
This CL adds TextBadgeView to iOS Showcase. This involves adding a text_badge_view folder to showcase, creating a glue view controller, and modifying the Showcase configuration file and BUILD.gn files as necessary. Since TextBadgeView is currently a stub implementation, Showcase displays a blank white screen. BUG=740133. Review-Url: https://codereview.chromium.org/2967113003 Cr-Commit-Position: refs/heads/master@{#485302}
-
joedow authored
BUG=704216 Review-Url: https://codereview.chromium.org/2936673003 Cr-Commit-Position: refs/heads/master@{#485301}
-
Lucas Furukawa Gadani authored
Bug: 739816 Change-Id: I73ac3e7b68f5918a3f4749896d0ed7cf26d739df Reviewed-on: https://chromium-review.googlesource.com/562856 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#485300}
-
