- 16 Jul, 2014 14 commits
-
-
prasadv@chromium.org authored
Prior to crrev.com/274857 *only* android-chromium-testshell. Then until crrev.com/276628 *both* (android-chromium-testshell and android-chrome-shell) work. After that rev 276628 *only* android-chrome-shell works. bisect-perf-reggresion.py script should handle these cases and set appropriate browser type based on revision. BUG=385324 NOTRY=true Review URL: https://codereview.chromium.org/399463002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283308 0039d316-1c4b-4281-b951-d872f2087c98
-
cjhopman@chromium.org authored
These things should be in a 'variables' block (otherwise they don't do anything). BUG=388270 NOTRY=true Review URL: https://codereview.chromium.org/396823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283306 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
This contains fixes for the following sorts of issues: * Signedness mismatch * Assignment inside conditional * Constant value was truncated * Possibly-uninitialized local variable BUG=81439 TEST=none Review URL: https://codereview.chromium.org/377683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283305 0039d316-1c4b-4281-b951-d872f2087c98
-
smaslo@chromium.org authored
Adds support for allowing users to change the appearance of distilled pages to different themes. The current themes are light, dark and sepia. The theme of the page is controlled by the CSS class of the body element. When the page is loaded, this CSS class is set by inserting the CSS class into the HTML. When a setting is changed while a distilled page is open, the CSS class is set by calling the JavaScript function useTheme which then updates the body element's CSS class. BUG=383630 Review URL: https://codereview.chromium.org/341563002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283303 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
* Fix typo. * Remove unused code. * Move IsFallbackFileBrowserHandler to file_tasks.cc since it is no more specific to fileBrowserHandler. BUG=none Review URL: https://codereview.chromium.org/391873003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283302 0039d316-1c4b-4281-b951-d872f2087c98
-
rob@robwu.nl authored
The previous comment was incorrect. It seems to be a leftover when the flag changed from --enable-shared-worker to --disable-shared-worker in https://codereview.chromium.org/395006. Review URL: https://codereview.chromium.org/378523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283300 0039d316-1c4b-4281-b951-d872f2087c98
-
vsevik@chromium.org authored
Review URL: https://codereview.chromium.org/383123003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283299 0039d316-1c4b-4281-b951-d872f2087c98
-
michaelpg@chromium.org authored
There shouldn't be multiple content-areas housing the link-buttons. See screenshots at http://crbug.com/392347. BUG=392347 R=stevenjb@chromium.org Review URL: https://codereview.chromium.org/376093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283296 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
TBR=brettw@chromium.org BUG=none Review URL: https://codereview.chromium.org/390173002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283295 0039d316-1c4b-4281-b951-d872f2087c98
-
changwan@chromium.org authored
TEST=checked that this works on a test device BUG=384803 Review URL: https://codereview.chromium.org/385963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283294 0039d316-1c4b-4281-b951-d872f2087c98
-
cjhopman@chromium.org authored
This adds support for android resources to gn. Two new templates are introduced: java_string_grd: This is like gyp's build/java_strings_grd.gypi. It runs grit and generates Android strings.xml files and then zips them together. android_resources: This is the target for android resources. It is mostly a wrapper around process_resources.py. This is *not part* of android_library (like it is in gyp). Making these two things separate is more like facebook's BUCK and google's internal build rules (and gyp's java.gypi and java_apk.gypi have gotten way too big and complicated). Changes to the actual build scripts are very minor except for the added support for andoid_resources to write_build_config.py. Building resources requires getting all the transitive resource dependencies, and so this reuses the simple sorted transitive dependency thing from write_ordered_libraries.py. TBR=rch@chromium.org BUG=359249 Review URL: https://codereview.chromium.org/361633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283293 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
R=sky@chromium.org Review URL: https://codereview.chromium.org/388393002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283292 0039d316-1c4b-4281-b951-d872f2087c98
-
noamsml@chromium.org authored
Update simulator to keep up with renames in spec. NOTRY=true BUG= Review URL: https://codereview.chromium.org/395953004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283290 0039d316-1c4b-4281-b951-d872f2087c98
-
mcasas@chromium.org authored
MediaStreamVideoSource owns a VideoTrackAdapter, that sees the frames passing by (possibly adapting frame rate and resolution). This CL extends this VTA to monitor passing frames. Every time the monitoring wakes up, it notifies the MediaStreamVideoSource of the muted state via SetMutedState. This Class has no state, simply updates all registered MediaStreamVideoTracks, who have a muted state. Later CLs will further connect the MSVT::SetMutedState() to ping WebMediaStreamTrack etc. BUG=389159 Review URL: https://codereview.chromium.org/366243003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283285 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Jul, 2014 26 commits
-
-
siggi@chromium.org authored
R=gab@chromium.org,asvitkine@chromium.org TBR=sky@chromium.org BUG=388741 Review URL: https://codereview.chromium.org/385123004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283282 0039d316-1c4b-4281-b951-d872f2087c98
-
hashimoto@chromium.org authored
Only a few provider implementations need this member. BUG=None TEST=build Review URL: https://codereview.chromium.org/388203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283280 0039d316-1c4b-4281-b951-d872f2087c98
-
jsbell@chromium.org authored
Was flaky. Now not flaky? BUG=375856 Review URL: https://codereview.chromium.org/385763002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283278 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
Original review: https://codereview.chromium.org/383083010 R=jamesr@chromium.org TBR=jamesr@chromium.org Review URL: https://codereview.chromium.org/395633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283277 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283276 0039d316-1c4b-4281-b951-d872f2087c98
-
dschuff@chromium.org authored
> NaCl: Update revision in DEPS, r13456 -> r13484 > > This pulls in the following Native Client changes: > > r13457: (dyen) LLVM Regression tests check for build files instead of empty dirs. > r13458: (noelallen) Update and add GN files to build sel_ldr. > r13459: (jvoung) Remove env cleanser references to obsolete env vars. > r13460: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS > r13461: (hamaji) Non-SFI Mode: Add prctl syscall wrapper > r13462: (hamaji) Non-SFI Mode: Implement IRT fstat > r13463: (hamaji) Correct the return type of TestSuite in timefuncs_test > r13464: (hamaji) syscall_test: Do not test st_atime in the test for fstat > r13465: (earthdok) Implement initial MSan support. Also, adjust ASan build flags. > r13466: (dschuff) pnacl-ld: Do not attempt to parse ELF or bitcode files as linker scripts > r13467: (jvoung) Remove NaClSrpcIsStandalone() function. > r13468: (dschuff) Make testing architecture explicit PNaCl toolchain buildbot script > r13469: (dschuff) Stub out pnacl-opt and pnacl-finalize tools for scons built_elsewhere=1 > r13470: (dschuff) Update revision for PNaCl r13392->r13466 > r13471: (noelallen) Build nacl_bootstrap_helper and test with GN scons > r13472: (dschuff) Build PNaCl with mingw again > r13473: (earthdok) Zap the NaClSignalContext struct in SignalCatch. > r13474: (dschuff) Update revision for PNaCl r13466->r13472 > r13475: (sehr) Munge nacl_helper_bootstrap using python rather than libelf > r13476: (sky) Changes scan_sources not to output on bogus directory > r13477: (dschuff) Reduce debugging metadata for pexe builds in Chrome > r13480: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS > r13481: (hidehiko) Align at 16 bytes for stack for created thread. > r13484: (jfb) Revert "Munge nacl_helper_bootstrap using python rather than libelf" > > BUG=none > TEST=browser_tests and nacl_integration > R=jvoung@chromium.org > > Review URL: https://codereview.chromium.org/390553002 TBR=dschuff@chromium.org Review URL: https://codereview.chromium.org/397713006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283275 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283272 0039d316-1c4b-4281-b951-d872f2087c98
-
dschuff@chromium.org authored
This pulls in the following Native Client changes: r13457: (dyen) LLVM Regression tests check for build files instead of empty dirs. r13458: (noelallen) Update and add GN files to build sel_ldr. r13459: (jvoung) Remove env cleanser references to obsolete env vars. r13460: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS r13461: (hamaji) Non-SFI Mode: Add prctl syscall wrapper r13462: (hamaji) Non-SFI Mode: Implement IRT fstat r13463: (hamaji) Correct the return type of TestSuite in timefuncs_test r13464: (hamaji) syscall_test: Do not test st_atime in the test for fstat r13465: (earthdok) Implement initial MSan support. Also, adjust ASan build flags. r13466: (dschuff) pnacl-ld: Do not attempt to parse ELF or bitcode files as linker scripts r13467: (jvoung) Remove NaClSrpcIsStandalone() function. r13468: (dschuff) Make testing architecture explicit PNaCl toolchain buildbot script r13469: (dschuff) Stub out pnacl-opt and pnacl-finalize tools for scons built_elsewhere=1 r13470: (dschuff) Update revision for PNaCl r13392->r13466 r13471: (noelallen) Build nacl_bootstrap_helper and test with GN scons r13472: (dschuff) Build PNaCl with mingw again r13473: (earthdok) Zap the NaClSignalContext struct in SignalCatch. r13474: (dschuff) Update revision for PNaCl r13466->r13472 r13475: (sehr) Munge nacl_helper_bootstrap using python rather than libelf r13476: (sky) Changes scan_sources not to output on bogus directory r13477: (dschuff) Reduce debugging metadata for pexe builds in Chrome r13480: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS r13481: (hidehiko) Align at 16 bytes for stack for created thread. r13484: (jfb) Revert "Munge nacl_helper_bootstrap using python rather than libelf" BUG=none TEST=browser_tests and nacl_integration R=jvoung@chromium.org Review URL: https://codereview.chromium.org/390553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283271 0039d316-1c4b-4281-b951-d872f2087c98
-
raymes@google.com authored
> Hookup the PDF extension to the chrome extensions zoom API > > BUG=303491 > > Review URL: https://codereview.chromium.org/392533002 TBR=raymes@chromium.org Review URL: https://codereview.chromium.org/398643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283269 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=389333 TEST=Manual, see bug. Review URL: https://codereview.chromium.org/335993006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283268 0039d316-1c4b-4281-b951-d872f2087c98
-
sandersd@chromium.org authored
The system headers include visibility attributes, and thus should only be used if the frameworks are linked in. BUG=393439 Review URL: https://codereview.chromium.org/393633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283267 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283266 0039d316-1c4b-4281-b951-d872f2087c98
-
abarth@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178191:178200&mode=html TBR=falken@chromium.org,abarth@chromium.org,eseidel@chromium.org BUG= Review URL: https://codereview.chromium.org/396013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283265 0039d316-1c4b-4281-b951-d872f2087c98
-
sdefresne@chromium.org authored
As a pre-requisite of removing all the CancelableRequestConsumer, add a pointer to a CancelableTaskTracker to AsyncServiceRequest. BUG=371818 Review URL: https://codereview.chromium.org/370613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283264 0039d316-1c4b-4281-b951-d872f2087c98
-
rtenneti@chromium.org authored
Revert of Breakpad for windows - disable DumpProcessWithoutCrash to see if UMA (https://codereview.chromium.org/363203002/) Reason for revert: This change didn't reduce the crash rate. https://codereview.chromium.org/371073003 will generate the crash dumps. Original issue's description: > Breakpad for windows - disable DumpProcessWithoutCrash to see if UMA > crash rate decreases. > > BUG=391165 > R=rsesek@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281320 TBR=rsesek@chromium.org NOTREECHECKS=true NOTRY=true BUG=391165 Review URL: https://codereview.chromium.org/397593005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283263 0039d316-1c4b-4281-b951-d872f2087c98
-
aiolos@chromium.org authored
Step 1) Logic changes in ResourceScheduler::Client. Turns Clients into state machines with possible states of UNTHROTTLED, THROTTLED, COALESCED, and PAUSED. Changes Request throttling behaviors based on Client state, where UNTHROTTLED is the current behavior. Updates Client state based on visibility and audibility, and other input from the ResourceScheduler. Defaults to current behavior in all Clients. Step 2) Logic changes in ResourceScheduler Pipe needed signals between the ResourceScheduler and the Client on: visibility/audibility changes. loading completion. Observable Clients finish loading triggers background clients to load UNTHROTTLED Loading observable Clients triggers all UNTHROTTLED, unobservable clients to load THROTTLED. A request from a non-COALESCED Client, or a heartbeat will trigger Coalesced Clients to load. All requests from a COALESCED Client will coalesce, while non-coalesced clients will not wait for other requests. This will be expanded to listen for network wake ups, but first pass will only take into account the ResourceScheduler network usage. A PAUSED Client will not issue any requests until it transitions into another state. This will be used to limit the number of tabs that are allowed to load at one time. Still defaults to current behavior on all Clients. Step 3) Add the signals for visibility changes, which will turn on throttling. Step 3.5) Add the signals for audibility changes. Step 4) Turn on coalescing. BUG=128035 Review URL: https://codereview.chromium.org/357583003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283259 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
BUILDER object are needed to correctly encode interfaces. Add a dummy object until the real interfaces are pushed to allow using interfaces in structs. BUG=392693 TBR=darin@chromium.org Review URL: https://codereview.chromium.org/398453002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283258 0039d316-1c4b-4281-b951-d872f2087c98
-
mgiuca@chromium.org authored
The banner is now its own view (instead of being painted directly onto the background), and the view paints to a layer, so that it appears on top of other layers such as the WebContents of the custom launcher pages. BUG=393858 Review URL: https://codereview.chromium.org/390273002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283256 0039d316-1c4b-4281-b951-d872f2087c98
-
petewil@chromium.org authored
TBR=falken@chromium.org, michaeln@chromium.org NOTRY=true BUG=393486 Review URL: https://codereview.chromium.org/395983004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283255 0039d316-1c4b-4281-b951-d872f2087c98
-
gcasto@chromium.org authored
It is possible for password_sync_metrics::IsPasswordSyncUsername() to be called during sync setup, which currently causes a stack overflow since GetPasswordSyncUsername() will try to re-initialize sync. Fixed by not checking to see if the user is syncing passwords, just if they have a saved username. This is slightly less specific, but determining if password sync is occuring during setup doesn't seem reasonable. R=isherman@chromium.org TBR=vabr@chromium.org BUG=393626, 386403 Review URL: https://codereview.chromium.org/383083009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283254 0039d316-1c4b-4281-b951-d872f2087c98
-
danakj@chromium.org authored
TBR=vmiura@chromium.org BUG=394083 Review URL: https://codereview.chromium.org/394953003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283252 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
They are doing the same thing as the samely named methods without RegardlessOfStates. BUG=none Review URL: https://codereview.chromium.org/390183006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283249 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283247 0039d316-1c4b-4281-b951-d872f2087c98
-
abarth@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178085:178190&mode=html TBR=falken@chromium.org,abarth@chromium.org,eseidel@chromium.org BUG= Review URL: https://codereview.chromium.org/393023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283246 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
This doesn't eliminate drag-off-side canceling. BUG=388322 TEST=On Linux, visit a page with a scrollbar, drag the scrollbar down, verify it snaps back to the top if you move too far off the side but not if you only move too far directly off the far end Review URL: https://codereview.chromium.org/393723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283244 0039d316-1c4b-4281-b951-d872f2087c98
-
miu@chromium.org authored
The new UI code path for fullscreen is stable, and has been out for several months now. This change removes the command-line flag, and also cleans up the UI code in a few places where a boolean switch is no longer necessary. BUG=256870 TEST=Confirm Flash fullscreen video still works on Aura and Mac, and with/without tab capture engaged. Review URL: https://codereview.chromium.org/386463002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283243 0039d316-1c4b-4281-b951-d872f2087c98
-