- 08 Jul, 2020 40 commits
-
-
Kunihiko Sakamoto authored
In follow-up CLs, this factory will be created by LinkWebBundle, and will be used to load subresources from Web Bundles. Bug: 1082020 Change-Id: I231e8c85f740e3588c2ba4c518378cd26a36a79d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275986Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#786147}
-
Angela Yoeurng authored
The vague BUTTON_FOCUSED selection state was refactored into the more descriptive FOCUSED_BUTTON_FOO states. MaybeTriggerSecondaryButton is also deprecated and unit tests updated. Bug: 1099043 Change-Id: Ib79b829a51552c55349f204fa1702a85317bb803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284384 Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#786146}
-
Jia authored
Our upcoming client has code in src/chromeos/components and cannot depend on local search service that's in src/chrome. Hence we need to move local search service to src/chromeos/components. Some library functions used by local search service are in src/chrome/common/string_matching. This cl moves these functions to src/chromeos/components/string_matching. The next cl will move local search service itself. Bug: 1102232 Change-Id: I3d17b22b918cd3d1c55d40ef4aa6509da6b28957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281798 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#786145}
-
Tsuyoshi Horo authored
testTabNavigationHistoryDoNotLeakBetweenActivities__INCOGNITO_CCT_REGULAR_TAB is flaky TBR=roagarwal@chromium.org,roagarwal@chromium.org,peconn@chromium.org,bsazonov@chromium.org,rhalavati@chromium.org Bug: 1102755 Change-Id: I8deda3ce5feeef1ef07492c099ce7394dbead235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286250 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
Tsuyoshi Horo authored
TBR=asvitkine@chromium.org,treib@chromium.org,caitlinfischer@chromium.org,vincb@chromium.org Bug: 1102747,1102746 Change-Id: I0a778f226ee3ea9ac31c13fcb7dba88019881c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286529 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
Peter Kasting authored
This was the only consumer of it, so this scopes the usage more narrowly. Bug: none Change-Id: I200653b423e6538ee8d0b42a28ea7195853a6c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283401 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#786142}
-
Christopher Cameron authored
TBR=kbr@chromium.org Bug: 1098311 Change-Id: Ib0d18ff93b075e80f63668716a9469dc98e3f183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286050Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#786141}
-
Maggie Chen authored
This reverts commit 14ce0d3e. Reason for revert: <We are going to DumpWithoutCrashing() again and see if we can fix the magic signature at the same time.> Original change's description: > Revert "Update the GPU process termination code in the GPU watchdog." > > This reverts commit d2e5eb35. > > Reason for revert: <This CL changes the magic signatures in the crash report. Now [GPU hang] becomes [Dump without crash]. Also all signatures that used to show in the hanging functions are now combined into one watchdog function DeliberatelyTerminateToRecoverFromHang(). This is not what it is supposed to be in the crash reports.> > > Original change's description: > > Update the GPU process termination code in the GPU watchdog. > > > > Remove the old code "*((volatile int*)0) = 0x1337" so the crash is > > separated from other EXCEPTION_ACCESS_VIOLATION buckets for UMA analysis. > > Use DumpWithoutCrashing() then TerminateProcess instead. > > > > Bug: 949839 > > Change-Id: I29c735aea2d2063043e6a5da80842d62dddf2e34 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940552 > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Will Harris <wfh@chromium.org> > > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > > Commit-Queue: Maggie Chen <magchen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#723219} > > TBR=jam@chromium.org,zmo@chromium.org,wfh@chromium.org,magchen@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 949839 > Change-Id: Ief563313ec634a45f5710ab6ebfa5dacfcf11c72 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962981 > Reviewed-by: Maggie Chen <magchen@chromium.org> > Commit-Queue: Maggie Chen <magchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#724102} TBR=jam@chromium.org,zmo@chromium.org,wfh@chromium.org,magchen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1102672 Change-Id: I4b4b0307181620dff8ca5c8535a1bfb3da53a8a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285769Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786140}
-
Pavel Yatsuk authored
PrivacyWall requested to update their assets (tracked in crbug.com/1100408). This CL makes corresponding changes. BUG=1100408 R=orinj@chromium.org Change-Id: I3e410933c3996fff795ac6230e9bd17e644686a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285871Reviewed-by:
Orin Jaworski <orinj@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#786139}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I2f77959e8b6a961fb6e57d7907488e8b9b605925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286570Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786138}
-
Ovidio Henriquez authored
This change adds a tab indicator that is visible when a Bluetooth scan session is active. A scan session may be started through the Web Bluetooth API's watchAdvertisements() method or through the Web Bluetooth Scanning API's requestLEScan() method. Design Doc: https://docs.google.com/document/d/1h3uAVXJARHrNWaNACUPiQhLt7XI-fFFQoARSs1WgMDM Bug: 1099914 Change-Id: Ieb1bc385b5da6d2c8a98bdf263751fe549c097a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270815 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Carlos Pizano <cpu@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#786137}
-
Peter Kasting authored
This eliminates a virtual method from NonClientFrameView and a dedicated call to it, as well as a WidgetObserver subclass just to monitor this signal. This will be useful in refactoring how Button notifies interested parties of state changes. Bug: None Change-Id: I133f8e6521f33710b6b622f21406abea3693d524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280721Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#786136}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/c9336155e045..09cdba8cd4a6 2020-07-08 mfoltz@chromium.org [Open Screen] Style guide update. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I23569b4c2189b2f1532f39e0a2c9bdefa596d6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285893Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786135}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bb61fe324575..473c9f4cd9b2 2020-07-08 dmazzoni@chromium.org Tagged PDF annotations must appear in the Parent Tree as well. 2020-07-07 nifong@google.com Move frame measurement code into shared location 2020-07-07 bungeman@google.com Mark SkGetThreadID SK_SPI in debug. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1100712 Tbr: mtklein@google.com Change-Id: I877d35949175da79f729aa8cc2f13eb4781f5446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285891Reviewed-by:
-
Yi Xu authored
Added some perf tests to measure speed of clearRect. Bug: 1054666 Change-Id: Id902281ca2c85c2d1ebc89bac05ea4d85d756969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240348Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#786133}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ibd331c6d125bbc684ff5e14d61724aac6f06dd2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286049Reviewed-by:
-
Tsuyoshi Horo authored
This reverts commit 72158dea. Reason for revert: Caused build failure on builder "WebKit Linux Leak" Bug: 1103082 Original change's description: > Fix UAF in SelectType > > This fixes the UAF detected by ClusterFuzz in [1], caused by [2]. > The test case added here is a minimized version of the clusterfuzz > case, and I verified that it crashes (ASAN UAF) before this patch > and no longer crashes after. > > [1] https://clusterfuzz.com/testcase-detail/6224868955193344 > [2] https://chromium-review.googlesource.com/c/chromium/src/+/1912682 > > Fixed: 1102408 > Change-Id: Ieb6a9582ff5b9676596048920bbcff881fdc2eb2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283901 > Commit-Queue: Mason Freed <masonfreed@chromium.org> > Auto-Submit: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#785970} TBR=tkent@chromium.org,masonfreed@chromium.org Change-Id: I5fe02886b22a278ac7ae33b9e63542ec7b3bb10c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286432Reviewed-by:
-
Jing Wang authored
Some details: - Suggestions/settings link will be highlighted when using down/up to navigate - Tab/Right no longer commits suggestions. - If user keeps typing after a suggestion is highlighted, we cancel the highlight. Test: add unit test and tested with Chrome on Linux Bug: 1099498 Change-Id: If890b9d39fa86e55398841c2a8038922d59488f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269157Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#786130}
-
Jarryd authored
Change-Id: I164a3e7233fe2e7d07fc6e5b05adc68b04022ee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285909 Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786129}
-
Rakina Zata Amni authored
The new values for ShouldSwapBrowsingInstance are added in crrev.com/c/2121522, so we need to update the label for the corresponding metric values. See https://source.chromium.org/chromium/chromium/src/+/master:content/browser/frame_host/should_swap_browsing_instance.h;l=14;drc=50d126fbc5e2629e3f2eaf69c2da37b57e118532 Bug: 977562 Change-Id: I1ba5d97d7ea3be23e0ce886f57616d1c1be0cb54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282736Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#786128}
-
Michael Crouse authored
This change prevents LiteVideos from being attempted when the navigation is a reload or forward-back page transition. It also adds an entry for host of the navigation to the user blocklist to allow users to soft opt-out of the optimization if they reload frequently on a host. A future change will clear the blocklist when the browser history is wiped. Bug: 1096796 Change-Id: I687d4c9cd0844d7475f6a3baedacebcf73a48845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276681 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#786127}
-
Josh Simmons authored
Also renaming PerformanceHintsRewriteHandler to RewriteHandler, since the namespace already disambiguates. Change-Id: I9a1575b6990fa9736f47d237a71309fa3a6c55a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276765 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#786126}
-
Nate Fischer authored
This extends Safe Browsing histograms. We still use these histograms periodically to compare WebView and Chrome Safe Browsing behavior, so this extends the histograms one year. This adds WebView team as a second owner. Fixed: 1089421, 1089441 Test: N/A Change-Id: I6ed05b4d1b586a5d210190d6c7f615c6bafb4ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285481 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#786125}
-
Brian Sheedy authored
Removes //third_party/pymock, as all uses in Chromium have switched to the version of mock provided by vpython. Bug: 1094489 Change-Id: Ib9c5083557f4ca98ba5439cb836feaa7f80fabb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285482Reviewed-by:
Sam Clegg <sbc@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#786124}
-
John Lee authored
The decision to automatically close the tab strip when activating a tab was made a long time ago, so these prototyping tools are no longer needed. Change-Id: I048af52b5411a2bdf08a87c098d9e4bded6e8bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285530Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#786123}
-
Wei-Yin Chen (陳威尹) authored
Add RSS fetcher and integrate with the UI. Bug: 1099037 Change-Id: Icc0b391b9720a6622f9f3b4e9874d716cfe33937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266028 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#786122}
-
Kunihiko Sakamoto authored
It was flaky because the path to slow-script.pl was wrong. This narrows the failure expectation only to virtual/synchronous_html_parser, where viewport-dependent preloads don't work because DispatchLinkHeaderPreloads() from HTMLDocumentParser::EnqueueTokenizedChunk() is not called. Bug: 944025,901056 Change-Id: Ib76f9367a1eb5ab73ab1c81e40c60b9e331488e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279295Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b72434f3d312..a0b4571546bb 2020-07-07 rharrison@chromium.org Roll 6 dependencies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I7078dcec9973332c7fcb93519ae37e9a91a0549b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285594Reviewed-by:
-
Andrey Lushnikov authored
Consider the following situation: - We're running Chromium on Mac - There's an open context menu for the browser's page If at this moment we try to close browser programmatically via DevTools protocol, the browser will not close - it'll hang. This happens because: - context menus on mac spawn nested event loops - `RenderViewContextMenuMacCocoa` is destroyed and doesn't exit the run loop This patch cleans up context menu when `RenderViewContextMenuMacCocoa` is destroyed. Change-Id: Ic2f89806954cb5386d530c6e726386ac7f5d513d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285520 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#786119}
-
Clark DuVall authored
This was mostly mechanical, but had to be a little tricker in extension_updater.cc since FetchedCRXFile is no longer copyable when using a OnceCallback. Bug: 1007786 Change-Id: Ifb091f129066ff4e0b5d290a80b53892263d9c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285914Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#786118}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b2dfd8a6ee8c..7cbda52a2db8 2020-07-07 bsheedy@chromium.org [Telemetry] Swap CrOS shutdown order If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1091553 Tbr: eseckler@google.com Change-Id: I9911f6a9fe8d2a4f00c2329197723f16a092ebcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285216Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/81a9074069be..e62496bafc47 2020-07-07 dpranke@google.com Remove Python 3 warning. 2020-07-07 vadimsh@chromium.org [cipd] Always bootstrap mac-amd64, even on arm64. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1102967 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I9862460812e37109577d2219725c350b176ba027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285592Reviewed-by:
-
Erik Staab authored
This reverts commit b9897c33. Reason for revert: This breaks a few waterfall builders. Original change's description: > GN: switch from check_targets to no_check_targets. > > The list was semi-automatically generated by parsing the output of > "gn check" against various configurations. > > With some exceptions, parsing was done using: > grep -E -A1 '(The target:|It is not in)' | grep '//' | \ > grep -v '//build/toolchain' | cut -f1 -d: | sort | uniq -c | \ > sed -e 's/ *\([0-9]*\) *\(.*\)/ "\2:*", # \1 errors/' > > Note: if this breaks the "gn gen" step of a build configuration that > isn't tested in the CQ please add more entries to this .gn file instead > of reverting this CL. > > Bug: 896680 > > Change-Id: I4e3d2b316ec014f969303f7c4bb809e436447b10 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278172 > Commit-Queue: Erik Staab <estaab@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#786102} TBR=dpranke@google.com,estaab@chromium.org Change-Id: I994a4149f38fe00779045612291b0984b95f9075 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286473Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#786115}
-
Mark Pearson authored
about number of lines in various databases Remove sbirch@ as owner. (Not a Chromium contributor; not an appropriate owner.) Add myself as owner. Add sky@ as secondary owner, as sky@ is familiar with these histograms. Extend for a few months. Bug: 1039298,1041513,1043689,1036899 Change-Id: I33c38247d78b3b55c8d8070d0000239ef5743dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285347Reviewed-by:
-
Alexander Cooper authored
The tool currently fails to compile, and is breaking the trybots. Normally, we'd revert the commit that caused this to fail, but this tool is scheduled for deletion in the very near future and currently unused; so fix the bots by stopping building it on them. Change-Id: Ic4e8639c3d2f3f083072dd21ffa8b3d5c7df70ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285225 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#786113}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f6f11215cd93..28159ee9c8e3 2020-07-07 swiftshader.regress@gmail.com Regres: Update test lists @ f6f11215 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Icd6c2200371b7549302af8a0d6ab2ab8417c2308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285315Reviewed-by:
-
Jian Li authored
Bug: none Change-Id: I538d5a32853ea8a62b54f25f9c00c69d12fd53ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278344Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#786111}
-
Kurt Catti-Schmidt authored
This change builds upon the previous work in NGGridLayoutAlgorithm to actually perform measuring on the grid items. The next step in the grid algorithm is to determine track column widths. Since column-widths can be content-based (min-content and max-content), these measurements will be necessary at that point. Much like my previous change, this is validated using unit tests, as we cannot currently test end-to-end grid layout until we have more stages of the grid algorithm completed. Note that percentage resolution is currently incorrect. It will require another layout pass with additional sizing data. This is noted in the incorrect test result. Bug: 1045599 Change-Id: Ic10a8522a16e70792e2299dfe3d8eda0231ff877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257403Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#786110}
-
Matt Menke authored
This reverts commit 341bb752. Reason for revert: This broke the CQ. See: https://ci.chromium.org/p/chromium/builders/try/win-libfuzzer-asan-rel/472138? https://ci.chromium.org/p/chromium/builders/try/linux_chromium_tsan_rel_ng/604561? etc. Main builders also look to be failing. Original change's description: > [Nearby Share] Add ToDictionary, FromDictionary to PrivateCertificate > > ToDictionary and FromDictionary methods convert to/from a Value > dictionary to facilitate storing PrivateCertificates in Prefs. > > Change-Id: I92117836af94cd224eeea34edc7dd55dd3eb7484 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284043 > Reviewed-by: Josh Nohle <nohle@chromium.org> > Commit-Queue: Curt Clemens <cclem@google.com> > Cr-Commit-Position: refs/heads/master@{#786027} TBR=nohle@chromium.org,cclem@google.com Change-Id: I3a840d2bcdc09ff8ac6db1926a1a7339e121ca04 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286470Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#786109}
-
Nate Fischer authored
No change to logic. This swaps "whitelist" for "allowlist" in AwContentCaptureTest and components/content_capture. Fixed: 1101006 Test: run_webview_instrumentation_test_apk -f AwContentCaptureTest.* Change-Id: Id4c4fef7cf82c6b5ac9ba719c2ba46ca9c1b093f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285398 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#786108}
-
