- 17 May, 2019 40 commits
-
-
Wei Li authored
Make the return type of property metadata's getter function to be more flexible so that both returning a value and returning a constant reference of that value are allowed. Also, convert ImageViewBase's accessible_name to a property as an example of such usage. BUG=938501,957272 Change-Id: I8d6adeb9392b06be948b9fcf727b408661791f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615380Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#660883}
-
Maksym Onufriienko authored
Not called navigation_test_util methods directly from EG tests, instead use [ChromeEarlGrey loadUrl], [ChromeEarlGrey loadUrlWithoutWaitingForContent] and [ChromeEarlGrey isLoading]. Also removed unused "ios/chrome/test/app/navigation_test_util.h" imports through EG-tests. This is part of EG1 to EG2 migration, which involves moving EarlGrey code from app-side helpers into test code. For GREYAsserts, the policy is to take assert- containing-helpers, modify them to return NSError* with localizedDescription containing the assert failure (in the event of a failure), and then assert on the result of the helper on the test side. Note. There is a usage of navigation_test_util in ios_internal https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/1240877 will submit it after this cl Bug: 922813 Change-Id: Iafad97e8c0f7904e34a2af3292fbc03dfb505130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590707 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#660882}
-
Ethan Jimenez authored
1. Previously, our implementation of `ExpandToEnclosingUnit` didn't take into account that, since we changed the behavior of text positions to be able to reach the maximum text offset of its anchor, there are multiple text positions that are equal when compared, but are located in different anchors. For example, the end position of an anchor and the start position of the next text anchor. This could get even trickier with empty text anchors between characters in the text representation. Such scenarios are relevant to some assistive technologies since the anchors that the enclosing range spans affect `GetEnclosingElement`, ultimately breaking functions of these ATs. Implementing two new methods `AsPositionBeforeCharacter` and `AsPositionAfterCharacter` in `AXPosition`, which we will use to normalize positions between characters of the text representation. 2. Adding unit tests for both new methods in `AXPositionTest`. 3. Improving `TestITextRangeProviderExpandToEnclosingCharacter` coverage in `AXPlatformNodeTextRangeProviderTest` to check that the enclosing element resolved from the expanded range matches AT expectations. 4. Addressing a bug in `ExpandToEnclosingUnit` where the position at the end of the last anchor of the tree does not expand to the last character of its text representation. Bug: 961893 Change-Id: Ib168d680578a3b460b57b7ca9808987568743a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614940Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#660881}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/0559bc475569..8da525341e22 git log 0559bc475569..8da525341e22 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 capn@google.com Don't process unused texture coordinates Created with: gclient setdep -r src/third_party/swiftshader@8da525341e22 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/129523279 TBR=swiftshader-team+autoroll@google.com Change-Id: Ie58672db2f7fb51925ab71fc81e6f7d11174c040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617708Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660880}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c05031d35df8..c6e50309dcbd Created with: gclient setdep -r src-internal@c6e50309dcbd The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: Id514e3b83611d4f4702be24e2d8979d8f8699b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617553Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660879}
-
Xianzhu Wang authored
This still does *not* cover the following code - hit testing - outlines - painter for legacy inline layout - BoxBackgroundGeometry - multi-column Change-Id: I554e628618fb008655b074ce6723ddd9a97bfbbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608088 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#660878}
-
Henrik Boström authored
It was added to the spec: https://w3c.github.io/webrtc-stats/#dom-rtcoutboundrtpstreamstats-totalpacketsenddelay Bug: webrtc:10506 Change-Id: Ieb4d339490a30b830484e91f519c1fcf0e9544c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617823Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#660877}
-
Xiyuan Xia authored
Use ui::SimpleMenuModel instead of mojo menus in AppListClient and relevant app context menu code. LauncherContextMenu (context menu of shelf items) is unchanged and still uses mojo menus and ui::MenuModel. Deferring that since it might change with shelf mojo changes. Bug: 958134, 958208 Change-Id: I0e798f3b9fd6f7b23b604ff2f421bda8dd9e1485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616161Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#660876}
-
kylechar authored
1. Flaky failures in webgl-compressed-texture-s3tc.html on multiple bots. 2. Consistent failures in conformance/ogles/GL/pow/pow_009_to_016.html and conformance/ogles/GL/pow/pow_017_to_024.html on Win10 NVIDIA GTX 1660 bot. Bug: 964321, 964331 Change-Id: I28d7bead952e0cdd68bd279b966e3afb4a47ff8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617707 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#660875}
-
Rijubrata Bhaumik authored
This CL wires the focus_mode and focus_distance in the GetPhotoState() and SetPhotoOptions() in VideoCaptureDeviceWin. Works with DirectShow backend, so we have to pass --disable-features=MediaFoundationVideoCapture to chrome. Test Page: https://codepen.io/rijuB/pen/BPyWzp or https://riju.github.io/WebCamera/samples/ BUG=732807 Change-Id: Ic8663dc6c676f14a0f9d7361bc5e861bc66bbdd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1314592Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#660874}
-
Tommy Steimel authored
This CL updates the relationship between MediaNotificationItem and MediaNotificationController (now MediaNotificationControllerImpl) such that MediaNotificationItem is only responsible for deciding when to show or hide a media notification, and isn't responsible for how that media notification is displayed. This is done by creating a MediaNotificationController interface that MediaNotificationControllerImpl implements. This CL also updates the relationship of MediaNotificationItem and MediaNotificationView so that MediaNotificationView calls methods on MediaNotificationItem directly instead of calling them through the MediaNotificationController or the message_center::MessageCenter. This is part of a refactoring of the media notification to make it reusable outside of ash/media. Bug: 959478 Change-Id: I77d3f0329f0e8ee32d4cbb79829a0fdf50ac8113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615497Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#660873}
-
Antonio Gomes authored
This reverts commit febfdad1. Reason for revert: gfx::Size isn't actually banned from Blink. This revert keeps it being used for consistency. TBR=guidou@chromium.org Original change's description: > Switch blink::MediaStreamVideoSource away from using gfx::Size > > After MediaStream got OnionSoup'ed, some left banned classes > are still being used, eg gfx::Size. > > This CL switches MediaStreamVideoSource from using ui::gfx::Size > in favor of blink::IntSize. > It also works as a preparation CL to migrates of the use of base::Bind > to WTF::Bind on the same file/class. > > R=jbroman@chromium.org, guidou@chromium.org > CC=blink-reviews-vendor@chromium.org > > BUG=923394 > > Change-Id: I8484fe13c3987fabffe11e9d28eb1782dabb5a7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593530 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#656217} TBR=dgozman@chromium.org,haraken@chromium.org,guidou@chromium.org,tonikitoo@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 923394 Change-Id: Ida0307929f8442e9a12c158debf49ef64da2f8db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596968Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#660872}
-
Koji Ishii authored
This patch fixes NGLineBreaker crash when handling a very long line. Because line breaker determines overflow by the position being larger than the available width, it cannot stop if the available width is |LayoutUnit::Max()|. This patch clamps the available width by |LayoutUnit::NearlyMax()| to prevent that. The `word-wrap: break-word` is not necessary to cause the failure, but it makes things worse by setting |ShapeResult| to |nullptr| when overflow occurs for the performance reason. This patch also changes |BreakText| to return whether the overflow occurred or not, rather than callers to determine it from the position. Doing so helps clearer communication with the callers. Bug: 961987 Change-Id: I17eb758aca8b9b6d3e2f328e5b1b49acb83c0a5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613138 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#660871}
-
Scott Violet authored
While we sort out converting ShelfIntegrationTestApi I'm removing the dependency on services/ws/common/switches. Specifically, ShelfIntegrationTestApi is only exposed if a switched defined in services/ws was supplied. This adds the switch to the ash side in the short term. This also removes some unnecessary includes/deps on services/ws. BUG:960503, 958247 TEST=none Change-Id: Ibcda3b4fa17de19fc2f6382c3df2d8beca9e2aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616784Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#660870}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e5b3e400b6e9..4f71cccb9dc5 git log e5b3e400b6e9..4f71cccb9dc5 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 egdaniel@google.com Appease compilers after swizzle change. 2019-05-17 robertphillips@google.com Add helper method to fill in yuvaIndices given a yuv format 2019-05-17 egdaniel@google.com Add GrCaps call to get swizzle from BackendFormat and ColorType. 2019-05-17 brianosman@google.com Interpreter: Implement ternary operator 2019-05-17 brianosman@google.com Particles + Interpreter: Bind particle's SkRandom to "rand" 2019-05-17 ethannicholas@google.com redesigned SkSL interpreter vector instructions 2019-05-17 aparchur@google.com Apply layer in-point as a negative time-bias for multi-frame image assets. 2019-05-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d61595f367af..ab1e2b49fe88 (8 commits) 2019-05-17 michaelludwig@google.com Remove rounding on explicit clip geometry Created with: gclient setdep -r src/third_party/skia@4f71cccb9dc5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:957946,chromium:423834 TBR=michaelludwig@google.com Change-Id: Iab82a51493f27f64a03379bdbc01ad9645be61c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617682Reviewed-by:
-
Brian White authored
Mark TestStrippingHeadersFromRequestUsingSimpleURLLoaderWithProfileNetworkContext as flaky on ChromeOS. TBR=juncai@chromium.org Bug: 964338 Change-Id: Iac0c9d903a3dac12da4ba534259110a5b971feee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617633 Auto-Submit: Brian White <bcwhite@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#660868}
-
Hongchan Choi authored
By default, the destination node is constructed as stereo. However, AudioDestination creates a resampler with the maximum channel count of the system. So when UA uses an audio device with more than 2 channels does not pass the check in MultiChannelResampler because it expect both to be equal. This patch uses the current channel count instead of the maximum channel count. When channel count changes after the construction, the `channelCount` setter method on a destination note will recreate a platform destination with a new channel count. Bug: 962989 Test: Locally verified with multichannel audio device (8ch) Change-Id: I4f586ec8b37c7c9063244abec38dd48e4e36193e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615830 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#660867}
-
Vladimir Levin authored
This patch adds size containment implementation for fieldsets in LayoutNG. Tested with LayoutNGFieldset feature flag. Along with the new tests, external/wpt/css/css-contain/contain-size-fieldset-001.html and external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-fieldset-001.html are also passing. R=chrishtr@chromium.org, ikilpatrick@chromium.org, mstensho@chromium.org Bug: 958975 Change-Id: I5e735adc65ed9450f84e4c1ab68cba69e3fd85ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613844Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#660866}
-
Sadrul Habib Chowdhury authored
All GLSurfaces now support presentation-callbacks. So remove GLSurface::SupportsPresentationCallback(). TBR=boliu@ for API updates in android_webview/ BUG=883592 Change-Id: I05cecb9c90a0a412615a251936f011e277b31c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617542 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#660865}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/867bf9d35a9f..23e25e0bb4dc git log 867bf9d35a9f..23e25e0bb4dc --date=short --no-merges --format='%ad %ae %s' 2019-05-17 evanhernandez@chromium.org tree_status: Nuke. Created with: gclient setdep -r src/third_party/chromite@23e25e0bb4dc The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ic3fc0f918590ca7d35a1c8834ff5ef5c6cb27732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617130Reviewed-by:
-
Jun Mukai authored
Bug: 958467 Test: trybot Change-Id: I8a85cdeb51412becc9353123a109f50c74d11950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615711Reviewed-by:
-
Jun Mukai authored
Bug: 958467 Test: trybot Change-Id: I163739c1acb5377a6ed19643287a6cd01b3d0ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614704Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#660862}
-
Andrew Grieve authored
This reverts MinidumpUploadCallable.java in 398ed50f. Reason for revert: Breaking crash uploads Original change's description: > Android: Add FileUtils.copyStream() and FileUtils.readStream() > > And also make use of existing FileUtils functions in a couple > spots. This is mostly a no-behavior-change clean-up. > > Behavior changes: > * Also removes a useless Trace event from ResourceExtractor. > * FileUtils.recursivelyDeleteFile() now succeeds if the file > didn't exist to start with and has a return value. > * MinidumpUploadCallable now makes an extra copy of the response > data (choosing code simplicity of performance for crash logic). > > Change-Id: I367d385e397f48d40ff0a7f9a01e2d661a7def64 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604187 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659827} TBR=torne@chromium.org,tedchoc@chromium.org,agrieve@chromium.org Bug: 964334 Change-Id: I73a23d193f093d6afaef1c8abed4b8904e2b5b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617549 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#660861}
-
Johannes Henkel authored
New Revision: 0aafd2876f7485db7b07c513c0457b7cbbbe3304 https://chromium.googlesource.com/deps/inspector_protocol/+/0aafd2876f7485db7b07c513c0457b7cbbbe3304 Change-Id: Ib7597e9edb2d665ef13cffe0d055f7a968a56f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616521Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#660860}
-
Avi Drissman authored
The new bundle structure moves the Chromium Framework into a top-level Frameworks directory (see https://crbug.com/958976). This requires new app shim code to locate the Chromium Framework when launching. App shims function by doing a dlopen on the Chromium Framework and jumping into an entrypoint. While this change alters how that framework is found, it does not change the functionality of that launch. Because the value of kCurrentAppShortcutsVersion is incremented, the AppShortcutManager will automatically rebuild all existing app shortcuts. Therefore, no merge is strictly required, as the first launch of Chromium will cause all existing app shims to be rebuilt. However, because there is a window during which a launch of an old shim will fail (from the update of Chromium to a version with the new bundle structure to the first launch of that Chromium) it might be worth a merge to have the shims rebuilt in preparation. BUG=960886 Change-Id: Ia6f6914c9d6685e15323cae0905bccce8dcbee4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607604 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#660859}
-
Matt Menke authored
iOS doesn't seem to be using URLFetcher to fetch account information, so remove iOS code to mock out URLFetcher responses. Bug: None Change-Id: I703d71c11decf168541c1181b7836000ef80d129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611868 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Mohamed Heikal authored
If in reduced mode, we cannot create PrefetchGCMAppHandler. Instead we pass the prefetch service a closure to create the gcm app handler on demand. This cl also changes the signature of the getter for PrefetchGCMHandler in PrefetchService to require a profile to be passed in. This ensures that: 1) the getter can only be called in full browser mode (there is no profile in reduced mode). 2) if PrefetchGCMHandler hadn't been created yet, then it can be created on demand using the aforementioned profile. > This is a reland, Original CL: > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495737 This reverts commit a59ecdc7. Reason for reland: Fixed CQ tests being slow by mocking out InstanceIDAndroid during tests. This reland also moves away from deprecated call to PostAfterStartupTask. Bug: 934337, 963688 Change-Id: I8d57b1f96f0b6152ba3271a9a7ef7e023f5f6988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613672 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#660857}
-
Ryan Hansberry authored
This method was only defined and used within the impl class, EasyUnlockServiceRegular. This change also improves the documentation around this method and the similar GetRemoteDevices. Bug: 959016 Change-Id: Idf849b79a1a249def3f375ae7384b19e6b4e61ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594067 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#660856}
-
chrome://webrtc-internalsHenrik Boström authored
Adds these calculated graphs: - [targetEncodedBytes/s]: Multiplies the average target bytes per frame (=delta totalEncodedBytesTarget/delta framesEncoded) by the average encode frame rate (=delta framesEncoded/delta timestamp) to estimate what bytesSent/s should be if the target was achieved. This graph can be compared with the actual bytesSent/s to see if the encoder over- or undershoots its target. - [totalEncodeTime/framesEncoded_in_ms]: The average encode time per frame, in milliseconds. Bug: webrtc:10446 Change-Id: I14c0fc7736fd6b48f073e3e4b6217de5afd3f049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615742Reviewed-by:
-
Tanya Gupta authored
This CL is one of many to come. It covers: * Creation of the infobar from the SendTabToSelfInfoBarController * Plumbed the call to create the infobar to the native code. * Open the link when user taps on the link In follow-up CLs, the following will be done: * Instantiate the InfobarController in the ChromeActivity * Listen for Model changes in the Controller Bug: 949233,963193 Change-Id: I5df1359debb5f0f35c32c2df3b691bf9129cdeb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604406Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#660854}
-
Maksim Moskvitin authored
Explicit passphrase means either CUSTOM_PASSPHRASE or FROZEN_IMPLICIT_PASSPHRASE passphrase types. This CL contains logic required for MergeSyncData()/ApplySyncChanges() methods to work with explicit passphrase types. It includes validation of received NigoriSpecifics and support for following fields: - passphrase_type - custom_passphrase_time - keystore_migration_time (used instead of custom_passphrase_time if passphrase type is FROZEN_IMPLICIT_PASSPHRASE) - encrypt_everything Note: currently there is no way to set custom passphrase or to decrypt the data encrypted with explicit passphrase in USS implementation of Nigori. We only update local state and notify observers about encryption state changes. Bug: 922900 Change-Id: Ib27169259772f0528d765c10de9a40a5ebd9f235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613059 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
chrome://webrtc-internalsHenrik Boström authored
When https://webrtc-review.googlesource.com/c/src/+/137044/ lands, this will show the packet average send-side delay over the last second as a graph in chrome://webrtc-internals. Verified manually. Bug: webrtc:10506 Change-Id: Icade78b31ed37509e8769b6b9b9c4b89447c619a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615144Reviewed-by:
-
Elly Fong-Jones authored
This change removes the flag only; the backing feature is still present because it is being used for some experimentation (or will be in future). Bug: None Change-Id: I9f083ea5beac6086cd881653c4d444fc24f1412c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617627 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
Now this is the same with linux-rel and corresponding CI builder/tester. I will remove recipes later. Bug: 964197 Change-Id: I58e82885d341d4447523da33e5fa3450906438e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616706 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#660850}
-
Kevin McNee authored
This was recently re-enabled as one source of flakiness was fixed, but this test is still flaky for another reason; it seg faults in chromeos::UserSessionManager::InitializeBrowser. We disable this test again. Tbr: alemate@chromium.org Bug: 961607, 964333 Change-Id: I3bc48798afabfbe004173b5faf9ad810be5bdff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617377Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#660849}
-
Jordan Demeulenaere authored
This is a reland of 3618cb02 Original change's description: > Autofill Assistant dependencies are now deps instead of classpath_deps. > > Bug: 951489 > Change-Id: I6959c83313aef83976910a56e7c198bcb98d50ea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613077 > Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Auto-Submit: Jordan Demeulenaere <jdemeulenaere@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660769} Bug: 951489 Change-Id: I0003f33665041536a96318825f794b4e73ab3ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617356Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#660848}
-
David Roger authored
On some platforms (windows in particular), the installer may create a preference file in the profile directory, before the profile is created. This happens in first_run::ProcessMasterPreferences(). In this case, when the profile is created, the preference file is found and the profile is assumed to not be new. As a result, all the code that is intended to be called for new profiles is bypassed, which leaves the profile in a bad state. Bug: 728402, 959188, 145351 Change-Id: Ibfeeebbb72893cc48095ce810d8300718dc24e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614207Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#660847}
-
Xianzhu Wang authored
Bug: 963782 Change-Id: I8c6faf984321c38765357bf613bdb27a71c282bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616445Reviewed-by:
-
Rohit Rao authored
This defaults to NSObject, but can be set to a class that implements the XCTestObservation protocol to perform one-time setup in XCTest bundles. BUG=None Change-Id: I3ff7abbf928a16ce6626fc99ed8fd747902cc791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617623Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#660845}
-
Tim Volodine authored
Add UMA to record invocation counts for some network related callbacks: - onReceivedLoginRequest - onReceivedClientCertRequest - onReceivedHttpAuthRequest - onDownloadStart These are non-error callbacks, so there is no need to have separate histograms with error code distributions. BUG=841556,951885,945922 Change-Id: I88be3ca2dfd831b83099bdbf44ece885b9acad18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609708 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#660844}
-
